[Impala-ASF-CR] [Preview]IMPALA-5216: Make admission control queuing async

2018-04-24 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10060 to look at the new patch set (#3). Change subject: [Preview]IMPALA-5216: Make admission control queuing async ..

[Impala-ASF-CR] [Preview]IMPALA-5216: Make admission control queuing async

2018-04-25 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10060 to look at the new patch set (#4). Change subject: [Preview]IMPALA-5216: Make admission control queuing async ..

[Impala-ASF-CR] IMPALA-6679,IMPALA-6678: reduce scan reservation

2018-04-25 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9757 ) Change subject: IMPALA-6679,IMPALA-6678: reduce scan reservation .. Patch Set 10: Code-Review+2 (9 comments) Just a few nits. Carryin

[Impala-ASF-CR] [Preview]IMPALA-5216: Make admission control queuing async

2018-05-01 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: [Preview]IMPALA-5216: Make admission control queuing async .. Patch Set 4: (6 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-01 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10060 to look at the new patch set (#5). Change subject: IMPALA-5216: Make admission control queuing async ..

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-07 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10060 to look at the new patch set (#6). Change subject: IMPALA-5216: Make admission control queuing async ..

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-07 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 ) Change subject: IMPALA-5216: Make admission control queuing async .. Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] IMPALA-5216: Make admission control queuing async

2018-05-07 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10060 to look at the new patch set (#7). Change subject: IMPALA-5216: Make admission control queuing async ..

[Impala-ASF-CR] IMPALA-6970: race with decreasing scanner reservation

2018-05-07 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10314 ) Change subject: IMPALA-6970: race with decreasing scanner reservation .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-6227: reduce window of metric inconsistency

2018-05-07 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10330 ) Change subject: IMPALA-6227: reduce window of metric inconsistency .. Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.

[Impala-ASF-CR] PREVIEW - IMPALA-6957: calc thread resource requirement in planner

2018-05-07 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10256 ) Change subject: PREVIEW - IMPALA-6957: calc thread resource requirement in planner .. Patch Set 4: (2 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-6227: reduce window of metric inconsistency

2018-05-08 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10330 ) Change subject: IMPALA-6227: reduce window of metric inconsistency .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-8092: Add an admission controller debug page

2019-01-18 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12244 Change subject: IMPALA-8092: Add an admission controller debug page .. IMPALA-8092: Add an admission controller debug page This patch

[Impala-ASF-CR] IMPALA-7565: Set TAcceptQueueServer connection setup pool to be multi-threaded by default

2019-01-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12249 Change subject: IMPALA-7565: Set TAcceptQueueServer connection_setup_pool to be multi-threaded by default .. IMPALA-7565: Set TAcceptQ

[Impala-ASF-CR] IMPALA-7941: part 1: detect cgroups memory limit

2019-01-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12120 ) Change subject: IMPALA-7941: part 1: detect cgroups memory limit .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/12

[Impala-ASF-CR] IMPALA-7941: part 1: detect cgroups memory limit

2019-01-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12120 ) Change subject: IMPALA-7941: part 1: detect cgroups memory limit .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-8092: Add an admission controller debug page

2019-01-23 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12244 ) Change subject: IMPALA-8092: Add an admission controller debug page .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-8092: Add an admission controller debug page

2019-01-24 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12244 ) Change subject: IMPALA-8092: Add an admission controller debug page .. Patch Set 1: (18 comments) Please let me know if you have any

[Impala-ASF-CR] IMPALA-8092: Add an admission controller debug page

2019-01-24 Thread Bikramjeet Vig (Code Review)
Hello Pooja Nilangekar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12244 to look at the new patch set (#2). Change subject: IMPALA-8092: Add an admission controller debug page ...

[Impala-ASF-CR] IMPALA-8092: Add an admission controller debug page

2019-01-25 Thread Bikramjeet Vig (Code Review)
Hello Pooja Nilangekar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12244 to look at the new patch set (#3). Change subject: IMPALA-8092: Add an admission controller debug page ...

[Impala-ASF-CR] IMPALA-8092: Add an admission controller debug page

2019-01-25 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12244 ) Change subject: IMPALA-8092: Add an admission controller debug page .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-7941: part 2/2: use cgroups memory limit

2019-01-25 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12262 ) Change subject: IMPALA-7941: part 2/2: use cgroups memory limit .. Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-7941: part 2/2: use cgroups memory limit

2019-01-25 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12262 ) Change subject: IMPALA-7941: part 2/2: use cgroups memory limit .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-8092: Add an admission controller debug page

2019-01-29 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12244 ) Change subject: IMPALA-8092: Add an admission controller debug page .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-8092: Add an admission controller debug page

2019-01-29 Thread Bikramjeet Vig (Code Review)
Hello Pooja Nilangekar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12244 to look at the new patch set (#4). Change subject: IMPALA-8092: Add an admission controller debug page ...

[Impala-ASF-CR] IMPALA-6932: Speed up scans for sequence datasets with many files

2019-01-30 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11517 ) Change subject: IMPALA-6932: Speed up scans for sequence datasets with many files .. Patch Set 4: Code-Review+2 Carrying forward Lar

[Impala-ASF-CR] IMPALA-8092: Add an admission controller debug page

2019-01-30 Thread Bikramjeet Vig (Code Review)
Hello Pooja Nilangekar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12244 to look at the new patch set (#5). Change subject: IMPALA-8092: Add an admission controller debug page ...

[Impala-ASF-CR] IMPALA-8092: Add an admission controller debug page

2019-01-30 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12244 ) Change subject: IMPALA-8092: Add an admission controller debug page .. Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-8092: Add an admission controller debug page

2019-01-31 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12244 ) Change subject: IMPALA-8092: Add an admission controller debug page .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-8092: Add an admission controller debug page

2019-01-31 Thread Bikramjeet Vig (Code Review)
Hello Pooja Nilangekar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12244 to look at the new patch set (#6). Change subject: IMPALA-8092: Add an admission controller debug page ...

[Impala-ASF-CR] IMPALA-7565: Set TAcceptQueueServer connection setup pool to be multi-threaded by default

2019-02-01 Thread Bikramjeet Vig (Code Review)
Hello Michael Ho, Thomas Marshall, Zoram Thanga, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12249 to look at the new patch set (#2). Change subject: IMPALA-7565: Set TAcceptQueueServer connection_setup_pool to be multi-threaded b

[Impala-ASF-CR] IMPALA-7565: Set TAcceptQueueServer connection setup pool to be multi-threaded by default

2019-02-04 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12249 ) Change subject: IMPALA-7565: Set TAcceptQueueServer connection_setup_pool to be multi-threaded by default .. Patch Set 3: (2 comment

[Impala-ASF-CR] IMPALA-8162: Add memory reserved and admitted to the backends debug page

2019-02-04 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12364 Change subject: IMPALA-8162: Add memory reserved and admitted to the backends debug page .. IMPALA-8162: Add memory reserved and admit

[Impala-ASF-CR] IMPALA-8162: Add memory reserved and admitted to the backends debug page

2019-02-05 Thread Bikramjeet Vig (Code Review)
Hello Pooja Nilangekar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12364 to look at the new patch set (#2). Change subject: IMPALA-8162: Add memory reserved and admitted to the backends debug page .

[Impala-ASF-CR] IMPALA-8162: Add memory reserved and admitted to the backends debug page

2019-02-05 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12364 ) Change subject: IMPALA-8162: Add memory reserved and admitted to the backends debug page .. Patch Set 1: (9 comments) http://gerrit

[Impala-ASF-CR] IMPALA-8096: Add rows returned limit per query

2019-02-06 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12328 ) Change subject: IMPALA-8096: Add rows returned limit per query .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/1232

[Impala-ASF-CR] IMPALA-8096: Add rows produced limit per query

2019-02-06 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12328 ) Change subject: IMPALA-8096: Add rows produced limit per query .. Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-8172: [DOCS] Documented the NUM ROWS PRODUCED LIMIT query option

2019-02-07 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12396 ) Change subject: IMPALA-8172: [DOCS] Documented the NUM_ROWS_PRODUCED_LIMIT query option .. Patch Set 1: Code-Review+1 -- To view, v

[Impala-ASF-CR] IMPALA-8064: Improve observability of wait times for runtime filters

2019-02-08 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12401 ) Change subject: IMPALA-8064: Improve observability of wait times for runtime filters .. Patch Set 1: (2 comments) http://gerrit.clo

[Impala-ASF-CR] IMPALA-5043: diagnostics for topic staleness in AC

2019-02-08 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12407 ) Change subject: IMPALA-5043: diagnostics for topic staleness in AC .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-5043: diagnostics for topic staleness in AC

2019-02-08 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12407 ) Change subject: IMPALA-5043: diagnostics for topic staleness in AC .. Patch Set 4: Code-Review+2 (2 comments) LGTM, i ll leave addre

[Impala-ASF-CR] IMPALA-5043: diagnostics for topic staleness in AC

2019-02-08 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12407 ) Change subject: IMPALA-5043: diagnostics for topic staleness in AC .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] IMPALA-8064: Improve observability of wait times for runtime filters

2019-02-11 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12401 ) Change subject: IMPALA-8064: Improve observability of wait times for runtime filters .. Patch Set 2: (2 comments) http://gerrit.clo

[Impala-ASF-CR] IMPALA-8064: Improve observability of wait times for runtime filters

2019-02-11 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12401 ) Change subject: IMPALA-8064: Improve observability of wait times for runtime filters .. Patch Set 2: (1 comment) http://gerrit.clou

[Impala-ASF-CR] IMPALA-8064: Improve observability of wait times for runtime filters

2019-02-11 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12401 ) Change subject: IMPALA-8064: Improve observability of wait times for runtime filters .. Patch Set 2: Code-Review+2 -- To view, visi

[Impala-ASF-CR] IMPALA-8064: Improve observability of wait times for runtime filters

2019-02-11 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12401 ) Change subject: IMPALA-8064: Improve observability of wait times for runtime filters .. Patch Set 2: @Pooja Please make sure you add

[Impala-ASF-CR] IMPALA-8064: Improve observability of wait times for runtime filters

2019-02-11 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12401 ) Change subject: IMPALA-8064: Improve observability of wait times for runtime filters .. Patch Set 3: Totally forgot about testing, d

[Impala-ASF-CR] IMPALA-8064: Improve observability of wait times for runtime filters

2019-02-11 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12401 ) Change subject: IMPALA-8064: Improve observability of wait times for runtime filters .. Patch Set 3: Code-Review+2 > > Patch Set 3:

[Impala-ASF-CR] [DOCS] Updated the description of the port number parameter in SHUTDOWN

2019-02-21 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12550 ) Change subject: [DOCS] Updated the description of the port_number parameter in SHUTDOWN .. Patch Set 1: (9 comments) http://gerrit.

[Impala-ASF-CR] [DOCS] Updated the description of the port number parameter in SHUTDOWN

2019-02-21 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12550 ) Change subject: [DOCS] Updated the description of the port_number parameter in SHUTDOWN .. Patch Set 2: (2 comments) http://gerrit.

[Impala-ASF-CR] [DOCS] Updated the description of the port number parameter in SHUTDOWN

2019-02-21 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12550 ) Change subject: [DOCS] Updated the description of the port_number parameter in SHUTDOWN .. Patch Set 3: Code-Review+2 -- To view, v

[Impala-ASF-CR] IMPALA-8064: Increase RUNTIME FILTER WAIT TIME MS for slow builds

2019-02-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12560 ) Change subject: IMPALA-8064: Increase RUNTIME_FILTER_WAIT_TIME_MS for slow builds .. Patch Set 1: (1 comment) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-8064: Increase RUNTIME FILTER WAIT TIME MS for slow builds

2019-02-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12560 ) Change subject: IMPALA-8064: Increase RUNTIME_FILTER_WAIT_TIME_MS for slow builds .. Patch Set 2: (1 comment) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-8064: Increase RUNTIME FILTER WAIT TIME MS for slow builds

2019-02-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12560 ) Change subject: IMPALA-8064: Increase RUNTIME_FILTER_WAIT_TIME_MS for slow builds .. Patch Set 2: Code-Review+2 (1 comment) http://

[Impala-ASF-CR] IMPALA-5397: Set query's end time us when the operation completes

2019-02-26 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12583 ) Change subject: IMPALA-5397: Set query's end_time_us_ when the operation completes .. Patch Set 1: (3 comments) http://gerrit.cloud

[Impala-ASF-CR] Bump debug web page header size to prevent wrapping

2019-02-27 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12596 ) Change subject: Bump debug web page header size to prevent wrapping .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-5397: Set query's end time us when the operation completes

2019-02-27 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12583 ) Change subject: IMPALA-5397: Set query's end_time_us_ when the operation completes .. Patch Set 6: (2 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-5397: Set query's end time us when the operation completes

2019-02-27 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12583 ) Change subject: IMPALA-5397: Set query's end_time_us_ when the operation completes .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8153: [DOCS] Admission Control page added to web ui

2019-03-04 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12645 ) Change subject: IMPALA-8153: [DOCS] Admission Control page added to web ui .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-8153: [DOCS] Admission Control page added to web ui

2019-03-05 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12645 ) Change subject: IMPALA-8153: [DOCS] Admission Control page added to web ui .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-8153: [DOCS] Admission Control page added to web ui

2019-03-05 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12645 ) Change subject: IMPALA-8153: [DOCS] Admission Control page added to web ui .. Patch Set 4: Code-Review+2 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-8202: Add more logging to TestAdmissionControllerStress

2019-03-21 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12829 Change subject: IMPALA-8202: Add more logging to TestAdmissionControllerStress .. IMPALA-8202: Add more logging to TestAdmissionControl

[Impala-ASF-CR] IMPALA-6852: Add a section to the query profile covering number of fragments instances and total bytes scanned per host

2019-03-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12831 ) Change subject: IMPALA-6852: Add a section to the query profile covering number of fragments instances and total bytes scanned per host ...

[Impala-ASF-CR] IMPALA-6852: Add number of fragment instances per host to query profile

2019-03-22 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12831 ) Change subject: IMPALA-6852: Add number of fragment instances per host to query profile .. Patch Set 2: Code-Review+2 -- To view, v

[Impala-ASF-CR] IMPALA-7031: Cancel action of debug page should not unregister query

2019-04-09 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12926 ) Change subject: IMPALA-7031: Cancel action of debug page should not unregister query .. Patch Set 4: (10 comments) http://gerrit.cl

[Impala-ASF-CR] IMPALA-8401: SIGQUIT initiates the graceful shutdown process

2019-04-09 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12973 Change subject: IMPALA-8401: SIGQUIT initiates the graceful shutdown process .. IMPALA-8401: SIGQUIT initiates the graceful shutdown pr

[Impala-ASF-CR] IMPALA-8224: [DOCS] Add the missing contents about Impala web UI pages

2019-04-10 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12934 ) Change subject: IMPALA-8224: [DOCS] Add the missing contents about Impala web UI pages .. Patch Set 2: (3 comments) http://gerrit.c

[Impala-ASF-CR] IMPALA-8224: [DOCS] Add the missing contents about Impala web UI pages

2019-04-10 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12934 ) Change subject: IMPALA-8224: [DOCS] Add the missing contents about Impala web UI pages .. Patch Set 3: (2 comments) http://gerrit.c

[Impala-ASF-CR] IMPALA-8224: [DOCS] Add the missing contents about Impala web UI pages

2019-04-10 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12934 ) Change subject: IMPALA-8224: [DOCS] Add the missing contents about Impala web UI pages .. Patch Set 4: Code-Review+2 -- To view, vi

[Impala-ASF-CR] IMPALA-8401: SIGRTMIN initiates the graceful shutdown process

2019-04-10 Thread Bikramjeet Vig (Code Review)
Hello Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12973 to look at the new patch set (#2). Change subject: IMPALA-8401: SIGRTMIN initiates the graceful shutdown process ..

[Impala-ASF-CR] IMPALA-8401: SIGRTMIN initiates the graceful shutdown process

2019-04-10 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12973 ) Change subject: IMPALA-8401: SIGRTMIN initiates the graceful shutdown process .. Patch Set 2: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-8401: SIGRTMIN initiates the graceful shutdown process

2019-04-12 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12973 ) Change subject: IMPALA-8401: SIGRTMIN initiates the graceful shutdown process .. Patch Set 2: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-8401: SIGRTMIN initiates the graceful shutdown process

2019-04-12 Thread Bikramjeet Vig (Code Review)
Hello Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12973 to look at the new patch set (#3). Change subject: IMPALA-8401: SIGRTMIN initiates the graceful shutdown process ..

[Impala-ASF-CR] IMPALA-8401: SIGRTMIN initiates the graceful shutdown process

2019-04-15 Thread Bikramjeet Vig (Code Review)
Hello Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12973 to look at the new patch set (#4). Change subject: IMPALA-8401: SIGRTMIN initiates the graceful shutdown process ..

[Impala-ASF-CR] IMPALA-8401: SIGRTMIN initiates the graceful shutdown process

2019-04-15 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12973 ) Change subject: IMPALA-8401: SIGRTMIN initiates the graceful shutdown process .. Patch Set 3: (15 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-8401: SIGRTMIN initiates the graceful shutdown process

2019-04-15 Thread Bikramjeet Vig (Code Review)
Hello Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12973 to look at the new patch set (#5). Change subject: IMPALA-8401: SIGRTMIN initiates the graceful shutdown process ..

[Impala-ASF-CR] IMPALA-8401: SIGRTMIN initiates the graceful shutdown process

2019-04-15 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12973 ) Change subject: IMPALA-8401: SIGRTMIN initiates the graceful shutdown process .. Patch Set 4: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

2019-04-15 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12530 ) Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0 .. Patch Set 11: Code-Review+1 (2 comments) Looks good

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

2019-04-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12530 ) Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0 .. Patch Set 11: Code-Review+2 (2 comments) http://gerri

[Impala-ASF-CR] IMPALA-8401: SIGRTMIN initiates the graceful shutdown process

2019-04-17 Thread Bikramjeet Vig (Code Review)
Hello Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12973 to look at the new patch set (#6). Change subject: IMPALA-8401: SIGRTMIN initiates the graceful shutdown process ..

[Impala-ASF-CR] IMPALA-8401: SIGRTMIN initiates the graceful shutdown process

2019-04-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12973 ) Change subject: IMPALA-8401: SIGRTMIN initiates the graceful shutdown process .. Patch Set 5: (4 comments) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-7665: Fix unwarranted query cancellation on statestore restart

2019-04-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13061 Change subject: IMPALA-7665: Fix unwarranted query cancellation on statestore restart .. IMPALA-7665: Fix unwarranted query cancellati

[Impala-ASF-CR] IMPALA-8401: SIGRTMIN initiates the graceful shutdown process

2019-04-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12973 ) Change subject: IMPALA-8401: SIGRTMIN initiates the graceful shutdown process .. Patch Set 6: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-8401: SIGRTMIN initiates the graceful shutdown process

2019-04-17 Thread Bikramjeet Vig (Code Review)
Hello Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12973 to look at the new patch set (#7). Change subject: IMPALA-8401: SIGRTMIN initiates the graceful shutdown process ..

[Impala-ASF-CR] IMPALA-8401: SIGRTMIN initiates the graceful shutdown process

2019-04-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12973 ) Change subject: IMPALA-8401: SIGRTMIN initiates the graceful shutdown process .. Patch Set 8: Code-Review+2 Rebased and carrying over

[Impala-ASF-CR] IMPALA-8401: SIGRTMIN initiates the graceful shutdown process

2019-04-18 Thread Bikramjeet Vig (Code Review)
Hello Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12973 to look at the new patch set (#9). Change subject: IMPALA-8401: SIGRTMIN initiates the graceful shutdown process ..

[Impala-ASF-CR] IMPALA-8401: SIGRTMIN initiates the graceful shutdown process

2019-04-18 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12973 ) Change subject: IMPALA-8401: SIGRTMIN initiates the graceful shutdown process .. Patch Set 9: Code-Review+2 Updated Commit message wi

[Impala-ASF-CR] IMPALA-8270: fix MemTracker teardown in FeSupport

2019-04-18 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13057 ) Change subject: IMPALA-8270: fix MemTracker teardown in FeSupport .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-8270: fix MemTracker teardown in FeSupport

2019-04-19 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13057 ) Change subject: IMPALA-8270: fix MemTracker teardown in FeSupport .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-23 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 2: (4 comments) looks good, just a few nits

[Impala-ASF-CR] IMPALA-8295: Fix flakiness in TestAdmissionControllerStress

2019-04-24 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13103 Change subject: IMPALA-8295: Fix flakiness in TestAdmissionControllerStress .. IMPALA-8295: Fix flakiness in TestAdmissionControllerStr

[Impala-ASF-CR] IMPALA-8295: Fix flakiness in TestAdmissionControllerStress

2019-04-24 Thread Bikramjeet Vig (Code Review)
Hello Michael Ho, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13103 to look at the new patch set (#2). Change subject: IMPALA-8295: Fix flakiness in TestAdmissionControllerStress .

[Impala-ASF-CR] IMPALA-8295: Fix flakiness in TestAdmissionControllerStress

2019-04-24 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13103 ) Change subject: IMPALA-8295: Fix flakiness in TestAdmissionControllerStress .. Patch Set 2: (1 comment) Carrying over Tim's +1 http

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-24 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 3: Code-Review+2 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-25 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 5: Code-Review+2 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-7665: Fix unwarranted query cancellation on statestore restart

2019-04-29 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13061 ) Change subject: IMPALA-7665: Fix unwarranted query cancellation on statestore restart .. Patch Set 2: (15 comments) http://gerrit.c

[Impala-ASF-CR] IMPALA-7665: Fix unwarranted query cancellation on statestore restart

2019-04-29 Thread Bikramjeet Vig (Code Review)
Hello Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13061 to look at the new patch set (#2). Change subject: IMPALA-7665: Fix unwarranted query cancellation on statestore restart .

[Impala-ASF-CR] IMPALA-7665: Fix unwarranted query cancellation on statestore restart

2019-04-30 Thread Bikramjeet Vig (Code Review)
Hello Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13061 to look at the new patch set (#3). Change subject: IMPALA-7665: Fix unwarranted query cancellation on statestore restart .

[Impala-ASF-CR] IMPALA-7665: Fix unwarranted query cancellation on statestore restart

2019-04-30 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13061 ) Change subject: IMPALA-7665: Fix unwarranted query cancellation on statestore restart .. Patch Set 3: (2 comments) http://gerrit.cl

[Impala-ASF-CR] IMPALA-966: Type errors are attributed to wrong expression with insert

2019-05-01 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13050 ) Change subject: IMPALA-966: Type errors are attributed to wrong expression with insert .. Patch Set 3: (12 comments) http://gerrit.

<    1   2   3   4   5   6   7   8   9   10   >