[Impala-ASF-CR] IMPALA-7199: Add scripts to create code coverage reports

2018-06-22 Thread Joe McDonnell (Code Review)
Hello Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10791 to look at the new patch set (#2). Change subject: IMPALA-7199: Add scripts to create code coverage reports ..

[Impala-ASF-CR] IMPALA-7200: Fix missing FILESYSTEM PREFIX hitting local dataload

2018-06-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10803 Change subject: IMPALA-7200: Fix missing FILESYSTEM_PREFIX hitting local dataload .. IMPALA-7200: Fix missing FILESYSTEM_PREFIX

[Impala-ASF-CR] IMPALA-7200: Fix missing FILESYSTEM PREFIX hitting local dataload

2018-06-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10803 ) Change subject: IMPALA-7200: Fix missing FILESYSTEM_PREFIX hitting local dataload .. IMPALA-7200: Fix missing

[native-toolchain-CR] Patch llvm to fix run-clang-tidy.py output

2018-06-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10788 ) Change subject: Patch llvm to fix run-clang-tidy.py output .. Patch llvm to fix run-clang-tidy.py output Clang's

[native-toolchain-CR] Patch llvm to fix run-clang-tidy.py output

2018-06-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10788 ) Change subject: Patch llvm to fix run-clang-tidy.py output .. Patch Set 5: Verified+1 Toolchain package build succeeded on all

[Impala-ASF-CR] IMPALA-7132: Filter out useless output from run clang tidy.sh

2018-06-26 Thread Joe McDonnell (Code Review)
Hello Jim Apple, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10615 to look at the new patch set (#2). Change subject: IMPALA-7132: Filter out useless output from run_clang_tidy.sh

[Impala-ASF-CR] IMPALA-7185: low statestore custom cluster interval

2018-07-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10845 ) Change subject: IMPALA-7185: low statestore custom cluster interval .. Patch Set 3: Code-Review+2 This looks good to me. -- To

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

2018-04-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10244 ) Change subject: Warn about Hadoop / Java version incompatibility .. Patch Set 2: Code-Review+2 This looks reasonable to me. -- To

[Impala-ASF-CR] Warn about JAVA version if minicluster fails to start

2018-04-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10222 ) Change subject: Warn about JAVA version if minicluster fails to start .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6070: Further improvements to test-with-docker.

2018-04-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10123 ) Change subject: IMPALA-6070: Further improvements to test-with-docker. .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

2018-04-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10222 ) Change subject: Warn about Hadoop / Java version incompatibility .. Patch Set 2: (1 comment)

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

2018-04-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10222 ) Change subject: Warn about Hadoop / Java version incompatibility .. Patch Set 4: (1 comment) This looks good to me once you fix the

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

2018-04-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10244 ) Change subject: Warn about Hadoop / Java version incompatibility .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6866: Rework timeouts for test exchange delays.py

2018-05-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10208 ) Change subject: IMPALA-6866: Rework timeouts for test_exchange_delays.py .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6972: Disable parallel dataload on

2018-05-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10306 Change subject: IMPALA-6972: Disable parallel dataload on .. IMPALA-6972: Disable parallel dataload on There is a Hive bug in Hive

[Impala-ASF-CR] IMPALA-7238: Use custom timeout for create unique database

2018-07-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10862 ) Change subject: IMPALA-7238: Use custom timeout for create unique database .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7238: Use custom timeout for create unique database

2018-07-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10862 Change subject: IMPALA-7238: Use custom timeout for create unique database .. IMPALA-7238: Use custom timeout for create unique

[Impala-ASF-CR] IMPALA-6364: Bypass file handle cache for ineligible files

2018-01-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8945 ) Change subject: IMPALA-6364: Bypass file handle cache for ineligible files .. Patch Set 3: Code-Review+2 Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-6364: Bypass file handle cache for ineligible files

2018-01-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8945 Change subject: IMPALA-6364: Bypass file handle cache for ineligible files .. IMPALA-6364: Bypass file handle cache for ineligible files

[Impala-ASF-CR] IMPALA-6364: Bypass file handle cache for ineligible files

2018-01-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8945 ) Change subject: IMPALA-6364: Bypass file handle cache for ineligible files .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6364: Bypass file handle cache for ineligible files

2018-01-04 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8945 to look at the new patch set (#2). Change subject: IMPALA-6364: Bypass file handle cache for ineligible files ..

[Impala-ASF-CR] IMPALA-6364: Bypass file handle cache for ineligible files

2018-01-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8945 ) Change subject: IMPALA-6364: Bypass file handle cache for ineligible files .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6364: Bypass file handle cache for ineligible files

2018-01-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8945 ) Change subject: IMPALA-6364: Bypass file handle cache for ineligible files .. Patch Set 1: (1 comment)

[Impala-ASF-CR] PREVIEW: IMPALA-6372: Go parallel for Hive dataload

2018-01-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8894 ) Change subject: PREVIEW: IMPALA-6372: Go parallel for Hive dataload .. Patch Set 6: (10 comments)

[Impala-ASF-CR] PREVIEW: IMPALA-6372: Go parallel for Hive dataload

2018-01-05 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8894 to look at the new patch set (#6). Change subject: PREVIEW: IMPALA-6372: Go parallel for Hive dataload ..

[Impala-ASF-CR] IMPALA-6386: Invalidate metadata at table level for dataload

2018-01-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9009 ) Change subject: IMPALA-6386: Invalidate metadata at table level for dataload .. Patch Set 3: Code-Review+2 Carry +2 -- To view,

[Impala-ASF-CR] IMPALA-6386: Invalidate metadata at table level for dataload

2018-01-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9009 ) Change subject: IMPALA-6386: Invalidate metadata at table level for dataload .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6386: Invalidate metadata at table level for dataload

2018-01-17 Thread Joe McDonnell (Code Review)
Hello Philip Zeyliger, Zach Amsden, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9009 to look at the new patch set (#3). Change subject: IMPALA-6386: Invalidate metadata at table level for dataload

[Impala-ASF-CR] IMPALA-6386: Invalidate metadata at table level for dataload

2018-01-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9009 Change subject: IMPALA-6386: Invalidate metadata at table level for dataload .. IMPALA-6386: Invalidate metadata at table level for

[Impala-ASF-CR] IMPALA-6386: Invalidate metadata at table level for dataload

2018-01-11 Thread Joe McDonnell (Code Review)
Hello Philip Zeyliger, Zach Amsden, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9009 to look at the new patch set (#2). Change subject: IMPALA-6386: Invalidate metadata at table level for dataload

[Impala-ASF-CR] IMPALA-6386: Invalidate metadata at table level for dataload

2018-01-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9009 ) Change subject: IMPALA-6386: Invalidate metadata at table level for dataload .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6386: Invalidate metadata at table level for dataload

2018-01-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9009 ) Change subject: IMPALA-6386: Invalidate metadata at table level for dataload .. Patch Set 1: (1 comment)

[Impala-ASF-CR] KUDU-2296: Fix deserialization of messages larger than 64MB

2018-02-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9313 ) Change subject: KUDU-2296: Fix deserialization of messages larger than 64MB .. Patch Set 1: Clean cherry-pick -- To view, visit

[Impala-ASF-CR] KUDU-2296: Fix deserialization of messages larger than 64MB

2018-02-13 Thread Joe McDonnell (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9313 to review the following change. Change subject: KUDU-2296: Fix deserialization of messages larger than 64MB

[Impala-ASF-CR] KUDU-2296: Fix deserialization of messages larger than 64MB

2018-02-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9313 ) Change subject: KUDU-2296: Fix deserialization of messages larger than 64MB .. Removed reviewer Kudu Jenkins. -- To view, visit

[Impala-ASF-CR] KUDU-2296: Fix deserialization of messages larger than 64MB

2018-02-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9313 ) Change subject: KUDU-2296: Fix deserialization of messages larger than 64MB .. Patch Set 2: Code-Review+2 Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4874: Increase maximum KRPC message size

2018-02-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9337 ) Change subject: IMPALA-4874: Increase maximum KRPC message size .. Patch Set 5: Code-Review+2 Rebase, carry +2. -- To view, visit

[Impala-ASF-CR] IMPALA-6530: Track time spent opening HDFS file handles

2018-02-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9370 Change subject: IMPALA-6530: Track time spent opening HDFS file handles .. IMPALA-6530: Track time spent opening HDFS file handles When

[Impala-ASF-CR] IMPALA-4874: Increase maximum KRPC message size

2018-02-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9337 ) Change subject: IMPALA-4874: Increase maximum KRPC message size .. Patch Set 4: Code-Review+2 Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4874: Increase maximum KRPC message size

2018-02-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9337 ) Change subject: IMPALA-4874: Increase maximum KRPC message size .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4874: Increase maximum KRPC message size

2018-02-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9337 ) Change subject: IMPALA-4874: Increase maximum KRPC message size .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6549: Enable file handle cache by default

2018-02-21 Thread Joe McDonnell (Code Review)
Hello Lars Volker, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9371 to look at the new patch set (#2). Change subject: IMPALA-6549: Enable file handle cache by default

[Impala-ASF-CR] IMPALA-6549: Enable file handle cache by default

2018-02-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9371 ) Change subject: IMPALA-6549: Enable file handle cache by default .. Patch Set 1: (1 comment) > (1 comment) > > > (1 comment) > >

[Impala-ASF-CR] IMPALA-6530: Track time spent opening HDFS file handles

2018-02-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9370 ) Change subject: IMPALA-6530: Track time spent opening HDFS file handles .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6549: Enable file handle cache by default

2018-02-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9371 ) Change subject: IMPALA-6549: Enable file handle cache by default .. Patch Set 1: (1 comment) > (1 comment) > > Do you have a list

[Impala-ASF-CR] IMPALA-6530: Track time spent opening HDFS file handles

2018-02-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9370 ) Change subject: IMPALA-6530: Track time spent opening HDFS file handles .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6530: Track time spent opening HDFS file handles

2018-02-21 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9370 to look at the new patch set (#3). Change subject: IMPALA-6530: Track time spent opening HDFS file handles ..

[Impala-ASF-CR] IMPALA-6549: Enable file handle cache by default

2018-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9371 ) Change subject: IMPALA-6549: Enable file handle cache by default .. Patch Set 3: Code-Review+2 Rebased. Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-6543: Limit RowBatch serialization size to INT MAX

2018-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9367 ) Change subject: IMPALA-6543: Limit RowBatch serialization size to INT_MAX .. Patch Set 1: (1 comment) Updated

[Impala-ASF-CR] IMPALA-6543: Limit RowBatch serialization size to INT MAX

2018-02-22 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9367 to look at the new patch set (#2). Change subject: IMPALA-6543: Limit RowBatch serialization size to INT_MAX

[Impala-ASF-CR] IMPALA-6580: Use LOAD DATA LOCAL for decimal tables

2018-02-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9438 Change subject: IMPALA-6580: Use LOAD DATA LOCAL for decimal tables .. IMPALA-6580: Use LOAD DATA LOCAL for decimal tables IMPALA-5752

[Impala-ASF-CR] IMPALA-6580: Use LOAD DATA LOCAL for decimal tables

2018-02-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9438 ) Change subject: IMPALA-6580: Use LOAD DATA LOCAL for decimal tables .. Patch Set 1: I'm doing a dataload to test, but this had

[Impala-ASF-CR] IMPALA-2990: Add a warning message during cancellation

2018-02-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9413 ) Change subject: IMPALA-2990: Add a warning message during cancellation .. Patch Set 2: Code-Review+2 Looks good to me. -- To view,

[Impala-ASF-CR] IMPALA-6530: Track time spent opening HDFS file handles

2018-02-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9370 ) Change subject: IMPALA-6530: Track time spent opening HDFS file handles .. Patch Set 6: Code-Review+2 Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-6530: Track time spent opening HDFS file handles

2018-02-23 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9370 to look at the new patch set (#6). Change subject: IMPALA-6530: Track time spent opening HDFS file handles

[Impala-ASF-CR] IMPALA-6530: Track time spent opening HDFS file handles

2018-02-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9370 ) Change subject: IMPALA-6530: Track time spent opening HDFS file handles .. Patch Set 5: Fix a silly error (forgot to add the metric to

[Impala-ASF-CR] IMPALA-6543: Limit RowBatch serialization size to INT MAX

2018-02-23 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, Sailesh Mukil, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9367 to look at the new patch set (#3). Change subject: IMPALA-6543: Limit RowBatch serialization size to INT_MAX

[Impala-ASF-CR] IMPALA-6543: Limit RowBatch serialization size to INT MAX

2018-02-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9367 ) Change subject: IMPALA-6543: Limit RowBatch serialization size to INT_MAX .. Patch Set 3: Code-Review+2 Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-6579: Always force reload Kudu tables for dataload

2018-02-24 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9445 Change subject: IMPALA-6579: Always force reload Kudu tables for dataload .. IMPALA-6579: Always force reload Kudu tables for dataload

[Impala-ASF-CR] IMPALA-6579: Always force reload Kudu tables for dataload

2018-02-24 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9445 to look at the new patch set (#2). Change subject: IMPALA-6579: Always force reload Kudu tables for dataload ..

[Impala-ASF-CR] IMPALA-6579: Always force reload Kudu tables for dataload

2018-02-24 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9445 ) Change subject: IMPALA-6579: Always force reload Kudu tables for dataload .. Patch Set 1: (1 comment) Added comment, rebased. Carry

[Impala-ASF-CR] IMPALA-6579: Always force reload Kudu tables for dataload

2018-02-24 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9445 ) Change subject: IMPALA-6579: Always force reload Kudu tables for dataload .. Patch Set 2: Code-Review+2 Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4874: Increase maximum KRPC message size

2018-02-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9337 Change subject: IMPALA-4874: Increase maximum KRPC message size .. IMPALA-4874: Increase maximum KRPC message size The default value

[Impala-ASF-CR] IMPALA-4874: Increase maximum KRPC message size

2018-02-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9337 ) Change subject: IMPALA-4874: Increase maximum KRPC message size .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4874: Increase maximum KRPC message size

2018-02-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9337 ) Change subject: IMPALA-4874: Increase maximum KRPC message size .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6530: Track time spent opening HDFS file handles

2018-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9370 ) Change subject: IMPALA-6530: Track time spent opening HDFS file handles .. Patch Set 4: Code-Review+2 Carrying +2 -- To view, visit

[Impala-ASF-CR] IMPALA-6530: Track time spent opening HDFS file handles

2018-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9370 ) Change subject: IMPALA-6530: Track time spent opening HDFS file handles .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6530: Track time spent opening HDFS file handles

2018-02-22 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9370 to look at the new patch set (#4). Change subject: IMPALA-6530: Track time spent opening HDFS file handles

[Impala-ASF-CR] IMPALA-6549: Enable file handle cache by default

2018-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9371 ) Change subject: IMPALA-6549: Enable file handle cache by default .. Patch Set 3: GVO hit IMPALA-6532 -- To view, visit

[Impala-ASF-CR] KUDU-2305: Fix local variable usage to handle 2GB messages

2018-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has removed Todd Lipcon from this change. ( http://gerrit.cloudera.org:8080/9407 ) Change subject: KUDU-2305: Fix local variable usage to handle 2GB messages .. Removed reviewer Todd Lipcon. -- To view, visit

[Impala-ASF-CR] KUDU-2305: Fix local variable usage to handle 2GB messages

2018-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has removed Dan Burkert from this change. ( http://gerrit.cloudera.org:8080/9407 ) Change subject: KUDU-2305: Fix local variable usage to handle 2GB messages .. Removed reviewer Dan Burkert. -- To view, visit

[Impala-ASF-CR] KUDU-2305: Fix local variable usage to handle 2GB messages

2018-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9407 ) Change subject: KUDU-2305: Fix local variable usage to handle 2GB messages .. Removed reviewer Kudu Jenkins. -- To view, visit

[Impala-ASF-CR] KUDU-2305: Fix local variable usage to handle 2GB messages

2018-02-22 Thread Joe McDonnell (Code Review)
Hello Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9407 to review the following change. Change subject: KUDU-2305: Fix local variable usage to handle 2GB messages

[Impala-ASF-CR] KUDU-2305: Fix local variable usage to handle 2GB messages

2018-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9407 ) Change subject: KUDU-2305: Fix local variable usage to handle 2GB messages .. Patch Set 1: Clean cherry-pick -- To view, visit

[Impala-ASF-CR](2.x) IMPALA-6549: Enable file handle cache by default

2018-02-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9426 ) Change subject: IMPALA-6549: Enable file handle cache by default .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR](2.x) KUDU-2305: Fix local variable usage to handle 2GB messages

2018-02-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9427 ) Change subject: KUDU-2305: Fix local variable usage to handle 2GB messages .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6530: Track time spent opening HDFS file handles

2018-02-23 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9370 to look at the new patch set (#5). Change subject: IMPALA-6530: Track time spent opening HDFS file handles

[Impala-ASF-CR] IMPALA-6543: Limit RowBatch serialization size to INT MAX

2018-02-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9367 ) Change subject: IMPALA-6543: Limit RowBatch serialization size to INT_MAX .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6549: Enable file handle cache by default

2018-02-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9371 Change subject: IMPALA-6549: Enable file handle cache by default .. IMPALA-6549: Enable file handle cache by default The file handle

[Impala-ASF-CR] IMPALA-6530: Track time spent opening HDFS file handles

2018-02-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9370 ) Change subject: IMPALA-6530: Track time spent opening HDFS file handles .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4874: Increase maximum KRPC message size

2018-02-20 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9337 to look at the new patch set (#2). Change subject: IMPALA-4874: Increase maximum KRPC message size

[Impala-ASF-CR] IMPALA-4874: Increase maximum KRPC message size

2018-02-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9337 ) Change subject: IMPALA-4874: Increase maximum KRPC message size .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-6530: Track time spent opening HDFS file handles

2018-02-21 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9370 to look at the new patch set (#2). Change subject: IMPALA-6530: Track time spent opening HDFS file handles ..

[Impala-ASF-CR] IMPALA-6543: Limit RowBatch serialization size to INT MAX

2018-02-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9367 Change subject: IMPALA-6543: Limit RowBatch serialization size to INT_MAX .. IMPALA-6543: Limit RowBatch serialization size to INT_MAX

[Impala-ASF-CR] IMPALA-2990: Add a warning message during cancellation

2018-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9413 ) Change subject: IMPALA-2990: Add a warning message during cancellation .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6543: Limit RowBatch serialization size to INT MAX

2018-02-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9367 ) Change subject: IMPALA-6543: Limit RowBatch serialization size to INT_MAX .. Patch Set 4: Code-Review+2 Rebased, carry +2 -- To

[Impala-ASF-CR] IMPALA-7193: Fix cluster startup args in create-load-data.sh

2018-06-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10782 Change subject: IMPALA-7193: Fix cluster startup args in create-load-data.sh .. IMPALA-7193: Fix cluster startup args in

[Impala-ASF-CR] IMPALA-7132: Filter out useless output from run clang tidy.sh

2018-06-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10615 ) Change subject: IMPALA-7132: Filter out useless output from run_clang_tidy.sh .. Patch Set 1: I created a native-toolchain change to

[native-toolchain-CR] Patch llvm to fix run-clang-tidy.py output

2018-06-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10788 Change subject: Patch llvm to fix run-clang-tidy.py output .. Patch llvm to fix run-clang-tidy.py output Clang's run-clang-tidy.py has

[native-toolchain-CR] Patch llvm to fix run-clang-tidy.py output

2018-06-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10788 ) Change subject: Patch llvm to fix run-clang-tidy.py output .. Patch Set 2: Let me know if there are other appropriate reviewers. --

[native-toolchain-CR] Patch llvm to fix run-clang-tidy.py output

2018-06-21 Thread Joe McDonnell (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10788 to look at the new patch set (#4). Change subject: Patch llvm to fix run-clang-tidy.py output ..

[Impala-ASF-CR] Add scripts to create code coverage reports

2018-06-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10791 Change subject: Add scripts to create code coverage reports .. Add scripts to create code coverage reports gcovr is a python library

[native-toolchain-CR] Patch llvm to fix run-clang-tidy.py output

2018-06-21 Thread Joe McDonnell (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10788 to look at the new patch set (#3). Change subject: Patch llvm to fix run-clang-tidy.py output ..

[native-toolchain-CR] Patch llvm to fix run-clang-tidy.py output

2018-06-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10788 ) Change subject: Patch llvm to fix run-clang-tidy.py output .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-7193: Fix cluster startup args in create-load-data.sh

2018-06-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10782 ) Change subject: IMPALA-7193: Fix cluster startup args in create-load-data.sh .. IMPALA-7193: Fix cluster startup args in

[Impala-ASF-CR] IMPALA-7383: Configurable METASTORE DB defaulting to escaped IMPALA HOME

2018-08-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11104 ) Change subject: IMPALA-7383: Configurable METASTORE_DB defaulting to escaped IMPALA_HOME .. Patch Set 1: Can you do similar logic

[Impala-ASF-CR] IMPALA-7381: Prevent build failure after switching to new CDH BUILD NUMBER

2018-08-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11099 ) Change subject: IMPALA-7381: Prevent build failure after switching to new CDH_BUILD_NUMBER .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7381: Prevent build failure after switching to new CDH BUILD NUMBER

2018-08-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11099 ) Change subject: IMPALA-7381: Prevent build failure after switching to new CDH_BUILD_NUMBER .. Patch Set 2: (1 comment) I'm

[Impala-ASF-CR] IMPALA-7381: Prevent build failure after switching to new CDH BUILD NUMBER

2018-08-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11099 ) Change subject: IMPALA-7381: Prevent build failure after switching to new CDH_BUILD_NUMBER .. Patch Set 3: Code-Review+2 This looks

[Impala-ASF-CR] IMPALA-7385: Fix test-with-docker errors having to do with time zones.

2018-08-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11106 ) Change subject: IMPALA-7385: Fix test-with-docker errors having to do with time zones. .. Patch Set 3: Code-Review+2 Thanks for

<    1   2   3   4   5   6   7   8   9   10   >