[Impala-ASF-CR] IMPALA-8264: Fix overflow in SystemStateInfo::ComputeCpuRatios

2019-02-28 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12638 Change subject: IMPALA-8264: Fix overflow in SystemStateInfo::ComputeCpuRatios .. IMPALA-8264: Fix overflow in SystemStateInfo::ComputeCpu

[Impala-ASF-CR] IMPALA-8264: Fix overflow in SystemStateInfo::ComputeCpuRatios

2019-02-28 Thread Lars Volker (Code Review)
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12638 to look at the new patch set (#2). Change subject: IMPALA-8264: Fix overflow in SystemStateInfo::ComputeCpuRatios .

[Impala-ASF-CR] IMPALA-8264: Fix overflow in SystemStateInfo::ComputeCpuRatios

2019-02-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12638 ) Change subject: IMPALA-8264: Fix overflow in SystemStateInfo::ComputeCpuRatios .. Patch Set 2: Code-Review+2 (1 comment) Carrying Micha

[Impala-ASF-CR] IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()

2019-03-01 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12624 ) Change subject: IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy() .. Patch Set 3: (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()

2019-03-01 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12624 ) Change subject: IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy() .. Patch Set 3: Code-Review+2 -- To view, vis

[Impala-ASF-CR] IMPALA-8300: Skip test max nesting depth for Orc in non-HDFS tests

2019-03-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12714 ) Change subject: IMPALA-8300: Skip test_max_nesting_depth for Orc in non-HDFS tests .. Patch Set 1: Code-Review+2 If we expect more test

[Impala-ASF-CR] IMPALA-8067: [DOCS] Add host resource usage metrics to profile

2019-03-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12719 ) Change subject: IMPALA-8067: [DOCS] Add host resource usage metrics to profile .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-8067: [DOCS] Add host resource usage metrics to profile

2019-03-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12719 ) Change subject: IMPALA-8067: [DOCS] Add host resource usage metrics to profile .. Patch Set 2: Code-Review+2 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-7982: Add host network usage to profile

2019-03-13 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12747 Change subject: IMPALA-7982: Add host network usage to profile .. IMPALA-7982: Add host network usage to profile This change adds host ne

[native-toolchain-CR] IMPALA-8316. Update re2 to latest version

2019-03-17 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12771 ) Change subject: IMPALA-8316. Update re2 to latest version .. Patch Set 1: Code-Review+2 I'll reach out to you in person to point you to

[Impala-ASF-CR] IMPALA-5393. Use THREAD LOCAL state for regexp

2019-03-17 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12772 ) Change subject: IMPALA-5393. Use THREAD_LOCAL state for regexp .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-8316. Update re2 to the latest version

2019-03-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12778 ) Change subject: IMPALA-8316. Update re2 to the latest version .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.or

[Impala-ASF-CR] Revert "IMPALA-8316. Update re2 to the latest version"

2019-03-19 Thread Lars Volker (Code Review)
Lars Volker has created a revert of this change. ( http://gerrit.cloudera.org:8080/12790 ) Change subject: Revert "IMPALA-8316. Update re2 to the latest version" .. Uploaded patch set 1. -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] Revert "IMPALA-8316. Update re2 to the latest version"

2019-03-19 Thread Lars Volker (Code Review)
Hello Todd Lipcon, Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12790 to review the following change. Change subject: Revert "IMPALA-8316. Update re2 to the latest version"

[Impala-ASF-CR] Revert "IMPALA-5393. Use THREAD LOCAL state for regexp"

2019-03-19 Thread Lars Volker (Code Review)
Hello Todd Lipcon, Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12791 to review the following change. Change subject: Revert "IMPALA-5393. Use THREAD_LOCAL state for regexp" ...

[Impala-ASF-CR] Revert "IMPALA-5393. Use THREAD LOCAL state for regexp"

2019-03-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12791 ) Change subject: Revert "IMPALA-5393. Use THREAD_LOCAL state for regexp" .. Patch Set 1: Verified+1 Code-Review+2 Clean revert. -- To v

[Impala-ASF-CR] Revert "IMPALA-5393. Use THREAD LOCAL state for regexp"

2019-03-19 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12791 ) Change subject: Revert "IMPALA-5393. Use THREAD_LOCAL state for regexp" .. Revert "IMPALA-5393. Use THREAD_LOCAL state for regexp

[Impala-ASF-CR] Revert "IMPALA-5393. Use THREAD LOCAL state for regexp"

2019-03-19 Thread Lars Volker (Code Review)
Lars Volker has created a revert of this change. ( http://gerrit.cloudera.org:8080/12791 ) Change subject: Revert "IMPALA-5393. Use THREAD_LOCAL state for regexp" .. Uploaded patch set 1. -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] Revert "IMPALA-8316. Update re2 to the latest version"

2019-03-19 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12790 ) Change subject: Revert "IMPALA-8316. Update re2 to the latest version" .. Revert "IMPALA-8316. Update re2 to the latest version"

[Impala-ASF-CR] Revert "IMPALA-8316. Update re2 to the latest version"

2019-03-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12790 ) Change subject: Revert "IMPALA-8316. Update re2 to the latest version" .. Patch Set 2: Verified+1 Code-Review+2 Clean revert -- To vie

[Impala-ASF-CR] IMPALA-8320: Handle psutil error in tests

2019-03-19 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12792 Change subject: IMPALA-8320: Handle psutil error in tests .. IMPALA-8320: Handle psutil error in tests We use psutil.Process.cmdline to a

[Impala-ASF-CR] IMPALA-8320: Handle psutil error in tests

2019-03-19 Thread Lars Volker (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12792 to look at the new patch set (#2). Change subject: IMPALA-8320: Handle psutil error in tests ...

[Impala-ASF-CR] IMPALA-8320: Handle psutil error in tests

2019-03-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12792 ) Change subject: IMPALA-8320: Handle psutil error in tests .. Patch Set 2: Code-Review+2 (1 comment) Addressed Joe's comment, carrying h

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla

2019-03-19 Thread Lars Volker (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12530 to look at the new patch set (#5). Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla

2019-03-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12530 ) Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla .. Patch Set 5: Rebased, fixed some tests, still waiting for impyla

[Impala-ASF-CR] IMPALA-7982: Add host network usage to profile

2019-03-19 Thread Lars Volker (Code Review)
Hello Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12747 to look at the new patch set (#2). Change subject: IMPALA-7982: Add host network usage to profile

[Impala-ASF-CR] IMPALA-7982: Add host network usage to profile

2019-03-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12747 ) Change subject: IMPALA-7982: Add host network usage to profile .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12747/1

[Impala-ASF-CR] IMPALA-5051: Add INT64 timestamp write support in Parquet

2019-03-20 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12247 ) Change subject: IMPALA-5051: Add INT64 timestamp write support in Parquet .. Patch Set 9: (17 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-7981: Add host disk usage to profile

2019-03-21 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12822 Change subject: IMPALA-7981: Add host disk usage to profile .. IMPALA-7981: Add host disk usage to profile This change adds host disk usa

[Impala-ASF-CR] Use `wget http://169.254.169.254/` to determine if we're running in aws

2019-03-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 ) Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws .. Patch Set 4: (1 comment) http://gerrit.clou

[Impala-ASF-CR] IMPALA-5843: Use page index in Parquet files to skip pages

2019-03-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12065 ) Change subject: IMPALA-5843: Use page index in Parquet files to skip pages .. Patch Set 7: (31 comments) Did a first pass over the main

[Impala-ASF-CR] Re-land IMPALA-5393. Use THREAD LOCAL state for regexp

2019-03-25 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12845 ) Change subject: Re-land IMPALA-5393. Use THREAD_LOCAL state for regexp .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-7982: Add host network usage to profile

2019-03-28 Thread Lars Volker (Code Review)
Hello John Sherman, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12747 to look at the new patch set (#3). Change subject: IMPALA-7982: Add host network usage to profile ..

[Impala-ASF-CR] IMPALA-7982: Add host network usage to profile

2019-03-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12747 ) Change subject: IMPALA-7982: Add host network usage to profile .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12747/2/

[Impala-ASF-CR] IMPALA-5051: Add INT64 timestamp write support in Parquet

2019-03-29 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12247 ) Change subject: IMPALA-5051: Add INT64 timestamp write support in Parquet .. Patch Set 13: Code-Review+2 (3 comments) Only had some nit

[Impala-ASF-CR] IMPALA-7982: Add host network usage to profile

2019-03-29 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12747 ) Change subject: IMPALA-7982: Add host network usage to profile .. Patch Set 5: Code-Review+2 Rebased, carrying Todd's +2 -- To view, v

[Impala-ASF-CR] Ensure ssh config change is on its own line

2019-04-01 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12900 ) Change subject: Ensure ssh config change is on its own line .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12900/3/bin

[Impala-ASF-CR] Improve error handling for validation of unified backend executable

2019-04-01 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12895 ) Change subject: Improve error handling for validation of unified backend executable .. Patch Set 1: Code-Review+2 -- To view, visit ht

[Impala-ASF-CR] Give each config change in bootstrap system.sh its own line

2019-04-02 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12900 ) Change subject: Give each config change in bootstrap_system.sh its own line .. Patch Set 4: Code-Review+2 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-8380: Bump Postgres JDBC driver version to 9.4

2019-04-03 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2) to the change originally created by Laszlo Gaal. ( http://gerrit.cloudera.org:8080/12894 ) Change subject: IMPALA-8380: Bump Postgres JDBC driver version to 9.4 .. IMPALA-8380: Bump

[Impala-ASF-CR] IMPALA-8380: Bump Postgres JDBC driver version to 9.4

2019-04-03 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12894 ) Change subject: IMPALA-8380: Bump Postgres JDBC driver version to 9.4 .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-5843: Use page index in Parquet files to skip pages

2019-04-03 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12065 ) Change subject: IMPALA-5843: Use page index in Parquet files to skip pages .. Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-5843: Use page index in Parquet files to skip pages

2019-04-03 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12065 ) Change subject: IMPALA-5843: Use page index in Parquet files to skip pages .. Patch Set 8: (37 comments) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-8380: Bump Postgres JDBC driver version to 9.4

2019-04-03 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#3) to the change originally created by Laszlo Gaal. ( http://gerrit.cloudera.org:8080/12894 ) Change subject: IMPALA-8380: Bump Postgres JDBC driver version to 9.4 .. IMPALA-8380: Bump

[native-toolchain-CR] Remove '-static-libstdc++' from CXXFLAGS

2019-04-03 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12929 ) Change subject: Remove '-static-libstdc++' from CXXFLAGS .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-8101: Thrift 11 and ext-data-source compilation are always run

2019-04-03 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12290 ) Change subject: IMPALA-8101: Thrift 11 and ext-data-source compilation are always run .. Patch Set 1: Anything blocking this from movin

[Impala-ASF-CR] IMPALA-7087: Read Parquet decimal columns with lower precision/scale than table metadata

2019-04-03 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12163 ) Change subject: IMPALA-7087: Read Parquet decimal columns with lower precision/scale than table metadata .. Patch Set 3: Zoltan, any pl

[Impala-ASF-CR] IMPALA-7640: RENAME on managed Kudu table should rename Kudu table

2019-04-03 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12179 ) Change subject: IMPALA-7640: RENAME on managed Kudu table should rename Kudu table .. Patch Set 4: Thomas, do you have time to look at

[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-04-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12885 ) Change subject: IMPALA-8371: Return appropriate error code for unified backend tests .. Patch Set 3: (8 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-8101: Thrift 11 and ext-data-source compilation are always run

2019-04-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12290 ) Change subject: IMPALA-8101: Thrift 11 and ext-data-source compilation are always run .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8380: Bump Postgres JDBC driver version to 42.2.5

2019-04-05 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#4) to the change originally created by Laszlo Gaal. ( http://gerrit.cloudera.org:8080/12894 ) Change subject: IMPALA-8380: Bump Postgres JDBC driver version to 42.2.5 .. IMPALA-8380: Bu

[Impala-ASF-CR] IMPALA-8380: Bump Postgres JDBC driver version to 42.2.5

2019-04-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12894 ) Change subject: IMPALA-8380: Bump Postgres JDBC driver version to 42.2.5 .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-8395: Parse older formats of /proc/net/dev correctly

2019-04-07 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12954 Change subject: IMPALA-8395: Parse older formats of /proc/net/dev correctly .. IMPALA-8395: Parse older formats of /proc/net/dev correctly

[Impala-ASF-CR] IMPALA-5051: Add INT64 timestamp write support in Parquet

2019-04-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12247 ) Change subject: IMPALA-5051: Add INT64 timestamp write support in Parquet .. Patch Set 15: Code-Review+2 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-04-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12885 ) Change subject: IMPALA-8371: Return appropriate error code for unified backend tests .. Patch Set 5: Code-Review+2 (2 comments) http:/

[Impala-ASF-CR] IMPALA-8395: Parse older formats of /proc/net/dev correctly

2019-04-08 Thread Lars Volker (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12954 to look at the new patch set (#2). Change subject: IMPALA-8395: Parse older formats of /proc/net/dev correctly ..

[Impala-ASF-CR] IMPALA-8395: Parse older formats of /proc/net/dev correctly

2019-04-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12954 ) Change subject: IMPALA-8395: Parse older formats of /proc/net/dev correctly .. Patch Set 2: Code-Review+1 (2 comments) Carrying Bharath

[Impala-ASF-CR] IMPALA-7981: Add host disk usage to profile

2019-04-08 Thread Lars Volker (Code Review)
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12822 to look at the new patch set (#3). Change subject: IMPALA-7981: Add host disk usage to profile

[Impala-ASF-CR] IMPALA-7981: Add host disk usage to profile

2019-04-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12822 ) Change subject: IMPALA-7981: Add host disk usage to profile .. Patch Set 3: (10 comments) http://gerrit.cloudera.org:8080/#/c/12822/2/b

[Impala-ASF-CR] IMPALA-7981: Add host disk statistics to profile

2019-04-08 Thread Lars Volker (Code Review)
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12822 to look at the new patch set (#4). Change subject: IMPALA-7981: Add host disk statistics to profile ...

[Impala-ASF-CR] IMPALA-8395: Parse older formats of /proc/net/dev correctly

2019-04-08 Thread Lars Volker (Code Review)
Hello Bharath Vissapragada, Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12954 to look at the new patch set (#3). Change subject: IMPALA-8395: Parse older formats of /proc/net/dev correctly ..

[Impala-ASF-CR] IMPALA-8395: Parse older formats of /proc/net/dev correctly

2019-04-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12954 ) Change subject: IMPALA-8395: Parse older formats of /proc/net/dev correctly .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-7981: Add host disk statistics to profile

2019-04-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12822 ) Change subject: IMPALA-7981: Add host disk statistics to profile .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/12822/

[Impala-ASF-CR] IMPALA-7981: Add host disk statistics to profile

2019-04-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12822 ) Change subject: IMPALA-7981: Add host disk statistics to profile .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/12822/

[Impala-ASF-CR] IMPALA-8395: Parse older formats of /proc/net/dev correctly

2019-04-08 Thread Lars Volker (Code Review)
Hello Bharath Vissapragada, Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12954 to look at the new patch set (#4). Change subject: IMPALA-8395: Parse older formats of /proc/net/dev correctly ..

[Impala-ASF-CR] IMPALA-8395: Parse older formats of /proc/net/dev correctly

2019-04-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12954 ) Change subject: IMPALA-8395: Parse older formats of /proc/net/dev correctly .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPAAL-8336: fix flaky ORC memory limit test

2019-04-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12961 ) Change subject: IMPAAL-8336: fix flaky ORC memory limit test .. Patch Set 1: Code-Review+2 (2 comments) Just some nits http://gerrit.c

[Impala-ASF-CR] IMPALA-8380: Bump Postgres JDBC driver version to 42.2.5

2019-04-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12894 ) Change subject: IMPALA-8380: Bump Postgres JDBC driver version to 42.2.5 .. Patch Set 4: Laszlo, do you have time for another review her

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 1: (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-7981: Add host disk statistics to profile

2019-04-09 Thread Lars Volker (Code Review)
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12822 to look at the new patch set (#6). Change subject: IMPALA-7981: Add host disk statistics to profile ...

[Impala-ASF-CR] IMPALA-7981: Add host disk statistics to profile

2019-04-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12822 ) Change subject: IMPALA-7981: Add host disk statistics to profile .. Patch Set 6: (1 comment) Rebased the change and made the overall co

[Impala-ASF-CR] IMPALA-5843: Use page index in Parquet files to skip pages

2019-04-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12065 ) Change subject: IMPALA-5843: Use page index in Parquet files to skip pages .. Patch Set 9: (21 comments) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-5843: Use page index in Parquet files to skip pages

2019-04-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12065 ) Change subject: IMPALA-5843: Use page index in Parquet files to skip pages .. Patch Set 9: > (54 comments) > > In a few comments the r

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 1: (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-8401: SIGQUIT initiates the graceful shutdown process

2019-04-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12973 ) Change subject: IMPALA-8401: SIGQUIT initiates the graceful shutdown process .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-5843: Use page index in Parquet files to skip pages

2019-04-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12065 ) Change subject: IMPALA-5843: Use page index in Parquet files to skip pages .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-10 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 1: (23 comments) I think it would be good to have some tests that

[Impala-ASF-CR] IMPALA-8380: Bump Postgres JDBC driver version to 42.2.5

2019-04-10 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12894 ) Change subject: IMPALA-8380: Bump Postgres JDBC driver version to 42.2.5 .. Patch Set 4: Feel free to interleave testing and by pushing

[Impala-ASF-CR] IMPALA-7981: Add host disk statistics to profile

2019-04-10 Thread Lars Volker (Code Review)
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12822 to look at the new patch set (#7). Change subject: IMPALA-7981: Add host disk statistics to profile ...

[Impala-ASF-CR] IMPALA-7981: Add host disk statistics to profile

2019-04-10 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12822 ) Change subject: IMPALA-7981: Add host disk statistics to profile .. Patch Set 8: Code-Review+2 (2 comments) Addressed the remaining com

[Impala-ASF-CR] IMPALA-7981: Add host disk statistics to profile

2019-04-10 Thread Lars Volker (Code Review)
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12822 to look at the new patch set (#9). Change subject: IMPALA-7981: Add host disk statistics to profile ...

[Impala-ASF-CR] IMPALA-7981: Add host disk statistics to profile

2019-04-10 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12822 ) Change subject: IMPALA-7981: Add host disk statistics to profile .. Patch Set 9: Code-Review+2 Pulled the device names in the disk tests

[native-toolchain-CR] Add ORC 1.5.5 to toolchain

2019-04-11 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12998 Change subject: Add ORC 1.5.5 to toolchain .. Add ORC 1.5.5 to toolchain Testing: Ran the scanner tests on orc/def locally. Change-Id: I

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 3: (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 ) Change subject: IMPALA-8341: Data cache for remote reads .. Patch Set 1: > (1 comment) > > > I think the _IO_ apportioned relative to

[Impala-ASF-CR] IMPALA-8380: Bump Postgres JDBC driver version to 42.2.5

2019-04-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12894 ) Change subject: IMPALA-8380: Bump Postgres JDBC driver version to 42.2.5 .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

2019-04-12 Thread Lars Volker (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12530 to look at the new patch set (#6). Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0 .

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

2019-04-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12530 ) Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0 .. Patch Set 7: I have bumped impyla and tested PS5 with the

[Impala-ASF-CR] IMPALA-8401: SIGRTMIN initiates the graceful shutdown process

2019-04-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12973 ) Change subject: IMPALA-8401: SIGRTMIN initiates the graceful shutdown process .. Patch Set 3: (15 comments) http://gerrit.cloudera.org:

[native-toolchain-CR] Add ORC 1.5.5 to toolchain

2019-04-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12998 ) Change subject: Add ORC 1.5.5 to toolchain .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12998 To unsubs

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 4: (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

2019-04-12 Thread Lars Volker (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12530 to look at the new patch set (#8). Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0 .

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

2019-04-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12530 ) Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0 .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

2019-04-12 Thread Lars Volker (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12530 to look at the new patch set (#9). Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0 .

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

2019-04-12 Thread Lars Volker (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12530 to look at the new patch set (#11). Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

2019-04-12 Thread Lars Volker (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12530 to look at the new patch set (#10). Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

2019-04-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12530 ) Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0 .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0

2019-04-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12530 ) Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0 .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 5: Code-Review+2 -- To view, vis

[Impala-ASF-CR] IMPALA-8380: Bump Postgres JDBC driver version to 42.2.5

2019-04-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12894 ) Change subject: IMPALA-8380: Bump Postgres JDBC driver version to 42.2.5 .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.

<    1   2   3   4   5   6   7   8   9   10   >