Zach Amsden has posted comments on this change.
Change subject: Complete guide to important environment variables for build,
test, and mini-cluster operations.
..
Patch Set 1:
I personally abhor Google docs as they just seem t
Zach Amsden has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7350
Change subject: Complete guide to important environment variables for build,
test, and mini-cluster operations.
..
Complete guide to impor
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4687: Get Impala working against HBase 2.0
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7277
To unsubscribe, visi
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4687: Get Impala working against HBase 2.0
..
IMPALA-4687: Get Impala working against HBase 2.0
This changes Impala code to tolerate the
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and
beeswax RPCs
..
Patch Set 13: Verified-1
Build failed: http://jenkins.impala.io:8080/job/gerr
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily
..
Patch Set 4: Code-Review+2
(1 comment)
Please see if Michael wants to look also.
http://gerrit.cl
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5036: Parquet count star optimization
..
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6812
To unsubscribe, visit http://gerri
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4687: Get Impala working against HBase 2.0
..
Patch Set 5:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/817/
--
To view
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4687: Get Impala working against HBase 2.0
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7277
To unsubscribe, visit http://
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7346
To unsubscri
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily
..
Patch Set 4:
I think Michael should take a look at this, he's intimately familiar with the
exp
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7349
Change subject: [DOCS] Advise setting vm.overcommit_memory=1 in various places
..
[DOCS] Advise setting vm.overcommit_memory=1 in various
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-5547: Rework FK/PK join detection.
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7257
To unsubscribe, visit htt
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5560: always store CHAR(N) inline in tuple
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7303
To unsubscribe, visi
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5560: always store CHAR(N) inline in tuple
..
IMPALA-5560: always store CHAR(N) inline in tuple
This is done to simplify the CHAR(N) logi
Alex Behm has uploaded a new patch set (#5).
Change subject: IMPALA-5547: Rework FK/PK join detection.
..
IMPALA-5547: Rework FK/PK join detection.
Reworks the FK/PK join detection logic to:
- more accurately recognize many-to-m
Alex Behm has posted comments on this change.
Change subject: IMPALA-5547: Rework FK/PK join detection.
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7257/4/testdata/workloads/functional-planner/queries/Plan
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily
..
Patch Set 4: Code-Review+1
looks good, thanks
Let's see if Tim or Dan want to take a look too
Thomas Tauber-Marshall has uploaded a new patch set (#4).
Change subject: IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily
..
IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily
IMPALA-3742 introduced Ku
Thomas Tauber-Marshall has posted comments on this change.
Change subject: IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily
..
Patch Set 3:
(2 comments)
> (2 comments)
>
> nice! After this change, do you see t
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7348
Change subject: IMPALA-5605: [DOCS] New known issue for upping thread resource
limits
..
IMPALA-5605: [DOCS] New known issue for upping t
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily
..
Patch Set 3:
(2 comments)
nice! After this change, do you see that there isn't that much memo
Thomas Tauber-Marshall has posted comments on this change.
Change subject: IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7346/2/be/src/runtime/da
Thomas Tauber-Marshall has uploaded a new patch set (#3).
Change subject: IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily
..
IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily
IMPALA-3742 introduced Ku
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7346/1/be/src/exprs/kudu-partit
Thomas Tauber-Marshall has posted comments on this change.
Change subject: IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7346/1/be/src/exprs/kudu
Thomas Tauber-Marshall has uploaded a new patch set (#2).
Change subject: IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily
..
IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily
IMPALA-3742 introduced Ku
Alex Behm has posted comments on this change.
Change subject: IMPALA-5036: Parquet count star optimization
..
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/6812
To unsubscribe, visit http://gerri
Taras Bobrovytsky has uploaded a new patch set (#8).
Change subject: IMPALA-5036: Parquet count star optimization
..
IMPALA-5036: Parquet count star optimization
Instead of materializing empty rows when computing count star, we
Hello Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6812
to look at the new patch set (#8).
Change subject: IMPALA-5036: Parquet count star optimization
..
IMPALA-5036: Parque
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-5036: Parquet count star optimization
..
Patch Set 7:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/6812/5/fe/src/main/java/org/apache/impala/plan
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5240: Allow config of number of disk I/O threads per
disk type
..
Patch Set 8:
(7 comments)
looks good, very close now, thanks
http://gerrit.cloudera.
Joe McDonnell has posted comments on this change.
Change subject: IMPALA-4687: Get Impala working against HBase 2.0
..
Patch Set 4:
> Please rebase and the I can submit for gvo.
This is rebased all the way.
--
To view, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4687: Get Impala working against HBase 2.0
..
Patch Set 4:
Please rebase and the I can submit for gvo.
--
To view, visit http://gerrit.cloudera.org:8080/727
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4687: Get Impala working against HBase 2.0
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7277
To unsubscribe, visit http://
Hello Bharath Vissapragada, Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7277
to look at the new patch set (#4).
Change subject: IMPALA-4687: Get Impala working against HBase 2.0
.
Joe McDonnell has posted comments on this change.
Change subject: IMPALA-4687: Get Impala working against HBase 2.0
..
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7277/3/be/src/exec/hbase-table-scanner.cc
Fil
Alex Behm has posted comments on this change.
Change subject: IMPALA-5036: Parquet count star optimization
..
Patch Set 7:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/6812/7/fe/src/main/java/org/apache/impala/planner/Hdfs
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and
beeswax RPCs
..
Patch Set 13:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-
Lars Volker has posted comments on this change.
Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and
beeswax RPCs
..
Patch Set 13: Code-Review+2
Carrying Dan's +2
--
To view, visit http://gerrit.clouder
Lars Volker has posted comments on this change.
Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and
beeswax RPCs
..
Patch Set 13:
Fixed Typo 😒
--
To view, visit http://gerrit.cloudera.org:8080/7155
To
Hello Impala Public Jenkins, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7155
to look at the new patch set (#13).
Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and
beeswax RPCs
...
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily
..
Patch Set 1:
Thomas, wrt my concern earlier about the hash partitioning case doing the call
e
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily
..
Patch Set 1:
FYI, while you're fixing bugs in this area, I noticed recently that
DataStreamSen
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5036: Parquet count star optimization
..
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6812/5/fe/src/main/java/org/apache/impala/planner/HdfsS
Taras Bobrovytsky has uploaded a new patch set (#7).
Change subject: IMPALA-5036: Parquet count star optimization
..
IMPALA-5036: Parquet count star optimization
Instead of materializing empty rows when computing count star, we
Hello Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6812
to look at the new patch set (#7).
Change subject: IMPALA-5036: Parquet count star optimization
..
IMPALA-5036: Parque
Hello Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6812
to look at the new patch set (#7).
Change subject: IMPALA-5036: Parquet count star optimization
..
IMPALA-5036: Parque
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-5036: Parquet count star optimization
..
Patch Set 5:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6812/5/fe/src/main/java/org/apache/impala/cata
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5489: Improve Sentry authorization for Kudu tables
..
Patch Set 1:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/7307/1/fe/src/test/java/org/apache/i
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and
beeswax RPCs
..
Patch Set 12: Verified-1
Build failed: http://jenkins.impala.io:8080/job/gerr
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-5547: Rework FK/PK join detection.
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7257/4/testdata/workloads/functional-planner/
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily
..
Patch Set 1:
(1 comment)
Can you add a test case that runs a query w/ a mem limit such that t
Thomas Tauber-Marshall has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7346
Change subject: IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily
..
IMPALA-5611: KuduPartitionExpr holds onto memo
Bikramjeet Vig has uploaded a new patch set (#8).
Change subject: IMPALA-5240: Allow config of number of disk I/O threads per
disk type
..
IMPALA-5240: Allow config of number of disk I/O threads per disk type
Currently Impala d
Bikramjeet Vig has posted comments on this change.
Change subject: IMPALA-5240: Allow config of number of disk I/O threads per
disk type
..
Patch Set 7:
(12 comments)
http://gerrit.cloudera.org:8080/#/c/7232/7//COMMIT_MSG
Com
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
Patch Set 6:
It seems like a good idea, just didn't want to do an ad-hoc solution. Filed
https://issues.apache
Alex Behm has posted comments on this change.
Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.
..
Patch Set 8:
I'll do an exhaustive run before submitting.
--
To view, visit http://gerrit.cloud
Alex Behm has posted comments on this change.
Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.
..
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6527/8/be/src/exec/hdfs-scanner.h
F
Alex Behm has uploaded a new patch set (#4).
Change subject: IMPALA-5547: Rework FK/PK join detection.
..
IMPALA-5547: Rework FK/PK join detection.
Reworks the FK/PK join detection logic to:
- more accurately recognize many-to-m
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5560: always store CHAR(N) inline in tuple
..
Patch Set 7:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/815/
--
To view
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5560: always store CHAR(N) inline in tuple
..
Patch Set 7: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/7303
To unsubscribe, v
Alex Behm has posted comments on this change.
Change subject: IMPALA-5547: Rework FK/PK join detection.
..
Patch Set 3:
New tests are complete now.
--
To view, visit http://gerrit.cloudera.org:8080/7257
To unsubscribe, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
Patch Set 6: Code-Review+2
Okay, if we have precedence for "silently" deprecating, then that's fine.
--
To view,
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5560: always store CHAR(N) inline in tuple
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7303
To unsubscribe, visit http://
Dan Hecht has posted comments on this change.
Change subject: DRAFT - IMPALA-5498: Support for partial sorts
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7267/2/common/thrift/PlanNodes.thrift
File common/thr
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7303
to look at the new patch set (#6).
Change subject: IMPALA-5560: always store CHAR(N) inline in tuple
..
IMPALA-5560: a
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5560: always store CHAR(N) inline in tuple
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7303/3/be/src/exec/parquet-column-readers.cc
F
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
Patch Set 6:
We could probably use the GFlag validator mechanism:
https://gflags.github.io/gflags/#validate
-
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
Patch Set 6:
Sorry meant to respond to that one. We don't generally warn on deprecated
command-line flags. E.g
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5560: always store CHAR(N) inline in tuple
..
Patch Set 5: Code-Review+2
Meant to +2 but please see previous comment.
--
To view, visit http://gerrit.cloude
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5560: always store CHAR(N) inline in tuple
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7303/3/be/src/exec/parquet-column-readers.cc
File
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
Patch Set 6:
What about this question:
> Maybe print something to the warning log if either flag is set to true?
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and
beeswax RPCs
..
Patch Set 12: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7155
To un
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.
..
Patch Set 9: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6527/8/be/src/exec/hd
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5281: stress test: introduce stricter pass guidelines
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7282/2/tests/stress/concurrent_select.p
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5240: Allow config of number of disk I/O threads per
disk type
..
Patch Set 7:
(12 comments)
http://gerrit.cloudera.org:8080/#/c/7232/7//COMMIT_MSG
Com
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and
beeswax RPCs
..
Patch Set 12:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-
Lars Volker has posted comments on this change.
Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and
beeswax RPCs
..
Patch Set 12:
Regarding testing, I haven't been able to repro the issue since PS 7, whi
Lars Volker has posted comments on this change.
Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and
beeswax RPCs
..
Patch Set 12: Code-Review+2
(2 comments)
Thank for the review. I addressed the last co
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7155
to look at the new patch set (#12).
Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and
beeswax RPCs
..
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-5547: Rework FK/PK join detection.
..
Patch Set 2:
(2 comments)
Just minor responses; thanks for the clarifications. I'll take a look at the
tes
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3504: UDF for current timestamp in UTC
..
Patch Set 6:
Not sure why the aws download failed, but this could use a rebase anyway
--
To view, visit http:
Michael Brown has posted comments on this change.
Change subject: IMPALA-5281: stress test: introduce stricter pass guidelines
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7282/2/tests/stress/concurrent_sele
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
Patch Set 5:
PS5 was a rebase, PS6 addressed the comment
--
To view, visit http://gerrit.cloudera.org:8080/71
Tim Armstrong has uploaded a new patch set (#6).
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
IMPALA-4674: Part 1: remove old aggs and joins
This is intended to be merged at the same time as Part 2 but is
se
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7102/4/be/src/exec/blocking-join-node.cc
File be
Tim Armstrong has uploaded a new patch set (#5).
Change subject: IMPALA-4674: Part 1: remove old aggs and joins
..
IMPALA-4674: Part 1: remove old aggs and joins
This is intended to be merged at the same time as Part 2 but is
se
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5560: always store CHAR(N) inline in tuple
..
Patch Set 5:
A couple of tests referred to the in/out-of-line char optimisation in comments.
Fixed those.
Tim Armstrong has uploaded a new patch set (#5).
Change subject: IMPALA-5560: always store CHAR(N) inline in tuple
..
IMPALA-5560: always store CHAR(N) inline in tuple
This is done to simplify the CHAR(N) logic. I believe this i
Tim Armstrong has uploaded a new patch set (#3).
Change subject: IMPALA-5560: always store CHAR(N) inline in tuple
..
IMPALA-5560: always store CHAR(N) inline in tuple
This is done to simplify the CHAR(N) logic. I believe this i
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5560: always store CHAR(N) inline in tuple
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7303/2/be/src/exec/hash-table.cc
File be/src/
Vincent Tran has posted comments on this change.
Change subject: IMPALA-5524: Fixes NPE during planning with
DISABLE_UNFASE_SPILLS=1
..
Patch Set 2:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/7219/2/fe/src/main/java/or
Vincent Tran has uploaded a new patch set (#3).
Change subject: IMPALA-5524: Fixes NPE during planning with
DISABLE_UNFASE_SPILLS=1
..
IMPALA-5524: Fixes NPE during planning with DISABLE_UNFASE_SPILLS=1
This change will avoid a
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5588: Reduce the frequency of fault injection
..
IMPALA-5588: Reduce the frequency of fault injection
Previously, the fault injection uti
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5588: Reduce the frequency of fault injection
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7310
To unsubscribe, v
Alex Behm has uploaded a new patch set (#3).
Change subject: IMPALA-5547: Rework FK/PK join detection.
..
IMPALA-5547: Rework FK/PK join detection.
Reworks the FK/PK join detection logic to:
- more accurately recognize many-to-m
Alex Behm has posted comments on this change.
Change subject: IMPALA-5547: Rework FK/PK join detection.
..
Patch Set 2:
(9 comments)
Responding to comments. New tests are still WIP.
http://gerrit.cloudera.org:8080/#/c/7257/2/
98 matches
Mail list logo
