[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-11-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 22: Code-Review+2 (7

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-11-09 Thread Pranay Singh (Code Review)
Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 16: (10 comments)

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-11-09 Thread Pranay Singh (Code Review)
Hello Joe McDonnell, Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8034 to look at the new patch set (#16). Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

[Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu

2017-11-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/7793 ) Change subject: IMPALA-4252: Min-max runtime filters for Kudu .. Patch Set 14: Code-Review+1 (1 comment) I'm happy with this change. Nice

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8498 ) Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8498 ) Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter .. IMPALA-6164: Fix stale query profile

[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE

2017-11-09 Thread Matthew Mulder (Code Review)
Matthew Mulder has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs

2017-11-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8456 ) Change subject: IMPALA-6148: Specifying thirdparty deps as URLs .. IMPALA-6148: Specifying thirdparty deps as URLs If

[Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs

2017-11-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8456 ) Change subject: IMPALA-6148: Specifying thirdparty deps as URLs .. Patch Set 7: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6160: Rework query execution to handle multiple statements in a Query object.

2017-11-09 Thread Tim Wood (Code Review)
Tim Wood has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8513 Change subject: IMPALA-6160: Rework query execution to handle multiple statements in a Query object. .. IMPALA-6160: Rework query execution

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. Patch Set 3: (3 comments) Didn't look at the frontend part.

[Impala-ASF-CR] IMPALA-6170: Remove broken backend test from llvm-codegen-test

2017-11-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8505 ) Change subject: IMPALA-6170: Remove broken backend test from llvm-codegen-test .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8498 ) Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8498 ) Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-2235: Fix current db when shell auto-reconnects

2017-11-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8368 ) Change subject: IMPALA-2235: Fix current db when shell auto-reconnects .. Patch Set 3: Phil, did you want to take another look at

[Impala-ASF-CR] IMPALA-6084: Avoid using of global namespace for llvm

2017-11-09 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8489 ) Change subject: IMPALA-6084: Avoid using of global namespace for llvm .. Patch Set 4: > I'm ok with using llvm:: in those files, but

[Impala-ASF-CR] IMPALA-6084: Avoid using of global namespace for llvm

2017-11-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8489 ) Change subject: IMPALA-6084: Avoid using of global namespace for llvm .. Patch Set 4: I'm ok with using llvm:: in those files, but was

[Impala-ASF-CR] IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction

2017-11-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8436 ) Change subject: IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction .. Patch Set 4: (4 comments) Looks

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-09 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8498 ) Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter .. Patch Set 4: The change in base64 decoding broke a test

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-09 Thread Tianyi Wang (Code Review)
Hello Sailesh Mukil, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8498 to look at the new patch set (#4). Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

[Impala-ASF-CR](asf-site) Update Impala docs for 2.10 release

2017-11-09 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8511 ) Change subject: Update Impala docs for 2.10 release .. Patch Set 2: (1 comment) Just 1 nit (see below), but otherwise I think this

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-09 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8270 to look at the new patch set (#3). Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos ..

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-09 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 3: (11 comments)

[Impala-ASF-CR] IMPALA-6173: Fix SHOW CREATE TABLE for unpartitioned Kudu tables

2017-11-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8506 ) Change subject: IMPALA-6173: Fix SHOW CREATE TABLE for unpartitioned Kudu tables .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6121: remove I/O mgr request context cache

2017-11-09 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Tianyi Wang, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8408 to look at the new patch set (#8). Change subject: IMPALA-6121: remove I/O mgr request context cache

[Impala-ASF-CR] IMPALA-6121: remove I/O mgr request context cache

2017-11-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8408 ) Change subject: IMPALA-6121: remove I/O mgr request context cache .. Patch Set 7: (4 comments)

[Impala-ASF-CR](asf-site) Update Impala docs for 2.10 release

2017-11-09 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8511 ) Change subject: Update Impala docs for 2.10 release .. Patch Set 2: > Patch Set 2: > > I realized what the hiccup was in the procedure

[Impala-ASF-CR](asf-site) Update Impala docs for 2.10 release

2017-11-09 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. ( http://gerrit.cloudera.org:8080/8511 ) Change subject: Update Impala docs for 2.10 release .. Patch Set 2: Code-Review+1 Downloaded your changes and PDF, HTML look good. --

[Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs

2017-11-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8456 ) Change subject: IMPALA-6148: Specifying thirdparty deps as URLs .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs

2017-11-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8456 ) Change subject: IMPALA-6148: Specifying thirdparty deps as URLs .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs

2017-11-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8456 ) Change subject: IMPALA-6148: Specifying thirdparty deps as URLs .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR](asf-site) Update Impala docs for 2.10 release

2017-11-09 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8511 ) Change subject: Update Impala docs for 2.10 release .. Patch Set 2: I also checked the size and contents of impala-2.10.pdf to make

[Impala-ASF-CR](asf-site) Update Impala docs for 2.10 release

2017-11-09 Thread John Russell (Code Review)
Hello Bharath Vissapragada, Michael Brown, Laurel Hale, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8511 to look at the new patch set (#2). Change subject: Update Impala docs for 2.10 release

[Impala-ASF-CR](asf-site) Update Impala docs for 2.10 release

2017-11-09 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8511 ) Change subject: Update Impala docs for 2.10 release .. Patch Set 2: I realized what the hiccup was in the procedure - checking out

[Impala-ASF-CR](asf-site) Update Impala docs for 2.10 release

2017-11-09 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8511 ) Change subject: Update Impala docs for 2.10 release .. Patch Set 1: Looks like somehow my 'git add *.html' only picked up new HTML

[Impala-ASF-CR](asf-site) Update Impala docs for 2.10 release

2017-11-09 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8511 ) Change subject: Update Impala docs for 2.10 release .. Patch Set 1: Laurel and I are proofreading now, this is mainly an FYI for

[Impala-ASF-CR](asf-site) Update Impala docs for 2.10 release

2017-11-09 Thread John Russell (Code Review)
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8511 Change subject: Update Impala docs for 2.10 release .. Update Impala docs for 2.10 release Commit hash =

[Impala-ASF-CR] IMPALA-6170: Remove broken backend test from llvm-codegen-test

2017-11-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8505 ) Change subject: IMPALA-6170: Remove broken backend test from llvm-codegen-test .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6173: Fix SHOW CREATE TABLE for unpartitioned Kudu tables

2017-11-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8506 ) Change subject: IMPALA-6173: Fix SHOW CREATE TABLE for unpartitioned Kudu tables .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6173: Fix SHOW CREATE TABLE for unpartitioned Kudu tables

2017-11-09 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8506 ) Change subject: IMPALA-6173: Fix SHOW CREATE TABLE for unpartitioned Kudu tables .. Patch Set 1: GVO failure was unrelated.

[Impala-ASF-CR] IMPALA-6173: Fix SHOW CREATE TABLE for unpartitioned Kudu tables

2017-11-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8506 ) Change subject: IMPALA-6173: Fix SHOW CREATE TABLE for unpartitioned Kudu tables .. Patch Set 1: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-11-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8023 ) Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 13: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-11-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8023 ) Change subject: IMPALA-4856: Port data stream service to KRPC .. IMPALA-4856: Port data stream service to KRPC This

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

2017-11-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt .. Patch Set 7: (3 comments) I kept on pulling at the error

[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

2017-11-09 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8447 ) Change subject: IMPALA-2181: Add query option levels for display .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

2017-11-09 Thread Gabor Kaszab (Code Review)
Hello Lars Volker, Laszlo Gaal, Zoltan Borok-Nagy, Philip Zeyliger, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8447 to look at the new patch set (#10). Change subject: IMPALA-2181: Add query

[Impala-ASF-CR] IMPALA-6121: remove I/O mgr request context cache

2017-11-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8408 ) Change subject: IMPALA-6121: remove I/O mgr request context cache .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu

2017-11-09 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/7793 ) Change subject: IMPALA-4252: Min-max runtime filters for Kudu .. Patch Set 14: (7 comments)

[Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu

2017-11-09 Thread Thomas Tauber-Marshall (Code Review)
Hello Michael Ho, Lars Volker, Matthew Jacobs, Anonymous Coward #345, Tim Armstrong, Todd Lipcon, Mostafa Mokhtar, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7793 to look at the new patch set (#14). Change subject: IMPALA-4252:

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-11-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8023 ) Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs

2017-11-09 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8456 ) Change subject: IMPALA-6148: Specifying thirdparty deps as URLs .. Patch Set 6: Well, that's what I get for being clever with bash.

[Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs

2017-11-09 Thread Philip Zeyliger (Code Review)
Hello David Knupp, Joe McDonnell, Zach Amsden, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8456 to look at the new patch set (#6). Change subject: IMPALA-6148: Specifying thirdparty deps as URLs

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-11-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8023 ) Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 13: Build started:

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-11-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8023 ) Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 13: Code-Review+2 Retested the new PS. Carry+2. -- To view,

[Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs

2017-11-09 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8456 ) Change subject: IMPALA-6148: Specifying thirdparty deps as URLs .. Patch Set 5: (1 comment) Thanks for starting that

[Impala-ASF-CR] IMPALA-6173: Fix SHOW CREATE TABLE for unpartitioned Kudu tables

2017-11-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8506 ) Change subject: IMPALA-6173: Fix SHOW CREATE TABLE for unpartitioned Kudu tables .. Patch Set 1: Build started: