[kudu-CR] WIP: Address alter table randomized-test flakyness on ResultTracker

2016-10-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/4629 Change subject: WIP: Address alter_table_randomized-test flakyness on ResultTracker .. WIP: Address alter_table_randomized-test fl

[kudu-CR] loadgen: allow configuring the number of buckets

2016-10-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: loadgen: allow configuring the number of buckets .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4625 To unsubscribe, visi

[kudu-CR] [c++ client] notes for timestamp-related methods

2016-10-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: [c++ client] notes for timestamp-related methods .. [c++ client] notes for timestamp-related methods Added notes on anticipated changes on methods

[kudu-CR] [c++ client] notes for timestamp-related methods

2016-10-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [c++ client] notes for timestamp-related methods .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4569 To unsubscribe, visi

[kudu-CR] KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

2016-10-05 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone .. Patch Set 3: (5 comments) TFTR Alexey, http://gerrit.cloudera.org:8080/#/c/4594/3/src

[kudu-CR] KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

2016-10-05 Thread Dinesh Bhat (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4594 to look at the new patch set (#4). Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone .

[kudu-CR] Running kudu-spark tests alone fail finding build dir

2016-10-05 Thread Mladen Kovacevic (Code Review)
Mladen Kovacevic has uploaded a new change for review. http://gerrit.cloudera.org:8080/4630 Change subject: Running kudu-spark tests alone fail finding build dir .. Running kudu-spark tests alone fail finding build dir When r

[kudu-CR] consensus: refactor tracking of received OpIds out of ReplicaState

2016-10-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: consensus: refactor tracking of received OpIds out of ReplicaState .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4476/2/src/kudu/conse

[kudu-CR] consensus: refactor tracking of received OpIds out of ReplicaState

2016-10-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: refactor tracking of received OpIds out of ReplicaState .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4476/2/src/kudu/consensus/raft

[kudu-CR] loadgen: allow configuring the number of buckets

2016-10-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: loadgen: allow configuring the number of buckets .. loadgen: allow configuring the number of buckets Change-Id: Idf0ae3e95b90d38829dba67a9ccc2dfbe2b5b09b

[kudu-CR] Running kudu-spark tests alone fail finding build dir

2016-10-05 Thread Mladen Kovacevic (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4630 to look at the new patch set (#2). Change subject: Running kudu-spark tests alone fail finding build dir .. Running

[kudu-CR] KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

2016-10-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4594 To

[kudu-CR] Running kudu-spark tests alone fail finding build dir

2016-10-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Running kudu-spark tests alone fail finding build dir .. Patch Set 2: I'm not sure I agree with the premise of this patch. Running the kudu-spark tests against a

[kudu-CR] delete table-test: fix flakiness with table creation timeout

2016-10-05 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4632 to review the following change. Change subject: delete_table-test: fix flakiness with table creation timeout ...

[kudu-CR] kudu-spark pom.xml has malformed artifactId

2016-10-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: kudu-spark pom.xml has malformed artifactId .. Patch Set 1: Code-Review-1 Even though maven complains about this, it's a very common pattern in the Scala world.

[kudu-CR] Running kudu-spark tests alone fail finding build dir

2016-10-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Running kudu-spark tests alone fail finding build dir .. Patch Set 2: Code-Review-1 -- To view, visit http://gerrit.cloudera.org:8080/4630 To unsubscribe, visit h

[kudu-CR] Running kudu-spark tests alone fail finding build dir

2016-10-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Running kudu-spark tests alone fail finding build dir .. Patch Set 2: I forget: do we already have an easy way to override the "search for binaries" from the comm

[kudu-CR] KUDU-1640 - [python] Add IN-list predicate support

2016-10-05 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1640 - [python] Add IN-list predicate support .. KUDU-1640 - [python] Add IN-list predicate support This patch adds IN list predicate support for the

[kudu-CR] KUDU-1640 - [python] Add IN-list predicate support

2016-10-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1640 - [python] Add IN-list predicate support .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4548 To unsubscribe, visit http

[kudu-CR] refactor schema-design guide

2016-10-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: refactor schema-design guide .. Patch Set 1: (10 comments) http://gerrit.cloudera.org:8080/#/c/4485/1//COMMIT_MSG Commit Message: PS1, Line 7: r Nit capi

[kudu-CR] kernel stack watchdog: avoid blocking threads starting

2016-10-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: kernel_stack_watchdog: avoid blocking threads starting .. Patch Set 2: Code-Review+2 (2 comments) Looks good, though it looks like you still have a broken test. B

[kudu-CR] refactor schema-design guide

2016-10-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: refactor schema-design guide .. Patch Set 1: (14 comments) http://gerrit.cloudera.org:8080/#/c/4485/1/docs/schema_design.adoc File docs/schema_design.adoc: PS1,

[kudu-CR] consensus: refactor tracking of received OpIds out of ReplicaState

2016-10-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: consensus: refactor tracking of received OpIds out of ReplicaState .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4476/2/src/kudu/consen

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

2016-10-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4520/4/python/kudu/tests/tes

[kudu-CR] KUDU-1671 - [python] Enable predicate pushdown for additional types

2016-10-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1671 - [python] Enable predicate pushdown for additional types .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4589

[kudu-CR] KUDU-1671 - [python] Enable predicate pushdown for additional types

2016-10-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1671 - [python] Enable predicate pushdown for additional types .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4589/2/python/kudu/te

[kudu-CR] Add script to run clang-tidy against a patch

2016-10-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add script to run clang-tidy against a patch .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/4381/3/build-support/clang_tidy_gerrit.py File build-

[kudu-CR] Add script to run clang-tidy against a patch

2016-10-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add script to run clang-tidy against a patch .. Patch Set 3: Forgot to ask: how is clang_tidy_gerrit.py invoked? -- To view, visit http://gerrit.cloudera.org:8080

[kudu-CR] KUDU-1567. Decouple hard-minimum WAL segment retention from target

2016-10-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1567. Decouple hard-minimum WAL segment retention from target .. Patch Set 5: (3 comments) just nits really. looking good http://gerrit.cloudera.or

[kudu-CR] kernel stack watchdog: avoid blocking threads starting

2016-10-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: kernel_stack_watchdog: avoid blocking threads starting .. Patch Set 2: (2 comments) To find the root causes I was basically just looking at gstacks and adding LO

[kudu-CR] consensus: refactor tracking of received OpIds out of ReplicaState

2016-10-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: refactor tracking of received OpIds out of ReplicaState .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4476/2/src/kudu/consensus/raft

[kudu-CR] consensus: refactor tracking of received OpIds out of ReplicaState

2016-10-05 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4476 to look at the new patch set (#3). Change subject: consensus: refactor tracking of received OpIds out of ReplicaState .

[kudu-CR] KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

2016-10-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone .. KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone Read

[kudu-CR] WIP: Address alter table randomized-test flakyness on ResultTracker

2016-10-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: Address alter_table_randomized-test flakyness on ResultTracker .. Patch Set 1: Looks reasonable. A repro would be nice -- To view, visit http://gerrit.clou

[kudu-CR] mem tracker: fix race between FindTracker() and destructor

2016-10-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: mem_tracker: fix race between FindTracker() and destructor .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4614/1/src/kudu/util/mem_tracker-test.cc

[kudu-CR] mem tracker: fix race between FindTracker() and destructor

2016-10-05 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded a new patch set (#2). Change subject: mem_tracker: fix race between FindTracker() and destructor .. mem_tracker: fix race between FindTracker() and destructor In very rare cases, it's possible for an inte

[kudu-CR] delete table-test: fix flakiness with table creation timeout

2016-10-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: delete_table-test: fix flakiness with table creation timeout .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4632/1/src/kudu/integration-t

[kudu-CR] delete table-test: fix flakiness with table creation timeout

2016-10-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: delete_table-test: fix flakiness with table creation timeout .. Patch Set 1: Code-Review+2 Looks fine to me, will defer to David since he left some comments. -- T

[kudu-CR] delete table-test: fix flakiness with table creation timeout

2016-10-05 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4632 to look at the new patch set (#2). Change subject: delete_table-test: fix flakiness with table creation timeout

[kudu-CR] KUDU-1671 - [python] Enable predicate pushdown for additional types

2016-10-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1671 - [python] Enable predicate pushdown for additional types .. Patch Set 3: seems like this needs a rebase before merging? -- To view, visit htt

[kudu-CR] consensus: refactor tracking of received OpIds out of ReplicaState

2016-10-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: consensus: refactor tracking of received OpIds out of ReplicaState .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4476/2/s

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

2016-10-05 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4520 to look at the new patch set (#7). Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning ..

[kudu-CR] delete table-test: fix flakiness with table creation timeout

2016-10-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: delete_table-test: fix flakiness with table creation timeout .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4632 To unsub

[kudu-CR] delete table-test: fix flakiness with table creation timeout

2016-10-05 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: delete_table-test: fix flakiness with table creation timeout .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4632 To unsubscribe,

[kudu-CR] Add a design doc for rpc retry/failover semantics

2016-10-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add a design doc for rpc retry/failover semantics .. Patch Set 7: (11 comments) http://gerrit.cloudera.org:8080/#/c/2642/7/docs/design-docs/rpc-retry-and-failover

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

2016-10-05 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4520 to look at the new patch set (#8). Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning ..

[kudu-CR] refactor schema-design guide

2016-10-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: refactor schema-design guide .. Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/4485/1/docs/schema_design.adoc File docs/schema_design.adoc: PS1,

[kudu-CR] kernel stack watchdog: avoid blocking threads starting

2016-10-05 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4626 to look at the new patch set (#3). Change subject: kernel_stack_watchdog: avoid blocking threads starting ..

[kudu-CR] kernel stack watchdog: avoid blocking threads starting

2016-10-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: kernel_stack_watchdog: avoid blocking threads starting .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4626 To unsubscribe, visit h

[kudu-CR] delete table-test: fix flakiness with table creation timeout

2016-10-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: delete_table-test: fix flakiness with table creation timeout .. delete_table-test: fix flakiness with table creation timeout This test was timing

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

2016-10-05 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4520 to look at the new patch set (#9). Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning ..

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

2016-10-05 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4520 to look at the new patch set (#10). Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning ..

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

2016-10-05 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/4520/4/python/kudu/tests/test_s

[kudu-CR] Running kudu-spark tests alone fail finding build dir

2016-10-05 Thread Mladen Kovacevic (Code Review)
Mladen Kovacevic has posted comments on this change. Change subject: Running kudu-spark tests alone fail finding build dir .. Patch Set 2: So this is interesting. If I go under java/kudu-spark and from there run "mvn clean pac

[kudu-CR] Running kudu-spark tests alone fail finding build dir

2016-10-05 Thread Mladen Kovacevic (Code Review)
Mladen Kovacevic has posted comments on this change. Change subject: Running kudu-spark tests alone fail finding build dir .. Patch Set 2: It seems a little 'hackish' anyway looking for the base kudu-client test class's locati

[kudu-CR] kudu-spark pom.xml has malformed artifactId

2016-10-05 Thread Mladen Kovacevic (Code Review)
Mladen Kovacevic has posted comments on this change. Change subject: kudu-spark pom.xml has malformed artifactId .. Patch Set 1: I see. Annoying, but I suppose it'll save changing it in two places in the pom file. -- To view

[kudu-CR] kernel stack watchdog: avoid blocking threads starting

2016-10-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: kernel_stack_watchdog: avoid blocking threads starting .. Patch Set 3: Verified+1 Other known flakies -- To view, visit http://gerrit.cloudera.org:8080/4626 To u

[kudu-CR] kernel stack watchdog: avoid blocking threads starting

2016-10-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: kernel_stack_watchdog: avoid blocking threads starting .. kernel_stack_watchdog: avoid blocking threads starting I've noticed recently that threads start

[kudu-CR] [java client] Rename NoLeaderMasterFoundException and reuse

2016-10-05 Thread Jean-Daniel Cryans (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4624 to look at the new patch set (#2). Change subject: [java client] Rename NoLeaderMasterFoundException and reuse

[kudu-CR] [java client] Rename NoLeaderMasterFoundException and reuse

2016-10-05 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Rename NoLeaderMasterFoundException and reuse .. Patch Set 1: > I'm assuming you want to keep around NoSuitableReplicaException for > future

[kudu-CR] consensus: refactor tracking of received OpIds out of ReplicaState

2016-10-05 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4476 to look at the new patch set (#4). Change subject: consensus: refactor tracking of received OpIds out of ReplicaState

[kudu-CR] KUDU-1671 - [python] Enable predicate pushdown for additional types

2016-10-05 Thread Jordan Birdsell (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4589 to look at the new patch set (#4). Change subject: KUDU-1671 - [python] Enable predicate pushdown for additional types ...

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

2016-10-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4520 To uns

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

2016-10-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning .. Patch Set 10: Is is safe to merge this without the parent? -- To view, visit http://gerr

[kudu-CR] KUDU-1567. Decouple hard-minimum WAL segment retention from target

2016-10-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1567. Decouple hard-minimum WAL segment retention from target .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/4470/5/src/kudu/tablet/tablet

[kudu-CR] KUDU-1567. Decouple hard-minimum WAL segment retention from target

2016-10-05 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4470 to look at the new patch set (#6). Change subject: KUDU-1567. Decouple hard-minimum WAL segment retention from target

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

2016-10-05 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning .. Patch Set 10: This is revised to master so you're good -- To view, visit http://gerrit.cloud

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

2016-10-05 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning .. Patch Set 10: Revised*... autocorrect -- To view, visit http://gerrit.cloudera.org:8080/4520

[kudu-CR] mem tracker: fix race between FindTracker() and destructor

2016-10-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: mem_tracker: fix race between FindTracker() and destructor .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4614 To unsubscribe, vi

[kudu-CR] mem tracker: fix race between FindTracker() and destructor

2016-10-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: mem_tracker: fix race between FindTracker() and destructor .. mem_tracker: fix race between FindTracker() and destructor In very rare cases, it's possible

[kudu-CR] [java client] Temporarily ignore row count regressions in ITClient

2016-10-05 Thread Jean-Daniel Cryans (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4597 to look at the new patch set (#2). Change subject: [java client] Temporarily ignore row count regressions in ITClient

[kudu-CR] [java client] Temporarily ignore row count regressions in ITClient

2016-10-05 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Temporarily ignore row count regressions in ITClient .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4597/2/java/kudu-client

[kudu-CR] Running kudu-spark tests alone fail finding build dir

2016-10-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Running kudu-spark tests alone fail finding build dir .. Patch Set 2: -Code-Review > I just wanted to make sure that once you pull down the image, if you go > str

[kudu-CR] raft consensus: clean up overrides, protected methods

2016-10-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: raft_consensus: clean up overrides, protected methods .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4620 To unsubscribe, visit h

[kudu-CR] raft consensus: clean up overrides, protected methods

2016-10-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: raft_consensus: clean up overrides, protected methods .. raft_consensus: clean up overrides, protected methods RaftConsensus used to have a subclass mock

[kudu-CR] consensus: refactor tracking of received OpIds out of ReplicaState

2016-10-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: refactor tracking of received OpIds out of ReplicaState .. Patch Set 4: Code-Review+2 Just rebased -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] consensus: refactor tracking of received OpIds out of ReplicaState

2016-10-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: consensus: refactor tracking of received OpIds out of ReplicaState .. consensus: refactor tracking of received OpIds out of ReplicaState The PeerMessageQ

[kudu-CR] maintenance manager-test: fix flaky test

2016-10-05 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4634 to review the following change. Change subject: maintenance_manager-test: fix flaky test .. mainte

[kudu-CR] [java client] Rename NoLeaderMasterFoundException and reuse

2016-10-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java client] Rename NoLeaderMasterFoundException and reuse .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4624 To unsubscribe, v

[kudu-CR] maintenance manager-test: fix flaky test

2016-10-05 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: maintenance_manager-test: fix flaky test .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4634 To unsubscribe, visit http://

[kudu-CR] raft: set threadpool timeout to be longer than heartbeat interval

2016-10-05 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4635 to review the following change. Change subject: raft: set threadpool timeout to be longer than heartbeat interval

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

2016-10-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning .. KUDU-1612 - [python] Enable setting of read mode for scanning Currently the pytho

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

2016-10-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning .. Patch Set 10: I guess you meant rebased :) -- To view, visit http://gerrit.cloudera.org:

[kudu-CR] KUDU-1669. Java client tests leak orphan processes (part 2)

2016-10-05 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/4636 Change subject: KUDU-1669. Java client tests leak orphan processes (part 2) .. KUDU-1669. Java client tests leak orphan processes (p

[kudu-CR] KUDU-1669. Java ITClient test can orphan processes

2016-10-05 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4598 to look at the new patch set (#2). Change subject: KUDU-1669. Java ITClient test can orphan processes .. KUDU-1669.

[kudu-CR] [java client] Retry regressing counts in ITClient

2016-10-05 Thread Jean-Daniel Cryans (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4597 to look at the new patch set (#3). Change subject: [java client] Retry regressing counts in ITClient ..

[kudu-CR] [java client] Retry regressing counts in ITClient

2016-10-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Retry regressing counts in ITClient .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4597/3/java/kudu-client/src/test/java/org/apache/

[kudu-CR] KUDU-1669. Java ITClient test can orphan processes

2016-10-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1669. Java ITClient test can orphan processes .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4598/2/java/kudu-client/src/test/java/org/apache

[kudu-CR] maintenance manager-test: fix flaky test

2016-10-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: maintenance_manager-test: fix flaky test .. maintenance_manager-test: fix flaky test TestCompletedOps failed relatively often because of the following rac

[kudu-CR] KUDU-1669. Java client tests leak orphan processes (part 2)

2016-10-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1669. Java client tests leak orphan processes (part 2) .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4636/1/java/kudu-client/src/test/java/

[kudu-CR] [java client] Retry regressing counts in ITClient

2016-10-05 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Retry regressing counts in ITClient .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4597/3/java/kudu-client/src/test/java/org

[kudu-CR] [java client] Rename NoLeaderMasterFoundException and reuse

2016-10-05 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java client] Rename NoLeaderMasterFoundException and reuse .. [java client] Rename NoLeaderMasterFoundException and reuse I pushed d87486c too fas

[kudu-CR] [java client] Retry regressing counts in ITClient

2016-10-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Retry regressing counts in ITClient .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4597/3/java/kudu-client/src/test/java/org/apache/

[kudu-CR] [java client] Retry regressing counts in ITClient

2016-10-05 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Retry regressing counts in ITClient .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4597/3/java/kudu-client/src/test/java/org

[kudu-CR] KUDU-1669. Java client tests leak orphan processes (part 2)

2016-10-05 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1669. Java client tests leak orphan processes (part 2) .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4636/1/java/kudu-client/src/te

[kudu-CR] KUDU-1669. Java client tests leak orphan processes (part 2)

2016-10-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1669. Java client tests leak orphan processes (part 2) .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4636/1/java/kudu-client/src/test/java/o

[kudu-CR] KUDU-1669. Java client tests leak orphan processes (part 2)

2016-10-05 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4636 to look at the new patch set (#2). Change subject: KUDU-1669. Java client tests leak orphan processes (part 2) .. K

[kudu-CR] [java client] Retry regressing counts in ITClient

2016-10-05 Thread Jean-Daniel Cryans (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4597 to look at the new patch set (#4). Change subject: [java client] Retry regressing counts in ITClient ..

[kudu-CR] KUDU-1669. Java ITClient test can orphan processes

2016-10-05 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4598 to look at the new patch set (#3). Change subject: KUDU-1669. Java ITClient test can orphan processes .. KUDU-1669.

[kudu-CR] KUDU-1669. Java client tests leak orphan processes (part 2)

2016-10-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1669. Java client tests leak orphan processes (part 2) .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4636/1/java/kudu-client/src/test/java/o

  1   2   >