[kudu-CR] [WIP] KUDU-721 Support for Decimal type: Part 1 (C++)

2016-11-15 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [WIP] KUDU-721 Support for Decimal type: Part 1 (C++) .. Patch Set 2: (16 comments) I, for one, welcome our new bot overlord.

[kudu-CR] [WIP] KUDU-721 Support for Decimal type: Part 1 (C++)

2016-11-15 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5104 to look at the new patch set (#3). Change subject: [WIP] KUDU-721 Support for Decimal type: Part 1 (C++) .. [WIP]

[kudu-CR] KUDU-1679 Propagate timestamps for scans

2016-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1679 Propagate timestamps for scans .. Patch Set 2: (1 comment) > I mention this yesterday, but it was pretty late and maybe you > didn't get a chance to

[kudu-CR] [WIP] KUDU-721 Support for Decimal type: Part 1 (C++)

2016-11-15 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5104 to look at the new patch set (#2). Change subject: [WIP] KUDU-721 Support for Decimal type: Part 1 (C++) .. [WIP]

[kudu-CR] [WIP] KUDU-721 Support for Decimal type: Part 1 (C++)

2016-11-15 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/5104 Change subject: [WIP] KUDU-721 Support for Decimal type: Part 1 (C++) .. [WIP] KUDU-721 Support for Decimal type: Part 1 (C++) This

[kudu-CR] el6: fix krb5 realm workaround for static builds

2016-11-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: el6: fix krb5 realm workaround for static builds .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/5100/4//COMMIT_MSG Commit Message: PS4, Line

[kudu-CR] [Timestamp] use 'operator<' instead of ComesBefore

2016-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. Change subject: [Timestamp] use 'operator<' instead of ComesBefore .. Abandoned submitted wrong change -- To view, visit http://gerrit.cloudera.org:8080/5102 To unsubscribe, visit

[kudu-CR] [Timestamp] use 'operator<' instead of ComesBefore

2016-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5102 Change subject: [Timestamp] use 'operator<' instead of ComesBefore .. [Timestamp] use 'operator<' instead of ComesBefore Added more

[kudu-CR] sasl: add a leak suppression for krb5 1.10

2016-11-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: sasl: add a leak suppression for krb5 1.10 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5101 To unsubscribe, visit

[kudu-CR] el6: fix krb5 realm workaround for static builds

2016-11-15 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5100 to look at the new patch set (#4). Change subject: el6: fix krb5 realm workaround for static builds

[kudu-CR] sasl: add a leak suppression for krb5 1.10

2016-11-15 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5101 to look at the new patch set (#3). Change subject: sasl: add a leak suppression for krb5 1.10

[kudu-CR] el6: fix krb5 realm workaround for static builds

2016-11-15 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5100 to look at the new patch set (#3). Change subject: el6: fix krb5 realm workaround for static builds

[kudu-CR] el6: fix krb5 realm workaround for static builds

2016-11-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: el6: fix krb5 realm workaround for static builds .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5100/1/src/kudu/security/CMakeLists.txt File

[kudu-CR] sasl: add a leak suppression for krb5 1.10

2016-11-15 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5101 to review the following change. Change subject: sasl: add a leak suppression for krb5 1.10 .. sasl: add a

[kudu-CR] el6: fix krb5 realm workaround for static builds

2016-11-15 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5100 to look at the new patch set (#2). Change subject: el6: fix krb5 realm workaround for static builds

[kudu-CR] [java] Add checkstyle coverage to Java build

2016-11-15 Thread Will Berkeley (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5016 to look at the new patch set (#7). Change subject: [java] Add checkstyle coverage to Java build

[kudu-CR] [java] Add checkstyle coverage to Java build

2016-11-15 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [java] Add checkstyle coverage to Java build .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5016/5//COMMIT_MSG Commit Message: Line 21:

[kudu-CR] log block manager: push down container locks

2016-11-15 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: log block manager: push down container locks .. log block manager: push down container locks This simplifies container logic a bit. PosixRWFile is now

[kudu-CR] env: change various file filename() functions to return copies

2016-11-15 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: env: change various file filename() functions to return copies .. env: change various file filename() functions to return copies I'm doing this so that

[kudu-CR] test util: prefer test dir over GetTestDataDirectory()

2016-11-15 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: test_util: prefer test_dir_ over GetTestDataDirectory() .. test_util: prefer test_dir_ over GetTestDataDirectory() The latter is more expensive to call.

[kudu-CR] env: change various file filename() functions to return copies

2016-11-15 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: env: change various file filename() functions to return copies .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5085 To

[kudu-CR] test util: prefer test dir over GetTestDataDirectory()

2016-11-15 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: test_util: prefer test_dir_ over GetTestDataDirectory() .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5028 To unsubscribe,

[kudu-CR] log block manager: push down container locks

2016-11-15 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: log block manager: push down container locks .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5029 To unsubscribe, visit

[kudu-CR] el6: fix krb5 realm workaround for static builds

2016-11-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: el6: fix krb5 realm workaround for static builds .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5100/1/src/kudu/security/CMakeLists.txt File

[kudu-CR](gh-pages) Add 11/15 weekly update

2016-11-15 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add 11/15 weekly update .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5098 To unsubscribe, visit

[kudu-CR](gh-pages) Add 11/15 weekly update

2016-11-15 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Add 11/15 weekly update .. Add 11/15 weekly update Change-Id: I487b092739b3f921e3ab0b186f82c7f368d84f4f Reviewed-on:

[kudu-CR](gh-pages) Add 11/15 weekly update

2016-11-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add 11/15 weekly update .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5098 To unsubscribe, visit

[kudu-CR](gh-pages) Add 11/15 weekly update

2016-11-15 Thread David Ribeiro Alves (Code Review)
Hello Dinesh Bhat, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5098 to look at the new patch set (#4). Change subject: Add 11/15 weekly update .. Add 11/15 weekly update Change-Id:

[kudu-CR] el6: fix krb5 realm workaround for static builds

2016-11-15 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5100 to review the following change. Change subject: el6: fix krb5 realm workaround for static builds .. el6:

[kudu-CR] log block manager: push down container locks

2016-11-15 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5029 to look at the new patch set (#4). Change subject: log block manager: push down container locks .. log block

[kudu-CR](gh-pages) Add 11/15 weekly update

2016-11-15 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add 11/15 weekly update .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/5098/3/_posts/2016-11-15-weekly-update.md File

[kudu-CR] [c++client] propagating timestamp for scans

2016-11-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [c++client] propagating timestamp for scans .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5099/2//COMMIT_MSG Commit Message: Line 7:

[kudu-CR](gh-pages) Add 11/15 weekly update

2016-11-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add 11/15 weekly update .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/5098/3/_posts/2016-11-15-weekly-update.md File

[kudu-CR](gh-pages) Add 11/15 weekly update

2016-11-15 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Add 11/15 weekly update .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/5098/3/_posts/2016-11-15-weekly-update.md File

[kudu-CR](gh-pages) Add 11/15 weekly update

2016-11-15 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#3). Change subject: Add 11/15 weekly update .. Add 11/15 weekly update Change-Id: I487b092739b3f921e3ab0b186f82c7f368d84f4f --- A _posts/2016-11-15-weekly-update.md 1 file

[kudu-CR] [c++client] propagating timestamp for scans

2016-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#2). Change subject: [c++client] propagating timestamp for scans .. [c++client] propagating timestamp for scans KUDU-1679 Propagate timestamps for scans Change-Id:

[kudu-CR] [c++client] propagating timestamp for scans

2016-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5099 Change subject: [c++client] propagating timestamp for scans .. [c++client] propagating timestamp for scans KUDU-1679 Propagate

[kudu-CR] KUDU-1745. Avoid crashing during failed master lookup

2016-11-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1745. Avoid crashing during failed master lookup .. KUDU-1745. Avoid crashing during failed master lookup This addresses a SEGV seen when handling a

[kudu-CR] KUDU-1634. TS and master should delete tmp metadata files on startup

2016-11-15 Thread Maxim Smyatkin (Code Review)
Maxim Smyatkin has posted comments on this change. Change subject: KUDU-1634. TS and master should delete tmp metadata files on startup .. Patch Set 5: Having more specific tmp infix seems good. -- To view, visit

[kudu-CR] WIP: Add a test for maximum number of columns and cell sizes

2016-11-15 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/946 to look at the new patch set (#3). Change subject: WIP: Add a test for maximum number of columns and cell sizes ..

[kudu-CR] KUDU-1634. TS and master should delete tmp metadata files on startup

2016-11-15 Thread Maxim Smyatkin (Code Review)
Maxim Smyatkin has posted comments on this change. Change subject: KUDU-1634. TS and master should delete tmp metadata files on startup .. Patch Set 5: I guess it would need Kudu servers to be executed by someone like root

[kudu-CR] KUDU-1634. TS and master should delete tmp metadata files on startup

2016-11-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1634. TS and master should delete tmp metadata files on startup .. Patch Set 5: Yea, I guess if there's a symlink for the metadata we should follow it, for

[kudu-CR] KUDU-1634. TS and master should delete tmp metadata files on startup

2016-11-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1634. TS and master should delete tmp metadata files on startup .. Patch Set 5: > Are you guys worried about a user somehow accidentally having a > link

[kudu-CR] KUDU-1634. TS and master should delete tmp metadata files on startup

2016-11-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1634. TS and master should delete tmp metadata files on startup .. Patch Set 5: Are you guys worried about a user somehow accidentally having a link from

[kudu-CR] KUDU-1745. Avoid crashing during failed master lookup

2016-11-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1745. Avoid crashing during failed master lookup .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5089 To unsubscribe, visit

[kudu-CR] WIP: Add a test for maximum number of columns and cell sizes

2016-11-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#2). Change subject: WIP: Add a test for maximum number of columns and cell sizes .. WIP: Add a test for maximum number of columns and cell sizes This adds a parameterized test which

[kudu-CR] [java] Add checkstyle coverage to Java build

2016-11-15 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java] Add checkstyle coverage to Java build .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5016/5//COMMIT_MSG Commit Message: Line 21: import

[kudu-CR] python: check status result when setting row contents

2016-11-15 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has submitted this change and it was merged. Change subject: python: check status result when setting row contents .. python: check status result when setting row contents The various PartialRow::Set*()

[kudu-CR] python: check status result when setting row contents

2016-11-15 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: python: check status result when setting row contents .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5018 To unsubscribe,

[kudu-CR] KUDU-1745. Avoid crashing during failed master lookup

2016-11-15 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5089 to look at the new patch set (#3). Change subject: KUDU-1745. Avoid crashing during failed master lookup ..

[kudu-CR] [master] CA management: added SysTable base class

2016-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [master] CA management: added SysTable base class .. Patch Set 1: > Unfortunately I don't think this approach is going to work. > > We originally had

[kudu-CR] KUDU-1745. Avoid crashing during failed master lookup

2016-11-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1745. Avoid crashing during failed master lookup .. Patch Set 2: (2 comments)

[kudu-CR] [Timestamp] use operator '<' instead of ComesBefore

2016-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5096 Change subject: [Timestamp] use operator '<' instead of ComesBefore .. [Timestamp] use operator '<' instead of ComesBefore Added more

[kudu-CR] WIP: [integration tests] scan inconsistency test

2016-11-15 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: [integration tests] scan inconsistency test .. Patch Set 1: (6 comments)

[kudu-CR] KUDU-1634. TS and master should delete tmp metadata files on startup

2016-11-15 Thread Maxim Smyatkin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5007 to look at the new patch set (#5). Change subject: KUDU-1634. TS and master should delete tmp metadata files on startup

[kudu-CR] WIP: [integration tests] scan inconsistency test

2016-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP: [integration tests] scan inconsistency test .. Patch Set 1: > Maybe rename this to 'consistency-itest' or somesuch so that it > provides a useful home for

[kudu-CR] [MonoTime] use operator '<' instead of ComesBefore

2016-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [MonoTime] use operator '<' instead of ComesBefore .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5086 To unsubscribe, visit

[kudu-CR] [MonoTime] use operator '<' instead of ComesBefore

2016-11-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [MonoTime] use operator '<' instead of ComesBefore .. [MonoTime] use operator '<' instead of ComesBefore To bring better readability and please

[kudu-CR] KUDU-1745. Avoid crashing during failed master lookup

2016-11-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1745. Avoid crashing during failed master lookup .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-1634. TS and master should delete tmp metadata files on startup

2016-11-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1634. TS and master should delete tmp metadata files on startup .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-1745. Avoid crashing during failed master lookup

2016-11-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1745. Avoid crashing during failed master lookup .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5089/1/src/kudu/rpc/retriable_rpc.h File