[kudu-CR] KUDU-1796: Use last REPLICATE OpId instead of last COMMIT OpId to tombstone a tablet replica

2016-12-08 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5416 to review the following change. Change subject: KUDU-1796: Use last REPLICATE OpId instead of last COMMIT OpId to tombstone a tablet replica .

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

2016-12-08 Thread Yanlong Zheng (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5237 to look at the new patch set (#5). Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set .

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

2016-12-08 Thread Yanlong Zheng (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5237 to look at the new patch set (#6). Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set .

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

2016-12-08 Thread Yanlong Zheng (Code Review)
Yanlong Zheng has posted comments on this change. Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5237

[kudu-CR] KUDU-1508: enforce block limit on lbm containers

2016-12-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1508: enforce block limit on lbm containers .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/5403/4/src/kudu/util/env.h File src/kudu/util/en

[kudu-CR] dist-test: allow collecting the tmp dir of failed tests

2016-12-08 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2336 to look at the new patch set (#3). Change subject: dist-test: allow collecting the tmp dir of failed tests ...

[kudu-CR] WIP: bug in exactly-once during tablet bootstrap

2016-12-08 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5417 to review the following change. Change subject: WIP: bug in exactly-once during tablet bootstrap .. WIP: bug i

[kudu-CR] KUDU-1624. Fix data race in Trace::MetricsToJSON

2016-12-08 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5419 to review the following change. Change subject: KUDU-1624. Fix data race in Trace::MetricsToJSON .. KUDU-1624. Fix data

[kudu-CR] KUDU-1776: Fix "kudu remote replica copy" connecting to wildcard address

2016-12-08 Thread Dinesh Bhat (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5378 to look at the new patch set (#3). Change subject: KUDU-1776: Fix "kudu remote_replica copy" connecting to wildcard address ..

[kudu-CR] KUDU-1776: Fix "kudu remote replica copy" connecting to wildcard address

2016-12-08 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1776: Fix "kudu remote_replica copy" connecting to wildcard address .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/5378/2/src/kudu/integra

[kudu-CR] KUDU-1624. Fix data race in Trace::MetricsToJSON

2016-12-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1624. Fix data race in Trace::MetricsToJSON .. Patch Set 1: Code-Review+2 nit: Would be nice to note that child_traces_ is protected by lock_ in the header fi

[kudu-CR] dist-test: allow collecting the tmp dir of failed tests

2016-12-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: dist-test: allow collecting the tmp dir of failed tests .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2336 To unsubscribe, visit

[kudu-CR] KUDU-1796: Use last REPLICATE OpId instead of last COMMIT OpId to tombstone a tablet replica

2016-12-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1796: Use last REPLICATE OpId instead of last COMMIT OpId to tombstone a tablet replica .. Patch Set 1: (1 comment) Whoops. Good catch. Looks good, just an e

[kudu-CR] KUDU-1796: Use last REPLICATE OpId instead of last COMMIT OpId to tombstone a tablet replica

2016-12-08 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5416 to look at the new patch set (#2). Change subject: KUDU-1796: Use last REPLICATE OpId instead of last COMMIT OpId to tombstone a tablet replica ..

[kudu-CR] KUDU-1796: Use last REPLICATE OpId instead of last COMMIT OpId to tombstone a tablet replica

2016-12-08 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1796: Use last REPLICATE OpId instead of last COMMIT OpId to tombstone a tablet replica .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5416

[kudu-CR] KUDU-1796: Use last REPLICATE OpId instead of last COMMIT OpId to tombstone a tablet replica

2016-12-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1796: Use last REPLICATE OpId instead of last COMMIT OpId to tombstone a tablet replica .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.clouder

[kudu-CR] KUDU-1796: Use last REPLICATE OpId instead of last COMMIT OpId to tombstone a tablet replica

2016-12-08 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: KUDU-1796: Use last REPLICATE OpId instead of last COMMIT OpId to tombstone a tablet replica .. KUDU-1796: Use last REPLICATE OpId instead of last COMMIT O

[kudu-CR] Revert "KUDU-861 Support changing default, storage attributes"

2016-12-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/5420 Change subject: Revert "KUDU-861 Support changing default, storage attributes" .. Revert "KUDU-861 Support changing default, storage

[kudu-CR] Revert "KUDU-861 Support changing default, storage attributes"

2016-12-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Revert "KUDU-861 Support changing default, storage attributes" .. Patch Set 1: Code-Review+2 +2 pending Jenkins -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] Revert "KUDU-861 Support changing default, storage attributes"

2016-12-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Revert "KUDU-861 Support changing default, storage attributes" .. Patch Set 1: Thanks Will, like we discussed on Slack let's put up this patch again when it

[kudu-CR] Revert "KUDU-861 Support changing default, storage attributes"

2016-12-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Revert "KUDU-861 Support changing default, storage attributes" .. Revert "KUDU-861 Support changing default, storage attributes" This reverts commi

[kudu-CR] dist-test: allow collecting the tmp dir of failed tests

2016-12-08 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: dist-test: allow collecting the tmp dir of failed tests .. dist-test: allow collecting the tmp dir of failed tests When debugging certain types of failur

[kudu-CR] KUDU-1776: Fix "kudu remote replica copy" connecting to wildcard address

2016-12-08 Thread Dinesh Bhat (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5378 to look at the new patch set (#4). Change subject: KUDU-1776: Fix "kudu remote_replica copy" connecting to wildcard address ..

[kudu-CR] Make delete table-test less flaky

2016-12-08 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5421 to review the following change. Change subject: Make delete_table-test less flaky .. Make delete_table-test less flaky

[kudu-CR] KUDU-1753 [delete table-test] deleted-while-in-scan test

2016-12-08 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1753 [delete_table-test] deleted-while-in-scan test .. Patch Set 6: (1 comment) Consider +1 from my side, my browser is playing some tricks with me not showi

[kudu-CR] KUDU-1753 [delete table-test] deleted-while-in-scan test

2016-12-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1753 [delete_table-test] deleted-while-in-scan test .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5345/7/src/kudu/integration-tests

[kudu-CR] KUDU-1753 continue scan if tablet is being deleted

2016-12-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1753 continue scan if tablet is being deleted .. Patch Set 6: (2 comments) lgtm, excepting nits. see my comment on the test patch though. http://ger

[kudu-CR] Remove the clock from MvccManager

2016-12-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5326 to look at the new patch set (#5). Change subject: Remove the clock from MvccManager .. Remove the clock from MvccM

[kudu-CR] Remove the clock from MvccManager

2016-12-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5326 to look at the new patch set (#6). Change subject: Remove the clock from MvccManager .. Remove the clock from MvccM

[kudu-CR] KUDU-1753 [delete table-test] deleted-while-in-scan test

2016-12-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1753 [delete_table-test] deleted-while-in-scan test .. Patch Set 7: > (1 comment) > > Consider +1 from my side, my browser is playing some tricks with me

[kudu-CR] KUDU-1753 [delete table-test] deleted-while-in-scan test

2016-12-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1753 [delete_table-test] deleted-while-in-scan test .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5345/7/src/kudu/integration-tests/delet

[kudu-CR] KUDU-1753 [delete table-test] deleted-while-in-scan test

2016-12-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1753 [delete_table-test] deleted-while-in-scan test .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5345/7/src/kudu/integration-tests

[kudu-CR] KUDU-1753 [delete table-test] deleted-while-in-scan test

2016-12-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1753 [delete_table-test] deleted-while-in-scan test .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5345/7/src/kudu/integration-tests

[kudu-CR] KUDU-1508: enforce block limit on lbm containers

2016-12-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1508: enforce block limit on lbm containers .. Patch Set 4: (3 comments) Still doing a full review, but here are some notes from trying to run on macOS. htt

[kudu-CR] KUDU-1753 [delete table-test] deleted-while-in-scan test

2016-12-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1753 [delete_table-test] deleted-while-in-scan test .. Patch Set 7: > (1 comment) ok, will remove the comment -- after couple of readings it looks like man

[kudu-CR] KUDU-1508: enforce block limit on lbm containers

2016-12-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1508: enforce block limit on lbm containers .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5403/4/src/kudu/fs/block_manager-test.cc File src

[kudu-CR] Fix linked list-test flakiness

2016-12-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5424 Change subject: Fix linked_list-test flakiness .. Fix linked_list-test flakiness A recent patch changed this test to do a snapshot

[kudu-CR] KUDU-1753 [delete table-test] deleted-while-in-scan test

2016-12-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1753 [delete_table-test] deleted-while-in-scan test .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5345/7/src/kudu/integration-tests/delet

[kudu-CR] [spark] KUDU-1641 Pushdown SparkSQL In predicates

2016-12-08 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/5425 Change subject: [spark] KUDU-1641 Pushdown SparkSQL In predicates .. [spark] KUDU-1641 Pushdown SparkSQL In predicates This patch adds s

[kudu-CR] KUDU-1508: enforce block limit on lbm containers

2016-12-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1508: enforce block limit on lbm containers .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/5403/4/src/kudu/fs/block_manager-test.cc File src

[kudu-CR] KUDU-1508: enforce block limit on lbm containers

2016-12-08 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5403 to look at the new patch set (#5). Change subject: KUDU-1508: enforce block limit on lbm containers .. KUDU-1508: e

[kudu-CR] KUDU-1624. Fix data race in Trace::MetricsToJSON

2016-12-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1624. Fix data race in Trace::MetricsToJSON .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5419/1/src/kudu/util/trace.cc File s

[kudu-CR] KUDU-1508: enforce block limit on lbm containers

2016-12-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1508: enforce block limit on lbm containers .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/5403/4/src/kudu/fs/block_manager-test.cc File sr

[kudu-CR] KUDU-1508: enforce block limit on lbm containers

2016-12-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1508: enforce block limit on lbm containers .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/5403/4/src/kudu/fs/block_manager-test.cc File src

[kudu-CR] KUDU-1508: enforce block limit on lbm containers

2016-12-08 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5403 to look at the new patch set (#6). Change subject: KUDU-1508: enforce block limit on lbm containers .. KUDU-1508: e

[kudu-CR] KUDU-1508: enforce block limit on lbm containers

2016-12-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1508: enforce block limit on lbm containers .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5403/6/src/kudu/fs/log_block_manager.cc File src/

[kudu-CR] KUDU-1508: enforce block limit on lbm containers

2016-12-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1508: enforce block limit on lbm containers .. Patch Set 6: Verified on macOS -- To view, visit http://gerrit.cloudera.org:8080/5403 To unsubscribe, visit h

[kudu-CR] [spark] KUDU-1641 Pushdown SparkSQL In predicates

2016-12-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [spark] KUDU-1641 Pushdown SparkSQL In predicates .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5425/1/java/kudu-spark/src/main/scala/org/apach

[kudu-CR] KUDU-1524. Add a workaround for unflushable large cells

2016-12-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1524. Add a workaround for unflushable large cells .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5282 To unsubscribe, visit

[kudu-CR] KUDU-1508: enforce block limit on lbm containers

2016-12-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1508: enforce block limit on lbm containers .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5403/6/src/kudu/fs/log_block_manager.cc File src/k

[kudu-CR] KUDU-1508: enforce block limit on lbm containers

2016-12-08 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5403 to look at the new patch set (#7). Change subject: KUDU-1508: enforce block limit on lbm containers .. KUDU-1508: e

[kudu-CR] KUDU-1757: add PartialRow.toString

2016-12-08 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5237 to look at the new patch set (#7). Change subject: KUDU-1757: add PartialRow.toString .. KUDU-1

[kudu-CR] KUDU-1757: add PartialRow.toString

2016-12-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1757: add PartialRow.toString .. Patch Set 6: Hey Yanlong, I tracked down the error to a bug I introduced recently. I just pushed a new revision with the f

[kudu-CR] KUDU-1508: enforce block limit on lbm containers

2016-12-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1508: enforce block limit on lbm containers .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5403 To unsubscribe, visit http:/

[kudu-CR] KUDU-1508: enforce block limit on lbm containers

2016-12-08 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: KUDU-1508: enforce block limit on lbm containers .. KUDU-1508: enforce block limit on lbm containers This patch introduces the following machinery: 1. LBM

[kudu-CR] KUDU-1753 [delete table-test] deleted-while-in-scan test

2016-12-08 Thread Alexey Serbin (Code Review)
Hello Dinesh Bhat, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5345 to look at the new patch set (#8). Change subject: KUDU-1753 [delete_table-test] deleted-while-in-scan test ...

[kudu-CR] KUDU-1753 continue scan if tablet is being deleted

2016-12-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1753 continue scan if tablet is being deleted .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5346/6/src/kudu/tserver/tablet_service.cc Fil

[kudu-CR] [spark] KUDU-1641 Pushdown SparkSQL In predicates

2016-12-08 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5425 to look at the new patch set (#2). Change subject: [spark] KUDU-1641 Pushdown SparkSQL In predicates .. [spark] KUD

[kudu-CR] log-rolling-itest: wait for log roller on server startup

2016-12-08 Thread Dan Burkert (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5431 to review the following change. Change subject: log-rolling-itest: wait for log roller on server startup .. log-rolling

[kudu-CR] KUDU-1753 continue scan if tablet is being deleted

2016-12-08 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5346 to look at the new patch set (#7). Change subject: KUDU-1753 continue scan if tablet is being deleted .. KUDU-1753

[kudu-CR] KUDU-1757: add PartialRow.toString

2016-12-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1757: add PartialRow.toString .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5237/7/java/kudu-client/src/test/java/org/apache/kudu/cl

[kudu-CR] KUDU-1757: add PartialRow.toString

2016-12-08 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5237 to look at the new patch set (#8). Change subject: KUDU-1757: add PartialRow.toString .. KUDU-1

[kudu-CR] KUDU-1757: add PartialRow.toString

2016-12-08 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5237 to look at the new patch set (#9). Change subject: KUDU-1757: add PartialRow.toString .. KUDU-1

[kudu-CR] KUDU-1757: add PartialRow.toString

2016-12-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1757: add PartialRow.toString .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/5237/7/java/kudu-client/src/test/java/org/apache/kudu/client/Te

[kudu-CR] KUDU-1624. Fix data race in Trace::MetricsToJSON

2016-12-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1624. Fix data race in Trace::MetricsToJSON .. KUDU-1624. Fix data race in Trace::MetricsToJSON We were accessing child_traces_ without the appropria

[kudu-CR] KUDU-1624. Fix data race in Trace::MetricsToJSON

2016-12-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1624. Fix data race in Trace::MetricsToJSON .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5419/1/src/kudu/util/trace.cc File src/kudu/util/

[kudu-CR] WIP: bug in exactly-once during tablet bootstrap

2016-12-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5417 to look at the new patch set (#2). Change subject: WIP: bug in exactly-once during tablet bootstrap .. WIP: bug in

[kudu-CR] WIP Fix exactly once bug in tablet bootstrap

2016-12-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5432 Change subject: WIP Fix exactly_once bug in tablet bootstrap .. WIP Fix exactly_once bug in tablet bootstrap Change-Id: Ia33e6a937

[kudu-CR] WIP: bug in exactly-once during tablet bootstrap

2016-12-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: bug in exactly-once during tablet bootstrap .. Patch Set 2: oops sorry ended up rebasing your patch on master -- To view, visit http://gerrit.cloude

[kudu-CR] [spark] KUDU-1641 Pushdown SparkSQL In predicates

2016-12-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [spark] KUDU-1641 Pushdown SparkSQL In predicates .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5425/2/java/kudu-spark/src/main/scala/org/apache

[kudu-CR] log-rolling-itest: wait for log roller on server startup

2016-12-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: log-rolling-itest: wait for log roller on server startup .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5431 To unsubscribe, visi

[kudu-CR] KUDU-1524. Add a workaround for unflushable large cells

2016-12-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1524. Add a workaround for unflushable large cells .. KUDU-1524. Add a workaround for unflushable large cells Previously, we had a hard-coded limit o

[kudu-CR] [spark] KUDU-1641 Pushdown SparkSQL In predicates

2016-12-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [spark] KUDU-1641 Pushdown SparkSQL In predicates .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5425/1/java/kudu-spark/src/main/scala/org/apa

[kudu-CR] Fix linked list-test flakiness

2016-12-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Fix linked_list-test flakiness .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5424 To unsubscribe, visit http://gerrit.cloudera

[kudu-CR] WIP Fix exactly once bug in tablet bootstrap

2016-12-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP Fix exactly_once bug in tablet bootstrap .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5432/1/src/kudu/tablet/tablet_bootstrap.cc File src/k

[kudu-CR] Fix linked list-test flakiness

2016-12-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Fix linked_list-test flakiness .. Fix linked_list-test flakiness A recent patch changed this test to do a snapshot scan at the end which is now failing wi

[kudu-CR] Fix linked list-test flakiness

2016-12-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix linked_list-test flakiness .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5424 To unsubscribe, visit http://gerrit.cloudera.o

[kudu-CR] KUDU-1757: add PartialRow.toString

2016-12-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1757: add PartialRow.toString .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5237 To unsubscribe, visit http://gerrit

[kudu-CR] KUDU-1753 continue scan if tablet is being deleted

2016-12-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1753 continue scan if tablet is being deleted .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5346 To unsubscribe, vi

[kudu-CR] KUDU-1753 [delete table-test] deleted-while-in-scan test

2016-12-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1753 [delete_table-test] deleted-while-in-scan test .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5345 To unsubscri

[kudu-CR] KUDU-1757: add PartialRow.toString

2016-12-08 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1757: add PartialRow.toString .. KUDU-1757: add PartialRow.toString Operation.toString could fail if the operation's partial row had not had its full

[kudu-CR] KUDU-1753 [delete table-test] deleted-while-in-scan test

2016-12-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: KUDU-1753 [delete_table-test] deleted-while-in-scan test .. KUDU-1753 [delete_table-test] deleted-while-in-scan test Added an integration test to ensure

[kudu-CR] log-rolling-itest: wait for log roller on server startup

2016-12-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: log-rolling-itest: wait for log roller on server startup .. log-rolling-itest: wait for log roller on server startup The log roller runs early in the star

[kudu-CR] Make delete table-test less flaky

2016-12-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Make delete_table-test less flaky .. Patch Set 1: (1 comment) how about TabletCopyClientSessionITest.TestStartTabletCopyWhileSourceBootstrapping ? it's also fla

[kudu-CR] Remove the clock from MvccManager

2016-12-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Remove the clock from MvccManager .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5326 To unsubscribe, visit http://gerrit.clouder

[kudu-CR] Remove the clock from MvccManager

2016-12-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Remove the clock from MvccManager .. Remove the clock from MvccManager Now that safe time has it's own managing entity, there is no need for MvccManager t

[kudu-CR] Remove the clock from MvccManager

2016-12-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Remove the clock from MvccManager .. Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/5326/6//COMMIT_MSG Commit Message: PS6, Line 9: it's nit: it

[kudu-CR] Remove the clock from MvccManager

2016-12-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Remove the clock from MvccManager .. Patch Set 7: > (6 comments) oops, I got it wrong -- ignore that. -- To view, visit http://gerrit.cloudera.org:8080/5326 T

[kudu-CR] KUDU-1753 continue scan if tablet is being deleted

2016-12-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1753 continue scan if tablet is being deleted .. Patch Set 8: Code-Review+2 Re-based the patch, David already gave +2. -- To view, visit http://gerrit.clo

[kudu-CR] KUDU-1753 continue scan if tablet is being deleted

2016-12-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: KUDU-1753 continue scan if tablet is being deleted .. KUDU-1753 continue scan if tablet is being deleted Updated TabletServiceImpl::HandleContinueScanRe

[kudu-CR] csd: two minor changes

2016-12-08 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded a new change for review. http://gerrit.cloudera.org:8080/5435 Change subject: csd: two minor changes .. csd: two minor changes Revert the memory limit scaleFactor to the default value (1.0). 1.3 is rec

[kudu-CR] Modify the default value of log dir flag.

2016-12-08 Thread Kousuke Saruta (Code Review)
Kousuke Saruta has uploaded a new change for review. http://gerrit.cloudera.org:8080/5436 Change subject: Modify the default value of log_dir flag. .. Modify the default value of log_dir flag. The document about configuration

[kudu-CR] Modify the default value of log dir flag.

2016-12-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Modify the default value of log_dir flag. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5436 To unsubscribe, visit http://gerrit

[kudu-CR] csd: two minor changes

2016-12-08 Thread Anonymous Coward (Code Review)
Anonymous Coward #265 has posted comments on this change. Change subject: csd: two minor changes .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5435/1//COMMIT_MSG Commit Message: Line 23: So this probably mak

[kudu-CR] Change version in master to 1.3.0-SNAPSHOT

2016-12-08 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5437 to review the following change. Change subject: Change version in master to 1.3.0-SNAPSHOT .. Change version in

[kudu-CR] KUDU-1776: Fix "kudu remote replica copy" connecting to wildcard address

2016-12-08 Thread Dinesh Bhat (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5378 to look at the new patch set (#5). Change subject: KUDU-1776: Fix "kudu remote_replica copy" connecting to wildcard address ..