[kudu-CR] log block manager: convert container metrics from counters to gauges

2017-05-08 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6823 to review the following change. Change subject: log block manager: convert container metrics from counters to gauges

[kudu-CR] log block manager: reopen container metadata writers at the OS level

2017-05-08 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6825 to review the following change. Change subject: log block manager: reopen container metadata writers at the OS level

[kudu-CR] KUDU-1549: delete dead LBM containers at startup

2017-05-08 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6824 to review the following change. Change subject: KUDU-1549: delete dead LBM containers at startup .

[kudu-CR] KUDU-1549: compact LBM container metadata files at startup

2017-05-08 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6826 to review the following change. Change subject: KUDU-1549: compact LBM container metadata files at startup ...

[kudu-CR] KUDU-463. Add checksumming to cfile

2017-05-08 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: KUDU-463. Add checksumming to cfile .. Patch Set 16: I still want to performance test this yet too. -- To view, visit http://gerrit.cloudera.org:8080/6630 To uns

[kudu-CR] KUDU-463. Add checksumming to cfile

2017-05-08 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6630 to look at the new patch set (#16). Change subject: KUDU-463. Add checksumming to cfile .. KUDU-463. Add checksummi

[kudu-CR] WIP: KUDU-463. Add checksumming to cfile

2017-05-08 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: WIP: KUDU-463. Add checksumming to cfile .. Patch Set 15: (14 comments) http://gerrit.cloudera.org:8080/#/c/6630/15/docs/design-docs/cfile.md File docs/design-doc

[kudu-CR] Refactor ConsensusStatePB to hold committed and pending configs

2017-05-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Refactor ConsensusStatePB to hold committed and pending configs .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6809/2/src/kudu/consensus/consensu

[kudu-CR] KUDU-1999: Spark connector should login with Kerberos credentials on driver

2017-05-08 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6822 to look at the new patch set (#2). Change subject: KUDU-1999: Spark connector should login with Kerberos credentials on driver ...

[kudu-CR] KUDU-1999: Spark connector should login with Kerberos credentials on driver

2017-05-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1999: Spark connector should login with Kerberos credentials on driver .. Patch Set 1: (5 comments) Can you add some color to the commit message on testing?

[kudu-CR] KUDU-1999: Spark connector should login with Kerberos credentials on driver

2017-05-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1999: Spark connector should login with Kerberos credentials on driver .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6822/1/java/kudu-spar

[kudu-CR] Refactor ConsensusStatePB to hold committed and pending configs

2017-05-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Refactor ConsensusStatePB to hold committed and pending configs .. Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/6809/2//COMMIT_MSG Commit Message

[kudu-CR] KUDU-1999: Spark connector should login with Kerberos credentials on driver

2017-05-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1999: Spark connector should login with Kerberos credentials on driver .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6822/1/java/kudu-spar

[kudu-CR] KUDU-1999: Spark connector should login with Kerberos credentials on driver

2017-05-08 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6822 to review the following change. Change subject: KUDU-1999: Spark connector should login with Kerberos credentials on driver ..

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 17: (18 comments) http://gerrit.cloudera.org:8080/#/c/6636/17//COMMIT_MSG Commit Message: PS17, Lin

[kudu-CR] WIP: KUDU-463. Add checksumming to cfile

2017-05-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: KUDU-463. Add checksumming to cfile .. Patch Set 15: (13 comments) http://gerrit.cloudera.org:8080/#/c/6630/15/docs/design-docs/cfile.md File docs/design-doc

[kudu-CR] [build] disable tcmalloc for OS X builds

2017-05-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [build] disable tcmalloc for OS X builds .. [build] disable tcmalloc for OS X builds As a workaround for KUDU-1998, tcmalloc is disabled for OS X builds

[kudu-CR] [build] disable tcmalloc for OS X builds

2017-05-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [build] disable tcmalloc for OS X builds .. Patch Set 1: Verified+1 Unrelated flake of MasterStressTest -- To view, visit http://gerrit.cloudera.org:8080/6821

[kudu-CR] Refactor ConsensusStatePB to hold committed and pending configs

2017-05-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Refactor ConsensusStatePB to hold committed and pending configs .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/6809/2/src/kudu/consensus/metadata

[kudu-CR] KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs

2017-05-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs .. Patch Set 19: (19 comments) http://gerrit.cloudera.org:8080/#/c/6514/19/src/kudu

[kudu-CR] spark: add support for fault tolerant scanner

2017-05-08 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: spark: add support for fault tolerant scanner .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6782/5/java/kudu-spark/src/main/scala/org/apache/kudu/sp

[kudu-CR] spark: add support for fault tolerant scanner

2017-05-08 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6782 to look at the new patch set (#6). Change subject: spark: add support for fault tolerant scanner .. spark: add supp

[kudu-CR] spark: add support for fault tolerant scanner

2017-05-08 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: spark: add support for fault tolerant scanner .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/6782/5/java/kudu-spark/src/main/scala/org/apache/kudu/s

[kudu-CR] [build] disable tcmalloc for OS X builds

2017-05-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [build] disable tcmalloc for OS X builds .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6821/1/CMakeLists.txt File CMakeLists.txt:

[kudu-CR] [build] disable tcmalloc for OS X builds

2017-05-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [build] disable tcmalloc for OS X builds .. Patch Set 1: Code-Review+1 Checked on my OS X machine that this fixes the problem. -- To view, visit http://gerrit.

[kudu-CR] [build] disable tcmalloc for OS X builds

2017-05-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [build] disable tcmalloc for OS X builds .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6821/1/CMakeLists.txt File CMakeLists.txt: Line 892: ## A

[kudu-CR] maintenance manager: schedule work immediately when threads are free

2017-05-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: maintenance_manager: schedule work immediately when threads are free .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6815/1/src/kudu/uti

[kudu-CR] [build] disable tcmalloc for OS X builds

2017-05-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/6821 Change subject: [build] disable tcmalloc for OS X builds .. [build] disable tcmalloc for OS X builds As a workaround for KUDU-1998, tcma

[kudu-CR] Fix flaky test TestRecoverFromOpIdOverflow

2017-05-08 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new patch set (#3). Change subject: Fix flaky test TestRecoverFromOpIdOverflow .. Fix flaky test TestRecoverFromOpIdOverflow This test is flaky because we race against the COMMIT message for the first N

[kudu-CR] Fix flaky test TestRecoverFromOpIdOverflow

2017-05-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Fix flaky test TestRecoverFromOpIdOverflow .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6808/2/src/kudu/integration-tests/ts_recovery-itest.cc

[kudu-CR] Fix flaky test TestRecoverFromOpIdOverflow

2017-05-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Fix flaky test TestRecoverFromOpIdOverflow .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6808/2/src/kudu/integration-tests/ts_recovery-

[kudu-CR] KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs

2017-05-08 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6514 to look at the new patch set (#19). Change subject: KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs .

[kudu-CR] KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs

2017-05-08 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs .. Patch Set 18: (8 comments) http://gerrit.cloudera.org:8080/#/c/6514/17/src/kudu/rpc/

[kudu-CR] KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs

2017-05-08 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6514 to look at the new patch set (#18). Change subject: KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs .

[kudu-CR] spark: add support for fault tolerant scanner

2017-05-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: spark: add support for fault tolerant scanner .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6782/5/java/kudu-spark/src/main/scala/org/apache/kud

[kudu-CR] WIP [java] re-acquire authn token if expired

2017-05-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP [java] re-acquire authn token if expired .. Patch Set 2: Verified+1 Unrelated MultiThreadedTabletTest/4.DeleteAndReinsert flake -- To view, visit http://ge

[kudu-CR] KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs

2017-05-08 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6514 to look at the new patch set (#17). Change subject: KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs .

[kudu-CR] WIP: release WritableLogSegment buffers when log is idle

2017-05-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: release WritableLogSegment buffers when log is idle .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6611/2/src/kudu/consensus/log.cc File src

[kudu-CR] KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs

2017-05-08 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6514 to look at the new patch set (#16). Change subject: KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs .

[kudu-CR] WIP: KUDU-463. Add checksumming to cfile

2017-05-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: WIP: KUDU-463. Add checksumming to cfile .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/6630/15//COMMIT_MSG Commit Message: Line 7: WIP: KUDU-46

[kudu-CR] WIP: KUDU-463. Add checksumming to cfile

2017-05-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: WIP: KUDU-463. Add checksumming to cfile .. Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/6630/14/docs/design-docs/cfile.md File docs/design-docs/

[kudu-CR] [c++ client] re-acquire authn token if expired

2017-05-08 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6648 to look at the new patch set (#11). Change subject: [c++ client] re-acquire authn token if expired .. [c++ client]