[kudu-CR] build-support: option to retry all failed tests

2018-08-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11342 ) Change subject: build-support: option to retry all failed tests .. Patch Set 3: (1 comment)

[kudu-CR] build-support: option to retry all failed tests

2018-08-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11342 ) Change subject: build-support: option to retry all failed tests .. Patch Set 3: (1 comment)

[kudu-CR] build-support: option to retry all failed tests

2018-08-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11342 ) Change subject: build-support: option to retry all failed tests .. Patch Set 2: > Patch Set 2: > > (1 comment) > > See this logic here

[kudu-CR] build-support: option to retry all failed tests

2018-08-27 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11342 to look at the new patch set (#3). Change subject: build-support: option to retry all failed tests

[kudu-CR] build-support: option to retry all failed tests

2018-08-27 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11342 ) Change subject: build-support: option to retry all failed tests .. Patch Set 2: (1 comment) See this logic here for dist-test. We

[kudu-CR] build-support: option to retry all failed tests

2018-08-27 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11342 to look at the new patch set (#2). Change subject: build-support: option to retry all failed tests ..

[kudu-CR] build-support: option to retry all failed tests

2018-08-27 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11342 Change subject: build-support: option to retry all failed tests .. build-support: option to retry all failed tests Currently, users can

[kudu-CR] [build] add -D{LEAK,UNDEFINED} SANITIZER

2018-08-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11340 ) Change subject: [build] add -D{LEAK,UNDEFINED}_SANITIZER .. [build] add -D{LEAK,UNDEFINED}_SANITIZER To enable

[kudu-CR] [build] add -D{LEAK,UNDEFINED} SANITIZER

2018-08-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11340 ) Change subject: [build] add -D{LEAK,UNDEFINED}_SANITIZER .. Patch Set 2: Verified+1 Known flake in

[kudu-CR] [build] add -D{LEAK,UNDEFINED} SANITIZER

2018-08-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11340 ) Change subject: [build] add -D{LEAK,UNDEFINED}_SANITIZER .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] [build] add -D{LEAK,UNDEFINED} SANITIZER

2018-08-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11340 ) Change subject: [build] add -D{LEAK,UNDEFINED}_SANITIZER .. Patch Set 1: (1 comment)

[kudu-CR] [build] add -D{LEAK,UNDEFINED} SANITIZER

2018-08-27 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11340 ) Change subject: [build] add -D{LEAK,UNDEFINED}_SANITIZER .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [build] add -D{LEAK,UNDEFINED} SANITIZER

2018-08-27 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11340 to look at the new patch set (#2). Change subject: [build] add -D{LEAK,UNDEFINED}_SANITIZER

[kudu-CR] [build] add -DLEAK SANITIZER to compilation flags

2018-08-27 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11340 ) Change subject: [build] add -DLEAK_SANITIZER to compilation flags .. Patch Set 1: (1 comment)

[kudu-CR] [build] add -DLEAK SANITIZER to compilation flags

2018-08-27 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11340 ) Change subject: [build] add -DLEAK_SANITIZER to compilation flags .. Patch Set 1: Thank you for fixing this. For reference we always

[kudu-CR] [build] add -DLEAK SANITIZER to compilation flags

2018-08-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11340 ) Change subject: [build] add -DLEAK_SANITIZER to compilation flags .. Patch Set 1: Code-Review+1 Ran this on a centos 6.6 machine (on

[kudu-CR] [build] add -DLEAK SANITIZER to compilation flags

2018-08-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11340 Change subject: [build] add -DLEAK_SANITIZER to compilation flags .. [build] add -DLEAK_SANITIZER to compilation flags To enable

[kudu-CR] util: add once class based on std::call once

2018-08-27 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11302 ) Change subject: util: add once class based on std::call_once .. util: add once class based on std::call_once The existing

[kudu-CR] [location awareness] Add 'location' column in tserver list

2018-08-27 Thread Fengling Wang (Code Review)
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11313 ) Change subject: [location_awareness] Add 'location' column in tserver list .. Patch Set 2: (13 comments)

[kudu-CR] [location awareness] Add 'location' column in tserver list

2018-08-27 Thread Fengling Wang (Code Review)
Hello Will Berkeley, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11313 to look at the new patch set (#2). Change subject: [location_awareness] Add 'location' column in tserver list

[kudu-CR] error manager: rename error types

2018-08-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11303 ) Change subject: error_manager: rename error types .. Patch Set 4: (1 comment)

[kudu-CR] error manager: rename error types

2018-08-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11303 ) Change subject: error_manager: rename error types .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2469 pt 1: add an IOContext

2018-08-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11248 ) Change subject: KUDU-2469 pt 1: add an IOContext .. Patch Set 4: (3 comments)

[kudu-CR] error manager: rename error types

2018-08-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11303 ) Change subject: error_manager: rename error types .. Patch Set 4: (1 comment)

[kudu-CR] util: add once class based on std::call once

2018-08-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11302 ) Change subject: util: add once class based on std::call_once .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] [gutil] change libunwind to Linux specific to fix build

2018-08-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11338 ) Change subject: [gutil] change libunwind to Linux specific to fix build .. Patch Set 2: > Patch Set 1: Code-Review+2 Thank you for

[kudu-CR] [gutil] change libunwind to Linux specific to fix build

2018-08-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11338 ) Change subject: [gutil] change libunwind to Linux specific to fix build .. [gutil] change libunwind to Linux specific to fix

[kudu-CR] [gutil] change libunwind to Linux specific to fix build

2018-08-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11338 ) Change subject: [gutil] change libunwind to Linux specific to fix build .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [gutil] change libunwind to Linux specific to fix build

2018-08-27 Thread Kiyoshi Mizumaru (Code Review)
Kiyoshi Mizumaru has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11338 Change subject: [gutil] change libunwind to Linux specific to fix build .. [gutil] change libunwind to Linux specific to fix build

[kudu-CR] Add protobuf generated files to Eclipse project classpath.

2018-08-27 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11310 ) Change subject: Add protobuf generated files to Eclipse project classpath. .. Patch Set 6: Verified+1 -- To view, visit

[kudu-CR] util: add once class based on std::call once

2018-08-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11302 ) Change subject: util: add once class based on std::call_once .. Patch Set 3: Verified+1 Build failure was unrelated: *

[kudu-CR] Add protobuf generated files to Eclipse project classpath.

2018-08-27 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11310 ) Change subject: Add protobuf generated files to Eclipse project classpath. .. Add protobuf generated files to Eclipse project

[kudu-CR] Add protobuf generated files to Eclipse project classpath.

2018-08-27 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: Add protobuf generated files to Eclipse project classpath. .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11310 To

[kudu-CR] util: add once class based on std::call once

2018-08-27 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: util: add once class based on std::call_once .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11302 To unsubscribe,

[kudu-CR] KUDU-2012 Kudu Flume sink auth support

2018-08-27 Thread Ferenc Szabo (Code Review)
Ferenc Szabo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11334 ) Change subject: KUDU-2012 Kudu Flume sink auth support .. Patch Set 1: (4 comments)

[kudu-CR] common: add equality methods to ColumnBlock and SelectionVector

2018-08-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11267 ) Change subject: common: add equality methods to ColumnBlock and SelectionVector .. Patch Set 2: Code-Review+1 (4 comments) looks good,

[kudu-CR] util: add once class based on std::call once

2018-08-27 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11302 ) Change subject: util: add once class based on std::call_once .. Patch Set 3: Code-Review+1 -- To view, visit

[kudu-CR] Add protobuf generated files to Eclipse project classpath.

2018-08-27 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11310 ) Change subject: Add protobuf generated files to Eclipse project classpath. .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] bitmap: add equality method

2018-08-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11266 ) Change subject: bitmap: add equality method .. Patch Set 3: Code-Review+1 (2 comments)

[kudu-CR] deltamemstore: support iteration with snap to exclude

2018-08-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11029 ) Change subject: deltamemstore: support iteration with snap_to_exclude .. Patch Set 9: Code-Review+1 (7 comments) looks good to me

[kudu-CR] Add protobuf generated files to Eclipse project classpath.

2018-08-27 Thread Greg Solovyev (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11310 to look at the new patch set (#6). Change subject: Add protobuf generated files to Eclipse project classpath.

[kudu-CR] util: add once class based on std::call once

2018-08-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11302 ) Change subject: util: add once class based on std::call_once .. Patch Set 2: (1 comment)

[kudu-CR] util: add once class based on std::call once

2018-08-27 Thread Andrew Wong (Code Review)
Hello Dan Burkert, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11302 to look at the new patch set (#3). Change subject: util: add once class based on std::call_once

[kudu-CR] deltamemstore: support iteration with snap to exclude

2018-08-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11029 ) Change subject: deltamemstore: support iteration with snap_to_exclude .. Patch Set 9: Verified+1 Overriding Jenkins; it looks like one

[kudu-CR] deltamemstore: support iteration with snap to exclude

2018-08-27 Thread Mike Percy (Code Review)
Mike Percy has removed a vote on this change. Change subject: deltamemstore: support iteration with snap_to_exclude .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11029 To

[kudu-CR] util: add once class based on std::call once

2018-08-27 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11302 ) Change subject: util: add once class based on std::call_once .. Patch Set 2: Code-Review+1 (1 comment)

[kudu-CR](gh-pages) Add archived releases section

2018-08-27 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11295 ) Change subject: Add archived releases section .. Patch Set 3: (1 comment)

[kudu-CR](gh-pages) [site] Add descriptions to the DOAP file

2018-08-27 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11287 ) Change subject: [site] Add descriptions to the DOAP file .. [site] Add descriptions to the DOAP file Change-Id:

[kudu-CR](gh-pages) [site] Add descriptions to the DOAP file

2018-08-27 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11287 ) Change subject: [site] Add descriptions to the DOAP file .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2012 Kudu Flume sink auth support

2018-08-27 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11334 ) Change subject: KUDU-2012 Kudu Flume sink auth support .. Patch Set 1: (10 comments)