[kudu-CR] KUDU-1260 Add test for prefetching on java scanner

2019-11-05 Thread Yao Xu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14631 to look at the new patch set (#2). Change subject: KUDU-1260 Add test for prefetching on java scanner

[kudu-CR] KUDU-1260 Add test for prefetching on java scanner

2019-11-04 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14631 ) Change subject: KUDU-1260 Add test for prefetching on java scanner .. Patch Set 1: Hi, adar, grant. I for prefetching scanner added some

[kudu-CR] KUDU-1260 Add test for prefetching on java scanner

2019-11-04 Thread Yao Xu (Code Review)
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14631 Change subject: KUDU-1260 Add test for prefetching on java scanner .. KUDU-1260 Add test for prefetching on java scanner Change-Id:

[kudu-CR] [spark] Add prefetching option to kudu-spark

2019-11-01 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14598 ) Change subject: [spark] Add prefetching option to kudu-spark .. Patch Set 1: > (1 comment) > > Thanks for finding and fixing this bug.

[kudu-CR] [spark] Add prefetching option to kudu-spark

2019-11-01 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14598 ) Change subject: [spark] Add prefetching option to kudu-spark .. Patch Set 1: > (1 comment) Maybe we can use the existing testcase to test

[kudu-CR] [spark] Add prefetching option to kudu-spark

2019-10-30 Thread Yao Xu (Code Review)
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14598 Change subject: [spark] Add prefetching option to kudu-spark .. [spark] Add prefetching option to kudu-spark We have already supported the

[kudu-CR] [build] Fix a bug for memory gc-itest

2019-10-11 Thread Yao Xu (Code Review)
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14415 Change subject: [build] Fix a bug for memory_gc-itest .. [build] Fix a bug for memory_gc-itest In CMakeList.txt, we should use

[kudu-CR] [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

2019-08-20 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14061 ) Change subject: [tablet] Fixed the bug of DeltaTracker::CountDeletedRows .. Patch Set 10: (1 comment)

[kudu-CR] [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

2019-08-20 Thread Yao Xu (Code Review)
Hello Tidy Bot, Kudu Jenkins, helifu, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14061 to look at the new patch set (#10). Change subject: [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

[kudu-CR] [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

2019-08-20 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14061 ) Change subject: [tablet] Fixed the bug of DeltaTracker::CountDeletedRows .. Patch Set 9: (9 comments)

[kudu-CR] [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

2019-08-20 Thread Yao Xu (Code Review)
Hello Tidy Bot, Kudu Jenkins, helifu, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14061 to look at the new patch set (#9). Change subject: [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

[kudu-CR] [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

2019-08-20 Thread Yao Xu (Code Review)
Hello Tidy Bot, Kudu Jenkins, helifu, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14061 to look at the new patch set (#8). Change subject: [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

[kudu-CR] [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

2019-08-20 Thread Yao Xu (Code Review)
Hello Tidy Bot, Kudu Jenkins, helifu, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14061 to look at the new patch set (#7). Change subject: [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

[kudu-CR] [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

2019-08-20 Thread Yao Xu (Code Review)
Hello Tidy Bot, Kudu Jenkins, helifu, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14061 to look at the new patch set (#6). Change subject: [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

[kudu-CR] [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

2019-08-20 Thread Yao Xu (Code Review)
Hello Tidy Bot, Kudu Jenkins, helifu, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14061 to look at the new patch set (#5). Change subject: [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

[kudu-CR] [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

2019-08-15 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14061 ) Change subject: [tablet] Fixed the bug of DeltaTracker::CountDeletedRows .. Patch Set 4: I implemented an integration test case that

[kudu-CR] [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

2019-08-15 Thread Yao Xu (Code Review)
Hello Tidy Bot, Kudu Jenkins, helifu, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14061 to look at the new patch set (#4). Change subject: [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

[kudu-CR] [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

2019-08-15 Thread Yao Xu (Code Review)
Hello Kudu Jenkins, helifu, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14061 to look at the new patch set (#3). Change subject: [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

[kudu-CR] [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

2019-08-14 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14061 ) Change subject: [tablet] Fixed the bug of DeltaTracker::CountDeletedRows .. Patch Set 2: (2 comments)

[kudu-CR] [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

2019-08-13 Thread Yao Xu (Code Review)
Hello Kudu Jenkins, helifu, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14061 to look at the new patch set (#2). Change subject: [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

[kudu-CR] [tablet] Fixed the bug of DeltaTracker::CountDeletedRows

2019-08-13 Thread Yao Xu (Code Review)
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14061 Change subject: [tablet] Fixed the bug of DeltaTracker::CountDeletedRows .. [tablet] Fixed the bug of DeltaTracker::CountDeletedRows When

[kudu-CR] KUDU-2917 Split a tablet into primary key ranges by number of rows

2019-08-13 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14046 ) Change subject: KUDU-2917 Split a tablet into primary key ranges by number of rows .. Patch Set 6: > It looks like CountLiveRows will

[kudu-CR] KUDU-2917 Split a tablet into primary key ranges by number of rows

2019-08-13 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14046 ) Change subject: KUDU-2917 Split a tablet into primary key ranges by number of rows .. Patch Set 6: (1 comment) > (1 comment) > > Can you

[kudu-CR] KUDU-2917 Split a tablet into primary key ranges by number of rows

2019-08-13 Thread Yao Xu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14046 to look at the new patch set (#6). Change subject: KUDU-2917 Split a tablet into primary key ranges by number of rows

[kudu-CR] KUDU-2917 Split a tablet into primary key ranges by number of rows

2019-08-13 Thread Yao Xu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14046 to look at the new patch set (#5). Change subject: KUDU-2917 Split a tablet into primary key ranges by number of rows

[kudu-CR] KUDU-2917 Split a tablet into primary key ranges by number of rows

2019-08-13 Thread Yao Xu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14046 to look at the new patch set (#4). Change subject: KUDU-2917 Split a tablet into primary key ranges by number of rows

[kudu-CR] KUDU-2917 Split a tablet into primary key ranges by number of rows

2019-08-12 Thread Yao Xu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14046 to look at the new patch set (#3). Change subject: KUDU-2917 Split a tablet into primary key ranges by number of rows

[kudu-CR] KUDU-2917 Split a tablet into primary key ranges by number of rows

2019-08-12 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14046 ) Change subject: KUDU-2917 Split a tablet into primary key ranges by number of rows .. Patch Set 2: It looks like CountLiveRows will return

[kudu-CR] KUDU-2917 Split a tablet into primary key ranges by number of rows

2019-08-12 Thread Yao Xu (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14046 to look at the new patch set (#2). Change subject: KUDU-2917 Split a tablet into primary key ranges by number of rows

[kudu-CR] KUDU-2917 Split a tablet into primary key ranges by number of rows

2019-08-12 Thread Yao Xu (Code Review)
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14046 Change subject: KUDU-2917 Split a tablet into primary key ranges by number of rows .. KUDU-2917 Split a tablet into primary key ranges by

[kudu-CR] [docs] Remove the duplicate word

2019-08-01 Thread Yao Xu (Code Review)
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13977 Change subject: [docs] Remove the duplicate word .. [docs] Remove the duplicate word Change-Id: Ie988c1e7e635449c4ff5ca40170d628b9b3a1a8e ---

[kudu-CR] [client] Deprecated TabletLocationsPB.ReplicaPB message in client

2019-07-28 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13908 ) Change subject: [client] Deprecated TabletLocationsPB.ReplicaPB message in client .. Patch Set 9: (2 comments)

[kudu-CR] [client] Deprecated TabletLocationsPB.ReplicaPB message in client

2019-07-28 Thread Yao Xu (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13908 to look at the new patch set (#9). Change subject: [client] Deprecated TabletLocationsPB.ReplicaPB message in client

[kudu-CR] [client] Deprecated TabletLocationsPB.ReplicaPB message in client

2019-07-26 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13908 ) Change subject: [client] Deprecated TabletLocationsPB.ReplicaPB message in client .. Patch Set 8: (4 comments)

[kudu-CR] [client] Deprecated TabletLocationsPB.ReplicaPB message in client

2019-07-26 Thread Yao Xu (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13908 to look at the new patch set (#8). Change subject: [client] Deprecated TabletLocationsPB.ReplicaPB message in client

[kudu-CR] [client] Deprecated TabletLocationsPB.ReplicaPB message in client

2019-07-26 Thread Yao Xu (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13908 to look at the new patch set (#7). Change subject: [client] Deprecated TabletLocationsPB.ReplicaPB message in client

[kudu-CR] [client] Deprecated TabletLocationsPB.ReplicaPB message in client

2019-07-26 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13908 ) Change subject: [client] Deprecated TabletLocationsPB.ReplicaPB message in client .. Patch Set 6: (1 comment)

[kudu-CR] [client] Deprecated TabletLocationsPB.ReplicaPB message in client

2019-07-26 Thread Yao Xu (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13908 to look at the new patch set (#6). Change subject: [client] Deprecated TabletLocationsPB.ReplicaPB message in client

[kudu-CR] [client] Deprecated TabletLocationsPB.ReplicaPB message in client

2019-07-26 Thread Yao Xu (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13908 to look at the new patch set (#5). Change subject: [client] Deprecated TabletLocationsPB.ReplicaPB message in client

[kudu-CR] [client] Deprecated TabletLocationsPB.ReplicaPB message in client

2019-07-25 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13908 ) Change subject: [client] Deprecated TabletLocationsPB.ReplicaPB message in client .. Patch Set 4: (3 comments)

[kudu-CR] [client] Deprecated TabletLocationsPB.ReplicaPB message in client

2019-07-25 Thread Yao Xu (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13908 to look at the new patch set (#4). Change subject: [client] Deprecated TabletLocationsPB.ReplicaPB message in client

[kudu-CR] [client] Deprecated TabletLocationsPB.ReplicaPB message in client

2019-07-24 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13908 ) Change subject: [client] Deprecated TabletLocationsPB.ReplicaPB message in client .. Patch Set 3: (1 comment)

[kudu-CR] [client] Deprecated TabletLocationsPB.ReplicaPB message in client

2019-07-24 Thread Yao Xu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13908 to look at the new patch set (#3). Change subject: [client] Deprecated TabletLocationsPB.ReplicaPB message in client

[kudu-CR] [client] Deprecated TabletLocationsPB.ReplicaPB message in client

2019-07-24 Thread Yao Xu (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13908 to look at the new patch set (#2). Change subject: [client] Deprecated TabletLocationsPB.ReplicaPB message in client

[kudu-CR] Deprecated TabletLocationsPB.ReplicaPB message

2019-07-24 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13908 ) Change subject: Deprecated TabletLocationsPB.ReplicaPB message .. Patch Set 1: > (1 comment) It seems like this. :( I think I can make some

[kudu-CR] Deprecated TabletLocationsPB.ReplicaPB message

2019-07-24 Thread Yao Xu (Code Review)
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13908 Change subject: Deprecated TabletLocationsPB.ReplicaPB message .. Deprecated TabletLocationsPB.ReplicaPB message According to the comments of

[kudu-CR] KUDU-2823 [java client] Support setting dimension for the newly created tablet

2019-07-21 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13875 ) Change subject: KUDU-2823 [java client] Support setting dimension for the newly created tablet .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-2823 [java client] Support setting dimension for the newly created tablet

2019-07-21 Thread Yao Xu (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13875 to look at the new patch set (#5). Change subject: KUDU-2823 [java client] Support setting dimension for the newly created tablet

[kudu-CR] KUDU-2823 [java client] Support setting dimension for the newly created tablet

2019-07-19 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13875 ) Change subject: KUDU-2823 [java client] Support setting dimension for the newly created tablet .. Patch Set 4: (1 comment)

[kudu-CR] [docs]: Delete invalid link

2019-07-19 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13881 ) Change subject: [docs]: Delete invalid link .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2823 [java client] Support setting dimension for the newly created tablet

2019-07-18 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13875 ) Change subject: KUDU-2823 [java client] Support setting dimension for the newly created tablet .. Patch Set 4: (2 comments)

[kudu-CR] KUDU-2823 [java client] Support setting dimension for the newly created tablet

2019-07-17 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13875 ) Change subject: KUDU-2823 [java client] Support setting dimension for the newly created tablet .. Patch Set 4: (2 comments)

[kudu-CR] KUDU-2823 [java client] Support setting dimension for the newly created tablet

2019-07-17 Thread Yao Xu (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13875 to look at the new patch set (#4). Change subject: KUDU-2823 [java client] Support setting dimension for the newly created tablet

[kudu-CR] KUDU-2823 [java client] Support setting dimension for the newly created tablet

2019-07-17 Thread Yao Xu (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13875 to look at the new patch set (#3). Change subject: KUDU-2823 [java client] Support setting dimension for the newly created tablet

[kudu-CR] KUDU-2823 [java client] Support setting dimension for the newly created tablet

2019-07-17 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13875 ) Change subject: KUDU-2823 [java client] Support setting dimension for the newly created tablet .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-2823 [java client] Support setting dimension for the newly created tablet

2019-07-17 Thread Yao Xu (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13875 to look at the new patch set (#2). Change subject: KUDU-2823 [java client] Support setting dimension for the newly created tablet

[kudu-CR] KUDU-2828 [java client] Support setting dimension for the newly created tablet

2019-07-17 Thread Yao Xu (Code Review)
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13875 Change subject: KUDU-2828 [java client] Support setting dimension for the newly created tablet .. KUDU-2828 [java client] Support setting

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-15 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13632 ) Change subject: KUDU-2823 Place tablet replicas based on dimension .. Patch Set 22: (18 comments)

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-15 Thread Yao Xu (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13632 to look at the new patch set (#22). Change subject: KUDU-2823 Place tablet replicas based on dimension

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-15 Thread Yao Xu (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13632 to look at the new patch set (#21). Change subject: KUDU-2823 Place tablet replicas based on dimension

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-14 Thread Yao Xu (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13632 to look at the new patch set (#20). Change subject: KUDU-2823 Place tablet replicas based on dimension

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-14 Thread Yao Xu (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13632 to look at the new patch set (#19). Change subject: KUDU-2823 Place tablet replicas based on dimension

[kudu-CR] KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB

2019-07-12 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13842 ) Change subject: KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-12 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13632 ) Change subject: KUDU-2823 Place tablet replicas based on dimension .. Patch Set 18: Add some unit tests for a few scenarios. -- To view,

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-12 Thread Yao Xu (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13632 to look at the new patch set (#18). Change subject: KUDU-2823 Place tablet replicas based on dimension

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-11 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13632 ) Change subject: KUDU-2823 Place tablet replicas based on dimension .. Patch Set 17: (1 comment)

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-11 Thread Yao Xu (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13632 to look at the new patch set (#17). Change subject: KUDU-2823 Place tablet replicas based on dimension

[kudu-CR] KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB

2019-07-11 Thread Yao Xu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13842 to look at the new patch set (#2). Change subject: KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB

[kudu-CR] KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB

2019-07-11 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13842 ) Change subject: KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB .. Patch Set 1: Emmm, I’m not sure

[kudu-CR] KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB

2019-07-11 Thread Yao Xu (Code Review)
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13842 Change subject: KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB .. KUDU-2622 Validate read and write

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-10 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13632 ) Change subject: KUDU-2823 Place tablet replicas based on dimension .. Patch Set 16: (2 comments)

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-10 Thread Yao Xu (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13632 to look at the new patch set (#16). Change subject: KUDU-2823 Place tablet replicas based on dimension

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-10 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13632 ) Change subject: KUDU-2823 Place tablet replicas based on dimension .. Patch Set 15: (12 comments) > (12 comments) > > Just passing

[kudu-CR] KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock

2019-07-10 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13721 ) Change subject: KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-10 Thread Yao Xu (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13632 to look at the new patch set (#15). Change subject: KUDU-2823 Place tablet replicas based on dimension

[kudu-CR] KUDU-2722 (table level): Support table extraConfig 'write enabled' conf

2019-07-10 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13796 ) Change subject: KUDU-2722 (table level): Support table extraConfig 'write_enabled' conf .. Patch Set 1: I'm curious about how to implement

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-08 Thread Yao Xu (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13632 to look at the new patch set (#14). Change subject: KUDU-2823 Place tablet replicas based on dimension

[kudu-CR] KUDU-2823 Place tablet replicas based on dimension

2019-07-08 Thread Yao Xu (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13632 to look at the new patch set (#13). Change subject: KUDU-2823 Place tablet replicas based on dimension

[kudu-CR] KUDU-2823 Place tablet replicas based on deminsion

2019-07-08 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13632 ) Change subject: KUDU-2823 Place tablet replicas based on deminsion .. Patch Set 11: (33 comments) Thanks for your comments. I fixed some

[kudu-CR] KUDU-2823 Place tablet replicas based on deminsion

2019-07-08 Thread Yao Xu (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13632 to look at the new patch set (#12). Change subject: KUDU-2823 Place tablet replicas based on deminsion

[kudu-CR] KUDU-2823 Place tablet replicas based on deminsion

2019-07-08 Thread Yao Xu (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13632 to look at the new patch set (#11). Change subject: KUDU-2823 Place tablet replicas based on deminsion

[kudu-CR] alter schema transaction-ToString function error condition is reverse, when error happens the server may crash

2019-07-02 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13782 ) Change subject: alter_schema_transaction-ToString function error_ condition is reverse, when error happens the server may crash .. Patch Set

[kudu-CR] KUDU-2876 Audit the semantics and the usage of Tabet::GetComponents

2019-07-01 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13750 ) Change subject: KUDU-2876 Audit the semantics and the usage of Tabet::GetComponents .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-2876 Audit the semantics and the usage of Tabet::GetComponents

2019-07-01 Thread Yao Xu (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13750 to look at the new patch set (#2). Change subject: KUDU-2876 Audit the semantics and the usage of Tabet::GetComponents

[kudu-CR] KUDU-2876 Audit the semantics and the usage of Tabet::GetComponents

2019-06-27 Thread Yao Xu (Code Review)
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13750 Change subject: KUDU-2876 Audit the semantics and the usage of Tabet::GetComponents .. KUDU-2876 Audit the semantics and the usage of

[kudu-CR] KUDU-2823 Place tablet replicas based on deminsion

2019-06-26 Thread Yao Xu (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13632 to look at the new patch set (#10). Change subject: KUDU-2823 Place tablet replicas based on deminsion

[kudu-CR] KUDU-2823 Place tablet replicas based on deminsion

2019-06-26 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13632 ) Change subject: KUDU-2823 Place tablet replicas based on deminsion .. Patch Set 9: (10 comments) I refactored this patch to make it more

[kudu-CR] KUDU-2823 Place tablet replicas based on deminsion

2019-06-26 Thread Yao Xu (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13632 to look at the new patch set (#9). Change subject: KUDU-2823 Place tablet replicas based on deminsion

[kudu-CR] KUDU-2823 Place tablet replicas based on deminsion

2019-06-26 Thread Yao Xu (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13632 to look at the new patch set (#8). Change subject: KUDU-2823 Place tablet replicas based on deminsion

[kudu-CR] KUDU-2483 (part 1/3) Add bloom filter predicate for Java API

2019-06-25 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13703 ) Change subject: KUDU-2483 (part 1/3) Add bloom filter predicate for Java API .. Patch Set 1: (2 comments)

[kudu-CR] [docs] Add docs for extra configuration properties

2019-06-24 Thread Yao Xu (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13704 to look at the new patch set (#4). Change subject: [docs] Add docs for extra configuration properties

[kudu-CR] [docs] Add docs for extra configuration properties

2019-06-24 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13704 ) Change subject: [docs] Add docs for extra configuration properties .. Patch Set 3: (3 comments) Thanks for comments, it looks much better

[kudu-CR] [docs] Add docs for extra configuration properties

2019-06-24 Thread Yao Xu (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13704 to look at the new patch set (#3). Change subject: [docs] Add docs for extra configuration properties

[kudu-CR] KUDU-2483 (part 1/3) Add bloom filter predicate for Java API

2019-06-21 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13703 ) Change subject: KUDU-2483 (part 1/3) Add bloom filter predicate for Java API .. Patch Set 1: (3 comments) I will first answer some

[kudu-CR] [docs] Add docs for extra configuration properties

2019-06-21 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13704 ) Change subject: [docs] Add docs for extra configuration properties .. Patch Set 2: (1 comment) > (1 comment) > > Thanks for this change!

[kudu-CR] [docs] Add docs for extra configuration properties

2019-06-21 Thread Yao Xu (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13704 to look at the new patch set (#2). Change subject: [docs] Add docs for extra configuration properties

[kudu-CR] [maintenance] Add extra config for maintenance manager task priority

2019-06-21 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13659 ) Change subject: [maintenance] Add extra config for maintenance manager task priority .. Patch Set 1: (1 comment)

[kudu-CR] [maintenance] Add extra config for maintenance manager task priority

2019-06-21 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13659 ) Change subject: [maintenance] Add extra config for maintenance manager task priority .. Patch Set 1: Code-Review+1 LGTM -- To view, visit

[kudu-CR] [docs] Add docs for extra configuration properties

2019-06-21 Thread Yao Xu (Code Review)
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13704 Change subject: [docs] Add docs for extra configuration properties .. [docs] Add docs for extra configuration properties Change-Id:

[kudu-CR] KUDU-2483 (part 1/3) Add bloom filter predicate for Java API

2019-06-21 Thread Yao Xu (Code Review)
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13703 Change subject: KUDU-2483 (part 1/3) Add bloom filter predicate for Java API .. KUDU-2483 (part 1/3) Add bloom filter predicate for Java API

  1   2   3   >