[kudu-CR] Update CMake to 3.25.3

2024-07-17 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21569 ) Change subject: Update CMake to 3.25.3 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21569/2//COMMIT_MSG Commit

[kudu-CR] Update CMake to 3.25.3

2024-07-17 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21569 ) Change subject: Update CMake to 3.25.3 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21569/2/thirdparty/vars.sh

[kudu-CR] Update CMake to 3.25.3

2024-07-17 Thread Zoltan Martonka (Code Review)
Hello Alexey Serbin, Ashwani Raina, Yingchun Lai, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21569 to look at the new patch set (#3). Change subject: Update CMake to 3.25.3

[kudu-CR] Update CMake to 3.22.6

2024-07-11 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21569 ) Change subject: Update CMake to 3.22.6 .. Patch Set 2: > Is the cmake_minimum_required in ./CMakeLists.txt needed to be > updated

[kudu-CR] Update CMake to 3.22.6

2024-07-11 Thread Zoltan Martonka (Code Review)
Hello Yingchun Lai, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21569 to look at the new patch set (#2). Change subject: Update CMake to 3.22.6 .. Update CMake to 3.22.6

[kudu-CR] Update CMake to 3.22.6

2024-07-10 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21569 Change subject: Update CMake to 3.22.6 .. Update CMake to 3.22.6 Reason for update: We need glog 0.7.0 for newer g++ to fix a symbol

[kudu-CR] Fix cache cleaning in dense node-itest

2024-07-08 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21509 ) Change subject: Fix cache cleaning in dense_node-itest .. Patch Set 4: I thin we would never use the other 2 versions of it. I

[kudu-CR] KUDU-3371 Add NO ROCKSDB build option

2024-07-04 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21560 ) Change subject: KUDU-3371 Add NO_ROCKSDB build option .. Patch Set 2: Code-Review+1 Thank you for the change. Could you also add a

[kudu-CR] Fix cache cleaning in dense node-itest

2024-06-26 Thread Zoltan Martonka (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21509 to look at the new patch set (#4). Change subject: Fix cache cleaning in dense_node-itest .. Fix

[kudu-CR] Fix cache cleaning in dense node-itest

2024-06-26 Thread Zoltan Martonka (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21509 to look at the new patch set (#3). Change subject: Fix cache cleaning in dense_node-itest .. Fix

[kudu-CR] Fix cache cleaning in dense node-itest

2024-06-19 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21509 ) Change subject: Fix cache cleaning in dense_node-itest .. Patch Set 1: (5 comments)

[kudu-CR] Fix cache cleaning in dense node-itest

2024-06-19 Thread Zoltan Martonka (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21509 to look at the new patch set (#2). Change subject: Fix cache cleaning in dense_node-itest .. Fix

[kudu-CR] Include table UUID when using --show table info

2024-06-12 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21496 ) Change subject: Include table UUID when using --show_table_info .. Patch Set 4: (1 comment)

[kudu-CR] Fix cache cleaning in dense node-itest

2024-06-12 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21509 Change subject: Fix cache cleaning in dense_node-itest .. Fix cache cleaning in dense_node-itest Running dense_node-itest with

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-06-07 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. Patch Set 15: I updated the performance results. Both in the

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-06-07 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. Patch Set 15: (7 comments)

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-06-07 Thread Zoltan Martonka (Code Review)
Hello Tidy Bot, Zoltan Chovan, Alexey Serbin, Ashwani Raina, Kudu Jenkins, Anonymous Coward (763), I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21127 to look at the new patch set (#15). Change subject: [ARM] Concurrent binary tree memory barriers fixed.

[kudu-CR] [build] bootstrap-dev-env.sh fix for ubuntu 22.04+

2024-06-04 Thread Zoltan Martonka (Code Review)
Hello Marton Greber, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20559 to look at the new patch set (#2). Change subject: [build] bootstrap-dev-env.sh fix for ubuntu 22.04+

[kudu-CR] Add a benchmark for CBTree concurrent writes.

2024-06-04 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21447 ) Change subject: Add a benchmark for CBTree concurrent writes. .. Patch Set 8: (2 comments) I think it is cleaner to add it to

[kudu-CR] Add a benchmark for CBTree concurrent writes.

2024-05-29 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21447 ) Change subject: Add a benchmark for CBTree concurrent writes. .. Patch Set 8: (4 comments)

[kudu-CR] Add a benchmark for CBTree concurrent writes.

2024-05-29 Thread Zoltan Martonka (Code Review)
Hello Zoltan Chovan, Alexey Serbin, Ashwani Raina, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21447 to look at the new patch set (#8). Change subject: Add a benchmark for CBTree concurrent writes.

[kudu-CR] Add a benchmark for CBTree concurrent writes.

2024-05-28 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21447 ) Change subject: Add a benchmark for CBTree concurrent writes. .. Patch Set 7: (5 comments)

[kudu-CR] Add a benchmark for CBTree concurrent writes.

2024-05-28 Thread Zoltan Martonka (Code Review)
Hello Alexey Serbin, Ashwani Raina, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21447 to look at the new patch set (#7). Change subject: Add a benchmark for CBTree concurrent writes.

[kudu-CR] Add a benchmark for CBTree concurrent writes.

2024-05-28 Thread Zoltan Martonka (Code Review)
Hello Alexey Serbin, Ashwani Raina, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21447 to look at the new patch set (#6). Change subject: Add a benchmark for CBTree concurrent writes.

[kudu-CR] Add a benchmark for CBTree concurrent writes.

2024-05-28 Thread Zoltan Martonka (Code Review)
Hello Alexey Serbin, Ashwani Raina, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21447 to look at the new patch set (#5). Change subject: Add a benchmark for CBTree concurrent writes.

[kudu-CR] Add a benchmark for CBTree concurrent writes.

2024-05-23 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21447 ) Change subject: Add a benchmark for CBTree concurrent writes. .. Patch Set 4: (17 comments)

[kudu-CR] Add a benchmark for CBTree concurrent writes.

2024-05-23 Thread Zoltan Martonka (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21447 to look at the new patch set (#4). Change subject: Add a benchmark for CBTree concurrent writes. ..

[kudu-CR] Add a benchmark for CBTree concurrent writes.

2024-05-23 Thread Zoltan Martonka (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21447 to look at the new patch set (#3). Change subject: Add a benchmark for CBTree concurrent writes. ..

[kudu-CR] Add a benchmark for CBTree concurrent writes.

2024-05-23 Thread Zoltan Martonka (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21447 to look at the new patch set (#2). Change subject: Add a benchmark for CBTree concurrent writes. ..

[kudu-CR] Fix deadlock on fail for CBTree-test

2024-05-22 Thread Zoltan Martonka (Code Review)
Hello Ashwani Raina, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21446 to look at the new patch set (#4). Change subject: Fix deadlock on fail for CBTree-test .. Fix

[kudu-CR] Fix deadlock on fail for CBTree-test

2024-05-22 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21446 ) Change subject: Fix deadlock on fail for CBTree-test .. Patch Set 3: (3 comments)

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-05-22 Thread Zoltan Martonka (Code Review)
Hello Tidy Bot, Zoltan Chovan, Alexey Serbin, Ashwani Raina, Kudu Jenkins, Anonymous Coward (763), I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21127 to look at the new patch set (#14). Change subject: [ARM] Concurrent binary tree memory barriers fixed.

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-05-22 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. Patch Set 13: (7 comments) I updated the review. No more

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-05-22 Thread Zoltan Martonka (Code Review)
Hello Tidy Bot, Zoltan Chovan, Alexey Serbin, Ashwani Raina, Kudu Jenkins, Anonymous Coward (763), I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21127 to look at the new patch set (#13). Change subject: [ARM] Concurrent binary tree memory barriers fixed.

[kudu-CR] Fix deadlock on fail for CBTree-test

2024-05-22 Thread Zoltan Martonka (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21446 to look at the new patch set (#3). Change subject: Fix deadlock on fail for CBTree-test .. Fix deadlock on fail

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-05-22 Thread Zoltan Martonka (Code Review)
Hello Tidy Bot, Zoltan Chovan, Alexey Serbin, Ashwani Raina, Kudu Jenkins, Anonymous Coward (763), I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21127 to look at the new patch set (#12). Change subject: [ARM] Concurrent binary tree memory barriers fixed.

[kudu-CR] Fix deadlock on fail for CBTree-test

2024-05-22 Thread Zoltan Martonka (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21446 to look at the new patch set (#2). Change subject: Fix deadlock on fail for CBTree-test .. Fix deadlock on fail

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-05-21 Thread Zoltan Martonka (Code Review)
Hello Tidy Bot, Zoltan Chovan, Alexey Serbin, Ashwani Raina, Kudu Jenkins, Anonymous Coward (763), I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21127 to look at the new patch set (#11). Change subject: [ARM] Concurrent binary tree memory barriers fixed.

[kudu-CR] Add a benchmark for CBTree concurrent writes.

2024-05-21 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21447 Change subject: Add a benchmark for CBTree concurrent writes. .. Add a benchmark for CBTree concurrent writes. Before updating

[kudu-CR] Fix deadlock on fail for CBTree-test

2024-05-21 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21446 Change subject: Fix deadlock on fail for CBTree-test .. Fix deadlock on fail for CBTree-test When TestConcurrentIterateAndInsert,

[kudu-CR] [glog] Fix minidump-test for cold symbols.

2024-05-14 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21385 ) Change subject: [glog] Fix minidump-test for cold symbols. .. Patch Set 3: OK, I abandon this patch and will try to update to Glog

[kudu-CR] [glog] Fix minidump-test for cold symbols.

2024-05-14 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has abandoned this change. ( http://gerrit.cloudera.org:8080/21385 ) Change subject: [glog] Fix minidump-test for cold symbols. .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/21385 To

[kudu-CR] [security-flags-itest] Fix missing command line flags

2024-05-13 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21399 ) Change subject: [security-flags-itest] Fix missing command line flags .. Patch Set 3: Please add a proper description of the

[kudu-CR] [glog] Fix minidump-test for cold symbols.

2024-05-10 Thread Zoltan Martonka (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21385 to look at the new patch set (#2). Change subject: [glog] Fix minidump-test for cold symbols. ..

[kudu-CR] [glog] Fix minidump-test for cold symbols.

2024-05-10 Thread Zoltan Martonka (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21385 to look at the new patch set (#3). Change subject: [glog] Fix minidump-test for cold symbols. ..

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-05-07 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. Patch Set 9: > (1 comment) > > > (1 comment) > > > > I

[kudu-CR] [g++11] Fix DecrementIntCell for g++10 and g++11

2024-05-03 Thread Zoltan Martonka (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21396 to look at the new patch set (#2). Change subject: [g++11] Fix DecrementIntCell for g++10 and g++11

[kudu-CR] [g++11] Fix DecrementIntCell for g++10 and g++11

2024-05-03 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21396 Change subject: [g++11] Fix DecrementIntCell for g++10 and g++11 .. [g++11] Fix DecrementIntCell for g++10 and g++11 There seems to

[kudu-CR] [glog] Fix minidump-test for cold symbols.

2024-05-02 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21385 Change subject: [glog] Fix minidump-test for cold symbols. .. [glog] Fix minidump-test for cold symbols. glog 0.6.0 cannot reliably

[kudu-CR] [build] Fix RocksDB Snappy dependency.

2024-05-02 Thread Zoltan Martonka (Code Review)
Hello Yingchun Lai, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21370 to look at the new patch set (#3). Change subject: [build] Fix RocksDB Snappy dependency.

[kudu-CR] KUDU-3568 Fix budgeting constraint test by enabling preset factor

2024-05-02 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21360 ) Change subject: KUDU-3568 Fix budgeting constraint test by enabling preset factor .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] [Python] Update dependencies and 3.10 support

2024-05-02 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21380 ) Change subject: [Python] Update dependencies and 3.10 support .. Patch Set 4: Code-Review+1 -- To view, visit

[kudu-CR] [build] Fix RocksDB Snappy dependency.

2024-04-30 Thread Zoltan Martonka (Code Review)
Hello Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21370 to look at the new patch set (#2). Change subject: [build] Fix RocksDB Snappy dependency. .. [build]

[kudu-CR] [build] Fix RocksDB Snappy dependency.

2024-04-29 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21370 Change subject: [build] Fix RocksDB Snappy dependency. .. [build] Fix RocksDB Snappy dependency. RocksDB uses Snappy. When

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-04-23 Thread Zoltan Martonka (Code Review)
Hello Tidy Bot, Zoltan Chovan, Alexey Serbin, Ashwani Raina, Kudu Jenkins, Anonymous Coward (763), I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21127 to look at the new patch set (#10). Change subject: [ARM] Concurrent binary tree memory barriers fixed.

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-04-23 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. Patch Set 6: (1 comment) I realized that, the only proper

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-04-23 Thread Zoltan Martonka (Code Review)
Hello Tidy Bot, Zoltan Chovan, Alexey Serbin, Ashwani Raina, Kudu Jenkins, Anonymous Coward (763), I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21127 to look at the new patch set (#9). Change subject: [ARM] Concurrent binary tree memory barriers fixed.

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-04-23 Thread Zoltan Martonka (Code Review)
Hello Tidy Bot, Zoltan Chovan, Alexey Serbin, Ashwani Raina, Kudu Jenkins, Anonymous Coward (763), I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21127 to look at the new patch set (#8). Change subject: [ARM] Concurrent binary tree memory barriers fixed.

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-04-23 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. Patch Set 6: (1 comment)

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-04-23 Thread Zoltan Martonka (Code Review)
Hello Tidy Bot, Zoltan Chovan, Alexey Serbin, Ashwani Raina, Kudu Jenkins, Anonymous Coward (763), I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21127 to look at the new patch set (#7). Change subject: [ARM] Concurrent binary tree memory barriers fixed.

[kudu-CR] [CMakeLists] Make kudu test main static

2024-04-19 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21282 ) Change subject: [CMakeLists] Make kudu_test_main static .. Patch Set 1: (1 comment)

[kudu-CR] [CMakeLists] Make kudu test main static

2024-04-11 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21282 ) Change subject: [CMakeLists] Make kudu_test_main static .. Patch Set 1: (2 comments)

[kudu-CR] [CMakeLists] Make kudu test main static

2024-04-11 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21282 ) Change subject: [CMakeLists] Make kudu_test_main static .. Patch Set 1: (1 comment)

[kudu-CR] [tablet] one less memory allocation in CBTree::count()

2024-04-11 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21276 ) Change subject: [tablet] one less memory allocation in CBTree::count() .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-04-10 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. Patch Set 6: (1 comment)

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-03-26 Thread Zoltan Martonka (Code Review)
Hello Tidy Bot, Zoltan Chovan, Ashwani Raina, Kudu Jenkins, Anonymous Coward (763), I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21127 to look at the new patch set (#6). Change subject: [ARM] Concurrent binary tree memory barriers fixed.

[kudu-CR] [debug] Fallback to load from libc

2024-03-26 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21204 ) Change subject: [debug] Fallback to load from libc .. Patch Set 2: (1 comment)

[kudu-CR] [debug] Fallback to load from libc

2024-03-26 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21204 ) Change subject: [debug] Fallback to load from libc .. Patch Set 2: (1 comment)

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-03-26 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. Patch Set 5: (1 comment)

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-03-26 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. Patch Set 5: (1 comment)

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-03-26 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. Patch Set 5: I have nothing to do with the Tidy bot warning

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-03-26 Thread Zoltan Martonka (Code Review)
Hello Zoltan Chovan, Ashwani Raina, Kudu Jenkins, Anonymous Coward (763), I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21127 to look at the new patch set (#5). Change subject: [ARM] Concurrent binary tree memory barriers fixed.

[kudu-CR] WIP [ARM] Concurrent binary tree memory fences fixed.

2024-03-19 Thread Zoltan Martonka (Code Review)
Hello Zoltan Chovan, Ashwani Raina, Kudu Jenkins, Anonymous Coward (763), I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21127 to look at the new patch set (#4). Change subject: WIP [ARM] Concurrent binary tree memory fences fixed.

[kudu-CR] WIP [ARM] Concurrent binary tree memory fences fixed.

2024-03-11 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: WIP [ARM] Concurrent binary tree memory fences fixed. .. Patch Set 3: (1 comment)

[kudu-CR] WIP [ARM] Concurrent binary tree memory fences fixed.

2024-03-11 Thread Zoltan Martonka (Code Review)
Hello Kudu Jenkins, Anonymous Coward (763), I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21127 to look at the new patch set (#3). Change subject: WIP [ARM] Concurrent binary tree memory fences fixed.

[kudu-CR] WIP [ARM] Concurrent binary tree memory fences fixed.

2024-03-08 Thread Zoltan Martonka (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21127 to look at the new patch set (#2). Change subject: WIP [ARM] Concurrent binary tree memory fences fixed. .. WIP

[kudu-CR] iWIP [ARM] Concurrent binary tree memory fences fixed.

2024-03-08 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21127 Change subject: iWIP [ARM] Concurrent binary tree memory fences fixed. .. iWIP [ARM] Concurrent binary tree memory fences fixed.

[kudu-CR] [rpc] fix typo in branch prediction

2024-02-20 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21044 ) Change subject: [rpc] fix typo in branch prediction .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-3527 Fix block manager test when using 64k container block alignment

2024-01-29 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20725 ) Change subject: KUDU-3527 Fix block manager test when using 64k container block alignment .. Patch Set 14: (9 comments)

[kudu-CR] KUDU-3527 Fix block manager test when using 64k container block alignment

2024-01-29 Thread Zoltan Martonka (Code Review)
Hello Mahesh Reddy, Alexey Serbin, Ashwani Raina, Kudu Jenkins, Abhishek Chennaka, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20725 to look at the new patch set (#15). Change subject: KUDU-3527 Fix block manager test when using 64k

[kudu-CR] KUDU-3527 Fix block manager test when using 64k container block alignment

2024-01-26 Thread Zoltan Martonka (Code Review)
Hello Mahesh Reddy, Alexey Serbin, Ashwani Raina, Kudu Jenkins, Abhishek Chennaka, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20725 to look at the new patch set (#14). Change subject: KUDU-3527 Fix block manager test when using 64k

[kudu-CR] KUDU-3527 Fix block manager test when using 64k container block alignment

2024-01-26 Thread Zoltan Martonka (Code Review)
Hello Mahesh Reddy, Alexey Serbin, Ashwani Raina, Kudu Jenkins, Abhishek Chennaka, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20725 to look at the new patch set (#13). Change subject: KUDU-3527 Fix block manager test when using 64k

[kudu-CR] KUDU-3527 Fix block manager test when using 64k container block alignment

2024-01-25 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20725 ) Change subject: KUDU-3527 Fix block manager test when using 64k container block alignment .. Patch Set 9: (5 comments)

[kudu-CR] KUDU-3527 Fix block manager test when using 64k container block alignment

2024-01-25 Thread Zoltan Martonka (Code Review)
Hello Mahesh Reddy, Alexey Serbin, Ashwani Raina, Kudu Jenkins, Abhishek Chennaka, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20725 to look at the new patch set (#12). Change subject: KUDU-3527 Fix block manager test when using 64k

[kudu-CR] KUDU-3527 Fix block manager test when using 64k container block alignment

2024-01-25 Thread Zoltan Martonka (Code Review)
Hello Mahesh Reddy, Alexey Serbin, Ashwani Raina, Kudu Jenkins, Abhishek Chennaka, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20725 to look at the new patch set (#11). Change subject: KUDU-3527 Fix block manager test when using 64k

[kudu-CR] KUDU-3527 Fix block manager test when using 64k container block alignment

2024-01-25 Thread Zoltan Martonka (Code Review)
Hello Mahesh Reddy, Alexey Serbin, Ashwani Raina, Kudu Jenkins, Abhishek Chennaka, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20725 to look at the new patch set (#10). Change subject: KUDU-3527 Fix block manager test when using 64k

[kudu-CR] KUDU-3527 Fix block manager test when using 64k container block alignment

2024-01-25 Thread Zoltan Martonka (Code Review)
Hello Mahesh Reddy, Alexey Serbin, Ashwani Raina, Kudu Jenkins, Abhishek Chennaka, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20725 to look at the new patch set (#9). Change subject: KUDU-3527 Fix block manager test when using 64k container

[kudu-CR] KUDU-3527 Fix block manager test when using 64k container block alignment

2024-01-24 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20725 ) Change subject: KUDU-3527 Fix block manager test when using 64k container block alignment .. Patch Set 7: (8 comments)

[kudu-CR] KUDU-3527 Fix block manager test when using 64k container block alignment

2024-01-24 Thread Zoltan Martonka (Code Review)
Hello Mahesh Reddy, Alexey Serbin, Ashwani Raina, Kudu Jenkins, Abhishek Chennaka, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20725 to look at the new patch set (#8). Change subject: KUDU-3527 Fix block manager test when using 64k container

[kudu-CR] KUDU-3527 Fix block manager test on 64k filesystems

2024-01-19 Thread Zoltan Martonka (Code Review)
Hello Mahesh Reddy, Alexey Serbin, Ashwani Raina, Kudu Jenkins, Abhishek Chennaka, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20725 to look at the new patch set (#7). Change subject: KUDU-3527 Fix block manager test on 64k filesystems

[kudu-CR] Fix CheckHolePunch for bigger than 4k blocks.

2024-01-19 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20894 ) Change subject: Fix CheckHolePunch for bigger than 4k blocks. .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-3523 Use f bsize as Kudu block size instead of st blksize

2024-01-16 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20680 ) Change subject: KUDU-3523 Use f_bsize as Kudu block size instead of st_blksize .. Patch Set 4: > Do you have any real problem

[kudu-CR] KUDU-3523 Use f bsize as Kudu block size instead of st blksize

2024-01-16 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20680 ) Change subject: KUDU-3523 Use f_bsize as Kudu block size instead of st_blksize .. Patch Set 4: Do you have any real problem running

[kudu-CR] Fix CheckHolePunch for bigger than 4k blocks.

2024-01-16 Thread Zoltan Martonka (Code Review)
Hello Ashwani Raina, Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20894 to look at the new patch set (#5). Change subject: Fix CheckHolePunch for bigger than 4k blocks.

[kudu-CR] Fix CheckHolePunch for bigger than 4k blocks.

2024-01-16 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20894 ) Change subject: Fix CheckHolePunch for bigger than 4k blocks. .. Patch Set 4: (3 comments)

[kudu-CR] Fix CheckHolePunch for bigger than 4k blocks.

2024-01-16 Thread Zoltan Martonka (Code Review)
Hello Ashwani Raina, Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20894 to look at the new patch set (#4). Change subject: Fix CheckHolePunch for bigger than 4k blocks.

[kudu-CR] Fix CheckHolePunch for bigger than 4k blocks.

2024-01-16 Thread Zoltan Martonka (Code Review)
Hello Ashwani Raina, Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20894 to look at the new patch set (#3). Change subject: Fix CheckHolePunch for bigger than 4k blocks.

[kudu-CR] [log block manager-test] Improve random selection

2024-01-15 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20899 ) Change subject: [log_block_manager-test] Improve random selection .. Patch Set 4: (2 comments)

[kudu-CR] Fix CheckHolePunch for bigger than 4k blocks.

2024-01-15 Thread Zoltan Martonka (Code Review)
Hello Kudu Jenkins, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20894 to look at the new patch set (#2). Change subject: Fix CheckHolePunch for bigger than 4k blocks. .. Fix

[kudu-CR] Fix CheckHolePunch for bigger than 4k blocks.

2024-01-14 Thread Zoltan Martonka (Code Review)
Zoltan Martonka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20894 Change subject: Fix CheckHolePunch for bigger than 4k blocks. .. Fix CheckHolePunch for bigger than 4k blocks. With the new 64k ARM

  1   2   >