Re: Review Request 54068: Fixed some nits in hooks interfaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54068/#review156945 --- Patch looks great! Reviews applied: [54038, 54068] Passed

Re: Review Request 54088: Removed unused header include from stout's hashmap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54088/#review156942 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 54085: Made internal Mesos headers more standalone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54085/#review156940 --- Patch looks great! Reviews applied: [54085] Passed command:

Re: Review Request 54084: Made public Mesos header standalone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54084/#review156937 --- Patch looks great! Reviews applied: [54084] Passed command:

Re: Review Request 54083: Made headers in stout standalone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54083/#review156936 --- Patch looks great! Reviews applied: [54083] Passed command:

Re: Review Request 54068: Fixed some nits in hooks interfaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54068/ --- (Updated Nov. 25, 2016, 9:38 p.m.) Review request for mesos, Adam B, Gastón

Re: Review Request 54038: Added new hook for covering executor and task environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54038/ --- (Updated Nov. 25, 2016, 9:37 p.m.) Review request for mesos, Adam B, Gastón

Re: Review Request 54081: Added `--pidfile` option to master and agent binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54081/#review156935 --- Patch looks great! Reviews applied: [54081] Passed command:

Review Request 54087: Updated stout's README.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54087/ --- Review request for mesos. Repository: mesos Description --- Updated

Review Request 54088: Removed unused header include from stout's hashmap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54088/ --- Review request for mesos. Repository: mesos Description --- Removed

Re: Review Request 54077: Made sure parser settings member is properly initialized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54077/#review156933 --- Patch looks great! Reviews applied: [54077] Passed command:

Review Request 54084: Made public Mesos header standalone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54084/ --- Review request for mesos, Kevin Klues and Qian Zhang. Repository: mesos

Review Request 54083: Made headers in stout standalone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54083/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 54085: Made internal Mesos headers more standalone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54085/ --- Review request for mesos, Alexander Rojas and Jiang Yan Xu. Repository: mesos

Review Request 54081: Added `--pidfile` option to master and agent binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54081/ --- Review request for mesos, Benjamin Mahler and Vinod Kone. Bugs: MESOS-1648

Re: Review Request 54077: Made sure parser settings member is properly initialized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54077/ --- (Updated Nov. 25, 2016, 5:07 p.m.) Review request for mesos and Anand

Re: Review Request 54077: Made sure parser settings member is properly initialized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54077/#review156930 --- Thanks for the cleanup. Can you do a sweep in this file and fix

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

> On Nov. 25, 2016, 3:04 p.m., Guangya Liu wrote: > > src/master/validation.cpp, lines 295-305 > > > > > > How about the following? > > > > ``` > > // TODO(jay_guo) Consider extending this method to

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54062/ --- (Updated Nov. 25, 2016, 3:40 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

> On Nov. 25, 2016, 3:09 p.m., haosdent huang wrote: > > src/tests/health_check_tests.cpp, line 842 > > > > > > Change here to make it consistent with > > > > ``` > > // This test creates a task whose

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/#review156925 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 25, 2016,

Re: Review Request 53849: Added parsing of V2 schema 2 Docker image manifests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53849/ --- (Updated Nov. 25, 2016, 3:15 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52865/ --- (Updated Nov. 25, 2016, 3:10 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/#review156922 --- src/tests/health_check_tests.cpp (line 842)

Re: Review Request 52869: Ensured command executor stops health checking terminated tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52869/ --- (Updated Nov. 25, 2016, 3:09 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52870: Ensured docker executor stops health checking terminated tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52870/ --- (Updated Nov. 25, 2016, 3:09 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/ --- (Updated Nov. 25, 2016, 3:08 p.m.) Review request for mesos, Alexander

Re: Review Request 47088: Dropped http status check in HealthCheckTest.HealthStatusChange.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47088/ --- (Updated Nov. 25, 2016, 3:08 p.m.) Review request for mesos, Alexander

Re: Review Request 52869: Ensured command executor stops health checking terminated tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52869/ --- (Updated Nov. 25, 2016, 3:07 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52870: Ensured docker executor stops health checking terminated tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52870/ --- (Updated Nov. 25, 2016, 3:07 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54062/#review156920 --- src/master/validation.hpp (lines 60 - 61)

Re: Review Request 53607: Added Seccomp imeplementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53607/ --- (Updated Nov. 25, 2016, 2:47 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 53608: Added --enable-seccomp flag to configure options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53608/ --- (Updated Nov. 25, 2016, 2:47 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 53606: Added `linux/seccomp` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53606/ --- (Updated Nov. 25, 2016, 2:47 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 53605: Added --seccomp_profile flag to Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53605/ --- (Updated Nov. 25, 2016, 2:46 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 53604: Added SeccompInfo protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53604/ --- (Updated Nov. 25, 2016, 2:46 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 54068: Fixed some nits in hooks interfaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54068/#review156919 --- Ship it! Ship It! - Gastón Kleiman On Nov. 25, 2016, 4:30

Re: Review Request 54038: Added new hook for covering executor and task environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54038/#review156918 --- Fix it, then Ship it! Just a few typos, but it looks good to

Re: Review Request 52382: Added stubs for OCI store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52382/#review156917 --- Patch looks great! Reviews applied: [52349, 52379, 52382]

Re: Review Request 54007: Printed complete health check configuration on task launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54007/ --- (Updated Nov. 25, 2016, 11:56 a.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 52868: Health checks may be stopped on demand.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52868/#review156914 --- Ship it! Ship It! - Gastón Kleiman On Nov. 25, 2016, 11:50

Re: Review Request 54007: Printed complete health check configuration on task launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54007/ --- (Updated Nov. 25, 2016, 11:52 a.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 52872: Used callback instead of `send()` for health status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52872/ --- (Updated Nov. 25, 2016, 11:52 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52873: Cleaned up private members in HealthChecker class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52873/ --- (Updated Nov. 25, 2016, 11:52 a.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 52868: Health checks may be stopped on demand.

> On Nov. 24, 2016, 5:25 p.m., Gastón Kleiman wrote: > > I think that `HealthChecker::stop()` should just terminate the actor, no > > need to introduce a boolean. Good idea. WILCO. - Alexander --- This is an automatically generated

Re: Review Request 52871: Ensured default executor ignores health updates for terminated tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52871/ --- (Updated Nov. 25, 2016, 11:51 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52869: Ensured command executor stops health checking terminated tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52869/ --- (Updated Nov. 25, 2016, 11:50 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52868: Health checks may be stopped on demand.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52868/ --- (Updated Nov. 25, 2016, 11:50 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52866/ --- (Updated Nov. 25, 2016, 11:49 a.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 52870: Ensured docker executor stops health checking terminated tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52870/ --- (Updated Nov. 25, 2016, 11:50 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52867: Used `Duration::create()` for double -> Duration conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52867/ --- (Updated Nov. 25, 2016, 11:49 a.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 54004: Renamed functions in HealthChecker for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54004/ --- (Updated Nov. 25, 2016, 11:49 a.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52865/ --- (Updated Nov. 25, 2016, 11:49 a.m.) Review request for mesos, Anand Mazumdar,

Review Request 54077: Made sure parser settings member is properly initialized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54077/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-6646

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54062/ --- (Updated Nov. 25, 2016, 11:26 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 54068: Fixed some nits in hooks interfaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54068/#review156910 --- Patch looks great! Reviews applied: [54038, 54068] Passed

Re: Review Request 53949: Added test helper to obtain unused port.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53949/#review156908 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 25, 2016,

Re: Review Request 53950: Avoided hardcoding ports in some tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53950/#review156907 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 24, 2016,

Re: Review Request 54074: Added isolator nested aware user doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54074/#review156905 --- docs/mesos-containerizer.md (line 413)

Re: Review Request 54013: Added user doc for nested container and task group.

> On Nov. 24, 2016, 2:41 p.m., Qian Zhang wrote: > > docs/nested-container-and-task-group.md, line 209 > > > > > > Currently we only support a single level of container nesting, right? > > If so, then I think we

Re: Review Request 53949: Added test helper to obtain unused port.

> On Nov. 24, 2016, 6:34 p.m., Alexander Rukletsov wrote: > > src/tests/utils.hpp, line 80 > > > > > > #include Even though this is the correct header for C++ code like we have here, we seem to widely prefer

Re: Review Request 53949: Added test helper to obtain unused port.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53949/ --- (Updated Nov. 25, 2016, 10:05 a.m.) Review request for mesos, Alexander

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54062/#review156890 --- src/master/master.cpp (line 2336)

Re: Review Request 53950: Avoided hardcoding ports in some tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53950/#review156898 --- Patch looks great! Reviews applied: [53948, 53986, 53949, 53950]

Review Request 54074: Added isolator nested aware user doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54074/ --- Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, Qian

Re: Review Request 54013: Added user doc for nested container and task group.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54013/ --- (Updated Nov. 25, 2016, 12:36 a.m.) Review request for mesos, Benjamin Mahler,

Review Request 54073: Added linux launcher nested container support doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54073/ --- Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, Qian

Re: Review Request 54013: Added user doc for nested container and task group.

> On Nov. 23, 2016, 10:41 p.m., Qian Zhang wrote: > > docs/nested-container-and-task-group.md, line 166 > > > > > > Indent, it seems a space is missed here. Good catch, Qian. > On Nov. 23, 2016, 10:41 p.m., Qian