Re: Review Request 59641: Follow symlinks when resolving paths specified in the various master/agent endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59641/#review176576 --- Patch looks great! Reviews applied: [59641] Passed command:

Re: Review Request 59696: Added test to verify GPU filtering with '--filter_gpu_resources=false'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59696/#review176566 --- Fix it, then Ship it!

Re: Review Request 59695: Added test to verify GPU filtering with '--filter_gpu_resources=true'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59695/#review176564 --- Fix it, then Ship it!

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51879/#review176411 --- Sorry this patch had to go through this long delay. We couldn't

Re: Review Request 57817: Offers not sent for suppressed roles as indicated in `SUBSCRIBE`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57817/ --- (Updated June 1, 2017, 12:38 a.m.) Review request for mesos, James Peach,

Re: Review Request 57818: Added unit tests to verify offers are suppressed based on registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57818/ --- (Updated June 1, 2017, 12:38 a.m.) Review request for mesos, James Peach,

Re: Review Request 59082: Added provider ID to offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59082/#review176559 --- include/mesos/mesos.proto Lines 1453 (patched)

Re: Review Request 59136: Added functions to add/remove resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59136/#review176558 --- src/master/master.hpp Lines 1857 (patched)

Re: Review Request 59680: Added the 'LocalResourceProvider' structure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59680/#review176557 --- src/master/master.hpp Lines 291 (patched)

Re: Review Request 59135: Refactored resource handling to use resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59135/#review174441 --- src/master/master.hpp Lines 159 (patched)

Re: Review Request 57818: Added unit tests to verify offers are suppressed based on registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57818/#review176553 --- Bad patch! Reviews applied: [57818, 57817, 57815] Failed

Re: Review Request 59691: Renamed `flags` to `libprocess_flags` to fix build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59691/#review176541 --- Ship it! Ship It! - Joseph Wu On May 31, 2017, 1:34 p.m.,

Review Request 59696: Added test to verify GPU filtering with '--filter_gpu_resources=false'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59696/ --- Review request for mesos, Anand Mazumdar and Benjamin Mahler. Bugs: MESOS-7576

Review Request 59695: Added test to verify GPU filtering with '--filter_gpu_resources=true'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59695/ --- Review request for mesos, Anand Mazumdar and Benjamin Mahler. Bugs: MESOS-7576

Re: Review Request 59677: Added '--filter_gpu_resources' flag to the mesos master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59677/ --- (Updated May 31, 2017, 9:34 p.m.) Review request for mesos and Benjamin

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

> On Dec. 15, 2016, 11:58 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/containerizer.cpp > > Lines 165-169 (original), 288-305 (patched) > > > > > > Here what I found to be a bit awkward: > > > >

Re: Review Request 59662: Changed `Executor` and `Framework` to class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59662/#review176528 --- Ship it! Ship It! - Anand Mazumdar On May 30, 2017, 11:15

Re: Review Request 59551: Change launcher working directory before dropping privilege.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59551/#review176527 --- Ship it! Ship It! - Jie Yu On May 24, 2017, 11:45 p.m.,

Re: Review Request 59671: Reordered `Slave` copy constructor and assignment operator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59671/#review176526 --- Ship it! Ship It! - Anand Mazumdar On May 30, 2017, 11:50

Re: Review Request 59671: Reordered `Slave` copy constructor and assignment operator.

> On May 31, 2017, 4:59 p.m., Anand Mazumdar wrote: > > Can we do these in the same review where we started using `delete`? Sorry, rebasing will be hard :( - Jie --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 59666: Moved Framework::addTask to the source file.

> On May 31, 2017, 4:45 p.m., Anand Mazumdar wrote: > > src/slave/slave.hpp > > Lines 868 (patched) > > > > > > Update the summary/description to `hasTask()` instead of `addTask()`? Fixed. Good catch. - Jie

Re: Review Request 59662: Changed `Executor` and `Framework` to class.

> On May 31, 2017, 4:37 p.m., Anand Mazumdar wrote: > > src/slave/slave.hpp > > Lines 689 (patched) > > > > > > hmm, I like it the other way around i.e., since this class has a lot of > > public fields, `struct` is

Re: Review Request 59659: Used `delete` for `Slave` copy constructor and assignment operator.

> On May 31, 2017, 4:32 p.m., Anand Mazumdar wrote: > > src/slave/slave.hpp > > Lines 507-508 (original), 507-508 (patched) > > > > > > Nit: Can we move it after the constructor declaration now that it no > >

Re: Review Request 59659: Used `delete` for `Slave` copy constructor and assignment operator.

> On May 31, 2017, 4:32 p.m., Anand Mazumdar wrote: > > - Can we do a sweep for the `Framework`/`Executor` structs too? I haven't > > had a look later in the chain yet. > > - Can we do a similar cleanup for the Master header file too? Framework and Executor cleanup is in the subsequent patch.

Re: Review Request 59233: Updated v6 address for containers running on host network.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59233/#review176515 --- Bad patch! Reviews applied: [59233, 59131, 59130, 59129, 59688,

Re: Review Request 59320: Added test case for agent re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59320/ --- (Updated May 31, 2017, 8:35 p.m.) Review request for mesos and Benjamin

Review Request 59691: Renamed `flags` to `libprocess_flags` to fix build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59691/ --- Review request for mesos, Benjamin Mahler and Joseph Wu. Bugs: MESOS-7597

Re: Review Request 59320: Added test case for agent re-registration.

> On May 31, 2017, 12:09 a.m., Benjamin Mahler wrote: > > src/tests/partition_tests.cpp > > Lines 2387 (patched) > > > > > > Hm.. why disabled on windows? Do you know why or is this just copied? > > For example,

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58224/#review176508 --- Does not build on Windows. Please ensure that the tests include

Re: Review Request 59677: Added '--filter_gpu_resources' flag to the mesos master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59677/#review176499 --- Fix it, then Ship it! docs/configuration.md Lines 637-643

Re: Review Request 59641: Follow symlinks when resolving paths specified in the various master/agent endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59641/ --- (Updated May 31, 2017, 6:57 p.m.) Review request for mesos, Andrew

Re: Review Request 59302: Simplified master logic for agent re-registration.

> On May 30, 2017, 11:44 p.m., Benjamin Mahler wrote: > > Looking at this patch in isolation, it's hard to see what this > > simplifcation has to do with 0.x agents, so the description was a little > > confusing for me. Did some previous patches in the chain set us up for > > simplifying

Re: Review Request 59131: Added an IPv6 address storage to UPID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59131/ --- (Updated May 31, 2017, 6:40 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 59130: Added storage for IPv6 in a `libprocess` process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59130/ --- (Updated May 31, 2017, 6:40 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 59129: Introduced `inet6::Address` to handle IPv6 addresses in `libprocess`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59129/ --- (Updated May 31, 2017, 6:38 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 59233: Updated v6 address for containers running on host network.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59233/ --- (Updated May 31, 2017, 6:38 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 59688: Moved `net::IPNetwork` to `net::IP::Network`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59688/ --- (Updated May 31, 2017, 6:37 p.m.) Review request for mesos, Benjamin Hindman

Review Request 59688: Moved `net::IPNetwork` to `net::IP::Network`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59688/ --- Review request for mesos, Benjamin Hindman and Jie Yu. Bugs: MESOS-7488

Re: Review Request 59219: Removed logic for handling missing FrameworkID in ExecutorInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59219/ --- (Updated May 31, 2017, 6:27 p.m.) Review request for mesos and Benjamin

Re: Review Request 59428: Moved a couple of logging lines to `WARNING` level.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59428/#review176491 --- Bad patch! Reviews applied: [59504, 59428] Failed command:

Re: Review Request 59428: Moved a couple of logging lines to `WARNING` level.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59428/#review176490 --- Ship it! Ship It! - Vinod Kone On May 23, 2017, 9:57 p.m.,

Re: Review Request 59685: Fixed flakiness in OneWayPartitionTest.MasterToSlave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59685/ --- (Updated May 31, 2017, 6:04 p.m.) Review request for mesos. Changes ---

Re: Review Request 56721: Implemented pruneImages with a mark and sweep in docker store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56721/ --- (Updated May 31, 2017, 6:01 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 55727: Checkpoint and track docker image layer sizes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55727/ --- (Updated May 31, 2017, 6 p.m.) Review request for mesos, Gilbert Song, Jason

Review Request 59687: Added tests for recovering ContainerConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59687/ --- Review request for mesos, Gilbert Song and Jason Lai. Bugs: MESOS-6894

Re: Review Request 53105: Added an hourly timer for `slave/docker_containerizer/pull`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53105/ --- (Updated May 31, 2017, 5:58 p.m.) Review request for mesos, Xiaojian Huang,

Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55335/ --- (Updated May 31, 2017, 5:57 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 55334: Checkpoint and recover `ContainerConfig` in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55334/ --- (Updated May 31, 2017, 5:57 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 59685: Fixed flakiness in OneWayPartitionTest.MasterToSlave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59685/#review176483 --- Fix it, then Ship it! src/tests/partition_tests.cpp Lines

Re: Review Request 59673: Combined an 'undef' workaround for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59673/#review176482 --- Ship it! Ship It! - Anand Mazumdar On May 30, 2017, 11:51

Re: Review Request 59672: Reordered gauge methods in `Slave` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59672/#review176480 --- Ship it! Ship It! - Anand Mazumdar On May 30, 2017, 11:51

Re: Review Request 59671: Reordered `Slave` copy constructor and assignment operator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59671/#review176479 --- Can we do these in the same review where we started using

Re: Review Request 59670: Removed an unnecessary declaration in slave.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59670/#review176478 --- Ship it! Ship It! - Anand Mazumdar On May 30, 2017, 11:50

Re: Review Request 59669: Removed some unnecessary std:: prefix in slave.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59669/#review176476 --- Fix it, then Ship it! src/slave/slave.cpp Lines 133 (patched)

Re: Review Request 59685: Fixed flakiness in OneWayPartitionTest.MasterToSlave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59685/#review176477 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Review Request 59685: Fixed flakiness in OneWayPartitionTest.MasterToSlave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59685/ --- Review request for mesos. Repository: mesos Description --- The test

Re: Review Request 59668: Removed an unnecessary function declaration from slave.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59668/#review176475 --- Ship it! Ship It! - Anand Mazumdar On May 30, 2017, 11:18

Re: Review Request 59667: Reordered the methods in `Framework` into logic units.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59667/#review176473 --- Fix it, then Ship it! src/slave/slave.cpp Lines 4885

Re: Review Request 59550: Check bounding capabilities at isolator creation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59550/#review176472 --- Ship it! Ship It! - Jie Yu On May 24, 2017, 11:45 p.m.,

Re: Review Request 59666: Moved Framework::addTask to the source file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59666/#review176471 --- Fix it, then Ship it! src/slave/slave.hpp Lines 868 (patched)

Re: Review Request 59665: Reordered the streaming functions in slave.hpp|cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59665/#review176469 --- Ship it! Ship It! - Anand Mazumdar On May 30, 2017, 11:16

Re: Review Request 59664: Used `delete` for deleting copy constructor and assignment operator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59664/#review176468 --- Fix it, then Ship it! ahh, seems like the

Re: Review Request 59663: Removed unnecessary friend declaration for an stream operator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59663/#review176467 --- Ship it! Good catch! - Anand Mazumdar On May 30, 2017,

Re: Review Request 59662: Changed `Executor` and `Framework` to class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59662/#review176466 --- src/slave/slave.hpp Lines 689 (patched)

Re: Review Request 59661: Fixed some style issues in slave.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59661/#review176465 --- Ship it! Ship It! - Anand Mazumdar On May 30, 2017, 11:14

Re: Review Request 59660: Reordered some method definitions in `Slave` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59660/#review176464 --- Ship it! Ship It! - Anand Mazumdar On May 30, 2017, 11:14

Re: Review Request 59659: Used `delete` for `Slave` copy constructor and assignment operator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59659/#review176463 --- Fix it, then Ship it! - Can we do a sweep for the

Re: Review Request 59549: Add the agent --bounding_capabilities flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59549/#review176462 --- Fix it, then Ship it! src/slave/flags.cpp Lines 603 (patched)

Re: Review Request 59548: Add a `bounding_capabilities` field to ContainerLaunchInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59548/#review176461 --- Ship it! Ship It! - Jie Yu On May 24, 2017, 11:42 p.m.,

Re: Review Request 59547: Rename ContainerLaunchInfo `capabilities` field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59547/#review176460 --- Ship it! Ship It! - Jie Yu On May 24, 2017, 11:41 p.m.,

Re: Review Request 57818: Added unit tests to verify offers are suppressed based on registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57818/#review176455 --- Patch looks great! Reviews applied: [57815, 57817, 57818]

Re: Review Request 59641: Follow symlinks when resolving paths specified in the various master/agent endpoints.

> On May 31, 2017, 1:05 a.m., Vinod Kone wrote: > > src/files/files.cpp > > Line 874 (original), 874 (patched) > > > > > > I don't follow this. Why are we checking random prefixes for whether > > they are symlinks

Re: Review Request 57818: Added unit tests to verify offers are suppressed based on registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57818/ --- (Updated May 31, 2017, 2:53 p.m.) Review request for mesos, James Peach, Vinod

Re: Review Request 57817: Offers not sent for suppressed roles as indicated in `SUBSCRIBE`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57817/ --- (Updated May 31, 2017, 2:52 p.m.) Review request for mesos, James Peach, Vinod

Re: Review Request 59605: Use glog for logging in executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59605/#review176448 --- src/docker/executor.cpp Line 734 (original), 734 (patched)

Re: Review Request 59634: Updated 'config.py' in the new Mesos CLI to take settings as parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59634/#review176445 --- Patch looks great! Reviews applied: [59634] Passed command:

Re: Review Request 59525: Added filtering of `/slaves` endpoint and `GET_AGENTS` API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59525/#review176443 --- Patch looks great! Reviews applied: [59453, 58955, 58964, 59099,

Re: Review Request 58720: Extended the unit test infrastructure in the new Mesos CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review176439 --- Patch looks great! Reviews applied: [58720] Passed command:

Re: Review Request 59136: Added functions to add/remove resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59136/ --- (Updated May 31, 2017, 2:44 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 59680: Added the 'LocalResourceProvider' structure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59680/ --- (Updated May 31, 2017, 2:43 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 59135: Refactored resource handling to use resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59135/ --- (Updated May 31, 2017, 2:43 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 59525: Added filtering of `/slaves` endpoint and `GET_AGENTS` API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59525/ --- (Updated May 31, 2017, 2:41 p.m.) Review request for mesos, Adam B and Greg

Re: Review Request 58720: Extended the unit test infrastructure in the new Mesos CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/ --- (Updated May 31, 2017, 12:10 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 59681: Updated offer handling to support local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59681/ --- (Updated May 31, 2017, 1:57 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 59525: Added filtering of roles in the endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59525/#review176433 --- Patch looks great! Reviews applied: [59453, 58955, 58964, 59099,

Review Request 59525: Added filtering of roles in the endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59525/ --- Review request for mesos, Adam B and Greg Mann. Bugs: MESOS-7416

Re: Review Request 59677: Added '--filter_gpu_resources' flag to the mesos master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59677/#review176431 --- Patch looks great! Reviews applied: [59677] Passed command:

Re: Review Request 59082: Added provider ID to offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59082/ --- (Updated May 31, 2017, 12:02 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 59136: Added functions to add/remove resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59136/ --- (Updated May 31, 2017, 12:01 p.m.) Review request for mesos, Benjamin Bannier

Review Request 59680: Added the 'LocalResourceProvider' structure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59680/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos

Re: Review Request 59135: Refactored resource handling to use resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59135/ --- (Updated May 31, 2017, 11:58 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 59081: Updated master to use resource provider IDs in allocator calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59081/ --- (Updated May 31, 2017, 11:56 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 57818: Added unit tests to verify offers are suppressed based on registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57818/ --- (Updated May 31, 2017, 8 a.m.) Review request for mesos, James Peach, Vinod

Re: Review Request 57817: Offers not sent for suppressed roles as indicated in `SUBSCRIBE`.

> On May 23, 2017, 9:01 p.m., Vinod Kone wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Line 309 (original), 309 (patched) > > > > > > I don't quite follow why you need to have this variable here?

Re: Review Request 57817: Offers not sent for suppressed roles as indicated in `SUBSCRIBE`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57817/ --- (Updated May 31, 2017, 8 a.m.) Review request for mesos, James Peach, Vinod

Re: Review Request 59634: Updated 'config.py' in the new Mesos CLI to take settings as parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59634/#review176428 --- Ship it! The ReviewBot is acting strange, I have tested the

Re: Review Request 59673: Combined an 'undef' workaround for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59673/#review176424 --- Patch looks great! Reviews applied: [59651, 59659, 59660, 59661,