Re: Review Request 61015: Fixed cgroup device Entry.Selector major/minor number type.

> On July 20, 2017, 5:56 p.m., Benjamin Mahler wrote: > > I think you'll want to reference this page in your description: > > http://man7.org/linux/man-pages/man3/makedev.3.html > > > > The one you linked to seems to show MAJOR/MINOR returning `int` rather than > > `unsigned int`. Makes

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

> On July 20, 2017, 1:27 a.m., Qian Zhang wrote: > > include/mesos/v1/mesos.proto > > Lines 2815 (patched) > > > > > > Why do we need this? I see `Entry.op` is a required field rather than > > an optional field,

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

> On July 20, 2017, 6:43 p.m., Qian Zhang wrote: > > include/mesos/mesos.proto > > Line 2843 (original), 2922 (patched) > > > > > > Why is `value` an optional field? I think there have to a value for any > >

Review Request 61018: Minor fix to use the more idiomatic `send` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61018/ --- Review request for mesos and James Peach. Repository: mesos Description

Re: Review Request 60933: Added stats/control helpers for the Blkio cgroup subsystem.

> On July 20, 2017, 8:39 p.m., Qian Zhang wrote: > > src/linux/cgroups.cpp > > Lines 1986 (patched) > > > > > > So this means there can be an entry without operation? But I think the > > possible semantics are:

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

> On July 20, 2017, 4:27 p.m., Qian Zhang wrote: > > include/mesos/v1/mesos.proto > > Lines 2815 (patched) > > > > > > Why do we need this? I see `Entry.op` is a required field rather than > > an optional field,

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/#review181087 --- include/mesos/mesos.proto Line 2843 (original), 2922 (patched)

Re: Review Request 61015: Fixed cgroup device Entry.Selector major/minor number type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61015/#review181085 --- Ship it! I think you'll want to reference this page in your

Review Request 61015: Fixed cgroup device Entry.Selector major/minor number type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61015/ --- Review request for mesos, Benjamin Mahler, haosdent huang, Jie Yu, Kevin Klues,

Re: Review Request 60915: Enabled filtering of reservations in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60915/ --- (Updated July 21, 2017, 12:24 a.m.) Review request for mesos, Alexander

Re: Review Request 60933: Added stats/control helpers for the Blkio cgroup subsystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60933/ --- (Updated July 20, 2017, 4:58 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/ --- (Updated July 20, 2017, 4:57 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 60933: Added stats/control helpers for the Blkio cgroup subsystem.

> On July 20, 2017, 5:39 a.m., Qian Zhang wrote: > > src/linux/cgroups.cpp > > Lines 1986 (patched) > > > > > > So this means there can be an entry without operation? But I think the > > possible semantics are:

Re: Review Request 60913: Adds support for OpenSSL's ECDH handshake.

> On July 20, 2017, 3:51 p.m., Till Toenshoff wrote: > > 3rdparty/libprocess/src/openssl.cpp > > Lines 294 (patched) > > > > > > Judging from the NGINX sources, it appears that `OPENSSL_NO_ECDH` got > > introduced

Re: Review Request 60719: Add test infrastructure for src/python/lib/mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60719/ --- (Updated July 20, 2017, 6:45 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 61001: Windows: Fixed `CreateProcess` error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61001/#review181072 --- Ship it! Ship It! - Michael Park On July 20, 2017, 10:05

Review Request 61005: Added a test to check for copy assignment of `net::IP::Network`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61005/ --- Review request for mesos and Benjamin Hindman. Bugs: MESOS-7806

Review Request 61004: Added a copy assignment operator to `net::IP::Network`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61004/ --- Review request for mesos and Benjamin Hindman. Bugs: MESOS-7806

Re: Review Request 60719: Add test infrastructure for src/python/lib/mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60719/#review181058 --- src/python/lib/test.sh Lines 1 (patched)

Re: Review Request 60719: Add test infrastructure for src/python/lib/mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60719/#review181057 --- src/python/lib/setup.py Lines 21 (patched)

Re: Review Request 61001: Windows: Fixed `CreateProcess` error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61001/ --- (Updated July 20, 2017, 10:05 a.m.) Review request for mesos, Joseph Wu and Li

Review Request 61001: Windows: Fixed `CreateProcess` error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61001/ --- Review request for mesos and Joseph Wu. Repository: mesos Description

Re: Review Request 60996: Adds documentation for LIBPROCESS_SSL_ECDH_CURVE environment variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60996/#review181051 --- docs/ssl.md Lines 78 (patched)

Re: Review Request 60913: Adds support for OpenSSL's ECDH handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/#review181052 --- 3rdparty/libprocess/src/openssl.cpp Lines 294 (patched)

Re: Review Request 60931: Added test cases for framework streaming events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60931/#review181053 --- Patch looks great! Reviews applied: [60928, 60929, 60930, 60931]

Re: Review Request 60913: Adds support for OpenSSL's ECDH handshake.

> On July 20, 2017, 3:21 p.m., Till Toenshoff wrote: > > 3rdparty/libprocess/src/openssl.cpp > > Lines 124 (patched) > > > > > > ``` > > "NOTE: OpenSSL versions below 1.0.2 support only..." > > ``` > >

Re: Review Request 60913: Adds support for OpenSSL's ECDH handshake.

> On July 20, 2017, 3:21 p.m., Till Toenshoff wrote: > > 3rdparty/libprocess/src/openssl.cpp > > Lines 118 (patched) > > > > > > We are still missing the documentation in `docs/ssl.md`. Oops - drop this - Till

Re: Review Request 60913: Adds support for OpenSSL's ECDH handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/#review181045 --- 3rdparty/libprocess/src/openssl.cpp Lines 118 (patched)

Re: Review Request 60915: Enabled filtering of reservations in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60915/ --- (Updated July 20, 2017, 1:59 p.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 60915: Enabled filtering of reservations in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60915/ --- (Updated July 20, 2017, 1:58 p.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 60933: Added stats/control helpers for the Blkio cgroup subsystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60933/#review181029 --- src/linux/cgroups.hpp Lines 582-583 (patched)

Review Request 60996: Adds documentation for LIBPROCESS_SSL_ECDH_CURVE environment variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60996/ --- Review request for mesos, Jie Yu and Till Toenshoff. Bugs: MESOS-7792

Re: Review Request 60913: Adds support for OpenSSL's ECDH handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/ --- (Updated July 20, 2017, 2:37 p.m.) Review request for mesos, Jie Yu and Till

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/ --- (Updated July 20, 2017, 8:21 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 60913: Adds support for OpenSSL's ECDH handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/#review181030 --- 3rdparty/libprocess/src/openssl.cpp Lines 297 (patched)

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

> On July 20, 2017, 4:27 p.m., Qian Zhang wrote: > > include/mesos/v1/mesos.proto > > Lines 2815 (patched) > > > > > > Why do we need this? I see `Entry.op` is a required field rather than > > an optional field,

Re: Review Request 60933: Added stats/control helpers for the Blkio cgroup subsystem.

> On July 18, 2017, 7:27 a.m., Qian Zhang wrote: > > src/linux/cgroups.cpp > > Lines 1944 (patched) > > > > > > Should we replace `unsigned int` with `dev_t` like the code below? > >

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

> On July 20, 2017, 1:27 a.m., Qian Zhang wrote: > > include/mesos/v1/mesos.proto > > Lines 2815 (patched) > > > > > > Why do we need this? I see `Entry.op` is a required field rather than > > an optional field,

Re: Review Request 60933: Added stats/control helpers for the Blkio cgroup subsystem.

> On July 18, 2017, 10:27 p.m., Qian Zhang wrote: > > src/linux/cgroups.hpp > > Lines 427 (patched) > > > > > > Why do we need this? > > Gilbert Song wrote: > Yes, so that we can use an object as a `dev_t` key

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/#review181023 --- include/mesos/v1/mesos.proto Lines 2815 (patched)

Re: Review Request 58939: Filesystem isolation check for Mesos image provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58939/#review181016 --- src/slave/containerizer/mesos/containerizer.cpp Lines 1112-1126

Re: Review Request 60991: Changed Device::path to optional and introduced Device::Number.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60991/#review181020 --- Ship it! Ship It! - Qian Zhang On July 20, 2017, 8:16 a.m.,

Re: Review Request 60791: Add fetcher cache space usage metrics.

> On July 18, 2017, 2:16 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/fetcher.cpp > > Lines 272-275 (patched) > > > > > > Aside from styling/convention, would this require defer? > > James Peach wrote: >

Re: Review Request 60956: Refactored fetcher cache metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60956/#review181019 --- Ship it! Ship It! - Jiang Yan Xu On July 18, 2017, 8:04