Re: Review Request 65721: Windows: Specified byproducts of `sasl2` imported target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65721/#review197838 --- Patch looks great! Reviews applied: [65719, 65720, 65721]

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/ --- (Updated Feb. 21, 2018, 2:08 a.m.) Review request for mesos, Alexander

Re: Review Request 65419: Fixed quoting issues in docker executor command checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65419/ --- (Updated Feb. 21, 2018, 2:07 a.m.) Review request for mesos, Alexander

Re: Review Request 65574: Windows: Fixed handle inheritance in `create_process` wrapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65574/ --- (Updated Feb. 20, 2018, 5:19 p.m.) Review request for mesos, Akash Gupta, Jeff

Re: Review Request 65718: Allowed empty resource provider selector in `UriDiskProfileAdaptor`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65718/#review197836 --- Patch looks great! Reviews applied: [65718] Passed command:

Re: Review Request 65469: Windows: Updated `internal::process:createChildProcess`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65469/#review197833 --- Ship it! Ship It! - Akash Gupta On Feb. 20, 2018, 7:40

Re: Review Request 65394: Added separate structs for health check runtime and check types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/#review197831 --- Ship it! Ship It! - Joseph Wu On Feb. 16, 2018, 3:25 p.m.,

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/#review197830 --- Ship it! Ship It! - Joseph Wu On Feb. 12, 2018, 3:16 p.m.,

Re: Review Request 65574: Windows: Fixed handle inheritance in `create_process` wrapper.

> On Feb. 20, 2018, 4:01 p.m., Akash Gupta wrote: > > 3rdparty/stout/include/stout/os/windows/shell.hpp > > Lines 275 (patched) > > > > > > It seems like you can have a race condition here if you send the same > >

Re: Review Request 65574: Windows: Fixed handle inheritance in `create_process` wrapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65574/#review197823 --- 3rdparty/stout/include/stout/os/windows/shell.hpp Lines 275

Re: Review Request 65624: Added fetcher tests for `stderr` output.

> On Feb. 20, 2018, 11:43 a.m., Jeff Coffler wrote: > > src/tests/fetcher_tests.cpp > > Lines 132 (patched) > > > > > > These tests pretty much check the fetcher in a "stand-alone" > > environment. Could you add

Re: Review Request 65403: Windows: Disabled `O_CLOEXEC` semantic mapping on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65403/#review197825 --- Ship it! Ship It! - Akash Gupta On Feb. 20, 2018, 7:39

Re: Review Request 65467: Windows: Added `internal::windows::set_inherit(WindowsFD, bool)`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65467/#review197826 --- Ship it! Ship It! - Akash Gupta On Feb. 20, 2018, 7:39

Re: Review Request 65419: Fixed quoting issues in docker executor command checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65419/#review197820 --- Ship it! Ship It! - Joseph Wu On Feb. 16, 2018, 3:29 p.m.,

Re: Review Request 65396: Moved docker command check code inside health check library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65396/#review197818 --- Ship it! Ship It! - Joseph Wu On Feb. 8, 2018, 9:50 a.m.,

Re: Review Request 65395: Refactored health checks to cleanly separate each different check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65395/#review197817 --- Ship it! Ship It! - Joseph Wu On Feb. 8, 2018, 9:49 a.m.,

Re: Review Request 65581: Made all allocator tests allow for slave backoff.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65581/#review197816 --- Patch looks great! Reviews applied: [65717, 65581] Passed

Re: Review Request 65696: Allowed base64-decoding with whitespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65696/#review197813 --- PASS: Mesos patch 65696 was successfully built and tested.

Re: Review Request 65696: Allowed base64-decoding with whitespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65696/#review197809 --- Ship it! 3rdparty/stout/include/stout/base64.hpp Line 92

Re: Review Request 65717: Updated Cluster::Slave::shutdown to support a paused Clock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65717/#review197808 --- Ship it! Note to everybody that it is not required anymore to

Re: Review Request 65624: Added fetcher tests for `stderr` output.

> On Feb. 20, 2018, 7:43 p.m., Jeff Coffler wrote: > > src/tests/fetcher_tests.cpp > > Lines 132 (patched) > > > > > > These tests pretty much check the fetcher in a "stand-alone" > > environment. Could you add

Re: Review Request 65721: Windows: Specified byproducts of `sasl2` imported target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65721/#review197805 --- PASS: Mesos patch 65721 was successfully built and tested.

Re: Review Request 65346: Updated Web UI to show quota guarantee and limit for roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65346/#review197801 --- Patch looks great! Reviews applied: [65503, 65346] Passed

Re: Review Request 65624: Added fetcher tests for `stderr` output.

> On Feb. 20, 2018, 11:43 a.m., Jeff Coffler wrote: > > src/tests/fetcher_tests.cpp > > Lines 132 (patched) > > > > > > These tests pretty much check the fetcher in a "stand-alone" > > environment. Could you add

Re: Review Request 65624: Added fetcher tests for `stderr` output.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65624/#review197799 --- src/tests/fetcher_tests.cpp Lines 132 (patched)

Re: Review Request 65469: Windows: Updated `internal::process:createChildProcess`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65469/#review197798 --- Ship it! Ship It! - Jeff Coffler On Feb. 20, 2018, 7:40

Re: Review Request 65718: Allowed empty resource provider selector in `UriDiskProfileAdaptor`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65718/#review197797 --- PASS: Mesos patch 65718 was successfully built and tested.

Re: Review Request 65467: Windows: Added `internal::windows::set_inherit(WindowsFD, bool)`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65467/#review197796 --- Ship it! Ship It! - Jeff Coffler On Feb. 8, 2018, 10:35

Re: Review Request 65403: Windows: Disabled `O_CLOEXEC` semantic mapping on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65403/#review197795 --- Ship it! Ship It! - Jeff Coffler On Feb. 8, 2018, 10:36

Review Request 65721: Windows: Specified byproducts of `sasl2` imported target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65721/ --- Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and

Review Request 65719: Windows: Fixed CMake check of toolset for Ninja.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65719/ --- Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and

Review Request 65720: Windows: Fixed location of imported libraries for Ninja.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65720/ --- Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and

Review Request 65718: Allowed 0 resource provider in DiskProfileMapping's selector.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65718/ --- Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu. Bugs:

Re: Review Request 65581: Made all allocator tests allow for slave backoff.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65581/#review197789 --- PASS: Mesos patch 65581 was successfully built and tested.

Re: Review Request 65713: Handled hanging docker `stop`, `inspect` commands in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65713/#review197788 --- Patch looks great! Reviews applied: [65713] Passed command:

Review Request 65717: Updated Cluster::Slave::shutdown to support a paused Clock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65717/ --- Review request for mesos, Benjamin Bannier and Neil Conway. Repository: mesos

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

> On Feb. 20, 2018, 4:25 p.m., Benjamin Bannier wrote: > > configure.ac > > Lines 2458-2469 (patched) > > > > > > Let's kill this section and reword below error messages. > > > > Having a good error

Re: Review Request 65581: Made all allocator tests allow for slave backoff.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65581/#review197778 --- Fix it, then Ship it! Thanks for the cleanup!

Re: Review Request 65713: Handled hanging docker `stop`, `inspect` commands in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65713/#review197779 --- PASS: Mesos patch 65713 was successfully built and tested.

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

> On Feb. 20, 2018, 3:25 p.m., Benjamin Bannier wrote: > > configure.ac > > Lines 2458-2469 (patched) > > > > > > This seems unrelated (`--enable-python`?) and redundant since we > > explicitly check another

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

> On Feb. 20, 2018, 3:25 p.m., Benjamin Bannier wrote: > > configure.ac > > Lines 2458-2469 (patched) > > > > > > Let's kill this section and reword below error messages. > > > > Having a good error

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64211/#review197775 --- Patch looks great! Reviews applied: [65585, 65705, 64211]

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64211/#review197774 --- Fix it, then Ship it! Looking great. I left some comments on

Review Request 65713: Handled hanging docker `stop`, `inspect` commands in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65713/ --- Review request for mesos, Alexander Rukletsov, Gilbert Song, and Greg Mann.

Re: Review Request 65581: Made all allocator tests allow for slave backoff.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65581/#review197773 --- Patch looks great! Reviews applied: [65581] Passed command:

Re: Review Request 65581: Made all allocator tests allow for slave backoff.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65581/#review197772 --- PASS: Mesos patch 65581 was successfully built and tested.

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64211/#review197771 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64211/ --- (Updated Feb. 20, 2018, 11:09 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 64608: Reverted unintended edit to cpplint.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64608/#review197766 --- Ship it! Ship It! - Jan Schlicht On Feb. 20, 2018, 10:08

Re: Review Request 64608: Reverted unintended edit to cpplint.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64608/ --- (Updated Feb. 20, 2018, 10:08 a.m.) Review request for mesos, Gaojin CAO,

Re: Review Request 65712: Added a unit test for docker daemon hangs while pulling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65712/#review197764 --- FAIL: Some of the unit tests failed. Please check the relevant