Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67601/#review205412 --- PASS: Mesos patch 67601 was successfully built and tested.

Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

> On 六月 21, 2018, 6:52 p.m., Gilbert Song wrote: > > src/tests/slave_tests.cpp > > Lines 2413 (patched) > > > > > > Instead of to string.find(), I would prefer: > > > > ``` > >

Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67601/ --- (Updated 六月 27, 2018, 3:03 a.m.) Review request for mesos and Gilbert Song.

Re: Review Request 67730: Made Git normalize all line endings automatically.

> On June 25, 2018, 11:26 p.m., Till Toenshoff wrote: > > Given that the problem triggering change on the CI got reverted, can we > > cann this review? > > Andrew Schwartzmeyer wrote: > I think we'll still want this as it will enable us to avoid this problem > entirely in the future.

Re: Review Request 67751: WIP: Added missing files to CMake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67751/#review205408 --- Patch looks great! Reviews applied: [67751] Passed command:

Re: Review Request 67751: WIP: Added missing files to CMake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67751/#review205406 --- FAIL: Mesos binaries failed to build. Reviews applied:

Re: Review Request 67388: Moved libprocess POSIX and Windows implementations to separate folders.

> On June 4, 2018, 11:53 p.m., Joseph Wu wrote: > > General note on code organization: > > > > Since you are splitting the `io::internal::read/write` functions into Posix > > and Windows implementations, it would be helpful to organize the code like: > > ``` > > 3rdparty/libprocess/src/ > >

Re: Review Request 67751: WIP: Added missing files to CMake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67751/#review205403 --- src/Makefile.am Lines 2711-2718 (original), 2711-2718 (patched)

Review Request 67751: WIP: Added missing files to CMake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67751/ --- Review request for mesos, Benjamin Bannier, James Peach, and Joseph Wu.

Re: Review Request 67707: Added a support script to check for files missing in the cmake build.

> On June 25, 2018, 2:15 p.m., Andrew Schwartzmeyer wrote: > > support/check-cmake-missing-files.sh > > Lines 23 (patched) > > > > > > Issue found in testing: this isn't compatible with Ubuntu's "sh" (which > > is

Re: Review Request 67707: Added a support script to check for files missing in the cmake build.

> On June 25, 2018, 11:15 p.m., Andrew Schwartzmeyer wrote: > > support/check-cmake-missing-files.sh > > Lines 23 (patched) > > > > > > Issue found in testing: this isn't compatible with Ubuntu's "sh" (which > > is

Re: Review Request 67748: Added monitoring paragraph to high-availability.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67748/#review205395 --- Fix it, then Ship it! Thanks Till, great addition. Only one

Re: Review Request 67748: Added monitoring paragraph to high-availability.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67748/#review205394 --- PASS: Mesos patch 67748 was successfully built and tested.

Re: Review Request 67748: Added monitoring paragraph to high-availability.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67748/#review205393 --- Patch looks great! Reviews applied: [67748] Passed command:

Review Request 67748: Added monitoring paragraph to high-availability.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67748/ --- Review request for mesos, Gastón Kleiman and Joerg Schad. Repository: mesos

Re: Review Request 67742: Allowed SOME principal in ACLs for new destroy operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67742/#review205390 --- Patch looks great! Reviews applied: [67501, 67723, 67724, 67725,

Re: Review Request 67738: Renamed APR and SVN `find_package` implementations.

> On June 26, 2018, 2:21 a.m., Mesos Reviewbot Windows wrote: > > FAIL: Failed to apply the current review. > > > > Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 67738` > > > > All the build artifacts available at: > >

Re: Review Request 67738: Renamed APR and SVN `find_package` implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67738/#review205388 --- Ship it! Ship It! - Andrew Schwartzmeyer On June 26, 2018,

Re: Review Request 67730: Made Git normalize all line endings automatically.

> On June 25, 2018, 1:44 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Some of the unit tests failed. Please check the relevant logs. > > > > Reviews applied: `['67730']` > > > > Failed command: `Start-MesosCITesting` > > > > All the build artifacts available at: > >

Re: Review Request 67730: Made Git normalize all line endings automatically.

> On June 25, 2018, 4:26 p.m., Till Toenshoff wrote: > > Given that the problem triggering change on the CI got reverted, can we > > cann this review? I think we'll still want this as it will enable us to avoid this problem entirely in the future. Simply put, Mesos on Windows will fail to

Re: Review Request 67743: Made `gpu/nvidia` isolator works with `cgroups/all` isolation option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67743/#review205378 --- PASS: Mesos patch 67743 was successfully built and tested.

Re: Review Request 67742: Allowed SOME principal in ACLs for new destroy operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67742/#review205377 --- PASS: Mesos patch 67742 was successfully built and tested.

Re: Review Request 67737: Updated CNI slave recovery test.

> On June 26, 2018, 7:44 a.m., Qian Zhang wrote: > > Do we still need to kill the task and wait for `TASK_KILLED`? > > Qian Zhang wrote: > And is it possible for CNI DEL command gets called after > `reregisterExecutorMessage` is received? It's not possible. recover containerizer should

Re: Review Request 67743: Made `gpu/nvidia` isolator works with `cgroups/all` isolation option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67743/#review205375 --- Patch looks great! Reviews applied: [67743] Passed command:

Re: Review Request 67722: Fixed unproperly guarded future.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67722/#review205374 --- src/master/master.cpp Lines 9667-9672 (patched)

Re: Review Request 67722: Fixed unproperly guarded future.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67722/#review205373 --- A regression test would be nice, I guess that would involve

Re: Review Request 67737: Updated CNI slave recovery test.

> On June 26, 2018, 3:44 p.m., Qian Zhang wrote: > > Do we still need to kill the task and wait for `TASK_KILLED`? And is it possible for CNI DEL command gets called after `reregisterExecutorMessage` is received? - Qian --- This is an

Re: Review Request 67634: Removed PICOJSON_USE_INT64 from Mesos build system.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67634/#review205370 --- PASS: Mesos patch 67634 was successfully built and tested.

Re: Review Request 67742: Allowed SOME principal in ACLs for new destroy operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67742/ --- (Updated June 26, 2018, 4:13 p.m.) Review request for mesos, Chun-Hung Hsiao

Review Request 67743: Made `gpu/nvidia` isolator works with `cgroups/all` isolation option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67743/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-9027

Re: Review Request 67738: Renamed APR and SVN `find_package` implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67738/#review205365 --- Patch looks great! Reviews applied: [67738] Passed command:

Review Request 67742: Allowed SOME principal in ACLs for new destroy operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67742/ --- Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. Bugs: MESOS-7329

Re: Review Request 67634: Removed PICOJSON_USE_INT64 from Mesos build system.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67634/#review205362 --- Ship it! Ship It! - Benjamin Bannier On June 18, 2018, 5:53

Re: Review Request 67632: Always define PICOJSON_USE_INT64.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67632/ --- (Updated June 26, 2018, 11:48 a.m.) Review request for mesos. Changes

Re: Review Request 67739: Documented the container-specific cgroups mounts feature.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67739/#review205360 --- Patch looks great! Reviews applied: [67662, 67526, 67564, 67565,

Re: Review Request 67738: Renamed APR and SVN `find_package` implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67738/#review205357 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 67739: Documented the container-specific cgroups mounts feature.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67739/#review205356 --- PASS: Mesos patch 67739 was successfully built and tested.

Re: Review Request 67722: Fixed unproperly guarded future.

> On June 25, 2018, 8:14 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Some of the unit tests failed. Please check the relevant logs. > > > > Reviews applied: `['67722']` > > > > Failed command: `Start-MesosCITesting` > > > > All the build artifacts available at: > >

Re: Review Request 67737: Updated CNI slave recovery test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67737/#review205353 --- Patch looks great! Reviews applied: [67728, 67737] Passed

Re: Review Request 67737: Updated CNI slave recovery test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67737/#review205352 --- Ship it! Do we still need to kill the task and wait for

Re: Review Request 67606: Allow for unbundled libevent cmake builds.

> On June 18, 2018, 11:17 a.m., Benjamin Bannier wrote: > > 3rdparty/cmake/Findlibevent.cmake > > Lines 1 (patched) > > > > > > This file should be called `3rdparty/cmake/FindLIBEVENT.cmake` (package > > name all

Review Request 67738: Renamed APR and SVN `find_package` implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67738/ --- Review request for mesos, Andrew Schwartzmeyer and Till Toenshoff. Repository:

Review Request 67739: Documented the container-specific cgroups mounts feature.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67739/ --- Review request for mesos, Gilbert Song and Jason Lai. Bugs: MESOS-8327

Re: Review Request 67737: Updated CNI slave recovery test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67737/#review205350 --- PASS: Mesos patch 67737 was successfully built and tested.

Re: Review Request 67736: Removed ifdef from library path construction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67736/#review205348 --- Patch looks great! Reviews applied: [67736] Passed command:

Re: Review Request 67728: Fixed orphan container cleanup issue in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67728/#review205347 --- Ship it! Ship It! - Stéphane Cottin On June 25, 2018, 7