Re: Review Request 59746: Stopped accounting aborted container launches as failures.

m` a: `GLOG_v=1 sudo ./bin/mesos-agent.sh --master=:5050 --work_dir=./a --containerizers=docker` f: `./src/mesos-execute --master=:5050 --containerizer=docker --docker_image=fedora:25 --name=pull-test --command="sleep 1000"` Thanks, Alexander Rukletsov

Review Request 61811: Flattened continuation chains in containerizer for readability.

20160916 (Red Hat 6.2.1-2)` on Fedora 24 Thanks, Alexander Rukletsov

Re: Review Request 61801: Used _EXIT macro in `CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write` test.

), 490 (patched) <https://reviews.apache.org/r/61801/#comment259478> Why did you drop this comment? - Alexander Rukletsov On Aug. 21, 2017, 8:54 p.m., Andrei Budnik wrote: > > --- > This is an automatically generated e

Re: Review Request 61798: Added _EXIT as alternative to ABORT.

ue similar to `__Exit`? - Alexander Rukletsov On Aug. 21, 2017, 8:54 p.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 61799: Replaced ABORT with _EXIT in `childMain` to handle `os::execvpe` error.

), 195-197 (patched) <https://reviews.apache.org/r/61799/#comment259477> Is this what `clang-format` suggests? - Alexander Rukletsov On Aug. 21, 2017, 8:54 p.m., Andrei Budnik wrote: > > --- > This is an automatically g

Re: Review Request 61797: Added async-signal safe implementation of `write` function in stout.

) <https://reviews.apache.org/r/61797/#comment259472> `std::strlen`? 3rdparty/stout/include/stout/os/write.hpp Line 60 (original), 95-99 (patched) <https://reviews.apache.org/r/61797/#comment259471> Maybe `return (result == 0) ? Nothing() : ErrnoError(result);`? - Alexander Ru

Re: Review Request 61575: Added a test for verifying signal escalation on the default executor.

> On Aug. 22, 2017, 9:02 a.m., Alexander Rukletsov wrote: > > src/tests/kill_policy_test_helper.cpp > > Lines 61-64 (original), 62-68 (patched) > > <https://reviews.apache.org/r/61575/diff/4/?file=1798824#file1798824line62> > > > > Good idea che

Re: Review Request 61575: Added a test for verifying signal escalation on the default executor.

tate! Can we also checkpoint when we get `SIGTERM` and `SIGKILL`? Or this is tricky due to async signal safety? - Alexander Rukletsov On Aug. 21, 2017, 9:26 p.m., Anand Mazumdar wrote: > > --- > This is an automatically gener

Re: Review Request 61766: Made the output handling of TCP and HTTP checks consistent.

(patched) <https://reviews.apache.org/r/61766/#comment259375> Additionally `VLOG(1)` stderr? - Alexander Rukletsov On Aug. 19, 2017, 12:27 a.m., Gastón Kleiman wrote: > > --- > This is an automatically generated e

Re: Review Request 61766: Made the output handling of TCP and HTTP checks consistent.

> On Aug. 21, 2017, 1:34 p.m., Alexander Rukletsov wrote: > > src/checks/checker_process.cpp > > Lines 913-920 (original), 913-920 (patched) > > <https://reviews.apache.org/r/61766/diff/1/?file=1800336#file1800336line913> > > > > Let's print stder

Re: Review Request 61697: Included nested command checks output in the executor logs.

tps://reviews.apache.org/r/61697/#comment259368> I'd rather `VLOG(1)` here. It seems we do `LOG(INFO)` for important messages in this file (3 occurences). It is also consistent with other checks. - Alexander Rukletsov On Aug. 18, 2017, 11:20 p.m., Gastón Kl

Re: Review Request 61766: Made the output handling of TCP and HTTP checks consistent.

checker, but it is _consistent_ : ). - Alexander Rukletsov On Aug. 19, 2017, 12:27 a.m., Gastón Kleiman wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 61149: Added Future::condition.

update. - Alexander Rukletsov On July 27, 2017, 1:55 a.m., Benjamin Hindman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review183199 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 11, 2017

Re: Review Request 61495: Add documentation for possible task reasons.

//reviews.apache.org/r/61495/#comment259194> Ditto. include/mesos/mesos.proto Lines 2148 (patched) <https://reviews.apache.org/r/61495/#comment259191> task-state-reasons.md? - Alexander Rukletsov On Aug. 10, 2017, 2:01 p.m., Benno Evers wrote: > > --

Re: Review Request 61558: Move duplicate comment closer to implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61558/#review183157 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 10, 2017, 2

Re: Review Request 61697: Included nested command checks output in the executor logs.

; This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61697/ > --- > > (Updated Aug. 16, 2017, 8:17 p.m.) > > > Review request for mesos, Alexander Rukletsov and V

Re: Review Request 61697: Included nested command checks output in the executor logs.

src/checks/checker_process.cpp Lines 999-1009 (original), 1047-1057 (patched) <https://reviews.apache.org/r/61697/#comment259146> Ditto. Let's make the output consistent. - Alexander Rukletsov On Aug. 16, 2017, 8:17 p.m., Gastón Kleiman wrote: > > ---

Re: Review Request 61483: Added a test using CMD health checks + DefaultExecutor w/ Docker image.

) <https://reviews.apache.org/r/61483/#comment258959> This is how one can still leave traces in the codebase long after abandoning the project : ) - Alexander Rukletsov On Aug. 7, 2017, 10:47 p.m., Gastón Kleiman

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

://reviews.apache.org/r/61434/diff/3/ Changes: https://reviews.apache.org/r/61434/diff/2-3/ Testing --- https://gist.github.com/rukletsov/517a136cb6a0e8b909db30b36b13eded Additionally rendered in MacDown. Thanks, Alexander Rukletsov

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

s running as part of the executor? Nope, not for the command executor case when `rootfs` is specified. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61434/#review182495 ---

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

send an empty check status in this case? See > > `CommandExecutorCheckTest.CommandCheckTimeout`. > > Alexander Rukletsov wrote: > Correct. This is an artefact from health-checks-only times and should be > updated. Actually no : ). I meant "no result" as "

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

: https://reviews.apache.org/r/61434/#review182456 ------- On Aug. 11, 2017, 12:12 a.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

------- On Aug. 11, 2017, 12:12 a.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61434/ > --

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61434/#review182718 --- On Aug. 11, 2017, 12:12 a.m., Alexander Rukletsov wrote: > > ---

Review Request 61664: Libprocess: Added a timeout for send socket operation.

ND_TIMEOUT` environment variable. Diffs - 3rdparty/libprocess/src/process.cpp dcd9c6738816764aae066fe56cd5f468c98fc9bd Diff: https://reviews.apache.org/r/61664/diff/1/ Testing --- Manual testing with a rogue client. Thanks, Alexander Rukletsov

Re: Review Request 61584: Fixed a typo in a test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61584/#review182653 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 10, 2017, 9

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

: https://reviews.apache.org/r/61434/diff/2/ Changes: https://reviews.apache.org/r/61434/diff/1-2/ Testing --- https://gist.github.com/rukletsov/517a136cb6a0e8b909db30b36b13eded Additionally rendered in MacDown. Thanks, Alexander Rukletsov

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61434/#review182495 --- On Aug. 4, 2017, 6:14 p.m., Alexander Rukletsov wrote: > > ---

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61434/#review182456 --- On Aug. 4, 2017, 6:14 p.m., Alexander Rukletsov wrote: > > -

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

t; > Description > --- > > See summary. > > > Diffs > - > > docs/health-checks.md d0749347d1f9398004e56b03503d655b5fba75f4 > > > Diff: https://reviews.apache.org/r/61434/diff/1/ > > > Testing > --- > > https://gist.github.com/rukletsov/517a136cb6a0e8b909db30b36b13eded > > Additionally rendered in MacDown. > > > Thanks, > > Alexander Rukletsov > >

Re: Review Request 59146: Added a 'UNKNOWN' field to the Update.State enumeration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59146/#review182645 --- Ship it! Ship It! - Alexander Rukletsov On May 10, 2017, 3

Re: Review Request 61530: Enabled retries for `killTasks` in docker executor.

.org/r/61530/ > --- > > (Updated Aug. 10, 2017, 4:14 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Bugs: MESOS-6743 > https://issues.apache.org/jira/browse/MESOS-6743 > > > Repository: mesos > > > Description > --- >

Re: Review Request 61580: Extracted JNI code into a protected function for clarity.

://reviews.apache.org/r/61580/diff/1/ Testing --- make check Thanks, Alexander Rukletsov

Review Request 61580: Extracted JNI code into a protected function for clarity.

/r/61580/diff/1/ Testing --- make check Thanks, Alexander Rukletsov

Review Request 61579: Ensured JAVA HTTP adapter propagates a subscription error.

subscribed. Diffs - src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 1f58fbff4e8414e4d2ae4c8f69b637ee3315e411 Diff: https://reviews.apache.org/r/61579/diff/1/ Testing --- See https://reviews.apache.org/r/61580/ Thanks, Alexander Rukletsov

Re: Review Request 61111: Extracted strings into constants in example frameworks.

t_http_framework.cpp Lines 411-413 (original), 416-418 (patched) <https://reviews.apache.org/r/6/#comment258540> Can it fit two lines now? src/examples/test_http_framework.cpp Line 459 (original), 464 (patched) <https://reviews.apache.org/r/6/#

Re: Review Request 61137: Cleaned up style in example frameworks.

(patched) <https://reviews.apache.org/r/61137/#comment258559> Let's leave as is. src/examples/test_http_framework.cpp Lines 243-244 (original), 244-245 (patched) <https://reviews.apache.org/r/61137/#comment258560> Ditto. src/examples/test_http_framewor

Re: Review Request 61110: Added name flag to balloon and disk full frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61110/#review182592 --- Ship it! - Alexander Rukletsov On Aug. 1, 2017, 10:20 a.m

Re: Review Request 61435: Added logging in docker executor on `docker stop` failure.

(patched) <https://reviews.apache.org/r/61435/#comment258501> s/string &/ string& - Alexander Rukletsov On Aug. 4, 2017, 6:34 p.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 61530: Enabled retries for `killTasks` in docker executor.

> On Aug. 10, 2017, 12:07 p.m., Alexander Rukletsov wrote: > > src/docker/executor.cpp > > Lines 410-415 (original), 416-421 (patched) > > <https://reviews.apache.org/r/61530/diff/1/?file=1794166#file1794166line416> > > > > Let's add a comment ex

Re: Review Request 61530: Enabled retries for `killTasks` in docker executor.

rd kill requests from schedulers and will be adjusted accordingly. - Alexander Rukletsov On Aug. 9, 2017, 4:55 p.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

lly generated e-mail. To reply, visit: https://reviews.apache.org/r/61434/#review182234 ------- On Aug. 4, 2017, 6:14 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-

Review Request 61455: Tweaked checker logs to avoid repeated information.

rocess.cpp d92588e9e7235cf403b9b18cd7cd58e652a9f2a2 src/checks/health_checker.cpp 41fd94906407b59b1f27033324279d6a0ee2cf4b Diff: https://reviews.apache.org/r/61455/diff/1/ Testing --- make check Thanks, Alexander Rukletsov

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

://gist.github.com/rukletsov/517a136cb6a0e8b909db30b36b13eded Additionally rendered in MacDown. Thanks, Alexander Rukletsov

Review Request 61434: Updated health-checks.md to include description of generalized checks.

, Alexander Rukletsov

Re: Review Request 61112: Added executor_uris flag to long lived and balloon frameworks.

apache.org/r/61112/#comment257685> Add a TODO for deprecation: ``` // TODO(armand): Remove the `--executor_uri` flag after the // deprecation cycle, started in 1.4.0. ``` src/examples/balloon_framework.cpp Line 500 (original), 533-534 (patched) <https://reviews.apache.org

Review Request 61258: Graduated HTTP and TCP health checks.

Kapil Arya. Repository: mesos Description --- See summary. Diffs - CHANGELOG e091fec10296090123986ca44a86645e5867aa0d Diff: https://reviews.apache.org/r/61258/diff/1/ Testing --- None: not a functional change. Thanks, Alexander Rukletsov

Re: Review Request 61112: Added uris flag to balloon framework.

61112/#comment257557> Can we use `CopyFrom` from `RepeatedPtrField` here? - Alexander Rukletsov On July 31, 2017, 1:01 p.m., Armand Grillet wrote: > > --- > This is an au

Re: Review Request 61032: Fixed slaves_unreachable metric.

, Alexander Rukletsov

Re: Review Request 61033: Added missing metrics to tests.

: https://reviews.apache.org/r/61033/diff/1-2/ Testing (updated) --- See https://reviews.apache.org/r/61030/ Thanks, Alexander Rukletsov

Re: Review Request 61030: Added metrics for the number of active http and driver frameworks.

://reviews.apache.org/r/61030/diff/1-2/ Testing (updated) --- make check on Mac OS X and several Linux distros. Thanks, Alexander Rukletsov

Review Request 61218: Adjusted the style in metrics tests for consistency.

Description --- See summary. Diffs - src/tests/slave_tests.cpp a089cc47eae41cd6baeffd3f4a7ee7c7984aacbd Diff: https://reviews.apache.org/r/61218/diff/1/ Testing --- See https://reviews.apache.org/r/61030/ Thanks, Alexander Rukletsov

Re: Review Request 61029: Added metric for connected API subscribers in the master.

://reviews.apache.org/r/61029/diff/1-2/ Testing (updated) --- See https://reviews.apache.org/r/61030/ Thanks, Alexander Rukletsov

Re: Review Request 61028: Added metric for API subscribe calls in the master.

) --- See https://reviews.apache.org/r/61030/ Thanks, Alexander Rukletsov

Re: Review Request 61031: Removed almost identical master and slave metrics tests.

Diff: https://reviews.apache.org/r/61031/diff/2/ Testing (updated) --- make check on Mac OS X and several Linux distros. Thanks, Alexander Rukletsov

Re: Review Request 61031: Removed almost identical master and slave metrics tests.

a089cc47eae41cd6baeffd3f4a7ee7c7984aacbd Diff: https://reviews.apache.org/r/61031/diff/2/ Changes: https://reviews.apache.org/r/61031/diff/1-2/ Testing --- See https://reviews.apache.org/r/61034/ Thanks, Alexander Rukletsov

Re: Review Request 61034: Minor style cleanups in process.cpp.

, Alexander Rukletsov

Re: Review Request 61034: Minor style cleanups in process.cpp.

--- make check on Mac OS X and several Linux distros. Thanks, Alexander Rukletsov

Re: Review Request 61033: Added missing metrics to tests.

enerated e-mail. To reply, visit: https://reviews.apache.org/r/61033/#review181396 --- On July 21, 2017, 2:32 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 61032: Fixed slaves_unreachable metric.

Diff: https://reviews.apache.org/r/61032/diff/1/ Testing (updated) --- Augemnted an appropriate test with a check for this metric in https://reviews.apache.org/r/61033/ See https://reviews.apache.org/r/61034/ Thanks, Alexander Rukletsov

Re: Review Request 61032: Fixed slaves_unreachable metric.

646041d53642d6c25c3ea735bd9c87784374084f Diff: https://reviews.apache.org/r/61032/diff/1/ Testing --- See https://reviews.apache.org/r/61034/ Thanks, Alexander Rukletsov

Re: Review Request 61112: Added flag executor_extra_uris to balloon framework.

- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61112/ > ------- > > (Updated July 25, 2017, 3:48 p.m.) > > > Review request for mesos, Alexander Rukletsov and Alexander Rojas. > > > Bugs: ME

Re: Review Request 61032: Fixed slaves_unreachable metric.

--- On July 21, 2017, 2:32 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61032/ > --

Re: Review Request 61030: Added metrics for the number of active http and driver frameworks.

Diff: https://reviews.apache.org/r/61030/diff/1/ Testing --- See https://reviews.apache.org/r/61034/ Thanks, Alexander Rukletsov

Re: Review Request 61029: Added metric for connected API subscribers in the master.

: https://reviews.apache.org/r/61029/diff/1/ Testing --- See https://reviews.apache.org/r/61034/ Thanks, Alexander Rukletsov

Re: Review Request 61028: Added metric for API subscribe calls in the master.

://reviews.apache.org/r/61034/ Thanks, Alexander Rukletsov

Review Request 61028: Added a metric for master api subscribe calls number.

646041d53642d6c25c3ea735bd9c87784374084f src/tests/master_tests.cpp e3ccf8ce32d7314e6003798404a43b2f1e83a166 Diff: https://reviews.apache.org/r/61028/diff/1/ Testing --- See https://reviews.apache.org/r/61034/ Thanks, Alexander Rukletsov

Review Request 61032: Fixed slaves_unreachable metric.

Description --- See summary. Diffs - src/master/metrics.cpp 646041d53642d6c25c3ea735bd9c87784374084f Diff: https://reviews.apache.org/r/61032/diff/1/ Testing --- See https://reviews.apache.org/r/61034/ Thanks, Alexander Rukletsov

Review Request 61031: Removed almost identical master and slave metrics tests.

/61031/diff/1/ Testing --- See https://reviews.apache.org/r/61034/ Thanks, Alexander Rukletsov

Review Request 61033: Added missing metrics to tests.

/ Thanks, Alexander Rukletsov

Review Request 61030: Added metrics for the number of http and driver frameworks.

f701efec0a82d6ba72b2414f739fcd1cd7ee2491 src/master/metrics.cpp 646041d53642d6c25c3ea735bd9c87784374084f src/tests/master_tests.cpp e3ccf8ce32d7314e6003798404a43b2f1e83a166 Diff: https://reviews.apache.org/r/61030/diff/1/ Testing --- See https://reviews.apache.org/r/61034/ Thanks, Alexander Rukletsov

Review Request 61029: Added a metric for connected subscribers to master api.

f701efec0a82d6ba72b2414f739fcd1cd7ee2491 src/master/metrics.cpp 646041d53642d6c25c3ea735bd9c87784374084f src/tests/master_tests.cpp e3ccf8ce32d7314e6003798404a43b2f1e83a166 Diff: https://reviews.apache.org/r/61029/diff/1/ Testing --- See https://reviews.apache.org/r/61034/ Thanks, Alexander Rukletsov

Review Request 61034: Minor style cleanups in process.cpp.

Description --- See summary. Diffs - 3rdparty/libprocess/src/process.cpp b268cdad776a3ca2a87cbe60eb098bde2a70667c Diff: https://reviews.apache.org/r/61034/diff/1/ Testing --- make check on Mac OS X and several Linux distros. Thanks, Alexander Rukletsov

Re: Review Request 60525: Fixed the default filter used by the allocator.

but I see that you follow the pattern here. Maybe clean the whole file in a separate patch? src/master/allocator/mesos/hierarchical.cpp Lines 1056 (patched) <https://reviews.apache.org/r/60525/#comment255019> Missing blank line? - Alexander Rukletsov On July 8, 2017, 12:03 a.m., Ga

Re: Review Request 60653: Tightened namespace to fix a lookup error on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60653/#review179632 --- Ship it! Ship It! - Alexander Rukletsov On July 5, 2017, 1

Re: Review Request 60216: Fixed the commit message hook to allow `fixup` and `squash` commits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60216/#review179082 --- Ship it! Ship It! - Alexander Rukletsov On June 27, 2017, 8

Review Request 60476: Fixed parameters in JNI call for disconnected event.

, Alexander Rukletsov

Re: Review Request 60448: Forward declare CheckerProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60448/#review178958 --- Ship it! Ship It! - Alexander Rukletsov On June 26, 2017

Re: Review Request 59746: Separated discarded and failed cases for container launch.

e` will be in > > DISCARDED state? who discard the promise associated with this future? > > Alexander Rukletsov wrote: > Sure. Consider docker containerizer. > > 1) During container launch, docker containerizer calls `pull()`: > https://github.com/apach

Re: Review Request 60008: Fixed bug causing FUTURE_DISPATCH to react on irrelevant dispatch (WIP).

/process_tests.cpp Lines 208-209 (patched) <https://reviews.apache.org/r/60008/#comment253222> Additionally to (or actually instead of) `EXPECT` here, `AWAIT_READY(f);` would carry your intent better, I think. I would actually get rid of call expectations all together and simply focus on futu

Re: Review Request 60124: Added a name to ballon framework to distinguish between instances.

have just `executor.set_name("Framework > > Name Executor (C++)");` to set the name of the executor (e.g. in > > `long_lived_framework.cpp`). More generally, what is the reason to add a > > `name` flag for this test? > > Alexander Rukletsov wrote: > I

Re: Review Request 59746: Separated discarded and failed cases for container launch.

e` will be in > > DISCARDED state? who discard the promise associated with this future? > > Alexander Rukletsov wrote: > Sure. Consider docker containerizer. > > 1) During container launch, docker containerizer calls `pull()`: > https://github.com/apach

Re: Review Request 60124: Added a name to ballon framework to distinguish between instances.

. To reply, visit: https://reviews.apache.org/r/60124/#review178030 --- On June 15, 2017, 5:09 p.m., Alexander Rukletsov wrote: > > --- > This is an automatic

Re: Review Request 60123: Minor clean up of the balloon framework.

/ Testing --- make check Thanks, Alexander Rukletsov

Re: Review Request 60215: WIP: Logged offer ids of sent offers.

/master/master.cpp 287a5b71bc61949648ac0edff7668f217357a054 Diff: https://reviews.apache.org/r/60215/diff/1/ Testing --- make check Thanks, Alexander Rukletsov

Review Request 60215: Logged offer ids of sent offers.

/ Testing --- make check Thanks, Alexander Rukletsov

Review Request 60214: Logged when an offer is removed.

. Repository: mesos Description --- See summary. Diffs - src/master/master.cpp 287a5b71bc61949648ac0edff7668f217357a054 Diff: https://reviews.apache.org/r/60214/diff/1/ Testing --- make check Thanks, Alexander Rukletsov

Re: Review Request 60017: Resources: Adjusted the utilities to the new resource format [5/N].

(patched) <https://reviews.apache.org/r/60017/#comment252117> I'm confused what this function should do. Could you please update the comment in .hpp? It feels that reservations should be removed altogether since we are only interested in scalar values, no? - Alexander Rukletsov On Ju

Re: Review Request 60184: Resources: Adjusted the `operator<<` to the new resource format [4/N].

) <https://reviews.apache.org/r/60184/#comment252116> Why don't we check `role` is optional? Because we assume the "new" post-refined format is used? It would be great if we can somehow express that `type` and `role` are kinda required in the new format. - Alexander Ruklets

Re: Review Request 60182: Resources: Adjusted the predicates to the new resource format [2/N].

tps://reviews.apache.org/r/60182/#comment252118> `resource.role()` — does not it contradict the check above? - Alexander Rukletsov On June 19, 2017, 5:23 a.m., Michael Park wrote: > > --- > This is an automatically gener

Re: Review Request 60016: Resources: Adjusted the comparators to new resource format [3/N].

115> Ditto. This chunks appears for the third time in this file. Looks like a candidate for factoring out : ) - Alexander Rukletsov On June 13, 2017, 8:35 a.m., Michael Park wrote: > > --- > This is an automatically generated

Re: Review Request 60181: Resources: Updated the comment to mention the resource format [1/N].

lass must leave it in valid state? - Alexander Rukletsov On June 19, 2017, 5:17 a.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Review Request 60124: Added a name to ballon framework to distinguish between instances.

Description --- See summary. Diffs - src/examples/balloon_framework.cpp bfaae3796afb426459ef5cff3a37634a8242032e Diff: https://reviews.apache.org/r/60124/diff/1/ Testing --- make check Thanks, Alexander Rukletsov

Review Request 60123: Minor clean up of the ballon framework.

Description --- See summary. Diffs - src/examples/balloon_framework.cpp bfaae3796afb426459ef5cff3a37634a8242032e Diff: https://reviews.apache.org/r/60123/diff/1/ Testing --- make check Thanks, Alexander Rukletsov

Review Request 60122: Printed the reason why offer is declined in disk full framework.

Description --- See summary. Diffs - src/examples/disk_full_framework.cpp a73e6cf285b9a74492d476a624915235e079051f Diff: https://reviews.apache.org/r/60122/diff/1/ Testing --- make check Thanks, Alexander Rukletsov

Re: Review Request 59746: Separated discarded and failed cases for container launch.

-mail. To reply, visit: https://reviews.apache.org/r/59746/#review176789 --- On June 2, 2017, 1:10 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically gene

Review Request 60001: Removed superfluous log message in docker containerizer.

Description --- See summary. Diffs - src/slave/containerizer/docker.cpp 9f84109d7de22a39ace6e44e0c7d8d501bcb24de Diff: https://reviews.apache.org/r/60001/diff/1/ Testing --- make check Thanks, Alexander Rukletsov

Re: Review Request 59993: Removed need for patched http_parser version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59993/#review177598 --- Ship it! Ship It! - Alexander Rukletsov On June 12, 2017, 9

Re: Review Request 59874: Made `CheckerProcess` use a consistent description for log messages.

ail. To reply, visit: https://reviews.apache.org/r/59874/#review177435 --- On June 9, 2017, 3:43 a.m., Gastón Kleiman wrote: > > --- > This is an automatically generated e-mail. To re

<    2   3   4   5   6   7   8   9   10   11   >