)
<https://reviews.apache.org/r/56284/#comment235893>
How about making this a bit simpler:
"This test verifies that the store skips layers that are already pulled"
- Timothy Chen
On Feb. 3, 2017, 6:08 p.m., I
/local_puller.cpp (line 287)
<https://reviews.apache.org/r/56174/#comment235450>
LGTM, do we have tests for the local puller already? Will be good to have a
test around this.
- Timothy Chen
On Feb. 1, 2017, 3:17 p.m., Ilya Pronin
t;
> (Updated Jan. 4, 2017, 3:28 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> This method could mistake the host part for the scheme because of
> unsuitable use of find_
65)
<https://reviews.apache.org/r/50871/#comment231587>
Backend no longer needed to be recorded when it's auto selected?
src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 294)
<https://reviews.apache.org/r/50871/#comment231586>
Remove this
- Timothy Chen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53128/#review153982
---
Ship it!
Ship It!
- Timothy Chen
On Oct. 26, 2016, 5:18 a.m
/uuid_tests.cpp (line 63)
<https://reviews.apache.org/r/53047/#comment223103>
I can understand why you added this, but can you break this into a separate
commit?
- Timothy Chen
On Oct. 22, 2016, 5:54 p.m., Manuwela Kanade
ontainer ids passed in has to be valid
UUIDs.
- Timothy Chen
On Oct. 21, 2016, 9:34 a.m., Manuwela Kanade wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
though.
- Timothy Chen
On Oct. 10, 2016, 10:06 p.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
2395)
<https://reviews.apache.org/r/46264/#comment217484>
Thanks for fixing this!
- Timothy Chen
On April 25, 2016, 8:23 a.m., Qian Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50081/#review142469
---
Ship it!
Ship It!
- Timothy Chen
On July 15, 2016, 7:07 p.m
---
Added Timothy Chen to contributors.
Diffs
-
docs/contributors.yaml 7272b59bfff1c30958f705b849b75f5cc656321e
Diff: https://reviews.apache.org/r/49907/diff/
Testing
---
make
Thanks,
Timothy Chen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49554/#review140499
---
Ship it!
Ship It!
- Timothy Chen
On July 2, 2016, 3:12 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49553/#review140498
---
Ship it!
Ship It!
- Timothy Chen
On July 2, 2016, 3:12 p.m
think is to just keep it as is, or perhaps rename wrap
into something more obvious?
- Timothy Chen
On June 29, 2016, 9:03 a.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/#review139934
---
Can you add a test?
- Timothy Chen
On June 29, 2016, 4:45 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47661/#review137063
---
Ship it!
Ship It!
- Timothy Chen
On May 26, 2016, 8:55 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47336/#review133139
---
Ship it!
Ship It!
- Timothy Chen
On May 13, 2016, 7:09 a.m
line up at all
and it's quite confusing.
- Timothy Chen
On May 13, 2016, 6:57 a.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
(line 111)
<https://reviews.apache.org/r/46858/#comment195349>
Trying to understand the new logic here, when do we expect the agent to
mount workdir so that we can find it here?
- Timothy Chen
On May 2, 2016, 9:04 p.m., Jie Yu
> On April 25, 2016, 1:48 a.m., Timothy Chen wrote:
> > Can you rebase your patch? Thanks!
>
> Qian Zhang wrote:
> Sorry, I do not quite understand. I think the file I updated in this
> patch was not updated by others after I posted this patch, so there should be
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46564/#review130341
---
Can you rebase your patch? Thanks!
- Timothy Chen
On April 22
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46564/#review130258
---
Ship it!
Ship It!
- Timothy Chen
On April 22, 2016, 10:40
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46142/#review129544
---
Ship it!
Ship It!
- Timothy Chen
On April 19, 2016, 12:13
-
>
> (Updated April 17, 2016, 9:14 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rukletsov, Michael Park, and
> Timothy Chen.
>
>
> Bugs: MESOS-2533
> https://issues.apache.org/jira/browse/MESOS-2533
>
>
> Repository: mesos
org/r/36816/#comment192761>
What other schemes are we looking to support besides http or not? What is
the intention of making it a string instead of bool as before?
- Timothy Chen
On April 17, 2016, 9:14 a.m., haosdent huang
g/r/45594/#comment190360>
Can you probably elaborate a bit more why a docker config file
configuration is needed?
I know it's most likely for pulling private registry docker files, but not
quite obvious just by reading the help text.
- Timothy Chen
On April 5, 2016, 7:21 p.m., G
/docker_containerizer_tests.cpp (line 1381)
<https://reviews.apache.org/r/45455/#comment190261>
I think instead of just checking the previous inspect, can you make sure
that the container is actually stopped by using exists?
- Timothy Chen
On March 29, 2016, 10:44 p.m., Anand Mazumdar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45454/#review127119
---
Ship it!
Ship It!
- Timothy Chen
On March 29, 2016, 10:44
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45707/#review126954
---
Ship it!
Ship It!
- Timothy Chen
On April 4, 2016, 9:32 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45453/#review126499
---
Ship it!
Ship It!
- Timothy Chen
On March 29, 2016, 10:44
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45557/#review126480
---
Ship it!
Ship It!
- Timothy Chen
On March 31, 2016, 6:52
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4/#review126479
---
Ship it!
Ship It!
- Timothy Chen
On March 31, 2016, 6:51
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45556/#review126478
---
Ship it!
Ship It!
- Timothy Chen
On March 31, 2016, 6:51
g/r/45185/#comment188081>
I think we should also mention this only applies when image provisioner is
enabled and used.
- Timothy Chen
On March 23, 2016, 12:20 a.m., Gilbert Song wrote:
>
> ---
> This is an automatically g
207)
<https://reviews.apache.org/r/45186/#comment188079>
We should use the path::absolute method here
src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 219)
<https://reviews.apache.org/r/45186/#comment188080>
Also log when we cannot find it.
- Timothy Che
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45126/#review124681
---
Ship it!
Ship It!
- Timothy Chen
On March 21, 2016, 8:31
g/r/44660/#comment186488>
This should fit 80 char width?
- Timothy Chen
On March 15, 2016, 4:04 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
lt;< "'
src/slave/containerizer/mesos/isolators/disk/xfs.cpp (line 226)
<https://reviews.apache.org/r/44948/#comment186442>
ditto
- Timothy Chen
On March 17, 2016, 3:38 a.m., James Peach wrote:
>
> ---
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44944/#review123979
---
Ship it!
Ship It!
- Timothy Chen
On March 17, 2016, 1:50
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44708/#review123534
---
Ship it!
Ship It!
- Timothy Chen
On March 14, 2016, 5:50
t all consistent.
- Timothy Chen
On March 14, 2016, 5:51 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
eviews.apache.org/r/44531/#review123025
---
On March 8, 2016, 10:54 p.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To re
/registry_puller.cpp (line 173)
<https://reviews.apache.org/r/44672/#comment185153>
From the docker code base they're checking against docker.io, not
regsitry-1.docker.io, as I assume registry-1 is not a permanent name.
I would suggest we don't hard code that as well.
- Timothy Chen
On March 10
/
Testing
---
make check
Thanks,
Timothy Chen
Description
---
Fixed parsing network ip address with docker.
Diffs
-
src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373
Diff: https://reviews.apache.org/r/44531/diff/
Testing
---
make check
Thanks,
Timothy Chen
/
Testing
---
make check
Thanks,
Timothy Chen
> On March 7, 2016, 5:36 p.m., Timothy Chen wrote:
> > Are you still be able to work on this? We like to get this merged, so if
> > you can't or don't reply we will create a new patch based on this.
>
> Travis Hegner wrote:
> Hi Timothy,
>
> I'v
> On March 7, 2016, 5:36 p.m., Timothy Chen wrote:
> > Are you still be able to work on this? We like to get this merged, so if
> > you can't or don't reply we will create a new patch based on this.
>
> Travis Hegner wrote:
> Hi Timothy,
>
> I'v
> On March 7, 2016, 5:36 p.m., Timothy Chen wrote:
> > Are you still be able to work on this? We like to get this merged, so if
> > you can't or don't reply we will create a new patch based on this.
>
> Travis Hegner wrote:
> Hi Timothy,
>
> I'v
out a proper heading.
- Timothy Chen
On March 5, 2016, 2:20 a.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
, so if you
can't or don't reply we will create a new patch based on this.
- Timothy Chen
On Feb. 17, 2016, 10:52 p.m., Travis Hegner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://review
360/#comment183834>
Seems odd to add this in this commit?
- Timothy Chen
On March 4, 2016, 1:09 a.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44247/#review121564
---
Ship it!
Ship It!
- Timothy Chen
On March 2, 2016, 1:44 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44232/#review121554
---
Ship it!
Ship It!
- Timothy Chen
On March 1, 2016, 11:50
/docker_containerizer_tests.cpp (line 1841)
<https://reviews.apache.org/r/43963/#comment182103>
Can you add the mesos ticket in the comments as well? it has good
information about this.
- Timothy Chen
On Feb. 25, 2016, 2 a.m., Joseph Wu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42390/#review120516
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 20, 2016, 2:12 p.m
354)
<https://reviews.apache.org/r/43854/#comment181700>
Do we have tests to test the docker runtime isolator?
- Timothy Chen
On Feb. 22, 2016, 10:52 p.m., Gilbert Song wrote:
>
> ---
> This is an automatically g
/docker_containerizer_tests.cpp
8541a9a3d2f40cd6e78ff8fba474da214017937a
Diff: https://reviews.apache.org/r/43790/diff/
Testing
---
make check
Thanks,
Timothy Chen
8541a9a3d2f40cd6e78ff8fba474da214017937a
Diff: https://reviews.apache.org/r/43790/diff/
Testing
---
make check
Thanks,
Timothy Chen
ed1c9a551f03a37d572470e4c495f5df834198cc
src/tests/containerizer/docker_containerizer_tests.cpp
645bdcf095145097d8b8c65d592c787417883145
Diff: https://reviews.apache.org/r/43015/diff/
Testing
---
make check
Thanks,
Timothy Chen
ed1c9a551f03a37d572470e4c495f5df834198cc
src/tests/containerizer/docker_containerizer_tests.cpp
645bdcf095145097d8b8c65d592c787417883145
Diff: https://reviews.apache.org/r/43015/diff/
Testing
---
make check
Thanks,
Timothy Chen
sit:
https://reviews.apache.org/r/43015/#review119340
---
On Feb. 16, 2016, 3:33 a.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To re
so we're now more explicit.
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43015/#review119340
---
On Feb.
> > Alternatively, we can kill updatePersistentVolumes and inline it into
> > mountPersistentVolumes.
>
> Timothy Chen wrote:
> I think I simply forgot about it, let me add them.
Actually I'll just drop a TODO since we don't support update as you mentioned.
- Timothy
eviews.apache.org/r/43015/#review119340
---
On Feb. 16, 2016, 3:33 a.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To re
nerated e-mail. To reply, visit:
https://reviews.apache.org/r/43015/#review119340
-------
On Feb. 16, 2016, 3:33 a.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org
that restriction now?
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43015/#review119340
---
On Feb. 16, 20
test as it
requires docker network create. Did you test this manually and made sure it
worked?
Once you update the comments I can merge it.
- Timothy Chen
On Feb. 11, 2016, 1:51 p.m., Ezra Silvera wrote:
>
> ---
> This is an auto
/#comment180576>
Space between next if
src/docker/docker.cpp (line 530)
<https://reviews.apache.org/r/42516/#comment180577>
Fix the formatting, need to move one more char to the right.
- Timothy Chen
On Feb. 11, 2016, 1:51
g/r/43093/#comment180573>
This can fit in 80 char width line right?
src/docker/docker.cpp (line 314)
<https://reviews.apache.org/r/43093/#comment180572>
Also fix the formatting for the strings concat. Move
networkModeValue.get().value aligned with the "NetworkSettings&
ill be
more appropriate as well. Can you also log the image name? Same as above one.
src/docker/docker.cpp (line 398)
<https://reviews.apache.org/r/43293/#comment180569>
Actually shouldn't we take the latest value? What does Docker do when it
have duplicated env var?
- Timothy Chen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43592/#review119260
---
Ship it!
Ship It!
- Timothy Chen
On Feb. 16, 2016, 3:31 a.m
/docker_containerizer_tests.cpp
645bdcf095145097d8b8c65d592c787417883145
Diff: https://reviews.apache.org/r/43015/diff/
Testing
---
make check
Thanks,
Timothy Chen
with custom executors case.
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43015/#review119250
---
On Feb.
ed1c9a551f03a37d572470e4c495f5df834198cc
src/tests/containerizer/docker_containerizer_tests.cpp
645bdcf095145097d8b8c65d592c787417883145
Diff: https://reviews.apache.org/r/43015/diff/
Testing
---
make check
Thanks,
Timothy Chen
.apache.org/r/43015/#review119208
---
On Feb. 14, 2016, 8:38 a.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
ed1c9a551f03a37d572470e4c495f5df834198cc
src/tests/containerizer/docker_containerizer_tests.cpp
645bdcf095145097d8b8c65d592c787417883145
Diff: https://reviews.apache.org/r/43015/diff/
Testing
---
make check
Thanks,
Timothy Chen
ready checks for this.
src/slave/containerizer/mesos/containerizer.cpp (line 1616)
<https://reviews.apache.org/r/43569/#comment180491>
This as well
- Timothy Chen
On Feb. 15, 2016, 4:17 a.m., Guangya Liu wrote:
>
> ---
&g
> On Feb. 14, 2016, 8:42 a.m., Timothy Chen wrote:
> > src/tests/containerizer/docker_tests.cpp, lines 506-507
> > <https://reviews.apache.org/r/43293/diff/2/?file=1237051#file1237051line506>
> >
> > Is this even a valid docker inspect output?
>
)
<https://reviews.apache.org/r/43293/#comment180455>
Is this even a valid docker inspect output?
In what situations will we get this?
- Timothy Chen
On Feb. 7, 2016, 9:40 a.m., Guangya Liu wrote:
>
> ---
> This is a
at this moment. Can you
rebase?
- Timothy Chen
On Jan. 24, 2016, 3:45 a.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
ated e-mail. To reply, visit:
https://reviews.apache.org/r/43015/#review118285
-------
On Feb. 9, 2016, 2:32 a.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r
ed1c9a551f03a37d572470e4c495f5df834198cc
src/tests/containerizer/docker_containerizer_tests.cpp
645bdcf095145097d8b8c65d592c787417883145
Diff: https://reviews.apache.org/r/43015/diff/
Testing
---
make check
Thanks,
Timothy Chen
ove(
strings::remove(i.., "[", strings::PREFIX),
"]",
strings::SUFFIX);
src/tests/containerizer/docker_tests.cpp (line 139)
<https://reviews.apache.org/r/43032/#comment180325>
You need to EXPECT_SOME on the find first, other wise it's basically an
asser
> On Feb. 9, 2016, 2:17 a.m., Timothy Chen wrote:
> > src/docker/docker.cpp, line 525
> > <https://reviews.apache.org/r/42516/diff/7/?file=1229690#file1229690line525>
> >
> > Can you put a more elaborate message here?
> > i.e: "User network mo
2887cb4a01febbbf276026e584ffc466289e10c9
src/tests/containerizer/docker_containerizer_tests.cpp
645bdcf095145097d8b8c65d592c787417883145
Diff: https://reviews.apache.org/r/43015/diff/
Testing
---
make check
Thanks,
Timothy Chen
g/r/42516/#comment179576>
Can you put a more elaborate message here?
i.e: "User network mode requires Docker version higher than 1.9.0."
- Timothy Chen
On Feb. 4, 2016, 10:04 a.m., Ezra Silvera wrote:
>
> ---
>
/containerizer/docker_containerizer_tests.cpp
645bdcf095145097d8b8c65d592c787417883145
Diff: https://reviews.apache.org/r/43015/diff/
Testing
---
make check
Thanks,
Timothy Chen
tps://reviews.apache.org/r/43015/#comment178219>
It can't
- Timothy Chen
On Jan. 30, 2016, 5:25 p.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
----
On Jan. 30, 2016, 5:25 p.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43015/
> ---
/docker_containerizer_tests.cpp
645bdcf095145097d8b8c65d592c787417883145
Diff: https://reviews.apache.org/r/43015/diff/
Testing
---
make check
Thanks,
Timothy Chen
> On Jan. 29, 2016, 7:40 a.m., Timothy Chen wrote:
> > docs/fetcher.md, line 119
> > <https://reviews.apache.org/r/42914/diff/2/?file=1225096#file1225096line119>
> >
> > then files with a recognized extension
>
> Bernd Mathiske wrote:
> Soryy,
)
<https://reviews.apache.org/r/42914/#comment178012>
then files with a recognized extension
- Timothy Chen
On Jan. 28, 2016, 6:17 p.m., Bernd Mathiske wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42866/#review116856
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 27, 2016, 8:38 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42673/#review116737
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 22, 2016, 11:38
------
On Jan. 25, 2016, 7:18 p.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42674/
> ---
/slave.cpp 1f4c8368feb0ce19963577582ce745acfb21aa9f
src/tests/containerizer/filesystem_isolator_tests.cpp
496275a73601664b51155ef1373d8d46b9069613
Diff: https://reviews.apache.org/r/42278/diff/
Testing
---
make check
Thanks,
Timothy Chen
/docker.cpp (line 1370)
<https://reviews.apache.org/r/42288/#comment177131>
I don't think this comment means much here. Let's remove it
- Timothy Chen
On Jan. 21, 2016, 6:18 a.m., Andy Pang wrote:
>
> ---
> This is a
ilesystem
image is causing problems with the docker daemon in some configurations.
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42674/#review115992
------
---
make check
Thanks,
Timothy Chen
1 - 100 of 701 matches
Mail list logo
