8d679cd33b6ddf3a5c11bb8c458a97b8809473ac
Diff: https://reviews.apache.org/r/51352/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
8d679cd33b6ddf3a5c11bb8c458a97b8809473ac
src/internal/devolve.hpp 90681ebe454e12e39b214248f7457931e32295dc
src/internal/devolve.cpp efcc5d6050c5cb2fb79a4d676e4427f02e03eae9
Diff: https://reviews.apache.org/r/51351/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50629/#review144266
-------
On July 30, 2016, 6 p.m., Yong Tang wrote:
>
> ---
/setup.py.in`
so that protobuf 3.0 is allowed.
Diffs (updated)
-
src/python/interface/setup.py.in 037c2ec8e63f497f7029a847a7a0d7b72e6f36fa
Diff: https://reviews.apache.org/r/50629/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
/50630/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
-style.py 061cbe711bd9407b7341fa146f8c723eaa9fc438
Diff: https://reviews.apache.org/r/50629/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
.org/r/45011/#review143603
---
On March 18, 2016, 10:49 p.m., Yong Tang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&
26a637bec1193dd51437bd689c34fbe6d1935d89
3rdparty/stout/tests/numify_tests.cpp
444377df00922df12d4b3ed25b4cfe9071cff5c3
Diff: https://reviews.apache.org/r/50473/diff/
Testing
---
make check (Ubuntu 14.04)
NOTE: This RR is from #45011.
Thanks,
Yong Tang
88b7fc4c36ed3974ac6b103a29e1d975619f0c69
src/internal/devolve.hpp 4a6ae681d37b3405ee81c4a58388b8d501743ebf
src/internal/devolve.cpp cecb22e49614c6ee47489eead1d3161e033a53ef
Diff: https://reviews.apache.org/r/49240/diff/
Testing
---
make check on Ubuntu 14.04
Thanks,
Yong Tang
/http_docker_executor.cpp PRE-CREATION
src/internal/devolve.hpp 00842bb0de1dd587f2b47c79f17c0e7bd7f51189
src/internal/devolve.cpp 4233246c6838f85189f1b4c7e66d2bc0a3bf5408
Diff: https://reviews.apache.org/r/46617/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
://reviews.apache.org/r/46616/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
HTTP Docker Executor that uses the Executor Library.
Diffs
-
src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca
src/docker/http_docker_executor.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/46615/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
ly, visit:
https://reviews.apache.org/r/46364/#review129948
---
On April 22, 2016, 5:28 a.m., Yong Tang wrote:
>
> ---
> This is an automatically generated e-mail. To rep
://reviews.apache.org/r/46470/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
e4b63d41d883807ac39846799468b80e88c84e0b
Diff: https://reviews.apache.org/r/46364/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
pp and slave/http.cpp?
> >
> > make sure to grep through the code base to catch all other cases where
> > switch over an enum uses a "default".
>
> Yong Tang wrote:
> Thanks Vinod for the review. I just updated the listed files.
>
> Yong Tang wrote:
> Oh
e4b63d41d883807ac39846799468b80e88c84e0b
Diff: https://reviews.apache.org/r/46364/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
:
https://reviews.apache.org/r/45342/ (MESOS-5031)
Diffs
-
src/authorizer/local/authorizer.cpp c744a16041c2466d3839a37fbee2bf86887bf4e1
Diff: https://reviews.apache.org/r/46470/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
://reviews.apache.org/r/46364/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
pp and slave/http.cpp?
> >
> > make sure to grep through the code base to catch all other cases where
> > switch over an enum uses a "default".
>
> Yong Tang wrote:
> Thanks Vinod for the review. I just updated the listed files.
>
> Yong Tang wrote:
> Oh
pp and slave/http.cpp?
> >
> > make sure to grep through the code base to catch all other cases where
> > switch over an enum uses a "default".
>
> Yong Tang wrote:
> Thanks Vinod for the review. I just updated the listed files.
Oh I noticed there are 54 other in
is is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46364/#review129486
-------
On April 19, 2016, 3:19 p.m., Yong Tang wrote:
>
> ---
> This is a
/http.cpp 3908e33ed5b233387790276f6f5d884452087d2c
src/slave/validation.cpp ec1a4b6d9c55ab0c9894d5a49e290e15dee32c22
src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b
Diff: https://reviews.apache.org/r/46364/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
ceb489d43f35d24c8a7f5fbb0148529745ee357a
src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b
Diff: https://reviews.apache.org/r/46364/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
/docker.cpp 19cf424dfd5748ae66a7023840aa2b0652e8f2c0
Diff: https://reviews.apache.org/r/46246/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
cb50103775fb69e0696e0c389f2119f397a1c499
src/uri/fetchers/docker.cpp fbfc96c3f86cd2d2d585516f37be12834c2bb3a4
Diff: https://reviews.apache.org/r/45660/diff/
Testing
---
make check
Thanks,
Yong Tang
t; do for the `line_number` in order to keep this all in one place. We could
> > also use this opportunity to go for less incidental list formatting, e.g.,
> >
> > chars=', '.join([str(char + 1) for char in char_errors]) # gives
> > e.g., "Lin
a1bfc808eb1b1c372acb028019901f0ab3f15238
Diff: https://reviews.apache.org/r/45659/diff/
Testing
---
make check
Thanks,
Yong Tang
s-style.py 13616065ebe07ca401b385716d9b723f65bb2162
Diff: https://reviews.apache.org/r/45033/diff/
Testing
---
Tested manually and found two non ascii characters in docs/versioning.md (fixed
as part of this review request).
Thanks,
Yong Tang
t; do for the `line_number` in order to keep this all in one place. We could
> > also use this opportunity to go for less incidental list formatting, e.g.,
> >
> > chars=', '.join([str(char + 1) for char in char_errors]) # gives
> > e.g., "Lin
cb50103775fb69e0696e0c389f2119f397a1c499
src/uri/fetchers/docker.cpp fbfc96c3f86cd2d2d585516f37be12834c2bb3a4
Diff: https://reviews.apache.org/r/45660/diff/
Testing
---
make check
Thanks,
Yong Tang
33/#review126806
---
On April 4, 2016, 2:31 p.m., Yong Tang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.or
a1bfc808eb1b1c372acb028019901f0ab3f15238
Diff: https://reviews.apache.org/r/45659/diff/
Testing
---
make check
Thanks,
Yong Tang
tomatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45033/#review126806
---
On April 4, 2016, 2:31 p.m., Yong Tang wrote:
>
> ---
> This is an au
support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162
Diff: https://reviews.apache.org/r/45033/diff/
Testing
---
Tested manually and found two non ascii characters in docs/versioning.md (fixed
as part of this review request).
Thanks,
Yong Tang
> example?
> > Is there perhaps a separate patch that I don't have a pointer to?
>
> Yong Tang wrote:
> Thanks Michael. I was not sure when I did the change. Let me update the
> review request shortly.
>
> Michael Park wrote:
> Ah, ok. Thanks!
Hi Michael, I
f8e141bfc0023128f40ca8ecdae7a5609818c2b1
Diff: https://reviews.apache.org/r/45664/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
. AWAIT_FALSE alias to AWAIT_ASSERT_FALSE.
Diffs
-
3rdparty/libprocess/include/process/gtest.hpp
30d51d3704bd0ad82c6d21f1222d6158aaa61298
Diff: https://reviews.apache.org/r/45663/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
eviews.apache.org/r/45357/#review126760
---
On April 4, 2016, 1:56 a.m., Yong Tang wrote:
>
> ---
> This is an automatically generated e-mail. To re
/libprocess/include/process/gtest.hpp
30d51d3704bd0ad82c6d21f1222d6158aaa61298
Diff: https://reviews.apache.org/r/45357/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
nerated e-mail. To reply, visit:
https://reviews.apache.org/r/45356/#review126762
---
On March 26, 2016, 10:35 p.m., Yong Tang wrote:
>
> ---
> This is an automatically generated e-mail.
omatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45660/#review126755
---
On April 3, 2016, 11:47 p.m., Yong Tang wrote:
>
> ---
> This is an automatically generated e
0551ec334c6747507bf7bb068d27d67f3fdd6c83
src/uri/fetchers/curl.cpp cb50103775fb69e0696e0c389f2119f397a1c499
src/uri/fetchers/docker.cpp fbfc96c3f86cd2d2d585516f37be12834c2bb3a4
Diff: https://reviews.apache.org/r/45660/diff/
Testing
---
make check
Thanks,
Yong Tang
it message have been updated.
- Yong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45659/#review126756
---
On Apri
/libprocess/3rdparty/stout/include/stout/windows/format.hpp
a1bfc808eb1b1c372acb028019901f0ab3f15238
Diff: https://reviews.apache.org/r/45659/diff/
Testing
---
make check
Thanks,
Yong Tang
request).
Thanks,
Yong Tang
Note: This commit includes patches from Kevin Klues and haosdent.
> > ```
> >
> > Thanks!
Thanks Kevin. The commit message was updated.
- Yong
---
This is an automatically generated e-mail. To reply, visit:
https://re
s why this is a separate review request.
Diffs
-
3rdparty/libprocess/3rdparty/stout/include/stout/windows/format.hpp
a1bfc808eb1b1c372acb028019901f0ab3f15238
Diff: https://reviews.apache.org/r/45659/diff/
Testing
---
make check
Thanks,
Yong Tang
sting
---
make check
Thanks,
Yong Tang
about the actual matching going on here.
> >
> > This match doesn't exclude non-printable characters from the lower 127
> > ascii codes, nor does it exclude unicode characters (which I think we want
> > to exclude).
> >
> > I updated the pat
0551ec334c6747507bf7bb068d27d67f3fdd6c83
src/uri/fetchers/curl.cpp cb50103775fb69e0696e0c389f2119f397a1c499
src/uri/fetchers/docker.cpp fbfc96c3f86cd2d2d585516f37be12834c2bb3a4
Diff: https://reviews.apache.org/r/45660/diff/
Testing
---
make check
Thanks,
Yong Tang
/stout/include/stout/windows/format.hpp
a1bfc808eb1b1c372acb028019901f0ab3f15238
Diff: https://reviews.apache.org/r/45659/diff/
Testing
---
make check
Thanks,
Yong Tang
c1c6b
support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162
Diff: https://reviews.apache.org/r/45033/diff/
Testing
---
Tested manually and found two non ascii characters in docs/versioning.md (fixed
as part of this review request).
Thanks,
Yong Tang
it:
https://reviews.apache.org/r/45033/#review126749
---
On April 3, 2016, 7:46 p.m., Yong Tang wrote:
>
> ---
> This is an automatically generated e-mail. To rep
t; Note: This commit includes patches from Kevin Klues and haosdent.
>
>
> Diffs
> -
>
> docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b
> support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162
>
> Diff: https://reviews.apache.org/r/45033/diff/
>
>
> Testing
> ---
>
> Tested manually and found two non ascii characters in docs/versioning.md
> (fixed as part of this review request).
>
>
> Thanks,
>
> Yong Tang
>
>
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45033/#review126733
---
On April 3, 2016, 7:46 p.m., Yong Tang wrote:
>
>
support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162
Diff: https://reviews.apache.org/r/45033/diff/
Testing
---
Tested manually and found two non ascii characters in docs/versioning.md (fixed
as part of this review request).
Thanks,
Yong Tang
request and
merged the ascii check with mesos-style.py. I also skipped the .md check for
now as there is another ticket MESOS-5077 for that. Let me know if there are
other issues.
- Yong Tang
On April 2, 2016, 1:41 a.m., Yong Tang wrote
13616065ebe07ca401b385716d9b723f65bb2162
Diff: https://reviews.apache.org/r/45033/diff/
Testing
---
Tested manually and found two non ascii characters in docs/versioning.md (fixed
as part of this review request).
Thanks,
Yong Tang
not.
- Yong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45342/#review125768
---
On March 29, 2016, 2:04 a.m., Yong Tang wrote:
>
>
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
://reviews.apache.org/r/45357/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
(Ubuntu 14.04)
Thanks,
Yong Tang
eply, visit:
https://reviews.apache.org/r/45304/#review125476
---
On March 25, 2016, 9:25 p.m., Yong Tang wrote:
>
> ---
> This is an automatically generated e-mai
562b0acfd8555b9b773175f53defe0e7e2744641
src/slave/validation.cpp bc8d6717eac103c41f8cc8720e8482589210ea72
src/tests/mesos.hpp 23694885a69ddcbc7039de1186093ce0ad5eed22
Diff: https://reviews.apache.org/r/45304/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
view.
- Yong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45304/#review125465
---
On March 25, 2016, 9:19 p.m., Yong Tang wrote:
>
> -
2016, 9:19 p.m., Yong Tang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45304/
> ---
>
> (Updated March
check (Ubuntu 14.04)
Thanks,
Yong Tang
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45317/#review125464
---
On March 25, 2016, 8:55 p.m., Yong Tang wrote:
>
> -
/validation.cpp 701a5c4b279f319dde15bd8f2e97b5fd8608e578
src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57
Diff: https://reviews.apache.org/r/45317/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
944a493e0979c7ffbd99f3a67785a10425fd9040
src/authorizer/local/authorizer.cpp 0f0d9276337858984f0b19a82ffca74ee84dc650
Diff: https://reviews.apache.org/r/45342/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
MESOS-5014, I updated the review request
https://reviews.apache.org/r/45304/ as well.
Again, thanks a lot for the help.
- Yong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org
/test_http_executor.cpp 562b0acfd8555b9b773175f53defe0e7e2744641
src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57
Diff: https://reviews.apache.org/r/45304/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
aaef158e5784ce077ef60996ebbeb77b356b7c57
Diff: https://reviews.apache.org/r/45317/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45327/#review125378
---
On March 25, 2016, 2:28 a.m., Yong Tang wrote:
>
> -
of treating them as Event::ERROR.
(MESOS-5020)
Diffs (updated)
-
src/scheduler/scheduler.cpp 1f52a423c8c83c58d38ba6731ab2625136a271bb
Diff: https://reviews.apache.org/r/45327/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
1f52a423c8c83c58d38ba6731ab2625136a271bb
Diff: https://reviews.apache.org/r/45327/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
0049e1383f50574c3dad6a29b91811001694e82c
include/mesos/v1/scheduler/scheduler.proto
09fafedd06837f2307fedc6fa0e7b4460b21e5b0
src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57
Diff: https://reviews.apache.org/r/45317/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
The Mesos codebase follows the Google C++ Style Guide with some
> > notable differences, as described below.
> >
> > So basing off of Google and overriding the parts that don't match
> > accurately defines our style guide.
>
> Yong Tang wrote:
> Tha
.
- Yong Tang
On March 23, 2016, 2:46 p.m., Yong Tang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/non-ascii.py PRE-CREATION
Diff: https://reviews.apache.org/r/45033/diff/
Testing
---
Tested manually and found two non ascii characters in docs/versioning.md (fixed
as part of this review request).
Thanks,
Yong Tang
> On March 17, 2016, 4:09 p.m., Michael Park wrote:
> > The patch looks good to me. Would you like to send an announcement email to
> > the dev list about this upgrade? I can do it if you'd rather not.
>
> Yong Tang wrote:
> Hi Michael, Thanks a lot for the he
ch 17, 2016, 1:52 a.m., Yong Tang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44883/
> ---
>
> (Updated
/diff/
Testing
---
make check
Also tested with configure --disable-optimize manually.
Thanks,
Yong Tang
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/45033/#review124253
-------
On March 19, 2016, 6:26 p.m., Yong Tang wrote:
>
> ---
> This is an automatically generated e
---
Tested manually and found two non ascii characters in docs/versioning.md (fixed
as part of this review request).
Thanks,
Yong Tang
found two non ascii characters in docs/versioning.md (fixed
as part of this review request).
Thanks,
Yong Tang
n automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45033/#review124256
---
On March 18, 2016, 11:11 p.m., Yong Tang wrote:
>
> ---
> This is a
he dev
list shortly.
- Yong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44758/#review124038
---
On March 16, 2016, 1:37 a
-ascii.py PRE-CREATION
Diff: https://reviews.apache.org/r/45033/diff/
Testing
---
Tested manually and found two non ascii characters in docs/versioning.md (fixed
as part of this review request).
Thanks,
Yong Tang
ly generated e-mail. To reply, visit:
https://reviews.apache.org/r/45033/#review124253
---
On March 18, 2016, 2:48 p.m., Yong Tang wrote:
>
> ---
> This is an automatically generated e-mail. T
updated the review request. Let me know if there are other
issues.
- Yong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44758/#review124090
------
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44912/#review123882
---
Ship it!
Ship It!
- Yong Tang
On March 16, 2016, 3:47 p.m
/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
26a637bec1193dd51437bd689c34fbe6d1935d89
3rdparty/libprocess/3rdparty/stout/tests/numify_tests.cpp
444377df00922df12d4b3ed25b4cfe9071cff5c3
Diff: https://reviews.apache.org/r/45011/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
skipped if it is not
created.
Diffs (updated)
-
src/uri/fetcher.cpp 8645b66f6c64c76b6c02ef0b9827a7d694d5ba97
Diff: https://reviews.apache.org/r/44883/diff/
Testing
---
make check (Ubuntu 14.04)
Thanks,
Yong Tang
ex: '^<.*.h>'
> > Priority:1
> > - Regex: '^<.*.hpp>'
> > Priority:3
> > - Regex: '^<.*>'
> > Priority:2
> > - Regex: '.*&#
-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04
support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e
Diff: https://reviews.apache.org/r/44758/diff/
Testing
---
make check
Thanks,
Yong Tang
> On March 18, 2016, 7:03 p.m., haosdent huang wrote:
> > docs/versioning.md, line 85
> > <https://reviews.apache.org/r/45033/diff/1/?file=1305277#file1305277line85>
> >
> > Any reason we need change here?
>
> Yong Tang wrote:
> Hi hao
1 - 100 of 130 matches
Mail list logo
