Re: Review Request 42662: Added common command utils file.

/#comment177757> Add a case for `tar/untar` failure. - Klaus Ma On Jan. 28, 2016, 4:29 a.m., Jojy Varghese wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 42877: Cleaned up MesosSchedulerDriver shutdown in unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42877/#review116670 --- Ship it! Ship It! - Klaus Ma On Jan. 28, 2016, 6:56 a.m

Re: Review Request 42589: Added test case for allocator recover with Quota.

allocator recover with Quota? - Klaus Ma On Jan. 21, 2016, 2:27 p.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

nd the offer maybe wrong in about cases. - Klaus Ma On Jan. 23, 2016, 11:18 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Review Request 42946: Replace tabs with spaces in configure.ac.

tabs with spaces in configure.ac. Diffs - configure.ac cb39c7f Diff: https://reviews.apache.org/r/42946/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 42946: Replace tabs with spaces in configure.ac.

/diff/ Testing (updated) --- ../configure make Thanks, Klaus Ma

Re: Review Request 42936: Edited flag help strings for style.

tps://reviews.apache.org/r/42936/#comment177994> Move "By" to the next line. - Klaus Ma On Jan. 29, 2016, 12:30 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 42946: Replaced tabs with spaces in configure.ac.

configure.ac. Diffs - configure.ac cb39c7f Diff: https://reviews.apache.org/r/42946/diff/ Testing --- ../configure make Thanks, Klaus Ma

Re: Review Request 42908: Fixed a flaky test in quota tests.

apache.org/r/42908/#comment178000> ``` driver.stop(); driver.join(); ``` - Klaus Ma On Jan. 28, 2016, 8:20 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 42908: Fixed a flaky test in quota tests.

> On Jan. 29, 2016, 4:42 p.m., Klaus Ma wrote: > > src/tests/master_quota_tests.cpp, line 957 > > <https://reviews.apache.org/r/42908/diff/1/?file=1224834#file1224834line957> > > > > Just check the code on `setQuota-->rescindOffer`, why not let allocat

Re: Review Request 42908: Fixed a flaky test in quota tests.

> On Jan. 29, 2016, 4:42 p.m., Klaus Ma wrote: > > src/tests/master_quota_tests.cpp, line 957 > > <https://reviews.apache.org/r/42908/diff/1/?file=1224834#file1224834line957> > > > > Just check the code on `setQuota-->rescindOffer`, why not let allocat

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

y generated e-mail. To reply, visit: https://reviews.apache.org/r/40375/#review117796 ------- On Jan. 7, 2016, 11:43 a.m., Klaus Ma wrote: > > --- > This is an autom

Re: Review Request 43149: Add LIBPROCESS_THREAD_COUNT to override the thread pool size.

tps://reviews.apache.org/r/43149/#comment179067> Check negative and zero value. 3rdparty/libprocess/src/process.cpp (line 2205) <https://reviews.apache.org/r/43149/#comment179068> Add test for this patch. - Klaus Ma On Feb. 4, 2016, 8:40 a.m., James

Re: Review Request 43144: Added env var to set upper bound on number of worker threads.

tps://reviews.apache.org/r/43144/#comment179070> blank line before. 3rdparty/libprocess/src/process.cpp (line 2211) <https://reviews.apache.org/r/43144/#comment179069> Just `os::getenv("LIB...")` is OK. - Klaus Ma On Feb. 4, 2016, 4:57 a.m

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

> On Feb. 4, 2016, 9:38 p.m., Klaus Ma wrote: > > 3rdparty/libprocess/src/process.cpp, line 2211 > > <https://reviews.apache.org/r/43144/diff/1/?file=1231709#file1231709line2211> > > > > Just `os::getenv("LIB...")` is OK. > > Maged Mich

Re: Review Request 42946: Replaced tabs with spaces in configure.ac.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42946/#review118142 --- ping @Joris, any comments on this? - Klaus Ma On Jan. 29, 2016

Re: Review Request 43267: Returned "ServiceUnavailable" for slave's /state during recovery.

t; ``` driver.stop() driver.join() ``` - Klaus Ma On Feb. 6, 2016, 6:46 a.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 43159: Removed the duplicate "active" field in json schema of `Framework`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43159/#review118166 --- Ship it! Ship It! - Klaus Ma On Feb. 4, 2016, 7:11 a.m

Re: Review Request 43159: Removed the duplicate "active" field in json schema of `Framework`.

> On Feb. 7, 2016, 11:29 a.m., Klaus Ma wrote: > > Ship It! Add test case for duplicated keys in our output: did not prase json, just `std::count` should be OK. - Klaus --- This is an automatically generated e-mail. To rep

Re: Review Request 43328: Title for documentation webpages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43328/#review118237 --- Ship it! Ship It! - Klaus Ma On Feb. 8, 2016, 11:28 p.m

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43283/#review118332 --- Ship it! Ship It! - Klaus Ma On Feb. 7, 2016, 4:18 p.m

Re: Review Request 42589: Added test case for allocator recover with Quota.

On Jan. 21, 2016, 2:27 p.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42589/ > --

Re: Review Request 42516: Add support for user-defined networks.

g/r/42516/#comment180148> Also check whether `network_name()` is empty string `""`. please add unit test cases for this patches; refer to `bridge` test cases. - Klaus Ma On Feb. 10, 2016, 4:34 p.m., Ezra Silvera wrote: > > ---

Re: Review Request 42516: Add support for user-defined networks.

> On Feb. 11, 2016, 5:34 p.m., Klaus Ma wrote: > > src/docker/docker.cpp, line 529 > > <https://reviews.apache.org/r/42516/diff/9/?file=1239370#file1239370line529> > > > > Also check whether `network_name()` is empty string `""`. > > Ezra Sil

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master.

-- On Jan. 19, 2016, 10:55 a.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41305/ >

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master.

old slave did not report `slaveInfo`, right? - Klaus --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41305/#review115703 ------- On Feb. 12, 2016, 11:02 p.m., Klaus Ma wrote: > > --

Re: Review Request 42589: Added test case for allocator recover with Quota.

Diff: https://reviews.apache.org/r/42589/diff/ Testing --- make make check GTEST_FILTER="HierarchicalAllocatorTest.RecoverWithQuota" (CHECK() failed without fix) Thanks, Klaus Ma

Review Request 43561: Improve Ranges parsing to handle single values.

://reviews.apache.org/r/43561/diff/ Testing --- make make check GTEST_FILTER="ResourcesTest.*" Thanks, Klaus Ma

Re: Review Request 43561: Improve Ranges parsing to handle single values.

/tests/resources_tests.cpp 96864c3945729fe33be8b243b9c826fb12e90eff src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 Diff: https://reviews.apache.org/r/43561/diff/ Testing (updated) --- make make check GTEST_FILTER=~"*" ./src/mesos-test Thanks, Klaus Ma

Review Request 43580: Add indent to comments in protobuf_tests.cpp.

--- Add indent to comments in protobuf_tests.cpp. Diffs - 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 8dd9cfd3e7d1e3ab4ace87066a43a3094b776d82 Diff: https://reviews.apache.org/r/43580/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 43587: Replaced use of *_MESSAGE macros with *_PROTOBUF equivalents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43587/#review119254 --- Ship it! Ship It! - Klaus Ma On Feb. 16, 2016, 5:19 a.m

Re: Review Request 43588: Added allocator recovery tests in presence of quota.

or_tests.cpp (line 2513) <https://reviews.apache.org/r/43588/#comment180566> ditto - Klaus Ma On Feb. 16, 2016, 5:23 a.m., Joerg Schad wrote: > > --- > This i

Re: Review Request 43588: Added allocator recovery tests in presence of quota.

> On Feb. 16, 2016, 11:28 a.m., Klaus Ma wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2400 > > <https://reviews.apache.org/r/43588/diff/1/?file=1241757#file1241757line2400> > > > > Move to HierarchicalAllocatorTest. > > Joerg Schad

Re: Review Request 41950: Cleaned up hierarchical allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41950/#review119268 --- Ship it! Ship It! - Klaus Ma On Jan. 28, 2016, 9:12 p.m

Re: Review Request 43041: Update Master to send revocable resources in separate offers.

180599> ditto src/tests/oversubscription_tests.cpp (line 588) <https://reviews.apache.org/r/43041/#comment180595> `EXPECT_EQ(offer1.slaveID(), offer2.slaveID())` - Klaus Ma On Feb. 16, 2016, 4:52 p.m., Yongqiao Wang wrote: > > --- &

Re: Review Request 43488: Adding framework capability for TASK_KILLING.

org/r/43488/#comment180619> Do you mean framework can filter `killing` state? I thinke this's not necessary. - Klaus Ma On Feb. 16, 2016, 4:25 p.m., Abhishek Dasgupta wrote: > > --- > This is an automatically genera

Re: Review Request 43488: Adding framework capability for TASK_KILLING.

> On Feb. 16, 2016, 6:24 p.m., Klaus Ma wrote: > > include/mesos/mesos.proto, line 261 > > <https://reviews.apache.org/r/43488/diff/2/?file=1241816#file1241816line261> > > > > Do you mean framework can filter `killing` state? I thinke this's not >

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

value was big. Scalar is a general type, there maybe used with a big value, e.g. total size of distributed filesystem. src/tests/resources_tests.cpp (line 23) <https://reviews.apache.org/r/43635/#comment180731> Se

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

> On Feb. 17, 2016, 8:30 a.m., Klaus Ma wrote: > > src/common/values.cpp, line 67 > > <https://reviews.apache.org/r/43635/diff/1/?file=1252182#file1252182line67> > > > > Let's add check on overflow; it will be helpful if scalar value was > > big

Re: Review Request 41306: MESOS-1718: use command line executor to launch tasks.

66898e914c7b4ab83c4580be67530f355cfb05ca src/slave/slave.cpp f0be0d5bf4b853952caf06e2e262c2903d79ead3 Diff: https://reviews.apache.org/r/41306/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master.

/slave.cpp f0be0d5bf4b853952caf06e2e262c2903d79ead3 Diff: https://reviews.apache.org/r/41305/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 41308: MESOS-1718: Unit Test for moving getExecutorInfo from slave to master.

, Klaus Ma

Re: Review Request 41302: MESOS-1718: add slave's configuration into SlaveInfo.

proto e24d3e03a7dc7c6bfd07f34531cb593fe4925646 include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 Diff: https://reviews.apache.org/r/41302/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master.

gt; does not have this chain of patches? > > - Have you considered completely converting a `CommandInfo` to > > `ExecutorInfo`? If we do that, it may be possible to remove all the other > > places with special logic for command tasks. > > Klaus Ma wrote: > * It&#

Review Request 43754: WIP: Enhance allocator performance.

frameworks Added 100 frameworks in 1846us Added 1 slaves in 4.953045secs Updated 1 slaves in 4.338845secs [ OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/14 (10309 ms) ``` Thanks, Klaus Ma

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

> On Feb. 17, 2016, 8:30 a.m., Klaus Ma wrote: > > src/common/values.cpp, line 60 > > <https://reviews.apache.org/r/43635/diff/1/?file=1252182#file1252182line60> > > > > Regarnding `lround`, it maybe overcommit resources, if framework keep > > lau

Review Request 43802: Wrapped TASK_LOST with `` in authorization.md

--- Wrapped TASK_LOST with `` in authorization.md Diffs - docs/authorization.md bbb4f2a Diff: https://reviews.apache.org/r/43802/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 43802: Wrapped TASK_LOST with `` in authorization.md.

://reviews.apache.org/r/43802/diff/ Testing --- Thanks, Klaus Ma

Review Request 43807: Replaced with /Users/klaus in authentication.md.

Mac OS. Failed when using `~`: I0221 13:08:41.717308 4284416 credentials.hpp:35] Loading credentials for authentication from '~/credentials' Failed to read credentials file '~/credentials': Failed to open file '~/credentials': No such file or directory (see --credentials flag) Thanks, Klaus Ma

Re: Review Request 43807: Replaced with `~` in authentication.md.

27; Failed to read credentials file '~/credentials': Failed to open file '~/credentials': No such file or directory (see --credentials flag) Thanks, Klaus Ma

Re: Review Request 43718: Added fs::supported() function.

718/#comment181438> Would you add comments on expected format in `/proc/systems`? It'll help other contributors to understand magic number `1` & `2`. - Klaus Ma On Feb. 21, 2016, 3:46 p.m., Shuai Lin wrote: > > ---

Re: Review Request 37168: Add an example framework using dynamic reservation.

ttps://reviews.apache.org/r/37168/diff/ Testing --- make make check Thanks, Klaus Ma

Re: Review Request 37168: Added example for dynamic reservation features.

://reviews.apache.org/r/37168/diff/ Testing --- make make check Thanks, Klaus Ma

Re: Review Request 37531: Fix master CHECK failure if a framework uses duplicated task id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37531/#review120073 --- ping @jieyu/vinodkone. - Klaus Ma On Jan. 13, 2016, 10:06 p.m

Re: Review Request 43807: Replaced with `~` in authentication.md.

ly, visit: https://reviews.apache.org/r/43807/#review120099 --- On Feb. 21, 2016, 2:42 p.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 39939: Make docker_socket option support different protocols.

g/r/39939/#comment181473> I think we need to handle feature interaction with `docker_mesos_image`. Currently, we mount unix socket into container; but it'll failed when using TCP socket. - Klaus Ma On Feb. 22, 2016, 11:35 a.m., haosdent

Re: Review Request 43821: Updated the HA framweork guide for TASK_KILLING.

aviour if executor generate `TASK_KILLING` without framework's capability: ignore, crash or undefined? - Klaus Ma On Feb. 22, 2016, 1:19 p.m., Ben Mahler wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Re: Review Request 43838: Added note about not implemented requestResources call.

tps://reviews.apache.org/r/43838/#comment181681> It seems scheduler did not send `ResourceRequestMessage` to the master; so other allocator also can not handle it. I'd like to say Master ignore this call. - Klaus Ma On Feb. 23, 2016, 12:54 a.m., Joerg

Review Request 43864: Fix typo of roles doc.

--- Fix typo of roles doc. Diffs - docs/endpoints/master/roles.json.md d67779c246cceae2209f2611f32ada4493ae6f83 docs/endpoints/master/roles.md 976a9b7891a17652289126ec7e7ee73cea0c2e35 Diff: https://reviews.apache.org/r/43864/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 43816: Updated `/frameworks` master endpoint to use jsonify.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43816/#review120272 --- Ship it! Ship It! - Klaus Ma On Feb. 22, 2016, 3:11 p.m

Re: Review Request 43822: Updated `/slaves` master endpoint to use jsonify.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43822/#review120291 --- Ship it! Ship It! - Klaus Ma On Feb. 22, 2016, 3:12 p.m

Re: Review Request 43823: Updated `/tasks` master endpoint to use jsonify.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43823/#review120292 --- Ship it! Ship It! - Klaus Ma On Feb. 22, 2016, 3:13 p.m

Re: Review Request 43817: Removed no-longer-used model functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43817/#review120293 --- Ship it! Ship It! - Klaus Ma On Feb. 22, 2016, 3:13 p.m

Re: Review Request 43848: Used `size_t` to track number of frameworks per role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43848/#review120294 --- Ship it! Ship It! - Klaus Ma On Feb. 23, 2016, 3:54 a.m

Re: Review Request 42390: Fixed fetching uris when slave is running inside a container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42390/#review120296 --- Ship it! Ship It! - Klaus Ma On Jan. 20, 2016, 10:12 p.m

Re: Review Request 43868: Add a getter for master::Flags.

o, please clear it up. Can you also show which part of code will use this function? - Klaus Ma On Feb. 23, 2016, 1:23 p.m., Jay Guo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 69885: Sped up some resource benchmark test instantiations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69885/#review212539 --- Ship it! Ship It! - Klaus Ma On Feb. 4, 2019, 8:29 p.m

Re: Review Request 69885: Sped up some resource benchmark test instantiations.

> On Feb. 5, 2019, 12:31 a.m., Klaus Ma wrote: > > Ship It! LGTM overall, but I don-t have enough experience right now to review the detail, please wait for BenM's comments :) - Klaus --- This is an automatically genera

Re: Review Request 43561: Improve Ranges parsing to handle single values.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review136543 --- On March 22, 2016, 9:22 p.m., Klaus Ma wrote: > > ---

Re: Review Request 43561: Improve Ranges parsing to handle single values.

handled in r/45813. - Klaus --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review136543 --- On March 22, 2016, 9:22 p.m., Klaus Ma wrote: &

Re: Review Request 48579: Reset "dirty" to false in sort().

{{allocated}} & {{unallocated}}; and only return clients list in {{sort()}} (the client was sorted when inserted in {{allocated}} & {{unallocated}}). - Klaus Ma On June 11, 2016, 11:42 a.m., Guangya Liu wrote: > > --- &

Re: Review Request 46425: Add helper function to simplify tokenize handling.

162bdfb6c4f5a6b108761ebccd9b77e672f6dd87 3rdparty/stout/tests/strings_tests.cpp b54a9dbf162403310b8bba687442e184a473f5a6 Diff: https://reviews.apache.org/r/46425/diff/ Testing --- make && make check Thanks, Klaus Ma

Review Request 48581: Removed duplicated code in 'strings::tokenize()'.

--- Removed duplicated code in 'strings::tokenize()'. Diffs - 3rdparty/stout/include/stout/strings.hpp 162bdfb6c4f5a6b108761ebccd9b77e672f6dd87 Diff: https://reviews.apache.org/r/48581/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 48581: Removed duplicated code in 'strings::tokenize()'.

ake check Thanks, Klaus Ma

Re: Review Request 43561: Improve Ranges parsing to handle single values.

587cb68551d438621e215953e89818b623b7f71b src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 Diff: https://reviews.apache.org/r/43561/diff/ Testing --- make make check GTEST_FILTER=~"*" ./src/mesos-test Thanks, Klaus Ma

Re: Review Request 43561: Improve Ranges parsing to handle single values.

- Klaus --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review136543 --- On June 11, 2016, 10:29 p.m., Klaus Ma wrote:

Re: Review Request 43561: Improve Ranges parsing to handle single values.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review136543 --- On June 11, 2016, 10:29 p.m., Klaus Ma wrote: > >

Re: Review Request 46375: Updated MACHINE_UP_HELP's comments.

iew129614 --- On April 19, 2016, 3:51 p.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 43561: Improve Ranges parsing to handle single values.

having 3 > > levels of `tokenize`? > > Is this code in any critical paths? > > Klaus Ma wrote: > This function is only uesd when parsing resources from string; it only > impacts the duration of `make check`. I'll try it and let you known the > impact

Re: Review Request 48593: Refactor Ranges Subtraction.

tps://reviews.apache.org/r/48593/#comment202389> Any data on performance improvement? - Klaus Ma On June 12, 2016, 4:03 p.m., Yanyan Hu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 48593: Refactor Ranges Subtraction.

> On June 13, 2016, 11:40 a.m., Klaus Ma wrote: > > src/common/values.cpp, lines 411-419 > > <https://reviews.apache.org/r/48593/diff/2/?file=1415977#file1415977line411> > > > > Any data on performance improvement? > > Yanyan Hu wrote: >

Re: Review Request 48593: Refactor Ranges Subtraction.

> On June 13, 2016, 11:40 a.m., Klaus Ma wrote: > > src/common/values.cpp, lines 411-419 > > <https://reviews.apache.org/r/48593/diff/2/?file=1415977#file1415977line411> > > > > Any data on performance improvement? > > Yanyan Hu wrote: >

Re: Review Request 48914: Added GPU_RESOURCES capability to FrameworkInfo.

> On June 19, 2016, 10:18 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1277-1279 > > > > > > This logic seems also allow agents without gpu resources offered to the > > framework

Review Request 49140: Added startsWith/endsWith to support char.

Thanks, Klaus Ma

Review Request 49223: WIP: enhance value parsing.

: enhance value parsing. Diffs - src/common/values.cpp 587cb68551d438621e215953e89818b623b7f71b Diff: https://reviews.apache.org/r/49223/diff/ Testing --- make Thanks, Klaus Ma

Re: Review Request 49140: Added startsWith/endsWith to support char.

s.cpp 18bcb0e499a9d2d84113b5b9e609e5e40913ebcc support/docker_build.sh 8ae1aadbc12b12e44984d34ccfbcb8a97bf05bcf Diff: https://reviews.apache.org/r/49140/diff/ Testing --- make Thanks, Klaus Ma

Re: Review Request 49140: Added startsWith/endsWith to support char.

: https://reviews.apache.org/r/49140/diff/ Testing --- make Thanks, Klaus Ma

Re: Review Request 49140: Added startsWith/endsWith to support char.

rsion of `startsWith/endsWith` to improve the performance. - Klaus Ma On June 26, 2016, 5:46 p.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 49223: Enhanced Value parsing.

Diff: https://reviews.apache.org/r/49223/diff/ Testing (updated) --- make && make check Thanks, Klaus Ma

Re: Review Request 49223: Enhanced Value parsing.

mp; make check Thanks, Klaus Ma

Review Request 49246: Enhanced startsWith/endsWith's performance.

make && make check Thanks, Klaus Ma

Re: Review Request 49246: Enhanced startsWith/endsWith's performance.

Diff: https://reviews.apache.org/r/49246/diff/ Testing --- make && make check Thanks, Klaus Ma

Re: Review Request 49246: Enhanced startsWith/endsWith's performance.

imilar cases with `startsWith`. - Klaus --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49246/#review139536 ------- On

Re: Review Request 49223: Enhanced Value parsing.

://reviews.apache.org/r/49223/diff/ Testing --- make && make check Thanks, Klaus Ma

Review Request 49381: WIP: Benchmark for Resources class.

, Klaus Ma

Re: Review Request 48581: Removed duplicated code in 'strings::tokenize()'.

trings.hpp 162bdfb6c4f5a6b108761ebccd9b77e672f6dd87 Diff: https://reviews.apache.org/r/48581/diff/ Testing --- make && make check Thanks, Klaus Ma

Re: Review Request 49352: Added a flag parser for hashset.

tps://reviews.apache.org/r/49352/#comment205342> Call `insert` directly should be fine. `set` will help to avoid duplicated item. - Klaus Ma On June 29, 2016, 8:12 p.m., Guangya Liu wrote: > > --- > This is an automatically generated e

Re: Review Request 48895: Added allocator_fairness_excluded_resource_names flag to master.

g/r/48895/#comment205344> s/client/framework Mesos user does not know client. - Klaus Ma On June 29, 2016, 8:14 p.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 48904: Updated allocator initialize() to include fairnessExcludeResourceNames.

g/r/48904/#comment205346> Please check whether the resource name is valid. We only support cpus, mem, disk, ports, gpus for now. - Klaus Ma On June 29, 2016, 8:16 p.m., Guangya Liu wrote: > > --- > This is an automatica

Re: Review Request 49352: Added a flag parser for hashset.

> On June 30, 2016, 12:59 a.m., Klaus Ma wrote: > > src/common/parse.hpp, lines 150-152 > > <https://reviews.apache.org/r/49352/diff/1/?file=1432428#file1432428line150> > > > > Call `insert` directly should be fine. `set` will help to avoid > >

<    1   2   3   4   5   6   7   >