[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r913192462 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -208,12 +210,46 @@ case class Abs(child: Expression, failOnError:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r893017456 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -734,11 +920,35 @@ case class Pmod( override def nullable:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r893003521 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -953,15 +952,16 @@ case class Pmod( // when we reach here,

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r893003240 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -953,15 +952,16 @@ case class Pmod( // when we reach here,

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r890146130 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/decimalExpressions.scala: ## @@ -232,3 +216,33 @@ case class CheckOverflowInSum( override

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r886782526 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -490,12 +622,27 @@ trait DivModLike extends BinaryArithmetic {

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r886762319 ## sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala: ## @@ -3055,21 +3055,6 @@ class DataFrameSuite extends QueryTest assert(df2.isLocal) }

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r886761154 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/decimalExpressions.scala: ## @@ -232,3 +216,33 @@ case class CheckOverflowInSum( override

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r886760416 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/decimalExpressions.scala: ## @@ -232,3 +216,33 @@ case class CheckOverflowInSum( override

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r886759507 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/decimalExpressions.scala: ## @@ -232,3 +216,33 @@ case class CheckOverflowInSum( override

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r886758935 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -778,16 +1002,24 @@ case class Pmod( val javaType =

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r886757508 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -490,12 +622,27 @@ trait DivModLike extends BinaryArithmetic {

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885787936 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -244,8 +314,7 @@ abstract class BinaryArithmetic extends

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885787249 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/decimalExpressions.scala: ## @@ -232,3 +216,36 @@ case class CheckOverflowInSum( override

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885784544 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -778,16 +1002,24 @@ case class Pmod( val javaType =

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885782952 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -778,16 +1002,24 @@ case class Pmod( val javaType =

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885779230 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -490,12 +622,27 @@ trait DivModLike extends BinaryArithmetic {

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885776567 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -208,6 +210,79 @@ case class Abs(child: Expression, failOnError:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885774715 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -208,6 +210,79 @@ case class Abs(child: Expression, failOnError:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885616172 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -490,10 +621,26 @@ trait DivModLike extends BinaryArithmetic {

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885426684 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -208,6 +210,78 @@ case class Abs(child: Expression, failOnError:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885426207 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -208,6 +210,76 @@ case class Abs(child: Expression, failOnError:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885424345 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -778,16 +999,26 @@ case class Pmod( val javaType =

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885417861 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -490,10 +621,26 @@ trait DivModLike extends BinaryArithmetic {

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885416511 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -490,10 +621,26 @@ trait DivModLike extends BinaryArithmetic {

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885415814 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -490,10 +621,26 @@ trait DivModLike extends BinaryArithmetic {

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885412953 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -208,6 +210,78 @@ case class Abs(child: Expression, failOnError:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885232931 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/decimalExpressions.scala: ## @@ -232,3 +216,33 @@ case class CheckOverflowInSum( override

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885232378 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -575,7 +707,31 @@ case class Divide( override def symbol: String =

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885231906 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -373,11 +457,24 @@ case class Subtract( override def

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885231224 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -373,11 +457,24 @@ case class Subtract( override def

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885230648 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -521,6 +651,7 @@ trait DivModLike extends BinaryArithmetic {

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885229342 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -490,10 +599,31 @@ trait DivModLike extends BinaryArithmetic {

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885228623 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -208,6 +210,76 @@ case class Abs(child: Expression, failOnError:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885227041 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -208,6 +210,76 @@ case class Abs(child: Expression, failOnError:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885226749 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -208,6 +210,76 @@ case class Abs(child: Expression, failOnError:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885221860 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -208,6 +210,76 @@ case class Abs(child: Expression, failOnError:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885220637 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -422,9 +520,20 @@ case class Multiply( override def symbol: String

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885220389 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -373,11 +457,24 @@ case class Subtract( override def

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885220020 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -373,11 +457,24 @@ case class Subtract( override def

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885219727 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -323,11 +390,27 @@ case class Add( override def decimalMethod:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885218585 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -208,6 +210,76 @@ case class Abs(child: Expression, failOnError:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885218377 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -244,8 +311,7 @@ abstract class BinaryArithmetic extends

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885213632 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala: ## @@ -57,10 +53,13 @@ import org.apache.spark.sql.types._ * - LONG

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885179955 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala: ## @@ -60,7 +56,7 @@ import org.apache.spark.sql.types._ */ //

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885179844 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala: ## @@ -60,7 +56,7 @@ import org.apache.spark.sql.types._ */ //

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885169100 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -323,11 +389,24 @@ case class Add( override def decimalMethod:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r884783994 ## sql/core/src/test/resources/tpcds-plan-stability/approved-plans-modified/q65.sf100/explain.txt: ## @@ -151,106 +152,110 @@ Functions [1]: [avg(revenue#21)]

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r884783483 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Average.scala: ## @@ -75,18 +80,17 @@ abstract class AverageBase )

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r884540625 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/decimalExpressions.scala: ## @@ -232,3 +216,32 @@ case class CheckOverflowInSum( override

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r884540625 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/decimalExpressions.scala: ## @@ -232,3 +216,32 @@ case class CheckOverflowInSum( override

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r884517612 ## sql/core/src/test/resources/tpcds-plan-stability/approved-plans-modified/q65.sf100/explain.txt: ## @@ -151,106 +152,110 @@ Functions [1]: [avg(revenue#21)]

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r884490301 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -208,6 +210,76 @@ case class Abs(child: Expression, failOnError:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r884489135 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -323,11 +389,24 @@ case class Add( override def decimalMethod:

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r884487459 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -313,7 +379,7 @@ object BinaryArithmetic { case class Add(

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r884480683 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Average.scala: ## @@ -75,18 +80,17 @@ abstract class AverageBase )

[GitHub] [spark] cloud-fan commented on a diff in pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r884470221 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala: ## @@ -60,7 +56,7 @@ import org.apache.spark.sql.types._ */ //