Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/6876
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-114607544
Thanks, merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-114245985
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-114245895
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-114288625
[Test build #35483 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35483/console)
for PR 6876 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-114288715
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-114246587
[Test build #35483 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35483/consoleFull)
for PR 6876 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32891689
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateProjection.scala
---
@@ -127,6 +127,7 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32884758
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateProjection.scala
---
@@ -127,6 +127,7 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32884828
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -26,7 +26,67 @@ import
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32887551
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateProjection.scala
---
@@ -127,6 +127,7 @@ object
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113844501
[Test build #946 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/946/console)
for PR 6876 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113838214
[Test build #946 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/946/consoleFull)
for PR 6876 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113637840
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113637801
[Test build #35307 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35307/console)
for PR 6876 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113643422
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113643472
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113670534
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113670505
[Test build #35322 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35322/console)
for PR 6876 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113632533
[Test build #939 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/939/console)
for PR 6876 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113643925
[Test build #35322 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35322/consoleFull)
for PR 6876 at commit
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32804448
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/LiteralExpressionSuite.scala
---
@@ -31,8 +45,16 @@ class
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113397757
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113397673
[Test build #35225 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35225/console)
for PR 6876 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113577456
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113576558
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113576770
[Test build #35283 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35283/consoleFull)
for PR 6876 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113576533
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113577516
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113577977
[Test build #35284 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35284/consoleFull)
for PR 6876 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113595742
[Test build #937 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/937/consoleFull)
for PR 6876 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113593028
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113596212
[Test build #937 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/937/console)
for PR 6876 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113592984
[Test build #35283 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35283/console)
for PR 6876 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113602656
[Test build #939 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/939/consoleFull)
for PR 6876 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113604521
[Test build #35284 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35284/console)
for PR 6876 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113604560
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113606152
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113606317
[Test build #35307 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35307/consoleFull)
for PR 6876 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113606196
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113606100
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32752513
--- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/BaseRow.java ---
@@ -167,9 +167,21 @@ public boolean equals(Object other) {
return
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32751957
--- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/BaseRow.java ---
@@ -215,4 +227,15 @@ public String mkString(String sep) {
public String
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32799341
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -26,7 +26,67 @@ import
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32799934
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -26,7 +26,67 @@ import
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113371654
[Test build #35225 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35225/consoleFull)
for PR 6876 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113371570
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113371558
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113348592
**[Test build #35189 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35189/console)**
for PR 6876 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113348606
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32799402
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -26,7 +26,67 @@ import
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32799430
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -26,7 +26,67 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32799457
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -26,7 +26,67 @@ import
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113232161
[Test build #35144 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35144/console)
for PR 6876 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113231076
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113231014
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113237099
[Test build #35146 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35146/consoleFull)
for PR 6876 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113232167
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113235712
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113235672
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113269194
[Test build #35146 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35146/console)
for PR 6876 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113269243
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113231856
[Test build #35144 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35144/consoleFull)
for PR 6876 at commit
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113285297
@marmbrus Could you help to review this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32786925
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -55,7 +55,7 @@ trait ExpressionEvalHelper
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32786856
--- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/BaseRow.java ---
@@ -155,27 +155,6 @@ public int fieldIndex(String name) {
throw new
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32786889
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -27,6 +27,63 @@ import
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113307995
@davies, thanks for working on this! I'm okay with this approach, but did
you consider the alternative, where we instead change the internal type of
`BytesType` to be
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32789934
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -27,6 +27,63 @@ import
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32790069
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -55,7 +55,7 @@ trait ExpressionEvalHelper {
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32790173
--- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/BaseRow.java ---
@@ -155,27 +155,6 @@ public int fieldIndex(String name) {
throw new
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113319601
@marmbrus We're working to have more efficient representation in catalyst,
putting Array[Byte] inside a wrapper sounds not in the same direction. I'd like
to go this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113320406
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113320501
[Test build #35189 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35189/consoleFull)
for PR 6876 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113320382
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113321944
I think using a wrapper might be necessary for efficiency. For example, we
will want to reuse the same byte array when reading from something like
parquet, instead of
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32714548
--- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/BaseRow.java ---
@@ -215,4 +227,15 @@ public String mkString(String sep) {
public String
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32714889
--- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/BaseRow.java ---
@@ -167,9 +167,21 @@ public boolean equals(Object other) {
return
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113098257
[Test build #35114 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35114/console)
for PR 6876 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113098285
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113068930
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113069330
[Test build #35112 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35112/console)
for PR 6876 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113069333
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user davies opened a pull request:
https://github.com/apache/spark/pull/6876
[SPARK-8432] [SQL] fix hashCode() and equals() of BinaryType in Row
Also added more tests in LiteralExpressionSuite
You can merge this pull request into a Git repository by running:
$ git pull
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113069063
[Test build #35112 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35112/consoleFull)
for PR 6876 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113068917
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113070851
[Test build #35114 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35114/consoleFull)
for PR 6876 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113070594
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6876#issuecomment-113070606
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
89 matches
Mail list logo
