[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-08-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7014 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-08-12 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-130336611 merged to master & 1.5 thanks @tomwhite ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-08-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-128838079 [Test build #1405 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1405/console) for PR 7014 at commit [`4c884d0`](https://github

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-08-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-128795853 [Test build #1405 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1405/consoleFull) for PR 7014 at commit [`4c884d0`](https://git

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-08-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-128771268 [Test build #1404 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1404/console) for PR 7014 at commit [`4c884d0`](https://github

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-08-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-128725619 [Test build #1404 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1404/consoleFull) for PR 7014 at commit [`4c884d0`](https://git

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-08-07 Thread tomwhite
Github user tomwhite commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-128724854 Thanks. The error came from new code that was committed in SPARK-4352. I've rebased and fixed the offending line. --- If your project is set up for it, you can reply t

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-08-07 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-128703873 @tomwhite still looks like a real compile error: ``` [error] /home/jenkins/workspace/NewSparkPullRequestBuilder/core/src/main/scala/org/apache/spark/schedule

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-08-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-128595127 [Test build #1401 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1401/console) for PR 7014 at commit [`d531c93`](https://github

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-08-06 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-128594900 I triggered Jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-08-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-128594748 [Test build #1401 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1401/consoleFull) for PR 7014 at commit [`d531c93`](https://git

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-08-06 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-128450309 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-08-05 Thread tomwhite
Github user tomwhite commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-128271252 I rebased this on master. Is there a way to get this to be retested? --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-30 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-126501269 @tomwhite there is a legit failure here, looks like you need to merge w/ master and fix a compile error --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-30 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-126415566 Looks good from my end. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-126400812 [Test build #1238 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1238/console) for PR 7014 at commit [`a14f282`](https://github

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-126397175 [Test build #1238 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1238/consoleFull) for PR 7014 at commit [`a14f282`](https://git

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-126394289 [Test build #1237 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1237/console) for PR 7014 at commit [`a14f282`](https://github

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-126393428 [Test build #1237 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1237/consoleFull) for PR 7014 at commit [`a14f282`](https://git

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-126367552 [Test build #1235 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1235/console) for PR 7014 at commit [`b609c51`](https://github

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-126365459 [Test build #1235 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1235/consoleFull) for PR 7014 at commit [`b609c51`](https://git

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-30 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-126283659 @aarondav are you OK with this now? I think tom addressed all your concerns --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-28 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r35658884 --- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala --- @@ -128,6 +149,25 @@ case class ExceptionFailure( } /** + * A class f

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-28 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-125636498 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-27 Thread tomwhite
Github user tomwhite commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-125377110 Looks like this change is not causing the failure in SQLQuerySuite as it is failing for other PRs (e.g. https://github.com/apache/spark/pull/7678, https://amplab.cs.ber

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-125353124 [Test build #1211 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1211/console) for PR 7014 at commit [`b609c51`](https://github

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-125329030 [Test build #1211 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1211/consoleFull) for PR 7014 at commit [`b609c51`](https://git

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-125324925 [Test build #1209 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1209/console) for PR 7014 at commit [`b609c51`](https://github

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-125324517 [Test build #1209 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1209/consoleFull) for PR 7014 at commit [`b609c51`](https://git

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-125323278 [Test build #1207 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1207/console) for PR 7014 at commit [`8df33bc`](https://github

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-125287659 [Test build #1207 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1207/consoleFull) for PR 7014 at commit [`8df33bc`](https://git

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r35478432 --- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala --- @@ -97,13 +103,27 @@ case class ExceptionFailure( description: String,

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-124762135 [Test build #1199 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1199/console) for PR 7014 at commit [`8df33bc`](https://github

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-124761604 [Test build #1199 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1199/consoleFull) for PR 7014 at commit [`8df33bc`](https://git

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-24 Thread tomwhite
Github user tomwhite commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-124739632 Rebased on master to fix a merge conflict. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-24 Thread tomwhite
Github user tomwhite commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r35463705 --- Diff: core/src/test/scala/org/apache/spark/FailureSuite.scala --- @@ -141,5 +141,73 @@ class FailureSuite extends SparkFunSuite with LocalSparkContext {

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-24 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r35415582 --- Diff: core/src/test/scala/org/apache/spark/FailureSuite.scala --- @@ -141,5 +141,73 @@ class FailureSuite extends SparkFunSuite with LocalSparkContext {

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-23 Thread tomwhite
Github user tomwhite commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r35339164 --- Diff: core/src/test/scala/org/apache/spark/FailureSuite.scala --- @@ -141,5 +141,73 @@ class FailureSuite extends SparkFunSuite with LocalSparkContext {

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-22 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r35280981 --- Diff: core/src/test/scala/org/apache/spark/FailureSuite.scala --- @@ -141,5 +141,73 @@ class FailureSuite extends SparkFunSuite with LocalSparkContext {

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-22 Thread tomwhite
Github user tomwhite commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r35280938 --- Diff: core/src/test/scala/org/apache/spark/FailureSuite.scala --- @@ -141,5 +141,73 @@ class FailureSuite extends SparkFunSuite with LocalSparkContext {

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-22 Thread tomwhite
Github user tomwhite commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r35280889 --- Diff: core/src/test/scala/org/apache/spark/FailureSuite.scala --- @@ -141,5 +141,73 @@ class FailureSuite extends SparkFunSuite with LocalSparkContext {

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-22 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r35280503 --- Diff: core/src/test/scala/org/apache/spark/FailureSuite.scala --- @@ -141,5 +141,73 @@ class FailureSuite extends SparkFunSuite with LocalSparkContext {

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-22 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r35280447 --- Diff: core/src/test/scala/org/apache/spark/FailureSuite.scala --- @@ -141,5 +141,73 @@ class FailureSuite extends SparkFunSuite with LocalSparkContext {

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-22 Thread tomwhite
Github user tomwhite commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-123915069 Thanks @aarondav for the review. I've addressed all your points and I also rebased on master to fix a conflict. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-22 Thread tomwhite
Github user tomwhite commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r35279212 --- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala --- @@ -97,13 +103,26 @@ case class ExceptionFailure( description: String,

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-17 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r34903975 --- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala --- @@ -97,13 +103,26 @@ case class ExceptionFailure( description: String,

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-17 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r34903771 --- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala --- @@ -127,6 +146,19 @@ case class ExceptionFailure( } } +class Thro

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-17 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r34903699 --- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala --- @@ -97,13 +103,26 @@ case class ExceptionFailure( description: String,

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-17 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r34903614 --- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala --- @@ -97,13 +103,26 @@ case class ExceptionFailure( description: String,

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-17 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r34903555 --- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala --- @@ -127,6 +146,19 @@ case class ExceptionFailure( } } +class Thro

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-17 Thread tomwhite
Github user tomwhite commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-122297345 The build was failing because the changes didn't compile against master. I've rebased and fixed the problem, as well as added a commit to address @aarondav's comment.

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-17 Thread tomwhite
Github user tomwhite commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r34895108 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -300,8 +300,16 @@ private[spark] class Executor( m

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-16 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r34855806 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -300,8 +300,16 @@ private[spark] class Executor( m

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-16 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r34855831 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -300,8 +300,16 @@ private[spark] class Executor( m

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-122027879 [Test build #1082 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1082/console) for PR 7014 at commit [`e5a1d7c`](https://github

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-122024436 [Test build #1082 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1082/consoleFull) for PR 7014 at commit [`e5a1d7c`](https://git

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-16 Thread tomwhite
Github user tomwhite commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-122012446 Thanks for all the feedback @pwendell, @squito, and @kayousterhout. I've addressed all your points and updated this PR. @squito Regarding `JsonProtocol`, I can'

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-15 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-121679734 Scheduler changes LGTM, subject to @squito's suggestion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-15 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r34698703 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -745,8 +745,11 @@ class DAGScheduler( submitWaitingStages()

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-15 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-121648671 I played with this locally a bit, and I think that actually defaulting `Option[Throwable] = None` is covering up some cases where there really is an exception you should

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-15 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r34685157 --- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala --- @@ -90,6 +90,10 @@ case class FetchFailed( * * `fullStackTrace` is a better r

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-14 Thread markhamstra
Github user markhamstra commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-121311906 @pwendell I'm not seeing anything concerning in the DAGScheduler changes. --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-14 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r34590635 --- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala --- @@ -97,11 +101,17 @@ case class ExceptionFailure( description: String,

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-14 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-121306600 I think the compatibility is okay, but two other quick questions: 1. Is it well defined which exception caused the task to fail? What if a task fails N times wi

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-06 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-119052339 ping @pwendell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-07-01 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-117710355 @pwendell are you OK with the change to `ExceptionFailure`? If you're ok w/ it, this lgtm --- If your project is set up for it, you can reply to this email and have yo

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-06-29 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r33468301 --- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala --- @@ -97,11 +101,17 @@ case class ExceptionFailure( description: String,

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-06-29 Thread tomwhite
Github user tomwhite commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r33454836 --- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala --- @@ -97,11 +101,17 @@ case class ExceptionFailure( description: String,

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-06-29 Thread tomwhite
Github user tomwhite commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r33454364 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -662,6 +662,7 @@ private[spark] class TaskSetManager( val

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-06-28 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r33435542 --- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala --- @@ -97,11 +101,17 @@ case class ExceptionFailure( description: String,

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-06-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-115750881 [Test build #965 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/965/console) for PR 7014 at commit [`44cb266`](https://github.c

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-06-26 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r33371157 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -662,6 +662,7 @@ private[spark] class TaskSetManager(

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-06-26 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-115708177 a couple of minor comments, aside from that just waiting to see if the tests pass --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-06-26 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r33360179 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala --- @@ -47,7 +47,10 @@ class FakeDAGScheduler(sc: SparkContext, taskSchedule

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-06-26 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r33360109 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1264,7 +1267,10 @@ class DAGScheduler( * Aborts all jobs depending

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-06-26 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r33359952 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -17,7 +17,7 @@ package org.apache.spark.executor -import java

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-06-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-115705368 [Test build #965 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/965/consoleFull) for PR 7014 at commit [`44cb266`](https://githu

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-06-26 Thread tomwhite
Github user tomwhite commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-115607939 @squito thanks for the review! I've addressed your comments in a new commit. --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-06-26 Thread tomwhite
Github user tomwhite commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r33340937 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -662,6 +662,7 @@ private[spark] class TaskSetManager( val

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-06-25 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-115270287 @tomwhite this looks great! thanks so much for working on this, I think it will be a really good addition. I left some minor style comments in addition to the ones the

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-06-25 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r33257851 --- Diff: core/src/test/scala/org/apache/spark/FailureSuite.scala --- @@ -139,5 +139,32 @@ class FailureSuite extends SparkFunSuite with LocalSparkContext {

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-06-25 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r33257390 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -728,16 +730,16 @@ private[spark] class TaskSetManager( logEr

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-06-25 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r33257058 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -662,6 +662,7 @@ private[spark] class TaskSetManager( val f

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-06-25 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r3325 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGSchedulerEvent.scala --- @@ -74,6 +74,7 @@ private[scheduler] case class ExecutorAdded(execId: Str

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-06-25 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r33256629 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1281,8 +1284,9 @@ class DAGScheduler( } /** Fails a job

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-06-25 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r33256599 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1264,7 +1266,8 @@ class DAGScheduler( * Aborts all jobs depending o

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-06-25 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r33256565 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1155,7 +1156,8 @@ class DAGScheduler( case commitDenied: TaskCom

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-06-25 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/7014#discussion_r33255869 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -745,8 +745,9 @@ class DAGScheduler( submitWaitingStages() }

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-06-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-115259611 [Test build #961 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/961/console) for PR 7014 at commit [`fc484b9`](https://github.c

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-06-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-115258927 [Test build #961 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/961/consoleFull) for PR 7014 at commit [`fc484b9`](https://githu

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-06-25 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-115212961 OK to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-06-25 Thread sujkh85
Github user sujkh85 commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-115210040 NAVER - http://www.naver.com/ su...@naver.com 님께 보내신 메일 이 다음과 같은 이유로 전ì†

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-115209808 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-06-25 Thread sujkh85
Github user sujkh85 commented on the pull request: https://github.com/apache/spark/pull/7014#issuecomment-115209619 NAVER - http://www.naver.com/ su...@naver.com 님께 보내신 메일 <[spark] [SPARK-8625] [Core] Propagat

[GitHub] spark pull request: [SPARK-8625] [Core] Propagate user exceptions ...

2015-06-25 Thread tomwhite
GitHub user tomwhite opened a pull request: https://github.com/apache/spark/pull/7014 [SPARK-8625] [Core] Propagate user exceptions in tasks back to driver This allows clients to retrieve the original exception from the cause field of the SparkException that is thrown by the driv