[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-18 Thread junyangq
Github user junyangq closed the pull request at: https://github.com/apache/spark/pull/14558 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-18 Thread junyangq
GitHub user junyangq reopened a pull request: https://github.com/apache/spark/pull/14558 [SPARK-16508][SparkR] Fix warnings on undocumented/duplicated arguments by CRAN-check ## What changes were proposed in this pull request? This PR tries to fix all the remaining

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-18 Thread junyangq
Github user junyangq closed the pull request at: https://github.com/apache/spark/pull/14558 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-17 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r75215338 --- Diff: R/pkg/R/generics.R --- @@ -1251,10 +1311,57 @@ setGeneric("year", function(x) { standardGeneric("year") }) #' @export

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-17 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r75182227 --- Diff: .gitignore --- @@ -77,3 +77,8 @@ spark-warehouse/ # For R session data .RData .RHistory +.Rhistory --- End diff --

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-17 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r75123714 --- Diff: R/pkg/R/generics.R --- @@ -1251,10 +1311,57 @@ setGeneric("year", function(x) { standardGeneric("year") }) #' @export

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-17 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r75124591 --- Diff: R/pkg/R/DataFrame.R --- @@ -510,9 +510,7 @@ setMethod("registerTempTable", #' #' Insert the contents of a SparkDataFrame into a table

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-17 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r75123349 --- Diff: R/pkg/R/mllib.R --- @@ -602,14 +599,14 @@ setMethod("spark.survreg", signature(data = "SparkDataFrame", formula = "formula # Returns a

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-16 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r75025476 --- Diff: R/pkg/R/DataFrame.R --- @@ -510,9 +510,7 @@ setMethod("registerTempTable", #' #' Insert the contents of a SparkDataFrame into a table

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-16 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74974091 --- Diff: R/pkg/R/DataFrame.R --- @@ -510,9 +510,7 @@ setMethod("registerTempTable", #' #' Insert the contents of a SparkDataFrame into a table

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-15 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74874929 --- Diff: R/pkg/R/functions.R --- @@ -1143,7 +1139,7 @@ setMethod("minute", #' @export #' @examples \dontrun{select(df,

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-15 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74874081 --- Diff: R/pkg/R/SQLContext.R --- @@ -181,7 +181,7 @@ getDefaultSqlSource <- function() { #' @method createDataFrame default #' @note

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-15 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74873867 --- Diff: R/pkg/R/mllib.R --- @@ -298,14 +304,15 @@ setMethod("summary", signature(object = "NaiveBayesModel"), #' Users can call \code{summary} to

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-15 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74729338 --- Diff: R/pkg/R/DataFrame.R --- @@ -510,9 +510,7 @@ setMethod("registerTempTable", #' #' Insert the contents of a SparkDataFrame into a table

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-15 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74729028 --- Diff: R/pkg/R/generics.R --- @@ -1251,10 +1311,57 @@ setGeneric("year", function(x) { standardGeneric("year") }) #' @export

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-15 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74728822 --- Diff: R/pkg/R/generics.R --- @@ -1277,8 +1384,11 @@ setGeneric("spark.naiveBayes", function(data, formula, ...) { standardGeneric("s #'

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-15 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74728351 --- Diff: R/pkg/R/mllib.R --- @@ -142,15 +143,6 @@ setMethod("spark.glm", signature(data = "SparkDataFrame", formula = "formula"), #' Generalized

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-15 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74727208 --- Diff: R/pkg/R/mllib.R --- @@ -602,14 +599,14 @@ setMethod("spark.survreg", signature(data = "SparkDataFrame", formula = "formula # Returns a

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-14 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74707500 --- Diff: R/pkg/R/mllib.R --- @@ -142,15 +143,6 @@ setMethod("spark.glm", signature(data = "SparkDataFrame", formula = "formula"), #' Generalized

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-14 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74707292 --- Diff: R/pkg/R/mllib.R --- @@ -142,15 +143,6 @@ setMethod("spark.glm", signature(data = "SparkDataFrame", formula = "formula"), #' Generalized

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-14 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74707272 --- Diff: R/pkg/R/mllib.R --- @@ -346,8 +339,11 @@ setMethod("spark.kmeans", signature(data = "SparkDataFrame", formula = "formula" #' Get fitted

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-14 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74707253 --- Diff: R/pkg/R/mllib.R --- @@ -414,11 +411,12 @@ setMethod("predict", signature(object = "KMeansModel"), #' predictions on new data, and

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-14 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74706060 --- Diff: R/pkg/R/DataFrame.R --- @@ -3184,6 +3200,7 @@ setMethod("histogram", #' @param x A SparkDataFrame #' @param url JDBC database url of the

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74694116 --- Diff: R/pkg/R/functions.R --- @@ -1143,7 +1139,7 @@ setMethod("minute", #' @export #' @examples \dontrun{select(df,

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74693897 --- Diff: R/pkg/R/SQLContext.R --- @@ -181,7 +181,7 @@ getDefaultSqlSource <- function() { #' @method createDataFrame default #' @note

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74693887 --- Diff: R/pkg/R/DataFrame.R --- @@ -2461,8 +2473,9 @@ setMethod("unionAll", #' Union two or more SparkDataFrames. This is equivalent to `UNION

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74693856 --- Diff: R/pkg/R/DataFrame.R --- @@ -1146,7 +1147,7 @@ setMethod("head", #' Return the first row of a SparkDataFrame #' -#' @param x

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74693823 --- Diff: R/pkg/R/DataFrame.R --- @@ -510,9 +510,7 @@ setMethod("registerTempTable", #' #' Insert the contents of a SparkDataFrame into a table

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74693204 --- Diff: R/pkg/R/functions.R --- @@ -1497,7 +1493,7 @@ setMethod("soundex", #' \dontrun{select(df, spark_partition_id())} #' @note

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74693197 --- Diff: R/pkg/R/generics.R --- @@ -1251,10 +1311,57 @@ setGeneric("year", function(x) { standardGeneric("year") }) #' @export

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74693174 --- Diff: R/pkg/R/generics.R --- @@ -1277,8 +1384,11 @@ setGeneric("spark.naiveBayes", function(data, formula, ...) { standardGeneric("s #'

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74693158 --- Diff: R/pkg/R/mllib.R --- @@ -142,15 +143,6 @@ setMethod("spark.glm", signature(data = "SparkDataFrame", formula = "formula"), #' Generalized

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74693142 --- Diff: R/pkg/R/mllib.R --- @@ -298,14 +304,15 @@ setMethod("summary", signature(object = "NaiveBayesModel"), #' Users can call \code{summary} to

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74693106 --- Diff: R/pkg/R/mllib.R --- @@ -346,8 +339,11 @@ setMethod("spark.kmeans", signature(data = "SparkDataFrame", formula = "formula" #' Get fitted

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74693097 --- Diff: R/pkg/R/mllib.R --- @@ -414,11 +411,12 @@ setMethod("predict", signature(object = "KMeansModel"), #' predictions on new data, and

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74693087 --- Diff: .gitignore --- @@ -77,3 +77,8 @@ spark-warehouse/ # For R session data .RData .RHistory +.Rhistory --- End diff --

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74693053 --- Diff: R/pkg/R/mllib.R --- @@ -602,14 +599,14 @@ setMethod("spark.survreg", signature(data = "SparkDataFrame", formula = "formula # Returns a

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74692979 --- Diff: R/pkg/R/DataFrame.R --- @@ -3184,6 +3200,7 @@ setMethod("histogram", #' @param x A SparkDataFrame #' @param url JDBC database url of

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-10 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74350887 --- Diff: R/pkg/R/generics.R --- @@ -1046,8 +1084,8 @@ setGeneric("ntile", function(x) { standardGeneric("ntile") }) #' @export

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-10 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74349926 --- Diff: R/pkg/R/mllib.R --- @@ -57,6 +57,9 @@ setClass("KMeansModel", representation(jobj = "jobj")) #' #' Saves the MLlib model to the input

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-10 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74349451 --- Diff: R/pkg/R/mllib.R --- @@ -414,11 +425,12 @@ setMethod("predict", signature(object = "KMeansModel"), #' predictions on new data, and

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-10 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74316468 --- Diff: R/pkg/R/generics.R --- @@ -1046,8 +1084,8 @@ setGeneric("ntile", function(x) { standardGeneric("ntile") }) #' @export

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-10 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74316333 --- Diff: R/pkg/R/mllib.R --- @@ -57,6 +57,9 @@ setClass("KMeansModel", representation(jobj = "jobj")) #' #' Saves the MLlib model to the input

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-10 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74316168 --- Diff: R/pkg/R/mllib.R --- @@ -414,11 +425,12 @@ setMethod("predict", signature(object = "KMeansModel"), #' predictions on new data, and

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74178308 --- Diff: .gitignore --- @@ -77,3 +77,8 @@ spark-warehouse/ # For R session data .RData .RHistory +.Rhistory --- End diff --

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74177336 --- Diff: R/pkg/R/SQLContext.R --- @@ -257,23 +257,24 @@ createDataFrame.default <- function(data, schema = NULL, samplingRatio = 1.0) { }

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74176995 --- Diff: R/pkg/R/DataFrame.R --- @@ -1146,7 +1147,7 @@ setMethod("head", #' Return the first row of a SparkDataFrame #' -#' @param x A

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74176280 --- Diff: R/pkg/R/functions.R --- @@ -1273,12 +1267,14 @@ setMethod("round", #' bround #' #' Returns the value of the column `e` rounded to

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74172127 --- Diff: R/pkg/R/functions.R --- @@ -3033,6 +3033,9 @@ setMethod("when", signature(condition = "Column", value = "ANY"), #' Evaluates a list of

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74172250 --- Diff: R/pkg/R/functions.R --- @@ -2654,6 +2647,9 @@ setMethod("expr", signature(x = "character"), #' #' Formats the arguments in printf-style

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74172111 --- Diff: R/pkg/R/generics.R --- @@ -1022,6 +1059,7 @@ setGeneric("month", function(x) { standardGeneric("month") }) #' @export

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74171391 --- Diff: R/pkg/R/mllib.R --- @@ -57,6 +57,9 @@ setClass("KMeansModel", representation(jobj = "jobj")) #' #' Saves the MLlib model to the input

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74171283 --- Diff: R/pkg/R/generics.R --- @@ -1046,8 +1084,8 @@ setGeneric("ntile", function(x) { standardGeneric("ntile") }) #' @export

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74170465 --- Diff: R/pkg/R/mllib.R --- @@ -82,15 +87,16 @@ NULL #' Users can call \code{summary} to print a summary of the fitted model, \code{predict} to make

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74170438 --- Diff: R/pkg/R/mllib.R --- @@ -298,14 +304,15 @@ setMethod("summary", signature(object = "NaiveBayesModel"), #' Users can call \code{summary} to

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74170348 --- Diff: R/pkg/R/mllib.R --- @@ -414,11 +425,12 @@ setMethod("predict", signature(object = "KMeansModel"), #' predictions on new data, and

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74170002 --- Diff: R/pkg/R/mllib.R --- @@ -563,11 +574,12 @@ read.ml <- function(path) { #' \code{predict} to make predictions on new data, and

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74169009 --- Diff: R/pkg/R/generics.R --- @@ -465,10 +477,14 @@ setGeneric("dapply", function(x, func, schema) { standardGeneric("dapply") }) #' @export

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74167878 --- Diff: R/pkg/R/generics.R --- @@ -395,6 +396,9 @@ setGeneric("value", function(bcast) { standardGeneric("value") })

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74146966 --- Diff: .gitignore --- @@ -77,3 +77,8 @@ spark-warehouse/ # For R session data .RData .RHistory +.Rhistory --- End diff --

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74105069 --- Diff: R/pkg/R/DataFrame.R --- @@ -177,11 +176,10 @@ setMethod("isLocal", #' #' Print the first numRows rows of a SparkDataFrame #'

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74104886 --- Diff: R/pkg/R/DataFrame.R --- @@ -1146,7 +1147,7 @@ setMethod("head", #' Return the first row of a SparkDataFrame #' -#' @param x

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74104522 --- Diff: R/pkg/R/DataFrame.R --- @@ -2845,8 +2844,11 @@ setMethod("fillna", #' Since data.frames are held in memory, ensure that you have enough

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74104039 --- Diff: R/pkg/R/DataFrame.R --- @@ -3049,8 +3050,8 @@ setMethod("drop", #' #' @name histogram #' @param nbins the number of bins

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74103250 --- Diff: R/pkg/R/DataFrame.R --- @@ -3184,6 +3185,7 @@ setMethod("histogram", #' @param x A SparkDataFrame #' @param url JDBC database url of

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74103028 --- Diff: R/pkg/R/SQLContext.R --- @@ -257,23 +257,24 @@ createDataFrame.default <- function(data, schema = NULL, samplingRatio = 1.0) { }

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74102403 --- Diff: R/pkg/R/SQLContext.R --- @@ -727,6 +729,7 @@ dropTempView <- function(viewName) { #' @param source The name of external data source

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74102227 --- Diff: R/pkg/R/SQLContext.R --- @@ -840,6 +844,7 @@ createExternalTable <- function(x, ...) { #' clause expressions used to

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74022313 --- Diff: R/pkg/R/functions.R --- @@ -1273,12 +1267,14 @@ setMethod("round", #' bround #' #' Returns the value of the column `e` rounded

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74021040 --- Diff: R/pkg/R/functions.R --- @@ -1560,7 +1556,8 @@ setMethod("stddev_samp", #' #' Creates a new struct column that composes multiple input

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74020775 --- Diff: R/pkg/R/functions.R --- @@ -2654,6 +2647,9 @@ setMethod("expr", signature(x = "character"), #' #' Formats the arguments in

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74017865 --- Diff: R/pkg/R/functions.R --- @@ -3033,6 +3033,9 @@ setMethod("when", signature(condition = "Column", value = "ANY"), #' Evaluates a list of

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74017287 --- Diff: R/pkg/R/generics.R --- @@ -1022,6 +1059,7 @@ setGeneric("month", function(x) { standardGeneric("month") }) #' @export

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74016459 --- Diff: R/pkg/R/generics.R --- @@ -1091,8 +1129,8 @@ setGeneric("reverse", function(x) { standardGeneric("reverse") }) #' @export

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74016421 --- Diff: R/pkg/R/generics.R --- @@ -1046,8 +1084,8 @@ setGeneric("ntile", function(x) { standardGeneric("ntile") }) #' @export

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74016338 --- Diff: R/pkg/R/mllib.R --- @@ -57,6 +57,9 @@ setClass("KMeansModel", representation(jobj = "jobj")) #' #' Saves the MLlib model to the input

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74016268 --- Diff: R/pkg/R/mllib.R --- @@ -69,6 +72,8 @@ NULL #' #' Makes predictions from a MLlib model. For more information, see the specific

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74016085 --- Diff: R/pkg/R/mllib.R --- @@ -82,15 +87,16 @@ NULL #' Users can call \code{summary} to print a summary of the fitted model, \code{predict} to

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74015938 --- Diff: R/pkg/R/mllib.R --- @@ -298,14 +304,15 @@ setMethod("summary", signature(object = "NaiveBayesModel"), #' Users can call \code{summary} to

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74015800 --- Diff: R/pkg/R/mllib.R --- @@ -346,8 +353,11 @@ setMethod("spark.kmeans", signature(data = "SparkDataFrame", formula = "formula" #' Get fitted

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74014809 --- Diff: R/pkg/R/mllib.R --- @@ -563,11 +574,12 @@ read.ml <- function(path) { #' \code{predict} to make predictions on new data, and

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74014676 --- Diff: R/pkg/R/mllib.R --- @@ -414,11 +425,12 @@ setMethod("predict", signature(object = "KMeansModel"), #' predictions on new data, and

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74014544 --- Diff: R/pkg/R/mllib.R --- @@ -563,11 +574,12 @@ read.ml <- function(path) { #' \code{predict} to make predictions on new data, and

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74013650 --- Diff: R/pkg/R/sparkR.R --- @@ -328,6 +328,7 @@ sparkRHive.init <- function(jsc = NULL) { #' @param sparkPackages Character vector of packages

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74013042 --- Diff: R/pkg/R/generics.R --- @@ -465,10 +477,14 @@ setGeneric("dapply", function(x, func, schema) { standardGeneric("dapply") }) #' @export

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74013005 --- Diff: R/pkg/R/generics.R --- @@ -465,10 +477,14 @@ setGeneric("dapply", function(x, func, schema) { standardGeneric("dapply") }) #' @export

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74012847 --- Diff: R/pkg/R/generics.R --- @@ -395,6 +396,9 @@ setGeneric("value", function(bcast) { standardGeneric("value") })

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-09 Thread junyangq
GitHub user junyangq opened a pull request: https://github.com/apache/spark/pull/14558 [SPARK-16508][SparkR] Fix warnings on undocumented/duplicated arguments by CRAN-check ## What changes were proposed in this pull request? This PR tries to fix all the