Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14842
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78424378
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -21,26 +21,44 @@ import
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78424255
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -71,12 +95,38 @@ case class SortPrefix(child:
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78424193
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -71,12 +95,38 @@ case class SortPrefix(child:
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78271045
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SortPrefixUtils.scala ---
@@ -40,22 +40,56 @@ object SortPrefixUtils {
def
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78270996
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -71,12 +95,33 @@ case class SortPrefix(child:
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78270832
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -71,12 +95,34 @@ case class SortPrefix(child:
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78270188
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SortPrefixUtils.scala ---
@@ -40,22 +40,56 @@ object SortPrefixUtils {
def
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78270178
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SortPrefixUtils.scala ---
@@ -40,22 +40,56 @@ object SortPrefixUtils {
def
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78270169
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SortPrefixUtils.scala ---
@@ -40,22 +40,56 @@ object SortPrefixUtils {
def
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78270118
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -71,12 +95,33 @@ case class SortPrefix(child:
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78269994
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java
---
@@ -28,12 +28,31 @@
private PrefixComparators()
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78269965
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java
---
@@ -69,48 +86,96 @@ public static long
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78269953
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java
---
@@ -69,48 +86,96 @@ public static long
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78269936
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java
---
@@ -69,48 +86,96 @@ public static long
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78269938
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java
---
@@ -69,48 +86,96 @@ public static long
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78269937
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java
---
@@ -43,9 +62,7 @@ public static long
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78269932
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java
---
@@ -28,12 +28,31 @@
private PrefixComparators()
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78269927
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java
---
@@ -28,12 +28,31 @@
private PrefixComparators()
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78269854
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -71,12 +95,34 @@ case class SortPrefix(child:
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78268705
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -71,12 +95,34 @@ case class SortPrefix(child:
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78268549
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -71,12 +95,34 @@ case class SortPrefix(child:
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78268093
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -71,12 +95,34 @@ case class SortPrefix(child:
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78267899
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -71,12 +95,34 @@ case class SortPrefix(child:
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78267758
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java
---
@@ -27,14 +27,45 @@
public class
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78267373
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java
---
@@ -27,14 +27,45 @@
public class PrefixComparators
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78267385
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -71,12 +95,34 @@ case class SortPrefix(child:
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78267265
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -71,12 +95,34 @@ case class SortPrefix(child:
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78265625
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -71,12 +95,34 @@ case class SortPrefix(child:
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77372825
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java
---
@@ -333,11 +333,12 @@ public UnsafeSorterIterator
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77283504
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/unsafe/sort/RadixSortSuite.scala
---
@@ -40,23 +41,37 @@ class RadixSortSuite extends
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77281884
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/unsafe/sort/RadixSortSuite.scala
---
@@ -40,23 +41,37 @@ class RadixSortSuite extends
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77281310
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/unsafe/sort/RadixSortSuite.scala
---
@@ -40,23 +41,37 @@ class RadixSortSuite extends
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77252890
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java
---
@@ -333,11 +333,12 @@ public UnsafeSorterIterator
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77227594
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java
---
@@ -333,11 +333,12 @@ public UnsafeSorterIterator
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77226997
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java
---
@@ -333,11 +333,12 @@ public UnsafeSorterIterator
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77226868
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/unsafe/sort/RadixSortSuite.scala
---
@@ -40,23 +41,37 @@ class RadixSortSuite extends
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77226814
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java
---
@@ -69,49 +100,161 @@ public static long
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77224425
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -324,7 +324,7 @@ queryPrimary
;
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r7743
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java
---
@@ -333,11 +333,12 @@ public UnsafeSorterIterator
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77221980
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -324,7 +324,7 @@ queryPrimary
;
sortItem
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77221863
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/unsafe/sort/RadixSortSuite.scala
---
@@ -40,23 +41,37 @@ class RadixSortSuite extends
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77221570
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java
---
@@ -69,49 +100,161 @@ public static long
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77221335
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -324,7 +324,7 @@ queryPrimary
;
sortItem
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77210917
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -324,7 +324,7 @@ queryPrimary
;
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77200539
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1204,9 +1204,29 @@ class AstBuilder extends
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77200411
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1204,9 +1204,29 @@ class AstBuilder extends
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77199984
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -324,7 +324,7 @@ queryPrimary
;
sortItem
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77143047
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SortPrefixUtils.scala ---
@@ -89,7 +124,8 @@ object SortPrefixUtils {
* Returns
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77143025
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SortPrefixUtils.scala ---
@@ -40,29 +40,64 @@ object SortPrefixUtils {
def
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77142563
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1204,9 +1204,29 @@ class AstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77142212
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1204,9 +1204,29 @@ class AstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77141840
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -324,7 +324,7 @@ queryPrimary
;
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77141646
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -26,21 +26,40 @@ import
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77076122
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -28,14 +28,24 @@ abstract sealed class SortDirection
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77072274
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -28,14 +28,24 @@ abstract sealed class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77071952
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -28,14 +28,24 @@ abstract sealed class
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r77070890
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -28,14 +28,24 @@ abstract sealed class SortDirection
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r76878871
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -74,7 +74,7 @@ object
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r76878691
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -28,14 +28,24 @@ abstract sealed class SortDirection
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r76875999
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -74,7 +74,7 @@ object
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r76875904
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -28,14 +28,24 @@ abstract sealed class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r76535329
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -36,11 +40,19 @@ case object Descending extends
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r76534922
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2661,4 +2661,186 @@ class SQLQuerySuite extends QueryTest with
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r76534903
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -36,11 +40,19 @@ case object Descending extends
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r76534728
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/unsafe/sort/RadixSortSuite.scala
---
@@ -52,6 +52,7 @@ class RadixSortSuite extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r76532925
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2661,4 +2661,186 @@ class SQLQuerySuite extends QueryTest with
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r76532909
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2661,4 +2661,186 @@ class SQLQuerySuite extends QueryTest with
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r76532670
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -58,7 +70,8 @@ case class SortOrder(child:
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r76532654
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -36,11 +40,19 @@ case object Descending extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r76532409
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -36,11 +40,19 @@ case object Descending extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r76532391
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
@@ -28,6 +28,10 @@ abstract sealed class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r76532386
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/unsafe/sort/RadixSortSuite.scala
---
@@ -52,6 +52,7 @@ class RadixSortSuite extends
73 matches
Mail list logo
