[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21733 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208776234 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala --- @@ -167,6 +165,18 @@ trait WatermarkSupport

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208597100 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StreamingAggregationStateManagerSuite.scala --- @@ -0,0 +1,132 @@

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208597372 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StreamingAggregationStateManagerSuite.scala --- @@ -0,0 +1,132 @@

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208599035 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/package.scala --- @@ -81,4 +85,221 @@ package object state {

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208592855 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/package.scala --- @@ -81,4 +85,221 @@ package object state {

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208600386 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/package.scala --- @@ -81,4 +85,221 @@ package object state {

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208600267 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/package.scala --- @@ -81,4 +85,221 @@ package object state {

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208600790 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/package.scala --- @@ -81,4 +85,221 @@ package object state {

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208598475 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StreamingAggregationStateManagerSuite.scala --- @@ -0,0 +1,132 @@

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208596844 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala --- @@ -201,33 +211,37 @@ object WatermarkSupport {

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208602231 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/package.scala --- @@ -81,4 +85,221 @@ package object state {

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208598797 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/package.scala --- @@ -81,4 +85,221 @@ package object state {

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208596001 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/package.scala --- @@ -81,4 +85,221 @@ package object state {

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208594904 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/package.scala --- @@ -81,4 +85,221 @@ package object state {

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208592556 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -871,6 +871,16 @@ object SQLConf { .intConf

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208591232 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/package.scala --- @@ -81,4 +85,221 @@ package object state {

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208485230 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/package.scala --- @@ -81,4 +85,221 @@ package object state {

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208483760 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/package.scala --- @@ -81,4 +85,221 @@ package object state {

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208482355 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/package.scala --- @@ -81,4 +85,221 @@ package object state {

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208491512 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/package.scala --- @@ -81,4 +85,221 @@ package object state {

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208492158 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala --- @@ -167,6 +165,18 @@ trait WatermarkSupport extends

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208488566 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/package.scala --- @@ -81,4 +85,221 @@ package object state {

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208491168 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StreamingAggregationStateManagerSuite.scala --- @@ -0,0 +1,132 @@ +/*

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208487198 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/package.scala --- @@ -81,4 +85,221 @@ package object state {

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208486837 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/package.scala --- @@ -81,4 +85,221 @@ package object state {

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208496351 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala --- @@ -201,33 +211,37 @@ object WatermarkSupport {

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208490526 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StreamingAggregationStateManagerSuite.scala --- @@ -0,0 +1,132 @@ +/*

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208490973 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StreamingAggregationStateManagerSuite.scala --- @@ -0,0 +1,132 @@ +/*

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208485192 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/package.scala --- @@ -81,4 +85,221 @@ package object state {

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208486899 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/package.scala --- @@ -81,4 +85,221 @@ package object state {

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208491615 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/package.scala --- @@ -81,4 +85,221 @@ package object state {

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208483242 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/package.scala --- @@ -81,4 +85,221 @@ package object state {

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208481983 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/package.scala --- @@ -81,4 +85,221 @@ package object state {

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208489469 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -871,6 +871,16 @@ object SQLConf { .intConf

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208482479 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/package.scala --- @@ -81,4 +85,221 @@ package object state {

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-08 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r208492352 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala --- @@ -167,6 +165,18 @@ trait WatermarkSupport extends

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-01 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206790470 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/MemoryStateStore.scala --- @@ -0,0 +1,53 @@ +/* + * Licensed

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-01 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206791736 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala --- @@ -0,0 +1,137 @@ +/* + *

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-01 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206784385 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala --- @@ -201,33 +200,37 @@ object WatermarkSupport {

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-01 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206791325 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StatefulOperatorsHelperSuite.scala --- @@ -0,0 +1,121 @@ +/*

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-01 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206786014 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala --- @@ -53,7 +53,35 @@ class

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-01 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206780521 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala --- @@ -0,0 +1,137 @@ +/* + *

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-01 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206779898 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala --- @@ -0,0 +1,137 @@ +/* + *

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-01 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206781209 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala --- @@ -0,0 +1,137 @@ +/* + *

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-01 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206790358 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/MemoryStateStore.scala --- @@ -0,0 +1,53 @@ +/* + * Licensed

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-01 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206778127 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala --- @@ -0,0 +1,137 @@ +/* + *

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-01 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206780754 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala --- @@ -0,0 +1,137 @@ +/* + *

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-01 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206778355 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala --- @@ -0,0 +1,137 @@ +/* + *

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-01 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206790505 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StatefulOperatorsHelperSuite.scala --- @@ -0,0 +1,121 @@ +/*

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-01 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206788634 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StatefulOperatorsHelperSuite.scala --- @@ -0,0 +1,121 @@ +/*

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-01 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206778971 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala --- @@ -0,0 +1,137 @@ +/* + *

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-01 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206778077 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala --- @@ -0,0 +1,137 @@ +/* + *

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-01 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206775357 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -871,6 +871,16 @@ object SQLConf { .intConf

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-08-01 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206776398 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -871,6 +871,16 @@ object SQLConf { .intConf

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-07-31 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206726280 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala --- @@ -0,0 +1,137 @@ +/* + * Licensed to

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-07-31 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206727984 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala --- @@ -53,7 +53,35 @@ class StreamingAggregationSuite

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-07-31 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206726108 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala --- @@ -0,0 +1,137 @@ +/* + * Licensed to

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-07-31 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206732233 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/MemoryStateStore.scala --- @@ -0,0 +1,53 @@ +/* + * Licensed to the

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-07-31 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206726327 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala --- @@ -0,0 +1,137 @@ +/* + * Licensed to

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-07-31 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206732204 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/MemoryStateStore.scala --- @@ -0,0 +1,53 @@ +/* + * Licensed to the

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-07-31 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206732522 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StatefulOperatorsHelperSuite.scala --- @@ -0,0 +1,121 @@ +/* + *

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-07-31 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206730542 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala --- @@ -0,0 +1,137 @@ +/* + * Licensed to

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-07-31 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206730845 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala --- @@ -0,0 +1,137 @@ +/* + * Licensed to

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-07-31 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206729618 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala --- @@ -0,0 +1,137 @@ +/* + * Licensed to

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-07-31 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206725943 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala --- @@ -0,0 +1,137 @@ +/* + * Licensed to

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-07-31 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206732676 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StatefulOperatorsHelperSuite.scala --- @@ -0,0 +1,121 @@ +/* + *

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-07-31 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206725731 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala --- @@ -0,0 +1,137 @@ +/* + * Licensed to

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-07-31 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206728051 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StatefulOperatorsHelperSuite.scala --- @@ -0,0 +1,121 @@ +/* + *

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-07-31 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206726027 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala --- @@ -0,0 +1,137 @@ +/* + * Licensed to

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-07-31 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206724964 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -871,6 +871,16 @@ object SQLConf { .intConf

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-07-31 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206727384 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala --- @@ -201,33 +200,37 @@ object WatermarkSupport {

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-07-31 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206725041 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -871,6 +871,16 @@ object SQLConf { .intConf

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-07-11 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r201848371 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -825,6 +825,16 @@ object SQLConf { .intConf

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-07-11 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r201829938 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -825,6 +825,16 @@ object SQLConf { .intConf

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-07-11 Thread jose-torres
Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r201791805 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -825,6 +825,16 @@ object SQLConf { .intConf

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-07-10 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r201483544 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -825,6 +825,16 @@ object SQLConf { .intConf

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-07-10 Thread jose-torres
Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r201397799 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -825,6 +825,16 @@ object SQLConf { .intConf

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-07-09 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r200934841 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala --- @@ -53,7 +54,30 @@ class

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-07-09 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r200932324 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala --- @@ -53,7 +54,30 @@ class

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-07-09 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r200923851 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala --- @@ -53,7 +54,30 @@ class

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-07-09 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r200920142 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala --- @@ -53,7 +54,30 @@ class

[GitHub] spark pull request #21733: [SPARK-24763][SS] Remove redundant key data from ...

2018-07-09 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/spark/pull/21733 [SPARK-24763][SS] Remove redundant key data from value in streaming aggregation * add option to configure enabling new feature: remove redundant key data from value * modify code to