Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11987#discussion_r57946641
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/ng/SqlBase.g4
---
@@ -102,6 +102,15 @@ statement
(PARTITIONED
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11991#discussion_r57946967
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/ng/SqlBase.g4
---
@@ -838,6 +839,8 @@ OUTPUTFORMAT: 'OUTPUTFORMAT
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12069#discussion_r57934860
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/ng/SqlBase.g4
---
@@ -861,6 +866,7 @@ ROLES: 'ROLES';
COMPACTIONS
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12069#discussion_r57936230
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/ng/SqlBase.g4
---
@@ -167,6 +167,11 @@ unsupportedHiveNativeCommands
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12069#issuecomment-203563226
@sureshthalamati thanks for working on this. The `ALTER TABLE table TOUCH
[PARTITION spec]` command has already been implemented.
---
If your project is set up
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12071#discussion_r57971100
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -1,749 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12071#discussion_r57972363
--- Diff: dev/deps/spark-deps-hadoop-2.2 ---
@@ -2,7 +2,8 @@ JavaEWAH-0.3.2.jar
RoaringBitmap-0.5.11.jar
ST4-4.0.4.jar
activation-1.1.jar
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/12214
[SPARK-12610][SQL] Left Anti Join
### What changes were proposed in this pull request?
This PR adds support for `LEFT ANTI JOIN` to Spark SQL. A `LEFT ANTI JOIN`
is the exact opposite
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12199#discussion_r58688523
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/parser/ParseUtils.java
---
@@ -1,135 +0,0 @@
-/**
- * Licensed to the Apache
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12182#issuecomment-205979054
@infynyxx could you add a JIRA ticket and create a ticket like
`[SPARK-][BUILD] use https while downloading binaries` (see the titles of
other PRs
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12191#issuecomment-206222927
@bomeng what is the point of adding non-reserved keywords if they are not
used in parser rules?
The main point of this ticket is that we need to make sure
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12199#discussion_r58667228
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ParserUtilsSuite.scala
---
@@ -0,0 +1,65 @@
+/*
+ * Licensed
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12156#issuecomment-206223273
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59501466
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -488,7 +488,7 @@ class HiveSqlAstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59445656
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -121,84 +123,114 @@ class HiveSqlAstBuilder extends
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12271#issuecomment-209086376
LGTM - pending jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59501698
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -435,13 +480,15 @@ class HiveSqlAstBuilder extends
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12316#issuecomment-209244788
I am not nessecarily against this but I find these quite confusing. Why not
just write `>=` or `<=`?
The PR itself looks pretty solid.
---
If your p
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12255#discussion_r59054745
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -143,10 +143,10 @@ class SparkSqlAstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12191#discussion_r59036188
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -653,6 +653,7 @@ nonReserved
| STATISTICS
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59113861
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -271,8 +271,7 @@ createFileFormat
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59132688
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -134,82 +136,117 @@ class HiveSqlAstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59132734
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -134,82 +136,117 @@ class HiveSqlAstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59132476
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -134,82 +136,117 @@ class HiveSqlAstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59132489
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -134,82 +136,117 @@ class HiveSqlAstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59132631
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -397,11 +429,28 @@ class HiveSqlAstBuilder extends
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12201#issuecomment-206379394
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12199#issuecomment-206210010
Yay! LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12191#issuecomment-206383005
@bomeng No worries. Please focus on the keywords that are reserved in the
ANTLR4 parser, but were not in the ANTLR3 parser. The exception being join
keywords
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12201#issuecomment-206380656
Merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12306#discussion_r59289073
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -665,7 +665,7 @@ class Analyzer(
def apply
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/12306
[SPARK-4226][SQL] Support Correlated Sub-queries
### What changes were proposed in this pull request?
This PR adds support for correlated subqueries to Spark. Correlated
sub-queries
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11762#discussion_r56330360
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/CatalystQlSuite.scala
---
@@ -171,6 +171,7 @@ class CatalystQlSuite extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11209#discussion_r56971763
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -423,6 +345,121 @@ case class Murmur3Hash(children
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11209#discussion_r56972303
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/HashByteArrayBenchmark.scala
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11796#discussion_r57238010
--- Diff: sql/hive/pom.xml ---
@@ -238,36 +238,13 @@
v${hive.version.short}/src/main/scala
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11557#discussion_r57226227
--- Diff: LICENSE ---
@@ -238,6 +238,7 @@ The text of each license is also included at
licenses/LICENSE-[project].txt.
(BSD 3 Clause) netlib
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11557#discussion_r57226156
--- Diff: project/plugins.sbt ---
@@ -23,3 +23,9 @@ libraryDependencies += "org.ow2.asm" % "asm" % "5.0.3"
libra
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/11557#issuecomment-200527025
@cloud-fan I have created a gist of the generated files:
https://gist.github.com/hvanhovell/2ee2149efd6cab79e880
---
If your project is set up for it, you
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/11209#issuecomment-200516145
Thanks for the review! merging to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11557#discussion_r57077678
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ng/AstBuilder.scala
---
@@ -0,0 +1,1450 @@
+/*
+ * Licensed
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/11905
[SPARK-14086][SQL] Add DDL commands to ANTLR4 Parser [WIP]
## What changes were proposed in this pull request?
This PR is built on top of https://github.com/apache/spark/pull/11557
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11557#discussion_r57077787
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala ---
@@ -161,6 +161,10 @@ package object dsl {
def lower(e
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11557#discussion_r57149953
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/CatalystQlSuite.scala
---
@@ -21,15 +21,18 @@ import
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11557#discussion_r57149320
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/ng/SqlBase.g4
---
@@ -0,0 +1,742 @@
+/*
+ * Licensed under
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11557#discussion_r57147327
--- Diff: project/plugins.sbt ---
@@ -23,3 +23,9 @@ libraryDependencies += "org.ow2.asm" % "asm" % "5.0.3"
libra
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11557#discussion_r57354160
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ng/ExpressionParserSuite.scala
---
@@ -0,0 +1,494 @@
+/*
+ * Licensed
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/11948#issuecomment-201755230
@andrewor14 I thought we passed these on to Hive and would execute these
for us. Is this not working at?
As for better messaging: You could do some
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/11557#issuecomment-200368863
@srowen thanks for the heads-up. I'll add an entry to `LICENSE`.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11557#discussion_r57168260
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SessionState.scala ---
@@ -80,7 +80,7 @@ private[sql] class SessionState(ctx: SQLContext
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11297#discussion_r56426148
--- Diff:
sql/catalyst/src/main/antlr3/org/apache/spark/sql/catalyst/parser/FromClauseParser.g
---
@@ -91,10 +91,17 @@ fromClause
joinSource
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/10731#issuecomment-198032884
GROUP BY position is supported by a few major analytical databases:
Terradata & Netezza
I am not sure if you should even allow the combination of a `SE
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11557#discussion_r57278951
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ng/PlanParserSuite.scala
---
@@ -0,0 +1,408 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11557#discussion_r57279440
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ng/ExpressionParserSuite.scala
---
@@ -0,0 +1,494 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11557#discussion_r57279420
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ng/ExpressionParserSuite.scala
---
@@ -0,0 +1,494 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11557#discussion_r57279657
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ng/PlanParserSuite.scala
---
@@ -0,0 +1,408 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11557#discussion_r57279846
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ng/PlanParserSuite.scala
---
@@ -0,0 +1,408 @@
+/*
+ * Licensed
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/11929#issuecomment-200699057
@wangyang1992 what is the problem with using backticks? I am not really in
favor of backporting features.
---
If your project is set up for it, you can reply
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11557#discussion_r57279097
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ng/ExpressionParserSuite.scala
---
@@ -0,0 +1,494 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11557#discussion_r57279041
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -0,0 +1,250 @@
+/*
+ * Licensed to the Apache
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11557#discussion_r57279310
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ng/ExpressionParserSuite.scala
---
@@ -0,0 +1,494 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11557#discussion_r57279658
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ng/PlanParserSuite.scala
---
@@ -0,0 +1,408 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11929#discussion_r57280163
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/AbstractSparkSQLParser.scala
---
@@ -129,7 +129,7 @@ class SqlLexical extends
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/11905#issuecomment-200699373
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11557#discussion_r57281018
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ng/PlanParserSuite.scala
---
@@ -0,0 +1,408 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11557#discussion_r55195410
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -0,0 +1,250 @@
+/*
+ * Licensed to the Apache
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11557#discussion_r55195499
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1953,7 +1954,6 @@ object functions extends LegacyFunctions
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11557#discussion_r55185915
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ng/AstBuilder.scala
---
@@ -0,0 +1,1128 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11557#discussion_r55195847
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ---
@@ -331,8 +331,8 @@ class JoinSuite extends QueryTest with SharedSQLContext
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11557#discussion_r55186195
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ng/ParseDriver.scala
---
@@ -0,0 +1,205 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11557#discussion_r55185301
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ng/AstBuilder.scala
---
@@ -0,0 +1,1128 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11557#discussion_r55195953
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ng/AstBuilder.scala
---
@@ -0,0 +1,1128 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55334443
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommandParser.scala
---
@@ -0,0 +1,410 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55352952
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -64,6 +85,53 @@ private[sql] class SparkQl(conf: ParserConf
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55332214
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -64,6 +85,53 @@ private[sql] class SparkQl(conf: ParserConf
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55335079
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommandParser.scala
---
@@ -0,0 +1,410 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55335131
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommandParser.scala
---
@@ -0,0 +1,410 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55336099
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommandParser.scala
---
@@ -0,0 +1,410 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55337949
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Software
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r5511
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -64,6 +85,53 @@ private[sql] class SparkQl(conf: ParserConf
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55333881
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommandParser.scala
---
@@ -0,0 +1,410 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55333529
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommandParser.scala
---
@@ -0,0 +1,410 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55335240
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommandParser.scala
---
@@ -0,0 +1,410 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55336439
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommandParser.scala
---
@@ -0,0 +1,410 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55336977
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommandParser.scala
---
@@ -0,0 +1,410 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55337179
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/bucket.scala
---
@@ -29,7 +32,8 @@ package
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/11579#issuecomment-193810297
This seems like the most sensible approach in order to get SQL generation
working. In the initial implementation we applied the multi-distinct rewriter
during
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/11485#issuecomment-193811516
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11557#discussion_r55368124
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ---
@@ -331,8 +331,8 @@ class JoinSuite extends QueryTest with SharedSQLContext
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/11506#issuecomment-192116711
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/11415#issuecomment-191454136
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/11415#issuecomment-191455100
Merging this to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11485#discussion_r54842640
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
@@ -473,41 +473,44 @@ private[sql] object
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11485#discussion_r54843612
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
@@ -473,41 +473,44 @@ private[sql] object
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11485#discussion_r54940911
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
@@ -473,41 +473,44 @@ private[sql] object
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11485#discussion_r54940996
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
@@ -473,41 +473,44 @@ private[sql] object
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11501#discussion_r55246967
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/CatalystQl.scala
---
@@ -661,6 +664,36 @@
https://cwiki.apache.org
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/11529#issuecomment-193487536
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/11557
[SPARK-13713][SQL] Migrate parser from ANTLR3 to ANTLR4 [WIP]
### What changes were proposed in this pull request?
The current ANTLR3 parser is quite complex to maintain and suffers from
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/11557#issuecomment-193182056
cc @rxin @davies @andrewor14 @viirya
This will probably fail unit tests.
---
If your project is set up for it, you can reply to this email and have your
901 - 1000 of 4165 matches
Mail list logo
