fdisk but it didn't
exist)?
Best regards,
- Johannes
Am 01.03.22 um 02:25 schrieb Thomas Faber:
Hi Johannes,
ReactOS does not currently support WSK, nor is any work on it in
progress or planned.
Our network stack is unfortunately unstable enough even with just TDI,
so any efforts i
Hi Johannes,
ReactOS does not currently support WSK, nor is any work on it in
progress or planned.
Our network stack is unfortunately unstable enough even with just TDI,
so any efforts in networking typically go towards stabilization.
TDI itself is supported, so if you were to work on a librar
Hey Eric,
looks like we may be missing a header file change here? The build bots aren't
too happy.
Thanks!
/srv/buildbot/worker_data/Build_GCCLin_x86/build/base/services/seclogon/rpcserver.c:
In function 'StartRpcServer':
/srv/buildbot/worker_data/Build_GCCLin_x86/build/base/services/seclogon/
On 2021-09-12 08:34, Eric Kohl wrote:
diff --git a/drivers/hid/kbdhid/kbdhid.c b/drivers/hid/kbdhid/kbdhid.c
index bacf72a0109..b07a7d8445c 100644
--- a/drivers/hid/kbdhid/kbdhid.c
+++ b/drivers/hid/kbdhid/kbdhid.c
@@ -444,8 +444,8 @@ KbdHid_InternalDeviceControl(
case IOCTL_KEYBOARD_QU
Hey Eric,
On 2019-08-24 14:01, Eric Kohl wrote:
+PSTR
+WINAPI
+NetpAllocStrFromWStr(
+_In_ PWSTR InString)
+{
+UNICODE_STRING UnicodeString;
+OEM_STRING OemString;
+ULONG Size;
+NET_API_STATUS NetStatus;
+NTSTATUS Status;
+
+RtlInitUnicodeString(&UnicodeString, InStri
Hey Eric,
On 2019-08-24 22:58, Eric Kohl wrote:
> diff --git a/dll/win32/netapi32/netlogon.c b/dll/win32/netapi32/netlogon.c
> index 2c068dc176b..73a0324f0fa 100644
> --- a/dll/win32/netapi32/netlogon.c
> +++ b/dll/win32/netapi32/netlogon.c
> @@ -313,10 +313,58 @@ DsDeregisterDnsHostRecordsA(
>
This does not seem right.
On 2019-06-06 19:14, Eric Kohl wrote:
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=c47ad98ff79ad98042ff2043d739be58770c2fbc
commit c47ad98ff79ad98042ff2043d739be58770c2fbc
Author: Eric Kohl
AuthorDate: Thu Jun 6 19:12:44 2019 +0200
Commit: Eric Kohl
This fix seems odd. I thought HeapFree(NULL) was well-defined and did
nothing (despite what MSDN says). Pretty sure Wine uses it everywhere.
Am I missing something?
On 2019-04-27 19:02, Eric Kohl wrote:
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=ce218f70ec8a758ec6d4039690bae29c23289
This causes a test failure...
https://reactos.org/testman/diff.php?id1=41900790&id2=41904063&type=1&strip=1
On 2019-03-19 23:06, Stanislav Motylkov wrote:
> https://git.reactos.org/?p=reactos.git;a=commitdiff;h=8e05f5509c4baa4df9d543620d5da9552c18f25f
>
> commit 8e05f5509c4baa4df9d543620d5da955
This is resolved. Thank you for your patience.
On 2019-01-27 17:45, Thomas Faber wrote:
master has been broken for days. Until this issue is fixed, no test
results are going to make it to Testman, which means any regressions are
going to be extremely hard to track down.
Here's the iss
master has been broken for days. Until this issue is fixed, no test
results are going to make it to Testman, which means any regressions are
going to be extremely hard to track down.
Here's the issue to follow: https://jira.reactos.org/browse/CORE-15642
Unless you have something that might fix t
On 2018-12-09 20:54, Javier Agustìn Fernàndez Arroyo wrote:
> There are lots of USB related reports, and i´m about creating a master one,
> which blocks all of those... what do you think?
Why? Metabugs aren't really useful in Jira; labels and components are
usually easier to deal with.
This alrea
e the harderror dialog title:
"(null)" (in addition to other strings being appended), instead of just an
empty string.
And so the bug is that I forgot to adjust the condition that needs to be
checked before freeing the window title string (if it has been allocated).
Hermès
-Messa
On 2018-04-08 16:17, Hermès Bélusca-Maïto wrote:
/* Retrieve the window title of the client, if it has one */
-RtlInitEmptyUnicodeString(&WindowTitleU, NULL, 0);
+RtlInitEmptyUnicodeString(&WindowTitleU, L"", 0);
This looks like a bug. Can you explain why you think it's necessary
To elaborate, we're not dependent on GitHub in any significant way. It's
just convenient. But if it stops being so, it's easy to go elsewhere.
That's a key part of Git, being a "distributed" VCS.
On 2018-06-05 10:31, Oleksandr Shaposhnikov wrote:
> No it may not.
>
> 5 черв. 2018 р. 11:24 Javier
On 2018-04-22 22:23, Hermès Bélusca-Maïto wrote:
diff --git a/drivers/base/null/null.c b/drivers/base/null/null.c
index 610e886ddd..0d4ed541de 100644
--- a/drivers/base/null/null.c
+++ b/drivers/base/null/null.c
@@ -181,26 +199,16 @@ DriverEntry(IN PDRIVER_OBJECT DriverObject,
DriverObject-
t;> format. In the end, a buffer of 10 characters is still large enough.
>>
>> PPS: I'll keep using the old functions until you remove them from the
>> runtime code.
>>
>>
>> Regards
>> Eric
>>
>> Am 02.04.2018 um 14:12 schrieb Thomas Faber:
&
Hey Eric,
On 2018-04-02 12:58, Eric Kohl wrote:
-RtlStringCbPrintfW(strbuf, sizeof(strbuf), L"%d:%d:%d", hours, minutes,
seconds);
+swprintf(szBuffer, L"%02d:%02d:%02d", iHours, iMinutes, iSeconds);
Unfortunately I must disagree with this change.
Buffer overflows are a big enough thr
Hey,
On 2018-03-29 23:47, Giovanni Mascellani wrote:
> I am nosing inside Wine and ReactOS code to understand something of
> their inner workings. I wanted to compare the code of d2d1.dll, but
> apparently ReactOS does not have it. Is this intentional, is it just
> still to be implemented, or is
On 2018-03-18 21:06, Кирилл Печкарев wrote:
Hello, I am a 3rd year student of Nosov MSTU, studying in the direction of
Information and Computer science. I would like to develop components to support
Wi-Fi, this is the third item from the list left on the site
(https://habrahabr.ru/company/reac
On 2018-02-08 01:55, Alex Ionescu wrote:
This changes documented/external behavior. What is the point of this change?
Hmm. Before approving the change I googled/tested whether Windows
produces that output but somehow didn't see it. Now that you mention it,
all versions of Windows do seem to hav
Hey Amine,
seeing https://jira.reactos.org/browse/CORE-14288 just prompted me to
look into static vs dynamic 3rd party libraries, zlib and libxml2 in
particular. We use zlib in a bunch of modules these days, and libxml2 is
large and used in two, so I'm thinking we should make them dynamic.
I jus
We often get bug reports with just a screenshot of a bluescreen; we then
go ahead and tell people that bluescreens are basically useless, they
should get a debug log and a backtrace, and also remember to tell us
what version they're using.
Since there's actually no reason why bluescreens need to b
On 2018-01-08 08:17, James Tabor wrote:
@@ -711,7 +711,7 @@ typedef struct _ENABLE_TRACE_PARAMETERS {
PEVENT_FILTER_DESCRIPTOR EnableFilterDesc;
} ENABLE_TRACE_PARAMETERS, *PENABLE_TRACE_PARAMETERS;
-#define INVALID_PROCESSTRACE_HANDLE ((TRACEHANDLE)INVALID_HANDLE_VALUE)
+#define INVALID_P
We're done with that review and integrating it into the main repo is
next on the list, so archiving is fine.
Amine got Vadim set up with the new repo so he's already working off
that for new stuff.
-Thomas
On 2017-12-17 11:59, Alexander Shaposhnikov wrote:
We should probably notify him about th
Now the only problem is that neither our APIC nor MP HAL actually
work...
On 2017-12-12 18:31, David Quintana (gigaherz) wrote:
I have to agree that reducing it to 2 HALs (one ACPI with multiprocessor
and such, that maybe is also used for single-cpu systems with ACPI), and a
legacy one for syst
I'm a bit surprised that this works.
Don't we have those big "don't use the PCH for this file" warnings in
every guid.c? This library consists only of guid.c's :p
On 2017-12-09 13:04, Amine Khaldi wrote:
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=69005963fb4b1378f6a666c2b8b2483c22274
Ha, should have seen that. Thanks!
On 2017-11-03 16:09, Colin Finck wrote:
Am 03.11.2017 um 14:20 schrieb Thomas Faber:
If this is nontrivial I may have a look at it myself but someone would
need to point me to the right configuration/scripts please.
The Travis configuration is in
https
IIUC we currently always build rostests, but never rosapps in CI.
Would it be possible to analyze the changed paths instead and
* enable rostests iff modules/rostests/ or sdk/ was changed
* enable rosapps iff modules/rosapps/ or sdk/ was changed?
That should speed up builds that don't change rost
Or the annotation is just wrong and this parameter is not optional?
On 2017-10-31 16:07, encoded wrote:
Seems like this API has a 'feature' where by it throws exceptions if BytesRead
is null?
On Sun, Oct 29, 2017 at 8:02 AM, Jerome Gardou
wrote:
HI,
that doesn't look good, as shown by http
Ewww. Confluence is a nightmare.
On 2017-10-26 20:48, Timo Kreuzer wrote:
Last minute topic suggestion:
Discussion about using Confluence instead of MediaWiki.
Timo
Am 26.10.2017 um 19:16 schrieb Giannis Adamopoulos:
Hi all!
Let me invite you to the monthly status meeting taking place to
I'm wary of opening up pushing to master. If we really want a linear
history, it should be enforced. Accidents with version control happen
all the time (when was the last time the SVN pre-commit hook stopped you
from committing because you forgot to set eol-style?).
I wouldn't mind forcing the us
There's an easy benefit for them: it reduces their test matrix.
That's why you generally only support platforms that have value, rather
than supporting everything unless and until you have a concrete reason
to drop it.
On 2017-06-29 16:08, Hermès BÉLUSCA-MAÏTO wrote:
I’m wondering for which use
On 2017-06-19 18:29, hbelu...@svn.reactos.org wrote:
+/*
+ * Free it from the pool.
+ *
+ * We cannot use here ExFreePoolWithTag(..., OB_NAME_TAG); , because
+ * the object name may have been massaged during operation by different
+ * object parse r
On 2017-06-12 01:58, hbelu...@svn.reactos.org wrote:
+NTSTATUS
+SetupMoveFile(
+IN PCWSTR ExistingFileName,
+IN PCWSTR NewFileName,
+IN ULONG Flags)
+{
+NTSTATUS Status;
+IO_STATUS_BLOCK IoStatusBlock;
+OBJECT_ATTRIBUTES ObjectAttributes;
+PFILE_RENAME_INFORMATION Rena
On 2017-06-09 05:14, tthomp...@svn.reactos.org wrote:
> +RtlZeroMemory(&FilenameNoPath, sizeof(UNICODE_STRING));
> +FilenameNoPath.Buffer = Buffer;
> +FilenameNoPath.MaximumLength = MAX_PATH;
> +
RtlInitEmptyUnicodeString does this for you
On 2017-06-09 05:14, tthomp...@svn.reactos.o
On 2017-06-02 19:52, pha...@svn.reactos.org wrote:
+aDstNextStr = (char*)((DWORD)aDstNextStr + (DWORD)bItmLen);
DWORD cannot always fit a pointer. You want DWORD_PTR for this kind of
math (or simply use char *).
___
Ros-dev mailing list
Ros-d
On 2017-06-02 02:44, hbelu...@svn.reactos.org wrote:
@@ -341,7 +341,7 @@
}
InitializeObjectAttributes(&ObjectAttributes, &ServicesU, OBJ_CASE_INSENSITIVE, NULL, NULL);
-Status = NtCreateKey(&hServices, 0, &ObjectAttributes, 0, NULL, 0, NULL);
+Status = NtCreateKey(&hServic
I understand not making the change to how 1st stage deals with the
registry in trunk.
Why not the tool change though? Can't you have the new mkhive do the
exact same thing it does now, and do it in trunk? The smaller your
branch merge commit the easier it will be to avoid/pinpoint/fix
regressions.
On 2017-06-01 20:27, hbelu...@svn.reactos.org wrote:
/* EISA */
case EisaAdapter:
-
+{
/* Fixup information */
Interface = Eisa;
Bus = CmpTypeCount[EisaAdapter]++;
On 2017-06-02 02:00, hbelu...@svn.reactos.org wrote:
[MKHIVE]: Formatting changes only + sync back the names of the reg-inf
functions with the ones where they are coming from (aka. Wine's
setupapi/install.c).
Those two goals clearly conflict with either other. Either keep Wine's
function name
On 2017-06-01 20:37, hbelu...@svn.reactos.org wrote:
+if (!NT_SUCCESS(Status))
+{
+/* We failed, close all the opened handles and return */
+// NtClose(KeyHandle);
Please don't add commented-out code.
What is that supposed to even mean? "I was too lazy to test this"? "Al
Testbots seem to dislike this commit, looks like 3rd stage boot is
broken in some way. :(
On 2017-05-28 21:27, mjan...@svn.reactos.org wrote:
Author: mjansen
Date: Sun May 28 19:27:51 2017
New Revision: 74693
URL: http://svn.reactos.org/svn/reactos?rev=74693&view=rev
Log:
[KERNEL32] Initial im
On 2017-05-22 03:09, hbelu...@svn.reactos.org wrote:
--- branches/setup_improvements/base/setup/lib/arcname.c(added)
+++ branches/setup_improvements/base/setup/lib/arcname.c[iso-8859-1]
Mon May 22 01:09:35 2017
+PCSTR
+ArcGetNextTokenA(
+IN PCSTR ArcPath,
+OUT PANSI_S
On 2017-05-22 01:41, hbelu...@svn.reactos.org wrote:
+static PCVS_VERSION_INFO_STRUCT32
+VersionInfo32_FindChild(
+IN PCVS_VERSION_INFO_STRUCT32 info,
+IN PCWSTR szKey,
+IN UINT cbKey)
+{
+PCVS_VERSION_INFO_STRUCT32 child = VersionInfo32_Children(info);
+
+while ((ULONG_PTR)ch
On 2017-05-22 01:45, hbelu...@svn.reactos.org wrote:
> +BOOLEAN
> +NtPathToDiskPartComponents(
> +IN PCWSTR NtPath,
> +OUT PULONG pDiskNumber,
> +OUT PULONG pPartNumber,
> +OUT PCWSTR* PathComponent OPTIONAL)
> +{
> +ULONG DiskNumber, PartNumber;
> +PCWSTR Path;
> +
> +*
On 2017-05-22 01:36, hbelu...@svn.reactos.org wrote:
--- branches/setup_improvements/base/setup/lib/partlist.c [iso-8859-1]
(original)
+++ branches/setup_improvements/base/setup/lib/partlist.c [iso-8859-1]
Sun May 21 23:36:13 2017
@@ -1333,8 +1348,204 @@
RtlFreeHeap(ProcessHea
Hi,
comments inline.
On 2017-05-15 18:05, gadamopou...@svn.reactos.org wrote:
--- trunk/reactos/dll/win32/uxtheme/nonclient.c [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/uxtheme/nonclient.c [iso-8859-1] Mon May 15
16:05:14 2017
@@ -100,16 +100,7 @@
return hIcon;
}
-WCHAR *UserGe
Hi again,
some comments inline.
On 2017-05-15 03:59, hbelu...@svn.reactos.org wrote:
--- branches/setup_improvements/base/setup/usetup/osdetect.c[iso-8859-1]
(original)
+++ branches/setup_improvements/base/setup/usetup/osdetect.c[iso-8859-1]
Mon May 15 01:59:28 2017
@@ -19,6 +19,9 @@
On 2017-05-15 03:59, hbelu...@svn.reactos.org wrote:
Author: hbelusca
Date: Mon May 15 01:59:28 2017
New Revision: 74550
URL: http://svn.reactos.org/svn/reactos?rev=74550&view=rev
Log:
[USETUP]: Continue implementing the NT OS installation detector.
What remains to be done here, besides cleaning
Basic source control rule: please don't change things and move them
around at the same time. Unless your goal is to make sure noone reviews
your changes, of course.
Thanks.
-Thomas
On 2017-05-15 03:52, hbelu...@svn.reactos.org wrote:
Author: hbelusca
Date: Mon May 15 01:52:34 2017
New Revision:
We have a bin2c tool that would make including the boot logo much
nicer. You'll want to use something like the attached patch, and add
the bmp file as app/rosload/logo.bmp. Then just include "logo.h"
instead of the g_Logo array in rosload.c.
On 2017-05-15 03:38, i...@svn.reactos.org wrote:
Auth
Hey Hermès,
I'm fixing how the BCD hive is generated and this just showed up in an
svn blame for me.
Can you explain why this bcd_hive dependency is needed? I don't see the
command depending on the hive file.
Thanks,
Thomas
On 2015-09-09 21:48, hbelu...@svn.reactos.org wrote:
> Author: hbelusca
On 2017-05-13 18:13, hbelu...@svn.reactos.org wrote:
--- branches/setup_improvements/base/setup/usetup/filesup.c [iso-8859-1]
(original)
+++ branches/setup_improvements/base/setup/usetup/filesup.c [iso-8859-1]
Sat May 13 16:13:49 2017
@@ -524,14 +523,10 @@
&I
on 20 years old).
On 2017-05-08 04:11, Hermès BÉLUSCA-MAÏTO wrote:
Hi!
The assert is fixed (r74495). For ExAllocatePool, it would be better to change
them all at once in this file.
Hermès
-Message d'origine-
De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Thomas Fab
On 2017-05-07 20:15, hbelu...@svn.reactos.org wrote:
--- trunk/reactos/ntoskrnl/io/iomgr/driver.c[iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/io/iomgr/driver.c[iso-8859-1] Sun May 7
18:15:12 2017
@@ -884,7 +884,7 @@
PDEVICE_NODE DeviceNode;
PDRIVER_OBJECT DriverObject;
I said it's unclear how, not that it doesn't happen ;)
This change fixes boot on the machine mentioned in
https://jira.reactos.org/browse/CORE-12993
What happens is there's a bug in the BIOS that causes a ret to an
broken address, then we execute garbage and fault on a stack address.
The stack d
Hi,
Terminal Services is a relatively generic project that we might assign
almost any mentor to. Feel free to post any technical questions you
might have here or on #reactos-dev. If you'd like to talk to someone
privately, you may pick any of the devs that you see active on the
mailing list or IR
Hey,
from your list I'd be the likely mentor for at least the KMTest
project. Other projects might be supported by Pierre, Giannis or others.
To help pick your project I'd suggest you let us know more about your
interests and skills, as these are probably the most important factor.
A real-time d
Hello,
I've seen some of your contributions and am happy to hear you're
considering applying.
I'd be the most likely mentor candidate for a USB-related project, so
feel free to direct any technical questions toward me or show me
proposal drafts. The code you'd be working on will be structurally ve
On 2017-03-12 10:48, gadamopou...@svn.reactos.org wrote:
// *** IServiceProvider methods ***
HRESULT STDMETHODCALLTYPE CExplorerBand::QueryService(REFGUID guidService,
REFIID riid, void **ppvObject)
{
-UNIMPLEMENTED;
-return E_NOTIMPL;
+/* FIXME: we probably want to handle more se
I can tell you some possible next steps:
- x64: implement PAE support in the 32 bit kernel
- SMP: Implement resource translators and arbiters (I have some initial work
for this somewhere)
- Also SMP: build a CONFIG_SMP kernel (with some hack to use the regular HAL)
and debug any issues coming fro
On 2017-03-05 01:40, hbelu...@svn.reactos.org wrote:
+
+/*
+ * Check whether we actually just retrieved the needed buffer size
+ * because our previous local allocation did fail. If so, allocate
+ * a new buffer and retry again.
+ */
+if ( (!UnicodeQuerySet) && (*lpdwBuffe
On 2017-03-04 17:02, ek...@svn.reactos.org wrote:
> +Dacl = ExAllocatePool(PagedPool, AclLength);
Would you mind using ExAllocatePoolWithTag for new code please,
with no exceptions?
(I want to #define ExAllocatePool do_not_use_this_function at some point)
Thanks!
-Thomas
___
On 2017-02-24 02:52, hbelu...@svn.reactos.org wrote:
@@ -4419,12 +4422,31 @@
LPCWSTR UnSafepwc = pwc;
LPWORD UnSafepgi = pgi;
-if ((!UnSafepwc) && (!UnSafepgi)) return cwc;
-
-if ((UnSafepwc == NULL) || (UnSafepgi == NULL))
+/* Check for integer overflow */
+if (cwc & 0
On 2017-02-13 23:38, ek...@svn.reactos.org wrote:
> +_SEH2_TRY
> +{
> +Relations = RelationsData->Relations;
> +BufferSize = RelationsData->BufferSize;
> +Buffer = RelationsData->Buffer;
> +
> +ProbeForWrite(RelationsData->Buffer,
> + Rel
"ASSUME DS:.text" allows the assembler to use a smaller addressing
mode -- but then also (silently) refuses to use 32 bit memory operands.
E.g.
mov ds:[01234h], ax
mov ds:[012345678h], ax
becomes
6: a3 34 12mov%ax,0x1234
9: a3 78 56mov%ax,0x567
On 2017-01-13 05:06, jimta...@svn.reactos.org wrote:
VOID FASTCALL
IntSendChildNCPaint(PWND pWnd)
{
+ PWND Child;
+ HWND *List, *phWnd;
+
+ List = IntWinListChildren(UserGetDesktopWindow());
+ if ( List )
+ {
+ for (phWnd = List; *phWnd; ++phWnd)
+ {
+ Child = Vali
On 2016-12-22 11:39, jimta...@svn.reactos.org wrote:
+#ifndef _WIN32K_ / Fix CORE-2201.
+if (!(flags & DT_NOCLIP) )
+{
+ int hasClip;
+ hrgn = CreateRectRgn(0,0,0,0);
+ if (hrgn)
+ {
+ hasClip = GetClipRgn(hdc, hrgn);
+ // If the region to be
On 2016-12-07 01:10, gadamopou...@svn.reactos.org wrote:
[SHELL32] - Initialize the shell icon cache only when needed or when
FileIconInit is called (and not in the DllMain of shell32)
--- trunk/reactos/dll/win32/shell32/iconcache.cpp [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/
On 2016-11-14 17:19, hbelu...@svn.reactos.org wrote:
-hInstance = GetModuleHandleW(L"lsasrv.dll");
+hInstance = GetModuleHandleW(NULL);
Those are not equivalent at all.
___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailm
APITests should be named after a function.
And in particular, they can't be named the same as a Wine test for the
same module. This is currently causing result submission on Testbot to
fail, so please rename this test.
On 2016-11-09 23:13, mjan...@svn.reactos.org wrote:
Author: mjansen
Date: We
On 2016-11-02 12:24, pha...@svn.reactos.org wrote:
+/* Check if we had an unspecified address */
+if (Connection->AddressFile->Address.Address.IPv4Address !=
bindaddr.addr)
+{
+/* We did, so we need to copy back the address */
+Connection->AddressF
And what's wrong with just adding it to our headers?
On 2016-10-30 15:14, hbelu...@svn.reactos.org wrote:
Author: hbelusca
Date: Sun Oct 30 14:14:27 2016
New Revision: 73078
URL: http://svn.reactos.org/svn/reactos?rev=73078&view=rev
Log:
[BTRFS]: Fix compilation with MSVC too, as we don't have
On 2016-10-27 00:06, hbelu...@svn.reactos.org wrote:
-/* Sundry checkboxes */
+/* Other checkboxes */
Not sure how this "fixes" anything? Those are synonyms?
___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo
On 2016-10-21 23:15, janderw...@svn.reactos.org wrote:
> NTSTATUS
> +NTAPI
> +USBAudioGetDescriptor(
> +IN PDEVICE_OBJECT DeviceObject,
> +IN UCHAR DescriptorType,
> +IN ULONG DescriptorLength,
> +IN UCHAR DescriptorIndex,
> +IN LANGID LanguageId,
> +OUT PVOID *OutDescript
On 2016-10-19 01:45, hbelu...@svn.reactos.org wrote:
> --- trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/conwnd.c
> [iso-8859-1] (original)
> +++ trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/conwnd.c
> [iso-8859-1] Tue Oct 18 23:45:19 2016
> @@ -137,7 +137,7 @@
>
Hurray! Congrats on your first commit!
On 2016-10-10 08:38, pha...@svn.reactos.org wrote:
> Author: phater
> Date: Mon Oct 10 06:38:52 2016
> New Revision: 72948
>
> URL: http://svn.reactos.org/svn/reactos?rev=72948&view=rev
> Log:
> [MSAFD] Fix some return codes and better parameter checks base
ests
> + * LICENSE: GPLv2+ - See COPYING in the top level directory
> + * PURPOSE: Test for getaddrinfo
> + * PROGRAMMER: Thomas Faber
> + */
Thanks for the credit, but I don't think I deserve it ;)
___
Ros-dev ma
You should be able to simply add an
Options=...
line to the [Setup] section in boot/bootdata/bootcd.ini to modify
the setup's freeldr options. That file becomes freeldr.ini in the root
dir of the BootCD.
On 2016-09-27 12:21, Love Nystrom wrote:
> Good afternoon gentlemen..
>
> Can anyone tell me
't return the correct LastError when
>> you pass an invalid path like "C:C:\Windows"
>> Our CreateFile returns ERROR_INVALID_NAME, wines PATH_NOT_FOUND or
>> FILE_NOT_FOUND**
>>
>> Guess we need a test for CreateFile...
>>
>> Am 24.09.2016 um
. I
> committed a better fix.
>
>
> Am 24.09.2016 um 13:56 schrieb Thomas Faber:
>> Could you elaborate on what makes it broken? Link to a bug perhaps?
>>
>> On 2016-09-24 13:39, cwitt...@svn.reactos.org wrote:
>>> Author: cwittich
>>> Date:
Could you elaborate on what makes it broken? Link to a bug perhaps?
On 2016-09-24 13:39, cwitt...@svn.reactos.org wrote:
> Author: cwittich
> Date: Sat Sep 24 11:39:17 2016
> New Revision: 72792
>
> URL: http://svn.reactos.org/svn/reactos?rev=72792&view=rev
> Log:
> [CRYPTNET] disable broken code
On 2016-09-21 01:43, hbelu...@svn.reactos.org wrote:
> @@ -300,25 +268,53 @@
> * @implemented
> */
> NTSTATUS
> -WINAPI
> -LsaRegisterLogonProcess(PLSA_STRING LsaLogonProcessName,
> -PHANDLE Handle,
> -PLSA_OPERATIONAL_MODE OperationalMode)
> -{
On 2016-09-18 16:24, janderw...@svn.reactos.org wrote:
> +NTSTATUS
> +SubmitUrbSync(
> +IN PKSDEVICE Device,
> +IN PURB Urb)
> +{
> +PIRP Irp;
> +KEVENT Event;
> +PDEVICE_EXTENSION DeviceExtension;
> +IO_STATUS_BLOCK IoStatus;
> +PIO_STACK_LOCATION IoStack;
> +NTSTAT
I've seen like 4 people change this stuff recently and not one of them
got it 100% right.
So here are the rules for how to use probes and SEH:
* Probe pointers before accessing them. This ensures you're not reading
kernel mode memory (and does pretty much nothing else)
* Never access user mode po
On 2016-09-06 18:47, gedmur...@svn.reactos.org wrote:
> @@ -116,12 +150,21 @@
> InitializeListHead(&Filter->PortList.mList);
> Filter->PortList.mCount = 0;
>
> +/* We got this far, assume success from here */
> +Status = STATUS_SUCCESS;
> +
> /* Check if the caller requeste
On 2016-09-06 18:59, gedmur...@svn.reactos.org wrote:
> +NTSTATUS
> +HandleLoadUnloadIoctl(_In_ PDEVICE_OBJECT DeviceObject,
> + _Inout_ PIRP Irp)
> +{
> +PIO_STACK_LOCATION StackPtr;
> +UNICODE_STRING Name;
> +PFILTER_NAME FilterName;
> +ULONG BufferLength;
> +
On 2016-08-20 11:43, gadamopou...@svn.reactos.org wrote:
> --- trunk/reactos/dll/win32/shell32/shlfileop.cpp [iso-8859-1] (original)
> +++ trunk/reactos/dll/win32/shell32/shlfileop.cpp [iso-8859-1] Sat Aug 20
> 09:43:09 2016
> @@ -1480,6 +1480,19 @@
> return 0;
> }
>
On 2016-08-10 00:10, gedmur...@svn.reactos.org wrote:
> +/* Calc and allocate a buffer to hold our filter name */
> +BufferLength = wcslen(lpFilterName) * sizeof(WCHAR);
> +FilterName = RtlAllocateHeap(GetProcessHeap(),
> + 0,
> +
On 2016-07-08 19:52, z...@svn.reactos.org wrote:
> --- branches/GSoC_2016/lwIP-tcpip/drivers/network/tcpip/address.c
> [iso-8859-1] (original)
> +++ branches/GSoC_2016/lwIP-tcpip/drivers/network/tcpip/address.c
> [iso-8859-1] Fri Jul 8 17:52:42 2016
> @@ -33,6 +33,8 @@
> static LIST_ENT
Can't event viewer load those icons from shell32 (much like regedit
should)?
On 2016-07-06 01:42, hbelu...@svn.reactos.org wrote:
> Author: hbelusca
> Date: Tue Jul 5 23:42:40 2016
> New Revision: 71829
>
> URL: http://svn.reactos.org/svn/reactos?rev=71829&view=rev
> Log:
> [CLIPBRD]: Use NULL f
Comments inline.
On 2016-07-05 20:35, z...@svn.reactos.org wrote:
> --- branches/GSoC_2016/lwIP-tcpip/drivers/network/tcpip/address.c
> [iso-8859-1] (original)
> +++ branches/GSoC_2016/lwIP-tcpip/drivers/network/tcpip/address.c
> [iso-8859-1] Tue Jul 5 18:35:17 2016
> @@ -357,15 +356,15
On 2016-06-29 02:38, hbelu...@svn.reactos.org wrote:
> +if (!CharCount && (Result == ERROR_INSUFFICIENT_BUFFER))
> +{
> +/* Reallocate the buffer with double size */
> +dwSize *= 2;
> +tmp = (PWSTR)HeapReAlloc(GetProcessHeap(), 0, lpTargetPath, dwSize *
> sizeof(WCH
On 2016-06-28 21:21, hbelu...@svn.reactos.org wrote:
> --- trunk/reactos/base/system/subst/subst.c [iso-8859-1] (original)
> +++ trunk/reactos/base/system/subst/subst.c [iso-8859-1] Tue Jun 28
> 19:21:08 2016
> @@ -75,81 +75,71 @@
> if (_tcslen(Drive) > 2)
> return FALSE;
>
> -
On 2016-06-15 12:10, z...@svn.reactos.org wrote:
--- branches/GSoC_2016/lwIP/drivers/network/tcpip/main.c[iso-8859-1]
(original)
+++ branches/GSoC_2016/lwIP/drivers/network/tcpip/main.c[iso-8859-1]
Wed Jun 15 19:10:40 2016
@@ -384,7 +384,9 @@
Quickie:
Irp->IoStatus.Statu
On 2016-06-09 12:20, Yonggang Chen wrote:
> After building ReactOS and Rostests successfully, I can't debug CoInitialize
> function through Visual Studio 2015. It seems Visual Studio thinks I'm using
> their CoInitialize of Windows kernel.
That's because you _are_ using Windows's version! :)
The "
atomixos.com <http://www.atomixos.com>*
>
>
> On Mon, Jun 6, 2016 at 1:02 AM, Thomas Faber
> wrote:
>
>> On 2016-06-05 14:40, apriyadar...@svn.reactos.org wrote:
>>> Author: apriyadarshi
>>> Date: Sun Jun 5 12:40:49 2016
>>> New Revision: 715
On 2016-06-05 14:40, apriyadar...@svn.reactos.org wrote:
> Author: apriyadarshi
> Date: Sun Jun 5 12:40:49 2016
> New Revision: 71530
>
> URL: http://svn.reactos.org/svn/reactos?rev=71530&view=rev
> Log:
> Added INF File for driver installation with minimal configuration.
> Device Detection and I
On 2016-06-05 01:29, hbelu...@svn.reactos.org wrote:
> -rcDesk.left = GetSystemMetrics(SM_XVIRTUALSCREEN);
> -rcDesk.top = GetSystemMetrics(SM_YVIRTUALSCREEN);
> -rcDesk.right = rcDesk.left + GetSystemMetrics(SM_CXVIRTUALSCREEN);
> -rcDesk.bottom = rcDesk.top + GetSystemMetrics(SM_C
1 - 100 of 258 matches
Mail list logo
