svn commit: r678360 - in /james/server/trunk: experimental-seda-imap-function/src/test/resources/org/apache/james/test/functional/imap/scripts/ imap-codec-library/src/main/java/org/apache/james/imapse

2008-07-21 Thread rdonkin
Author: rdonkin Date: Mon Jul 21 01:05:34 2008 New Revision: 678360 URL: http://svn.apache.org/viewvc?rev=678360&view=rev Log: Sort disposition parameters to ensure consistency across JVMs Modified: james/server/trunk/experimental-seda-imap-function/src/test/resources/org/apache/james/test/f

Re: [mime4j] newlines and parsing of nested (encoded) rfc822 messages

2008-07-21 Thread Robert Burrell Donkin
On Sun, Jul 20, 2008 at 9:08 PM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: > Robert Burrell Donkin ha scritto: >> >> On Sat, Jul 19, 2008 at 5:29 PM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: >>> >>> Oleg Kalnichevski ha scritto: Robert Burrell Donkin wrote: > > On 7/18/08, Stef

Re: [mime4j] newlines and parsing of nested (encoded) rfc822 messages

2008-07-21 Thread Stefano Bagnara
Robert Burrell Donkin ha scritto: On Sun, Jul 20, 2008 at 9:08 PM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: Robert Burrell Donkin ha scritto: On Sat, Jul 19, 2008 at 5:29 PM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: Oleg Kalnichevski ha scritto: Robert Burrell Donkin wrote: On 7/18/08, S

[jira] Created: (MIME4J-61) ArrayIndexOutOfBoundsException in CodecUtil.encodeQuotedPrintableBinary for large inputs

2008-07-21 Thread Niklas Therning (JIRA)
ArrayIndexOutOfBoundsException in CodecUtil.encodeQuotedPrintableBinary for large inputs Key: MIME4J-61 URL: https://issues.apache.org/jira/browse/MIME4J-61 Proj

svn commit: r678373 - in /james/mime4j/trunk/src: main/java/org/apache/james/mime4j/util/CodecUtil.java test/java/org/apache/james/mime4j/util/CodecUtilTest.java

2008-07-21 Thread niklas
Author: niklas Date: Mon Jul 21 02:23:31 2008 New Revision: 678373 URL: http://svn.apache.org/viewvc?rev=678373&view=rev Log: Fix for MIME4J-61: Large inputs will not cause ArrayIndexOutOfBoundsException anymore when encoded using quoted printable. Modified: james/mime4j/trunk/src/main/java/

[jira] Commented: (MIME4J-59) Quoted-Printable encoded body no more decoded

2008-07-21 Thread Stefano Bagnara (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615171#action_12615171 ] Stefano Bagnara commented on MIME4J-59: --- Thank you Niklas, this is indeed the issue.

[jira] Closed: (MIME4J-61) ArrayIndexOutOfBoundsException in CodecUtil.encodeQuotedPrintableBinary for large inputs

2008-07-21 Thread Niklas Therning (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niklas Therning closed MIME4J-61. - > ArrayIndexOutOfBoundsException in CodecUtil.encodeQuotedPrintableBinary for > large inputs > --

[jira] Assigned: (MIME4J-61) ArrayIndexOutOfBoundsException in CodecUtil.encodeQuotedPrintableBinary for large inputs

2008-07-21 Thread Niklas Therning (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niklas Therning reassigned MIME4J-61: - Assignee: Niklas Therning > ArrayIndexOutOfBoundsException in CodecUtil.encodeQuotedPrinta

[jira] Resolved: (MIME4J-61) ArrayIndexOutOfBoundsException in CodecUtil.encodeQuotedPrintableBinary for large inputs

2008-07-21 Thread Niklas Therning (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niklas Therning resolved MIME4J-61. --- Resolution: Fixed A fix has been comitted > ArrayIndexOutOfBoundsException in CodecUtil.encod

[jira] Created: (MIME4J-62) Unnecessary qp encoding of SPACE and TAB characters in CodecUtil

2008-07-21 Thread Niklas Therning (JIRA)
Unnecessary qp encoding of SPACE and TAB characters in CodecUtil Key: MIME4J-62 URL: https://issues.apache.org/jira/browse/MIME4J-62 Project: Mime4j Issue Type: Bug Affects

[jira] Commented: (MIME4J-59) Quoted-Printable encoded body no more decoded

2008-07-21 Thread Stefano Bagnara (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615176#action_12615176 ] Stefano Bagnara commented on MIME4J-59: --- I see you're working on this: I had to chang

[jira] Commented: (MIME4J-59) Quoted-Printable encoded body no more decoded

2008-07-21 Thread Niklas Therning (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615179#action_12615179 ] Niklas Therning commented on MIME4J-59: --- I just checked in a fix for the ArrayIndexOut

[jira] Created: (MIME4J-63) QuotedPrintable encoder fails on 8bit bytes

2008-07-21 Thread Stefano Bagnara (JIRA)
QuotedPrintable encoder fails on 8bit bytes --- Key: MIME4J-63 URL: https://issues.apache.org/jira/browse/MIME4J-63 Project: Mime4j Issue Type: Bug Affects Versions: 0.4 Reporter: Stefa

[jira] Updated: (MIME4J-63) QuotedPrintable encoder fails on 8bit bytes

2008-07-21 Thread Stefano Bagnara (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefano Bagnara updated MIME4J-63: -- Attachment: qp-body_decoded_1.txt qp-body_decoded.xml qp-body.msg

[jira] Commented: (MIME4J-63) QuotedPrintable encoder fails on 8bit bytes

2008-07-21 Thread Stefano Bagnara (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615183#action_12615183 ] Stefano Bagnara commented on MIME4J-63: --- I had to change CodecUtil this way, maybe it

[jira] Commented: (MIME4J-59) Quoted-Printable encoded body no more decoded

2008-07-21 Thread Niklas Therning (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615182#action_12615182 ] Niklas Therning commented on MIME4J-59: --- I think int nextUnsigned = next & 0xff;

[jira] Commented: (MIME4J-59) Quoted-Printable encoded body no more decoded

2008-07-21 Thread Stefano Bagnara (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615187#action_12615187 ] Stefano Bagnara commented on MIME4J-59: --- I opened MIME4J-63 for this. If you review it

[jira] Commented: (MIME4J-59) Quoted-Printable encoded body no more decoded

2008-07-21 Thread Niklas Therning (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615186#action_12615186 ] Niklas Therning commented on MIME4J-59: --- Or maybe it should be int nextUnsigned =

[jira] Assigned: (MIME4J-59) Quoted-Printable encoded body no more decoded

2008-07-21 Thread Niklas Therning (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niklas Therning reassigned MIME4J-59: - Assignee: Niklas Therning > Quoted-Printable encoded body no more decoded > --

[jira] Updated: (MIME4J-60) Configurable strategy for line delimiters

2008-07-21 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski updated MIME4J-60: Attachment: newlinestrat.patch I would like to propose for your consideration a somewhat dif

[jira] Commented: (MIME4J-59) Quoted-Printable encoded body no more decoded

2008-07-21 Thread Niklas Therning (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615190#action_12615190 ] Niklas Therning commented on MIME4J-59: --- Hmmm, Stefano, I think you have attached the

svn commit: r678382 - /james/mime4j/trunk/src/test/java/org/apache/james/mime4j/message/MessageParserTest.java

2008-07-21 Thread niklas
Author: niklas Date: Mon Jul 21 03:15:41 2008 New Revision: 678382 URL: http://svn.apache.org/viewvc?rev=678382&view=rev Log: Saved txt files will now use the mime charset specified for the body part instead of the Java default. Modified: james/mime4j/trunk/src/test/java/org/apache/james/mi

svn commit: r678383 - in /james/mime4j/trunk/src: main/java/org/apache/james/mime4j/message/ test/resources/testmsgs/

2008-07-21 Thread niklas
Author: niklas Date: Mon Jul 21 03:20:00 2008 New Revision: 678383 URL: http://svn.apache.org/viewvc?rev=678383&view=rev Log: Resolved MIME4J-59: The TextBody instances created when parsing a message will now handle the decoding/encoding of qp and base64 bodies automatically as it was done in Mi

[jira] Resolved: (MIME4J-59) Quoted-Printable encoded body no more decoded

2008-07-21 Thread Niklas Therning (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niklas Therning resolved MIME4J-59. --- Resolution: Fixed I've added the test message and committed a fix for this issue. The fix make

[jira] Assigned: (MIME4J-63) QuotedPrintable encoder fails on 8bit bytes

2008-07-21 Thread Niklas Therning (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niklas Therning reassigned MIME4J-63: - Assignee: Niklas Therning > QuotedPrintable encoder fails on 8bit bytes >

svn commit: r678387 - in /james/mime4j/trunk/src: main/java/org/apache/james/mime4j/util/CodecUtil.java test/java/org/apache/james/mime4j/util/CodecUtilTest.java

2008-07-21 Thread niklas
Author: niklas Date: Mon Jul 21 03:36:57 2008 New Revision: 678387 URL: http://svn.apache.org/viewvc?rev=678387&view=rev Log: Resolved MIME4J-63: CodecUtil.encodeQuotedPrintableBinary() now handles 8bit bytes as expected. Modified: james/mime4j/trunk/src/main/java/org/apache/james/mime4j/uti

[jira] Resolved: (MIME4J-63) QuotedPrintable encoder fails on 8bit bytes

2008-07-21 Thread Niklas Therning (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niklas Therning resolved MIME4J-63. --- Resolution: Fixed A fix and test case has been committed. > QuotedPrintable encoder fails on

Re: [mime4j] newlines and parsing of nested (encoded) rfc822 messages

2008-07-21 Thread Robert Burrell Donkin
On Mon, Jul 21, 2008 at 10:11 AM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: > Robert Burrell Donkin ha scritto: >> >> On Sun, Jul 20, 2008 at 9:08 PM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: >>> >>> Robert Burrell Donkin ha scritto: On Sat, Jul 19, 2008 at 5:29 PM, Stefano Bagnara <[E

[jira] Updated: (MIME4J-59) Quoted-Printable encoded body no more decoded

2008-07-21 Thread Stefano Bagnara (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefano Bagnara updated MIME4J-59: -- Attachment: qp-body_decoded_1.txt Previously attached the wrong file. > Quoted-Printable encode

[jira] Updated: (MIME4J-59) Quoted-Printable encoded body no more decoded

2008-07-21 Thread Stefano Bagnara (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefano Bagnara updated MIME4J-59: -- Attachment: (was: simple-7bit-body_decoded_1.txt) > Quoted-Printable encoded body no more de

[jira] Commented: (MIME4J-60) Configurable strategy for line delimiters

2008-07-21 Thread Stefano Bagnara (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615210#action_12615210 ] Stefano Bagnara commented on MIME4J-60: --- What does the "int" returned by isLineDelimit

[jira] Commented: (MIME4J-59) Quoted-Printable encoded body no more decoded

2008-07-21 Thread Stefano Bagnara (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615211#action_12615211 ] Stefano Bagnara commented on MIME4J-59: --- Great work Niklas! It works like a charm!! :-

[jira] Commented: (MIME4J-62) Unnecessary qp encoding of SPACE and TAB characters in CodecUtil

2008-07-21 Thread Stefano Bagnara (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615214#action_12615214 ] Stefano Bagnara commented on MIME4J-62: --- Where does the current binaryQuotedPrintable

[jira] Issue Comment Edited: (MIME4J-60) Configurable strategy for line delimiters

2008-07-21 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615216#action_12615216 ] olegk edited comment on MIME4J-60 at 7/21/08 4:34 AM: -- > Wh

[jira] Commented: (MIME4J-60) Configurable strategy for line delimiters

2008-07-21 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615216#action_12615216 ] Oleg Kalnichevski commented on MIME4J-60: - > What does the "int" returned by isLineD

[jira] Commented: (MIME4J-60) Configurable strategy for line delimiters

2008-07-21 Thread Stefano Bagnara (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615220#action_12615220 ] Stefano Bagnara commented on MIME4J-60: --- Ok, I see javadocs now. I was looking at the

Opinions about MIME4J-54 (boundaries should only be found at the beginning of a line)

2008-07-21 Thread Stefano Bagnara
I opened this issue a week ago: http://issues.apache.org/jira/browse/MIME4J-54 Given the recent discussions about strict parsing and my view of the RFC compliance vs real world use case, before spending time in trying to fix this I would like to know if there is any harm in fixing this. Pleas

Re: [mime4j] newlines and parsing of nested (encoded) rfc822 messages

2008-07-21 Thread Stefano Bagnara
Robert Burrell Donkin ha scritto: On Mon, Jul 21, 2008 at 10:11 AM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: Robert Burrell Donkin ha scritto: On Sun, Jul 20, 2008 at 9:08 PM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: Robert Burrell Donkin ha scritto: On Sat, Jul 19, 2008 at 5:29 PM, Stefa

[jira] Commented: (MIME4J-60) Configurable strategy for line delimiters

2008-07-21 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615222#action_12615222 ] Oleg Kalnichevski commented on MIME4J-60: - Ok, I see a flaw in my logic now. There i

[jira] Commented: (MIME4J-60) Configurable strategy for line delimiters

2008-07-21 Thread Stefano Bagnara (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615229#action_12615229 ] Stefano Bagnara commented on MIME4J-60: --- Sorry if I've not been able to explain the fl

[jira] Commented: (MIME4J-60) Configurable strategy for line delimiters

2008-07-21 Thread Stefano Bagnara (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615232#action_12615232 ] Stefano Bagnara commented on MIME4J-60: --- FYI Javamail com.sun.mail.util.LineInputStrea

[jira] Commented: (MIME4J-60) Configurable strategy for line delimiters

2008-07-21 Thread Stefano Bagnara (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615236#action_12615236 ] Stefano Bagnara commented on MIME4J-60: --- Another source: http://developer.apple.com/do

[Mime4j] 24 Test Failures

2008-07-21 Thread Robert Burrell Donkin
i'm dispirited and disappointed. this is a complete mess. - robert - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [Mime4j] 24 Test Failures

2008-07-21 Thread Stefano Bagnara
Robert Burrell Donkin ha scritto: i'm dispirited and disappointed. this is a complete mess. - robert Can you list them? I have 11 failures. 8 of them are about boundaries and you can see there is an open thread (I asked you also if you would have preferred me to remove them and attach to J

Re: [Mime4j] 24 Test Failures

2008-07-21 Thread Robert Burrell Donkin
On Mon, Jul 21, 2008 at 2:37 PM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: > Robert Burrell Donkin ha scritto: > PS: "dispirited" and "disappointed" and "this is a complete mess" seems a > bit out of contest in a collaborative environment. i am disappointed that mime4j cannot be build and that

[jira] Commented: (MIME4J-62) Unnecessary qp encoding of SPACE and TAB characters in CodecUtil

2008-07-21 Thread Robert Burrell Donkin (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615250#action_12615250 ] Robert Burrell Donkin commented on MIME4J-62: - IIRC I created them from scratch

Re: [Mime4j] 24 Test Failures

2008-07-21 Thread Stefano Bagnara
Robert Burrell Donkin ha scritto: On Mon, Jul 21, 2008 at 2:37 PM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: Robert Burrell Donkin ha scritto: PS: "dispirited" and "disappointed" and "this is a complete mess" seems a bit out of contest in a collaborative environment. i am disappointed th

[jira] Commented: (MIME4J-62) Unnecessary qp encoding of SPACE and TAB characters in CodecUtil

2008-07-21 Thread Stefano Bagnara (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615252#action_12615252 ] Stefano Bagnara commented on MIME4J-62: --- Robert, the escaping of SPACE and TABS every

[jira] Commented: (MIME4J-62) Unnecessary qp encoding of SPACE and TAB characters in CodecUtil

2008-07-21 Thread Stefano Bagnara (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615253#action_12615253 ] Stefano Bagnara commented on MIME4J-62: --- And the SPACE and TABS special rule is not ab

svn commit: r678433 - in /james/mime4j/trunk/src/test/resources/testmsgs: qp-body.msg qp-body.xml qp-body_decoded.xml qp-body_decoded_1.txt

2008-07-21 Thread bago
Author: bago Date: Mon Jul 21 07:22:53 2008 New Revision: 678433 URL: http://svn.apache.org/viewvc?rev=678433&view=rev Log: Make sure test resources are committed with mime-type=application/octet-stream so their line endings are not altered by SVN. Modified: james/mime4j/trunk/src/test/resou

svn commit: r678435 - in /james/mime4j/trunk/src/test/resources/testmsgs: bad-newlines-multiple-parts-base64.xml bad-newlines-multiple-parts-base64_decoded.xml bad-newlines-multiple-parts.xml

2008-07-21 Thread bago
Author: bago Date: Mon Jul 21 07:24:15 2008 New Revision: 678435 URL: http://svn.apache.org/viewvc?rev=678435&view=rev Log: Commit updated expected result (they are not what I would expect from mime4j, but people is scared by failing tests, so let's make them pass) (this will probably change as

[jira] Updated: (MIME4J-60) Configurable strategy for line delimiters

2008-07-21 Thread Stefano Bagnara (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefano Bagnara updated MIME4J-60: -- Attachment: newlines-tests.zip Attaching tests for mixed newlines expectations. No need to have

[jira] Updated: (MIME4J-54) boundaries should only be found at the beginning of a line

2008-07-21 Thread Stefano Bagnara (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefano Bagnara updated MIME4J-54: -- Attachment: boundary-tests.zip Attached a couple of tests about misplaced boundaries so we can r

svn commit: r678439 - /james/mime4j/trunk/src/test/resources/testmsgs/

2008-07-21 Thread bago
Author: bago Date: Mon Jul 21 07:30:27 2008 New Revision: 678439 URL: http://svn.apache.org/viewvc?rev=678439&view=rev Log: Remove bug-proving tests (moved them to MIME4J-54 and MIME4J-60) Removed: james/mime4j/trunk/src/test/resources/testmsgs/intermediate-boundaries.msg james/mime4j/tru

Re: [Mime4j] 24 Test Failures

2008-07-21 Thread Robert Burrell Donkin
On Mon, Jul 21, 2008 at 3:09 PM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: > Robert Burrell Donkin ha scritto: >> >> On Mon, Jul 21, 2008 at 2:37 PM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: >>> >>> Robert Burrell Donkin ha scritto: >> >> >> >>> PS: "dispirited" and "disappointed" and "this is

Re: [Mime4j] 24 Test Failures

2008-07-21 Thread Robert Burrell Donkin
On Mon, Jul 21, 2008 at 2:37 PM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: > Robert Burrell Donkin ha scritto: >> >> i'm dispirited and disappointed. this is a complete mess. >> >> - robert > > Can you list them? >Failed tests: > > testBinaryAttachmentLenient(org.apache.james.mime4j.message.Mes

Re: [Mime4j] 24 Test Failures

2008-07-21 Thread Robert Burrell Donkin
On Mon, Jul 21, 2008 at 2:37 PM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: > The other 3 I see are in MessageWriteToTest > - testBinaryAttachmentLenient > - testBinaryAttachmentStrictError > - testBinaryAttachmentStrictIgnore > > They have been broken while Niklas fixed the quoted-printable dec

Re: [Mime4j] 24 Test Failures

2008-07-21 Thread Stefano Bagnara
Robert Burrell Donkin ha scritto: On Mon, Jul 21, 2008 at 3:09 PM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: Robert Burrell Donkin ha scritto: On Mon, Jul 21, 2008 at 2:37 PM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: Robert Burrell Donkin ha scritto: PS: "dispirited" and "disappointed"

Re: [Mime4j] 24 Test Failures

2008-07-21 Thread Stefano Bagnara
I just removed some message following your suggestion. About the 3 MessageWriteToTest test failing I notice that there is an issue with the QuotedPrintableInputStream(or the output stream, I don't know). The fact is that at any roundtrip we end with a =0D=0A added to the end of the quoted prin

[jira] Commented: (MIME4J-62) Unnecessary qp encoding of SPACE and TAB characters in CodecUtil

2008-07-21 Thread Robert Burrell Donkin (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615268#action_12615268 ] Robert Burrell Donkin commented on MIME4J-62: - binaryQuotedPrintable is intended

Re: [Mime4j] 24 Test Failures

2008-07-21 Thread Stefano Bagnara
Robert Burrell Donkin ha scritto: On Mon, Jul 21, 2008 at 2:37 PM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: The other 3 I see are in MessageWriteToTest - testBinaryAttachmentLenient - testBinaryAttachmentStrictError - testBinaryAttachmentStrictIgnore They have been broken while Niklas fixe

Re: [Mime4j] 24 Test Failures

2008-07-21 Thread Robert Burrell Donkin
On Mon, Jul 21, 2008 at 4:06 PM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: > Robert Burrell Donkin ha scritto: >> >> On Mon, Jul 21, 2008 at 3:09 PM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: >>> >>> Robert Burrell Donkin ha scritto: On Mon, Jul 21, 2008 at 2:37 PM, Stefano Bagnara <[EM

[jira] Commented: (MIME4J-62) Unnecessary qp encoding of SPACE and TAB characters in CodecUtil

2008-07-21 Thread Stefano Bagnara (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615274#action_12615274 ] Stefano Bagnara commented on MIME4J-62: --- MY OPINION is that rules #3, #4 and #5 are no

Re: [Mime4j] 24 Test Failures

2008-07-21 Thread Niklas Therning
Stefano Bagnara wrote: So you prefer to not have bug-proving tests. I just understood this, but this is simply a matter of preference, so rather than disappoint each other we can discuss a common way to deal with this. Most of them have opened threads/jiras waiting for more input, feel free t

Re: [Mime4j] 24 Test Failures

2008-07-21 Thread Stefano Bagnara
Robert Burrell Donkin ha scritto: On Mon, Jul 21, 2008 at 4:06 PM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: Robert Burrell Donkin ha scritto: On Mon, Jul 21, 2008 at 3:09 PM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: Robert Burrell Donkin ha scritto: i'm dispirited because i finally have a

Re: [Mime4j] 24 Test Failures

2008-07-21 Thread Stefano Bagnara
Niklas Therning ha scritto: Stefano Bagnara wrote: So you prefer to not have bug-proving tests. I just understood this, but this is simply a matter of preference, so rather than disappoint each other we can discuss a common way to deal with this. Most of them have opened threads/jiras waiting

[jira] Commented: (MIME4J-62) Unnecessary qp encoding of SPACE and TAB characters in CodecUtil

2008-07-21 Thread Niklas Therning (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615278#action_12615278 ] Niklas Therning commented on MIME4J-62: --- It's not trivial to implement rule #3. Seems

[jira] Commented: (MIME4J-62) Unnecessary qp encoding of SPACE and TAB characters in CodecUtil

2008-07-21 Thread Robert Burrell Donkin (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615279#action_12615279 ] Robert Burrell Donkin commented on MIME4J-62: - IMHO The correct behaviour is to

[jira] Commented: (MIME4J-62) Unnecessary qp encoding of SPACE and TAB characters in CodecUtil

2008-07-21 Thread Stefano Bagnara (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615282#action_12615282 ] Stefano Bagnara commented on MIME4J-62: --- I agree that the specific encoder for the tex

[jira] Commented: (MIME4J-62) Unnecessary qp encoding of SPACE and TAB characters in CodecUtil

2008-07-21 Thread Robert Burrell Donkin (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615286#action_12615286 ] Robert Burrell Donkin commented on MIME4J-62: - Niklas - I'm in general agreement

[jira] Updated: (MIME4J-62) Unnecessary qp encoding of SPACE and TAB characters in CodecUtil

2008-07-21 Thread Robert Burrell Donkin (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Burrell Donkin updated MIME4J-62: Attachment: TextAttachmentEncodingTest.java These tests capture well the correct beh

[jira] Commented: (MIME4J-62) Unnecessary qp encoding of SPACE and TAB characters in CodecUtil

2008-07-21 Thread Niklas Therning (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615289#action_12615289 ] Niklas Therning commented on MIME4J-62: --- Stefano, the extra CRLF you see come from Tem

[jira] Commented: (MIME4J-54) boundaries should only be found at the beginning of a line

2008-07-21 Thread Niklas Therning (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615294#action_12615294 ] Niklas Therning commented on MIME4J-54: --- IMO, boundaries should only be matched at the

Re: Opinions about MIME4J-54 (boundaries should only be found at the beginning of a line)

2008-07-21 Thread Niklas Therning
Stefano Bagnara wrote: I opened this issue a week ago: http://issues.apache.org/jira/browse/MIME4J-54 Given the recent discussions about strict parsing and my view of the RFC compliance vs real world use case, before spending time in trying to fix this I would like to know if there is any harm

[jira] Commented: (MIME4J-62) Unnecessary qp encoding of SPACE and TAB characters in CodecUtil

2008-07-21 Thread Stefano Bagnara (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615297#action_12615297 ] Stefano Bagnara commented on MIME4J-62: --- I'm not sure "_" is correct for SPACE in stan

svn commit: r678469 - /james/mime4j/trunk/src/test/resources/testmsgs/

2008-07-21 Thread bago
Author: bago Date: Mon Jul 21 09:39:26 2008 New Revision: 678469 URL: http://svn.apache.org/viewvc?rev=678469&view=rev Log: Make sure we don't have an eol-style native. Maybe this still changes the resources even when an application/octet-stream mime type is there Modified: james/mime4j/tru

Re: svn commit: r678469 - /james/mime4j/trunk/src/test/resources/testmsgs/

2008-07-21 Thread Stefano Bagnara
Robert, I tested mime4j on people.apache.org and I think I found the issue with many failure you saw under unix. svn:eol-style was still altering the content even if I added the svn:mime-type application/octet-stream to every test resource. Please check that this commit fixed your issue. (Th

[jira] Commented: (MIME4J-62) Unnecessary qp encoding of SPACE and TAB characters in CodecUtil

2008-07-21 Thread Robert Burrell Donkin (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615307#action_12615307 ] Robert Burrell Donkin commented on MIME4J-62: - Niklas - that sounds like a good

Re: svn commit: r678469 - /james/mime4j/trunk/src/test/resources/testmsgs/

2008-07-21 Thread Robert Burrell Donkin
On Mon, Jul 21, 2008 at 5:43 PM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: > > Robert, > > I tested mime4j on people.apache.org and I think I found the issue with many > failure you saw under unix. > svn:eol-style was still altering the content even if I added the > svn:mime-type application/octet

svn commit: r678494 - /james/server/trunk/stage/org.apache.james/jars/apache-mime4j-0.4-SNAPSHOT.jar

2008-07-21 Thread rdonkin
Author: rdonkin Date: Mon Jul 21 10:41:47 2008 New Revision: 678494 URL: http://svn.apache.org/viewvc?rev=678494&view=rev Log: Upgrade to latest Mime4J Modified: james/server/trunk/stage/org.apache.james/jars/apache-mime4j-0.4-SNAPSHOT.jar Modified: james/server/trunk/stage/org.apache.jame

Re: svn commit: r678469 - /james/mime4j/trunk/src/test/resources/testmsgs/

2008-07-21 Thread Robert Burrell Donkin
On Mon, Jul 21, 2008 at 6:06 PM, Robert Burrell Donkin <[EMAIL PROTECTED]> wrote: > On Mon, Jul 21, 2008 at 5:43 PM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: >> >> Robert, >> >> I tested mime4j on people.apache.org and I think I found the issue with many >> failure you saw under unix. >> svn:eol-

svn commit: r678517 - /james/mime4j/trunk/src/main/java/org/apache/james/mime4j/BufferedLineReaderInputStream.java

2008-07-21 Thread bago
Author: bago Date: Mon Jul 21 10:52:56 2008 New Revision: 678517 URL: http://svn.apache.org/viewvc?rev=678517&view=rev Log: BufferedLineReaderInputStream indexOf method was ignoring pos and searched in the wrong part of the buffer if pos/len argument were used. Modified: james/mime4j/trunk/

[jira] Updated: (MIME4J-54) boundaries should only be found at the beginning of a line

2008-07-21 Thread Stefano Bagnara (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefano Bagnara updated MIME4J-54: -- Attachment: MIME4J-54.patch This make sure we only find boundaries at the start of a line. This

[jira] Updated: (MIME4J-54) boundaries should only be found at the beginning of a line

2008-07-21 Thread Stefano Bagnara (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefano Bagnara updated MIME4J-54: -- Attachment: boundary-tests.zip Updated/Fixed test resources > boundaries should only be found a

[jira] Updated: (MIME4J-54) boundaries should only be found at the beginning of a line

2008-07-21 Thread Stefano Bagnara (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefano Bagnara updated MIME4J-54: -- Attachment: (was: boundary-tests.zip) > boundaries should only be found at the beginning of

Re: Opinions about MIME4J-54 (boundaries should only be found at the beginning of a line)

2008-07-21 Thread Serge Knystautas
I do not have a use for telling someone their message is non-compliant. I have a use for parsing emails. I'm a simpleton user though, so can only speak to my own needs. -- Serge Knystautas Lokitech >> software . strategy . design >> http://www.lokitech.com p. 301.656.5501 e. [EMAIL PROTECTED]

Re: Opinions about MIME4J-54 (boundaries should only be found at the beginning of a line)

2008-07-21 Thread Stefano Bagnara
Serge Knystautas ha scritto: I do not have a use for telling someone their message is non-compliant. I have a use for parsing emails. I'm a simpleton user though, so can only speak to my own needs. Serge, I'm not sure this is on topic with what I asked: Are you saying that you prefer us not

[jira] Commented: (MIME4J-54) boundaries should only be found at the beginning of a line

2008-07-21 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615377#action_12615377 ] Oleg Kalnichevski commented on MIME4J-54: - Works for me. Oleg > boundaries should

[EMAIL PROTECTED]: Project james-jsieve (in module james-jsieve) failed

2008-07-21 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project james-jsieve has an issue affecting its community integration. This issue affects

Re: [Mime4j] 24 Test Failures

2008-07-21 Thread Bernd Fondermann
On Mon, Jul 21, 2008 at 17:40, Stefano Bagnara <[EMAIL PROTECTED]> wrote: > Niklas Therning ha scritto: >> >> Stefano Bagnara wrote: >>> >>> So you prefer to not have bug-proving tests. I just understood this, but >>> this is simply a matter of preference, so rather than disappoint each other >>> w

Re: [Mime4j] 24 Test Failures

2008-07-21 Thread Robert Burrell Donkin
On Mon, Jul 21, 2008 at 8:52 PM, Bernd Fondermann <[EMAIL PROTECTED]> wrote: > On Mon, Jul 21, 2008 at 17:40, Stefano Bagnara <[EMAIL PROTECTED]> wrote: >> Niklas Therning ha scritto: >>> >>> Stefano Bagnara wrote: So you prefer to not have bug-proving tests. I just understood this, but >

Re: [Mime4j] 24 Test Failures

2008-07-21 Thread Bernd Fondermann
On Mon, Jul 21, 2008 at 21:58, Robert Burrell Donkin <[EMAIL PROTECTED]> wrote: > On Mon, Jul 21, 2008 at 8:52 PM, Bernd Fondermann > <[EMAIL PROTECTED]> wrote: >> On Mon, Jul 21, 2008 at 17:40, Stefano Bagnara <[EMAIL PROTECTED]> wrote: >>> Niklas Therning ha scritto: Stefano Bagnara wro

svn commit: r678541 - in /james/mime4j/trunk/src: main/java/org/apache/james/mime4j/util/CodecUtil.java test/java/org/apache/james/mime4j/util/QuotedPrintableTextEncodeTest.java

2008-07-21 Thread rdonkin
Author: rdonkin Date: Mon Jul 21 13:03:38 2008 New Revision: 678541 URL: http://svn.apache.org/viewvc?rev=678541&view=rev Log: Improved encoder supports text and binary modes. More tests are needed but I think the pay will be greater if these are added as integration tests. Added: james/mim

svn commit: r678542 - /james/mime4j/trunk/src/main/java/org/apache/james/mime4j/message/TempFileTextBody.java

2008-07-21 Thread rdonkin
Author: rdonkin Date: Mon Jul 21 13:04:09 2008 New Revision: 678542 URL: http://svn.apache.org/viewvc?rev=678542&view=rev Log: Use text mode for text bodies Modified: james/mime4j/trunk/src/main/java/org/apache/james/mime4j/message/TempFileTextBody.java Modified: james/mime4j/trunk/src/mai

[jira] Commented: (MIME4J-54) boundaries should only be found at the beginning of a line

2008-07-21 Thread Robert Burrell Donkin (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615397#action_12615397 ] Robert Burrell Donkin commented on MIME4J-54: - I agree with Niklas et al that it

[jira] Commented: (MIME4J-62) Unnecessary qp encoding of SPACE and TAB characters in CodecUtil

2008-07-21 Thread Robert Burrell Donkin (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615395#action_12615395 ] Robert Burrell Donkin commented on MIME4J-62: - I've committed a first attempt at

svn commit: r678546 - in /james/mime4j/trunk/src/main/java/org/apache/james/mime4j: MimeBoundaryInputStream.java MimeEntity.java

2008-07-21 Thread rdonkin
Author: rdonkin Date: Mon Jul 21 13:17:41 2008 New Revision: 678546 URL: http://svn.apache.org/viewvc?rev=678546&view=rev Log: MIME4J-55 introduced an IllegalArgumentException. Though this is unlikely to be thrown, it would be unfriendly for a RuntimeException to be propogated. Document the thro

[jira] Commented: (MIME4J-62) Unnecessary qp encoding of SPACE and TAB characters in CodecUtil

2008-07-21 Thread Robert Burrell Donkin (JIRA)
[ https://issues.apache.org/jira/browse/MIME4J-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615402#action_12615402 ] Robert Burrell Donkin commented on MIME4J-62: - I've finished working in this are

[jsieve] Release...?

2008-07-21 Thread Robert Burrell Donkin
Norman - likely to have any free time soon? - robert - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r678554 - in /james/mime4j/trunk/src/main/java/org/apache/james/mime4j/message: TempFileBinaryBody.java TempFileTextBody.java

2008-07-21 Thread niklas
Author: niklas Date: Mon Jul 21 13:41:27 2008 New Revision: 678554 URL: http://svn.apache.org/viewvc?rev=678554&view=rev Log: Removed the extra CRLF written by writeTo() when QP encoding is used. Modified: james/mime4j/trunk/src/main/java/org/apache/james/mime4j/message/TempFileBinaryBody.ja

  1   2   >