Re: [Suspend-devel] [RFC] Modify switching into lzo compression

2007-08-15 Thread Alon Bar-Lev
stion is how do you want to proceed? >> - if (!cnt) { >> + /* NOTICE: Assuming block->data large enough as lzo does not check for limits */ > We can't make this assumption in general. I

Re: [Suspend-devel] [PATCH] Cleanup terminal if abort was selected

2007-08-15 Thread Alon Bar-Lev
On 8/15/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > On Saturday, 11 August 2007 21:08, Alon Bar-Lev wrote: > > > > Hello, > > > > Current implementation does not cleanup console settings if abort was > > selected by user. > > This should fix it.

Re: [Suspend-devel] encryption docs

2007-08-14 Thread Alon Bar-Lev
On 8/15/07, Pavel Machek <[EMAIL PROTECTED]> wrote: > With symetric-operations only -- how do you set it up in a way that > passphrase is only needed during resume, not during boot or bootup? asymmetric... gpg is capable of it But never mind... > Yep, seen that. I don't get the "integrity veri

Re: [Suspend-devel] encryption docs

2007-08-14 Thread Alon Bar-Lev
On 8/14/07, Pavel Machek <[EMAIL PROTECTED]> wrote: > I don't think we can rely on external programs during > suspend/resume. suspend is pagelocked, so that we don't access > filesystems after snapshot is made. You can access initramfs... --

Re: [Suspend-devel] encryption docs

2007-08-14 Thread Alon Bar-Lev
On 8/14/07, Luca <[EMAIL PROTECTED]> wrote: > IOW we don't use RSA to encrypt the whole image ;) Sure you don't. I referred the symmetric decryption... This can be done using gpg or any other external decryption software. Something like: resume --get-key-meterial | gpg --decrypt | resume When yo

Re: [Suspend-devel] encryption docs

2007-08-14 Thread Alon Bar-Lev
implementation can be found at: http://wiki.tuxonice.net/EncryptedSwapAndRoot Best Regards, Alon Bar-Lev. - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log

[Suspend-devel] [PATCH] Cleanup terminal if abort was selected

2007-08-11 Thread Alon Bar-Lev
Hello, Current implementation does not cleanup console settings if abort was selected by user. This should fix it. Part of pending series at: http://alon.barlev.googlepages.com/suspend-patches.tar.bz2 Best Regards, Alon Bar-Lev. --- --- suspend.org/suspend.c 2007-07-29 21:30

[Suspend-devel] [Call For Testing] autoconf/automake for suspend

2007-08-10 Thread Alon Bar-Lev
t run this package... Just check if it is built correctly. Thanks! Alon Bar-Lev. - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration

Re: [Suspend-devel] vt switch during image write

2007-08-08 Thread Alon Bar-Lev
On 8/8/07, Tim Dijkstra <[EMAIL PROTECTED]> wrote: > At some point I added an explicit lock against switching VTs at some > point. IIRC, this is to be sure we save a consistent state. Thanks! But can you please unlock it after snapshot? Alon. -

[Suspend-devel] vt switch during image write

2007-08-06 Thread Alon Bar-Lev
to tell the framebuffer not to blackout? And there is the ACPI leds that resets during snapshot... But apart of the above all seems OK. Regards, Alon Bar-Lev. - This SF.net email is sponsored by: Splunk Inc. Still grepping

Re: [Suspend-devel] [PATCH 1/6] - autoconf/automake glue - license

2007-08-06 Thread Alon Bar-Lev
On 8/6/07, Luca <[EMAIL PROTECTED]> wrote: > You can leave the full email address, it's not a secret ;-) > Furthermore Tim is the maintainer of the Debian package, I guess he > won't mind leaving the address either. Tim? - Th

Re: [Suspend-devel] [PATCH 1/6] - autoconf/automake glue - license

2007-08-06 Thread Alon Bar-Lev
On Monday 06 August 2007, Alon Bar-Lev wrote: > On 8/6/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > Second, what I didn't like is not the whole idea, but the context in which > > you > > used the word "License". I think you just shouldn'

Re: [Suspend-devel] [PATCH 1/6] - autoconf/automake glue - license

2007-08-06 Thread Alon Bar-Lev
On 8/6/07, Pavel Machek <[EMAIL PROTECTED]> wrote: > If you got radeontool from us, it is GPLed. You can get zlib-licensed > version from Frederick. So please update the header of the file into dual license. Now (if you wish) we can add the copyright of developers without making Refael angry... :

Re: [Suspend-devel] [PATCH 1/6] - autoconf/automake glue - license

2007-08-06 Thread Alon Bar-Lev
On 8/6/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > Second, what I didn't like is not the whole idea, but the context in which you > used the word "License". I think you just shouldn't say "vbetool License" or > "radeontool License" if you're not speaking of licenses. You can just write > "

Re: [Suspend-devel] [PATCH] print_checksum fixup

2007-08-06 Thread Alon Bar-Lev
On 8/6/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > You don't need my further help in this issue. > > This was rather offensive. Don't take my statement as offensive, this is the second time... I do what I can up to the point you should decide what you wish to do. For the license part: Th

Re: [Suspend-devel] [PATCH] print_checksum fixup

2007-08-06 Thread Alon Bar-Lev
On 8/6/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > Yes, in this context you're right, but this was not clear from the original > post. > > Moreover, the printf() is buggy, not the function itself. Again... we go philosophical... Please fix the issue as you see it... You don't need my furthe

Re: [Suspend-devel] [PATCH] print_checksum fixup

2007-08-06 Thread Alon Bar-Lev
On 8/6/07, Frank Seidel <[EMAIL PROTECTED]> wrote: > (and btw no need to CC me for an answer, i'm reading the list) > It just wasn't clear what you meant (at least to me). Hello, All I do is reply-all... You can configure your reply-to to the list... This way people won't have to guess how it is

Re: [Suspend-devel] [PATCH 2/6] - autoconf/automake glue - scripts

2007-08-06 Thread Alon Bar-Lev
On Monday 06 August 2007, Pavel Machek wrote: > > @@ -1,4 +1,4 @@ > > -#!/bin/bash > > +#!/bin/sh -x > > > > What is "sh -x"? > Good catch! I had some issues with this script... -x allows debugging... Here is an update. Sorry. --- diff -urNp suspend.org/scripts/create-resume-initrd.sh susp

Re: [Suspend-devel] [PATCH 1/6] - autoconf/automake glue - license

2007-08-06 Thread Alon Bar-Lev
On 8/6/07, Pavel Machek <[EMAIL PROTECTED]> wrote: > And the license is GPLv2... for all subparts, too. They are part of > GPLed project after all. No... /* Radeontool v1.4 * by Frederick Dean <[EMAIL PROTECTED]> * Copyright 2002-2004 Frederick Dean * Use hereby granted under the zlib license

Re: [Suspend-devel] [PATCH] print_checksum fixup

2007-08-06 Thread Alon Bar-Lev
On 8/6/07, Frank Seidel <[EMAIL PROTECTED]> wrote: > On Monday 06 August 2007 00:46:01 Alon Bar-Lev wrote: > > On 8/6/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > > On Monday, 6 August 2007 00:05, Alon Bar-Lev wrote: > > > > > > > > Wel

Re: [Suspend-devel] [PATCH] print_checksum fixup

2007-08-05 Thread Alon Bar-Lev
On 8/6/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > On Monday, 6 August 2007 00:05, Alon Bar-Lev wrote: > > > > Well... It never worked :) > > Why exactly do you think so? Because you increment buf and return it... This will not work with printf() as it alway

[Suspend-devel] [PATCH] print_checksum fixup

2007-08-05 Thread Alon Bar-Lev
Well... It never worked :) This what happens on shortcuts... Why calling this inside printf context instead of making this own statement? --- --- suspend.org/resume.c2007-05-13 20:53:13.0 +0300 +++ suspend.work/resume.c 2007-08-06 00:59:57.0 +0300 @@ -377,10 +427,11

Re: [Suspend-devel] [PATCH 6/6] - autoconf/automake glue - s2ram

2007-08-05 Thread Alon Bar-Lev
On 8/5/07, Luca <[EMAIL PROTECTED]> wrote: > > You just not include .c files in your source! > > This is day1 common practice. > > Well, the rule is "don't do that unless you know what you're doing"; > the inclusion was deliberate (and permitted by the standard btw). No it isn't. You just don't in

Re: [Suspend-devel] [PATCH 0/6] - autoconf/automake glue

2007-08-04 Thread Alon Bar-Lev
On Friday 03 August 2007, Alon Bar-Lev wrote: > Hello, > > In order to make migration to autoconf/automake easy I've made > a series of patches that preparing the environment to incremental > migration. > > Please review this quickly so I won't have to rebase my

[Suspend-devel] [PATCH] Enable splash setting via command-line

2007-08-04 Thread Alon Bar-Lev
Hello, This patch adds --splash argument to s2both, s2disk, resume. It is required especially for resume when you want to disable splash in initramfs as result of kernel parameter, even if it usually turned on on suspend.conf you wish to turn it off. This is handy if you get oops or cannot boot

Re: [Suspend-devel] [PATCH 6/6] - autoconf/automake glue - s2ram

2007-08-04 Thread Alon Bar-Lev
s2ram is concerned is a simple function... :) I think it is much easier to understand and maintain the package this way... Best Regards, Alon Bar-Lev. - This SF.net email is sponsored by: Splunk Inc. Still grepping through log f

[Suspend-devel] [PATCH] Do not manually calculate config elements

2007-08-04 Thread Alon Bar-Lev
This allows you to specify an array of config_par, ending it with NULL name, so that you don't have to calculate the number of entries manually. Alon --- --- suspend.org/configparser.h 2007-05-13 20:53:13.0 +0300 +++ suspend.work/configparser.h 2007-08-04 04:58:08.0 +0300 @@ -1

Re: [Suspend-devel] [RFC] Modify switching into lzo compression

2007-08-04 Thread Alon Bar-Lev
On Saturday 04 August 2007, Alon Bar-Lev wrote: > > Hello Rafael, > > This is *UNTESTED* suggestion for switching into lzo without the memcpy. > Please see if I missed something as I the code combination of global > variables, > local memory pool and unrelated sizes is di

Re: [Suspend-devel] [PATCH 6/6] - autoconf/automake glue - s2ram

2007-08-04 Thread Alon Bar-Lev
On 8/4/07, Stefan Seyfried <[EMAIL PROTECTED]> wrote: > I don't care too much, although i think this is much too much > actually changed code for just "automake conversion". I mean - > this is configuration stuff, why do we need to reorder whitelist.[hc]? > > I guess i know the answer - and now you

Re: [Suspend-devel] [PATCH 1/6] - autoconf/automake glue - license

2007-08-04 Thread Alon Bar-Lev
On 8/4/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > We can always complete this in future. > > Also if you apply the suggested fix, you can add more info later, > > there is nothing wrong with the current information. > > Anyway, it improves current state. > > No, it doesn't. Actually, it

[Suspend-devel] [RFC] Modify switching into lzo compression

2007-08-03 Thread Alon Bar-Lev
Hello Rafael, This is *UNTESTED* suggestion for switching into lzo without the memcpy. Please see if I missed something as I the code combination of global variables, local memory pool and unrelated sizes is difficult to understand/maintain. Basically, I've modify the init_swap_writer() so that

Re: [Suspend-devel] [PATCH3/6] - autoconf/automake glue - cflags

2007-08-03 Thread Alon Bar-Lev
On 8/4/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > If you think that it should be removed, then do so, but _please_ _make_ _sure_ > that _nothing_ will break as a result (ie. add all of the necessary > definitions > instead of it etc.). OK.. Never mind. I've added this define into resume a

Re: [Suspend-devel] [PATCH 4/6] - autoconf/automake glue - encrypt conflict

2007-08-03 Thread Alon Bar-Lev
On 8/4/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > OK. > > Do you wish to sync up compress->do_compress as well? > > No. I'd like to have a patch without this "compress_" stuff (plain LZO > instead I meant the compress flag... There is a variable called compress, just like the one which

Re: [Suspend-devel] [PATCH 1/6] - autoconf/automake glue - license

2007-08-03 Thread Alon Bar-Lev
On 8/4/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > Hmm... You can help you know... > > Perhaps I'm doing something else, which I consider as more important, in > parallel? We can always complete this in future. Also if you apply the suggested fix, you can add more info later, there is not

Re: [Suspend-devel] [PATCH3/6] - autoconf/automake glue - cflags

2007-08-03 Thread Alon Bar-Lev
On 8/4/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > I am for removing it and fix it right when someone have an issue with it. > > What exactly is wrong with it? Turning on GNU extensions without REAL reason is not wise, as different compilers will have hard time to compile this. Alon. --

Re: [Suspend-devel] [PATCH 1/6] - autoconf/automake glue - license

2007-08-03 Thread Alon Bar-Lev
On 8/4/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > Usually, only the package full license is shown here. > > For dependencies only short copyright signature is displayed. > > Do you wish to put the full license of each dependency as well? > > Not the full license, but the name of it and a

Re: [Suspend-devel] [PATCH 4/6] - autoconf/automake glue - encrypt conflict

2007-08-03 Thread Alon Bar-Lev
On Friday 03 August 2007, Rafael J. Wysocki wrote: > On Friday, 3 August 2007 01:15, Alon Bar-Lev wrote: > > > > encrypt variable conflict with glibc::encrypt() > > Rename it to encrypt_on > > I'd prefer do_encrypt. OK. --- diff -urNp suspend.org/suspe

Re: [Suspend-devel] [PATCH 5/6] - autoconf/automake glue - config.* rename

2007-08-03 Thread Alon Bar-Lev
On Friday 03 August 2007, Rafael J. Wysocki wrote: > On Friday, 3 August 2007 01:16, Alon Bar-Lev wrote: > > > > config.* conflicts with autoconf files. > > Rename the to configparser.*. > > > > After applying this patch, you should rename: > >

Re: [Suspend-devel] [PATCH 1/6] - autoconf/automake glue - license

2007-08-03 Thread Alon Bar-Lev
On 8/3/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > +vbetool License > > + > > + Copyright Matthew Garrett <[EMAIL PROTECTED]>, heavily based on > > + vbetest.c from the lrmi package and read-edid.c by John Fremlin > > And the license is? Usually, only the package full license is s

Re: [Suspend-devel] [PATCH 4/6] - autoconf/automake glue - encrypt conflict

2007-08-03 Thread Alon Bar-Lev
On 8/3/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > On Friday, 3 August 2007 01:15, Alon Bar-Lev wrote: > > > > encrypt variable conflict with glibc::encrypt() > > Rename it to encrypt_on > > I'd prefer do_encrypt. OK. Do you wish to sync u

Re: [Suspend-devel] [PATCH3/6] - autoconf/automake glue - cflags

2007-08-03 Thread Alon Bar-Lev
bellow is the document of addition. I am for removing it and fix it right when someone have an issue with it. Best Regards, Alon Bar-Lev. --- Re: [Suspend-devel] [PATCH] read-ahead in resume From: Michal Schmidt <[EMAIL PROTECTED]> - 2006-04-11 23:01 Rafael J. Wysocki wrote: > On

Re: [Suspend-devel] [PATCH3/6] - autoconf/automake glue - cflags

2007-08-03 Thread Alon Bar-Lev
On 8/3/07, Frank Seidel <[EMAIL PROTECTED]> wrote: > Hi, > > On Friday 03 August 2007 01:13:56 Alon Bar-Lev wrote: > > Can anyone please explain this usage? > > These flags should seldom be used. > Why do you think so? _GNU_SOURCE activates various features like >

Re: [Suspend-devel] Autoconf/automake support

2007-08-02 Thread Alon Bar-Lev
On 8/3/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > Please look at the code in prepare(), for example. In there, lzf_compress() > is > used to take page_size bytes of data from buf, compress them and place the > result under the address block->data, with the assumption that the size of the

Re: [Suspend-devel] [PATCH 6/6] - autoconf/automake glue - s2ram

2007-08-02 Thread Alon Bar-Lev
1. Move main() out of s2ram.c into s2ram-main.c, this will enable s2ram.o to be included in both s2ram and s2both without recompilation. 2. Split whitelist.c into whitelist.h/whitelist.c as including .c is none standard/unsupported. --- diff -urNp suspend.org/s2ram.c suspend-0.6_beta1/s2ram.c

Re: [Suspend-devel] [PATCH 4/6] - autoconf/automake glue - encrypt conflict

2007-08-02 Thread Alon Bar-Lev
encrypt variable conflict with glibc::encrypt() Rename it to encrypt_on --- diff -urNp suspend.org/suspend.c suspend-0.6_beta1/suspend.c --- suspend.org/suspend.c 2007-07-29 21:30:27.0 +0300 +++ suspend-0.6_beta1/suspend.c 2007-08-02 23:55:20.0 +0300 @@ -68,10 +68,10 @@ sta

Re: [Suspend-devel] [PATCH 2/6] - autoconf/automake glue - scripts

2007-08-02 Thread Alon Bar-Lev
Use sh and not bash. Support BOOT_DIR for install-resume.sh --- diff -urNp suspend.org/scripts/create-resume-initrd.sh suspend-0.6_beta1/scripts/create-resume-initrd.sh --- suspend.org/scripts/create-resume-initrd.sh 2006-07-23 14:32:53.0 +0300 +++ suspend-0.6_beta1/scripts/create-resu

Re: [Suspend-devel] [PATCH 5/6] - autoconf/automake glue - config.* rename

2007-08-02 Thread Alon Bar-Lev
config.* conflicts with autoconf files. Rename the to configparser.*. After applying this patch, you should rename: config.h->configparser.h config.c->configparser.c I did not want to include the removal/addition in patch. --- diff -urNp suspend.org/resume.c suspend-0.6_beta1/resume.c --- susp

Re: [Suspend-devel] [PATCH3/6] - autoconf/automake glue - cflags

2007-08-02 Thread Alon Bar-Lev
Can anyone please explain this usage? These flags should seldom be used. --- diff -urNp suspend.org/resume.c suspend-0.6_beta1/resume.c --- suspend.org/resume.c2007-05-13 20:53:13.0 +0300 +++ suspend-0.6_beta1/resume.c 2007-08-01 23:05:59.0 +0300 @@ -9,5 +9,4 @@ * */

Re: [Suspend-devel] [PATCH 1/6] - autoconf/automake glue - license

2007-08-02 Thread Alon Bar-Lev
You are using code from a lot of developers. This patch creates more detailed license information. After applying this patch, you should rename: LICENSE->COPYING.GPL I did not want to include the removal/addition in patch. The COPYING* is the standard name for autoconf packages. --- diff -urNp

[Suspend-devel] [PATCH 0/6] - autoconf/automake glue

2007-08-02 Thread Alon Bar-Lev
Hello, In order to make migration to autoconf/automake easy I've made a series of patches that preparing the environment to incremental migration. Please review this quickly so I won't have to rebase my work over and over. Best Regards, Al

Re: [Suspend-devel] Autoconf/automake support

2007-08-02 Thread Alon Bar-Lev
On 8/3/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > First, please just replace LZF with LZO. If LZF is unsupported, there's no > reason to drag it all the way. OK. > Second, you have added data copying in compress_compress(), which generally > is not desirable. Can you avoid it? I will a

Re: [Suspend-devel] Autoconf/automake support

2007-08-02 Thread Alon Bar-Lev
On Tuesday 31 July 2007, Rafael J. Wysocki wrote: > > IIRC noone was strongly against, so replacing lzf with lzo is the way > > to go...? > > Ultimately, I think it is. Rafael, Can you please apply the lzo support or tell me how to improve it? It makes it difficult for me to sync up each patch. T

Re: [Suspend-devel] Autoconf/automake support

2007-07-31 Thread Alon Bar-Lev
On Tuesday 31 July 2007, Luca wrote: > > http://suspend.sf.net/s2ram-support.html > > I've also updated the link on the documentation page. > > Luca > Thanks for such quick response! Here is a patch for the rest of the files. Alon. --- diff -urNp suspend.org/README suspend/README --- suspe

Re: [Suspend-devel] Autoconf/automake support

2007-07-31 Thread Alon Bar-Lev
On 7/31/07, Pavel Machek <[EMAIL PROTECTED]> wrote: > Luca, could you add redirect from suspend.sf.net to s2ram wiki in > suse? Alon knows what is required... > Pavel Great! Hello Luca, There should be a URL such as http://suspend.s

Re: [Suspend-devel] Autoconf/automake support

2007-07-31 Thread Alon Bar-Lev
On 7/31/07, Pavel Machek <[EMAIL PROTECTED]> wrote: > Hmm, IIRC we _do_ have some webmaster, already. Ok, lets keep pages in > suse wiki, then. Excuse me for not understanding such short messages... Are you doping the idea of link only suspend site and redirect from suspend site to suse wiki? Or y

Re: [Suspend-devel] Autoconf/automake support

2007-07-31 Thread Alon Bar-Lev
On 7/31/07, Pavel Machek <[EMAIL PROTECTED]> wrote: > Right... so do you have sourceforge login? I guess we could use you as > a webmaster for suspend.sf.net project ;-). > Pavel My sf login is alonbl. But I am far from being a web ma

Re: [Suspend-devel] Autoconf/automake support

2007-07-30 Thread Alon Bar-Lev
On 7/30/07, Stefan Seyfried <[EMAIL PROTECTED]> wrote: >> Why do you forward people to suse URLs on whitelist? >> I would have expected all be forwarded to suspend.sf.net... >> http://en.opensuse.org/S2ram belongs to the project site... not >> distribution specific site. > Ok, so i'm going to take

Re: [Suspend-devel] suspend - libz dependency

2007-07-29 Thread Alon Bar-Lev
On 7/29/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > On Sunday, 29 July 2007 21:17, Alon Bar-Lev wrote: > > On 7/29/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > > > Which version of pciutils do you have? > > > > > > pciutils-2.2.4-13

Re: [Suspend-devel] suspend - libz dependency

2007-07-29 Thread Alon Bar-Lev
On 7/29/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > Which version of pciutils do you have? > > pciutils-2.2.4-13 OK. pkg-config stuff was introduced in pciutils-2.2.6 I will fix this at autoconf/automake, but I need you to commit all changes first... I think the lzo patch is the only mis

Re: [Suspend-devel] suspend - libz dependency

2007-07-29 Thread Alon Bar-Lev
On 7/29/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > It doesn't work on my system (openSUSE 10.2). What do you get? Which version of pciutils do you have? Can you please send the output of the following command? $ pkg-config --libs libpci Alon. -

Re: [Suspend-devel] Autoconf/automake support

2007-07-28 Thread Alon Bar-Lev
On 7/28/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > Well, I think that the majority of core developers of the suspend package do > not know autoconf/automake very well, including me. That may be a problem > if any changes to the Makefile etc. are needed in the future. I can maintain this.

[Suspend-devel] [PATCH] Don't consume 100% CPU

2007-07-28 Thread Alon Bar-Lev
Hello, Just a minor issue, I know you should never reach there... But never consume 100% CPU. Best Regards, Alon Bar-Lev. --- Index: suspend.c === RCS file: /cvsroot/suspend/suspend/suspend.c,v retrieving revision 1.80 diff -u -B

Re: [Suspend-devel] [PATCH] Enable interactive reboot selection

2007-07-28 Thread Alon Bar-Lev
On Friday 27 July 2007, Alon Bar-Lev wrote: > On Friday 27 July 2007, Rafael J. Wysocki wrote: > > Apart from this you should also clear the PLATFORM_SUSPEND flag in the image > > header. Otherwise, resume will be confused if shutdown_method is originally > > set to "p

Re: [Suspend-devel] Autoconf/automake support

2007-07-27 Thread Alon Bar-Lev
On Friday 27 July 2007, Rafael J. Wysocki wrote: > Well, in fact we're missing someone to take care of the project's web page, > too. Hmmm... I cannot help you with web stuff... :( But I can help you with autoconf/automake... Alon -

Re: [Suspend-devel] [PATCH] Enable interactive reboot selection

2007-07-27 Thread Alon Bar-Lev
assed the header to save_image, but left the number of pages as-is, although it can be retrieved from the header now. Best Regards, Alon Bar-Lev. --- Index: splash.c === RCS file: /cvsroot/suspend/suspend/splash.c,v retrieving revision 1

Re: [Suspend-devel] suspend framebuffers during s2ram

2007-07-27 Thread Alon Bar-Lev
On 7/27/07, Stefan Seyfried <[EMAIL PROTECTED]> wrote: > i'd guess s2ram.c will be pretty small then: > > int main() > { > return 0; > } > > > ;-)) > But this is not the goal of s2ram, as i hopefully already explained > sufficiently in an earlier mail. I guess so... Your project. But I rea

Re: [Suspend-devel] Autoconf/automake support

2007-07-27 Thread Alon Bar-Lev
On 7/27/07, Stefan Seyfried <[EMAIL PROTECTED]> wrote: > But i am not the one to decide this, as i am only maintaining a small piece > of the code (mainly the whitelist). Why do you forward people to suse URLs on whitelist? I would have expected all be forwarded to suspend.sf.net... http://en.open

Re: [Suspend-devel] suspend framebuffers during s2ram

2007-07-27 Thread Alon Bar-Lev
On 7/27/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > (yes, i think i know what it does; writing 1 into the state of the > > framebuffer device just disables any drawing - and thus any access > > of possibly not really initialized hardware before running vbe_post > > etc...) > > At least it

Re: [Suspend-devel] Autoconf/automake support

2007-07-27 Thread Alon Bar-Lev
On 7/27/07, Stefan Seyfried <[EMAIL PROTECTED]> wrote: > On Wed, Jul 25, 2007 at 05:33:15PM +0300, Alon Bar-Lev wrote: > > On 7/25/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > > IIRC, we discussed that in the past and decided not to do it. > > &g

Re: [Suspend-devel] [PATCH] Set cpufreq to max during suspend/resume

2007-07-27 Thread Alon Bar-Lev
On 7/27/07, Stefan Seyfried <[EMAIL PROTECTED]> wrote: > On Mon, Jul 23, 2007 at 11:25:10AM +0200, Pavel Machek wrote: > > > Well, so user explicitely configured his machine to run on 80% max, > > for some reason. Now you want suspend to explicitely override his > > setting. That strikes me as a ba

Re: [Suspend-devel] [PATCH] Set cpufreq to max during suspend/resume

2007-07-27 Thread Alon Bar-Lev
On 7/27/07, Stefan Seyfried <[EMAIL PROTECTED]> wrote: > On Sun, Jul 22, 2007 at 10:09:50PM +0300, Alon Bar-Lev wrote: > > > These s2ram_* funcs in the end call code from vbetool/vbetool.c which > > > is indeed linked in. But partly I remembered it wrongly. The hacks

Re: [Suspend-devel] Autoconf/automake support

2007-07-25 Thread Alon Bar-Lev
On 7/25/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > IIRC, we discussed that in the past and decided not to do it. Well... Maybe now when the project advanced you have new arguments? It will be much much easier for users. Alon. --

[Suspend-devel] Autoconf/automake support

2007-07-24 Thread Alon Bar-Lev
Hello, I was afraid to ask this question... But given the options, dependencies and system configuration, it would be simpler (to users) an autoconf/automake build environment. If you don't have any religion thing against these tools, I will be happy to provide it. Best Regards, Alon Ba

Re: [Suspend-devel] [PATCH] Add lzo compression support

2007-07-23 Thread Alon Bar-Lev
On 7/24/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > On Monday, 23 July 2007 22:34, Alon Bar-Lev wrote: > > On 7/23/07, Arkadiusz Miskiewicz <[EMAIL PROTECTED]> wrote: > > > ... and there are two versions of lzo 8-) Which to support? We (at PLD) >

Re: [Suspend-devel] [PATCH] Add lzo compression support

2007-07-23 Thread Alon Bar-Lev
On 7/23/07, Arkadiusz Miskiewicz <[EMAIL PROTECTED]> wrote: > ... and there are two versions of lzo 8-) Which to support? We (at PLD) "like" > 2.x for example. My patch is for lzo1x_1 it is available in llzo-1 and lzo-2. I checked the lzo2* but it is much slower. Alon ---

Re: [Suspend-devel] [PATCH] Set cpufreq to max during suspend/resume

2007-07-23 Thread Alon Bar-Lev
On 7/23/07, Pavel Machek <[EMAIL PROTECTED]> wrote: > But you explicitely configured your system to do that... so you get > what you asked for. (And on very old systems, running at 80% cpu > during suspend _could_ be a win, power-wise). The 80% is configured with expectation of continue execution.

Re: [Suspend-devel] [PATCH] Add lzo compression support

2007-07-23 Thread Alon Bar-Lev
On 7/23/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > OTOH, if the user builds s2disk and resume himself, he probably won't care > which compression library they are linked with anyway. True. Next patch I was about to send is a version string to the suspend header and addition of compression

Re: [Suspend-devel] [PATCH] Set cpufreq to max during suspend/resume

2007-07-23 Thread Alon Bar-Lev
On 7/23/07, Pavel Machek <[EMAIL PROTECTED]> wrote: > > It works correctly now. > > Previously it did not work because of SIGALARM and related issues. > > I worked with cpufreqd developer to solve all these. > > Do you mean that cpufreqd is running while we suspend? That would be a > serious bug. B

Re: [Suspend-devel] [PATCH] Set cpufreq to max during suspend/resume

2007-07-23 Thread Alon Bar-Lev
On 7/23/07, Pavel Machek <[EMAIL PROTECTED]> wrote: > > They can... > > There is no difference between doing: > > vbe -> s2disk -> s2ram -> vbe > > s2disk -> vbe -> s2ram -> vbe > > No. vbe data need to go unswappable memory, so we can display messages > in case of something breaks etc... and passi

Re: [Suspend-devel] [PATCH] Add lzo compression support

2007-07-23 Thread Alon Bar-Lev
etter, we can switch, but we do > not want both. Well... So let's switch. :) Best Regards, Alon Bar-Lev. - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Se

Re: [Suspend-devel] [PATCH] Set cpufreq to max during suspend/resume

2007-07-23 Thread Alon Bar-Lev
On 7/23/07, Pavel Machek <[EMAIL PROTECTED]> wrote: > > These s2ram_* funcs in the end call code from vbetool/vbetool.c which > > is indeed linked in. But partly I remembered it wrongly. The hacks > > _before_ suspend are called with an unfrozen userspace, those after on > > We probably want to fix

Re: [Suspend-devel] [PATCH] Set cpufreq to max during suspend/resume

2007-07-23 Thread Alon Bar-Lev
On 7/23/07, Pavel Machek <[EMAIL PROTECTED]> wrote: > Okay, so this is done from userland, not from kernel. > > Does cpu frequency scaling work properly after we snapshot the system? > If yes, we should not need to do this. > If not, this is unsafe. > Which case is it? > > We may need to fix cpufre

Re: [Suspend-devel] [PATCH] Set cpufreq to max during suspend/resume

2007-07-23 Thread Alon Bar-Lev
On 7/23/07, Pavel Machek <[EMAIL PROTECTED]> wrote: > Well, so user explicitely configured his machine to run on 80% max, > for some reason. Now you want suspend to explicitely override his > setting. That strikes me as a bad idea. Plus it does not belong to > suspend. The lower maximum is intende

Re: [Suspend-devel] [PATCH] Set cpufreq to max during suspend/resume

2007-07-23 Thread Alon Bar-Lev
he same for radeon. And I guess the same for pci... This one I am not sure, as I don't really understand why you do what you do. Best Regards, Alon Bar-Lev. - This SF.net email is sponsored by: Splunk Inc. Still grepping t

Re: [Suspend-devel] [PATCH] Add lzo compression support

2007-07-23 Thread Alon Bar-Lev
On 7/23/07, Pavel Machek <[EMAIL PROTECTED]> wrote: > I guess it is easiest way for gentoo, but... I'd prefer not to switch > compression algorithms too often, unless there's good reason to. Support is a good reason :) Tried to talk to lzf developer, I don't want to quote the rude responses I

Re: [Suspend-devel] IBM ACPI suspend led is turned off during suspend

2007-07-23 Thread Alon Bar-Lev
On 7/23/07, Pavel Machek <[EMAIL PROTECTED]> wrote: > We do ACPI calls ("platform mode"), and they manipulate LED status for > us. We probably tell plaform to unsuspend at the end of snapshot. Will you fix this? Alon. - This

Re: [Suspend-devel] [PATCH] Set cpufreq to max during suspend/resume

2007-07-22 Thread Alon Bar-Lev
On 7/22/07, Tim Dijkstra <[EMAIL PROTECTED]> wrote: > On Sun, 22 Jul 2007 07:46:40 +0300 > "Alon Bar-Lev" <[EMAIL PROTECTED]> wrote: > > > On 7/21/07, Tim Dijkstra <[EMAIL PROTECTED]> wrote: > > > No. The vbetool code is linked in. It doesn'

[Suspend-devel] IBM ACPI suspend led is turned off during suspend

2007-07-21 Thread Alon Bar-Lev
off > /proc/acpi/ibm/led The expected behavior is to make it keep blinking until power off. Can anyone think why its state is modified during the snapshot? Best Regards, Alon Bar-Lev. - This SF.net email is sponsored by: Splu

Re: [Suspend-devel] [PATCH] Set cpufreq to max during suspend/resume

2007-07-21 Thread Alon Bar-Lev
On 7/21/07, Tim Dijkstra <[EMAIL PROTECTED]> wrote: > No. The vbetool code is linked in. It doesn't run as regular processes. > At the time we do those hacks, we are the only not-frozen part of userspace. > This is what makes it different from running it from a bunch of scripts. Are you sure? Can

Re: [Suspend-devel] [PATCH] Set cpufreq to max during suspend/resume

2007-07-21 Thread Alon Bar-Lev
On 7/21/07, Alon Bar-Lev <[EMAIL PROTECTED]> wrote: > On 7/21/07, Holger Macht <[EMAIL PROTECTED]> wrote: > > Right. So if we start putting things like cpufreq in the suspend package, > > we would have an argumentation to put everything which is in pm-utils, the >

Re: [Suspend-devel] [PATCH] Set cpufreq to max during suspend/resume

2007-07-21 Thread Alon Bar-Lev
On 7/21/07, Holger Macht <[EMAIL PROTECTED]> wrote: > Right. So if we start putting things like cpufreq in the suspend package, > we would have an argumentation to put everything which is in pm-utils, the > hibernate script etc. to it. And I don't think this is what we want. You can put vbetool, r

Re: [Suspend-devel] [PATCH] Set cpufreq to max during suspend/resume

2007-07-21 Thread Alon Bar-Lev
On 7/21/07, Holger Macht <[EMAIL PROTECTED]> wrote: > This is already done in pm-utils. Upstream uses 'userspace' as governor, > which I personally think is wrong. openSUSE uses the 'performance' > governor and this only because of a bug in the kernel which caused the > system to hang on suspend AF

Re: [Suspend-devel] [PATCH] Set cpufreq to max during suspend/resume

2007-07-21 Thread Alon Bar-Lev
n Demand Low [/Rule] Best Regards, Alon Bar-Lev. - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070m

Re: [Suspend-devel] [PATCH] Set cpufreq to max during suspend/resume

2007-07-21 Thread Alon Bar-Lev
Network) on for 100% more or just increase CPU frequency... Also there is an issue with user experience... Best Regards, Alon Bar-Lev. - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Stud

Re: [Suspend-devel] [PATCH] Set cpufreq to max during suspend/resume

2007-07-20 Thread Alon Bar-Lev
en). However, you can delegate this to the hibernate-script... Just like the pci-state, vbetool and radeontool, but then why these are included in suspend? Also there is the issue of resuming... I guess you don't have pm-utils in your initramfs... :) Best Regards, Alon Bar-Lev. ---

[Suspend-devel] [PATCH] Set cpufreq to max during suspend/resume

2007-07-20 Thread Alon Bar-Lev
Future: fbsplash support. Best Regards, Alon Bar-Lev --- diff -urNp suspend.org/cpufreql.c suspend/cpufreql.c --- suspend.org/cpufreql.c 1970-01-01 02:00:00.0 +0200 +++ suspend/cpufreql.c 2007-07-20 20:34:10.0 +0300 @@ -0,0 +1,76 @@ + +#include +#include +#include + +#include

[Suspend-devel] [PATCH] Enable interactive reboot selection

2007-07-20 Thread Alon Bar-Lev
Hello, This patch enables the user to press "r" during snapshot writing, in order to reboot and not shutdown. One more step toward suspend2 functionality... :) Best Regards, Alon Bar-Lev. diff -urNp suspend.org/splash.c suspend/splash.c --- suspend.org/splash.c2007-0

Re: [Suspend-devel] resume executable location

2007-07-18 Thread Alon Bar-Lev
On Wednesday 18 July 2007, Rafael J. Wysocki wrote: > On Wednesday, 18 July 2007 20:01, Alon Bar-Lev wrote: > > Hello, > > > > I wounder why resume default location is at /usr/local/lib/suspend > > and not at /usr/local/sbin... > > > > The resume is a pr

Re: [Suspend-devel] suspend - libz dependency

2007-07-18 Thread Alon Bar-Lev
n override its guess by using "make ZLIB=no" or "make ZLIB=yes". If compressed support is enabled, pciutils will use pci.ids.gz in preference to pci.ids, even if the pci.ids file is newer. If the pci.ids.gz file is missing, it will use pci.ids instead.""" Please

[Suspend-devel] resume executable location

2007-07-18 Thread Alon Bar-Lev
Hello, I wounder why resume default location is at /usr/local/lib/suspend and not at /usr/local/sbin... The resume is a program which is executed directly, right? Best Regards, Alon Bar-Lev. - This SF.net email is

  1   2   >