Re: [12] JDK-8213516: jck test api/javax_accessibility/AccessibleState/fields.html fails intermittent

Hi Sergey, Please find the updated Webrev with fixes for the below comments: http://cr.openjdk.java.net/~sveerabhadra/8213516/webrev.06/ Thanks and regards, Shashi -Original Message- From: Sergey Bylokhov Sent: Wednesday, March 6, 2019 5:19 AM To: Shashidhara Veerabhadraiah ; Philip

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

Hi Joe, Thank you for that good suggestion. I have incorporated the same and here is the new Webrev:   http://cr.openjdk.java.net/~sveerabhadra/8216008/webrev.10/   Thanks and regards, Shashi   From: Joe Darcy Sent: Friday, March 8, 2019 2:42 PM To: Shashidhara Veerabhadraiah ; Philip

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

Thank you Phil. Sure will wait till CSR is approved.   Thanks and regards, shashi   From: Philip Race Sent: Friday, March 8, 2019 12:18 PM To: Shashidhara Veerabhadraiah Cc: awt-...@openjdk.java.net; Joe Darcy ; swing-dev@openjdk.java.net Subject: Re: [13] JDK-8216008

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

Hi Phil, As discussed here are the updates for the Webrev. Hopefully this is correct.   http://cr.openjdk.java.net/~sveerabhadra/8216008/webrev.09/   Thanks and regards, Shashi   From: Shashidhara Veerabhadraiah Sent: Friday, March 8, 2019 10:33 AM To: Philip Race Cc: awt

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

0:42 PM To: Shashidhara Veerabhadraiah Cc: awt-...@openjdk.java.net; swing-dev@openjdk.java.net; Joe Darcy Subject: Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash   the webrev needs a couple of minor tweaks :   contains empty string -> is the

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

: Shashidhara Veerabhadraiah Sent: Monday, March 4, 2019 3:36 PM To: Philip Race ; Joe Darcy Cc: awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash   Hi Joe, Please find the updated Webrev fixing

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

Hi Joe, Please find the updated Webrev fixing the typo:   http://cr.openjdk.java.net/~sveerabhadra/8216008/webrev.07/   Thanks and regards, Shashi   From: Shashidhara Veerabhadraiah Sent: Thursday, February 21, 2019 2:08 PM To: Philip Race ; Joe Darcy Cc: awt-...@openjdk.java.net; swing

Re: [12] JDK-8213516: jck test api/javax_accessibility/AccessibleState/fields.html fails intermittent

Message- From: Shashidhara Veerabhadraiah Sent: Friday, February 15, 2019 4:27 PM To: Sergey Bylokhov ; Philip Race Cc: swing-dev@openjdk.java.net; Dmitry Bessonov Subject: Re: [12] JDK-8213516: jck test api/javax_accessibility/AccessibleState/fields.html fails intermittent Hi Phil\Sergey, I

Re: [13] RFR JDK-8213781:web page background renders blue in JEditorPane

The rest of the changes should be fine. Thanks and regards, Shashi -Original Message- From: Prasanta Sadhukhan Sent: Thursday, February 21, 2019 9:26 PM To: Shashidhara Veerabhadraiah ; swing-dev@openjdk.java.net Subject: Re: [13] RFR JDK-8213781:web page background renders blue in

Re: [13] RFR JDK-8213781:web page background renders blue in JEditorPane

: Thursday, February 21, 2019 8:20 PM To: Shashidhara Veerabhadraiah ; swing-dev@openjdk.java.net Subject: Re: [13] RFR JDK-8213781:web page background renders blue in JEditorPane Also, as per https://www.w3.org/TR/CSS2/syndata.html#value-def-color, we have The three-digit RGB notation (#rgb) is conv

Re: [13] RFR JDK-8213781:web page background renders blue in JEditorPane

Hi Prashanta, I have a question on the proposed solution. Shouldn’t one check for the color depth of the system like true color(24 bit) or high color system(12 bit or non-true color system) before applying this logic? Assuming 24 bit color system isn't the right thing to do I think but again tha

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

Hi Joe, Please find the new Webrev fixing the specification as asked in the CSR bug: https://bugs.openjdk.java.net/browse/JDK-8218737   Webrev: http://cr.openjdk.java.net/~sveerabhadra/8216008/webrev.06/   Thanks and regards, Shashi   From: Shashidhara Veerabhadraiah Sent: Monday

Re: [12] JDK-8213071: [macos] The focus is disappear after pressing return to close the "That was a pretty good movie!" dialog.

Hi Sergey, Thank you for the review and here is the new webrev fixing your comments: http://cr.openjdk.java.net/~sveerabhadra/8213071/webrev.02/ Thanks and regards, Shashi On 20/02/19 6:40 AM, Sergey Bylokhov wrote: Hi, Shashi. Can you please unify the usage of NO/false/true for the keyNo

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

Thank you Phil for that help on CSR.   From: Phil Race Sent: Friday, February 15, 2019 9:41 PM To: Shashidhara Veerabhadraiah Cc: Sergey Bylokhov ; awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list

Re: [12] JDK-8213516: jck test api/javax_accessibility/AccessibleState/fields.html fails intermittent

will still pass before and after the fix, so was not sure how do I go about that!! Please clarify. Thanks and regards, Shashi -Original Message- From: Shashidhara Veerabhadraiah Sent: Friday, February 15, 2019 3:14 PM To: Sergey Bylokhov ; Philip Race Cc: swing-dev@openjdk.java.net

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

Hi Phil, I have updated the CSR and updated the information for the function and here is the new Webrev:   http://cr.openjdk.java.net/~sveerabhadra/8216008/webrev.05/ Thanks and regards, Shashi   From: Phil Race Sent: Friday, February 15, 2019 2:58 AM To: Shashidhara Veerabhadraiah Cc

Re: [12] JDK-8213516: jck test api/javax_accessibility/AccessibleState/fields.html fails intermittent

Sent: Friday, February 15, 2019 4:23 AM To: Shashidhara Veerabhadraiah ; Philip Race Cc: swing-dev@openjdk.java.net; Dmitry Bessonov ; Krishna Addepalli Subject: Re: [12] JDK-8213516: jck test api/javax_accessibility/AccessibleState/fields.html fails intermittent Hi, Shashi. > HashTa

Re: [13] JDK-8190361: Incorrect version info in jaccessinspector.exe and jaccesswalker.exe

/webrev.02/ Thanks and regards, Shashi From: Philip Race Sent: Wednesday, February 13, 2019 11:24 PM To: Shashidhara Veerabhadraiah Cc: swing-dev Subject: Re: [13] JDK-8190361: Incorrect version info in jaccessinspector.exe and jaccesswalker.exe I'd prefer to see the webrev updated

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

ll other errors are handled by throwing {@code AWTError}" @throws AWTError if there is any error in parsing or loading the ATs. -phil. On 1/21/19, 9:12 AM, Shashidhara Veerabhadraiah wrote: Hi Sergey, Here is the new Webrev for your comments:   http://cr.openjdk.java.net/~sveerabhadra/8216

Re: [13] JDK-8190361: Incorrect version info in jaccessinspector.exe and jaccesswalker.exe

d I think it has inserted unnecessary indentations. I will modify that while pushing in if it is ok with you(if that's the only change). Thanks and regards, Shashi From: Phil Race Sent: Friday, February 8, 2019 10:28 PM To: Shashidhara Veerabhadraiah ; swing-dev Subject: Re: [

[13] JDK-8190361: Incorrect version info in jaccessinspector.exe and jaccesswalker.exe

Hi All, Please review a fix for the below customer bug. Bug: https://bugs.openjdk.java.net/browse/JDK-8190361 Webrev: http://cr.openjdk.java.net/~sveerabhadra/8190361/webrev.01/ The version string for the jaccessinspector and jaccesswalker modules had the string "JDK_BUILD_ID" and this

Re: [12] JDK-8182043: Access to Windows Large Icons

://cr.openjdk.java.net/~sveerabhadra/8182043/webrev.05/   Part of the fix is being borrowed from Semyon's fix and would like to thank Semyon for that.   Thanks and regards, Shashi   From: Alexey Ivanov Sent: Thursday, October 11, 2018 4:32 AM To: Shashidhara Veerabhadraiah ; Prasanta Sadhukhan ;

Re: [12] JDK-8213516: jck test api/javax_accessibility/AccessibleState/fields.html fails intermittent

e to write another open test for this problem? Thanks and regards, Shashi -Original Message- From: Phil Race Sent: Wednesday, January 16, 2019 4:35 AM To: Sergey Bylokhov ; Shashidhara Veerabhadraiah Cc: swing-dev@openjdk.java.net; Dmitry Bessonov ; Krishna Addepalli Subject: Re:

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

Hi Sergey, Here is the new Webrev for your comments: http://cr.openjdk.java.net/~sveerabhadra/8216008/webrev.02/ Thanks and regards, Shashi -Original Message- From: Sergey Bylokhov Sent: Saturday, January 19, 2019 3:47 AM To: Shashidhara Veerabhadraiah ; awt-...@openjdk.java.net

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

created to trim the whitespace in this case as well!! Hence, I chose to create only one path for not loading any assistive technologies. Hope this answers, Sergey. Please let me know if you think otherwise. Thanks and regards, Shashi On 17/01/19 10:28 AM, Shashidhara Veerabhadraiah wrote: We

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

- From: Sergey Bylokhov Sent: Thursday, January 17, 2019 1:33 AM To: Shashidhara Veerabhadraiah ; awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash I guess you meant whitespaces, then it

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

ds, Shashi -Original Message- From: Sergey Bylokhov Sent: Tuesday, January 15, 2019 7:32 AM To: Shashidhara Veerabhadraiah ; awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash Hi, Shashi. Shou

Re: [12] JDK-8213516: jck test api/javax_accessibility/AccessibleState/fields.html fails intermittent

Bylokhov Sent: Friday, December 21, 2018 12:42 PM To: Shashidhara Veerabhadraiah ; Philip Race Cc: swing-dev@openjdk.java.net; Dmitry Bessonov ; Krishna Addepalli Subject: Re: [12] JDK-8213516: jck test api/javax_accessibility/AccessibleState/fields.html fails intermittent Hi, Shashi. Yes

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

Hi Sergey, Thanks for pointing that out. Here is the new Webrev: http://cr.openjdk.java.net/~sveerabhadra/8216008/webrev.01/ Thanks and regards, Shashi -Original Message- From: Sergey Bylokhov Sent: Friday, January 4, 2019 3:48 AM To: Shashidhara Veerabhadraiah ; awt

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

Hi Krishna, Thank you for the review. Thanks and regards, Shashi From: Krishna Addepalli Sent: Thursday, January 3, 2019 8:22 PM To: Shashidhara Veerabhadraiah ; awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: RE: [13] JDK-8216008

[13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

Hi All, Please review a fix for the below bug. Bug: https://bugs.openjdk.java.net/browse/JDK-8216008 Webrev: http://cr.openjdk.java.net/~sveerabhadra/8216008/webrev.00/ Since the mentioned list of assistive technologies for the system property(javax.accessibility.assistive_technologies

Re: [12] JDK-8213516: jck test api/javax_accessibility/AccessibleState/fields.html fails intermittent

21, 2018 10:48 AM To: Shashidhara Veerabhadraiah Cc: Sergey Bylokhov ; swing-dev@openjdk.java.net; Dmitry Bessonov ; Krishna Addepalli Subject: Re: [12] JDK-8213516: jck test api/javax_accessibility/AccessibleState/fields.html fails intermittent No, we can't remove it in 13 unless we depr

Re: [12] JDK-8213516: jck test api/javax_accessibility/AccessibleState/fields.html fails intermittent

, Shashi -Original Message- From: Philip Race Sent: Friday, December 21, 2018 6:54 AM To: Sergey Bylokhov Cc: Shashidhara Veerabhadraiah ; swing-dev@openjdk.java.net; Dmitry Bessonov ; Krishna Addepalli Subject: Re: [12] JDK-8213516: jck test api/javax_accessibility/AccessibleState

Re: [12] JDK-8213516: jck test api/javax_accessibility/AccessibleState/fields.html fails intermittent

ds, Shashi -Original Message----- From: Shashidhara Veerabhadraiah Sent: Thursday, December 20, 2018 9:49 AM To: Sergey Bylokhov ; swing-dev@openjdk.java.net; Philip Race ; Dmitry Bessonov Subject: Re: [12] JDK-8213516: jck test api/javax_accessibility/AccessibleState/fields.html fails interm

Re: [12] JDK-8213516: jck test api/javax_accessibility/AccessibleState/fields.html fails intermittent

:58 AM To: Shashidhara Veerabhadraiah ; swing-dev@openjdk.java.net; Philip Race ; Dmitry Bessonov Subject: Re: [12] JDK-8213516: jck test api/javax_accessibility/AccessibleState/fields.html fails intermittent Hi, Shashi. Can you please describe the sequence of calls which might break the the

[12] JDK-8213516: jck test api/javax_accessibility/AccessibleState/fields.html fails intermittent

Hi All, Please review a fix for the JDK 12 for the below bug: Bug: https://bugs.openjdk.java.net/browse/JDK-8213516 Webrev: http://cr.openjdk.java.net/~sveerabhadra/8213516/webrev.00/ This issue is happening intermittently and am not able to reproduce it on my local machine(corner case

Re: [12]RFR: JDK-6714324: Removing a component from a JTabbedPane does not clear its accessibleParent

Hi Krishna, The changes looks fine to me. Thanks and regards, Shashi -Original Message- From: Krishna Addepalli Sent: Friday, December 14, 2018 2:38 PM To: Shashidhara Veerabhadraiah ; Sergey Bylokhov ; swing-dev@openjdk.java.net Subject: RE: [12]RFR: JDK-6714324: Removing a component

Re: [12]RFR: JDK-6714324: Removing a component from a JTabbedPane does not clear its accessibleParent

Hi Krishna, I am trying to understand the class JTabbedPane with this review. I have got some questions while doing, so please clarify it. 1. There is another variation of remove, remove(Component comp) line: 1034, where they remove the requested component from the container tree(if out of boun

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

2018 6:11 AM To: Shashidhara Veerabhadraiah ; Alexey Ivanov ; Krishna Addepalli Cc: awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar Hi, Shashi. On 26/11/2018 01:15, Shashidhara Veerabhadrai

Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after JDK-8153732

fix tries to eliminate the possible NPE cases. Thanks and regards, Shashi From: Prasanta Sadhukhan Sent: Monday, November 26, 2018 8:01 PM To: Shashidhara Veerabhadraiah ; swing-dev@openjdk.java.net; 2d-...@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print

Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after JDK-8153732

currentRemotePrinters is null, then also you update prevRemotePrinters to currentRemotePrinters which is the output of getRemotePrintersNames(). Regards Prasanta On 26-Nov-18 2:33 PM, Shashidhara Veerabhadraiah wrote: Hi All, Please review a NPE fix for the below bug. Bug: https://bugs.openjdk.java.net

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

Thank you Alexey for the detailed reply below. The issue is closed as non-issue now. Thanks and regards, Shashi -Original Message- From: Alexey Ivanov Sent: Saturday, November 24, 2018 12:10 AM To: Shashidhara Veerabhadraiah ; Sergey Bylokhov ; Krishna Addepalli Cc: awt

[12] JDK-8212202: NPE in the print tests after JDK-8153732

Hi All, Please review a NPE fix for the below bug. Bug: https://bugs.openjdk.java.net/browse/JDK-8212202 Webrev: http://cr.openjdk.java.net/~sveerabhadra/8212202/webrev.00/ Function getRemotePrintersNames() may return null values and hence they need to be handled from the caller of tha

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

ormation Swing exposes. So you should look into what implementation of AccessibleContext or rather javax.swing.JComponent.AccessibleJComponent provides. Regards, Alexey Thanks and regards, Shashi On 22/11/18 5:00 AM, Sergey Bylokhov wrote: On 20/11/2018 22:16, Shashidhara Veerabhadraiah wro

Re: [12]RFR: JDK-7124301: [macosx] When in a tab group if you arrow between tabs there are no VoiceOver announcements.

Hi Krishna, The changes looks fine to me. Thanks and regards, Shashi On 19/11/18 3:28 PM, Krishna Addepalli wrote: Hi All, Please review a fix for JDK-7124301: https://bugs.openjdk.java.net/browse/JDK-7124301 Webrev: http://cr.openjdk.java.net/~kaddepalli/7124301/webrev00/

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

Since they are consumed at OS level, we can't even fix that problem of internal traversal of the children components from our end. Thanks and regards, Shashi On 22/11/18 5:00 AM, Sergey Bylokhov wrote: On 20/11/2018 22:16, Shashidhara Veerabhadraiah wrote: Thank you Alexey. I agree to

Re: [12] JDK-8213071: [macos] The focus is disappear after pressing return to close the "That was a pretty good movie!" dialog.

Hi Sergey, Please find the updated webrev. It is true that the notifications are unique to each window and it should be a instance variable. http://cr.openjdk.java.net/~sveerabhadra/8213071/webrev.01/ I have reproduced this issue on Prashanth's mac as well with JDK 8 ver:121. Please note the

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

mind and considering the case of other platforms, should not this fix hold good? Thanks and regards, Shashi -Original Message- From: Alexey Ivanov Sent: Wednesday, November 14, 2018 11:52 PM To: Shashidhara Veerabhadraiah ; Krishna Addepalli ; Sergey Bylokhov Cc: awt

Re: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails

Thank you Krishna and Sergey for the review. -Original Message- From: Sergey Bylokhov Sent: Thursday, November 15, 2018 3:13 AM To: Shashidhara Veerabhadraiah ; Krishna Addepalli ; swing-dev@openjdk.java.net; awt-...@openjdk.java.net Subject: Re: [12] JDK-6849922: java/awt/Choice

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

ge- From: Sergey Bylokhov Sent: Tuesday, November 13, 2018 6:09 AM To: Shashidhara Veerabhadraiah ; awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar On 11/11/2018 05:30, shashidhara.veer

Re: [12] JDK-8213071: [macos] The focus is disappear after pressing return to close the "That was a pretty good movie!" dialog.

Hi Sergey, This same behavior exists on jdk 7 and jdk 8 as well. So it is not a regression I think. Thanks and regards, Shashi On 13/11/18 6:12 AM, Sergey Bylokhov wrote: Hi, Shashi. Did you check this behavior was in jdk7/8 GA, or it is a regression? On 11/11/2018 04:58, shashidhara.veera

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

know if you have any more questions. Thanks and regards, Shashi On 10/11/18 9:12 AM, Sergey Bylokhov wrote: On 07/11/2018 23:18, Shashidhara Veerabhadraiah wrote:  From the usability perspective of a disabled person, I don't think one would know use the Ctrl+option+shift kind of traversa

[12] JDK-8213071: [macos] The focus is disappear after pressing return to close the "That was a pretty good movie!" dialog.

Hi All, Please review a fix for an accessibility vpat issue. Bug: https://bugs.openjdk.java.net/browse/JDK-8213071 Webrev: http://cr.openjdk.java.net/~sveerabhadra/8213071/webrev.00/ The behavior of the same actions to reproduce the problem, produced different results with VO and without VO. I

Re: [12] JDK-8198624: java/awt/KeyboardFocusmanager/TypeAhead/SubMenuShowTest/SubMenuShowTest.html fails on mac

Sent: Tuesday, November 6, 2018 2:06 AM To: Shashidhara Veerabhadraiah ; swing-dev@openjdk.java.net Subject: Re: [12] JDK-8198624: java/awt/KeyboardFocusmanager/TypeAhead/SubMenuShowTest/SubMenuShowTest.html fails on mac Hi, Shashi. A few notes: 1. All Swing components are still created on non

Re: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails

Hi Sergey, Here is the updated Webrev. http://cr.openjdk.java.net/~sveerabhadra/6849922/webrev.04/ Thanks and regards, Shashi -Original Message- From: Sergey Bylokhov Sent: Wednesday, November 7, 2018 2:54 AM To: Shashidhara Veerabhadraiah ; Krishna Addepalli ; swing-dev

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

he existing framework for accessibility as well where it may have a different meaning, causing certain confusion from developer's point of view. Thanks and regards, Shashi -Original Message- From: Philip Race Sent: Friday, November 9, 2018 10:14 AM To: Shashidhara Veerabhadraia

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

04:18, Shashidhara Veerabhadraiah wrote: Hi Alexey, Thanks for running the test on Windows. With accessibility in question we should reach the component using the keyboard only. Touch and mouse is not permitted. In this case each component must be focusable. Can you reach each JLabel when using

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

e >important visible UI element traversals). So considering that, the solution >should at least work in the usability scenarios across the platforms!! Thanks and regards, Shashi -Original Message- From: Sergey Bylokhov Sent: Thursday, November 8, 2018 12:14 PM To: Sha

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

fic to the implementation of voice over on Mac and we do not have similar alternative ways for Windows(for JAWS) platform. Thanks and regards, Shashi -Original Message- From: Sergey Bylokhov Sent: Thursday, November 8, 2018 12:35 AM To: Shashidhara Veerabhadraiah ; awt-...@openjdk.java.net;

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

Thanks and regards, Shashi -Original Message- From: Alexey Ivanov Sent: Thursday, November 8, 2018 1:13 AM To: Shashidhara Veerabhadraiah ; Krishna Addepalli Cc: awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: Re: [12] JDK-7124285: Nothing heard from VoiceOver regardi

[12] JDK-8198624: java/awt/KeyboardFocusmanager/TypeAhead/SubMenuShowTest/SubMenuShowTest.html fails on mac

Hi All, Please review test fix for the below bug. Bug: https://bugs.openjdk.java.net/browse/JDK-8198624 Webrev: http://cr.openjdk.java.net/~sveerabhadra/8198624/webrev.00/ The problem was the swing components were used in the main thread, causing syncing issues between the key press events and

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

up/down. And VO reads the current value of the progress bar, but if the demo is in progress("Start loading text" button was pressed) the VO did not read information about the new values of the progress bar. On 24/10/2018 22:31, Shashidhara Veerabhadraiah wrote: Hi Sergey, While f

Re: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails

n addition to waitForIdle. 3. Minor nit: replace () -> createAndShowGUI() with method reference. Thanks, Krishna -Original Message- From: Shashidhara Veerabhadraiah Sent: Wednesday, October 31, 2018 3:34 PM To: swing-dev@openjdk.java.net; awt-...@openjdk.java.net Subject: [12] JDK-6

Re: [12] JDK-7124293: [macosx] VoiceOver reads percentages rather than the actual values for sliders.

Thank you Sergey and Krishna for your reviews. I have created a new bug for the problem that we found and here is the link: https://bugs.openjdk.java.net/browse/JDK-8213242 Thanks and regards, Shashi On 31/10/18 11:08 PM, Sergey Bylokhov wrote: Looks fine. Hi Sergey, Yeah I saw that prob

[12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails

Hi All, Please review test fix for the below bug. Bug: https://bugs.openjdk.java.net/browse/JDK-6849922 Webrev: http://cr.openjdk.java.net/~sveerabhadra/6849922/webrev.02/ Fix: As the initial bug analysis said in the bug comments, it is a timing issue where in the choice menu remains opened ev

Re: [12] JDK-7124293: [macosx] VoiceOver reads percentages rather than the actual values for sliders.

Hi Sergey, Yeah I saw that problem. It happens even before this fix. It does not behave as a progress bar. We may need to add a change listener to continuously monitor for change and then trigger VO to read it out!! Thanks and regards, Shashi On 31/10/18 8:12 AM, Sergey Bylokhov wrote: Hi,

Re: [12] JDK-7124293: [macosx] VoiceOver reads percentages rather than the actual values for sliders.

Thanks Krishna for your review. Thanks and regards, Shashi On 29/10/18 12:31 PM, Krishna Addepalli wrote: Yes, that would make for a good enhancement. This fix looks good to me. Thanks, Krishna -Original Message- From: Shashidhara Veerabhadraiah Sent: Monday, October 29, 2018 12:29

Re: [12] JDK-7124293: [macosx] VoiceOver reads percentages rather than the actual values for sliders.

, Shashi On 29/10/18 12:25 PM, Krishna Addepalli wrote: Good find Shashi. Now that we know how to make the VO read out only values, is it worthwhile to explore an option to choose between values and percentages? Thanks Krishna -Original Message- From: Shashidhara Veerabhadraiah Sent

[12] JDK-7124293: [macosx] VoiceOver reads percentages rather than the actual values for sliders.

Hi All, Please review a fix for the vpat bug. Bug: https://bugs.openjdk.java.net/browse/JDK-7124293 Webrev: http://cr.openjdk.java.net/~sveerabhadra/7124293/webrev.00/ The issue was that the slider used to voice out the percentages over the assistive technologies instead of the actual values.

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

f the JProgressBar is considered afterwards. Hope this answers. Please let me know if you have any questions. Thanks and regards, Shashi -Original Message- From: Sergey Bylokhov Sent: Thursday, October 25, 2018 3:11 AM To: Shashidhara Veerabhadraiah ; awt-...@openjdk.java.net; swin

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

al Message- From: Alexey Ivanov Sent: Wednesday, October 24, 2018 12:16 AM To: Shashidhara Veerabhadraiah ; Krishna Addepalli Cc: awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar Hi Krish

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

PM To: Shashidhara Veerabhadraiah Cc: awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar Hi Shashi, The fix looks good to me. Regarding the decision of placing the line “setFocusable(true

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

om: Philip Race Sent: Tuesday, October 23, 2018 10:46 AM To: Shashidhara Veerabhadraiah Cc: awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar OK. If the progress bar is still not "user a

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

sible. Thanks and regards, Shashi -Original Message- From: Philip Race Sent: Monday, October 22, 2018 8:57 PM To: Shashidhara Veerabhadraiah Cc: awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the pro

[12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

Hi All, Please review a swingset fix for the below bug. Bug: https://bugs.openjdk.java.net/browse/JDK-7124285 Fix: http://cr.openjdk.java.net/~sveerabhadra/7124285/webrev.00/ Problem: The JProgressBar component used in the swingset demo was not focusable and once it is turned on, now the progr

Re: [12] JDK-8061359: [macosx] Checkbox toggles on Space press but does not spoken by Voice Over

Could I get a one more review of this? Thanks and regards, Shashi -Original Message- From: Sergey Bylokhov Sent: Friday, October 5, 2018 4:47 AM To: Shashidhara Veerabhadraiah ; awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: Re: [12] JDK-8061359: [macosx] Checkbox

Re: [12] JDK-8061359: [macosx] Checkbox toggles on Space press but does not spoken by Voice Over

Thanks Sergey for your review. Thanks and regards, Shashi -Original Message- From: Sergey Bylokhov Sent: Friday, October 5, 2018 4:47 AM To: Shashidhara Veerabhadraiah ; awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: Re: [12] JDK-8061359: [macosx] Checkbox toggles on

Re: [12] JDK-8061359: [macosx] Checkbox toggles on Space press but does not spoken by Voice Over

checked at the beginning of this method. On 01/10/2018 02:54, Shashidhara Veerabhadraiah wrote: Hi All, Please review a fix for an accessibility bug. Bug: https://bugs.openjdk.java.net/browse/JDK-8061359 Webrev: http://cr.openjdk.java.net/~sveerabhadra/8061359/webrev.00/ Problem: The checkbox

[12] JDK-8061359: [macosx] Checkbox toggles on Space press but does not spoken by Voice Over

Hi All, Please review a fix for an accessibility bug. Bug: https://bugs.openjdk.java.net/browse/JDK-8061359 Webrev: http://cr.openjdk.java.net/~sveerabhadra/8061359/webrev.00/ Problem: The checkbox component state changes thro' keyboard space key were not getting voiced over. The problem was th

Re: [12] JDK-8182043: Access to Windows Large Icons

, 2018 3:00 AM To: Shashidhara Veerabhadraiah ; Prasanta Sadhukhan ; swing-dev ; awt-dev Subject: Re: [12] JDK-8182043: Access to Windows Large Icons   Hi Shashi, Please see my comments inline: On 21/09/2018 23:22, Shashidhara Veerabhadraiah wrote: Hi Alexey, Thanks for your review and

Re: [12] JDK-8182043: Access to Windows Large Icons

Hi Alexey, Thanks for your review and below is the new Webrev. http://cr.openjdk.java.net/~sveerabhadra/8182043/webrev.03/   Please see below for inline comments.   Thanks and regards, Shashi   From: Alexey Ivanov Sent: Friday, September 21, 2018 2:09 PM To: Shashidhara Veerabhadraiah

Re: [12] JDK-8182043: Access to Windows Large Icons

Hi All, Please find the updated Webrev per the discussion: http://cr.openjdk.java.net/~sveerabhadra/8182043/webrev.02/ Thanks and regards, Shashi From: Shashidhara Veerabhadraiah Sent: Monday, July 30, 2018 1:32 PM To: Prasanta Sadhukhan ; swing-dev@openjdk.java.net; awt

Re: [12] JDK-8182043: Access to Windows Large Icons

Hi Prashanta, Thanks for your review. Below are my replies: http://cr.openjdk.java.net/~sveerabhadra/8182043/webrev.01/ Thanks and regards, Shashi From: Prasanta Sadhukhan Sent: Friday, July 20, 2018 3:42 PM To: Shashidhara Veerabhadraiah ; swing-dev@openjdk.java.net; awt

[12] JDK-8182043: Access to Windows Large Icons

Hi All, Please review a fix for the below bug. Bug: https://bugs.openjdk.java.net/browse/JDK-8182043 Webrev: http://cr.openjdk.java.net/~sveerabhadra/8182043/webrev.00/ History: This fix is derived from an earlier fix proposed under this mail thread: http://mail.openjdk.java.net/piper

Re: [11] RFR: JDK-8206238: Aspect ratio is not maintained when image is scaled in JEditorPane

Ok. Other than that changes looks fine Krishna. Thanks and regards, Shashi From: Krishna Addepalli Sent: Thursday, July 12, 2018 12:25 PM To: Shashidhara Veerabhadraiah ; Prasanta Sadhukhan ; swing-dev@openjdk.java.net Subject: RE: [11] RFR: JDK-8206238: Aspect ratio is not maintained

Re: [11] RFR: JDK-8206238: Aspect ratio is not maintained when image is scaled in JEditorPane

m the other attribute. I have checked this behavior in Chrome. Attached the html for your reference(just adjust the path to circle.png appropriately on your system). Thanks, Krishna *From:*Shashidhara Veerabhadraiah *Sent:* Wednesday, July 11, 2018 3:07 PM *To:* Krishna Addepalli ; Pra

Re: [11] RFR: JDK-8206238: Aspect ratio is not maintained when image is scaled in JEditorPane

Hi Krishna, One clarification about the change: The said solution holds good for an image with an aspect ratio of 1:1. Can this aspect ratio be considered default? I think we should derive the aspect ratio from the image and use that value to calculate the unknown attribute of the scale info

[11] JDK-8153732: Windows remote printer changes do not reflect in lookupPrintServices()

Hi All, Please review this code changes for the below enhancement. Enhancement: https://bugs.openjdk.java.net/browse/JDK-8153732 Webrev: http://cr.openjdk.java.net/~sveerabhadra/8153732/webrev.00/ Details of the changes: Windows provides *PrinterChangeNotification* functions that provi

Re: [11] RFR JDK-8194943:Regression automated test 'open/test/jdk/javax/swing/JInternalFrame/8020708/bug8020708.java' fails

Looks good to me Prasanta. On 01/03/18 11:35 PM, semyon.sadet...@oracle.com wrote: +1 --Semyon On 3/1/18 10:01 AM, Prasanta Sadhukhan wrote: Hi All, Please review a test fix for an issue whereby it is seen that close mnemonics for different locales was not working. The issue has nothing t

Re: [11] RFR JDK-8186513:TESTBUG] javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java

Hi Prasanta, The changes looks fine. Thanks and regards, Shashi -Original Message- From: Jayathirth D V Sent: Tuesday, February 27, 2018 10:16 PM To: Prasanta Sadhukhan ; swing-dev@openjdk.java.net Subject: Re: [11] RFR JDK-8186513:TESTBUG] javax/swing/JInternalFrame/8160248/JInternal

Re: [10] JDK-8004029: [macosx] The long Tab titles are not clipped with dots at the end.

Hi Prasanta, Please find the updated Webrev @ http://cr.openjdk.java.net/~sveerabhadra/8004029/webrev.05/   Thanks and regards, Shashi   From: Prasanta Sadhukhan Sent: Friday, September 15, 2017 3:11 PM To: Shashidhara Veerabhadraiah ; swing-dev@openjdk.java.net Cc: Sergey Bylokhov

Re: [10] JDK-8004029: [macosx] The long Tab titles are not clipped with dots at the end.

Hi, Here is the updated webrev. Removed unnecessary try catch blocks!!   http://cr.openjdk.java.net/~sveerabhadra/8004029/webrev.04/   Thanks and regards, Shashi   From: Prasanta Sadhukhan Sent: Thursday, September 14, 2017 4:26 PM To: Shashidhara Veerabhadraiah ; swing-dev

Re: [10] Review request for 8166772: Touch keyboard is not shown for text components on a screen touch

Thank you Anton for that information.   Thanks and regards, Shashi   From: Anton Litvinov Sent: Thursday, September 14, 2017 5:51 PM To: Shashidhara Veerabhadraiah ; Sergey Bylokhov ; awt-...@openjdk.java.net; swing-dev@openjdk.java.net Subject: Re: [10] Review request for 8166772: Touch

Re: [10] JDK-8004029: [macosx] The long Tab titles are not clipped with dots at the end.

disposeUI() accordingly.   Thanks and regards, Shashi   From: Prasanta Sadhukhan Sent: Tuesday, September 12, 2017 11:45 AM To: Shashidhara Veerabhadraiah ; swing-dev@openjdk.java.net Cc: Sergey Bylokhov Subject: Re: [10] JDK-8004029: [macosx] The long Tab titles are not clipped with dots at

Re: [10] Review request for 8166772: Touch keyboard is not shown for text components on a screen touch

Hi Anton, I have a question to ask for. I was working on another bug and found that the WM_TOUCH has been deprecated and instead we should be using the WM_POINTER? Here is some info on that: https://stackoverflow.com/questions/23790602/wm-touch-vs-wm-pointer Typically, the WM_POINTER types can

Re: [10] JDK-8004029: [macosx] The long Tab titles are not clipped with dots at the end.

-Original Message- From: Shashidhara Veerabhadraiah Sent: Monday, September 11, 2017 9:37 AM To: Sergey Bylokhov ; Prasanta Sadhukhan ; swing-dev@openjdk.java.net Subject: Re: [10] JDK-8004029: [macosx] The long Tab titles are not clipped with dots at the end. Right Sergey. I was not

Re: [10] JDK-8004029: [macosx] The long Tab titles are not clipped with dots at the end.

Right Sergey. I was not sure on how to represent it under this Webrev. I will update the Webrev if need be. Thanks and regards, Shashi -Original Message- From: Sergey Bylokhov Sent: Saturday, September 9, 2017 7:33 AM To: Shashidhara Veerabhadraiah ; Prasanta Sadhukhan ; swing-dev

Re: [10] JDK-8004029: [macosx] The long Tab titles are not clipped with dots at the end.

santa Sadhukhan wrote: > Fix looks good. > > But, can you update > test/javax/swing/JTabbedPane/4310381/bug4310381.java > to include the test for all installed l&fs so that we can see if there > is problem in any other l&fs? > > Regards > Prasanta > On 8/

[10] JDK-8004029: [macosx] The long Tab titles are not clipped with dots at the end.

Hi All, Please review a fix for the JDK- 8004029 where the long tab titles were not clipped with the dots at the end to indicate a lengthy title. The aqua look and feel which is the default laf for mac does the title clipping only leading to an ambiguous UI where in the clipped title would look

Re: [10] JDK-8178106: There is no error message pop up when clicking 'create folder' button

Hi Sergey, Please find the new Webrev to fix the comments: http://cr.openjdk.java.net/~pkbalakr/shashi/8178106/webrev.03/ Thanks and regards, Shashi -Original Message- From: Sergey Bylokhov Sent: Tuesday, August 1, 2017 2:05 AM To: Shashidhara Veerabhadraiah ; Prasanta Sadhukhan Cc

  1   2   >