Re: [Toybox] [PATCH] Fix devmem build with clang.

2024-11-08 Thread enh
tch attached... On Thu, Nov 7, 2024 at 10:28 AM enh wrote: > > --- > lib/portability.h | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > 0001-devmem.c-simplify-the-8-byte-long-support.patch Description: Binary data ___

Re: [Toybox] readdir() and deleted files

2024-11-08 Thread enh
On Fri, Nov 8, 2024 at 6:02 AM Rob Landley wrote: > On 11/7/24 11:47, enh wrote: > > looking at > > https://lore.kernel.org/lkml/20241107005831.15434-1-e...@google.com/T/#u > i > > note that there _is_ a difference between glibc readdir() and bionic/musl > >

[Toybox] readdir() and deleted files

2024-11-07 Thread enh
looking at https://lore.kernel.org/lkml/20241107005831.15434-1-e...@google.com/T/#u i note that there _is_ a difference between glibc readdir() and bionic/musl readdir() --- glibc explicitly doesn't report any entry where d_ino is 0. i couldn't find any documentation on this, so i don't know wheth

[Toybox] [PATCH] Fix devmem build with clang.

2024-11-07 Thread enh
--- lib/portability.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) 0001-Fix-devmem-build-with-clang.patch Description: Binary data ___ Toybox mailing list Toybox@lists.landley.net http://lists.landley.net/listinfo.cgi/toybox-landley.net

Re: [Toybox] [PATCH] awk -- more patches

2024-11-04 Thread enh
On Thu, Oct 31, 2024 at 7:35 PM Ray Gardner wrote: > > On Tue, Oct 29, 2024 at 6:39 PM enh wrote: > > > On Tue, Oct 29, 2024 at 3:15 PM Rob Landley wrote: > >> > >> On 10/23/24 21:01, Ray Gardner wrote: > > > i certainly had trouble when AOSP bust on

Re: [Toybox] GNU autotools are not working

2024-11-03 Thread enh
On Sun, Nov 3, 2024, 16:29 Rob Landley wrote: > On 11/3/24 13:24, Brian Mayer wrote: > > This time I sent it correctly to the list! > > And my first reply went just to you, because _I_ forgot to manually add > the list to my reply window. Sigh... > > And cutting and pasting the previous reply int

Re: [Toybox] GNU autotools are not working

2024-10-31 Thread enh
On Wed, Oct 30, 2024 at 7:01 PM Rob Landley wrote: > On 10/29/24 13:53, Brian Mayer wrote: > > Hi. > > > > I'm trying to compile GNU make v3.79 using toybox and tcc, but it > > fails on the configure part. > > That's odd, https://github.com/landley/toybox/issues/461 managed to > build gmake once

Re: [Toybox] [PATCH] Support non memory mapped access

2024-10-29 Thread enh
On Tue, Oct 29, 2024 at 1:15 PM Rob Landley wrote: > On 10/25/24 15:14, Karthik Ramasubramanian wrote: > >> I already stripped the android files off and applied it locally > >> yesterday, although that was mostly so I could go: > >> > >> git diff -b HEAD^1 HEAD > >> > > Sorry that I added and

Re: [Toybox] [PATCH] awk -- more patches

2024-10-29 Thread enh
On Tue, Oct 29, 2024 at 3:15 PM Rob Landley wrote: > On 10/23/24 21:01, Ray Gardner wrote: > >> Anyway, I'm not seeing that warning on android-ndk-r26d's llvm, do I > >> need a newer one...? (I can apply just the parentheses removal but I > >> didn't want to edit hunks out of your patch without a

Re: [Toybox] [PATCH] Support non memory mapped access

2024-10-25 Thread enh
yeah, with the later xlseek()s removed, the initial one makes sense. but i told you that having both smelled like a bug, even if i wanted to remove the wrong one :-) On Fri, Oct 25, 2024 at 4:20 PM Karthik Ramasubramanian wrote: > > > On Thu, Oct 24, 2024 at 7:45 AM enh wrote: >

Re: [Toybox] [PATCH] Support non memory mapped access

2024-10-24 Thread enh
On Wed, Oct 23, 2024 at 7:02 PM Karthikeyan Ramasubramanian < krama...@google.com> wrote: > Add --no-mmap flag to indicate seek and read/write access. This allows > accessing devices that do not support mapping into memory - eg. > /dev/nvram, /dev/msr0 etc. > > Also currently only WIDTH bytes are

Re: [Toybox] [PATCH] awk -- more patches

2024-10-23 Thread enh
the Android.bp file for toybox has "-Wno-string-plus-int", since this is quite common in toybox code. On Wed, Oct 23, 2024 at 1:24 PM Rob Landley wrote: > On 10/18/24 18:09, Ray Gardner wrote: > > The attached patches (tested with git am) bring toybox awk up to date. > > The first two

Re: [Toybox] Microsoft github is disabling my account on the 7th.

2024-09-27 Thread enh
On Fri, Sep 27, 2024 at 4:37 PM Ray Gardner wrote: > On Wed, Sep 25, 2024 at 3:58 PM enh wrote: > > > On Wed, Sep 25, 2024 at 2:19 PM Rob Landley wrote: > >> > >> On 9/25/24 10:48, enh wrote: > >> > On Wed, Sep 25, 2024 at 11:14 AM Rob Landley wrote:

Re: [Toybox] Microsoft github is disabling my account on the 7th.

2024-09-25 Thread enh
On Wed, Sep 25, 2024 at 2:19 PM Rob Landley wrote: > On 9/25/24 10:48, enh wrote: > > On Wed, Sep 25, 2024 at 11:14 AM Rob Landley wrote: > > > GitHub users are now required to enable two-factor authentication > as > > > an additional security measure. Yo

Re: [Toybox] Microsoft github is disabling my account on the 7th.

2024-09-25 Thread enh
On Wed, Sep 25, 2024 at 11:14 AM Rob Landley wrote: > > GitHub users are now required to enable two-factor authentication as > > an additional security measure. Your activity on GitHub includes you > > in this requirement. You will need to enable two-factor authentication > > on your account befo

[Toybox] date tests still disabled

2024-09-17 Thread enh via Toybox
is it intentional that the date tests are still non-executable? (they've been running just fine for me on Android, where i ignore the execute bit...) ___ Toybox mailing list Toybox@lists.landley.net http://lists.landley.net/listinfo.cgi/toybox-landley.net

Re: [Toybox] [PATCH] cp: fix -i and -v messages.

2024-09-13 Thread enh via Toybox
On Thu, Sep 12, 2024 at 11:35 PM Rob Landley wrote: > On 9/10/24 17:16, enh via Toybox wrote: > > cp -i was showing the _source_ rather than the destination, while -v > > was only showing the source rather than the source _and_ the destination. > > In theory flags is sep

[Toybox] [PATCH] cp: fix -i and -v messages.

2024-09-10 Thread enh via Toybox
cp -i was showing the _source_ rather than the destination, while -v was only showing the source rather than the source _and_ the destination. --- toys/posix/cp.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) From 183b806786958be87e04ffa55a1d358b67183539 Mon Sep 17 00:00:0

Re: [Toybox] [PATCH] awk -- fixes and cleanups

2024-09-09 Thread enh via Toybox
On Mon, Sep 9, 2024 at 10:49 AM Rob Landley wrote: > > On 9/7/24 21:04, Ray Gardner wrote: > > On Tue, Sep 3, 2024 at 11:43 PM Rob Landley wrote: > >> > >> Sorry, been sick in my Tokyo hotel bed since before the typhoon ended. > > > > Hope you're doing better by now. > > Better is a relative term

Re: [Toybox] [PATCH] Support diff --no-dereference

2024-09-05 Thread enh via Toybox
On Thu, Sep 5, 2024 at 10:38 AM Rob Landley wrote: > > On 9/4/24 13:53, enh wrote: > > thanks (and hope you're feeling better soon)! > > Me too. It's persistent. > > > unfortunately this breaks the toybox tests when run with a toybox > > userspace. sp

Re: [Toybox] [PATCH] Support diff --no-dereference

2024-09-05 Thread enh via Toybox
On Thu, Sep 5, 2024 at 10:17 AM Rob Landley wrote: > > FYI I hadn't sent this old reply because I instead just applied the patch > as-is > after _two_ timeout pokes, but if it _still_ doesn't quite work, for the > record > my initial objections were... >

[Toybox] [PATCH] diff.c: fix warnings.

2024-09-05 Thread enh via Toybox
Also make xlstat() pull its weight a bit better. --- toys/pending/diff.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) 0001-diff.c-fix-warnings.patch Description: Binary data ___ Toybox mailing list Toybox@lists.landley.net http://li

Re: [Toybox] [PATCH] Support diff --no-dereference

2024-09-04 Thread enh via Toybox
"symbolic link"}; printf("File %s is a %s while file %s is a %s\n", files[0], fidir[!i], files[1], fidir[i]); TT.differ = 1; } else { behavior isn't the diffutils default? On Wed, Sep 4, 2024 at 3:06 AM Rob Landley wrote: > > On 9/3/24 07:02,

Re: [Toybox] [PATCH] Support diff --no-dereference

2024-09-03 Thread enh via Toybox
ping again on this patch... it's wanted for kernel builds. On Mon, Aug 26, 2024 at 5:30 PM enh wrote: > > ...but ignoring the bikeshed of "should we do something about all the > _other_ readlink callers" --- ping on this specific patch :-) > > On Fri, Aug 23, 2024

[Toybox] [PATCH] ps.c: fix typo.

2024-08-30 Thread enh via Toybox
Android's new "foreground_window" cgroup uses an underscore, unlike all the previous cgroups which used hyphens. Sadly, it's too late to fix the inconsistency now. --- toys/posix/ps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) 0001-ps.c-fix-typo.patch Description: Binary data

Re: [Toybox] [PATCH] ps: drop dependency on Android's libprocessgroup.

2024-08-27 Thread enh via Toybox
On Mon, Aug 26, 2024 at 6:45 PM T.J. Mercier wrote: > > On Mon, Aug 26, 2024 at 3:01 PM enh wrote: > > > > On Mon, Aug 26, 2024 at 11:14 AM T.J. Mercier wrote: > > > > > > On Fri, Aug 23, 2024 at 3:52 PM enh wrote: > > > > > > > > T

Re: [Toybox] [PATCH] ps: drop dependency on Android's libprocessgroup.

2024-08-26 Thread enh via Toybox
On Mon, Aug 26, 2024 at 11:14 AM T.J. Mercier wrote: > > On Fri, Aug 23, 2024 at 3:52 PM enh wrote: > > > > This dependency keeps getting hairier and hairier (json!) and the > > current system for policy scheduling is actually quite different from > > the ori

Re: [Toybox] [PATCH] Support diff --no-dereference

2024-08-26 Thread enh via Toybox
...but ignoring the bikeshed of "should we do something about all the _other_ readlink callers" --- ping on this specific patch :-) On Fri, Aug 23, 2024 at 3:15 PM Rob Landley wrote: > > > > On 8/23/24 06:33, enh wrote: > > On Fri, Aug 23, 2024 at 3:32 AM Rob Landley

[Toybox] [PATCH] ps: drop dependency on Android's libprocessgroup.

2024-08-23 Thread enh via Toybox
This dependency keeps getting hairier and hairier (json!) and the current system for policy scheduling is actually quite different from the original anyway. --- lib/portability.h | 14 -- toys/posix/ps.c | 33 - 2 files changed, 28 insertions(+), 19 de

Re: [Toybox] [PATCH] Support diff --no-dereference

2024-08-23 Thread enh via Toybox
On Fri, Aug 23, 2024 at 3:32 AM Rob Landley wrote: > > On 8/22/24 08:23, enh via Toybox wrote: > > + int s = sizeof(toybuf)/2; > > + > > + TT.is_symlink = 1; > > + for (i = 0; i < 2; i++) { > > +TT.link[i].name = toybuf + i * s; > > +TT.link

Re: [Toybox] [PATCH] Support diff --no-dereference

2024-08-22 Thread enh via Toybox
+ int s = sizeof(toybuf)/2; + + TT.is_symlink = 1; + for (i = 0; i < 2; i++) { +TT.link[i].name = toybuf + i * s; +TT.link[i].len = readlink0(files[i], TT.link[i].name, s); should probably use xreadlink() and free() instead? toybuf is big enough to be safe for _one_ path on linux, but n

[Toybox] vhangup(2)

2024-08-21 Thread enh via Toybox
fyi in case it's news to you too, TIL that vhangup(2) exists, and init/login/getty seem like the only processes that might actually want to use it... ___ Toybox mailing list Toybox@lists.landley.net http://lists.landley.net/listinfo.cgi/toybox-landley.net

Re: [Toybox] [PATCH] host: fix duplicate strings.

2024-08-05 Thread enh via Toybox
ewer magic numbers in toybox... On Sun, Aug 4, 2024 at 8:55 AM Rob Landley wrote: > > On 8/2/24 15:50, enh via Toybox wrote: > > Fixes #396 and theoretically the same bug but for records, though > > in practice `toybox host www.google.com` isn't showing me record

[Toybox] [PATCH] host: fix duplicate strings.

2024-08-02 Thread enh via Toybox
Fixes #396 and theoretically the same bug but for records, though in practice `toybox host www.google.com` isn't showing me records like `host www.google.com` does. --- toys/net/host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) From 8faca0b8bac7c1c7b9eb3e6920488c4e97b57fe7 Mon

[Toybox] [PATCH] file: don't print ELF flags unless we've verified the bitness.

2024-08-02 Thread enh via Toybox
This was the file(1) crash mentioned in #503. --- tests/file.test | 3 +++ toys/posix/file.c | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) From 950c6d3edbbde6cda00c908e7a4b33ecb3aeed48 Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Fri, 2 Aug 2024 16:20:00 -0400 Subject: [PATCH]

[Toybox] [PATCH] getty: fix /etc/issue output.

2024-08-02 Thread enh via Toybox
Also simplify/depessimize the code a bit. `./toybox getty 300 -` works for me (including outputting /etc/issue) on Debian after this. Fixes #508. --- toys/pending/getty.c | 43 +-- 1 file changed, 21 insertions(+), 22 deletions(-) From 11e9fd923b43e1c7224b2

Re: [Toybox] [PATCH] tar.test: don't test non-`-p` behavior as root.

2024-08-02 Thread enh via Toybox
On Thu, Aug 1, 2024 at 10:08 PM Rob Landley wrote: > > On 8/1/24 10:24, enh wrote: > >> > i'm not sure what you're talking about? this isn't a hash-related test? > ... > >> The tar "ownership" test. > >> > >> FAIL: tar own

[Toybox] [PATCH] devmem.test: ignore whitespace.

2024-08-01 Thread enh via Toybox
Yet again, I am victim of my own bad habit of only testing on my Debian desktop... It turns out that [current] Debian od uses a single space between fields, macOS od uses a tab between fields, and toybox od uses 4 spaces between fields. (Given that POSIX just says "one or more characters", I assum

[Toybox] [PATCH] devmem: add --no-sync option.

2024-08-01 Thread enh via Toybox
Although O_SYNC is what you want 99% of the time, there is also a use for not supplying the flag. See drivers/char/mem.c's uncached_access(). The big question here is probably the bikeshed issue of whether to name the option after what it does (disable the O_SYNC flag) or _why_ you're doing that.

Re: [Toybox] [PATCH] tar.test: don't test non-`-p` behavior as root.

2024-08-01 Thread enh via Toybox
On Thu, Aug 1, 2024 at 1:06 AM Rob Landley wrote: > > On 7/29/24 16:27, enh wrote: > > On Sat, Jul 27, 2024 at 3:51 PM Rob Landley wrote: > >> On 7/23/24 14:55, enh via Toybox wrote: > >> > Fixes https://github.com/landley/toybox/issues/512. > >> > &

Re: [Toybox] [PATCH] sendfile_len: fix bounds check.

2024-07-31 Thread enh via Toybox
oh, and the unconcluded thought in the commit message is "...but it seems unreasonable to add a test that requires > 2GiB of disk space, so i haven't included a new test in this patch". On Wed, Jul 31, 2024 at 4:09 PM enh wrote: > > this is actually a regression in Androi

Re: [Toybox] [PATCH] sendfile_len: fix bounds check.

2024-07-31 Thread enh via Toybox
parate cosmetic issue i noticed while testing: ``` /tmp/x$ ~/toybox-tar/toybox tar xvf ~/toybox-tar/x/x.tar tar: tar: had errors two two-and-a-half /tmp/x$ ls -l total 4657156 -rw-r- 1 enh primarygroup 2147483648 Jul 31 15:44 two -rw-r- 1 enh primarygroup 2621441024 Jul 31 15:45 two-and-a-ha

[Toybox] [PATCH] sendfile_len: fix bounds check.

2024-07-31 Thread enh via Toybox
We want to check whether the next call we make will try to send more than 1<<30 bytes, not whether the total number of bytes to transfer is more than that. Interestingly, the read() fallback implementation already has the right check, presumably because files larger than libbuf are commonplace, wh

Re: [Toybox] [PATCH] devmem: add -f FILE, arbitrary amounts of data.

2024-07-31 Thread enh via Toybox
ping? On Mon, Jul 29, 2024 at 8:48 AM enh wrote: > > ping? > > On Fri, Jul 26, 2024 at 7:52 PM Rob Landley wrote: > > > > On 7/26/24 07:13, enh via Toybox wrote: > > >> Don't know Rob cares about this, but ?: is not ISO C. It's a GNU > > &g

Re: [Toybox] [PATCH] tar.test: don't test non-`-p` behavior as root.

2024-07-29 Thread enh via Toybox
1554 + +++ actual 2024-07-29 21:26:48.668171554 + @@ -1,2 +1,2 @@ -drwxr-xr-x --rwxr-xr-x +drwxrwxrwx +-rwxrwxrwx On Sat, Jul 27, 2024 at 3:51 PM Rob Landley wrote: > > On 7/23/24 14:55, enh via Toybox wrote: > > Fixes https://github.com/landley/toybox/issues/512. > > Ap

Re: [Toybox] [PATCH] devmem: add -f FILE, arbitrary amounts of data.

2024-07-29 Thread enh via Toybox
ping? On Fri, Jul 26, 2024 at 7:52 PM Rob Landley wrote: > > On 7/26/24 07:13, enh via Toybox wrote: > >> Don't know Rob cares about this, but ?: is not ISO C. It's a GNU > >> extension. > > Specifically https://gcc.gnu.org/onlinedocs/gcc-14.1.0/gcc/Condi

Re: [Toybox] [PATCH] devmem: add -f FILE, arbitrary amounts of data.

2024-07-26 Thread enh via Toybox
with 80 existing uses of https://en.wikipedia.org/wiki/Elvis_operator in toybox, i'm pretty sure rob knows this already :-) On Thu, Jul 25, 2024 at 6:01 PM Ivo van Poorten wrote: > > On Thu, 25 Jul 2024 14:17:51 -0400 enh via Toybox > wrote: > > +fd = xopen(TT.f ?:

[Toybox] [PATCH] devmem: add -f FILE, arbitrary amounts of data.

2024-07-25 Thread enh via Toybox
-f lets people use /dev/port for x86 i/o ports (rather than needing a separate x86-only command), or /dev/nvram, or /dev/cpu/*/msr, or /sys/bus/pci/devices/*:*:*.* ... you get the idea. It also means we can write some tests. (Though of course, the tests don't tell us whether this actually works wi

[Toybox] [PATCH] tar.test: don't test non-`-p` behavior as root.

2024-07-23 Thread enh via Toybox
Fixes https://github.com/landley/toybox/issues/512. --- tests/tar.test | 1 + 1 file changed, 1 insertion(+) From 77d366f65905d527a6d49c75284a3a12e9864980 Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Tue, 23 Jul 2024 15:52:51 -0400 Subject: [PATCH] tar.test: don't test non-`-p` behavior as

Re: [Toybox] toybox tar test failure

2024-07-23 Thread enh via Toybox
(see debugging on http://github.com/landley/toybox/issues/512.) On Thu, Jul 18, 2024 at 5:53 PM Rob Landley wrote: > > On 7/17/24 07:56, enh wrote: > >> > FAIL: tar honor umask > >> > echo -ne '' | umask 0022 && rm -rf dir && mkdir dir

Re: [Toybox] toybox tar test failure

2024-07-17 Thread enh via Toybox
On Wed, Jul 17, 2024 at 3:07 AM Rob Landley wrote: > > On 7/15/24 12:11, enh via Toybox wrote: > > tried to sync this morning, but i'm getting a new tar test failure: > > Saw this yesterday but didn't have the email laptop with me. (I need to move > that over.

Re: [Toybox] toybox tar test failure

2024-07-16 Thread enh via Toybox
On Mon, Jul 15, 2024 at 7:03 PM Ray Gardner wrote: > > On Mon, Jul 15, 2024 at 11:12 AM enh via Toybox > wrote: > > [snip] > > also (since possibly WAI, and not a blocker because we ignore toybox > > failures in tests if we're not using the toybox implementation)

[Toybox] toybox tar test failure

2024-07-15 Thread enh via Toybox
tried to sync this morning, but i'm getting a new tar test failure: FAIL: tar honor umask echo -ne '' | umask 0022 && rm -rf dir && mkdir dir && tar xf $FILES/tar/dir.tar && stat -c%A dir dir/file --- expected 2024-07-15 16:20:47.217287424 + +++ actual 2024-07-15 16:20:47.257287423 + @@ -1

Re: [Toybox] gcc vs llvm -static-libasan

2024-07-09 Thread enh via Toybox
On Tue, Jul 9, 2024 at 3:06 PM Rob Landley wrote: > > On 7/9/24 12:35, enh wrote: > > On Tue, Jul 9, 2024 at 10:02 AM enh wrote: > >> On Tue, Jul 9, 2024 at 8:47 AM Rob Landley wrote: > >> > >> i'll forward this to the llvm asan folks anyway, in par

Re: [Toybox] gcc vs llvm -static-libasan

2024-07-09 Thread enh via Toybox
On Tue, Jul 9, 2024 at 2:49 PM Rob Landley wrote: > > On 7/9/24 09:02, enh wrote: > > On Tue, Jul 9, 2024 at 8:47 AM Rob Landley wrote: > >> Any suggestions? > > > > none you're going to like, but... > > I don't have to like it, I just have to mak

Re: [Toybox] gcc vs llvm -static-libasan

2024-07-09 Thread enh via Toybox
On Tue, Jul 9, 2024 at 10:02 AM enh wrote: > > On Tue, Jul 9, 2024 at 8:47 AM Rob Landley wrote: > > > > On 6/12/24 16:08, Rob Landley wrote: > > > The new debian toolchain also broke gcc/glibc ASAN, complaining (at > > > runtime) > > > "ASan r

Re: [Toybox] gcc vs llvm -static-libasan

2024-07-09 Thread enh via Toybox
On Tue, Jul 9, 2024 at 8:47 AM Rob Landley wrote: > > On 6/12/24 16:08, Rob Landley wrote: > > The new debian toolchain also broke gcc/glibc ASAN, complaining (at > > runtime) > > "ASan runtime does not come first in initial library list; you should > > either link runtime to your application or

Re: [Toybox] awk (was: strlower() bug)

2024-06-12 Thread enh via Toybox
On Wed, Jun 12, 2024 at 4:57 PM Rob Landley wrote: > > On 6/11/24 16:56, Ray Gardner wrote: > > Elliot, thanks for the positive feedback on the docs, but I really > > wish you and Rob would try the program. I waited a while to see what > > Rob would have to say. He doesn't seem the sort to be at a

Re: [Toybox] [PATCH] vi: rename `-s` flag to `-c`

2024-06-11 Thread enh via Toybox
On Tue, Jun 11, 2024 at 4:53 AM Rob Landley wrote: > > On 6/7/24 03:41, Rob Landley wrote: > > On 6/5/24 00:46, Jarno Mäkipää wrote: > >> You cannot test against other vi clones with -c after this patch. But > >> you could have test against vim with -s {script} implementation. I > >> used vim as r

Re: [Toybox] [PATCH] microcom, stty: Use TCSADRAIN to set tty device attribute

2024-05-31 Thread enh via Toybox
On Fri, May 31, 2024, 11:08 Rob Landley wrote: > On 5/20/24 23:43, Yi-Yo Chiang via Toybox wrote: > > Don't flush the tty device input queue when setting device attribute. > > > > Rationale: > > * microcom: The tty device might already have a _good enough_ termios > > to read data from. Flu

Re: [Toybox] strlower() bug

2024-05-31 Thread enh via Toybox
On Fri, May 31, 2024 at 12:30 PM Rob Landley wrote: > > On 5/30/24 16:12, enh wrote: > >> > hmm... looking at Apple's online FreeBSD code, it looks like they have > >> > very different (presumably older) FreeBSD code > >> > [https://opensource.ap

Re: [Toybox] strlower() bug

2024-05-30 Thread enh via Toybox
On Wed, May 29, 2024 at 5:50 AM Rob Landley wrote: > > On 5/22/24 09:30, enh wrote: > > On Tue, May 14, 2024 at 2:58 PM Rob Landley wrote: > >> It looks like macos towlower() refuses to return expanding unicode > >> characters. > >> Possibly to avoid

Re: [Toybox] this week in weird coreutils stuff: chmod

2024-05-30 Thread enh via Toybox
want the underlying type :-) On Thu, May 30, 2024 at 3:41 AM Rob Landley wrote: > > > > On 5/29/24 14:20, enh wrote: > > seems to have broken the macOS build? > > ``` > > lib/lib.c:953:10: error: conflicting types for 'string_to_mode' > > unsigned string_t

[Toybox] [PATCH] getconf: add NPROCESSORS_CONF and NPROCESSORS_ONLN.

2024-05-30 Thread enh via Toybox
New (https://austingroupbugs.net/view.php?id=339) names for the existing _NPROCESSORS_CONF and _NPROCESSORS_ONLN. --- toys/posix/getconf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) 0001-getconf-add-NPROCESSORS_CONF-and-NPROCESSORS_ONLN.patch Description: Binary data ___

[Toybox] [PATCH] Fix ionice's return value for getting process IO priority

2024-05-30 Thread enh via Toybox
[note: this isn't my patch; it was https://android-review.googlesource.com/c/platform/external/toybox/+/3106282, and i'm just forwarding it. the attachment is the original patch with the original author's details, and i've cc:ed them. lgtm to me, though, and matches the next function in the same fi

Re: [Toybox] this week in weird coreutils stuff: chmod

2024-05-29 Thread enh via Toybox
^ ``` On Wed, May 29, 2024 at 12:29 PM Rob Landley wrote: > > On 5/28/24 08:00, enh via Toybox wrote: > > apparently chmod allows something like > > > > chmod u+rwX-s,g+rX-ws,o+rX-wt > > > > as a (far less readable!) synonym for > > > > chmod

[Toybox] this week in weird coreutils stuff: chmod

2024-05-28 Thread enh via Toybox
apparently chmod allows something like chmod u+rwX-s,g+rX-ws,o+rX-wt as a (far less readable!) synonym for chmod u+rwX,u-s,g+rX,g-ws,o+rX,o-wt i'm told that toybox silently accepts the former too, but does not interpret it as if it means the latter? _

Re: [Toybox] strlower() bug

2024-05-22 Thread enh via Toybox
On Tue, May 14, 2024 at 2:58 PM Rob Landley wrote: > > > > On 5/14/24 12:12, enh wrote: > > On Tue, May 14, 2024 at 1:04 PM Rob Landley wrote: > >> > >> On 5/14/24 07:10, enh wrote: > >> > macOS tests seem to be broken since this commit? > &g

Re: [Toybox] awk (was: strlower() bug)

2024-05-22 Thread enh via Toybox
interesting docs, thanks! i see you're already running the one-true-awk test suite, which was the only suggestion i would have had, and you're running it against "all the awks", which is even better than what i had in mind :-) On Tue, May 14, 2024 at 10:37 PM Ray Gardner wrote: > > On Fri, May 1

Re: [Toybox] [PATCH] netcat: clarify documentation.

2024-05-22 Thread enh via Toybox
On Wed, May 22, 2024 at 2:30 AM Rob Landley wrote: > > On 5/20/24 07:06, enh via Toybox wrote: > > "Collate" means "sort", but -O is like -o other than buffering. > > It means "group". (The dictionary says "gather or arrange in the proper &

Re: [Toybox] microcom.c discarding data due to TCSAFLUSH

2024-05-20 Thread enh via Toybox
On Mon, May 20, 2024 at 10:43 AM Yi-Yo Chiang wrote: > > Found this out today when comparing captured logs. Every time I connect to a > pty the first few hundreds of bytes seem to always be missing. > I then traced to this line > https://github.com/landley/toybox/blob/master/toys/net/microcom.c#

Re: [Toybox] [PATCH] xputs: Do flush

2024-05-20 Thread enh via Toybox
On Sun, May 19, 2024 at 10:56 PM Rob Landley wrote: > > On 5/18/24 21:53, Yi-Yo Chiang wrote: > > What I wanted to address with this patch are: > > > > 1. Fix this line of > > xputs() > > https://github.com/landley/toybox/blob/master/toys/net/microcom.c#L113 > > The prompt text is not flushed imm

[Toybox] [PATCH] netcat: clarify documentation.

2024-05-20 Thread enh via Toybox
"Collate" means "sort", but -O is like -o other than buffering. --- toys/net/netcat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) 0001-netcat-clarify-documentation.patch Description: Binary data ___ Toybox mailing list Toybox@lists.landley.ne

Re: [Toybox] netcat -f bug

2024-05-15 Thread enh via Toybox
On Sat, May 11, 2024 at 3:12 AM Yi-Yo Chiang via Toybox wrote: > > > > On Sat, May 11, 2024 at 1:30 AM Rob Landley wrote: >> >> What's your use case triggering this patch? Because without that, I go off on >> various design tangents, as seen below: > > > I just wanted some tool to communicate wit

Re: [Toybox] strlower() bug

2024-05-14 Thread enh via Toybox
On Tue, May 14, 2024 at 1:04 PM Rob Landley wrote: > > On 5/14/24 07:10, enh wrote: > > macOS tests seem to be broken since this commit? > > > > FAIL: find strlower edge case > > echo -ne '' | touch aⱥ; find . -iname aȺ > > --

Re: [Toybox] I'm aware landley.net is saying "site.not found".

2024-05-14 Thread enh via Toybox
seems to be working again now... On Mon, May 13, 2024 at 11:55 PM Rob Landley wrote: > > That dreamhost server migration they did? (The recent "only 2 years old" > version > thread?) Does not seem to have correctly updated the DNS record. Of the domain > they manage for me. > > Dreamhost continu

Re: [Toybox] strlower() bug

2024-05-14 Thread enh via Toybox
macOS tests seem to be broken since this commit? FAIL: find strlower edge case echo -ne '' | touch aⱥ; find . -iname aȺ --- expected 2024-05-10 17:32:56.0 + +++ actual 2024-05-10 17:32:56.0 + @@ -1 +0,0 @@ -./aⱥ On Wed, May 8, 2024 at 9:

[Toybox] [PATCH] find: use S_ISREG() rather than inlining it.

2024-05-10 Thread enh via Toybox
--- toys/posix/find.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) 0001-find-use-S_ISREG-rather-than-inlining-it.patch Description: Binary data ___ Toybox mailing list Toybox@lists.landley.net http://lists.landley.net/listinfo.cgi/toybox-landl

Re: [Toybox] unshare/nsenter and flags

2024-05-02 Thread enh via Toybox
On Thu, May 2, 2024 at 6:17 PM Rob Landley wrote: > > On 5/2/24 13:14, enh via Toybox wrote: > > another googler wanted a host unshare(1) for some testing... i added > > that, and they complained that although the docs say > > > > -r Become root (map curren

[Toybox] unshare/nsenter and flags

2024-05-02 Thread enh via Toybox
another googler wanted a host unshare(1) for some testing... i added that, and they complained that although the docs say -r Become root (map current euid/egid to 0/0, implies -U) (--map-root-user) it seems like -r _doesn't_ actually imply -U in practice (and they seemed to have strace output

Re: [Toybox] nproc(1)

2024-05-02 Thread enh via Toybox
(to be fair, i was shocked the first time i had to deal with an Android device where these weren't both the same...) On Thu, May 2, 2024 at 9:18 AM enh wrote: > > /facepalm > > maybe move your hand-written version into portability just for musl, > and everyone with a wo

Re: [Toybox] nproc(1)

2024-05-02 Thread enh via Toybox
/facepalm maybe move your hand-written version into portability just for musl, and everyone with a working libc just uses sysconf()? On Tue, Apr 30, 2024 at 8:26 PM Rob Landley wrote: > > On 4/29/24 16:56, enh via Toybox wrote: > > isn't nproc(1) just a call to sysco

[Toybox] nproc(1)

2024-04-29 Thread enh via Toybox
isn't nproc(1) just a call to sysconf(3) with either _SC_NPROCESSORS_ONLN for regular behavior, or _SC_NPROCESSORS_CONF for --all? that works fine for macOS too... ___ Toybox mailing list Toybox@lists.landley.net http://lists.landley.net/listinfo.cgi/toy

Re: [Toybox] [PATCH] readelf: Zero Pad -S section numbers (More scriptable through cut/awk)

2024-04-26 Thread enh via Toybox
but this isn't what anyone else's readelf does... so now anyone scripting has _two_ problems. (or a bug, if they've only tested against toybox.) honestly, if you're scripting, you should switch to llvm-readelf and its less-machine-unreadable alternative output format instead. On Thu, Apr 25, 202

Re: [Toybox] [PATCH] xxd: -d Decimal Lables flag, Don't cap at one file

2024-04-22 Thread enh via Toybox
On Mon, Apr 22, 2024 at 2:23 PM Oliver Webb wrote: > > > On Sat, Apr 20, 2024 at 7:38 PM Oliver Webb via Toybox > > toybox@lists.landley.net wrote: > > > > xxd also runs on average about 5 times slower than vim xxd, this is > > > because of read reading 16 bytes at a time, also not hard to fix, bu

[Toybox] [PATCH] xxd: buffer input via stdio.

2024-04-22 Thread enh via Toybox
--- toys/other/xxd.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) 0001-xxd-buffer-input-via-stdio.patch Description: Binary data ___ Toybox mailing list Toybox@lists.landley.net http://lists.landley.net/listinfo.cgi/toybox-landley.net

Re: [Toybox] [PATCH] xxd: -d Decimal Lables flag, Don't cap at one file

2024-04-22 Thread enh via Toybox
On Sat, Apr 20, 2024 at 7:38 PM Oliver Webb via Toybox wrote: > > Looking at xxd, I noticed that the -b[inary] flag wasn't there, > Having some facility to print binary is nice, but since printf > doesn't have anything in built for it implementing it isn't hard, > but it looks _ugly_. Which is why

Re: [Toybox] today in "shut up, gnu!"

2024-04-15 Thread enh via Toybox
i'd been deliberately _not_ sending you https://www.phoronix.com/news/GNU-Coreutils-9.5-Released for fear of winding you up :-) On Sat, Apr 13, 2024 at 7:34 AM Rob Landley wrote: > > On 4/12/24 13:24, enh via Toybox wrote: > > ~/aosp-main-with-phones$ find external/ -na

[Toybox] today in "shut up, gnu!"

2024-04-12 Thread enh via Toybox
~/aosp-main-with-phones$ find external/ -name NOTICE -type l -maxdepth 2 find: warning: you have specified the global option -maxdepth after the argument -name, but global options are not positional, i.e., -maxdepth affects tests specified before it as well as those specified after it. Please spec

Re: [Toybox] [PATCH] timeout.test: reduce flake.

2024-04-12 Thread enh via Toybox
, and now I'm at texas linuxfest doing sleep deprived talk > prep > for tomorrow...) > > On 4/8/24 15:28, enh via Toybox wrote: > > A (presumably overloaded) CI server saw the `exit 0` test time out. > > Given that several of these tests should just fail immediately, >

[Toybox] [PATCH] timeout.test: reduce flake.

2024-04-08 Thread enh via Toybox
A (presumably overloaded) CI server saw the `exit 0` test time out. Given that several of these tests should just fail immediately, having a huge timeout isn't even a bad thing --- if we had a bug that caused us to report the correct status, but not until the timeout had _also_ expired, this would

[Toybox] tail test failures?

2024-04-08 Thread enh via Toybox
looks like the github CI has been red for ubuntu and macOS since april 5th? this revert fixes the current failing test: [master 8368f8f9] Revert "Enforce min/max for % input type (time in seconds w/millisecond granularity)." but that just gets me a different failing test, so it's obviously a bit

Re: [Toybox] utf8towc(), stop being defective on null bytes

2024-04-08 Thread enh via Toybox
On Sun, Apr 7, 2024 at 7:43 AM Oliver Webb via Toybox wrote: > > On Sunday, April 7th, 2024 at 03:54, Rob Landley wrote: > > > As for moving it again someday, unnecessarily moving files is churn that > > makes > > the history harder to see, and lib/*.c has never been a strict division > > (more

[Toybox] more gnu nonsense: cp -n

2024-04-01 Thread enh via Toybox
hadn't seen this one before... cp: warning: behavior of -n is non-portable and may change in future; use --update=none instead (consider me skeptical that a system without -n is going to have --update=none...) ___ Toybox mailing list Toybox@lists.landle

Re: [Toybox] [PATCH] Clean up xz a good amount

2024-03-29 Thread enh via Toybox
On Fri, Mar 29, 2024 at 3:50 PM Oliver Webb wrote: > > > > ah, crap, that's another thing to put on the riscv64 to-do list... > > > (thanks for bringing that to light!) > > > > so, TIL that upstream already added a risc-v bcj implementation... > > I always thought that the xz decompresser we use i

Re: [Toybox] [PATCH] Clean up xz a good amount

2024-03-29 Thread enh via Toybox
On Wed, Feb 28, 2024 at 9:13 AM enh wrote: > > On Tue, Feb 27, 2024 at 8:34 PM Rob Landley wrote: > > > > On 2/27/24 21:27, Oliver Webb wrote: > > > 2 are help text, do_xzcat was due to replacing the case statement for > > > error handling with a array &g

[Toybox] [PATCH] inotifyd: enable line buffering.

2024-03-27 Thread enh via Toybox
Since the point here is to get a notification for every event, and there's one line per event, line buffering is the right choice. --- toys/other/inotifyd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) 0001-inotifyd-enable-line-buffering.patch Description: Binary data __

Re: [Toybox] hexdump tests.

2024-03-27 Thread enh via Toybox
On Wed, Mar 27, 2024 at 6:22 AM Rob Landley wrote: > > On 3/25/24 10:42, enh wrote: > > On Sun, Mar 24, 2024 at 1:40 AM Rob Landley wrote: > >> > >> On 3/22/24 15:02, enh wrote: > >> >> > CANONICALIZE_SPACE_IF_RUNNING_HOST_VERSION=1? so we trus

Re: [Toybox] Poke about the bc.c cleanup patches I submitted a while ago

2024-03-27 Thread enh via Toybox
On Wed, Mar 27, 2024 at 6:22 AM Rob Landley wrote: > > Yesterday I did NOT spend all my energy reading email, and instead got > https://landley.net/bin/toolchains updated with a musl 1.2.5 and or1k and > riscv > in the list, and that seems to have fixed the sh2eb build break as well > (although I

Re: [Toybox] [PATCH] toysh: fix -Wuse-after-free

2024-03-27 Thread enh via Toybox
On Wed, Mar 27, 2024 at 6:47 AM Rob Landley wrote: > > On 3/25/24 20:24, enh wrote: > > But "dpkg-query -S $(which $NAME)" is pretty easy to do the mapping > > yourself on > > debian... > > > > > > (yeah, though i suspect anyone

  1   2   3   4   5   6   7   8   9   10   >