RE: Adding SVN version to Java files

2008-04-29 Thread Mark Combellack
Hi, It looks like the discussions on adding SVN version to Java files has gone quiet again so I'll give it a little prod :-) Previously, the question was asked as to what was the justification for adding the SVN version. I hope I have answered this question satisfactorily. Generally people

Re: Adding SVN version to Java files

2008-04-29 Thread ant elder
properties on new files. ...ant On Tue, Apr 29, 2008 at 1:46 PM, Mark Combellack [EMAIL PROTECTED] wrote: Hi, It looks like the discussions on adding SVN version to Java files has gone quiet again so I'll give it a little prod :-) Previously, the question was asked as to what

RE: Adding SVN version to Java files

2008-04-29 Thread Mark Combellack
@ws.apache.org; [EMAIL PROTECTED] Subject: Re: Adding SVN version to Java files Yes i think we have consensus to do this now, and as a sign of good faith i'll help by (as soon as we get SVN write access back) adding the keywords to the IDE templates we have in SVN and adding text to the developer

Re: Adding SVN version to Java files

2008-04-25 Thread ant elder
On Thu, Apr 24, 2008 at 9:55 AM, Mark Combellack [EMAIL PROTECTED] wrote: snip * Typically, users do not do an SVN checkout of the source code and will not have SVN installed. They are typically provided with a jar file containing the source code. They will not be able to run SVN

Re: Adding SVN version to Java files

2008-04-25 Thread ant elder
On Thu, Apr 24, 2008 at 5:55 PM, Simon Nash [EMAIL PROTECTED] wrote: snip Regarding whether or not we have consensus and whether we should hold a vote, consensus is not the same as unanimity. I think we need to make a decision on this issue (which is relatively minor) and move forward.

Re: Adding SVN version to Java files

2008-04-24 Thread Vamsavardhana Reddy
I would like to know the last revision and date at which a particular file is updated just by opening the file in any editor and without having to do anything extra, for e.g., like installing a plugin for eclipse, opening a command prompt to issue an svn info command (note that the source I have

Re: Adding SVN version to Java files

2008-04-24 Thread Simon Nash
] Subject: Re: Adding SVN version to Java files I would like to know the last revision and date at which a particular file is updated just by opening the file in any editor and without having to do anything extra, for e.g., like installing a plugin for eclipse, opening a command prompt

Re: Adding SVN version to Java files

2008-04-23 Thread Simon Nash
Mark Combellack wrote: -Original Message- From: Jean-Sebastien Delfino [mailto:[EMAIL PROTECTED] Sent: 15 April 2008 02:59 To: tuscany-dev@ws.apache.org Subject: Re: Adding SVN version to Java files Mark Combellack wrote: Hi, I've been looking through the Tuscany source code

Re: Adding SVN version to Java files

2008-04-23 Thread Luciano Resende
:52 AM, Simon Nash [EMAIL PROTECTED] wrote: Mark Combellack wrote: -Original Message- From: Jean-Sebastien Delfino [mailto:[EMAIL PROTECTED] Sent: 15 April 2008 02:59 To: tuscany-dev@ws.apache.org Subject: Re: Adding SVN version to Java files Mark Combellack wrote

Re: Adding SVN version to Java files

2008-04-23 Thread Vamsavardhana Reddy
On Wed, Apr 23, 2008 at 6:22 PM, Simon Nash [EMAIL PROTECTED] wrote: Mark Combellack wrote: -Original Message- From: Jean-Sebastien Delfino [mailto:[EMAIL PROTECTED] Sent: 15 April 2008 02:59 To: tuscany-dev@ws.apache.org Subject: Re: Adding SVN version to Java files

Re: Adding SVN version to Java files

2008-04-23 Thread Venkata Krishnan
] Sent: 15 April 2008 02:59 To: tuscany-dev@ws.apache.org Subject: Re: Adding SVN version to Java files Mark Combellack wrote: Hi, I've been looking through the Tuscany source code and noticed that some files have a @version containing the SVN revision number

Re: Adding SVN version to Java files

2008-04-23 Thread ant elder
On Wed, Apr 23, 2008 at 5:52 PM, Vamsavardhana Reddy [EMAIL PROTECTED] wrote: snip From the above, we have 4 +1s and no -1s - although we have a preference not to do this from ant. So, the consensus is to make this change. We haven't held a formal vote, so I don't think we

RE: Adding SVN version to Java files

2008-04-22 Thread Mark Combellack
-Original Message- From: Jean-Sebastien Delfino [mailto:[EMAIL PROTECTED] Sent: 15 April 2008 02:59 To: tuscany-dev@ws.apache.org Subject: Re: Adding SVN version to Java files Mark Combellack wrote: Hi, I've been looking through the Tuscany source code and noticed that some

Re: Adding SVN version to Java files

2008-04-22 Thread Raymond Feng
I guess you missed my +1. :-) Raymond -- From: Mark Combellack [EMAIL PROTECTED] Sent: Tuesday, April 22, 2008 6:15 AM To: tuscany-dev@ws.apache.org Subject: RE: Adding SVN version to Java files -Original Message- From: Jean-Sebastien

Re: Adding SVN version to Java files

2008-04-15 Thread Vamsavardhana Reddy
+1 on adding the missing revision headers. ++Vamsi On Tue, Apr 15, 2008 at 7:29 AM, Jean-Sebastien Delfino [EMAIL PROTECTED] wrote: Mark Combellack wrote: Hi, I've been looking through the Tuscany source code and noticed that some files have a @version containing the SVN revision

RE: Adding SVN version to Java files

2008-04-15 Thread Mark Combellack
-Original Message- From: Jean-Sebastien Delfino [mailto:[EMAIL PROTECTED] Sent: 15 April 2008 02:59 To: tuscany-dev@ws.apache.org Subject: Re: Adding SVN version to Java files Mark Combellack wrote: Hi, I've been looking through the Tuscany source code and noticed that some

Re: Adding SVN version to Java files

2008-04-14 Thread Jean-Sebastien Delfino
Mark Combellack wrote: Hi, I've been looking through the Tuscany source code and noticed that some files have a @version containing the SVN revision number in their JavaDoc headers but others do not. As an example, @version might look like: /** * Some JavaDoc for the class * * @version

Re: Adding SVN version to Java files

2008-04-03 Thread ant elder
Do you use an ide with svn integration? Using eclipse with the svn plugin you get this information displayed right next to the file name in the package explorer, no need to right click or anything you don't even need to open up the file. I'd guess other IDEs probably have similar tools available.

Re: Adding SVN version to Java files

2008-04-02 Thread ant elder
PROTECTED] Sent: Monday, March 31, 2008 11:55 AM To: tuscany-dev tuscany-dev@ws.apache.org Subject: Re: Adding SVN version to Java files On Mon, Mar 31, 2008 at 7:27 PM, Jean-Sebastien Delfino [EMAIL PROTECTED] wrote: Mark Combellack wrote: Hi, I've been looking through

Re: Adding SVN version to Java files

2008-04-02 Thread ant elder
On Mon, Mar 31, 2008 at 8:01 PM, Jean-Sebastien Delfino [EMAIL PROTECTED] wrote: ant elder wrote: On Mon, Mar 31, 2008 at 7:27 PM, Jean-Sebastien Delfino [EMAIL PROTECTED] wrote: Mark Combellack wrote: Hi, I've been looking through the Tuscany source code and noticed

Re: Adding SVN version to Java files

2008-04-02 Thread Vamsavardhana Reddy
, 2008 11:55 AM To: tuscany-dev tuscany-dev@ws.apache.org Subject: Re: Adding SVN version to Java files On Mon, Mar 31, 2008 at 7:27 PM, Jean-Sebastien Delfino [EMAIL PROTECTED] wrote: Mark Combellack wrote: Hi, I've been looking through the Tuscany

Re: Adding SVN version to Java files

2008-04-02 Thread Vamsavardhana Reddy
. Thanks, Raymond -- From: ant elder [EMAIL PROTECTED] Sent: Monday, March 31, 2008 11:55 AM To: tuscany-dev tuscany-dev@ws.apache.org Subject: Re: Adding SVN version to Java files On Mon, Mar 31, 2008 at 7:27 PM, Jean-Sebastien

Re: Adding SVN version to Java files

2008-04-02 Thread Vamsavardhana Reddy
The one use I see is that by looking at the file (and not doing anything extra), I can quickly learn the last revision at which it is modified. Otherwise, I will have to look at the file properties or svn log to know that revision number. I find that it saves time while investigating issues.

RE: Adding SVN version to Java files

2008-04-02 Thread Mark Combellack
:[EMAIL PROTECTED] Sent: 31 March 2008 20:01 To: tuscany-dev@ws.apache.org Subject: Re: Adding SVN version to Java files ant elder wrote: On Mon, Mar 31, 2008 at 7:27 PM, Jean-Sebastien Delfino [EMAIL PROTECTED] wrote: Mark Combellack wrote: Hi, I've been looking through the Tuscany source

Re: Adding SVN version to Java files

2008-04-02 Thread Vamsavardhana Reddy
@ws.apache.org Subject: Re: Adding SVN version to Java files ant elder wrote: On Mon, Mar 31, 2008 at 7:27 PM, Jean-Sebastien Delfino [EMAIL PROTECTED] wrote: Mark Combellack wrote: Hi, I've been looking through the Tuscany source code and noticed that some files have a @version

RE: Adding SVN version to Java files

2008-04-02 Thread Mark Combellack
-dev@ws.apache.org; [EMAIL PROTECTED] Subject: Re: Adding SVN version to Java files Can we add the missing headers as we modify existing files (not modify just to add there headers) and add the headers as we create new files? ++Vamsi On Wed, Apr 2, 2008 at 7:21 PM, Mark Combellack [EMAIL

Re: Adding SVN version to Java files

2008-04-02 Thread Simon Nash
Vamsavardhana Reddy wrote: The one use I see is that by looking at the file (and not doing anything extra), I can quickly learn the last revision at which it is modified. Otherwise, I will have to look at the file properties or svn log to know that revision number. I find that it saves time

Re: Adding SVN version to Java files

2008-04-02 Thread Vamsavardhana Reddy
svn info filename command will display information as given in the example output below: -- Path: pom.xml Name: pom.xml URL: https://svn.apache.org/repos/asf/incubator/tuscany/java/sca/modules/host-em bedded/pom.xml Repository Root:

Re: Adding SVN version to Java files

2008-04-02 Thread Vamsavardhana Reddy
Reddy [mailto:[EMAIL PROTECTED] Sent: 02 April 2008 14:58 To: tuscany-dev@ws.apache.org; [EMAIL PROTECTED] Subject: Re: Adding SVN version to Java files Can we add the missing headers as we modify existing files (not modify just to add there headers) and add the headers as we create new files

Re: Adding SVN version to Java files

2008-04-02 Thread Simon Nash
Vamsavardhana Reddy wrote: svn info filename command will display information as given in the example output below: -- Path: pom.xml Name: pom.xml URL: https://svn.apache.org/repos/asf/incubator/tuscany/java/sca/modules/host-em bedded/pom.xml Repository

Re: Adding SVN version to Java files

2008-03-31 Thread Simon Nash
Luciano Resende wrote: If Mark is willing to check the missing files, +1 for the updates. I do find this useful from time to time. I also agree that developers should configure their IDE and SVN to proper add the tags and any necessary SVN properties to make this work. On Thu, Mar 27, 2008 at

Re: Adding SVN version to Java files

2008-03-31 Thread Jean-Sebastien Delfino
Mark Combellack wrote: Hi, I've been looking through the Tuscany source code and noticed that some files have a @version containing the SVN revision number in their JavaDoc headers but others do not. As an example, @version might look like: /** * Some JavaDoc for the class * * @version

Re: Adding SVN version to Java files

2008-03-31 Thread ant elder
On Mon, Mar 31, 2008 at 7:27 PM, Jean-Sebastien Delfino [EMAIL PROTECTED] wrote: Mark Combellack wrote: Hi, I've been looking through the Tuscany source code and noticed that some files have a @version containing the SVN revision number in their JavaDoc headers but others do not.

Re: Adding SVN version to Java files

2008-03-31 Thread Jean-Sebastien Delfino
ant elder wrote: On Mon, Mar 31, 2008 at 7:27 PM, Jean-Sebastien Delfino [EMAIL PROTECTED] wrote: Mark Combellack wrote: Hi, I've been looking through the Tuscany source code and noticed that some files have a @version containing the SVN revision number in their JavaDoc headers but others

Re: Adding SVN version to Java files

2008-03-31 Thread Raymond Feng
, March 31, 2008 11:55 AM To: tuscany-dev tuscany-dev@ws.apache.org Subject: Re: Adding SVN version to Java files On Mon, Mar 31, 2008 at 7:27 PM, Jean-Sebastien Delfino [EMAIL PROTECTED] wrote: Mark Combellack wrote: Hi, I've been looking through the Tuscany source code and noticed that some

Adding SVN version to Java files

2008-03-27 Thread Mark Combellack
Hi, I've been looking through the Tuscany source code and noticed that some files have a @version containing the SVN revision number in their JavaDoc headers but others do not. As an example, @version might look like: /** * Some JavaDoc for the class * * @version $Rev: 598005 $ $Date:

Re: Adding SVN version to Java files

2008-03-27 Thread ant elder
I'd prefer not to do this. I've never found these useful and think they just clutter up the code. ...ant On Thu, Mar 27, 2008 at 8:55 PM, Mark Combellack [EMAIL PROTECTED] wrote: Hi, I've been looking through the Tuscany source code and noticed that some files have a @version containing

Re: Adding SVN version to Java files

2008-03-27 Thread Jean-Sebastien Delfino
Mark Combellack wrote: Hi, I've been looking through the Tuscany source code and noticed that some files have a @version containing the SVN revision number in their JavaDoc headers but others do not. As an example, @version might look like: /** * Some JavaDoc for the class * * @version

Re: Adding SVN version to Java files

2008-03-27 Thread Vamsavardhana Reddy
+0.5 These numbers are expected to help in quickly getting to the revision in which these files are modified. So, if the last revision on the file just added this header, it is not of much use. I would suggest that instead of making a change to just add these headers, we add these headers in

Re: Adding SVN version to Java files

2008-03-27 Thread Luciano Resende
If Mark is willing to check the missing files, +1 for the updates. I do find this useful from time to time. I also agree that developers should configure their IDE and SVN to proper add the tags and any necessary SVN properties to make this work. On Thu, Mar 27, 2008 at 9:44 PM, Vamsavardhana