Re: [PATCH v4 3/5] net: ti: icssg: Add icssg queues APIs and macros

2024-04-02 Thread Ravi Gunasekaran
On 3/27/24 10:58 AM, MD Danish Anwar wrote: > Add icssg_queue.c file. This file introduces macros and APIs related to > ICSSG queues. These will be used by ICSSG Ethernet driver. > > Signed-off-by: MD Danish Anwar > --- > drivers/net/ti/icssg_prueth.h | 5 >

Re: [PATCH v4 2/5] net: ti: icssg: Add Firmware config and classification APIs.

2024-04-02 Thread Ravi Gunasekaran
On 3/27/24 10:58 AM, MD Danish Anwar wrote: > Add icssg_config.h / .c and icssg_classifier.c files. These are firmware > configuration and classification related files. Add MII helper APIs and > MACROs. These APIs and MACROs will be later used by ICSSG Ethernet driver. > Also introduce

Re: [PATCH v4 1/5] net: ti: icssg: Add Firmware Interface for ICSSG Ethernet driver.

2024-04-02 Thread Ravi Gunasekaran
On 3/27/24 10:58 AM, MD Danish Anwar wrote: > Add firmware interface related headers and macros for ICSSG Ethernet > driver. These macros will be later used by the ICSSG ethernet driver. > > Signed-off-by: MD Danish Anwar > --- > drivers/net/ti/icssg_switch_map.h | 209

Re: [PATCH 3/4] arm: dts: k3-*-binman.dtsi: Clean up and templatize boot binaries

2024-04-02 Thread Neha Malcom Francis
Hi Michael Sorry for the late response. On 28/03/24 17:26, Michael Walle wrote: Hi, On Thu Mar 28, 2024 at 12:18 PM CET, Neha Malcom Francis wrote: On 27-Mar-24 8:03 PM, Michael Walle wrote: On Wed Mar 27, 2024 at 8:01 AM CET, Neha Malcom Francis wrote: On 26/03/24 19:18, Michael Walle

Re: [PATCH 26/31] rockchip: rk3399-rock960: Sync device tree from linux v6.8

2024-04-02 Thread Peter Robinson
On Sun, 31 Mar 2024 at 21:34, Jonas Karlman wrote: > > Sync rk3399-rock960 related device tree from linux v6.8. TBH I wouldn't class this as "Sync device tree from linux v6.8", it does a dozen other things as well! > Add DM_RESET=y to support reset signals. > > Add PCI=y, CMD_PCI=y and

Re: [PATCH v5 03/16] phy: qcom: Add SNPS femto v2 USB HS phy

2024-04-02 Thread Sumit Garg
On Tue, 2 Apr 2024 at 15:37, Caleb Connolly wrote: > > Hi Sumit, > > On 01/04/2024 06:46, Sumit Garg wrote: > > On Thu, 28 Mar 2024 at 23:29, Caleb Connolly > > wrote: > >> > >> From: Bhupesh Sharma > >> > >> Some Qualcomm SoCs newer than SDM845 feature a so-called "7nm phy" > >> driver,

Re: [PATCH 02/31] rockchip: rk3399-ficus: Enable TPL and use common bss and stack addr

2024-04-02 Thread Peter Robinson
On Sun, 31 Mar 2024 at 21:30, Jonas Karlman wrote: > > The rk3399-ficus board is only using SPL and not TPL+SPL like all other > RK3399 boards, chromebook bob/kevin excluded. It does not seem to be any > technical reason why this board was left using only SPL. > > Switch to use TPL+SPL and use

Re: [PATCH 05/31] rockchip: rk3399: Enable random generator on all boards

2024-04-02 Thread Peter Robinson
On Sun, 31 Mar 2024 at 21:29, Jonas Karlman wrote: > > The RK3399 SoC contain a crypto engine block that can generate random > numbers. > > Imply DM_RNG and RNG_ROCKCHIP Kconfig options to take advantage of the > random generator on all RK3399 boards. > > Signed-off-by: Jonas Karlman

Re: [PATCH 00/31] rockchip: rk3399: Sync DT with linux v6.8 and update defconfigs

2024-04-02 Thread Peter Robinson
Hi Jonas, Overall this series looks good, and I'll be able to test it fro next week when I'm back near devices. > This series adds support for new clocks used in linux v6.8 device trees, > enables use of FIT signature check for checksum validation and fixes > loading FIT from SD-card when

Re: [PATCH v2 0/3] dt-bindings: arm: bcm: raspberrypi,bcm2835-firmware: Drive-by fixes

2024-04-02 Thread Florian Fainelli
On 4/2/24 13:32, Laurent Pinchart wrote: Hi Florian, On Tue, Apr 02, 2024 at 01:18:35PM -0700, Florian Fainelli wrote: On 4/2/24 13:08, Laurent Pinchart wrote: On Tue, Apr 02, 2024 at 09:52:06PM +0200, Stefan Wahren wrote: Am 02.04.24 um 10:58 schrieb Ivan T. Ivanov: On 2024-03-28 01:37,

Re: [PATCH] mmc: arm_pl180: Limit data transfer to U16_MAX

2024-04-02 Thread Jaehoon Chung
Hi, On 2/28/24 05:18, c...@mailbox.org wrote: > From: max > > Currently fetching files bigger that cause a data transfer greater than > U16_MAX fails. > > The reason is that the specification defines the datalength register > as a 16 bit wide register, but in u-boot it is used as if it is an >

Re: [PATCH v2 3/3] mmc: hi6220_dw_mmc: add fifoth_val to private data and set it in .probe

2024-04-02 Thread Yang Xiwen
On 4/3/2024 8:43 AM, Jaehoon Chung wrote: Hi On 2/1/24 23:05, Yang Xiwen via B4 Relay wrote: From: Yang Xiwen The value defaults to 0 and is ignored by dw_mmc code, so the other users are not affected. Setting this explicitly fixes some weird reading error found on Hi3798MV200. Fixes:

Re: [PATCH v2 2/3] mmc: dw_mmc: Don't return error if data busy timeout

2024-04-02 Thread Yang Xiwen
On 4/3/2024 8:41 AM, Jaehoon Chung wrote: Hi, On 2/1/24 23:05, Yang Xiwen via B4 Relay wrote: From: Yang Xiwen As described in [1], some poor hardware or cards would fail to release the bus and keep driving data lines low. Ignore it and send the next cmd directly seems okay for most cases.

Re: [PATCH v2 3/3] mmc: renesas-sdhi: Do not access SCC during tuning in send_cmd callback

2024-04-02 Thread Jaehoon Chung
On 2/25/24 07:32, Marek Vasut wrote: > Do not access SCC when sending commands during tuning operation as that > will disrupt the tuning operation. The tuning operation is adjusting the > SCC settings itself in execute_tuning callback. > > When renesas_sdhi_execute_tuning() is called by the MMC

Re: [PATCH v2 2/3] mmc: Add generic tuning flag

2024-04-02 Thread Jaehoon Chung
On 2/25/24 07:32, Marek Vasut wrote: > Set generic mmc->tuning flag when performing tuning to indicate > this condition to drivers. Drivers may use this to bypass various > checks during tuning. > > Signed-off-by: Marek Vasut Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > Cc:

Re: [PATCH v2 1/3] mmc: hi6220-dwmmc: handle clocks and resets if CONFIG_CLK and CONFIG_DM_RESET enabled

2024-04-02 Thread Yang Xiwen
On 4/3/2024 8:39 AM, Jaehoon Chung wrote: Hi, On 2/1/24 23:05, Yang Xiwen via B4 Relay wrote: From: Yang Xiwen This can avoid hardcoding a clock rate in driver. Also can enable the clocks and deassert the resets if the pre-bootloader does not do this for us. Currently only enabled for

Re: [PATCH v2 1/3] mmc: Convert hs400_tuning flag from u8 to bool

2024-04-02 Thread Jaehoon Chung
On 2/25/24 07:32, Marek Vasut wrote: > This hs400_tuning is a flag, make it bool. No functional change. > This will be useful in the following patch, which adds another > more generic flag, where the compiler can better use the space > now reserved for the u8 to store more flags in it. > >

Re: [PATCH] mmc: renesas-sdhi: Stop transmission in case tuning block transfer fails

2024-04-02 Thread Jaehoon Chung
On 2/20/24 17:38, Marek Vasut wrote: > The current code uses the state of tuning block received by SCC to > determine whether or not to send transmission stop command. This is > not correct. Use the state of tuning block transfer to determine > whether or not to send transmission stop command

Re: [PATCH] mmc: tmio: Check INFO1 for completion during DMA transfer

2024-04-02 Thread Jaehoon Chung
On 2/20/24 17:38, Marek Vasut wrote: > In case a CRC error occurs during DMA transfer, the transfer completion > flag is not set in TMIO_SD_DMA_INFO1 and the transfer would eventually > time out. The timeout could be very long in case the transfer consists > of a large amount of blocks, the base

Re: [PATCH] mmc: arm_pl180_mmci: Rely on DM

2024-04-02 Thread Jaehoon Chung
On 2/8/24 18:33, Linus Walleij wrote: > The PL180/MMCI driver is implied to use CONFIG_DM and the ARM > defconfigs such as configs/vexpress_ca9x4_defconfig will get it > as well. > > With a simple oneline to default to not being the v2 variant, > the original ARM MMCI variant works fine with the

Re: [PATCH v2 3/3] mmc: hi6220_dw_mmc: add fifoth_val to private data and set it in .probe

2024-04-02 Thread Jaehoon Chung
Hi On 2/1/24 23:05, Yang Xiwen via B4 Relay wrote: > From: Yang Xiwen > > The value defaults to 0 and is ignored by dw_mmc code, so the other > users are not affected. > > Setting this explicitly fixes some weird reading error found on Hi3798MV200. > > Fixes: 8a5dc8140e62 ("mmc:

Re: [PATCH v2 2/3] mmc: dw_mmc: Don't return error if data busy timeout

2024-04-02 Thread Jaehoon Chung
Hi, On 2/1/24 23:05, Yang Xiwen via B4 Relay wrote: > From: Yang Xiwen > > As described in [1], some poor hardware or cards would fail to release > the bus and keep driving data lines low. Ignore it and send the next cmd > directly seems okay for most cases. This patch seems to be same with

Re: [PATCH v2 1/3] mmc: hi6220-dwmmc: handle clocks and resets if CONFIG_CLK and CONFIG_DM_RESET enabled

2024-04-02 Thread Jaehoon Chung
Hi, On 2/1/24 23:05, Yang Xiwen via B4 Relay wrote: > From: Yang Xiwen > > This can avoid hardcoding a clock rate in driver. Also can enable the > clocks and deassert the resets if the pre-bootloader does not do this > for us. > > Currently only enabled for Hi3798MV200. > > Signed-off-by:

Re: [PATCH v2] mmc: Add SPL_MMC_PWRSEQ to fix link issue when building SPL

2024-04-02 Thread Jaehoon Chung
On 1/28/24 02:12, Jonas Karlman wrote: > With MMC_PWRSEQ enabled the following link issue may happen when > building SPL and SPL_PWRSEQ is not enabled. > > aarch64-linux-gnu-ld.bfd: drivers/mmc/meson_gx_mmc.o: in function > `meson_mmc_probe': > drivers/mmc/meson_gx_mmc.c:295: undefined

Re: [PATCH v2] mmc: Remove alignment hole for cmdidx in struct mmc_cmd

2024-04-02 Thread Jaehoon Chung
Hi, On 1/28/24 01:29, Jonas Karlman wrote: > The alignment hole caused by cmdidx in struct mmc_cmd cause strange > issues together with the peephole2 optimization on Amlogic SoCs. > Following was observed while working on SPL support for Amlogic SoCs. > > sd_get_capabilities() normally issue a

Re: [PATCH] mmc: dw_mmc: Don't return error if data busy timeout

2024-04-02 Thread Jaehoon Chung
Hi, On 1/26/24 12:29, Yang Xiwen wrote: > As described in [1], some poor hardware or cards would fail to release > the bus and keep driving data lines low. Ignore it and send the next cmd > directly seems okay for most cases. I didn't test on my board. But it's not same with below patch. Did you

Re: [PATCH 1/1] mmc: Don't suggest to build modules in Kconfig.

2024-04-02 Thread Jaehoon Chung
On 1/24/24 01:18, Heinrich Schuchardt wrote: > U-Boot does not support building kernel modules. > > Fixes: 3c0dbed232bd ("mmc: arm_pl180_mmci: adapt driver to DM usage") > Fixes: 36645f45a048 ("drivers: mmc: Add sdhci driver for Broadcom iProc > platform") > Fixes: dadd43c14368 ("mmc: synquacer:

Re: [PATCH 1/1] mmc: Avoid buffer overrun in mmc_startup()

2024-04-02 Thread Jaehoon Chung
On 1/4/24 12:49, Heinrich Schuchardt wrote: > If the CSD register contains a reserved value (4 - 7) in bits 0:2 of the > TRAN_SPEED field, a buffer overrun occurs. Resize the mapping table. > > According to the original report >

Re: [PATCH 28/31] rockchip: rk3399-rock-pi-4: Sync device tree from linux v6.8

2024-04-02 Thread Christopher Obbard
Hi Jonas, On Sun, 2024-03-31 at 20:28 +, Jonas Karlman wrote: > Sync rk3399-rock-pi-4 related device tree from linux v6.8. > > Add SPI flash related options to support booting from SPI flash. > > Add AHCI=y, SCSI_AHCI=y, AHCI_PCI=y and SCSI=y to support PCIe SATA boot. > > Change to

Re: [PATCH v2 0/3] dt-bindings: arm: bcm: raspberrypi,bcm2835-firmware: Drive-by fixes

2024-04-02 Thread Laurent Pinchart
Hi Florian, On Tue, Apr 02, 2024 at 01:18:35PM -0700, Florian Fainelli wrote: > On 4/2/24 13:08, Laurent Pinchart wrote: > > On Tue, Apr 02, 2024 at 09:52:06PM +0200, Stefan Wahren wrote: > >> Am 02.04.24 um 10:58 schrieb Ivan T. Ivanov: > >>> On 2024-03-28 01:37, Laurent Pinchart wrote: >

Re: [PATCH v2 0/3] dt-bindings: arm: bcm: raspberrypi,bcm2835-firmware: Drive-by fixes

2024-04-02 Thread Florian Fainelli
On 4/2/24 01:58, Ivan T. Ivanov wrote: Hi, On 2024-03-28 01:37, Laurent Pinchart wrote: On Wed, Mar 27, 2024 at 07:49:38AM +0100, Stefan Wahren wrote: Hi, [add Peter and Ivan] Am 26.03.24 um 20:58 schrieb Laurent Pinchart: > Hello, > > This small series includes a few drive-by fixes for DT

Re: [PATCH v2 0/3] dt-bindings: arm: bcm: raspberrypi,bcm2835-firmware: Drive-by fixes

2024-04-02 Thread Stefan Wahren
Hi Laurent, Am 02.04.24 um 22:08 schrieb Laurent Pinchart: Hello, ... Stefan, I'm quite unfamiliar with the Raspberry Pi upstreaming process (despite having sent patches for ages :-)), do I understand correctly that this patch will go through your tree, or do I need to work with someone else

Re: [PATCH v2 0/3] dt-bindings: arm: bcm: raspberrypi,bcm2835-firmware: Drive-by fixes

2024-04-02 Thread Florian Fainelli
On 4/2/24 13:08, Laurent Pinchart wrote: Hello, On Tue, Apr 02, 2024 at 09:52:06PM +0200, Stefan Wahren wrote: Am 02.04.24 um 10:58 schrieb Ivan T. Ivanov: On 2024-03-28 01:37, Laurent Pinchart wrote: On Wed, Mar 27, 2024 at 07:49:38AM +0100, Stefan Wahren wrote: Hi, [add Peter and Ivan]

Re: [PATCH v2 0/3] dt-bindings: arm: bcm: raspberrypi,bcm2835-firmware: Drive-by fixes

2024-04-02 Thread Laurent Pinchart
Hello, On Tue, Apr 02, 2024 at 09:52:06PM +0200, Stefan Wahren wrote: > Am 02.04.24 um 10:58 schrieb Ivan T. Ivanov: > > On 2024-03-28 01:37, Laurent Pinchart wrote: > >> On Wed, Mar 27, 2024 at 07:49:38AM +0100, Stefan Wahren wrote: > >>> Hi, > >>> > >>> [add Peter and Ivan] > >>> > >>> Am

Re: [PATCH v2 0/3] dt-bindings: arm: bcm: raspberrypi,bcm2835-firmware: Drive-by fixes

2024-04-02 Thread Stefan Wahren
Am 02.04.24 um 10:58 schrieb Ivan T. Ivanov: Hi, On 2024-03-28 01:37, Laurent Pinchart wrote: On Wed, Mar 27, 2024 at 07:49:38AM +0100, Stefan Wahren wrote: Hi, [add Peter and Ivan] Am 26.03.24 um 20:58 schrieb Laurent Pinchart: > Hello, > > This small series includes a few drive-by fixes

Re: [PATCH v2 1/1] xilinx: zynq: add FDT_FIXUP_PARTITIONS support

2024-04-02 Thread James Hilliard
On Tue, Apr 2, 2024 at 6:41 AM Michal Simek wrote: > > > > On 4/1/24 01:28, James Hilliard wrote: > > There are situations where we may want to let U-Boot modify the FDT > > nand partitions for the kernel, such as when supporting multiple > > sizes of NAND chips. > > > > Signed-off-by: James

Re: [RFC PATCH v1 1/1] mmc: snps_sdhci: Add sdhci driver support for TH1520 SoC

2024-04-02 Thread Heinrich Schuchardt
Maxim Kiselev schrieb am Di., 2. Apr. 2024, 19:19: > i, Heinrich! > > вт, 2 апр. 2024 г. в 17:47, Heinrich Schuchardt > : > > > > On 30.03.24 18:59, Maksim Kiselev wrote: > > > Add support for DesignWare SDHCI host controller on Alibaba TH1520 SoC > > > > > > Signed-off-by: Maksim Kiselev > > >

Re: [RFC PATCH v1 1/1] mmc: snps_sdhci: Add sdhci driver support for TH1520 SoC

2024-04-02 Thread Maxim Kiselev
Hi, Sean вт, 2 апр. 2024 г. в 18:39, Sean Anderson : > > On 3/30/24 13:59, Maksim Kiselev wrote: > > Add support for DesignWare SDHCI host controller on Alibaba TH1520 SoC > > > > Signed-off-by: Maksim Kiselev > > --- > > drivers/mmc/Kconfig | 12 + > > drivers/mmc/Makefile | 1 + > >

Re: [PATCH v2] mx6cuboxi: Fix Ethernet after DT sync with Linux

2024-04-02 Thread Josua Mayer
Hi Fabio, Am 01.04.24 um 12:13 schrieb Christian Gmeiner: > Hi Fabio > >> From: Josua Mayer >> >> The i.MX6 Cubox-i and HummingBoards can have different PHYs at varying >> addresses. U-Boot needs to auto-detect which phy is actually present, >> and at which address it is responding. >> >>

Re: [RFC PATCH v1 1/1] mmc: snps_sdhci: Add sdhci driver support for TH1520 SoC

2024-04-02 Thread Maxim Kiselev
i, Heinrich! вт, 2 апр. 2024 г. в 17:47, Heinrich Schuchardt : > > On 30.03.24 18:59, Maksim Kiselev wrote: > > Add support for DesignWare SDHCI host controller on Alibaba TH1520 SoC > > > > Signed-off-by: Maksim Kiselev > > Thank you for driving the TH1520 support forward. > > Locally I updated

Re: [V2 PATCH 2/2] rockchip: Switch RK3568 and RK3588 to new RAM bank logic

2024-04-02 Thread Quentin Schulz
Hi Chris, On 4/1/24 20:14, Chris Morgan wrote: From: Chris Morgan Switch all RK3568 and RK3588 boards to use the ATAGS based RAM bank logic. This allows us to access all RAM when >= 4GB of RAM is available while also automatically creating the memory holes when >= 16GB of RAM is available.

Re: [V1 PATCH 1/2] rockchip: sdram: Support getting banks from TPL for rk3568 and rk3588

2024-04-02 Thread Quentin Schulz
Hi Chris, On 4/1/24 20:14, Chris Morgan wrote: From: Chris Morgan Allow RK3568 and RK3588 based boards to get the RAM bank configuration from the ROCKCHIP_TPL stage instead of the current logic. This fixes both an issue where 256MB of RAM is blocked for devices with >= 4GB of RAM and where

[PATCH 1/2] firmware: ti_sci: Bind sysreset driver when enabled

2024-04-02 Thread Andrew Davis
The sysreset TI-SCI API is available with TI-SCI always, there is no need for a DT node to describe the availability of this. If the sysreset driver is available then bind it during ti-sci probe. Remove the unneeded device tree matching. Signed-off-by: Andrew Davis ---

[PATCH 2/2] arm: dts: k3: Remove unneeded ti, sci-sysreset binding and nodes

2024-04-02 Thread Andrew Davis
This extra binding is non-standard and now unneeded as we bind the sysreset driver automatically. This matches what is done in Linux and allows us to more closely match the DTBs. Remove the binding and all users. Signed-off-by: Andrew Davis --- arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 7

[PATCH 0/2] Remove ti,sci-sysreset

2024-04-02 Thread Andrew Davis
Hello all, Idea here is to remove one more delta between the U-Boot and Linux DTB files: ti,sci-sysreset. We currently have to add this to every board's -u-boot.dtsi file as this is not a standard node. Instead do what we are moving the kernel towards[0] and remove this node. Thanks, Andrew [0]

Re: [RFC PATCH v1 1/1] mmc: snps_sdhci: Add sdhci driver support for TH1520 SoC

2024-04-02 Thread Sean Anderson
On 3/30/24 13:59, Maksim Kiselev wrote: > Add support for DesignWare SDHCI host controller on Alibaba TH1520 SoC > > Signed-off-by: Maksim Kiselev > --- > drivers/mmc/Kconfig | 12 + > drivers/mmc/Makefile | 1 + > drivers/mmc/snps_sdhci.c | 464

Re: [PATCH 2/3] rockchip: Add a board_gen_ethaddr() function

2024-04-02 Thread Detlev Casanova
Hi Jonas, On Thursday, March 14, 2024 2:38:30 P.M. EDT Jonas Karlman wrote: > Hi Detlev, > > On 2024-03-14 15:43, Detlev Casanova wrote: > > Set the MAC address based on the CPU ID only if the ethernet device has > > no ROM or DT address set. > > This patch changes behavior and once again

Re: [PATCH 00/31] rockchip: rk3399: Sync DT with linux v6.8 and update defconfigs

2024-04-02 Thread Quentin Schulz
Hi Jonas, On 3/31/24 22:28, Jonas Karlman wrote: This series adds support for new clocks used in linux v6.8 device trees, enables use of FIT signature check for checksum validation and fixes loading FIT from SD-card when loading FIT from eMMC fails. After this series it should be possible to

Re: [PATCH 17/31] rockchip: rk3399-puma: Sync DT from linux v6.8

2024-04-02 Thread Quentin Schulz
Hi Jonas, On 3/31/24 22:28, Jonas Karlman wrote: Sync rk3399-puma related device tree from linux v6.8. SPL_MAX_SIZE is not adjusted to the now common 0x4 (256 KiB) due to TPL+SPL combined (idbloader.img) is limited to max 224 KiB because of: SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0x200

Re: [PATCH 15/31] rockchip: rk3399: Sync soc device tree from linux v6.8

2024-04-02 Thread Quentin Schulz
Hi Jonas, On 3/31/24 22:28, Jonas Karlman wrote: Sync RK3399 SoC common .dtsi-files from linux v6.8. The ethernet0 alias is removed from rk3399.dtsi in this patch, it will be restored in board specific .dts-files. There is no other intended Please add ethernet0 alias to rk3399-u-boot.dtsi

Re: [RFC PATCH v1 1/1] mmc: snps_sdhci: Add sdhci driver support for TH1520 SoC

2024-04-02 Thread Heinrich Schuchardt
On 30.03.24 18:59, Maksim Kiselev wrote: Add support for DesignWare SDHCI host controller on Alibaba TH1520 SoC Signed-off-by: Maksim Kiselev Thank you for driving the TH1520 support forward. Locally I updated the Lichee Pi4A device-tree based on the Linux device-tree and built

Re: [PATCH 14/31] clk: rockchip: rk3399: Add SCLK_USB3OTGx_REF support

2024-04-02 Thread Quentin Schulz
Hi Jonas, On 3/31/24 22:28, Jonas Karlman wrote: The SCLK_USB3OTGx_REF clocks is used as reference clock for USB3 block. Add simple support to get rate of SCLK_USB3OTGx_REF clocks to fix reference clock period configuration. Also replace use of 2400 with the OSC_HZ constant.

Re: [PATCH 13/31] clk: rockchip: rk3399: Add dummy support for SCLK_PCIEPHY_REF clock

2024-04-02 Thread Quentin Schulz
Hi Jonas, On 3/31/24 22:28, Jonas Karlman wrote: rk3399-nanopi-4.dtsi try to set parent of and set rate to 100 MHz of the SCLK_PCIEPHY_REF clock. The existing enable/disable ops for SCLK_PCIEPHY_REF already handles setting correct parent once the clock gets enabled. And 100 MHz is the default

Re: [PATCH 10/31] rockchip: rk3399: Fix loading FIT from SD-card when booting from eMMC

2024-04-02 Thread Quentin Schulz
Hi Jonas, On 3/31/24 22:28, Jonas Karlman wrote: When RK3399 boards run SPL from eMMC and fail to load FIT from eMMC due to it being missing or checksum validation fails there can be a fallback to read FIT from SD-card. However, without proper pinctrl configuration reading FIT from SD-card may

[PATCH] soc: zynqmp: Add the IDcode for TEG variant

2024-04-02 Thread Venkatesh Yadav Abbarapu
ID code is added for zu3teg variant. Signed-off-by: Venkatesh Yadav Abbarapu --- drivers/soc/soc_xilinx_zynqmp.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/soc/soc_xilinx_zynqmp.c b/drivers/soc/soc_xilinx_zynqmp.c index 786825d920..d8b4f172a3 100644 ---

Re: [PATCH 08/31] rockchip: rk3399: Remove use of xPL_MISC_DRIVERS options

2024-04-02 Thread Quentin Schulz
Hi Jonas, On 3/31/24 22:28, Jonas Karlman wrote: The TPL and/or SPL control FDT on RK3399 boards does not contain any node with a compatible that is supported by driver/misc/ drivers. Remove use of xPL_MISC_DRIVERS options to stop including e.g an unused efuse driver in TPL and/or SPL. This

Re: [PATCH 09/31] rockchip: rk3399: Add a default spl-boot-order prop

2024-04-02 Thread Quentin Schulz
Hi Jonas, On 3/31/24 22:28, Jonas Karlman wrote: A lot of RK3399 boards use a u-boot,spl-boot-order of "same-as-spl", and Move this to rk3399-u-boot.dtsi and make this default for boards currently missing a u-boot,spl-boot-order prop. The _flash reference has been dropped from

Re: [PATCH 07/31] rockchip: rk3399: Enable DT overlay support on all boards

2024-04-02 Thread Quentin Schulz
Hi Jonas, On 3/31/24 22:28, Jonas Karlman wrote: Imply OF_LIBFDT_OVERLAY Kconfig options to add device tree overlay support on all RK3399 boards. Signed-off-by: Jonas Karlman Reviewed-by: Quentin Schulz Thanks, Quentin

Re: [PATCH 06/31] rockchip: rk3399: Imply support for GbE PHY

2024-04-02 Thread Quentin Schulz
Hi Jonas, On 3/31/24 22:28, Jonas Karlman wrote: Imply support for GbE PHY status parsing and configuration when support for onboard ethernet is enabled. Signed-off-by: Jonas Karlman Reviewed-by: Quentin Schulz Thanks, Quentin

Re: [PATCH 05/31] rockchip: rk3399: Enable random generator on all boards

2024-04-02 Thread Quentin Schulz
Hi Jonas, On 3/31/24 22:28, Jonas Karlman wrote: The RK3399 SoC contain a crypto engine block that can generate random numbers. Imply DM_RNG and RNG_ROCKCHIP Kconfig options to take advantage of the random generator on all RK3399 boards. Signed-off-by: Jonas Karlman Reviewed-by: Quentin

Re: [PATCH 12/19] rockchip: rk3588: Update bootph props

2024-04-02 Thread Quentin Schulz
Hi Jonas, On 4/2/24 15:36, Jonas Karlman wrote: Hi Quentin, On 2024-04-02 13:20, Quentin Schulz wrote: Hi Jonas, On 3/29/24 20:01, Jonas Karlman wrote: [...] diff --git a/arch/arm/dts/rk3588s-u-boot.dtsi b/arch/arm/dts/rk3588s-u-boot.dtsi index e4171bd24d2a..a502a82fae6a 100644 ---

Re: [PATCH 02/31] rockchip: rk3399-ficus: Enable TPL and use common bss and stack addr

2024-04-02 Thread Jonas Karlman
Hi Quentin, On 2024-04-02 15:10, Quentin Schulz wrote: > Hi Jonas, > > On 3/31/24 22:28, Jonas Karlman wrote: >> The rk3399-ficus board is only using SPL and not TPL+SPL like all other >> RK3399 boards, chromebook bob/kevin excluded. It does not seem to be any >> technical reason why this board

Re: [PATCH 12/19] rockchip: rk3588: Update bootph props

2024-04-02 Thread Jonas Karlman
Hi Quentin, On 2024-04-02 13:20, Quentin Schulz wrote: > Hi Jonas, > > On 3/29/24 20:01, Jonas Karlman wrote: > > [...] > >> diff --git a/arch/arm/dts/rk3588s-u-boot.dtsi >> b/arch/arm/dts/rk3588s-u-boot.dtsi >> index e4171bd24d2a..a502a82fae6a 100644 >> --- a/arch/arm/dts/rk3588s-u-boot.dtsi

Re: [PATCH 08/19] rockchip: rk35xx: Imply support for GbE PHY

2024-04-02 Thread Quentin Schulz
Hi Jonas, On 4/2/24 14:54, Jonas Karlman wrote: Hi Quentin, On 2024-04-02 13:11, Quentin Schulz wrote: Hi Jonas, On 3/29/24 20:01, Jonas Karlman wrote: Imply support for GbE PHY status parsing and configuration when support for onboard ethernet is enabled. Signed-off-by: Jonas Karlman ---

Re: [PATCH 18/19] rockchip: rk356x-generic: Add support for SPI flash and USB OTG

2024-04-02 Thread Quentin Schulz
Hi Jonas, On 4/2/24 14:37, Jonas Karlman wrote: Hi Quentin, On 2024-04-02 12:38, Quentin Schulz wrote: Hi Jonas, On 3/29/24 20:01, Jonas Karlman wrote: Extend the Generic RK3566/RK3568 target to also include support for SPI flash, USB OTG, RockUSB and UMS. Also fix sdmmc alias, include

Re: [PATCH 04/31] rockchip: rk3399: Enable ARMv8 crypto and FIT checksum validation

2024-04-02 Thread Quentin Schulz
Hi Jonas, On 3/31/24 22:28, Jonas Karlman wrote: The RK3399 SoC support the ARMv8 Cryptography Extensions, use of ARMv8 crypto can speed up FIT checksum validation in SPL. Imply ARMV8_SET_SMPEN and ARMV8_CRYPTO to take advantage of the crypto extensions for SHA256 when validating checksum of

Re: [PATCH 0/3] Add support for jtag disable/enable and multiboot get/set for zynq

2024-04-02 Thread Michal Simek
Hi, On 3/28/24 10:01, lukas.funke-...@weidmueller.com wrote: From: Lukas Funke This series adds support to enable/disable/lock the jtag interface from u-boot. This becomes handy if secure boot is used but debugging should be poissible for non-productions builds. The series also adds support

Re: [PATCH v3 2/2] arm64: zynq(mp): Rename spl_board_init() to spl_soc_init()

2024-04-02 Thread Michal Simek
On 3/27/24 13:11, lukas.funke-...@weidmueller.com wrote: From: Lukas Funke Rename spl_board_init() to spl_soc_init(). SoC specific implementation should be separated from board specific implementation in order to be extended by board developers. Signed-off-by: Lukas Funke --- Changes in

Re: [PATCH 02/31] rockchip: rk3399-ficus: Enable TPL and use common bss and stack addr

2024-04-02 Thread Quentin Schulz
Hi Jonas, On 3/31/24 22:28, Jonas Karlman wrote: The rk3399-ficus board is only using SPL and not TPL+SPL like all other RK3399 boards, chromebook bob/kevin excluded. It does not seem to be any technical reason why this board was left using only SPL. Switch to use TPL+SPL and use common bss

Re: [PATCH] arm64: dts: zynqmp: make hw-ecc as the default ecc mode

2024-04-02 Thread Michal Simek
On 3/25/24 10:50, Venkatesh Yadav Abbarapu wrote: Except for Linux no other component (i.e., u-boot, fsbl or BootRom) of the software stack supports software ecc engine. So, make hw-ecc as the default ecc mode. Update the same for mini u-boot nand configuration as well. Signed-off-by:

Re: [PATCH v2 2/2] arm64: zynqmp: Add MTD partition handling for dfu_alt_info generation

2024-04-02 Thread Michal Simek
On 3/22/24 13:09, Michal Simek wrote: Generate dfu_alt_info generation based on information from MTD partitions. mtd_found_part() is trying to identify MTD partition which code is running from. If partitions are not defined and location is not found it is going to previous behavior.

Re: [PATCH v2 1/2] arm64: zynqmp: Generate desc when SPL_FS_LOAD_PAYLOAD_NAME is valid

2024-04-02 Thread Michal Simek
On 3/22/24 13:09, Michal Simek wrote: Generate description only when CONFIG_SPL_FS_LOAD_PAYLOAD_NAME is not empty. When name is empty there is no reason to generate description for it because it is not aligned with dfu rules. Signed-off-by: Michal Simek --- Changes in v2: - New patch is

Re: [PATCH] xilinx: Do not call private env_get_location() when !ENV_IS_NOWHERE

2024-04-02 Thread Michal Simek
On 3/22/24 12:43, Michal Simek wrote: Private function for finding out location of environment is not working when ENV_IS_NOWHERE is disabled. The reason is that current fallback is ENVL_UNKNOWN when CONFIG_ENV_IS_NOWHERE is not enabled. The code could be updated like this -

Re: [PATCH] arm64: zynqmp: Describe DisplayPort connector for Kria

2024-04-02 Thread Michal Simek
On 3/21/24 16:54, Michal Simek wrote: From: Vishal Sagar Add a device tree node to describe the DisplayPort connector, and connect it to the DPSUB output. The patch was tested on kv260-revB/rev2 and also kr260-revB. Signed-off-by: Vishal Sagar Signed-off-by: Michal Simek ---

Re: [PATCH 18/19] rockchip: rk356x-generic: Add support for SPI flash and USB OTG

2024-04-02 Thread Jonas Karlman
Hi Quentin, On 2024-04-02 12:38, Quentin Schulz wrote: > Hi Jonas, > > On 3/29/24 20:01, Jonas Karlman wrote: >> Extend the Generic RK3566/RK3568 target to also include support for SPI >> flash, USB OTG, RockUSB and UMS. >> >> Also fix sdmmc alias, include missing pinctrl and add broken-cd prop

Re: [PATCH 08/19] rockchip: rk35xx: Imply support for GbE PHY

2024-04-02 Thread Jonas Karlman
Hi Quentin, On 2024-04-02 13:11, Quentin Schulz wrote: > Hi Jonas, > > On 3/29/24 20:01, Jonas Karlman wrote: >> Imply support for GbE PHY status parsing and configuration when support >> for onboard ethernet is enabled. >> >> Signed-off-by: Jonas Karlman >> --- >>

Re: [PATCH v2 1/1] xilinx: zynq: add FDT_FIXUP_PARTITIONS support

2024-04-02 Thread Michal Simek
On 4/1/24 01:28, James Hilliard wrote: There are situations where we may want to let U-Boot modify the FDT nand partitions for the kernel, such as when supporting multiple sizes of NAND chips. Signed-off-by: James Hilliard --- Changes v1 -> v2: - move partition fixups to

Re: [PATCH 1/1] net: dw_eth_qos: Add missing \n in error messages.

2024-04-02 Thread Heinrich Schuchardt
On 02.04.24 13:26, Quentin Schulz wrote: Hi Heinrich, On 4/2/24 10:39, Heinrich Schuchardt wrote: Missing line-feeds in error messages lead to output like: phy_startup() failed: -110FAILED: -110=> Output like the following is much easier to read: phy_startup() failed: -110

Re: [PATCH 15/19] rockchip: rk3588-toybrick: Add missing Kconfig options

2024-04-02 Thread Jonas Karlman
Hi Quentin, On 2024-04-02 12:28, Quentin Schulz wrote: > Hi Jonas, > > On 3/29/24 20:01, Jonas Karlman wrote: >> Add .dtb-file entry to Makefile and enable Kconfig options required to >> configure pinctrl in SPL. Also add missing PHY_ROCKCHIP_NANENG_COMBOPHY. >> >> Fixes: 9fdd9a546986 ("board:

Re: [PATCH 10/19] rockchip: rk35xx: Sort soc u-boot.dtsi alphabetically

2024-04-02 Thread Jonas Karlman
Hi Quentin, On 2024-04-02 12:23, Quentin Schulz wrote: > Hi Jonas, > > On 3/29/24 20:01, Jonas Karlman wrote: >> Sort nodes and props in RK356x/RK3588 u-boot.dtsi alphabetically, nodes >> is sorted by reg addr then by alphabetical order. >> >> This has no intended change beside sorting existing

Re: [PATCH] clk: rockchip: rk3399: Add SCLK_UART4_PMU support

2024-04-02 Thread Quentin Schulz
Hi, On 4/2/24 12:01, xiaofengvskuye wrote: [You don't often get email from xiaofengvsk...@hotmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] The SCLK_UART4_PMU clocks is used as reference clock for UART4 block. Add simple support to get rate of

[PATCH] trace: use dynamic string buffer in make_flamegraph()

2024-04-02 Thread Vincent Stehlé
The str[] buffer declared in make_flamegraph() is used to hold strings representing the full call-stacks recorded in traces. The size of this buffer is currently 500 characters and this works well for the documented examples. However, it is possible to exhaust this buffer when processing traces

Re: [PATCH 1/1] net: dw_eth_qos: Add missing \n in error messages.

2024-04-02 Thread Quentin Schulz
Hi Heinrich, On 4/2/24 10:39, Heinrich Schuchardt wrote: Missing line-feeds in error messages lead to output like: phy_startup() failed: -110FAILED: -110=> Output like the following is much easier to read: phy_startup() failed: -110 FAILED: -110 => Signed-off-by:

Re: [PATCH 12/19] rockchip: rk3588: Update bootph props

2024-04-02 Thread Quentin Schulz
Hi Jonas, On 3/29/24 20:01, Jonas Karlman wrote: [...] diff --git a/arch/arm/dts/rk3588s-u-boot.dtsi b/arch/arm/dts/rk3588s-u-boot.dtsi index e4171bd24d2a..a502a82fae6a 100644 --- a/arch/arm/dts/rk3588s-u-boot.dtsi +++ b/arch/arm/dts/rk3588s-u-boot.dtsi @@ -121,31 +121,35 @@ }; { -

Re: [PATCH 08/19] rockchip: rk35xx: Imply support for GbE PHY

2024-04-02 Thread Quentin Schulz
Hi Jonas, On 3/29/24 20:01, Jonas Karlman wrote: Imply support for GbE PHY status parsing and configuration when support for onboard ethernet is enabled. Signed-off-by: Jonas Karlman --- arch/arm/mach-rockchip/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git

[ANN] U-Boot v2024.04 released

2024-04-02 Thread Tom Rini
Hey all, It's Tuesday, and for once I'm not late and it's release day and so here is v2024.04. Once again I want to thank everyone that's contributed to this release, not just in terms of code, but documentation, testing and otherwise ensuring things go as smoothly as they can. In terms of a

Re: [PATCH 02/19] clk: rockchip: rk3588: Add REF_CLK_USB3OTGx support

2024-04-02 Thread Quentin Schulz
Hi Jonas, On 3/29/24 20:01, Jonas Karlman wrote: The REF_CLK_USB3OTGx clocks is used as reference clock for USB3 block. Add simple support to get rate of REF_CLK_USB3OTGx clocks to fix reference clock period configuration. Signed-off-by: Jonas Karlman Reviewed-by: Quentin Schulz Thanks,

Re: [PATCH 18/19] rockchip: rk356x-generic: Add support for SPI flash and USB OTG

2024-04-02 Thread Quentin Schulz
Hi Jonas, On 3/29/24 20:01, Jonas Karlman wrote: Extend the Generic RK3566/RK3568 target to also include support for SPI flash, USB OTG, RockUSB and UMS. Also fix sdmmc alias, include missing pinctrl and add broken-cd prop to fix use of SD-card in linux. I think we would have benefit with

Re: [PATCH 15/19] rockchip: rk3588-toybrick: Add missing Kconfig options

2024-04-02 Thread Quentin Schulz
Hi Jonas, On 3/29/24 20:01, Jonas Karlman wrote: Add .dtb-file entry to Makefile and enable Kconfig options required to configure pinctrl in SPL. Also add missing PHY_ROCKCHIP_NANENG_COMBOPHY. Fixes: 9fdd9a546986 ("board: rockchip: add Rockchip Toybrick TB-RK3588X board") Signed-off-by: Jonas

Re: [PATCH 10/19] rockchip: rk35xx: Sort soc u-boot.dtsi alphabetically

2024-04-02 Thread Quentin Schulz
Hi Jonas, On 3/29/24 20:01, Jonas Karlman wrote: Sort nodes and props in RK356x/RK3588 u-boot.dtsi alphabetically, nodes is sorted by reg addr then by alphabetical order. This has no intended change beside sorting existing nodes and removing a duplicated usbdpphy0_grf node. Signed-off-by:

Re: [PATCH v5 03/16] phy: qcom: Add SNPS femto v2 USB HS phy

2024-04-02 Thread Caleb Connolly
Hi Sumit, On 01/04/2024 06:46, Sumit Garg wrote: On Thu, 28 Mar 2024 at 23:29, Caleb Connolly wrote: From: Bhupesh Sharma Some Qualcomm SoCs newer than SDM845 feature a so-called "7nm phy" driver, notable the SM8250 SoC which will gain U-Boot support in upcoming patches. Introduce a

[PATCH] clk: rockchip: rk3399: Add SCLK_UART4_PMU support

2024-04-02 Thread xiaofengvskuye
The SCLK_UART4_PMU clocks is used as reference clock for UART4 block. Add simple support to get rate of SCLK_UART4_PMU clocks to fix reference clock period configuration. Signed-off-by: xiaofengvskuye --- drivers/clk/rockchip/clk_rk3399.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH] clk: rockchip: rk3399: Add SCLK_UART4_PMU support

2024-04-02 Thread xiaofengvskuye
The SCLK_UART4_PMU clocks is used as reference clock for UART4 block. Add simple support to get rate of SCLK_UART4_PMU clocks to fix reference clock period configuration. Signed-off-by: xiaofengvskuye --- drivers/clk/rockchip/clk_rk3399.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[GIT PULL] Please pull u-boot-dfu-20240402

2024-04-02 Thread Mattijs Korpershoek
425dc46a2c8ebe6d1a5a7d2d7ac5506aa7783409: Merge tag 'u-boot-imx-master-20240330' of https://gitlab.denx.de/u-boot/custodians/u-boot-imx (2024-03-30 14:07:37 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-dfu.git tags/u-boot-dfu-20240402 for you to fetch changes

[GIT PULL] Please pull u-boot-dfu-next-20240402

2024-04-02 Thread Mattijs Korpershoek
-updates' into next (2024-03-20 08:39:05 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-dfu.git tags/u-boot-dfu-next-20240402 for you to fetch changes up to 12ac51cdb788b9f8e50cbc4fa3681102882ade33: usb: udc: dwc3: Fold dwc3_uboot_handle_interrupt

Re: [PATCH v5 16/16] usb: gadget: UMS: fix 64-bit division on ARM32

2024-04-02 Thread Caleb Connolly
Hi Mattijs, On 02/04/2024 09:24, Mattijs Korpershoek wrote: Hi Caleb, Thank you for the patch. On jeu., mars 28, 2024 at 17:59, Caleb Connolly wrote: The patch introducing support for dynamic sector sizes changed the types used in some divisions, resulting in the compiler attempting to

Re: [PATCH 1/2] usb: udc: dwc3: Fold board dm_usb_gadget_handle_interrupts() into DWC3 gadget

2024-04-02 Thread Mattijs Korpershoek
Hi, On Sun, 17 Mar 2024 05:42:52 +0100, Marek Vasut wrote: > The dm_usb_gadget_handle_interrupts() has no place in board code. Move > this into DWC3 driver. The OMAP implementation is special, add new weak > dwc3_uboot_interrupt_status() function to decide whether DWC3 interrupt > handling should

[PATCH v2] efi_loader: fix append write behavior to non-existent variable

2024-04-02 Thread Masahisa Kojima
Current "variables" efi_selftest result is inconsistent between the U-Boot file storage and the tee-based StandaloneMM RPMB secure storage. U-Boot file storage implementation does not accept SetVariale call to non-existent variable with EFI_VARIABLE_APPEND_WRITE, it return EFI_NOT_FOUND. However

Re: [PATCH] mvebu: Enable preboot start for pci/usb/scsi/nvme

2024-04-02 Thread Igor Opaniuk
Hi Dennis, On Tue, Apr 2, 2024 at 3:40 AM Dennis Gilmore wrote: > While preboot was enabled, it did not work as commands are needed to be > run to enable some of the subsystems. This patch starts pci, USB, Sata, > and nvme and makes sure that the system will boot no mater what storage > is in

Re: [PATCH v2 0/3] dt-bindings: arm: bcm: raspberrypi,bcm2835-firmware: Drive-by fixes

2024-04-02 Thread Ivan T. Ivanov
Hi, On 2024-03-28 01:37, Laurent Pinchart wrote: On Wed, Mar 27, 2024 at 07:49:38AM +0100, Stefan Wahren wrote: Hi, [add Peter and Ivan] Am 26.03.24 um 20:58 schrieb Laurent Pinchart: > Hello, > > This small series includes a few drive-by fixes for DT validation > errors. > > The first

  1   2   >