es have a few checkpatch warnings in it, those
> also partly come from Linux.
> ---
> Cc: Jonas Karlman
> Cc: Lukasz Majewski
> Cc: Mattijs Korpershoek
> Cc: Miquel Raynal
> Cc: Simon Glass
> Cc: Tom Rini
> Cc: Vitaliy Vasylskyy
I've reviewed this by compa
lt -a -f
=> saveenv
# 3. Read back mmc0boot1 and confirm the env is present
=> mmc read ${loadaddr} 0 400
=> md ${loadaddr} 4
8200: 13e0632e 72646461 7469665f 3978303d .c..addr_fit=0x9
Fixes: 5b4acb0ff79d ("env: mmc: Apply GPT only on eMMC user HW partition")
Sign
Hi Simon,
Thank you for the patch.
On sam., juil. 13, 2024 at 08:00, Simon Glass wrote:
> Fix a missing dot in a comment, since '..' is confusing.
>
> Signed-off-by: Simon Glass
Reviewed-by: Mattijs Korpershoek
> ---
>
> (no changes since v1)
>
> arch/sandbox/c
Hi Simon,
Thank you for the patch.
On sam., juil. 13, 2024 at 08:00, Simon Glass wrote:
> The argument array is not changed by the callee, so mark it const.
>
> Signed-off-by: Simon Glass
Reviewed-by: Mattijs Korpershoek
> ---
>
> (no changes since v1)
>
> a
Hi Heinrich,
Thank you for the patch.
On mer., juil. 17, 2024 at 16:54, Heinrich Schuchardt
wrote:
> All Kconfig options that depend on CONFIG_CMD_DHCP6 should immediately
> follow it.
>
> Signed-off-by: Heinrich Schuchardt
Reviewed-by: Mattijs Korpershoek
> ---
>
Hi Simon,
Thank you for the patch.
On mar., juil. 16, 2024 at 08:04, Simon Glass wrote:
> The bootstd node provides some configuration properties. Add these to
> the documentation.
>
> Signed-off-by: Simon Glass
> Reviewed-by: Quentin Schulz
Reviewed-by: Matt
Hi Simon,
Thank you for the patch.
On mar., juil. 16, 2024 at 08:04, Simon Glass wrote:
> Fix a minor indentation / whitespace problem in a comment.
>
> Signed-off-by: Simon Glass
> Reviewed-by: Heinrich Schuchardt
> Reviewed-by: Quentin Schulz
Reviewed-by: Matt
Hi Simon,
Thank you for the patch.
On mar., juil. 16, 2024 at 08:04, Simon Glass wrote:
> Link to this page to make it easier to find the VBE docs.
>
> Signed-off-by: Simon Glass
> Reviewed-by: Heinrich Schuchardt
> Reviewed-by: Quentin Schulz
Reviewed-by: Matt
Hi Simon,
Thank you for the patch.
On mar., juil. 16, 2024 at 08:04, Simon Glass wrote:
> Add documentation for the script bootmeth.
>
> Signed-off-by: Simon Glass
> Reviewed-by: Quentin Schulz
Reviewed-by: Mattijs Korpershoek
> ---
>
> Changes in v2:
> - Adj
k devices.
>
> Signed-off-by: Simon Glass
Reviewed-by: Mattijs Korpershoek
> ---
>
> (no changes since v1)
>
> boot/bootmeth_script.c | 51 +-
> 1 file changed, 31 insertions(+), 20 deletions(-)
>
> diff --git a/boot/bootmeth_sc
Hi Simon,
Thank you for the patch.
On mar., juil. 16, 2024 at 08:04, Simon Glass wrote:
> Fix a typo in the comment and add one to the EFI driver too.
>
> Signed-off-by: Simon Glass
> Reviewed-by: Heinrich Schuchardt
> Reviewed-by: Quentin Schulz
Reviewed-by: Matt
Reviewed-by: Quentin Schulz
Reviewed-by: Mattijs Korpershoek
> ---
>
> Changes in v2:
> - Adjustments from Heinrich's comments
>
> boot/bootmeth_sandbox.c | 2 +-
> doc/develop/bootstd/index.rst| 1 +
> doc/develop/bootstd/overview.rst |
Hi Simon,
Thank you for the patch.
On mar., juil. 16, 2024 at 08:04, Simon Glass wrote:
> Add documentation for the cros bootmeth.
>
> Signed-off-by: Simon Glass
> Reviewed-by: Quentin Schulz
Reviewed-by: Mattijs Korpershoek
> ---
>
> Changes in v2:
> - Adj
W, this bootmeth reads the kernel
> +provided by the QEMU `-kernel` argument, the initial ramdisk and provided by
There is a "and" which should be removed here:
ramdisk and provided by -> ramdisk provided by
With that fixed:
Reviewed-by: Mattijs Korpershoek
> +`-initrd` and th
Hi Simon,
Thank you for the patch.
On mar., juil. 16, 2024 at 08:04, Simon Glass wrote:
> Add documentation for the pxe bootmeth.
>
> Signed-off-by: Simon Glass
> Reviewed-by: Quentin Schulz
Reviewed-by: Mattijs Korpershoek
Nitpick: now that pxelinux.rst exist, can we link
Hi Simon,
Thank you for the patch.
On mar., juil. 16, 2024 at 08:04, Simon Glass wrote:
> Add documentation for the extlinux bootmeth.
>
> Signed-off-by: Simon Glass
> Reviewed-by: Quentin Schulz
Reviewed-by: Mattijs Korpershoek
Minor nitpicks below, feel free to ign
Hi Simon,
Thank you for the patch.
On mar., juil. 16, 2024 at 08:04, Simon Glass wrote:
> Add a note about how bootmeth drivers are instantiated.
>
> Signed-off-by: Simon Glass
> Suggested-by: Heinrich Schuchardt
Reviewed-by: Mattijs Korpershoek
> ---
>
> Changes in
Hi Simon,
Thank you for the patch.
On mar., juil. 16, 2024 at 08:04, Simon Glass wrote:
> Before adding more files, move the bootstd docs into a new directory,
> with an index.
>
> Signed-off-by: Simon Glass
> Reviewed-by: Quentin Schulz
Reviewed-by: Matt
Hi Simon,
Thank you for the patch.
On mar., juil. 16, 2024 at 08:04, Simon Glass wrote:
> Rename this to BOOTSTD which is the normal name for the feature.
>
> Signed-off-by: Simon Glass
> Reviewed-by: Quentin Schulz
Reviewed-by: Mattijs Korpershoek
> ---
>
>
Hi Simon,
Thank you for the patch.
On lun., juil. 15, 2024 at 11:13, Simon Glass wrote:
> Add documentation for the sandbox bootmeth.
>
> Fix up the compatible string to drop the 'extlinux' part, which is not
> relevant to this bootmeth.
>
> Signed-off-by: Simon Glass
Re
Hi Simon,
Thank you for the patch.
On lun., juil. 15, 2024 at 11:13, Simon Glass wrote:
> Add documentation for the cros bootmeth.
>
> Signed-off-by: Simon Glass
Reviewed-by: Mattijs Korpershoek
> ---
>
> doc/develop/bootstd/cros.rst | 33 +
t; +When invoked on a bootdev for UCLASS_QFW, this bootmeth reads the kernel
> +provided by the QEMU `-kernel` argument, the iniital ramdisk and provided by
iniital -> initial
ramdisk and provided by -> ramdisk provided by
With that fixed:
Reviewed-by: Mattijs Korpershoek
> +`-initrd` and th
Hi Simon,
Thank you for the patch.
On lun., juil. 15, 2024 at 11:13, Simon Glass wrote:
> Add documentation for the pxe bootmeth.
>
> Signed-off-by: Simon Glass
Reviewed-by: Mattijs Korpershoek
Nitpick: now that pxelinux.rst exist, can we link to this file in
extlinux.rst ?
>
Hi Simon,
Thank you for the patch.
On lun., juil. 15, 2024 at 11:13, Simon Glass wrote:
> Add documentation for the extlinux bootmeth.
>
> Signed-off-by: Simon Glass
Reviewed-by: Mattijs Korpershoek
Minor nitpicks below, feel free to ignore or apply.
> ---
>
> d
Hi Simon,
Thank you for the patch.
On lun., juil. 15, 2024 at 11:13, Simon Glass wrote:
> Before adding more files, move the bootstd docs into a new directory,
> with an index.
>
> Signed-off-by: Simon Glass
Reviewed-by: Mattijs Korpershoek
> ---
&
Hi Simon,
Thank you for the patch.
On lun., juil. 15, 2024 at 11:13, Simon Glass wrote:
> Rename this to BOOTSTD which is the normal name for the feature.
>
> Signed-off-by: Simon Glass
Reviewed-by: Mattijs Korpershoek
> ---
>
> MAINTAINERS | 2 +-
> 1 file chang
Hi Tom,
Please find some new developments for master:
Usb gadget:
- A welcome cleanup: epautoconf workaround is dropped to use
.match_ep() instead
- Introduce handle_interrupts() op for USB_GADGET_GENERIC, which
allows a per-driver interrupt handling
Fastboot:
- Fix mssing include when
://lore.kernel.org/r/all/20230914165615.1058529-17-...@chromium.org/
Reviewed-by: Simon Glass
Reviewed-by: Julien Masson
Tested-by: Guillaume La Roque
Signed-off-by: Mattijs Korpershoek
---
MAINTAINERS | 7 +
boot/Kconfig| 17 ++
boot/Makefile | 2 +
boot
BOOTMETH_ANDROID as a dependency on sandbox so that we can test
this with:
$ ./test/py/test.py --bd sandbox --build -k test_ut # build the mmc7.img
$ ./test/py/test.py --bd sandbox --build -k bootflow_android
Signed-off-by: Mattijs Korpershoek
---
arch/sandbox/dts/test.dts | 8 +
configs
be useful for implementing an Android bootmethod.
Reviewed-by: Igor Opaniuk
Reviewed-by: Julien Masson
Reviewed-by: Simon Glass
Reviewed-by: Guillaume La Roque
Tested-by: Guillaume La Roque
Signed-off-by: Mattijs Korpershoek
---
cmd/abootimg.c | 10 ++
include/image.h | 14 +
Some bootflows might be able to only boot from MMC devices.
Add a helper function these bootflows can use.
Reviewed-by: Igor Opaniuk
Reviewed-by: Julien Masson
Reviewed-by: Guillaume La Roque
Tested-by: Guillaume La Roque
Signed-off-by: Mattijs Korpershoek
---
boot/bootflow.c| 12
that don't have CMD_ABOOTIMG, add a weak
implementation to avoid linking errors.
Reviewed-by: Simon Glass
Reviewed-by: Julien Masson
Reviewed-by: Igor Opaniuk
Reviewed-by: Guillaume La Roque
Tested-by: Guillaume La Roque
Signed-off-by: Mattijs Korpershoek
---
boot/image-android.c | 5
/meson64_android.h
[5] https://lore.kernel.org/r/all/20230914165615.1058529-17-...@chromium.org/
[6]
https://software-dl.ti.com/processor-sdk-android/esd/AM62X/09_02_00/docs/android/Overview.html
Signed-off-by: Mattijs Korpershoek
---
Changes in v3:
- Fixed CI issues (Tom):
* Generate bootv4.img
Hi Marek,
On mar., juil. 09, 2024 at 13:13, Marek Vasut wrote:
> On 7/9/24 10:39 AM, Mattijs Korpershoek wrote:
>> Hi Caleb,
>
> Hi,
>
>> Thank you for the patch.
>>
>> On mar., juin 18, 2024 at 16:57, Caleb Connolly
>> wrote:
>>
>>>
m phy_setup'
>
> Signed-off-by: Marek Vasut
Reviewed-by: Mattijs Korpershoek
> ---
> Cc: Caleb Connolly
> Cc: Fabio Estevam
> Cc: Fabrice Gasnier
> Cc: Jonas Karlman
> Cc: Mathieu Othacehe
> Cc: Mattijs Korpershoek
> Cc: Neil Armstrong
> Cc: Nishanth Menon
>
gt; Since the OTG mode may enable IRQ generation in the PHY, disable
> that IRQ generation in the exit callback again.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Mattijs Korpershoek
> ---
> Cc: Caleb Connolly
> Cc: Fabio Estevam
> Cc: Fabrice Gasnier
> Cc: Jonas Karlman
ric_phy_set_mode() call returns 0 and does not error out, so this
> should not break any existing systems.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Mattijs Korpershoek
> ---
> Cc: Caleb Connolly
> Cc: Fabio Estevam
> Cc: Fabrice Gasnier
> Cc: Jonas Karlman
>
during probe so we always start with it in a
> known state, and don't have wait for the first asix_wait_link() to
> time out.
>
> Signed-off-by: Caleb Connolly
Reviewed-by: Mattijs Korpershoek
> ---
> I see this behaviour consistently across three Qualcomm platfo
Hi,
On Fri, 21 Jun 2024 03:51:02 +0200, Caleb Connolly wrote:
> Fixes a compile error when building with only the TCP fastboot implementation.
>
>
Thanks, Applied to https://source.denx.de/u-boot/custodians/u-boot-dfu
(u-boot-dfu)
[1/1] include/fastboot.h: add missing types.h include
Hi Caleb,
Thank you for the patch.
On ven., juin 21, 2024 at 03:51, Caleb Connolly
wrote:
> Fixes a compile error when building with only the TCP fastboot implementation.
>
> Signed-off-by: Caleb Connolly
Reviewed-by: Mattijs Korpershoek
> ---
> include/fastboot.h |
Hi,
On Fri, 14 Jun 2024 02:51:15 +0200, Marek Vasut wrote:
> Introduce .ops for USB_GADGET_GENERIC uclass. The first new ops is
> .handle_interrupts which must be implemented by DM capable USB gadget
> controller drivers and must implement interrupt handling similar to
>
Hi,
On Sun, 09 Jun 2024 23:32:14 +0200, Marek Vasut wrote:
> The bcdDevice field is defined as
> |Device release number in binary-coded decimal
> in the USB 2.0 specification. We use this field to distinguish the UDCs
> from each other. In theory this could be used on the host side to apply
>
Hi Tom,
On jeu., juin 20, 2024 at 08:23, Tom Rini wrote:
> On Thu, Jun 13, 2024 at 12:13:07PM +0200, Mattijs Korpershoek wrote:
>
>> Android boot flow is a bit different than a regular Linux distro.
>> Android relies on multiple partitions in order to boot.
>>
>
Hi Simon.
On mar., juin 18, 2024 at 21:03, Simon Glass wrote:
> Hi Mattijs,
>
> On Mon, 17 Jun 2024 at 09:15, Mattijs Korpershoek
> wrote:
>>
>> Hi Simon,
>>
>> On lun., juin 17, 2024 at 07:53, Simon Glass wrote:
>>
>> > Hi Mattijs,
>>
d-off-by: Heinrich Schuchardt
Reviewed-by: Mattijs Korpershoek
> ---
> v3:
> plural controllers
> v2:
> add 'found' at end of message
> keep printf
> ---
> drivers/usb/host/usb-uclass.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff
by: Marek Vasut
Reviewed-by: Mattijs Korpershoek
> ---
> Cc: Alexander Sverdlin
> Cc: Felipe Balbi
> Cc: Lukasz Majewski
> Cc: Mattijs Korpershoek
> Cc: Nishanth Menon
> Cc: Simon Glass
> Cc: Thinh Nguyen
> Cc: Tom Rini
> Cc: u-boot@lists.denx.de
> ---
> d
Hi Marek,
Thank you for the patch.
On ven., juin 14, 2024 at 02:51, Marek Vasut
wrote:
> Drop dm_usb_gadget_handle_interrupts() in favor of empty default
> implementation of the same in drivers/usb/gadget/udc/udc-uclass.c .
>
> Signed-off-by: Marek Vasut
Reviewed-by: Mattijs
efine its own
> IRQ handling implementation without colliding with other controller
> drivers.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Mattijs Korpershoek
> ---
> Cc: Alexander Sverdlin
> Cc: Felipe Balbi
> Cc: Lukasz Majewski
> Cc: Mattijs Korpershoek
>
efine its own
> IRQ handling implementation without colliding with other controller
> drivers.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Mattijs Korpershoek
nitpick below (up to you if you want to fix it)
> ---
> Cc: Alexander Sverdlin
> Cc: Felipe Balbi
> C
efine its own
> IRQ handling implementation without colliding with other controller
> drivers.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Mattijs Korpershoek
> ---
> Cc: Alexander Sverdlin
> Cc: Felipe Balbi
> Cc: Lukasz Majewski
> Cc: Mattijs Korpershoek
>
efine its own
> IRQ handling implementation without colliding with other controller
> drivers.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Mattijs Korpershoek
> ---
> Cc: Alexander Sverdlin
> Cc: Felipe Balbi
> Cc: Lukasz Majewski
> Cc: Mattijs Korpershoek
>
efine its own
> IRQ handling implementation without colliding with other controller
> drivers.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Mattijs Korpershoek
> ---
> Cc: Alexander Sverdlin
> Cc: Felipe Balbi
> Cc: Lukasz Majewski
> Cc: Mattijs Korpershoek
>
efine its own
> IRQ handling implementation without colliding with other controller
> drivers.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Mattijs Korpershoek
> ---
> Cc: Alexander Sverdlin
> Cc: Felipe Balbi
> Cc: Lukasz Majewski
> Cc: Mattijs Korpershoek
>
efine its own
> IRQ handling implementation without colliding with other controller
> drivers.
>
> Keep the dm_usb_gadget_handle_interrupts() in this driver for non-DM
> case for now, until this driver gets fully converted to DM USB gadget.
>
> Signed-off-by: Marek Vasut
Re
Hi Jonas,
On sam., mars 02, 2024 at 14:00, Jonas Karlman wrote:
[...]
>>
>> I will keep you posted.
>
> Thanks, much appreciated!
>
> Please also keep in mind that changing the interrupt handling probably
> only fixes the second of the two build errors reported and fixed by this
> patch.
>
>
-by: Marek Vasut
Reviewed-by: Mattijs Korpershoek
> ---
> Cc: Alexander Sverdlin
> Cc: Felipe Balbi
> Cc: Lukasz Majewski
> Cc: Mattijs Korpershoek
> Cc: Nishanth Menon
> Cc: Simon Glass
> Cc: Thinh Nguyen
> Cc: Tom Rini
> Cc: u-boot@lists.
rivers/usb/musb-new/ux500.c| 22 ++
> include/linux/usb/gadget.h | 8
> 14 files changed, 172 insertions(+), 81 deletions(-)
Tested on Khadas vim3 using fastboot, ums and usb storage scanning.
Tested-by: Mattijs Korpershoek # vim3
>
>
Hi Simon,
On lun., juin 17, 2024 at 07:53, Simon Glass wrote:
> Hi Mattijs,
>
> On Thu, 13 Jun 2024 at 04:13, Mattijs Korpershoek
> wrote:
>>
>> Android boot flow is a bit different than a regular Linux distro.
>> Android relies on multiple partitions in order
Hi Heinrich,
Thank you for your review.
On dim., juin 16, 2024 at 09:38, Heinrich Schuchardt wrote:
> On 6/4/24 17:15, Mattijs Korpershoek wrote:
>> According to [1], we should use bootmeth when describing the
>> struct bootmeth:
>>
>> """
>> For
Hi Guillaume,
Thank you for testing.
On ven., juin 14, 2024 at 11:53, Guillaume LA ROQUE
wrote:
> Hi,
>
> i apply patch series with commit you give in cover letter and test on
> TI AM62S-SK board.
> Android boot properly , just with a small changes in uboot eenv
>
> setenv
Some bootflows might be able to only boot from MMC devices.
Add a helper function these bootflows can use.
Reviewed-by: Igor Opaniuk
Signed-off-by: Mattijs Korpershoek
---
boot/bootflow.c| 12
include/bootflow.h | 9 +
2 files changed, 21 insertions(+)
diff --git
that don't have CMD_ABOOTIMG, add a weak
implementation to avoid linking errors.
Signed-off-by: Mattijs Korpershoek
---
boot/image-android.c | 5 +
boot/image-fdt.c | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/boot/image-android.c b/boot/image-android.c
index
/meson64_android.h
[5] https://lore.kernel.org/r/all/20230914165615.1058529-17-...@chromium.org/
[6]
https://software-dl.ti.com/processor-sdk-android/esd/AM62X/09_02_00/docs/android/Overview.html
Signed-off-by: Mattijs Korpershoek
---
Changes in v2:
- Dropped patch 2/6 boot: android: Add
be useful for implementing an Android bootmethod.
Reviewed-by: Igor Opaniuk
Signed-off-by: Mattijs Korpershoek
---
cmd/abootimg.c | 10 ++
include/image.h | 14 ++
2 files changed, 24 insertions(+)
diff --git a/cmd/abootimg.c b/cmd/abootimg.c
index 327712a536c0..ae7a1a7c8
Glass
Signed-off-by: Mattijs Korpershoek
---
arch/sandbox/dts/test.dts | 8 +
configs/sandbox_defconfig | 2 +-
test/boot/bootflow.c | 65 ++--
test/py/tests/test_ut.py | 76 +++
4 files changed, 147
://lore.kernel.org/r/all/20230914165615.1058529-17-...@chromium.org/
Reviewed-by: Simon Glass
Signed-off-by: Mattijs Korpershoek
---
MAINTAINERS | 7 +
boot/Kconfig| 16 ++
boot/Makefile | 2 +
boot/bootmeth_android.c | 553
Hi Simon,
Thank you for your review.
On mar., juin 11, 2024 at 12:52, Simon Glass wrote:
> Hi Mattijs,
>
> On Thu, 6 Jun 2024 at 06:24, Mattijs Korpershoek
> wrote:
>>
>> Android boot flow is a bit different than a regular Linux distro.
>> Android relies o
Hi Igor,
Thank you for your quick review.
On lun., juin 10, 2024 at 17:15, Igor Opaniuk wrote:
> Hi Mattijs,
>
> On Thu, Jun 6, 2024 at 2:24 PM Mattijs Korpershoek
> wrote:
>>
>> Android boot flow is a bit different than a regular Linux distro.
>> Android
Hi Lukasz,
On mar., juin 11, 2024 at 10:51, Lukasz Majewski wrote:
> On Tue, 11 Jun 2024 09:20:33 +0200
> Mattijs Korpershoek wrote:
[...]
>
>> > --
>> > 2.43.0
>
> FInally. :-)
>
> Thanks Mattijs for this cleanup.
You should thank Marek, i've
Hi Igor,
Thank you for the review.
On lun., juin 10, 2024 at 11:31, Igor Opaniuk wrote:
> Hi Mattijs,
>
> On Thu, Jun 6, 2024 at 2:24 PM Mattijs Korpershoek
> wrote:
>>
>> Some bootflows might be able to only boot from MMC devices.
>>
>> Add a hel
Hi Igor,
Thank you for the review.
On lun., juin 10, 2024 at 11:20, Igor Opaniuk wrote:
> Hi Mattijs,
>
> On Thu, Jun 6, 2024 at 2:24 PM Mattijs Korpershoek
> wrote:
>>
>> When reading a boot image header, we may need to retrieve the header
>> versio
, otherwise I'll apply the changes.
>
> Signed-off-by: Marek Vasut
To me, this looks good.
Reviewed-by: Mattijs Korpershoek
Tested-by: Mattijs Korpershoek # on vim3
> ---
> Cc: Alexander Sverdlin
> Cc: Felipe Balbi
> Cc: Lukasz Majewski
> Cc: Mattijs Korpershoek
&g
linux implementation (usb_ep_autoconfig_ss()).
Reviewed-by: Mattijs Korpershoek
Tested-by: Mattijs Korpershoek # on vim3
> ---
> Cc: Alexander Sverdlin
> Cc: Felipe Balbi
> Cc: Lukasz Majewski
> Cc: Mattijs Korpershoek
> Cc: Nishanth Menon
> Cc: Simon Glass
hips.h as well.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Mattijs Korpershoek
Tested-by: Mattijs Korpershoek # on vim3
> ---
> Cc: Alexander Sverdlin
> Cc: Felipe Balbi
> Cc: Lukasz Majewski
> Cc: Mattijs Korpershoek
> Cc: Nishanth Menon
> Cc: Simon Glass
>
this quirk anymore.
>
> This patch removes the newly unused function. Linux stopped using this
> functionality in 2012, remove it from U-Boot as well.
>
> Matching Linux kernel commit:
> ed9cbda63d45 ("usb: gadget: remove usb_gadget_controller_number()")
>
> S
dget: remove usb_gadget_controller_number()")
>
> Signed-off-by: Marek Vasut
Reviewed-by: Mattijs Korpershoek
Tested-by: Mattijs Korpershoek # on vim3
> ---
> Cc: Alexander Sverdlin
> Cc: Felipe Balbi
> Cc: Lukasz Majewski
> Cc: Mattijs Korpershoek
> Cc: Nishanth
dget: remove usb_gadget_controller_number()")
>
> Signed-off-by: Marek Vasut
Compared with linux commit, and looks good to me.
Reviewed-by: Mattijs Korpershoek
Tested that I could use fastboot, ums and scan for storage devices on
khadas vim3
Tested-by: Mattijs Korpershoek # vim3
> ---
gt;
> Signed-off-by: Nishanth Menon
Reviewed-by: Mattijs Korpershoek
Boot tested to main U-Boot via DFU on AM62X SK EVM.
Tested-by: Mattijs Korpershoek
> ---
> arch/arm/dts/Makefile|3 +-
> arch/arm/dts/k3-am62-main.dtsi | 1058 --
://lore.kernel.org/r/all/20230914165615.1058529-17-...@chromium.org/
Signed-off-by: Mattijs Korpershoek
---
MAINTAINERS | 7 +
boot/Kconfig| 14 ++
boot/Makefile | 2 +
boot/bootmeth_android.c | 522
boot/bootmeth_android.h
BOOTMETH_ANDROID as a dependency on sandbox so that we can test
this with:
$ ./test/py/test.py --bd sandbox --build -k test_ut # to build the mmc7.img
$ ./test/py/test.py --bd sandbox --build -k bootflow_android
Signed-off-by: Mattijs Korpershoek
---
arch/sandbox/dts/test.dts | 8 +
configs
be useful for implementing an Android bootmethod.
Signed-off-by: Mattijs Korpershoek
---
cmd/abootimg.c | 10 ++
include/image.h | 14 ++
2 files changed, 24 insertions(+)
diff --git a/cmd/abootimg.c b/cmd/abootimg.c
index 88c77d999290..33381e22dec2 100644
--- a/cmd/abootimg.c
Some bootflows might be able to only boot from MMC devices.
Add a helper function these bootflows can use.
Signed-off-by: Mattijs Korpershoek
---
boot/bootflow.c| 12
include/bootflow.h | 9 +
2 files changed, 21 insertions(+)
diff --git a/boot/bootflow.c b/boot
When reading a boot image header, we may need to retrieve the header
version.
Add a helper function for it.
Signed-off-by: Mattijs Korpershoek
---
boot/image-android.c | 7 ++-
include/image.h | 7 +++
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/boot/image
When calling android_image_get_dtb_by_index() using boot image v3+,
we should also pass the vendor_boot ramdisk address.
Use get_avendor_bootimg_addr() to do so.
Note: on boot image v2, this is harmless since get_avendor_bootimg_addr()
returns -1.
Signed-off-by: Mattijs Korpershoek
---
boot
/meson64_android.h
[5] https://lore.kernel.org/r/all/20230914165615.1058529-17-...@chromium.org/
[6]
https://software-dl.ti.com/processor-sdk-android/esd/AM62X/09_02_00/docs/android/Overview.html
Signed-off-by: Mattijs Korpershoek
---
Mattijs Korpershoek (6):
boot: android: Provide
Hi everyone,
On jeu., mai 16, 2024 at 17:12, Mattijs Korpershoek
wrote:
> Hi Tom,
>
> Please find some fixes for master:
>
> - dwc3 fix crash when ep0 stalls or gadget is stopped
> - Kconfig build fix for DFU_SF (SPI flash DFU driver)
>
> The CI job is at
> ht
Hi Tom,
Please find some fixes for master:
- dwc3 fix crash when ep0 stalls or gadget is stopped
- Kconfig build fix for DFU_SF (SPI flash DFU driver)
The CI job is at
https://source.denx.de/u-boot/custodians/u-boot-dfu/-/pipelines/20990
Thanks,
Mattijs
The following changes since commit
Hi Tom,
Please find some fixes for master:
- dwc3 fix crash when ep0 stalls or gadget is stopped
- Kconfig build fix for DFU_SF (SPI flash DFU driver)
The CI job is at
https://source.denx.de/u-boot/custodians/u-boot-dfu/-/pipelines/20990
Thanks,
Mattijs
The following changes since commit
v6.10-rc1).
>
> Signed-off-by: Nishanth Menon
Reviewed-by: Mattijs Korpershoek
> ---
> arch/arm/dts/Makefile| 1 -
> arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 4 +-
> arch/arm/dts/k3-am625-beagleplay.dts | 932 ---
Hi,
On Tue, 04 Jun 2024 07:44:25 +0200, Heinrich Schuchardt wrote:
> Building the SPI flash DFU driver fails if SPI flash support is missing.
>
> drivers/dfu/dfu_sf.c:123:29: error:
> ‘CONFIG_SF_DEFAULT_MODE’ undeclared (first use in this function);
>
> Add the missing dependency.
>
>
Schulz
Reviewed-by: Mattijs Korpershoek
> ---
> drivers/power/regulator/rk8xx.c | 26 +-
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/power/regulator/rk8xx.c b/drivers/power/regulator/rk8xx.c
> index bd5a37e718f..3125
Hi Quentin,
Thank you for the review.
On mar., juin 04, 2024 at 17:25, Quentin Schulz
wrote:
> Hi Mattijs,
>
> On 6/4/24 5:15 PM, Mattijs Korpershoek wrote:
>> According to [1], we should use bootmeth when describing the
>> struct bootmeth:
>>
>> "&q
Hi Quentin,
Thanks for the review!
On mar., juin 04, 2024 at 14:22, Quentin Schulz
wrote:
> Hi Mattijs,
>
> On 6/4/24 2:04 PM, Mattijs Korpershoek wrote:
[...]
>>
>> There seems indeed to be some inconsistencies around bootmeths versus
>> bootmethods.
>>
tmeth - because 'method' is too vanilla, appears 1300 times in
U-Boot
"""
Replace all occurences in various comments for consistency.
[1] https://lore.kernel.org/u-boot/20211023232635.9195-1-...@chromium.org/
Signed-off-by: Mattijs Korpershoek
---
board/sandbox/sand
Fix some trivial typos found by browsing the code.
Done with flyspell.
Reviewed-by: Quentin Schulz
Signed-off-by: Mattijs Korpershoek
---
include/bootmeth.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/bootmeth.h b/include/bootmeth.h
index
pos, second patch replaces all
occurences of bootmethod(s) -> bootmeth(s).
Signed-off-by: Mattijs Korpershoek
---
Changes in v2:
- Made into a series
- New patch replaces all bootmethod(s) -> bootmeth(s)
- Link to v1:
https://lore.kernel.org/r/20240603-bootmeth-typos-v1-1-6edbdb469...@bayl
Hi Quentin,
On mar., juin 04, 2024 at 11:47, Quentin Schulz
wrote:
> Hi Mattijs,
>
> On 6/3/24 11:11 AM, Mattijs Korpershoek wrote:
>> Fix some trivial typos found by browsing the code.
>> Done with flyspell.
>>
>> Signed-off-by: Mattijs Korpershoek &
able to execute any
> arbitrary commands just like in the u-boot's shell.
Can we please add CONFIG_DFU_SCSI in "Configuration Options" section at
the beginning of this document?
See:
https://docs.u-boot.org/en/latest/usage/dfu.html#configuration-options
Note: I requested that h
his function);
>
> Add the missing dependency.
>
> Signed-off-by: Heinrich Schuchardt
Reviewed-by: Mattijs Korpershoek
> ---
> drivers/dfu/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dfu/Kconfig b/drivers/dfu/Kconfig
> index 0360d9da142..9712
Hi,
On Tue, 28 May 2024 10:35:03 +0200, Neil Armstrong wrote:
> If the ep0 stalls or request are dequeued when gagdet is stopped,
> the request dma may not be mapped yet and dwc3_flush_cache() may be
> called with a NULL pointer.
>
> Check req->request.dma before calling dwc3_flush_cache() and
1 - 100 of 536 matches
Mail list logo
