found the solution.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
To unsubscribe from this group, send email to
v8-dev+unsubscribegooglegroups.com or reply to this email with the words
"REMOVE ME" as the subject.
http://codereview.chromium.org/1117011/diff/1009/6002
File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/1117011/diff/1009/6002#newcode2736
src/ia32/codegen-ia32.cc:2736: if (nan_info == kCantBothBeNaN && cc ==
equal) {
On 2010/03/23 18:09:24, Erik Corry wrote:
This seems wro
LGTM
Still convoluted but much better and easier to follow. I guess the
complicated
dance comes with the territory...
-Ivan
http://codereview.chromium.org/1181001
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
To unsubscribe from this group, send emai
On 2010/03/23 18:16:13, Michail Naganov wrote:
Ivan, please look if it makes more sense for you now.
http://codereview.chromium.org/1181001
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
To unsubscribe from this group, send email to v8-dev+unsubscribegoog
Reviewers: iposva,
Description:
Add comments to test-log-stack-tracer.
Please review this at http://codereview.chromium.org/1181001
Affected files:
M test/cctest/test-log-stack-tracer.cc
Index: test/cctest/test-log-stack-tracer.cc
diff --git a/test/cctest/test-log-stack-tracer.cc
b/test/c
http://codereview.chromium.org/1117011/diff/1009/6002
File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/1117011/diff/1009/6002#newcode2736
src/ia32/codegen-ia32.cc:2736: if (nan_info == kCantBothBeNaN && cc ==
equal) {
This seems wrong. If one side is a constant fp number th
Reviewers: Søren Gjesse,
Message:
Hi Soren
This is my approach to the taks.
It does not support try/catches yet and I haven't added stubs to all
architectures so far.
Peter
Description:
LiveEdit: implement frame dropping
Please review this at http://codereview.chromium.org/1118007
Affected
On 2010/03/23 11:07:24, Michail Naganov wrote:
Kasper, may I ask you to review this fix, as you were the reviewer for
Ivan's
change.
Mikhail,
It would be really helpful if the rather tricky code in
test-log-stack-tracer.cc
was a bit better documented. It is nearly impossible to figure out
Hi,
Looking for help to figure out where is the problem...
Here is the call stack when I'm loading google.com page.
...
V8AbstractEventListener::invokeEventHandler()
getListenerObject()
V8LazyEventListener::prepareListenerObject()
V8LazyEventListener::callListenerFun
LGTM -ip
http://codereview.chromium.org/1117010
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply
to this email with the words "REMOVE ME" as the subject.
LGTM -ip
http://codereview.chromium.org/1081014
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply
to this email with the words "REMOVE ME" as the subject.
Reviewers: ,
Message:
I have implemented copy constructor/= operator in StackFrameIterator for
easy
stack manipulations but didn't use it.
Just offering it here should anyone need it.
I'm sorry for spam.
Description:
Add a copy constructor to StackFrameIterator
Please review this at http:/
First round of comments.
http://codereview.chromium.org/1159005/diff/1/2
File src/ast.cc (right):
http://codereview.chromium.org/1159005/diff/1/2#newcode647
src/ast.cc:647: return expression()->IsPrimitive();
This should be
return !expression()->IsPrimitive();
right?
http://codereview.chromi
Revision: 4236
Author: o...@chromium.org
Date: Tue Mar 23 08:28:58 2010
Log: Make the new Date test independent of the timezone in which it is run.
Review URL: http://codereview.chromium.org/1084018
http://code.google.com/p/v8/source/detail?r=4236
Modified:
/branches/bleeding_edge/test/mjsunit/d
LGTM
http://codereview.chromium.org/1084018
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply
to this email with the words "REMOVE ME" as the subject.
Revision: 4235
Author: whe...@chromium.org
Date: Tue Mar 23 08:18:00 2010
Log: Fix an error in optimized modulus operator, add unit test.
Review URL: http://codereview.chromium.org/1118008
http://code.google.com/p/v8/source/detail?r=4235
Modified:
/branches/bleeding_edge/src/ia32/codegen-ia32.cc
Revision: 4233
Author: sgje...@chromium.org
Date: Tue Mar 23 07:59:36 2010
Log: Fix GetName and Print for CompareStub
Review URL: http://codereview.chromium.org/1108006
http://code.google.com/p/v8/source/detail?r=4233
Modified:
/branches/bleeding_edge/src/arm/codegen-arm.cc
/branches/bleeding_e
LGTM.
http://codereview.chromium.org/1118008
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply
to this email with the words "REMOVE ME" as the subject.
Status: Accepted
Owner:
Labels: Type-Bug Priority-Medium
New issue 660 by sgje...@chromium.org: Port inlining of number compare
http://code.google.com/p/v8/issues/detail?id=660
The ia32 change in r4220 should be ported to x64 and ARM.
--
You received this message because you are listed in
On 2010/03/23 13:35:11, Alexandre wrote:
Hi,
I corrected test-mips.cc and changed SetupAlignedCall code.
I think your problem running tools/test.py --simulator=mips is that your
src/flag-definitions.h is not good for MIPS.
You need these diffs to have it work:
Index: src/flag-definitions
Buffer size enlarged to 772. Added code checking if all of the dropped
digits
are zeros and appenging '1' (or '.1') if not. Added a test for 1000-digit
number.
http://codereview.chromium.org/1096002/diff/21004/27003
File src/conversions.cc (right):
http://codereview.chromium.org/1096002/diff/
Reviewers: fschneider,
Description:
Fix an error in optimized modulus operator, add unit test.
Please review this at http://codereview.chromium.org/1118008
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/ia32/codegen-ia32.cc
M test/mjsunit/div-m
Updates:
Status: Assigned
Owner: vego...@chromium.org
Comment #1 on issue 476 by vego...@chromium.org: Optimize CanvasPixelArray
and other CanvasArrays on ARM platform
http://code.google.com/p/v8/issues/detail?id=476
Done in bleeding_edge r4228.
--
You received this message b
LGTM. The flag looks fine and is needed when working on a new port.
http://codereview.chromium.org/1140004
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply
to this ema
Updates:
Status: Fixed
Comment #4 on issue 610 by vego...@chromium.org: Port optimize stirng plus
smi
http://code.google.com/p/v8/issues/detail?id=610
Done in bleeding_edge r4138.
Pushed to trunk in r4165 (Version 2.1.6)
--
You received this message because you are listed in the owne
Updates:
Status: Fixed
Comment #2 on issue 609 by vego...@chromium.org: Port probing of the symbol
table for two character strings in native code
http://code.google.com/p/v8/issues/detail?id=609
Done in bleeding_edge r4050.
Pushed to trunk in r4079 (Version 2.1.3)
--
You received thi
Updates:
Status: Fixed
Comment #2 on issue 659 by o...@chromium.org: Date doesn't correctly handle
large time values.
http://code.google.com/p/v8/issues/detail?id=659
Fixed in r4232.
--
You received this message because you are listed in the owner
or CC fields of this issue, or becau
Revision: 4232
Author: o...@chromium.org
Date: Tue Mar 23 07:47:02 2010
Log: Fix bug http://code.google.com/p/v8/issues/detail?id=659. Move the
limits check for date before the time zone offset is applied.
Review URL: http://codereview.chromium.org/1075016
http://code.google.com/p/v8/source/de
Reviewers: Mads Ager,
Description:
MIPS simple function calls
This lands http://codereview.chromium.org/1018001.
Patch by Alexandre Rames from Sigma Designs Inc.
Mads, please just have to look at the new flag --disable-native-files (two
files
not in the mips directory).
Please review this
LGTM, thanks!
http://codereview.chromium.org/1075016
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply
to this email with the words "REMOVE ME" as the subject.
Comment #1 on issue 659 by o...@chromium.org: Date doesn't correctly handle
large time values.
http://code.google.com/p/v8/issues/detail?id=659
Fixed by http://codereview.chromium.org/1075016. Waiting for review.
--
You received this message because you are listed in the owner
or CC fields o
Reviewers: Mads Ager,
Description:
Fix bug http://code.google.com/p/v8/issues/detail?id=659. Move the limits
check
for date before the time zone offset is applied.
Please review this at http://codereview.chromium.org/1075016
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Af
LGTM
http://codereview.chromium.org/1108006
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply
to this email with the words "REMOVE ME" as the subject.
Revision: 4231
Author: erik.co...@gmail.com
Date: Tue Mar 23 07:33:42 2010
Log: Fix pop push optimization to work with partial snapshots (correct
registration of external references in Proxy objects).
I moved the declaration of the two functions to stub-cache.h
because with all the types they use
Reviewers: Mads Ager,
Description:
Fix GetName and Print for CompareStub
Please review this at http://codereview.chromium.org/1108006
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/arm/codegen-arm.cc
M src/codegen.h
M src/ia32/codegen-ia3
LGTM!
http://codereview.chromium.org/1079012/diff/1/6
File src/assembler.h (right):
http://codereview.chromium.org/1079012/diff/1/6#newcode509
src/assembler.h:509:
Intentional edit?
http://codereview.chromium.org/1079012
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/
Revision: 4230
Author: whe...@chromium.org
Date: Tue Mar 23 07:24:41 2010
Log: Add binary operations with constants to the safe-int32 expression
compiler.
Review URL: http://codereview.chromium.org/1089004
http://code.google.com/p/v8/source/detail?r=4230
Modified:
/branches/bleeding_edge/src/
Reviewers: Kasper Lund,
Description:
Fix pop push optimization to work with partial snapshots (correct
registration of external references in Proxy objects).
I moved the declaration of the two functions to stub-cache.h
because with all the types they use it's hard to declare them
anywhere else.
Revision: 4229
Author: ant...@chromium.org
Date: Tue Mar 23 07:05:16 2010
Log: Trim underlying fixed array by one element from the left when doing
shift.
For now this trick is only done to objects in new space, see comments
for reasons.
Review URL: http://codereview.chromium.org/1076010
http:
Reviewers: fschneider,
Message:
As we discussed, control dependencies are not yet handled. We need to find
a
cheap way to do so.
Description:
Initial support for marking live code.
As part of aggressive dead code elimination, we initially assume all
flow-graph instructions are not live. We
Comment #5 on issue 658 by east...@gmail.com: d8 is not compiled in 'Debug
Win32' mode
http://code.google.com/p/v8/issues/detail?id=658
Tested the fix using revision 4226
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this
Revision: 4227
Author: kmilli...@chromium.org
Date: Tue Mar 23 06:36:38 2010
Log: Mark all loop conditions.
Previously we marked compare operations that occurred as for loop
conditions so as to avoid inlining the floating-point code for them.
Begin marking all expressions that occur as any loop c
Reviewers: Erik Corry, sandholm,
Message:
Largish review.
Description:
Run string replace regexp with function in C++ code loop.
Reuses the result array to save on allocation.
Matches Safari's behavior.
Please review this at http://codereview.chromium.org/1109010
Affected files:
M src/jsrege
http://codereview.chromium.org/1074009/diff/4001/5003
File src/data-flow.cc (right):
http://codereview.chromium.org/1074009/diff/4001/5003#newcode223
src/data-flow.cc:223: cond_copy->set_is_loop_condition(false);
On 2010/03/23 13:21:02, Søren Gjesse wrote:
Strictly speaking this is a lie, and i
Hi,
I corrected test-mips.cc and changed SetupAlignedCall code.
I think your problem running tools/test.py --simulator=mips is that your
src/flag-definitions.h is not good for MIPS.
You need these diffs to have it work:
Index: src/flag-definitions.h
=
Thanks a lot for review, Mads.
http://codereview.chromium.org/1076010/diff/1/2
File src/builtins.cc (right):
http://codereview.chromium.org/1076010/diff/1/2#newcode448
src/builtins.cc:448: // In large object space object's start must
coincide with chunk
On 2010/03/23 12:36:50, Mads Ager wrote:
LGTM
http://codereview.chromium.org/1074009/diff/4001/5003
File src/data-flow.cc (right):
http://codereview.chromium.org/1074009/diff/4001/5003#newcode223
src/data-flow.cc:223: cond_copy->set_is_loop_condition(false);
Strictly speaking this is a lie, and it will cause the number compare
code to
LGTM.
http://codereview.chromium.org/1074009/diff/4001/5004
File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/1074009/diff/4001/5004#newcode2475
src/ia32/codegen-ia32.cc:2475: bool is_loop_condition =
(node->AsExpression() != NULL) &&
I think we should change CodeGenerator::
Comment #4 on issue 658 by east...@gmail.com: d8 is not compiled in 'Debug
Win32' mode
http://code.google.com/p/v8/issues/detail?id=658
Checked the fix in r4226
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You
Revision: 4226
Author: mikhail.naga...@gmail.com
Date: Tue Mar 23 06:11:44 2010
Log: New GCCallbacks with additional parameters.
Author: Ilya Tikhonovsky
Original issue: http://codereview.chromium.org/1094002
tbr=sgje...@chromium.org
Review URL: http://codereview.chromium.org/1165004
http://co
Revision: 4225
Author: sgje...@chromium.org
Date: Tue Mar 23 06:09:33 2010
Log: Update Visual Studio project files.
Review URL: http://codereview.chromium.org/011
http://code.google.com/p/v8/source/detail?r=4225
Modified:
/branches/bleeding_edge/tools/visual_studio/js2c.cmd
/branches/bleedi
Reviewers: Søren Gjesse, fschneider,
Description:
Mark all loop conditions.
Previously we marked compare operations that occurred as for loop
conditions so as to avoid inlining the floating-point code for them.
Begin marking all expressions that occur as any loop condition
(because they are neve
LGTM.
http://codereview.chromium.org/011
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply
to this email with the words "REMOVE ME" as the subject.
Revision: 4224
Author: fschnei...@chromium.org
Date: Tue Mar 23 06:01:37 2010
Log: Add iterative primitive type analysis.
This change adds a data-flow pass to statically determine
if a variable contains a primitive type.
It requires building the flow graph and computing reaching
definitions as p
http://codereview.chromium.org/1132005/diff/19001/2008
File src/data-flow.h (right):
http://codereview.chromium.org/1132005/diff/19001/2008#newcode208
src/data-flow.h:208: class BlockNode;
On 2010/03/23 12:41:14, Kevin Millikin wrote:
No longer needed.
Done.
http://codereview.chromium.org/11
LGTM
http://codereview.chromium.org/1165004
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply
to this email with the words "REMOVE ME" as the subject.
Reviewers: Kasper Lund,
Description:
Update Visual Studio project files.
Please review this at http://codereview.chromium.org/011
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M tools/visual_studio/js2c.cmd
M tools/visual_studio/v8.vcproj
M
Reviewers: Søren Gjesse,
Description:
New GCCallbacks with additional parameters.
Author: Ilya Tikhonovsky
Original issue: http://codereview.chromium.org/1094002
tbr=sgje...@chromium.org
Please review this at http://codereview.chromium.org/1165004
Affected files:
M include/v8.h
M src/api
Revision: 4223
Author: o...@chromium.org
Date: Tue Mar 23 05:48:42 2010
Log: Modify FastD2I to use static_cast instead of lrint(). Benchmarks show
that it's much faster this way.
Review URL: http://codereview.chromium.org/1128010
http://code.google.com/p/v8/source/detail?r=4223
Modified:
/br
Updates:
Status: Fixed
Comment #1 on issue 657 by mikhail.naganov: Update test-log-stack-tracer.cc
after JSFunction boilerplate removal
http://code.google.com/p/v8/issues/detail?id=657
Fixed in http://code.google.com/p/v8/source/detail?r=4222
--
You received this message because you
LGTM
http://codereview.chromium.org/1175001
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply
to this email with the words "REMOVE ME" as the subject.
Revision: 4222
Author: mikhail.naga...@gmail.com
Date: Tue Mar 23 05:42:47 2010
Log: Fix issue 658: update test-log-stack-tracer after r4211.
It appears that semi-automatic changes made to test's code were
incorrect. v8::Script::Compile returns wrapped JSFunction,
not SharedFunctionInfo.
Review
LGTM
http://codereview.chromium.org/1158005
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply
to this email with the words "REMOVE ME" as the subject.
Revision: 4220
Author: sgje...@chromium.org
Date: Tue Mar 23 05:36:31 2010
Log: Inline floating point compare
Inline floating point compare instead of calling the stub when the
following conditions are met:
* Code is in a loop
* Compare is not a for loop condition
* Compare is not an equ
LGTM.
http://codereview.chromium.org/1132005/diff/19001/2008
File src/data-flow.h (right):
http://codereview.chromium.org/1132005/diff/19001/2008#newcode208
src/data-flow.h:208: class BlockNode;
No longer needed.
http://codereview.chromium.org/1132005/diff/19001/2003
File src/prettyprinter.cc
Thanks!
http://codereview.chromium.org/1169002/diff/1/2
File test/cctest/test-log-stack-tracer.cc (right):
http://codereview.chromium.org/1169002/diff/1/2#newcode215
test/cctest/test-log-stack-tracer.cc:215: ret_addr,
On 2010/03/23 11:53:28, Kasper Lund wrote:
Indentation.
Done.
http://code
Revision: 4221
Author: kasp...@chromium.org
Date: Tue Mar 23 05:36:41 2010
Log: Remove the last of the obsolete *-delay.js files. This one
is replaced by src/liveedit-debugger.js.
Review URL: http://codereview.chromium.org/1158005
http://code.google.com/p/v8/source/detail?r=4221
Deleted:
/branch
LGTM
http://codereview.chromium.org/1076010/diff/1/2
File src/builtins.cc (right):
http://codereview.chromium.org/1076010/diff/1/2#newcode448
src/builtins.cc:448: // In large object space object's start must
coincide with chunk
object's -> the object's
http://codereview.chromium.org/1076010/di
TBR'ed.
On Tue, Mar 23, 2010 at 1:22 PM, wrote:
> Reviewers: Erik Corry,
>
> Description:
> Remove the last of the obsolete *-delay.js files. This one
> is replaced by src/liveedit-debugger.js.
>
> Please review this at http://codereview.chromium.org/1158005
>
> SVN Base: http://v8.googlecode.co
LGTM if you increase the buffer size to the max-double string.
Please upload a new version here before committing (just to make comparison
easier).
http://codereview.chromium.org/1096002/diff/21004/27003
File src/conversions.cc (right):
http://codereview.chromium.org/1096002/diff/21004/27003#ne
Revision: 4219
Author: kasp...@chromium.org
Date: Tue Mar 23 05:31:52 2010
Log: Bring back source line accidentally removed in r4217.
Review URL: http://codereview.chromium.org/1153008
http://code.google.com/p/v8/source/detail?r=4219
Modified:
/branches/bleeding_edge/src/debug.cc
==
LGTM
http://codereview.chromium.org/1153008
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply
to this email with the words "REMOVE ME" as the subject.
Updates:
Status: Fixed
Comment #3 on issue 658 by kasp...@chromium.org: d8 is not compiled
in 'Debug Win32' mode
http://code.google.com/p/v8/issues/detail?id=658
Fixed in r4218.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because yo
Revision: 4218
Author: kasp...@chromium.org
Date: Tue Mar 23 05:23:15 2010
Log: Fix issue 658 by adapting the d8.cc code to the new types of
scripts (either a JSFunction or a SharedFunctionInfo).
Review URL: http://codereview.chromium.org/1077010
http://code.google.com/p/v8/source/detail?r=4218
M
Reviewers: Erik Corry,
Description:
Remove the last of the obsolete *-delay.js files. This one
is replaced by src/liveedit-debugger.js.
Please review this at http://codereview.chromium.org/1158005
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
D src/liveed
LGTM
http://codereview.chromium.org/1077010
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply
to this email with the words "REMOVE ME" as the subject.
Reviewers: Mads Ager,
Description:
Fix issue 658 by adapting the d8.cc code to the new types of
scripts (either a JSFunction or a SharedFunctionInfo).
Please review this at http://codereview.chromium.org/1077010
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M
Status: Accepted
Owner: o...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 659 by lasserei...@gmail.com: Date doesn't correctly handle large
time values.
http://code.google.com/p/v8/issues/detail?id=659
Large time values are incorrectly converted to NaN results
var d = new Date(864
Reviewers: Søren Gjesse,
Description:
Bring back source line accidentally removed in r4217.
Please review this at http://codereview.chromium.org/1153008
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/debug.cc
Index: src/debug.cc
===
LGTM
http://codereview.chromium.org/1094014/diff/1/33
File src/SConscript (right):
http://codereview.chromium.org/1094014/diff/1/33#newcode260
src/SConscript:260: debug-debugger.js
We will break the other builds unless we do this other places too.
http://codereview.chromium.org/1094014/diff/1/
Comment #2 on issue 658 by kasp...@chromium.org: d8 is not compiled
in 'Debug Win32' mode
http://code.google.com/p/v8/issues/detail?id=658
Compiling d8 in debug mode fails on Linux too.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because yo
Reviewers: Mads Ager,
Message:
Mads,
may you have a look?
Any other spaces where object could span the page? LargeObject seems fine
as it
only provides Contains(HeapObject*) and thus unless some one fakes
HeapObject*,
there should be no problems imho.
Couple of notes:
1) probably new sp
Updates:
Status: Fixed
Comment #2 on issue 632 by kasp...@chromium.org: Weird crashes after
changing GC policy
http://code.google.com/p/v8/issues/detail?id=632
This seems fixed. The deserialization tests have been reenabled in r4217.
--
You received this message because you are liste
Great. thanks. This should remove any remaining doubts (if there were any).
Btw: if you want to play with doubles have a look at doubles.h (recently
checked in). It gives easy access to significands and exponents.
// florian
On Tue, Mar 23, 2010 at 12:36 PM, Sergey Ryazanov wrote:
>
> 4.45014771
LGTM.
http://codereview.chromium.org/1169002/diff/1/2
File test/cctest/test-log-stack-tracer.cc (right):
http://codereview.chromium.org/1169002/diff/1/2#newcode215
test/cctest/test-log-stack-tracer.cc:215: ret_addr,
Indentation.
http://codereview.chromium.org/1169002/diff/1/2#newcode294
test/c
Updates:
Status: Assigned
Owner: sgje...@chromium.org
Cc: a...@chromium.org sandh...@chromium.org
Comment #1 on issue 658 by a...@chromium.org: d8 is not compiled in 'Debug
Win32' mode
http://code.google.com/p/v8/issues/detail?id=658
Søren, could you have a look?
--
Y
LGTM!
http://codereview.chromium.org/993002/diff/49001/50003
File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/993002/diff/49001/50003#newcode4753
src/arm/codegen-arm.cc:4753: // We have -1, 0 or 1, which we treat
specially.
Could we clearify the comment to state that source c
http://codereview.chromium.org/1132005/diff/1/8
File src/ast.cc (right):
http://codereview.chromium.org/1132005/diff/1/8#newcode523
src/ast.cc:523: bool VariableProxy::IsPrimitive() { return
is_primitive_; }
On 2010/03/23 07:52:42, Kevin Millikin wrote:
Move this function after the "not primiti
4.450147717014402025081996672794991863585242658592605113516950912287262231249312640695305412711894243178380137008083052315457825154530323827726959236845743044099361970891187471508150509418060480375117378320411851935338796416115205148741308316327252012460602310586905362063117526562176521464664318142
Reviewers: Erik Corry,
Description:
Merge the partial_snapshots branch back into bleeding_edge. For
now, the custom call generator stuff is disabled.
Please review this at http://codereview.chromium.org/1094014
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M
LGTM
http://codereview.chromium.org/1094002
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply
to this email with the words "REMOVE ME" as the subject.
When I run tools/test.py --simulator=mips it turns out that the test
test-mips/MIPS_function_calls fails as it hits a large number of
UNIMPLEMENTED_MIPS. Is Was that the intention?
Also two more comments:
1. Regarding writing below the stack pointer in
MacroAssembler::SetupAlignedCall. I don't
http://codereview.chromium.org/1094002/diff/41001/42003
File include/v8.h (right):
http://codereview.chromium.org/1094002/diff/41001/42003#newcode2324
include/v8.h:2324: static void AddGCPrologueCallback(GCPrologueCallback
callback,
On 2010/03/23 09:20:22, Søren Gjesse wrote:
Please format like
Reviewers: Kasper Lund,
Message:
Kasper, may I ask you to review this fix, as you were the reviewer for
Ivan's
change.
Description:
Fix issue 658: update test-log-stack-tracer after r4211.
It appears that semi-automatic changes made to test's code were
incorrect. v8::Script::Compile returns
Status: New
Owner:
New issue 658 by east...@gmail.com: d8 is not compiled in 'Debug Win32' mode
http://code.google.com/p/v8/issues/detail?id=658
OS: Windows XP Professional Service Pack 3 x86
Compiler: Microsoft Visual C++ 2008
Sources Branch: http://v8.googlecode.com/svn/branches/bleeding_
Rubber stamp LGTM
http://codereview.chromium.org/1113009
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply
to this email with the words "REMOVE ME" as the subject.
Reviewers: Mads Ager,
Message:
Mads,
may you have a look?
Description:
Trim underlying fixed array by one element from the left when doing shift.
For now this trick is only done to objects in new space, see comments
for reasons.
Please review this at http://codereview.chromium.org/1076010
Af
Reviewers: Erik Corry,
Description:
Merge 4205:4215 from bleeding_edge to partial_snapshots branch.
Please review this at http://codereview.chromium.org/1113009
SVN Base:
http://v8.googlecode.com/svn/branches/experimental/partial_snapshots/
Affected files:
M src/api.h
M src/api.
http://codereview.chromium.org/1089004/diff/1/2
File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/1089004/diff/1/2#newcode7134
src/ia32/codegen-ia32.cc:7134: left.ToRegister();
On 2010/03/22 10:30:42, fschneider wrote:
Do we need right.ToRegister() here as well?
No. If ri
http://codereview.chromium.org/1117011/diff/1/5
File src/codegen.h (right):
http://codereview.chromium.org/1117011/diff/1/5#newcode369
src/codegen.h:369: // the stub will be called due to number comparison
not working.
On 2010/03/23 09:41:55, Mads Ager wrote:
will be called if one of the operan
1 - 100 of 118 matches
Mail list logo
