Reviewers: Jakob,
Message:
Hi Jakob,
In testing, I found one AST node that didn't have the required slot support
for
store ics. This addresses that oversight...ClassLiteral works similarly to
ObjectLiteral, just a bit simpler.
Thanks for the look!
--Michael
Description:
Vector ICs:
https://codereview.chromium.org/1155043005/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/1155043005/diff/1/src/api.cc#newcode7214
src/api.cc:7214: if (index i::LAST_SPACE || (i::FIRST_SPACE 0
index i::FIRST_SPACE))
The way I read globals.h, i::FIRST_SPACE would
Patchset 1 (id:??) landed as
https://crrev.com/7a7a0735682809338178761db415ce5475eaa4b2
Cr-Commit-Position: refs/heads/master@{#28807}
https://codereview.chromium.org/1168573003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1168573003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Reviewers: titzer,
Description:
[turbofan] Allow ReplaceWithValue to kill control.
This allows any AdvancedReducer to remove exception projections from
graphs. This is the common case when JS-operators are being replaced
with pure values. The old NodeProperties::ReplaceWithValue is being
Reviewers: tandrii(chromium), Jakob,
Message:
PTAL. The hearbeat method is simply not called when the indicators are
chained.
The output never shows up on the bots and the recipes can sometimes timeout,
like:
Redid the names, I like Adam's suggestion that non-strong mode should be
NORMAL, since it doesn't inspire the same confusion that seeing WEAK
scattered around in object initialization would.
I can't think of a better name for the enum itself than Strength, since
it's
already being used by
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1163523008/1
https://codereview.chromium.org/1163523008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
lgtm
https://codereview.chromium.org/1163523008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1168693002/diff/1/src/compiler/graph-reducer.h
File src/compiler/graph-reducer.h (right):
https://codereview.chromium.org/1168693002/diff/1/src/compiler/graph-reducer.h#newcode126
src/compiler/graph-reducer.h:126: GraphReducer(Graph* graph, Node*
dead_value,
Reviewers: ulan,
Description:
Add CHECKs to verify that we never finalize stale copies of external strings
BUG=none
R=u...@chromium.org
LOG=n
Please review this at https://codereview.chromium.org/1160253010/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+8, -1
Reviewers: Jakob,
Message:
Hi Jakob,
This helps in passing debugger tests :),
--Michael
Description:
Vector ICs: debugger should save registers for vector store ics.
BUG=
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/1154303008/
Base URL:
Reviewers: Michael Starzinger,
Message:
PTAL
Description:
Fixed memory leak in JSDate::JSDatePrint().
BUG=chromium:496013
LOG=N
Please review this at https://codereview.chromium.org/1163203002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -1 lines):
M
Patchset 1 (id:??) landed as
https://crrev.com/e728125131a6a6638da0af1d0b95c5d3f368667b
Cr-Commit-Position: refs/heads/master@{#28808}
https://codereview.chromium.org/1163523008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Comments addressed.
https://codereview.chromium.org/1168693002/diff/1/src/compiler/graph-reducer.h
File src/compiler/graph-reducer.h (right):
https://codereview.chromium.org/1168693002/diff/1/src/compiler/graph-reducer.h#newcode126
src/compiler/graph-reducer.h:126: GraphReducer(Graph* graph,
Patchset 1 (id:??) landed as
https://crrev.com/ca2f8d811ca08783e38ce5dd42d38a6b6a7b876f
Cr-Commit-Position: refs/heads/master@{#28811}
https://codereview.chromium.org/1160253010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1160253010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
won't this almost immediately scale the new space up to full size again?
https://codereview.chromium.org/1164013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
Ulan or Hannes should approve this
https://codereview.chromium.org/1147503002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
lgtm
https://codereview.chromium.org/1160253010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
LGTM with comments.
https://codereview.chromium.org/1146963002/diff/160001/src/compiler/js-intrinsic-lowering.cc
File src/compiler/js-intrinsic-lowering.cc (right):
https://codereview.chromium.org/1146963002/diff/160001/src/compiler/js-intrinsic-lowering.cc#newcode464
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1168693002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Reviewers: titzer,
Description:
[turbofan] Turn JSBuiltinReducer into an AdvancedReducer.
This in turn allows usage of AdvancedReducer::ReplaceWithValue which
has access to the underlying graph reducer. It will allow us to deal
with exception continuations correctly.
R=tit...@chromium.org
Patchset 3 (id:??) landed as
https://crrev.com/8f4d9a0a1e5fc3b761409f851813831aad7dd53f
Cr-Commit-Position: refs/heads/master@{#28810}
https://codereview.chromium.org/1168693002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1163203002/1
https://codereview.chromium.org/1163203002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
PTAL.
https://codereview.chromium.org/1147503002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 (id:1)
https://codereview.chromium.org/1163523008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
https://codereview.chromium.org/1168693002/diff/20001/src/compiler/graph-reducer.h
File src/compiler/graph-reducer.h (right):
https://codereview.chromium.org/1168693002/diff/20001/src/compiler/graph-reducer.h#newcode174
src/compiler/graph-reducer.h:174: Node* const dead_value_;
On 2015/06/05
LGTM
https://codereview.chromium.org/1147503002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1160253010/1
https://codereview.chromium.org/1160253010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
lgtm
https://codereview.chromium.org/1158273011/diff/60001/test/unittests/compiler/js-builtin-reducer-unittest.cc
File test/unittests/compiler/js-builtin-reducer-unittest.cc (right):
LGTM.
https://codereview.chromium.org/1149133005/diff/11/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/1149133005/diff/11/src/compiler/ast-graph-builder.cc#newcode2313
src/compiler/ast-graph-builder.cc:2313: if
Patchset 11 (id:??) landed as
https://crrev.com/74f9d8c901ba68c2d664b6e1e3ba80cf0efe8e02
Cr-Commit-Position: refs/heads/master@{#28812}
https://codereview.chromium.org/1146963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #11 (id:21)
https://codereview.chromium.org/1146963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 2 (id:??) landed as
https://crrev.com/a6f23850a5106931c4e73e8ce0f339ec917b36a5
Cr-Commit-Position: refs/heads/master@{#28813}
https://codereview.chromium.org/1158273011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #2 (id:60001)
https://codereview.chromium.org/1158273011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1158273011/60001
https://codereview.chromium.org/1158273011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
https://codereview.chromium.org/1149133005/diff/11/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/1149133005/diff/11/src/compiler/ast-graph-builder.cc#newcode2313
src/compiler/ast-graph-builder.cc:2313: if
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1149133005/11
https://codereview.chromium.org/1149133005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1165003005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Comment #11 on issue 3895 by bugdro...@chromium.org: Array.prototype.find
incorrectly skips holes
https://code.google.com/p/v8/issues/detail?id=3895#c11
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/d269e22de93efa6abc45c386939fdec44ffe9fdf
Committed patchset #1 (id:11)
https://codereview.chromium.org/1149133005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Reviewers: titzer,
Description:
[turbofan] Turn LoadElimination into an AdvancedReducer.
This in turn allows usage of AdvancedReducer::ReplaceWithValue which
has access to the underlying graph reducer.
R=tit...@chromium.org
Please review this at https://codereview.chromium.org/1158723005/
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1165003005/40001
https://codereview.chromium.org/1165003005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Updates:
Status: Fixed
Comment #12 on issue 3895 by a...@chromium.org: Array.prototype.find
incorrectly skips holes
https://code.google.com/p/v8/issues/detail?id=3895
(No comment was entered for this change.)
--
You received this message because this project is configured to send
Comment #89 on issue 3330 by bugdro...@chromium.org: Implement ES6 classes
https://code.google.com/p/v8/issues/detail?id=3330#c89
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/06c706d84c04fc2e31e993518df9dcefb7543a2d
commit
https://codereview.chromium.org/1149133005/diff/11/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/1149133005/diff/11/src/compiler/ast-graph-builder.cc#newcode2313
src/compiler/ast-graph-builder.cc:2313: if
I assume we have a similar issue here?
https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/runtime/runtime-classes.ccl=165
https://codereview.chromium.org/1160173004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Patchset 3 (id:??) landed as
https://crrev.com/d269e22de93efa6abc45c386939fdec44ffe9fdf
Cr-Commit-Position: refs/heads/master@{#28814}
https://codereview.chromium.org/1165003005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Patchset 1 (id:??) landed as
https://crrev.com/06c706d84c04fc2e31e993518df9dcefb7543a2d
Cr-Commit-Position: refs/heads/master@{#28815}
https://codereview.chromium.org/1149133005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
LGTM with nits.
https://codereview.chromium.org/1160973006/diff/20001/build/toolchain.gypi
File build/toolchain.gypi (right):
https://codereview.chromium.org/1160973006/diff/20001/build/toolchain.gypi#newcode341
build/toolchain.gypi:341: ['v8_target_arch==target_arch and
(v8_target_arch==mips
Thank, addressed comments. Landing.
https://codereview.chromium.org/1149623010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group
https://codereview.chromium.org/1168643005/diff/120001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/1168643005/diff/120001/test/cctest/test-parsing.cc#newcode6556
test/cctest/test-parsing.cc:6556: {var x, y, z; for (x in , =
{});},
This
Comment #8 on issue 3565 by brian.te...@gmail.com: Generator function
deviations from ES6
https://code.google.com/p/v8/issues/detail?id=3565
6. `this` in a generator body called with new throws a reference error (see
I'm a bit worried about this affecting parse performance, due to the
increased
shuffling around of classifier data. But maybe it's not that bad.
https://codereview.chromium.org/1168643005/diff/20001/src/preparser.h
File src/preparser.h (right):
Reviewers: paul.l..., akos.palfi.imgtec, balazs.kilvady,
Description:
Revert MIPS64: Fix lithium arithmetic operations for integers to
sign-extend
result.
This reverts commit 75744da2689c57c3c8c5bbff2965fe9afe602258.
revert reason:
octane failures.
BUG=
Please review this at
LGTM
https://codereview.chromium.org/1160143008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Hannes Payer,
Message:
Hannes, wdyt?
I will add gc-tracer function to report the full incremental marking
duration
(total steps + final pause) per GC. Until then this works only with
--noincremental-marking.
Description:
WIP: Compute the heap growing factor based on mutator
Patchset 1 (id:??) landed as
https://crrev.com/ca0991c9bc665ce05d553733117339664832ce34
Cr-Commit-Position: refs/heads/master@{#28819}
https://codereview.chromium.org/1160143008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
https://codereview.chromium.org/1157843006/diff/20001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/1157843006/diff/20001/src/api.cc#newcode6276
src/api.cc:6276: int length = size * 2;
On 2015/06/05 15:05:47, Jakob wrote:
On 2015/06/03 15:35:30, adamk wrote:
On
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1160143008/1
https://codereview.chromium.org/1160143008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Committed patchset #1 (id:1)
https://codereview.chromium.org/1160143008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
https://codereview.chromium.org/1168643005/diff/120001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/1168643005/diff/120001/test/cctest/test-parsing.cc#newcode6556
test/cctest/test-parsing.cc:6556: {var x, y, z; for (x in , =
{});},
On
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1158723005/1
https://codereview.chromium.org/1158723005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Lgtm, need approval from Google team.
https://codereview.chromium.org/1160973006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group
lgtm
https://codereview.chromium.org/1158723005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: jochen,
Description:
Add TypedArray constructors with SharedArrayBuffer to the external API.
BUG=
LOG=n
Please review this at https://codereview.chromium.org/1168723002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+192, -38 lines):
M include/v8.h
Reviewers: titzer,
Description:
[turbofan] Turn JSContextSpecializer into an AdvancedReducer.
This in turn allows usage of AdvancedReducer::ReplaceWithValue which
has access to the underlying graph reducer.
R=tit...@chromium.org
Please review this at
Patchset 3 (id:??) landed as
https://crrev.com/050e8880f51070e1db3c79bdce9ea33f6ca3042b
Cr-Commit-Position: refs/heads/master@{#28816}
https://codereview.chromium.org/1151333005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #3 (id:11)
https://codereview.chromium.org/1151333005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Reviewers: jochen,
Message:
PTAL. This helps with postmortem debugging of OOM.
Description:
Print and save JS stacktrace on OOM crash.
BUG=
Please review this at https://codereview.chromium.org/1149623010/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+56, -13
Patchset 1 (id:??) landed as
https://crrev.com/5cefb367ceac8251b3d7aca27388a4c5e8c95c76
Cr-Commit-Position: refs/heads/master@{#28817}
https://codereview.chromium.org/1158723005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
https://codereview.chromium.org/1160973006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it, send
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1151333005/11
https://codereview.chromium.org/1151333005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Comment #30 on issue 3578 by oao.hika...@gmail.com: Implement ES6 typed
array methods: forEach, every, fill, indexOf, join...
https://code.google.com/p/v8/issues/detail?id=3578
TypedArray.prototype.slice ?
http://people.mozilla.org/~jorendorff/es6-draft.html#sec-%typedarray%.prototype.slice
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1149623010/20001
https://codereview.chromium.org/1149623010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Patchset 2 (id:??) landed as
https://crrev.com/25981994b781624518540e9fc28c09a40d635245
Cr-Commit-Position: refs/heads/master@{#28818}
https://codereview.chromium.org/1149623010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1149623010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
lgtm with nits
https://codereview.chromium.org/1149623010/diff/1/src/string-stream.h
File src/string-stream.h (right):
https://codereview.chromium.org/1149623010/diff/1/src/string-stream.h#newcode42
src/string-stream.h:42: ~FixedStringAllocator() {}
override
Committed patchset #1 (id:1)
https://codereview.chromium.org/1158723005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
LGTM.
https://codereview.chromium.org/1163203002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Patchset 1 (id:??) landed as
https://crrev.com/16bbd48f35c9d9f2c249b92a96c00bf548ec2714
Cr-Commit-Position: refs/heads/master@{#28809}
https://codereview.chromium.org/1163203002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1163203002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
lgtm
https://codereview.chromium.org/1168693002/diff/20001/src/compiler/graph-reducer.h
File src/compiler/graph-reducer.h (right):
https://codereview.chromium.org/1168693002/diff/20001/src/compiler/graph-reducer.h#newcode174
src/compiler/graph-reducer.h:174: Node* const dead_value_;
Const is
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1168693002/40001
https://codereview.chromium.org/1168693002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Feedback addressed, landing
https://codereview.chromium.org/1146963002/diff/160001/src/compiler/js-intrinsic-lowering.cc
File src/compiler/js-intrinsic-lowering.cc (right):
https://codereview.chromium.org/1146963002/diff/160001/src/compiler/js-intrinsic-lowering.cc#newcode464
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1146963002/21
https://codereview.chromium.org/1146963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
lgtm
https://codereview.chromium.org/1151333005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Updates:
Owner: little...@chromium.org
Cc: dslo...@chromium.org ad...@chromium.org
Labels: Area-Language
Comment #3 on issue 3048 by ad...@chromium.org: Array.prototype methods
applied to TypedArray instances should throw errors
Updates:
Status: Fixed
Comment by ad...@chromium.org:
These methods have all been implemented, staged, and from what I can tell
are compliant.
Affected issues:
issue 4112: Implement Array.from
http://code.google.com/p/v8/issues/detail?id=4112
issue 4113: Implement Array.of
Status: Assigned
Owner: wi...@igalia.com
CC: m...@mikepennisi.com, a...@chromium.org
Labels: Type-Bug Priority-Medium Harmony OS-All HW-All Area-Language
New issue 4163 by a...@chromium.org: Construct on generator functions
https://code.google.com/p/v8/issues/detail?id=4163
We are failing this
Updates:
Status: Fixed
Owner: ad...@chromium.org
Comment #4 on issue 948 by ad...@chromium.org: Incorrect behavior of |var|
statement appearing after a freeze() call: throws exception
https://code.google.com/p/v8/issues/detail?id=948
Looks like this was fixed at some point,
Updates:
Owner: little...@chromium.org
Cc: dslo...@chromium.org ad...@chromium.org
Labels: Area-Language Priority-Medium
Comment #2 on issue 3799 by ad...@chromium.org: The [[Configurable]]
attribute of properties of typed arrays should be false
Comment #1 on issue 4163 by m...@mikepennisi.com: Construct on generator
functions
https://code.google.com/p/v8/issues/detail?id=4163
I think it's correct. Declarations like:
function* g() {}
Are created like this:
14.4.14 Runtime Semantics: Evaluation
GeneratorExpression :
Reviewers: michael_dawson, rmcilroy,
Description:
Fix issues with Arm's use of embedded constant pools
- Handle non-instruction-aligned pc in Assembler::Align
- Fix several misuses of r8 (alias of the pool pointer register, pp)
- Fix calculation of pp in OSR/handler entry invocation
- Enable
Comment #2 on issue 4163 by a...@chromium.org: Construct on generator
functions
https://code.google.com/p/v8/issues/detail?id=4163
Thank you so much.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your
Status: Assigned
Owner: machenb...@chromium.org
CC: a...@chromium.org, rossb...@chromium.org
Labels: Type-Bug Priority-Medium Component-Tests
New issue 4164 by a...@chromium.org: Make the status file support filtering
on variants or flags
https://code.google.com/p/v8/issues/detail?id=4164
Reviewers: Michael Achenbach (OOO), rossberg,
Message:
PTAL
Description:
This updates the test runner to run all tests in both sloppy
and strict mode.
It also marks the test in the status file as failing in
sloppy mode even if all it does is marking the test as
[PASS, FAIL]. A future CL will
Updates:
Status: Started
Comment #31 on issue 3578 by little...@chromium.org: Implement ES6 typed
array methods: forEach, every, fill, indexOf, join...
https://code.google.com/p/v8/issues/detail?id=3578
Oops, forgot slice.
--
You received this message because this project is
1 - 100 of 101 matches
Mail list logo
