On 2015/07/01 17:47:23, rossberg wrote:
On 2015/07/01 12:16:57, bradn wrote:
> Some other type system questions:
>
> * Should Function(R, S, T0, T1...) types be unionable with each other?
(I.e.
can
> I use them to express the overloaded nature of Math.abs etc?) Some care
will
be
> required
LGTM other than the previous comment.
https://codereview.chromium.org/1287383003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group
https://codereview.chromium.org/1287383003/diff/31/test/mjsunit/regress/regress-crbug-513507.js
File test/mjsunit/regress/regress-crbug-513507.js (right):
https://codereview.chromium.org/1287383003/diff/31/test/mjsunit/regress/regress-crbug-513507.js#newcode22
test/mjsunit/regress/regres
On 2015/09/13 12:10:03, dougc wrote:
On 2015/04/20 12:20:40, titzer wrote:
>
https://codereview.chromium.org/1095063002/diff/1/src/compiler/js-typed-lowering.cc
> File src/compiler/js-typed-lowering.cc (right):
>
>
https://codereview.chromium.org/1095063002/diff/1/src/compi
https://codereview.chromium.org/1304923004/diff/60001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/1304923004/diff/60001/src/ast.h#newcode3280
src/ast.h:3280: : zone_(ast_value_factory->zone()),
Can we rename this zone to be clearer as well?
https://codereview.chromium.org/
Reviewers: Benedikt Meurer,
Description:
[turbofan] support for Int64 in CheckedLoad/CheckedStore on 64-bit
platforms.
This is to support WebAssembly 64-bit ints in the short term, since it
currently uses CheckedLoad/CheckedStore for accesses to the memory. In the
long run, we'll change this
lgtm other than existential questions
https://codereview.chromium.org/1318823010/diff/20001/src/ast-expression-visitor.h
File src/ast-expression-visitor.h (right):
https://codereview.chromium.org/1318823010/diff/20001/src/ast-expression-visitor.h#newcode25
src/ast-expression-visitor.h:25: Funct
lgtm with comment
https://codereview.chromium.org/1322773002/diff/110001/src/typing-asm.cc
File src/typing-asm.cc (right):
https://codereview.chromium.org/1322773002/diff/110001/src/typing-asm.cc#newcode44
src/typing-asm.cc:44: AsmTyper::AsmTyper(CompilationInfo* info)
Can we make this take a P
https://codereview.chromium.org/1322773002/diff/60001/src/typing-asm.cc
File src/typing-asm.cc (right):
https://codereview.chromium.org/1322773002/diff/60001/src/typing-asm.cc#newcode343
src/typing-asm.cc:343: RECURSE(VisitWithExpectation(stmt->cond(),
cache_.kInt32,
Is this also true? I thought
lgtm
https://codereview.chromium.org/1319983004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1319983004/diff/40001/test/cctest/expression-type-collector-macros.h
File test/cctest/expression-type-collector-macros.h (right):
https://codereview.chromium.org/1319983004/diff/40001/test/cctest/expression-type-collector-macros.h#newcode17
test/cctest/expression-
lgtm
https://codereview.chromium.org/1322003002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1326493002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1319983004/diff/20001/test/cctest/expression-type-collector-macros.h
File test/cctest/expression-type-collector-macros.h (right):
https://codereview.chromium.org/1319983004/diff/20001/test/cctest/expression-type-collector-macros.h#newcode17
test/cctest/expression-
https://codereview.chromium.org/1322773002/diff/40001/src/typing-asm.cc
File src/typing-asm.cc (right):
https://codereview.chromium.org/1322773002/diff/40001/src/typing-asm.cc#newcode59
src/typing-asm.cc:59: #define RECURSE_EXPR(expr, expected_type, msg)
\
Can these four macros be
lgtm
https://codereview.chromium.org/1306683003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Aha, looks like it was just the output buffer which was unaligned.
lgtm
https://codereview.chromium.org/1323663003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" gro
lgtm ich mag
https://codereview.chromium.org/1314473007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving email
On 2015/08/28 11:54:47, Michael Starzinger wrote:
Ben: PTAL.
Ross: FYI.
LGTM
https://codereview.chromium.org/1320503004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-d
On 2015/08/27 18:06:15, titzer wrote:
PTAL
https://codereview.chromium.org/1310283005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
On 2015/08/27 19:55:36, Michael Starzinger wrote:
https://codereview.chromium.org/1321663003/diff/40001/test/cctest/interpreter/test-bytecode-generator.cc
File test/cctest/interpreter/test-bytecode-generator.cc (right):
https://codereview.chromium.org/1321663003/diff/40001/test/cctest/interpr
lgtm
https://codereview.chromium.org/1307093006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1321553002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
On 2015/08/26 19:21:38, mtbrandyberry wrote:
On 2015/08/26 19:18:37, titzer wrote:
>
https://codereview.chromium.org/1315183002/diff/1/src/compiler/ppc/code-generator-ppc.cc
> File src/compiler/ppc/code-generator-ppc.cc (right):
>
>
https://codereview.chromium.org/131518300
https://codereview.chromium.org/1315183002/diff/1/src/compiler/ppc/code-generator-ppc.cc
File src/compiler/ppc/code-generator-ppc.cc (right):
https://codereview.chromium.org/1315183002/diff/1/src/compiler/ppc/code-generator-ppc.cc#newcode1348
src/compiler/ppc/code-generator-ppc.cc:1348:
frame()-
Looks much better with the GetDebugName() changes.
lgtm
https://codereview.chromium.org/1308863004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscr
lgtm
https://codereview.chromium.org/1314843002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
On 2015/08/25 09:40:14, Yang wrote:
On 2015/08/24 19:51:52, titzer wrote:
LGTM.
I wonder whether we can know the code kind upfront, even if the code
object
does
not exist yet. And where do we need the code kind when calling into a code
object that does not yet exist?
As discussed in
lgtm
https://codereview.chromium.org/1288773007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
On 2015/08/22 01:19:13, bradn wrote:
https://codereview.chromium.org/1288773007/diff/220001/src/ast-expression-visitor.cc
File src/ast-expression-visitor.cc (right):
https://codereview.chromium.org/1288773007/diff/220001/src/ast-expression-visitor.cc#newcode63
src/ast-expression-visitor.cc:6
lgtm
https://codereview.chromium.org/1297203002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1308763003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm agree completely please more better
https://codereview.chromium.org/1309883002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gr
lgtm
https://codereview.chromium.org/1310603002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
On 2015/08/21 14:58:32, Michael Starzinger wrote:
lgtm
https://codereview.chromium.org/1309813002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscri
lgtm
https://codereview.chromium.org/1304053004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1297203002/diff/60001/src/codegen.cc
File src/codegen.cc (right):
https://codereview.chromium.org/1297203002/diff/60001/src/codegen.cc#newcode160
src/codegen.cc:160: info->IsStub() || info->IsBytecodeHandler();
Here too
https://codereview.chromium.org/1297203002/
lgtm
https://codereview.chromium.org/1283193007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1288773007/diff/160001/src/ast-expression-visitor.cc
File src/ast-expression-visitor.cc (right):
https://codereview.chromium.org/1288773007/diff/160001/src/ast-expression-visitor.cc#newcode17
src/ast-expression-visitor.cc:17: #define RECURSE(call) \
On 2015/08/20 21:35:47, bradn wrote:
PTAL
That it much niced not needing to plumb in the zone.
I've sent out separate CL to change typing.h similarly.
I also looked at one of the items in hydrogen.h too that uses this
pattern,
but
it appears to actually need it, as that object gets hand
*sigh*
I'll be ok with this patch, but keep in mind that the graphs built by raw
machine assembler are really broken and don't make sense at all without a
schedule.
https://codereview.chromium.org/1283193007/diff/20001/src/compiler/graph.h
File src/compiler/graph.h (right):
https://codereview.
On 2015/08/21 09:06:15, chunyang.dai wrote:
PTAL.
I think it would be better to edit the test so that it checks the number of
allocatable double registers. There are already a couple like that in the
file.
https://codereview.chromium.org/1308763003/
--
--
v8-dev mailing list
v8-dev@googleg
On 2015/08/21 09:40:22, rossberg wrote:
lgtm
lgtm as well
https://codereview.chromium.org/1303843003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsu
lgtm
https://codereview.chromium.org/1288723005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
On 2015/08/19 06:55:32, rmcilroy wrote:
Ben, please take a look, thanks.
What's the motivation for this? The graphs built by the raw assembler
already
have no hope of being verified because they don't have proper effect chains
nor
control chains.
https://codereview.chromium.org/1283193007
https://codereview.chromium.org/1288773007/diff/40001/src/ast-expression-visitor.cc
File src/ast-expression-visitor.cc (right):
https://codereview.chromium.org/1288773007/diff/40001/src/ast-expression-visitor.cc#newcode167
src/ast-expression-visitor.cc:167: ++depth_;
IIUC, you are using the dept
lgtm
https://codereview.chromium.org/1293073004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
On 2015/08/18 17:53:25, Michael Starzinger wrote:
Empty string-search.cc is being empty.
lgtm
all red is all good
https://codereview.chromium.org/1295333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
lgtm
https://codereview.chromium.org/1293053004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
oid InstructionSelector::VisitCall(Node* node,
BasicBlock* handler) {
for (Node* input : base::Reversed(buffer.pushed_nodes)) {
// Skip any alignment holes in pushed nodes.
if (input == nullptr) continue;
+ // TODO(titzer): GapResolver cannot handle stack->stack double
:
On 2015/08/17 at 10:58:42, titzer wrote:
> I think this is dead now?
No, it's not. It is used to initialize the Frame with the initial
number of
slots.
In that case recommend moving it to the usage sites.
https://codereview.chromium.org/1261923007/
--
--
v8-dev mailing lis
lgtm
https://codereview.chromium.org/1303463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1303463002/diff/60001/src/snapshot/natives-common.cc
File src/snapshot/natives-common.cc (right):
https://codereview.chromium.org/1303463002/diff/60001/src/snapshot/natives-common.cc#newcode15
src/snapshot/natives-common.cc:15: FixedArray*
Natives::GetSourceCache(
On 2015/08/17 18:18:35, bradn wrote:
Looks good from my side, adding mstarzinger@ who wields better GYP-fu.
https://codereview.chromium.org/1294543006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
lgtm
https://codereview.chromium.org/1289863003/diff/60001/src/compiler/interpreter-assembler.h
File src/compiler/interpreter-assembler.h (right):
https://codereview.chromium.org/1289863003/diff/60001/src/compiler/interpreter-assembler.h#newcode96
src/compiler/interpreter-assembler.h:96: Node
On 2015/08/17 14:01:56, Jarin wrote:
lgtm.
However, I am not a big fan of the 'if (Node* node = ...)' pattern,
especially
when there is a 'node' variable in the outer scope, so it can be easily
misread
as if (node == ...)'.
I fixed the shadowing of the variable in the outer scope.
https
Reviewers: Jarin,
Message:
PTAL: small tweaks to code generators and instruction selectors to handle
float32/float64 passed on the stack.
I plan to clean this up in the near future by refactoring CallDescriptor to
contain an array of pushed arguments.
Description:
[turbofan] Support unboxed flo
https://codereview.chromium.org/1261923007/diff/290027/src/compiler/frame.h
File src/compiler/frame.h (right):
https://codereview.chromium.org/1261923007/diff/290027/src/compiler/frame.h#newcode84
src/compiler/frame.h:84: static const int kFixedSlotCount =
I think this is dead now?
https://code
https://codereview.chromium.org/1289863003/diff/20001/src/compiler/interpreter-assembler.h
File src/compiler/interpreter-assembler.h (right):
https://codereview.chromium.org/1289863003/diff/20001/src/compiler/interpreter-assembler.h#newcode40
src/compiler/interpreter-assembler.h:40: Node* Incomi
-generator.cc:535: if (!info()->parse_info()) return; //
TODO(titzer): that was unfortunate.
nit: Can we use has_shared_info() here instead? We shouldn't need to care
about
the ParseInfo vs. CompilationInfo madness here.
Done.
Also is it really safe to just bailout here without bu
Mostly looking good. ARM64 is going to be fun with the JSP/CSP distinction.
https://codereview.chromium.org/1261923007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev"
On 2015/08/13 14:04:31, Michael Starzinger wrote:
The actual change is in src/compiler/node.h, the rest is fallout from
missing
IWYU in other files.
LGTM
https://codereview.chromium.org/1288053004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
Reviewers: Jarin,
Description:
[turbofan] Propagate representation information from call descriptors in
SimplifiedLowering.
R=ja...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1292033002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (
On 2015/08/12 17:48:41, Michael Starzinger wrote:
LGTM.
https://codereview.chromium.org/1291553005/diff/1/test/cctest/compiler/test-run-native-calls.cc
File test/cctest/compiler/test-run-native-calls.cc (right):
https://codereview.chromium.org/1291553005/diff/1/test/cctest/compiler/test-ru
On 2015/08/12 15:59:08, JF wrote:
On 2015/08/12 09:44:05, titzer wrote:
> On 2015/08/10 16:12:44, Mark Seaborn wrote:
> > It's not my codebase, but removing the possibility of using these
instructions
> > looks like a good idea to me!
>
> Can you update the CL descript
On 2015/08/12 10:43:33, commit-bot: I haz the power wrote:
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1285543002/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1285543002/1
lgtm
https://codereview.chromium.org/12855
On 2015/08/10 18:55:18, Michael Starzinger wrote:
PTAL all reviewers, I would like to get sign-of on the below steps (1)-(3)
from
all reviewers. The optional step (4) only needs to be done once. Thanks!
Review-Instructions:
1) Read CL description of what the goal is.
2) Look at "DEPS" for th
On 2015/08/07 12:56:14, Michael Starzinger wrote:
Dead code is being dead.
lgtm
https://codereview.chromium.org/1278113004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v
On 2015/08/07 13:00:08, Michael Starzinger wrote:
Dead code is being dead.
lgtm
https://codereview.chromium.org/1281903002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v
On 2015/08/07 07:59:03, Michael Starzinger wrote:
LGTM.
Is there a particular reason to have five different linkage.cc files with
one
method each? I would consider it more intuitive to have all of these
methods
in
the linkage.cc file instead.
https://codereview.chromium.org/1272883003/
On 2015/08/06 12:56:06, Michael Starzinger wrote:
LGTM.
I guess this is where CheckEqualsHelper used to live.
https://codereview.chromium.org/1276843004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subsc
On 2015/08/03 10:38:18, Jarin wrote:
Looking good so far.
https://codereview.chromium.org/1263033004/diff/1/src/compiler/x64/code-generator-x64.cc
File src/compiler/x64/code-generator-x64.cc (right):
https://codereview.chromium.org/1263033004/diff/1/src/compiler/x64/code-generator-x64.cc#n
Bye bye love
Bye bye happiness
Hello loneliness
I think I'm-a gonna cry-y
Actually, no, I won't.
https://codereview.chromium.org/1267313002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the G
On 2015/08/04 12:38:30, Jarin wrote:
lgtm
https://codereview.chromium.org/1269183002/diff/1/src/compiler/instruction-selector.cc
File src/compiler/instruction-selector.cc (right):
https://codereview.chromium.org/1269183002/diff/1/src/compiler/instruction-selector.cc#newcode1004
src/compil
On 2015/08/03 13:54:42, Yang wrote:
On 2015/08/03 13:03:06, commit-bot: I haz the power wrote:
> Patchset 11 (id:??) landed as
> https://crrev.com/7b9670b63b486ba3b6f8a569552d307282dbccfd
> Cr-Commit-Position: refs/heads/master@{#29974}
Well by simply marking NOPRESUBMIT=true, other test bots i
On 2015/08/03 13:33:48, mtbrandyberry wrote:
On 2015/08/03 13:28:59, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
> v8_presubmit on tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/4636)
Hmmm.. Presubmit failur
lgtm
https://codereview.chromium.org/1271583002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
r/x64/code-generator-x64.cc
b/src/compiler/x64/code-generator-x64.cc
index
38c7f2a31c90724b3fd39767c07b3801fde1cbc6..a0e4299238496d109b826a1e79e73e425eb19e1f
100644
--- a/src/compiler/x64/code-generator-x64.cc
+++ b/src/compiler/x64/code-generator-x64.cc
@@ -1219,6 +1219,10 @@ void
CodeGenerator
lgtm
https://codereview.chromium.org/1269683002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: danno,
Message:
PTAL.
Turns out that CallDescriptor::JSParameterCount() isn't so interesting after
all.
Description:
[turbofan] Simplifying handling of callee-cleanup stack area.
R=da...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1269913002/
Base URL:
Reviewers: Benedikt Meurer,
Description:
[turbofan] Float32 LinkageLocations need double registers too.
R=bmeu...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1268433003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -1 lines):
M
https://codereview.chromium.org/1269683002/diff/60001/test/cctest/interpreter/test-interpreter.cc
File test/cctest/interpreter/test-interpreter.cc (right):
https://codereview.chromium.org/1269683002/diff/60001/test/cctest/interpreter/test-interpreter.cc#newcode31
test/cctest/interpreter/test-int
lgtm
https://codereview.chromium.org/1269813006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1265723003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Benedikt Meurer,
Description:
[turbofan] GraphBuilderTester uses --print-opt-code.
R=bmeu...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1256723003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+4, -0 lines):
M test/ccte
Reviewers: Benedikt Meurer,
Message:
Committed patchset #1 (id:1) manually as
ca38b15be78014f20641a59700d813f6c506a330 (tree was closed).
Description:
Fix BUILD.gn.
TBR=bmeu...@chromium.org
BUG=
Committed:
https://chromium.googlesource.com/v8/v8/+/ca38b15be78014f20641a59700d813f6c506a330
Plea
On 2015/07/30 07:12:40, titzer wrote:
On 2015/07/30 06:35:14, Benedikt Meurer wrote:
> This approach will not work because you add new static initializers
until
> uniform initialization and constexpr is allowed.
Yeah, I need to make the kParamRegisters array into a function.
On 2015/07/30 06:35:14, Benedikt Meurer wrote:
This approach will not work because you add new static initializers until
uniform initialization and constexpr is allowed.
Yeah, I need to make the kParamRegisters array into a function.
I was considering adding a kReturnRegister0 and kReturnRegis
Reviewers: Benedikt Meurer, danno,
Description:
Factor C call descriptor building into compiler/c-linkage.cc with inline
platform-specifics.
This is the first step in cutting the Gordian linkage/linkage-impl knot.
This basically changes the axis along which we organize call descriptor
building
lgtm
https://codereview.chromium.org/1245523002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1248743003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1245523002/diff/11/test/unittests/compiler/linkage-tail-call-unittest.cc
File test/unittests/compiler/linkage-tail-call-unittest.cc (right):
https://codereview.chromium.org/1245523002/diff/11/test/unittests/compiler/linkage-tail-call-unittest.cc#newcode53
https://codereview.chromium.org/1215333005/diff/1/src/compiler/osr.cc
File src/compiler/osr.cc (left):
https://codereview.chromium.org/1215333005/diff/1/src/compiler/osr.cc#oldcode253
src/compiler/osr.cc:253: Node* osr_loop) {
I don't think it's necessary to delete this code. We need to discuss
lgtm
https://codereview.chromium.org/1213043005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1221103003/diff/20001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/1221103003/diff/20001/src/compiler/ast-graph-builder.cc#newcode4081
src/compiler/ast-graph-builder.cc:4081: // TODO(titzer
https://codereview.chromium.org/1220823004/diff/20001/src/compiler/ast-graph-builder.h
File src/compiler/ast-graph-builder.h (right):
https://codereview.chromium.org/1220823004/diff/20001/src/compiler/ast-graph-builder.h#newcode55
src/compiler/ast-graph-builder.h:55: Node* relaxed_context() cons
On 2015/07/01 09:11:49, danno wrote:
I should add tests, but it's unclear if they will be anything other than a
trivial copy of the logic that is in the reducer itself.
You should add tests to verify that the reducer actually makes a change to
the
graph. Otherwise, we might end up breaking i
https://codereview.chromium.org/1201783003/diff/40001/src/ast-value-factory.h
File src/ast-value-factory.h (right):
https://codereview.chromium.org/1201783003/diff/40001/src/ast-value-factory.h#newcode148
src/ast-value-factory.h:148: bool ContainsDot() const { return type_ ==
NUMBER_WITH_DOT; }
lgtm
https://codereview.chromium.org/1201783003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1205173002/diff/60001/src/compiler/register-allocator.h
File src/compiler/register-allocator.h (right):
https://codereview.chromium.org/1205173002/diff/60001/src/compiler/register-allocator.h#newcode481
src/compiler/register-allocator.h:481: int size_;
Can you add
1 - 100 of 1480 matches
Mail list logo
