- Original Message -
> Is someone having a look at that unit test error?
Dan?
> > Name: configNetworkTests Failed: 1 test(s), Passed: 3 test(s),
>
> fyi, i've added a vdsm unit test gerrit job that will be triggered on
> each vdsm patch.
> for now it's on silent mode, so it won't -1 pa
Dan Kenigsberg has submitted this change and it was merged.
Change subject: skip gluster test if gluster module is not find
..
skip gluster test if gluster module is not find
if vdsm-gluster rpm is not installed, will skip the
Dan Kenigsberg has posted comments on this change.
Change subject: skip gluster test if gluster module is not find
..
Patch Set 10: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5915
To unsubscribe, visit
Is someone having a look at that unit test error?
fyi, i've added a vdsm unit test gerrit job that will be triggered on each vdsm
patch.
for now it's on silent mode, so it won't -1 patches on failure, once we'll see
jenkins can handle the load of commits,
we'll enable verify.
- Original Mes
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#838276: move isOVirt() to ovirt module
..
Patch Set 3: I would prefer that you didn't submit this
This won't fly as long as we need to bootstrap older versio
Dan Kenigsberg has posted comments on this change.
Change subject: make vdsm/storage/task.py PEP 8 clean
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Thanks for this big change. I think that on
ShaoHe Feng has posted comments on this change.
Change subject: make vdsm/storage/task.py PEP 8 clean
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6355
To unsubscribe
Zhou Zheng Sheng has posted comments on this change.
Change subject: make vdsm/storage/task.py PEP 8 clean
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
(2 inline comments)
Verify:
Run through ./aut
Bing Bu Cao has posted comments on this change.
Change subject: make vdsm/storage/task.py PEP 8 clean
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6355
To unsubscribe
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#838276: move isOVirt() to ovirt module
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/6357
To unsubscribe, visit http://gerri
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ838276: move isOVirt() to ovirt module
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/6357
To unsubscribe, visit http://gerrit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#838276 vds_bootstrap_complete remove deployUtil
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6358
To unsubscribe, visit htt
Douglas Schilling Landgraf has posted comments on this change.
Change subject: 838276: move isOVirt() to ovirt module
..
Patch Set 1: (1 inline comment)
Commit Message
Line 7
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: BZ#838276 vds_bootstrap_complete remove deployUtil
..
BZ#838276 vds_bootstrap_complete remove deployUtil
Executing a host installation by REST API
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: 838276: move isOVirt() to ovirt module
..
838276: move isOVirt() to ovirt module
Instead of have isOvirt() inside deployUtil module, let's make
it
Hello ShaoHe Feng,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/6355
to review the following change.
Change subject: make vdsm/storage/task.py PEP 8 clean
..
make vdsm/storage/task.py PEP 8 clean
Zhou Zheng Sheng has posted comments on this change.
Change subject: skip gluster test if gluster module is not find
..
Patch Set 10: Verified
Run through ./autobuild.sh. Install the generated rpm. Then run tests in the
instal
Zhou Zheng Sheng has posted comments on this change.
Change subject: Fix pep8 issue in configNetworkTests.py
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
A pep8 issue introduced in commit 7341f39529
Mark Wu has uploaded a new change for review.
Change subject: Bz#839919 remoteFileHandler.py: Add storage into python path
..
Bz#839919 remoteFileHandler.py: Add storage into python path
pickle need import modules in vdsm/storag
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#838591:vdsm is not looking for libvirt-daem
..
BZ#838591:vdsm is not looking for libvirt-daem
https://bugzilla.redhat.com/838591
vdsm is not lookin
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#838591:vdsm is not looking for libvirt-daem
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6076
To unsubscrib
Saggi Mizrahi has posted comments on this change.
Change subject: Fix 2nd order exception msg in lvm._initpvs().
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5319
To
Saggi Mizrahi has posted comments on this change.
Change subject: Use SANLock lease offset when present
..
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
Dan Kenigsberg has submitted this change and it was merged.
Change subject: build: use consistent python path
..
build: use consistent python path
Current behavior:
1. aclocal.m4::AM_PATH_PYTHON detects python using PYTHON var
Dan Kenigsberg has posted comments on this change.
Change subject: build: use consistent python path
..
Patch Set 3: Verified; Looks good to me, approved
simple rebase, copying score.
--
To view, visit http://gerrit.ovirt.org/
Dan Kenigsberg has posted comments on this change.
Change subject: build: use consistent python path
..
Patch Set 2: Looks good to me, approved
I hear no nacks. Taken. Thanks!
--
To view, visit http://gerrit.ovirt.org/6049
To
Dan Kenigsberg has posted comments on this change.
Change subject: adding handling EINTR to poll to make it more robust
..
Patch Set 6: I would prefer that you didn't submit this
(2 inline comments)
few comments within.
still
Saggi Mizrahi has posted comments on this change.
Change subject: vdsm_api: Add schema and html doc generator
..
Patch Set 1: I would prefer that you didn't submit this
(11 inline comments)
I'm giving -1 because of the ordered
Adam Litke has uploaded a new change for review.
Change subject: vdsm_api: Add schema and html doc generator
..
vdsm_api: Add schema and html doc generator
This patch adds a schema file to a new directory 'vdsm_api'. The schema
Saggi Mizrahi has posted comments on this change.
Change subject: Don't ignore nfs_mount_options in vdsm.conf
..
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
Please add the comment if you do
Dan Kenigsberg has posted comments on this change.
Change subject: Skip broken tests feature
..
Patch Set 7: I would prefer that you didn't submit this
it would be nicer for whomever uses this decorated to specify what is broke
Saggi Mizrahi has abandoned this change.
Change subject: [WIP] New repository system
..
Patch Set 18: Abandoned
Superseded by http://gerrit.ovirt.org/#/c/6247/
--
To view, visit http://gerrit.ovirt.org/192
To unsubscribe, visi
Saggi Mizrahi has posted comments on this change.
Change subject: SUDO change, move fuser call to super vdsm
..
Patch Set 1: I would prefer that you didn't submit this
What Dan said
--
To view, visit http://gerrit.ovirt.org/53
Saggi Mizrahi has posted comments on this change.
Change subject: change startup process for vdsm and supervdsm
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4145
To u
Saggi Mizrahi has posted comments on this change.
Change subject: Remove unused qemuImg.py.
..
Patch Set 1: Do not submit
I'm using it
--
To view, visit http://gerrit.ovirt.org/5582
To unsubscribe, visit http://gerrit.ovirt.or
Saggi Mizrahi has posted comments on this change.
Change subject: make compression type configurable, support gzip and xz
..
Patch Set 4: I would prefer that you didn't submit this
Is it really a build time decision?
--
To vie
Saggi Mizrahi has posted comments on this change.
Change subject: BZ#809497: connectStroragServer will fail if iscsi session
already exists
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http
Saggi Mizrahi has posted comments on this change.
Change subject: skip gluster test if gluster module is not find
..
Patch Set 10: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5915
T
Dan Kenigsberg has posted comments on this change.
Change subject: Basic tests for the tc module
..
Patch Set 3: (2 inline comments)
File tests/tcTests.py
Line 83: def _liste
Roman Fenkhuber has posted comments on this change.
Change subject: Basic tests for the tc module
..
Patch Set 3: (1 inline comment)
File tests/tcTests.py
Line 173: s
Federico Simoncelli has posted comments on this change.
Change subject: Orthogonal storage repository conversion
..
Patch Set 33: (4 inline comments)
Commit Message
Line 10:
Federico Simoncelli has posted comments on this change.
Change subject: Unify the volume creation code in volume.create
..
Patch Set 22: (3 inline comments)
File vdsm/storage
Federico Simoncelli has posted comments on this change.
Change subject: Uniform the block and file volume methods
..
Patch Set 21: (1 inline comment)
File vdsm/storage/blockV
Dan Kenigsberg has posted comments on this change.
Change subject: Basic tests for the tc module
..
Patch Set 3: (1 inline comment)
File tests/tcTests.py
Line 173: se
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#840386: vms with shared disk will pause...
..
Patch Set 4: (1 inline comment)
File vdsm/vm.py
Line 519:
Federico Simoncelli has posted comments on this change.
Change subject: Remove the unused nocache option
..
Patch Set 17: (2 inline comments)
File vdsm/storage/blockVolume.py
Barak Azulay has posted comments on this change.
Change subject: Add a channel in vdsm for introducing qemu-ga
..
Patch Set 9: I would prefer that you didn't submit this
(1 inline comment)
.
Roman Fenkhuber has posted comments on this change.
Change subject: Basic tests for the tc module
..
Patch Set 3: (3 inline comments)
File tests/tcTests.py
Line 83: def _list
Federico Simoncelli has posted comments on this change.
Change subject: Separate the Volume.share implementation
..
Patch Set 20: (1 inline comment)
File vdsm/storage/fileVol
Eli Mesika has posted comments on this change.
Change subject: BZ#840386: vms with shared disk will pause...
..
Patch Set 4: (1 inline comment)
File vdsm/vm.py
Line 519:
Dan Kenigsberg has posted comments on this change.
Change subject: Basic tests for the tc module
..
Patch Set 3: I would prefer that you didn't submit this
(3 inline comments)
..
Dan Kenigsberg has posted comments on this change.
Change subject: Basic tests for the tc module
..
Patch Set 2: (3 inline comments)
File tests/tcTests.py
Line 2: # Copyright
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#840386: vms with shared disk will pause...
..
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
...
Eli Mesika has posted comments on this change.
Change subject: BZ#834893: vms with shared disk will pause...
..
Patch Set 3: (3 inline comments)
Commit Message
Line 7: BZ#834
Mark Wu has posted comments on this change.
Change subject: BZ#834893: vms with shared disk will pause...
..
Patch Set 3: No score
(1 inline comment)
File vdsm/libvirtvm.py
Igor Lvovsky has posted comments on this change.
Change subject: BZ#834893: vms with shared disk will pause...
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
.
Ayal Baron has posted comments on this change.
Change subject: BZ#834893: vms with shared disk will pause...
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
...
Mark Wu has posted comments on this change.
Change subject: BZ#834893: vms with shared disk will pause...
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6283
To unsubsc
Mark Wu has posted comments on this change.
Change subject: BZ#834893: vms with shared disk will pause...
..
Patch Set 2: (1 inline comment)
Commit Message
Line 10: getting a
59 matches
Mail list logo
