Change in vdsm[master]: vdsm startup: fix assert statement

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm startup: fix assert statement .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/239/ (1/2) -- To view, vi

Change in vdsm[master]: vdsm startup: fix assert statement

2012-12-05 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: vdsm startup: fix assert statement .. vdsm startup: fix assert statement SyntaxWarning: assertion is always true, perhaps remove parentheses? Change-Id: I0b8c

Change in vdsm[master]: Added gluster volume top functionalities

2012-12-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Added gluster volume top functionalities .. Patch Set 9: I would prefer that you didn't submit this (2 inline comments) ...

Change in vdsm[master]: vm: increase the volume extension on storage migration

2012-12-05 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: increase the volume extension on storage migration .. vm: increase the volume extension on storage migration During live migration VDSM needs to su

Change in vdsm[master]: sdcache: add refresh to connectStoragePool

2012-12-05 Thread paikov
Daniel Paikov has posted comments on this change. Change subject: sdcache: add refresh to connectStoragePool .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/9422 To unsubscribe, visit http://gerrit.ovirt.org/

Change in vdsm[master]: vm: increase the volume extension on storage migration

2012-12-05 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: vm: increase the volume extension on storage migration .. Patch Set 4: Verified Verified in 3 scenarios: 1) one VM running on 1 host (regular extension), 2

Change in vdsm[master]: Specify the ACPI flag when shutting down VMs

2012-12-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Specify the ACPI flag when shutting down VMs .. Patch Set 1: (1 inline comment) File vdsm/libvirtvm.py Line

Change in vdsm[master]: Added gluster volume top functionalities

2012-12-05 Thread barumuga
Bala.FA has posted comments on this change. Change subject: Added gluster volume top functionalities .. Patch Set 9: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7844 To unsubscribe,

Change in vdsm[master]: vm: increase the volume extension on storage migration

2012-12-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: increase the volume extension on storage migration .. Patch Set 4: Looks good to me, approved thanks for the quick fix. -- To view, visit http://gerrit.ovi

Change in vdsm[master]: vm: increase the volume extension on storage migration

2012-12-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: increase the volume extension on storage migration .. Patch Set 3: I would prefer that you didn't submit this (3 inline comments) minor comments.

Change in vdsm[master]: Added gluster volume top functionalities

2012-12-05 Thread tjeyasin
Timothy Asir has posted comments on this change. Change subject: Added gluster volume top functionalities .. Patch Set 9: Verified -- To view, visit http://gerrit.ovirt.org/7844 To unsubscribe, visit http://gerrit.ovirt.org/set

Change in vdsm[master]: upgrade: reallocate the metadata slots when needed

2012-12-05 Thread abaron
Ayal Baron has posted comments on this change. Change subject: upgrade: reallocate the metadata slots when needed .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9660 To unsubscribe, visit h

Change in vdsm[master]: Added gluster volume top functionalities

2012-12-05 Thread tjeyasin
Timothy Asir has posted comments on this change. Change subject: Added gluster volume top functionalities .. Patch Set 6: Verified -- To view, visit http://gerrit.ovirt.org/7844 To unsubscribe, visit http://gerrit.ovirt.org/set

Change in vdsm[master]: Add default MTU=1500 to NIC's ifcfg files.

2012-12-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Add default MTU=1500 to NIC's ifcfg files. .. Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) .

Change in vdsm[master]: Allow to remove NIC if it not in use

2012-12-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Allow to remove NIC if it not in use .. Patch Set 3: I would prefer that you didn't submit this (2 inline comments) ...

Change in vdsm[master]: Do not fail when getVSize is called on an inctive LV.

2012-12-05 Thread ewarszaw
Eduardo has posted comments on this change. Change subject: Do not fail when getVSize is called on an inctive LV. .. Patch Set 1: Verified #vdsClient 0 getVolumeSize 91202d50-21de-46fa-a4c4-987c062036c5 ---

Change in vdsm[master]: Add default MTU=1500 to NIC's ifcfg files.

2012-12-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Add default MTU=1500 to NIC's ifcfg files. .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) ..

Change in vdsm[master]: Do not fail when getVSize is called on an inctive LV.

2012-12-05 Thread ewarszaw
Eduardo has uploaded a new change for review. Change subject: Do not fail when getVSize is called on an inctive LV. .. Do not fail when getVSize is called on an inctive LV. Change-Id: I0a8b6da4d57cdf810769586c1959989d7a545d0c Bu

Change in vdsm[master]: add emulator pin support to create vm

2012-12-05 Thread lvroyce
Royce Lv has posted comments on this change. Change subject: add emulator pin support to create vm .. Patch Set 7: Laszlo, if your 'host-mode'patch is ready, I'm glad to rebase on yours and verify with you. -- To view, visit

Change in vdsm[master]: PEP8 cleanup for *.py under vdsm_hooks

2012-12-05 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: PEP8 cleanup for *.py under vdsm_hooks .. Patch Set 1: Verified (1 inline comment) Pass autobuild.sh. pydiff find some changes. First change: pydiff vdsm

Change in vdsm[master]: [WIP] netwiring: [4/4] Add API definitions.

2012-12-05 Thread wudxw
Mark Wu has posted comments on this change. Change subject: [WIP] netwiring: [4/4] Add API definitions. .. Patch Set 14: (1 inline comment) File vdsm/libvirtvm.py Line 1563:

Change in vdsm[master]: Online check ksmState and ksmPages.

2012-12-05 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: Online check ksmState and ksmPages. .. Patch Set 1: Looks good to me, but someone else must approve looks good, I will trz to verifz -- To view, visit http://g

Change in vdsm[master]: PEP8 cleanup for *.py under vdsm_hooks

2012-12-05 Thread wudxw
Mark Wu has posted comments on this change. Change subject: PEP8 cleanup for *.py under vdsm_hooks .. Patch Set 1: I updated pep8 on my host and didn't ignore any PEP8 error when I fix it. So I doesn't need a rebase. -- To vi

Change in vdsm[master]: pep8: comply with E122 and E123

2012-12-05 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: pep8: comply with E122 and E123 .. Patch Set 1: Mistake of mistake. The last comment if for the other patch. -- To view, visit http://gerrit.ovirt.org/9730 T

Change in vdsm[master]: pep8: comply with E122 and E123

2012-12-05 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: pep8: comply with E122 and E123 .. Patch Set 1: No score My mistake. There are no pep8 problems. I apologize. -- To view, visit http://gerrit.ovirt.org/9730

Change in vdsm[master]: PEP8 cleanup for *.py under vdsm_hooks

2012-12-05 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: PEP8 cleanup for *.py under vdsm_hooks .. Patch Set 1: No score -- To view, visit http://gerrit.ovirt.org/9734 To unsubscribe, visit http://gerrit.ovirt.org/s

Change in vdsm[master]: PEP8 cleanup for *.py under vdsm_hooks

2012-12-05 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: PEP8 cleanup for *.py under vdsm_hooks .. Patch Set 1: I would prefer that you didn't submit this Dan tries to remove the pep8 ignore option for E121, E122, E

Change in vdsm[master]: Return the result directly instead of generator when getting...

2012-12-05 Thread wudxw
Mark Wu has uploaded a new change for review. Change subject: Return the result directly instead of generator when getting network for interface .. Return the result directly instead of generator when getting network for interfa

<    1   2