Mark Wu has posted comments on this change.
Change subject: Move getMaxMtu to netinfo
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
Just one minor issue inline.
Giuseppe Vallarelli has posted comments on this change.
Change subject: Extract helper functions to update nic and bonding's mtu
..
Patch Set 1: (1 inline comment)
File
Dan Kenigsberg has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 3: I would prefer that you didn't submit this
(3 inline comments)
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Fix py_modules in setup.py
..
Fix py_modules in setup.py
After modifying cpopen.py to __init__.py we should also update setup.py
parameters. This bug may lead
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix py_modules in setup.py
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2429/ (2/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix py_modules in setup.py
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2362/ (3/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix py_modules in setup.py
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2362/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: [REFACTORING] libvirtvm.py bye bye
..
Patch Set 5:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2430/ (2/3)
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: [REFACTORING] libvirtvm.py bye bye
..
Patch Set 5:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2363/ (1/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: [REFACTORING] libvirtvm.py bye bye
..
Patch Set 5:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1528/ (3/3)
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: [REFACTORING] libvirtvm.py bye bye
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2363/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: [REFACTORING] libvirtvm.py bye bye
..
Patch Set 6:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1529/ (1/3)
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: [REFACTORING] libvirtvm.py bye bye
..
Patch Set 6:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2431/ (2/3)
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: [REFACTORING] libvirtvm.py bye bye
..
Patch Set 6:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2364/ (3/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: [REFACTORING] libvirtvm.py bye bye
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2364/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Extend vdsm-tool commands - retrieving host uuid by
utils.getHostUUID
..
Patch Set 5:
Build Started
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Extend vdsm-tool commands - retrieving host uuid by
utils.getHostUUID
..
Patch Set 5:
Build Started
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Extend vdsm-tool commands - retrieving host uuid by
utils.getHostUUID
..
Patch Set 5:
Build Started
Yaniv Bronhaim has posted comments on this change.
Change subject: Extend vdsm-tool commands - retrieving host uuid by
utils.getHostUUID
..
Patch Set 5: (1 inline comment)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Extend vdsm-tool commands - retrieving host uuid by
utils.getHostUUID
..
Patch Set 5:
Build Successful
Alon Bar-Lev has posted comments on this change.
Change subject: Extend vdsm-tool commands - retrieving host uuid by
utils.getHostUUID
..
Patch Set 5: (2 inline comments)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: XMLRPCServer: make XMLRPCServer able to listen on IPv6 addresses
..
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2366/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: XMLRPCServer: make XMLRPCServer able to listen on IPv6 addresses
..
Patch Set 4:
Build Started
oVirt Jenkins CI Server has posted comments on this change.
Change subject: XMLRPCServer: make XMLRPCServer able to listen on IPv6 addresses
..
Patch Set 4:
Build Started
oVirt Jenkins CI Server has posted comments on this change.
Change subject: XMLRPCServer: make XMLRPCServer able to listen on IPv6 addresses
..
Patch Set 4: Fails
Build Failed
Petr Sebek has abandoned this change.
Change subject: XMLRPCServer able to listen on IPv6 addresses
..
Patch Set 1: Abandoned
Working on original change 11520.
--
To view, visit http://gerrit.ovirt.org/14779
To unsubscribe,
Michal Skrivanek has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 3: I would prefer that you didn't submit this
I think we should rather address the issue in
Michal Skrivanek has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 3: No score
maybe not:-)
--
To view, visit http://gerrit.ovirt.org/14869
To unsubscribe, visit
Deepak C Shetty has posted comments on this change.
Change subject: WIP: Introduce prepareForBackup vdsm verb
..
Patch Set 3:
@MarkWu,
Re: 1) We use qemu-nbd so that in future when the backup appliance is hosted on
a
Peter V. Saveliev has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 3:
Michal, you're not right — there each dict, passed as a parameter, is treated
as separated object. It is not
Yaniv Bronhaim has posted comments on this change.
Change subject: Supervdsm as external service
..
Patch Set 9: (3 inline comments)
File configure.ac
Line 189:
Deepak C Shetty has uploaded a new change for review.
Change subject: WIP: storage: Introduce teardownBackupDisk vdsm verb
..
WIP: storage: Introduce teardownBackupDisk vdsm verb
This patch introduces teardownBackupDisk vdsm
oVirt Jenkins CI Server has posted comments on this change.
Change subject: WIP: storage: Introduce teardownBackupDisk vdsm verb
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1532/ (1/3)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: WIP: storage: Introduce teardownBackupDisk vdsm verb
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2434/ (2/3)
--
oVirt Jenkins CI Server has posted comments on this change.
Change subject: WIP: storage: Introduce prepareBackupDisk vdsm verb
..
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1533/ (2/3)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: WIP: storage: Introduce teardownBackupDisk vdsm verb
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2367/ (3/3)
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: WIP: storage: Introduce prepareBackupDisk vdsm verb
..
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2435/ (1/3)
--
oVirt Jenkins CI Server has posted comments on this change.
Change subject: WIP: storage: Introduce prepareBackupDisk vdsm verb
..
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2368/ (3/3)
--
To
Deepak C Shetty has posted comments on this change.
Change subject: WIP: storage: Introduce prepareBackupDisk vdsm verb
..
Patch Set 4: Verified
Was able to create a qemu-nbd process, serving the given volUUID over a unix
Deepak C Shetty has posted comments on this change.
Change subject: WIP: storage: Introduce teardownBackupDisk vdsm verb
..
Patch Set 1: Verified
Was able to gracefully terminate the qemu-nbd process that was originally
oVirt Jenkins CI Server has posted comments on this change.
Change subject: WIP: storage: Introduce teardownBackupDisk vdsm verb
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2367/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: WIP: storage: Introduce prepareBackupDisk vdsm verb
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2368/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2369/ (1/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1534/ (2/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2436/ (3/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2369/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: WIP Adding functional tests for networking
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2370/ (1/3)
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: WIP Adding functional tests for networking
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1535/ (2/3)
--
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: WIP Adding functional tests for networking
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2437/ (3/3)
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: WIP Adding functional tests for networking
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2370/ : SUCCESS
Timothy Asir has posted comments on this change.
Change subject: schema: Fix the Hooks schema definition
..
Patch Set 9: (1 inline comment)
File vdsm_api/vdsmapi-schema.json
Yeela Kaplan has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 4: Verified
windows vm was started and shutdown successfully. Could see that volume was
deactivated.
--
To view,
Timothy Asir has posted comments on this change.
Change subject: Fix py_modules in setup.py
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14915
To
Federico Simoncelli has posted comments on this change.
Change subject: oop: rename createSparseFile to truncateFile
..
Patch Set 1: Verified
I've been using this since few weeks and looks ok.
--
To view, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: Move getMaxMtu to netinfo
..
Patch Set 2: (1 inline comment)
File lib/vdsm/netinfo.py
Line 130:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move getMaxMtu to netinfo
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1536/ (1/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move getMaxMtu to netinfo
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2371/ (2/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move getMaxMtu to netinfo
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2438/ (3/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move getMaxMtu to netinfo
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2371/ : SUCCESS
Giuseppe Vallarelli has posted comments on this change.
Change subject: Move getMaxMtu to netinfo
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/14856
To unsubscribe, visit http://gerrit.ovirt.org/settings
Yaniv Bronhaim has posted comments on this change.
Change subject: Extend vdsm-tool commands - retrieving host uuid by
utils.getHostUUID
..
Patch Set 5: (1 inline comment)
Ayal Baron has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14869
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Extend vdsm-tool commands - retrieving host uuid by
utils.getHostUUID
..
Patch Set 6:
Build Started
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Extend vdsm-tool commands - retrieving host uuid by
utils.getHostUUID
..
Patch Set 6:
Build Started
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Extend vdsm-tool commands - retrieving host uuid by
utils.getHostUUID
..
Patch Set 6:
Build Started
Alon Bar-Lev has posted comments on this change.
Change subject: Extend vdsm-tool commands - retrieving host uuid by
utils.getHostUUID
..
Patch Set 5: (1 inline comment)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Extend vdsm-tool commands - retrieving host uuid by
utils.getHostUUID
..
Patch Set 6:
Build Successful
Antoni Segura Puimedon has posted comments on this change.
Change subject: Separate adding libvirt network from configuring host network.
..
Patch Set 1: Looks good to me, but someone else must approve
I like a lot this
Antoni Segura Puimedon has posted comments on this change.
Change subject: Reduce the parameters for addVlan()
..
Patch Set 1: Looks good to me, but someone else must approve
Another good simplification. Thanks!
--
To view,
Antoni Segura Puimedon has posted comments on this change.
Change subject: Extract helper functions to update nic and bonding's mtu
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
Giuseppe Vallarelli has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 1: (1 inline comment)
File vdsm/netconf/ifcfg.py
Giuseppe Vallarelli has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 1: (1 inline comment)
File vdsm/netconf/ifcfg.py
Giuseppe Vallarelli has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 1: (1 inline comment)
File vdsm/netconf/ifcfg.py
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 5:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2373/ (2/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 5:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2440/ (1/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 5:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1538/ (3/3)
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 5: Verified; Looks good to me, approved
Copying score; only changed commit message.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Deactivate libvirtVM.Drives()
..
Deactivate libvirtVM.Drives()
Change I8d310f216987b7 has introduced teardownVolumePath() calls with a
Drive object
oVirt Jenkins CI Server has posted comments on this change.
Change subject: WIP: storage: Introduce teardownBackupDisk vdsm verb
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1539/ (1/3)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: WIP: storage: Introduce teardownBackupDisk vdsm verb
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2441/ (2/3)
--
oVirt Jenkins CI Server has posted comments on this change.
Change subject: WIP: storage: Introduce teardownBackupDisk vdsm verb
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2374/ (3/3)
--
To
Deepak C Shetty has posted comments on this change.
Change subject: WIP: storage: Introduce teardownBackupDisk vdsm verb
..
Patch Set 2: Verified
Was able to gracefully terminate the qemu-nbd process that was originally
Antoni Segura Puimedon has posted comments on this change.
Change subject: Add a backward reference their master device for Vlan, Bond and
Nic
..
Patch Set 1: (2 inline comments)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: WIP: storage: Introduce teardownBackupDisk vdsm verb
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2374/ : SUCCESS
Hello Eduardo,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/14953
to review the following change.
Change subject: Deactivate libvirtVM.Drives()
..
Deactivate libvirtVM.Drives()
Change
Federico Simoncelli has uploaded a new change for review.
Change subject: version: upstream dirty is nightly
..
version: upstream dirty is nightly
Previously the upstream dirty builds were released using a pre-release
oVirt Jenkins CI Server has posted comments on this change.
Change subject: version: upstream dirty is nightly
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2375/ (1/3)
--
To view, visit
Federico Simoncelli has uploaded a new change for review.
Change subject: [wip] import/export methods
..
[wip] import/export methods
Change-Id: Ib208bb20d88633167b5c66b42febe912439a022d
Signed-off-by: Federico Simoncelli
oVirt Jenkins CI Server has posted comments on this change.
Change subject: version: upstream dirty is nightly
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2442/ (2/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: version: upstream dirty is nightly
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1540/ (3/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [wip] import/export methods
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1541/ (1/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: WIP Adding functional tests for networking
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1542/ (1/3)
--
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [wip] import/export methods
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2376/ (2/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: WIP Adding functional tests for networking
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2377/ (2/3)
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [wip] import/export methods
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2443/ (3/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: WIP Adding functional tests for networking
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2444/ (3/3)
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: version: upstream dirty is nightly
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2375/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [wip] import/export methods
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2376/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: WIP Adding functional tests for networking
..
Patch Set 3: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2377/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: WIP Adding functional tests for networking
..
Patch Set 3: No score
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2445/
1 - 100 of 126 matches
Mail list logo
