Francesco Romani has posted comments on this change.
Change subject: storage: Use new concurrent.thread() utility
..
Patch Set 1: Code-Review+1
I'm not storage expert, but from a python perspective looks good to me.
--
To vie
Francesco Romani has posted comments on this change.
Change subject: lib: Use new concurrent.thread() utility
..
Patch Set 4: Code-Review+1
executor, libvirtconnection, profiling/memory and schedule: looks good to me.
--
To v
Francesco Romani has posted comments on this change.
Change subject: vm: Libvirt quering after disk detach operation addition.
..
Patch Set 11:
(1 comment)
reluctant ack (once Nir's comments are addressed), as I still don't li
Francesco Romani has posted comments on this change.
Change subject: vm.py: State saving in hotunplugDisk.
..
Patch Set 8: -Code-Review
(2 comments)
https://gerrit.ovirt.org/#/c/45077/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:
L
Shahar Havivi has posted comments on this change.
Change subject: virt: Use new concurrent.thread() utility
..
Patch Set 1:
The QE have a vCenter that you can check v2v,
all you need to make sure that you have the latest virt-v
Shahar Havivi has posted comments on this change.
Change subject: Update v2v to use new jobs infrastructure
..
Patch Set 2:
> Code looks good,
> Please specify what did you verify
The QE have a vCenter that you can check v2v,
Francesco Romani has posted comments on this change.
Change subject: virt: Use new concurrent.thread() utility
..
Patch Set 1:
Nir, the vm.py change looks good and it is easier to verify (and you already
did :) ). If you can/w
Shahar Havivi has posted comments on this change.
Change subject: virt: Use new concurrent.thread() utility
..
Patch Set 1: Code-Review-1
> I verified the vm creation thread, but I cannot verify the v2v
> change.
This is a pr
Shahar Havivi has posted comments on this change.
Change subject: Update v2v to use new jobs infrastructure
..
Patch Set 2: Code-Review-1
Code looks good,
Please specify what did you verify
--
To view, visit https://gerrit.ov
Nir Soffer has posted comments on this change.
Change subject: vm: Libvirt quering after disk detach operation addition.
..
Patch Set 11: Code-Review-1
The CI failure is caused by the previous patch, which for some reason was n
Nir Soffer has posted comments on this change.
Change subject: vm.py: State saving in hotunplugDisk.
..
Patch Set 8: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/45077/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 26
Nir Soffer has posted comments on this change.
Change subject: tests: Add basic tests for RWLock
..
Patch Set 4: Code-Review-1
Can be abandoned now.
--
To view, visit https://gerrit.ovirt.org/42772
To unsubscribe, visit https
Dan Kenigsberg has posted comments on this change.
Change subject: supervdsm: move udevadm methods to udevadm module
..
Patch Set 12: Code-Review-1
please rebase
--
To view, visit https://gerrit.ovirt.org/44808
To unsubscribe
Nir Soffer has posted comments on this change.
Change subject: volume: Support older engine or disks with long description
..
Patch Set 2:
This version refine the commit message, addressing Adam comments.
--
To view, visit ht
automat...@ovirt.org has posted comments on this change.
Change subject: blockVolume: Separate data formatting and writing
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: volume: Support older engine or disks with long description
..
Patch Set 2:
* Update tracker::#1258097::OK
* Check Bug-Url::OK
* Check Public Bug::#125809
automat...@ovirt.org has posted comments on this change.
Change subject: volume: Unify metadata formatting and validation
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Nir Soffer has posted comments on this change.
Change subject: volume: Support older engine or disks with long description
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45501/1//COMMIT_MSG
Commit Message:
Line 11:
Adam Litke has posted comments on this change.
Change subject: StorageDomainManifest: Move clusterLock into Manifest
..
Patch Set 12: Verified+1
--
To view, visit https://gerrit.ovirt.org/43549
To unsubscribe, visit https://ge
automat...@ovirt.org has posted comments on this change.
Change subject: StorageDomainManifest: Move validateCreateVolumeParams
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found
automat...@ovirt.org has posted comments on this change.
Change subject: StorageDomainManifest: Move clusterLock into Manifest
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: StorageDomainManifest: Move acquireVolumeMetadataSlot
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: StorageDomainManifest: move refresh and refreshDirTree
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Adam Litke has posted comments on this change.
Change subject: StorageDomainManifest: Move clusterLock into Manifest
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/43549/11/tests/sdm_indirection_tests.py
File tests/
Adam Litke has posted comments on this change.
Change subject: volume: Support older engine or disks with long description
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/45501/1//COMMIT_MSG
Commit Message:
Line 11:
Adam Litke has posted comments on this change.
Change subject: volume: Unify metadata formatting and validation
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45502
To unsubscribe, visit https://gerri
Adam Litke has posted comments on this change.
Change subject: blockVolume: Separate data formatting and writing
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45473
To unsubscribe, visit https://gerr
Adam Litke has posted comments on this change.
Change subject: blockVolume: Fail if metadata overflows
..
Patch Set 2: Code-Review+1
Withholding +2 until Liron removes his -1.
--
To view, visit https://gerrit.ovirt.org/45472
Adam Litke has posted comments on this change.
Change subject: storage_exception: Show data in MetadataOverflowError
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45471
To unsubscribe, visit https://
Nir Soffer has posted comments on this change.
Change subject: vm: Libvirt quering after disk detach operation addition.
..
Patch Set 11:
(4 comments)
Mostly look good, needs minor cleanup.
https://gerrit.ovirt.org/#/c/45138/
Nir Soffer has posted comments on this change.
Change subject: vm.py: State saving in hotunplugDisk.
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45077
To unsubscribe, visit https://gerrit.ovirt.org
Nir Soffer has posted comments on this change.
Change subject: lib: Use new concurrent.thread() utility
..
Patch Set 4:
This version split this huge change by subsystem, to make it easier to review
and verify.
Each behavior c
Nir Soffer has posted comments on this change.
Change subject: virt: Use new concurrent.thread() utility
..
Patch Set 1:
I verified the vm creation thread, but I cannot verify the v2v change.
--
To view, visit https://gerrit.
automat...@ovirt.org has posted comments on this change.
Change subject: infra: Use new concurrent.thread() utility
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
automat...@ovirt.org has posted comments on this change.
Change subject: network: Use new concurrent.thread() utility
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has uploaded a new change for review.
Change subject: storage: Use new concurrent.thread() utility
..
storage: Use new concurrent.thread() utility
This patch updates the storage subsystem to use the new utility.
Beha
automat...@ovirt.org has posted comments on this change.
Change subject: virt: Use new concurrent.thread() utility
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
automat...@ovirt.org has posted comments on this change.
Change subject: lib: Use new concurrent.thread() utility
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
automat...@ovirt.org has posted comments on this change.
Change subject: storage: Use new concurrent.thread() utility
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has uploaded a new change for review.
Change subject: infra: Use new concurrent.thread() utility
..
infra: Use new concurrent.thread() utility
This patch updates various infra stuff to use the new utility.
Behavior c
Nir Soffer has uploaded a new change for review.
Change subject: network: Use new concurrent.thread() utility
..
network: Use new concurrent.thread() utility
This patch updates the networking subsystem to use the new utility.
B
Nir Soffer has uploaded a new change for review.
Change subject: virt: Use new concurrent.thread() utility
..
virt: Use new concurrent.thread() utility
This patch updates virt subsystem to use the new utility.
Behavior changes:
Adam Litke has posted comments on this change.
Change subject: vm.py: State saving in hotunplugDisk.
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45077
To unsubscribe, visit https://gerrit.ovirt.org
automat...@ovirt.org has posted comments on this change.
Change subject: hooks: Open vSwitch configurator
..
Patch Set 68:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
Francesco Romani has posted comments on this change.
Change subject: Update v2v to use new jobs infrastructure
..
Patch Set 2:
waiting a bit more to see if Arik/Shahar are ok with this.
--
To view, visit https://gerrit.ovirt.
Nir Soffer has posted comments on this change.
Change subject: tests: Introduce schema parsing tests
..
Patch Set 2: -Code-Review
(1 comment)
I don't have time to dive into the schema parser now.
https://gerrit.ovirt.org/#/c/
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: configurable implementation
..
Patch Set 5:
(5 comments)
https://gerrit.ovirt.org/#/c/44494/5/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 58: from c
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: configurable implementation
..
Patch Set 5:
(5 comments)
https://gerrit.ovirt.org/#/c/44494/5/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 58: from cpo
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: Open vSwitch configurator
..
Patch Set 67:
(3 comments)
https://gerrit.ovirt.org/#/c/40312/67/vdsm_hooks/ovs/README
File vdsm_hooks/ovs/README:
Line 11
Dan Kenigsberg has submitted this change and it was merged.
Change subject: make v2v errors reusable
..
make v2v errors reusable
We plan to introduce a generic jobs module which will be used for
monitoring and managing long run
automat...@ovirt.org has posted comments on this change.
Change subject: supervdsm: generalize udevTrigger method
..
Patch Set 15:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To vie
automat...@ovirt.org has posted comments on this change.
Change subject: make v2v errors reusable
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://
Dan Kenigsberg has submitted this change and it was merged.
Change subject: supervdsm: generalize udevTrigger method
..
supervdsm: generalize udevTrigger method
udevTrigger in it's current state is tied to storage code as it do
Nir Soffer has posted comments on this change.
Change subject: supervdsm: generalize udevTrigger method
..
Patch Set 14: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/44767/14/vdsm/supervdsmServer
File vdsm/supervdsmS
Adam Litke has posted comments on this change.
Change subject: Update v2v to use new jobs infrastructure
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/45382
To unsubscribe, visit https://gerrit.ovirt.or
automat...@ovirt.org has posted comments on this change.
Change subject: virt: Remove QEMU passthrough hack in ppc64
..
Patch Set 14:
* Update tracker::#1122627::OK
* Check Bug-Url::OK
* Check Public Bug::#1122627::OK, public b
automat...@ovirt.org has posted comments on this change.
Change subject: virt: Remove QEMU passthrough hack in ppc64
..
Patch Set 13:
* Update tracker::#1122627::OK
* Check Bug-Url::OK
* Check Public Bug::#1122627::OK, public b
automat...@ovirt.org has posted comments on this change.
Change subject: net: ifcfg: synchronous ifup
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
automat...@ovirt.org has posted comments on this change.
Change subject: fakekvm: report correct POWER8 model
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: virt: add logic for POWER cpu xml element
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: bump libvirt version to 1.2.17-5
..
vdsm: bump libvirt version to 1.2.17-5
This libvirt version fixes POWER8 reporting - only usable models are
reported
automat...@ovirt.org has posted comments on this change.
Change subject: vdsm: bump libvirt version to 1.2.17-5
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
Amit Aviram has posted comments on this change.
Change subject: vm: Libvirt quering after disk detach operation addition.
..
Patch Set 10:
(3 comments)
https://gerrit.ovirt.org/#/c/45138/10/vdsm/virt/vm.py
File vdsm/virt/vm.py
Amit Aviram has posted comments on this change.
Change subject: vm: Libvirt quering after disk detach operation addition.
..
Patch Set 7:
(4 comments)
https://gerrit.ovirt.org/#/c/45138/7/vdsm/virt/vm.py
File vdsm/virt/vm.py:
automat...@ovirt.org has posted comments on this change.
Change subject: vm: Libvirt quering after disk detach operation addition.
..
Patch Set 11:
* Update tracker::#1044466::OK
* Check Bug-Url::OK
* Check Public Bug::#1044466
Francesco Romani has posted comments on this change.
Change subject: virt: Introduce Vm._setVolumeSize helper
..
Patch Set 2: Code-Review+1
why not cherry-pick change I742fde77a23387f89fa746c2030e151237cb230f aka patch
37943?
Francesco Romani has posted comments on this change.
Change subject: virt: Add _getVolumeInfo helper
..
Patch Set 2:
aka patch https://gerrit.ovirt.org/#/c/43560/ ?
--
To view, visit https://gerrit.ovirt.org/45104
To unsubscr
Francesco Romani has posted comments on this change.
Change subject: virt: Add _getVolumeInfo helper
..
Patch Set 2: Code-Review+1
shouldn't change-id I11eefb292e5d08458cf3a16ef9c444fb9c08702b ?
--
To view, visit https://gerr
Francesco Romani has posted comments on this change.
Change subject: virt: Add _getVolumeInfo helper
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45104
To unsubscribe, visit https://gerrit.ovirt.org
Francesco Romani has posted comments on this change.
Change subject: vm: Libvirt quering after disk detach operation addition.
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45138/1//COMMIT_MSG
Commit Message:
Line
automat...@ovirt.org has posted comments on this change.
Change subject: net: synchronous ifup
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur
Petr Horáček has uploaded a new change for review.
Change subject: net: synchronous ifup
..
net: synchronous ifup
Return device only after it's properly created and up.
Change-Id: Id739556e9ebcdd2882d2b055762007204c61cef3
Signe
automat...@ovirt.org has posted comments on this change.
Change subject: net: synchronous ifup
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur
Martin Polednik has posted comments on this change.
Change subject: supervdsm: generalize udevTrigger method
..
Patch Set 14: Verified+1
forgot to add the change, fixed.
--
To view, visit https://gerrit.ovirt.org/44767
To uns
automat...@ovirt.org has posted comments on this change.
Change subject: supervdsm: generalize udevTrigger method
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
automat...@ovirt.org has posted comments on this change.
Change subject: supervdsm: generalize udevTrigger method
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
Martin Polednik has posted comments on this change.
Change subject: supervdsm: generalize udevTrigger method
..
Patch Set 13: Verified+1
Functionality remains the same, the docstring and commit message is a bit more
formally c
automat...@ovirt.org has posted comments on this change.
Change subject: m2c: rename m2c modules
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://g
Dan Kenigsberg has submitted this change and it was merged.
Change subject: m2c: rename m2c modules
..
m2c: rename m2c modules
In preparation for configurable usage ssl or m2crypto modules we need
to distinguish modules which u
Dan Kenigsberg has posted comments on this change.
Change subject: m2c: rename m2c modules
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/44493
To unsubscribe, visit https://gerrit.ovirt.org/settings
Martin Polednik has posted comments on this change.
Change subject: supervdsm: generalize udevTrigger method
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/44767/12/vdsm/supervdsmServer
File vdsm/supervdsmServer:
L
Nir Soffer has posted comments on this change.
Change subject: supervdsm: generalize udevTrigger method
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/44767/12/vdsm/supervdsmServer
File vdsm/supervdsmServer:
Line 2
automat...@ovirt.org has posted comments on this change.
Change subject: vm: make acpiShutdown handle NotConnectedError
..
Patch Set 2:
* Update tracker::#1154389::OK
* Set MODIFIED::bug 1154389#1154389IGNORE, not oVirt
automat...@ovirt.org has posted comments on this change.
Change subject: virt: introduce virdomain module
..
Patch Set 2:
* Update tracker::#1154389::OK
* Set MODIFIED::bug 1154389#1154389IGNORE, not oVirt prod but Red
Francesco Romani has posted comments on this change.
Change subject: vm: make acpiShutdown handle NotConnectedError
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45379
To unsubscribe, visit https://g
Francesco Romani has submitted this change and it was merged.
Change subject: vm: make acpiShutdown handle NotConnectedError
..
vm: make acpiShutdown handle NotConnectedError
In the Vm shutdown flow it is possible that the doma
Francesco Romani has submitted this change and it was merged.
Change subject: virt: introduce virdomain module
..
virt: introduce virdomain module
Add virdomain module to hold the
libvirt Domain wrapper that virt code needs,
to
automat...@ovirt.org has posted comments on this change.
Change subject: vm: Improve error handling when Vm._dom is None
..
Patch Set 2:
* Update tracker::#1154389::OK
* Set MODIFIED::bug 1154389#1154389IGNORE, not oVir
Francesco Romani has posted comments on this change.
Change subject: virt: introduce virdomain module
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45378
To unsubscribe, visit https://gerrit.ovirt.or
Francesco Romani has submitted this change and it was merged.
Change subject: vm: Improve error handling when Vm._dom is None
..
vm: Improve error handling when Vm._dom is None
Vm._dom is initialized to None on when creating a
Francesco Romani has posted comments on this change.
Change subject: vm: Improve error handling when Vm._dom is None
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45377
To unsubscribe, visit https://
Nir Soffer has posted comments on this change.
Change subject: supervdsm: generalize udevTrigger method
..
Patch Set 12: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/44767/12//COMMIT_MSG
Commit Message:
Line 11: dev
Dan Kenigsberg has posted comments on this change.
Change subject: supervdsm: generalize udevTrigger method
..
Patch Set 12: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/44767/12/vdsm/supervdsmServer
File vdsm/superv
Martin Polednik has posted comments on this change.
Change subject: vm: Improve error handling when Vm._dom is None
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45377
To unsubscribe, visit https://g
Nir Soffer has posted comments on this change.
Change subject: hsm: Support checkStatus param in getDeviceList
..
Patch Set 6:
(1 comment)
Looks good, but the commit is missing the big picture.
https://gerrit.ovirt.org/#/c/45
automat...@ovirt.org has posted comments on this change.
Change subject: supervdsm: move udevadm methods to udevadm module
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
Martin Polednik has posted comments on this change.
Change subject: virt: introduce virdomain module
..
Patch Set 1: Code-Review+1
1 possible 'not -1 worthy' q: why not just 'domain'? Conflicts? virt.virdomain
really sounds a
Martin Polednik has posted comments on this change.
Change subject: vm: make acpiShutdown handle NotConnectedError
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45379
To unsubscribe, visit https://ge
Martin Polednik has posted comments on this change.
Change subject: spec: conflict with plain QEMU
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45323
To unsubscribe, visit https://gerrit.ovirt.org/s
Martin Polednik has posted comments on this change.
Change subject: vdscli: map invocation params to dictionary
..
Patch Set 2:
Seems like fine idea, consider that +1 after comments are addressed.
--
To view, visit https://ge
1 - 100 of 158 matches
Mail list logo
