Change in vdsm[master]: storage: move fuser module to vdsm storage lib

2016-04-26 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: storage: move fuser module to vdsm storage lib .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56620 To unsubscribe, visit https://ger

Change in vdsm[master]: v2v: Detect VM with snapshots

2016-04-26 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: v2v: Detect VM with snapshots .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56574 To unsubscribe, visit https://gerrit.ovirt.org/sett

Change in vdsm[master]: Adding configure requirements for py3

2016-04-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: Adding configure requirements for py3 .. Patch Set 3: Is this working now? If not, please mention it and mark the patch with -1 so I'll gracefully ignore it :) -

Change in vdsm[master]: net: native ovs: reserve ovsbr0 network name

2016-04-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: native ovs: reserve ovsbr0 network name .. Patch Set 8: Please rebase -- To view, visit https://gerrit.ovirt.org/56452 To unsubscribe, visit https://gerrit.

Change in vdsm[ovirt-3.6]: spec: qemu-kvm-img to handle unaligned images

2016-04-26 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: spec: qemu-kvm-img to handle unaligned images .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/56630 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: net: native ovs: ovsnettestlib.py

2016-04-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: native ovs: ovsnettestlib.py .. Patch Set 12: Code-Review+1 Very nice, thanks. -- To view, visit https://gerrit.ovirt.org/56391 To unsubscribe, visit https:

Change in vdsm[master]: net: native ovs: store constants in __init__

2016-04-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: native ovs: store constants in __init__ .. Patch Set 10: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/56451/10/lib/vdsm/network/ovs/switch.py File

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

2016-04-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: Using pkgutil instead of redundant private funcs in configurator .. Patch Set 9: (3 comments) https://gerrit.ovirt.org/#/c/53214/9/lib/vdsm/module_loader.py File

Change in vdsm[master]: NetworkManager: configure to monitor ifcfg/connection files

2016-04-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: NetworkManager: configure to monitor ifcfg/connection files .. Patch Set 4: I am in favor of "keyfile" plugin approach, where you specify the devices that should

Change in vdsm[master]: v2v: Detect VM with snapshots

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: Detect VM with snapshots .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur

Change in vdsm[master]: v2v: Detect VM with snapshots

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: Detect VM with snapshots .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur

Change in vdsm[master]: virt: add device setup and teardown

2016-04-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: add device setup and teardown .. Patch Set 11: (7 comments) Partial review https://gerrit.ovirt.org/#/c/55135/11/tests/vmTests.py File tests/vmTests.py: Li

Change in vdsm[master]: tests: volume_artifacts: validate FileVolumeArtifacts metadata

2016-04-26 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata .. tests: volume_artifacts: validate FileVolumeArtifacts metadata We now have the VolumeMeta

Change in vdsm[master]: tests: volume_artifacts: validate FileVolumeArtifacts metadata

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url foun

Change in vdsm[master]: Support initial_size parameter

2016-04-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Support initial_size parameter .. Patch Set 3: Code-Review-1 (3 comments) Looks good https://gerrit.ovirt.org/#/c/56628/3/tests/storage_volume_artifacts_test.py F

Change in vdsm[master]: tests: volume_artifacts: validate FileVolumeArtifacts metadata

2016-04-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata .. Patch Set 10: Rebase on master so we can merge it now safely. -- To view, visit https://gerrit.o

Change in vdsm[master]: tests: volume_artifacts: validate FileVolumeArtifacts metadata

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found

Change in vdsm[master]: storage: Add basic BlockVolumeArtifacts

2016-04-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: Add basic BlockVolumeArtifacts .. Patch Set 11: Code-Review-1 (5 comments) Partial review https://gerrit.ovirt.org/#/c/55987/11/vdsm/storage/blockSD.py F

Change in vdsm[master]: tests: marking temporarily as broken

2016-04-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: marking temporarily as broken .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56650 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: client: do not protect requests on client side

2016-04-26 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 2: Yaniv's comments fixed. Simone can you verify it one more time? -- To view, visit https://ger

Change in vdsm[master]: client: do not protect requests on client side

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure heade

Change in vdsm[master]: tests: marking temporarily as broken

2016-04-26 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: tests: marking temporarily as broken .. Patch Set 1: Verified+1 Verified by building locally -- To view, visit https://gerrit.ovirt.org/56650 To unsubscribe

Change in vdsm[master]: tests: marking temporarily as broken

2016-04-26 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: tests: marking temporarily as broken .. Patch Set 1: It is sad that I need to do :/. Hopefully will have some time soon to fix them. -- To view, visit https

Change in vdsm[master]: tests: marking temporarily as broken

2016-04-26 Thread piotr . kliczewski
Piotr Kliczewski has uploaded a new change for review. Change subject: tests: marking temporarily as broken .. tests: marking temporarily as broken Change-Id: Id673e92e73ae93994e002ac47b83af7031faeec0 Signed-off-by: pkliczewski

Change in vdsm[master]: tests: marking temporarily as broken

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: marking temporarily as broken .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: volume_artifacts: validate FileVolumeArtifacts metadata

2016-04-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata .. Patch Set 9: Adam, does this patch really depend on the previous patches? can you rebase it on ma

Change in vdsm[master]: tests: volume_artifacts: validate FileVolumeArtifacts metadata

2016-04-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata .. Patch Set 9: Verified+1 Jenkins is happy with the new test, seems verified. -- To view, visit ht

Change in vdsm[master]: storage: sdm: consolidate create validation

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: sdm: consolidate create validation .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, vis

Change in vdsm[master]: storage: sdm: consolidate create validation

2016-04-26 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: storage: sdm: consolidate create validation .. storage: sdm: consolidate create validation The validation of VolumeArtifacts.create parameters can be share

Change in vdsm[master]: tests: Add test_create_same_volume_in_image

2016-04-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Add test_create_same_volume_in_image .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56626 To unsubscribe, visit https://gerrit.ovi

Change in vdsm[master]: tests: Add test_create_same_volume_in_image

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add test_create_same_volume_in_image .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, vis

Change in vdsm[master]: tests: Add test_create_same_volume_in_image

2016-04-26 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: tests: Add test_create_same_volume_in_image .. tests: Add test_create_same_volume_in_image Add a new test (which will be broken until support for creating

Change in vdsm[master]: tests: Add test_create_same_volume_in_image

2016-04-26 Thread alitke
Adam Litke has posted comments on this change. Change subject: tests: Add test_create_same_volume_in_image .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/56626 To unsubscribe, visit https://gerrit.ovirt.

Change in vdsm[master]: storage: sdm: consolidate create validation

2016-04-26 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: sdm: consolidate create validation .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/56627 To unsubscribe, visit https://gerrit.ovirt.

Change in vdsm[master]: storage: sdm: consolidate create validation

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: sdm: consolidate create validation .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header m

Change in vdsm[master]: tests: Add test_create_same_volume_in_image

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add test_create_same_volume_in_image .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header m

Change in vdsm[master]: Support initial_size parameter

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Support initial_size parameter .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U

Change in vdsm[master]: tests: volume_artifacts: validate FileVolumeArtifacts metadata

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: cow wip

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: cow wip .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid u

Change in vdsm[master]: storage: Add basic BlockVolumeArtifacts

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Add basic BlockVolumeArtifacts .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matc

Change in vdsm[master]: tests: volume_artifacts: validate FileVolumeArtifacts metadata

2016-04-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata .. Patch Set 8: Can you rebase this on master? I want to merge it now. -- To view, visit https://ge

Change in vdsm[master]: storage: organize imports in clusterlock.py

2016-04-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: organize imports in clusterlock.py .. Patch Set 1: Code-Review-1 See the comments. -- To view, visit https://gerrit.ovirt.org/56639 To unsubscribe, visit

Change in vdsm[master]: jsonrpcvdscli: add storage verbs

2016-04-26 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpcvdscli: add storage verbs .. Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55252 To unsubscribe, visit https://gerrit.ovirt.o

Change in vdsm[master]: hostdev: report additional information in 'scsi' device

2016-04-26 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: hostdev: report additional information in 'scsi' device .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/56038/5/lib/vdsm/hostdev.py File lib/vdsm/hostd

Change in vdsm[master]: Let the engine control the guest lifecycle events

2016-04-26 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: Let the engine control the guest lifecycle events .. Patch Set 6: Code-Review+2 Based on Franceso's score and schema change being OK I raise. -- To view, vi

Change in vdsm[master]: vm: handle destroy request while starting up

2016-04-26 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: handle destroy request while starting up .. Patch Set 6: Verified+1 verified both positive and negative flow, the negative (aka triggering the failure) i

Change in vdsm[master]: tests: Add test_create_same_volume_in_image

2016-04-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Add test_create_same_volume_in_image .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/56626/2/tests/storage_volume_artifacts_test.py F

Change in vdsm[master]: hostdev: use libvirt flags to select capability

2016-04-26 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: hostdev: use libvirt flags to select capability .. Patch Set 5: Code-Review+1 (Although I still insist on that there is a grammar error in the commit message.)

Change in vdsm[master]: tests: Add test_create_same_volume_in_image

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add test_create_same_volume_in_image .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header m

Change in vdsm[master]: Support initial_size parameter

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Support initial_size parameter .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U

Change in vdsm[master]: storage: Add basic BlockVolumeArtifacts

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Add basic BlockVolumeArtifacts .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matc

Change in vdsm[master]: tests: volume_artifacts: validate FileVolumeArtifacts metadata

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: storage: sdm: consolidate create validation

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: sdm: consolidate create validation .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header m

Change in vdsm[master]: cow wip

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: cow wip .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid u

Change in vdsm[master]: jsonrpc: handle strings as correct response

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: jsonrpc: handle strings as correct response .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, vis

Change in vdsm[master]: jsonrpc: handle strings as correct response

2016-04-26 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: jsonrpc: handle strings as correct response .. jsonrpc: handle strings as correct response There is bunch of different response types. Currnetly we han

Change in vdsm[master]: jsonrpc: handle strings as correct response

2016-04-26 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: handle strings as correct response .. Patch Set 3: Code-Review+2 raising score -- To view, visit https://gerrit.ovirt.org/56207 To unsubscribe, visit

Change in vdsm[master]: vm: handle destroy request while starting up

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: handle destroy request while starting up .. Patch Set 6: * #912390::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#912390::OK, public bug * Check

Change in vdsm[master]: client: do not protect requests on client side

2016-04-26 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56288 To unsubscribe, visit https://g

Change in vdsm[master]: client: do not protect requests on client side

2016-04-26 Thread stirabos
Simone Tiraboschi has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 1: Verified on ovirt-hosted-engine-setup -- To view, visit https://gerrit.ovirt.org/56288 To un

Change in vdsm[master]: jsonrpc: handle strings as correct response

2016-04-26 Thread stirabos
Simone Tiraboschi has posted comments on this change. Change subject: jsonrpc: handle strings as correct response .. Patch Set 3: Verified+1 Verified with hosted-engine-setup -- To view, visit https://gerrit.ovirt.org/56207 T

Change in vdsm[master]: jsonrpcvdscli: add storage verbs

2016-04-26 Thread stirabos
Simone Tiraboschi has posted comments on this change. Change subject: jsonrpcvdscli: add storage verbs .. Patch Set 11: Verified+1 Verified on iSCSI and NFS -- To view, visit https://gerrit.ovirt.org/55252 To unsubscribe, vis

Change in vdsm[master]: hostdev: expose generic scsi driver char device in device pa...

2016-04-26 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: hostdev: expose generic scsi driver char device in device params .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/55022/6/lib/vdsm/hostdev.py File lib/v

Change in vdsm[master]: hostdev: add is_assignable flag

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: add is_assignable flag .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://g

Change in vdsm[master]: hostdev: add is_assignable flag

2016-04-26 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: hostdev: add is_assignable flag .. hostdev: add is_assignable flag is_assignable is new flag that uses underlying PCI_HEADER_TYPE. We can only assign d

Change in vdsm[master]: hostdev: use libvirt flags to select capability

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: use libvirt flags to select capability .. Patch Set 5: * #1270581::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1270581::OK, public bug *

Change in vdsm[master]: hostdev: add support for SCSI

2016-04-26 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: hostdev: add support for SCSI .. Patch Set 7: (3 comments) https://gerrit.ovirt.org/#/c/55024/5//COMMIT_MSG Commit Message: PS5, Line 12: udev pat > Sorry, w

Change in vdsm[master]: tests: Add test_create_same_volume_in_image

2016-04-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Add test_create_same_volume_in_image .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56626/1/tests/storage_volume_artifacts_test.py File tests/stor

Change in vdsm[master]: storage: sdm: consolidate create validation

2016-04-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: sdm: consolidate create validation .. Patch Set 1: -Verified Jenkins failure caused by the previous patch. -- To view, visit https://gerrit.ovirt.org/566

Change in vdsm[master]: hostdev: make _update_usb_device_info more generic

2016-04-26 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev: make _update_usb_device_info more generic .. Patch Set 6: Code-Review+1 (1 comment) please check inline comment (very minor, should be trivial to fi

Change in vdsm[master]: hostdev: make _update_usb_device_info more generic

2016-04-26 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: hostdev: make _update_usb_device_info more generic .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/55023/6/vdsm/virt/vmdevices/hostdevice.py File vds

Change in vdsm[master]: migration: Enable lazy setting of incoming/outgoing limits

2016-04-26 Thread mbetak
Martin Betak has posted comments on this change. Change subject: migration: Enable lazy setting of incoming/outgoing limits .. Patch Set 21: (1 comment) https://gerrit.ovirt.org/#/c/53305/21/vdsm/API.py File vdsm/API.py: PS21

Change in vdsm[master]: migration: Enable lazy setting of incoming/outgoing limits

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: Enable lazy setting of incoming/outgoing limits .. Patch Set 25: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, ma

Change in vdsm[master]: hostdev: add support for SCSI

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: add support for SCSI .. Patch Set 8: * #1270581::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1270581::OK, public bug * Check Product::#12

Change in vdsm[master]: hostdev: expose generic scsi driver char device in device pa...

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: expose generic scsi driver char device in device params .. Patch Set 7: * #1270581::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1270581::

Change in vdsm[master]: hostdev: make _update_usb_device_info more generic

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: make _update_usb_device_info more generic .. Patch Set 7: * #1270581::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1270581::OK, public bug

Change in vdsm[master]: hostdev: report storage model as product

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: report storage model as product .. Patch Set 4: * #1270581::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1270581::OK, public bug * Check P

Change in vdsm[master]: hostdev: report additional information in 'scsi' device

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: report additional information in 'scsi' device .. Patch Set 5: * #1270581::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1270581::OK, publi

Change in vdsm[master]: hostdev: add support for SCSI

2016-04-26 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev: add support for SCSI .. Patch Set 7: Code-Review+1 (1 comment) please check the inline comment https://gerrit.ovirt.org/#/c/55024/7/lib/vdsm/hostde

Change in vdsm[master]: hostdev: make _update_usb_device_info more generic

2016-04-26 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev: make _update_usb_device_info more generic .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55023 To unsubscribe, visit https

Change in vdsm[master]: hostdev: report storage model as product

2016-04-26 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: hostdev: report storage model as product .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/56123/3//COMMIT_MSG Commit Message: Line 11: is a special s

Change in vdsm[master]: hostdev: report additional information in 'scsi' device

2016-04-26 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev: report additional information in 'scsi' device .. Patch Set 4: Code-Review-1 (3 comments) looks good, but few questions inside, -1 for visibility h

Change in vdsm[master]: storage: sdm: consolidate create validation

2016-04-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: sdm: consolidate create validation .. Patch Set 1: Verified-1 This fails with: 14:58:37 pyflakes-1.1.0 14:58:45 ./tests/storage_volume_artifacts_test.py:1

Change in vdsm[master]: hostdev: use libvirt flags to select capability

2016-04-26 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: hostdev: use libvirt flags to select capability .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/56037/4//COMMIT_MSG Commit Message: PS4, Line 10: c

Change in vdsm[master]: hostdev: expose generic scsi driver char device in device pa...

2016-04-26 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev: expose generic scsi driver char device in device params .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55022 To unsubscrib

Change in vdsm[master]: tests: Move artifacts tests to their approproate classes

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Move artifacts tests to their approproate classes .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. --

Change in vdsm[master]: tests: Move artifacts tests to their approproate classes

2016-04-26 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: tests: Move artifacts tests to their approproate classes .. tests: Move artifacts tests to their approproate classes The tests: - test_new_image_commit_wi

Change in vdsm[master]: hostdev: report storage model as product

2016-04-26 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev: report storage model as product .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/56123/3//COMMIT_MSG Commit Message: Line 11: is a special

Change in vdsm[master]: tests: Move artifacts tests to their approproate classes

2016-04-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Move artifacts tests to their approproate classes .. Patch Set 1: Continuous-Integration+1 Jenkins failed, ignoring it. -- To view, visit https://gerrit.ov

Change in vdsm[master]: tests: Add test_create_same_volume_in_image

2016-04-26 Thread alitke
Adam Litke has posted comments on this change. Change subject: tests: Add test_create_same_volume_in_image .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56626/1/tests/storage_volume_artifacts_test.py File tests/stor

Change in vdsm[master]: hostdev: report storage model as product

2016-04-26 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev: report storage model as product .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56123 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: tests: Move artifacts tests to their approproate classes

2016-04-26 Thread alitke
Adam Litke has posted comments on this change. Change subject: tests: Move artifacts tests to their approproate classes .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/56625 To unsubscribe, visit https://

Change in vdsm[master]: hostdev: use libvirt flags to select capability

2016-04-26 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev: use libvirt flags to select capability .. Patch Set 4: Code-Review+1 please check Milan's comment. I don't have any other. -- To view, visit https:

Change in vdsm[master]: storage: sdm: consolidate create validation

2016-04-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: sdm: consolidate create validation .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56627 To unsubscribe, visit https://gerrit.ovi

Change in vdsm[master]: storage: organize imports in clusterlock.py

2016-04-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: organize imports in clusterlock.py .. Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/56639/1/vdsm/storage/clusterlock.py File vdsm/storage/cluster

Change in vdsm[master]: tests: volume_artifacts: validate FileVolumeArtifacts metadata

2016-04-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56172 To unsubscribe, visit

Change in vdsm[master]: migration: move helper into Progress class

2016-04-26 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: migration: move helper into Progress class .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56313 To unsubscribe, visit https://gerrit

Change in vdsm[master]: migration: validate progress fields from libvirt

2016-04-26 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: migration: validate progress fields from libvirt .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56378 To unsubscribe, visit https://

Change in vdsm[master]: storage: organize imports in clusterlock.py

2016-04-26 Thread ishaby
Idan Shaby has posted comments on this change. Change subject: storage: organize imports in clusterlock.py .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/56639 To unsubscribe, visit https://gerrit.ovirt.

Change in vdsm[master]: hostdev: use libvirt flags to select capability

2016-04-26 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: hostdev: use libvirt flags to select capability .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/56037/4//COMMIT_MSG Commit Message: PS4, Line 10: cap

  1   2   3   >