Adam Litke has posted comments on this change.
Change subject: [WIP]add simple balloon functional testcase
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/12820
To unsubscribe, visit http://gerrit.ovirt
Adam Litke has posted comments on this change.
Change subject: Enable balloon and use the MoM multiple policies feature
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/
Adam Litke has posted comments on this change.
Change subject: Rename balloon_min to min_guarantee in balloon information
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
Adam Litke has posted comments on this change.
Change subject: gluster: verbs for managing services
..
Patch Set 24: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11094
To unsubscrib
Adam Litke has abandoned this change.
Change subject: api: address and deviceId are optional for VM devices
..
Patch Set 1: Abandoned
Bitrot
--
To view, visit http://gerrit.ovirt.org/12316
To unsubscribe, visit http://gerrit.
Adam Litke has abandoned this change.
Change subject: schema: Fix the Hooks schema definition
..
Patch Set 9: Abandoned
Bitrot
--
To view, visit http://gerrit.ovirt.org/11568
To unsubscribe, visit http://gerrit.ovirt.org/sett
Adam Litke has abandoned this change.
Change subject: caps: Ensure package version data are always strings
..
Patch Set 9: Abandoned
Bitrot
--
To view, visit http://gerrit.ovirt.org/11569
To unsubscribe, visit http://gerrit.o
Adam Litke has abandoned this change.
Change subject: netinfo: Items in the 'bridges' dict are missing the 'bridged'
field
..
Patch Set 6: Abandoned
Bitrot
--
To view, visit http://gerrit.ovirt.org/11567
To unsubscribe, visi
Adam Litke has abandoned this change.
Change subject: vdsm-jsonrpc depends on vdsm-yajsonrpc
..
Patch Set 2: Abandoned
Bitrot
--
To view, visit http://gerrit.ovirt.org/12317
To unsubscribe, visit http://gerrit.ovirt.org/setti
Adam Litke has abandoned this change.
Change subject: [WIP] Implement python bindings
..
Patch Set 8: Abandoned
Bitrot
--
To view, visit http://gerrit.ovirt.org/11755
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Adam Litke has posted comments on this change.
Change subject: gluster: new vdsm verb glusterHostUUIDGet
..
Patch Set 4: (1 inline comment)
File vdsm/gluster/vdsmapi-gluster-
Adam Litke has posted comments on this change.
Change subject: gluster: Added verbs for read, update, add and remove hooks
..
Patch Set 5: (2 inline comments)
File vdsm/glust
Adam Litke has posted comments on this change.
Change subject: gluster: new vdsm verb glusterHostUUIDGet
..
Patch Set 4: (1 inline comment)
File vdsm/gluster/vdsmapi-gluster-
Adam Litke has posted comments on this change.
Change subject: gluster: verbs for managing services
..
Patch Set 18: I would prefer that you didn't submit this
(1 inline comment)
One small change to make it correct. You can t
Adam Litke has posted comments on this change.
Change subject: gluster: Added gluster hooks support
..
Patch Set 30: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9671
To unsubscribe,
Adam Litke has posted comments on this change.
Change subject: vdsmapi: vdsmapi support for gluster vdsm verbs
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13921
To unsubscribe, visit htt
Adam Litke has posted comments on this change.
Change subject: gluster: Added gluster hooks support
..
Patch Set 27: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9671
To unsubscribe,
Adam Litke has posted comments on this change.
Change subject: gluster: move exportToSupervdsm at module level
..
Patch Set 14: Looks good to me, but someone else must approve
Looks ok to me.
--
To view, visit http://gerrit.ov
Adam Litke has posted comments on this change.
Change subject: vdsmapi: vdsmapi support for gluster vdsm verbs
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
No major objections. Would like to s
Adam Litke has posted comments on this change.
Change subject: make our udev rules take effect later than default Ubuntu lvm
rules
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit
Adam Litke has posted comments on this change.
Change subject: dynamicly generate json-rpc client proxy methods according to
schema
..
Patch Set 11: I would prefer that you didn't submit this
I think we should get the python b
Adam Litke has posted comments on this change.
Change subject: change vdsm to use multipolicy mom
..
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
..
Adam Litke has posted comments on this change.
Change subject: netinfo: Items in the 'bridges' dict are missing the 'bridged'
field
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/11567
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: vdsm-jsonrpc depends on vdsm-yajsonrpc
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/12317
To unsubscribe, visit http://gerrit.ovirt.org/settin
Adam Litke has posted comments on this change.
Change subject: api: address and deviceId are optional for VM devices
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12316
To unsubscribe, visit http://gerrit.o
Adam Litke has posted comments on this change.
Change subject: caps: Ensure package version data are always strings
..
Patch Set 9: Verified
--
To view, visit http://gerrit.ovirt.org/11569
To unsubscribe, visit http://gerrit.ov
Adam Litke has posted comments on this change.
Change subject: schema: Fix the Hooks schema definition
..
Patch Set 9: Verified
--
To view, visit http://gerrit.ovirt.org/11568
To unsubscribe, visit http://gerrit.ovirt.org/setti
Adam Litke has uploaded a new change for review.
Change subject: api: address and deviceId are optional for VM devices
..
api: address and deviceId are optional for VM devices
Signed-off-by: Adam Litke
Change-Id: I00fdfd984960e
Adam Litke has uploaded a new change for review.
Change subject: vdsm-jsonrpc depends on vdsm-yajsonrpc
..
vdsm-jsonrpc depends on vdsm-yajsonrpc
Vdsm's jsonrpc server binding imports yajsonrpc but the spec file does not list
ya
Adam Litke has abandoned this change.
Change subject: tests: Avoid ResourceManagerTests failures when running
parallel tests
..
Patch Set 3: Abandoned
Fixed in Id74717584f0c4753cec58cb1b701e7095a735924 by just skipping this te
Adam Litke has posted comments on this change.
Change subject: tests: Skip stress tests that behave badly when run in parallel
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/12173
To unsubscribe, visit http:
Adam Litke has posted comments on this change.
Change subject: tests: Skip tests that behave badly when run in parallel
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12173
To unsubscribe, visit http://gerri
Adam Litke has uploaded a new change for review.
Change subject: tests: Skip tests that behave badly when run in parallel
..
tests: Skip tests that behave badly when run in parallel
A particular test: resourceManagerTests.testSt
Adam Litke has posted comments on this change.
Change subject: add verb for vdsm to tuneCpu params
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7492
To unsubscribe, v
Adam Litke has posted comments on this change.
Change subject: api: Convert process_schema.py to use vdsmapi.get_api()
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/12109
To unsubscribe, visit http://gerrit
Adam Litke has posted comments on this change.
Change subject: api: Convert schemaTests to use vdsmapi.get_api
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/12108
To unsubscribe, visit http://gerrit.ovirt.o
Adam Litke has posted comments on this change.
Change subject: api: Separate api schema into its own package
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/11864
To unsubscribe, visit http://gerrit.ovirt.org
Adam Litke has posted comments on this change.
Change subject: api: Remove some unneeded functions from vdsmapi.py
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/11865
To unsubscribe, visit http://gerrit.ovi
Adam Litke has posted comments on this change.
Change subject: api: Organize schema symbols by type
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/12106
To unsubscribe, visit http://gerrit.ovirt.org/settings
Adam Litke has posted comments on this change.
Change subject: api: Move DynamicBridge to vdsmapi schema processing
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/12107
To unsubscribe, visit http://gerrit.ov
Adam Litke has posted comments on this change.
Change subject: gluster: add task support
..
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
Some TODO items regarding the schema.
Adam Litke has uploaded a new change for review.
Change subject: api: Convert process_schema.py to use vdsmapi.get_api()
..
api: Convert process_schema.py to use vdsmapi.get_api()
Change-Id: Id4f6ec96f503b41fc1c976f515feb15a58a3
Adam Litke has uploaded a new change for review.
Change subject: api: Move DynamicBridge to vdsmapi schema processing
..
api: Move DynamicBridge to vdsmapi schema processing
Signed-off-by: Adam Litke
Change-Id: I0bbcc2475a40749
Adam Litke has uploaded a new change for review.
Change subject: api: Convert schemaTests to use vdsmapi.get_api
..
api: Convert schemaTests to use vdsmapi.get_api
Change-Id: I3e5716fcb9724621f4fb282746bf02958b1972d4
Signed-off-
Adam Litke has uploaded a new change for review.
Change subject: api: Organize schema symbols by type
..
api: Organize schema symbols by type
Currently the vdsmapi module returns the parsed schema as a large list of
symbols. Co
Adam Litke has posted comments on this change.
Change subject: blocksd: skip broken images in getAllVolumes
..
Patch Set 2:
FYI: This may be a candidate for fixing
https://bugzilla.redhat.com/show_bug.cgi?id=910013
--
To view
Adam Litke has posted comments on this change.
Change subject: add a json rpc funtional test which sets up a VM
..
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
...
Adam Litke has posted comments on this change.
Change subject: fix Exception message error in apiTests module
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11289
To un
Adam Litke has posted comments on this change.
Change subject: Added a support for a guest hibernate command.
..
Patch Set 15: I would prefer that you didn't submit this
(1 inline comment)
.
Adam Litke has posted comments on this change.
Change subject: tests: Avoid ResourceManagerTests failures when running
parallel tests
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/12034
To unsubscribe, vis
Adam Litke has posted comments on this change.
Change subject: tests: Avoid ResourceManagerTests failures when running
parallel tests
..
Patch Set 2: (1 inline comment)
File
Adam Litke has posted comments on this change.
Change subject: tests: Avoid ResourceManagerTests failures when running
parallel tests
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/12034
To unsubscribe, vis
Adam Litke has posted comments on this change.
Change subject: tests: Avoid ResourceManagerTests failures when running
parallel tests
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12034
To unsubscribe, vis
Adam Litke has uploaded a new change for review.
Change subject: tests: Avoid ResourceManagerTests failures when running
parallel tests
..
tests: Avoid ResourceManagerTests failures when running parallel tests
In the Jenkins te
Adam Litke has posted comments on this change.
Change subject: tests: Make getFreePort work in a multithreaded environment
..
Patch Set 2: Verified
I can locally run 8 copies of the tests at the same time with this patch.
--
T
Adam Litke has uploaded a new change for review.
Change subject: tests: Make getFreePort work in a multithreaded environment
..
tests: Make getFreePort work in a multithreaded environment
getFreePort does not currently work reli
Adam Litke has posted comments on this change.
Change subject: blocksd: skip broken images in getAllVolumes
..
Patch Set 2: Looks good to me, but someone else must approve
Yes please! We are actually seeing this in a productio
Adam Litke has uploaded a new change for review.
Change subject: api: Remove some unneeded functions from vdsmapi.py
..
api: Remove some unneeded functions from vdsmapi.py
Change-Id: I25d534033f089bf9f36592bd2be0e98f2fde2dfe
Sig
Adam Litke has uploaded a new change for review.
Change subject: api: Separate api schema into its own package
..
api: Separate api schema into its own package
The vdsm schema definition is needed by the vdsm server but also by
Adam Litke has posted comments on this change.
Change subject: [WIP] Implement python bindings
..
Patch Set 2: (7 inline comments)
File vdsm_api/vdsmapi-schema.json
Line 2341
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Fix race in ProtonReactor and add better delivery
semantics
..
Patch Set 11: Looks good to me, but someone else must approve
Thanks for the explanation Sa
Adam Litke has posted comments on this change.
Change subject: netinfo: report IPv6 information
..
Patch Set 6: Looks good to me, but someone else must approve
I don't see any problems with the schema changes.
--
To view, visi
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Make jsonrpc an independent package
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/11710
To unsubscribe, visit http://gerrit.ovirt.org/
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Use the AsyncoreClient implementation in tests too
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerri
Adam Litke has posted comments on this change.
Change subject: tests: (OCD) Add space at the end of the sample string
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovi
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Remove unecessary check
..
Patch Set 3: Verified
Please add a reason why the check is not needed to your commit message.
--
To view, visit http://gerrit.o
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Check for credit before popping a message from the
queue
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.o
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Use asyncore instead of custom solution
..
Patch Set 6: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Make reactor clients 1st class objects
..
Patch Set 5: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Change start_listening to createListener
..
Patch Set 5: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Add support for multiple listeners
..
Patch Set 5: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1140
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Change cxtr to connector to make the code a bit more
understandable
..
Patch Set 10: Verified; Looks good to me, but someone else must approve
Carrying my
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Add multi-threading option to JsonRpcServer
..
Patch Set 11: Verified
--
To view, visit http://gerrit.ovirt.org/10374
To unsubscribe, visit http://gerrit.o
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Federate context and request-response objects
..
Patch Set 11: Verified
--
To view, visit http://gerrit.ovirt.org/10375
To unsubscribe, visit http://gerrit
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Federate context and request-response objects
..
Patch Set 11: Looks good to me, but someone else must approve
Patch is unchanged and my review stands as-i
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Add multi-threading option to JsonRpcServer
..
Patch Set 11: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1037
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Fix race in ProtonReactor and add better delivery
semantics
..
Patch Set 11: (1 inline comment)
Commi
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Make jsonrpc an independent package
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11710
To unsu
Adam Litke has posted comments on this change.
Change subject: netinfo: Items in the 'bridges' dict are missing the 'bridged'
field
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/11567
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: caps: Ensure package version data are always strings
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/11569
To unsubscribe, visit http://gerrit.ov
Adam Litke has posted comments on this change.
Change subject: schema: Fix the Hooks schema definition
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/11568
To unsubscribe, visit http://gerrit.ovirt.org/setti
Adam Litke has posted comments on this change.
Change subject: schema: Fix the Hooks schema definition
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/11568
To unsubscribe, visit http://gerrit.ovirt.org/setti
Adam Litke has uploaded a new change for review.
Change subject: [WIP] Implement python bindings
..
[WIP] Implement python bindings
This patch produces a native way for python programs to work with the vdsm
jsonrpc API without n
Adam Litke has posted comments on this change.
Change subject: netinfo: Items in the 'bridges' dict are missing the 'bridged'
field
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/11567
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: caps: Ensure package version data are always strings
..
Patch Set 2: (2 inline comments)
File vdsm/caps.py
Line
Adam Litke has posted comments on this change.
Change subject: schema: Update VmDefinition to match current behavior
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/11712
To unsubscribe, visit http://gerrit.o
Adam Litke has posted comments on this change.
Change subject: schema: Eliminate 'class' from StorageDomainInfo
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/11711
To unsubscribe, visit http://gerrit.ovirt.
Adam Litke has posted comments on this change.
Change subject: caps: Ensure package version data are always strings
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/11569
To unsubscribe, visit http://gerrit.ov
Adam Litke has uploaded a new change for review.
Change subject: schema: Update VmDefinition to match current behavior
..
schema: Update VmDefinition to match current behavior
The schema for VmDefinition was incorrect in that it
Adam Litke has uploaded a new change for review.
Change subject: schema: Eliminate 'class' from StorageDomainInfo
..
schema: Eliminate 'class' from StorageDomainInfo
'class' is usually a reserved word and makes a bad name for a
Adam Litke has posted comments on this change.
Change subject: netinfo: Items in the 'bridges' dict are missing the 'bridged'
field
..
Patch Set 1: (1 inline comment)
File v
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Make jsonrpc an independent package
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11710
To unsu
Adam Litke has posted comments on this change.
Change subject: netinfo: Items in the 'bridges' dict are missing the 'bridged'
field
..
Patch Set 1: (1 inline comment)
File v
Adam Litke has uploaded a new change for review.
Change subject: caps: Ensure package version data are always strings
..
caps: Ensure package version data are always strings
According to the schema, package version information i
Adam Litke has uploaded a new change for review.
Change subject: schema: Fix the Hooks schema definition
..
schema: Fix the Hooks schema definition
The schema does not correctly describe the format of the hook info as returned
i
Adam Litke has uploaded a new change for review.
Change subject: netinfo: Items in the 'bridges' dict are missing the 'bridged'
field
..
netinfo: Items in the 'bridges' dict are missing the 'bridged' field
According to the sche
Adam Litke has posted comments on this change.
Change subject: change vdsm to use multipolicy mom
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Mom doesn't yet have a 0.3.1 version so committing
Adam Litke has posted comments on this change.
Change subject: jsonrpc: Rearrange test classes for reusability
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/11122
To unsubscribe, visit http://gerrit.ovirt.o
Adam Litke has posted comments on this change.
Change subject: schema: Strengthen schema verification
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/11397
To unsubscribe, visit http://gerrit.ovirt.org/settin
Adam Litke has posted comments on this change.
Change subject: schema: bridges was added to VdsmCapabilities
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/11396
To unsubscribe, visit http://gerrit.ovirt.org
1 - 100 of 583 matches
Mail list logo
