Change in vdsm[master]: sos report: _importVdsmPylibModule can import all vdsm modules

2016-07-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: sos report: _importVdsmPylibModule can import all vdsm modules .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60627 To unsubscribe,

Change in vdsm[master]: sos report: _importVdsmPylibModule can import all vdsm modules

2016-07-21 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: sos report: _importVdsmPylibModule can import all vdsm modules .. sos report: _importVdsmPylibModule can import all vdsm modules sos report cannot

Change in vdsm[master]: sos report: replace vdscli with jsonrpcvdscli

2016-07-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: sos report: replace vdscli with jsonrpcvdscli .. Patch Set 12: (2 comments) https://gerrit.ovirt.org/#/c/60605/12/vdsm/sos/vdsm.py.in File

Change in vdsm[master]: hostdev: properly teardown on hotunplug

2016-07-21 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: hostdev: properly teardown on hotunplug .. hostdev: properly teardown on hotunplug The device teardown mechanism is not explicitly invoked in

Change in vdsm[master]: hostdev: use proper scsi address

2016-07-21 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: hostdev: use proper scsi address .. hostdev: use proper scsi address SCSI device requires different address than what we call host address, as host

Change in vdsm[master]: hostdev: properly detect attached scsi devices

2016-07-21 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: hostdev: properly detect attached scsi devices .. hostdev: properly detect attached scsi devices SCSI device is addressed by two fields: adapter,

Change in vdsm[master]: hostdev: improve robustness of libvirt SCSI access

2016-07-21 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: hostdev: improve robustness of libvirt SCSI access .. hostdev: improve robustness of libvirt SCSI access SCSI host device is specific as it's

Change in vdsm[master]: hostdev: move usb device code to separate class

2016-07-21 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: hostdev: move usb device code to separate class .. hostdev: move usb device code to separate class We continue the effort of splitting the host device

Change in vdsm[master]: hostdev: use specific device classes in HostDevice

2016-07-21 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: hostdev: use specific device classes in HostDevice .. hostdev: use specific device classes in HostDevice The device functionality has been split into

Change in vdsm[master]: network/sr-iov: use device teardown to reattach device

2016-07-21 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: network/sr-iov: use device teardown to reattach device .. network/sr-iov: use device teardown to reattach device We have created a new mechanism for

Change in vdsm[master]: hostdev: move scsi device code to separate class

2016-07-21 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: hostdev: move scsi device code to separate class .. hostdev: move scsi device code to separate class We continue the effort of splitting the host

Change in vdsm[master]: hostdev: move pci device code to separate class

2016-07-21 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: hostdev: move pci device code to separate class .. hostdev: move pci device code to separate class At present, we use a single class to contain all

Change in vdsm[master]: hostdev: cleanup udev files after PCI host devices

2016-07-21 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: hostdev: cleanup udev files after PCI host devices .. hostdev: cleanup udev files after PCI host devices We have stopped reattaching PCI devices due

Change in vdsm[master]: network/sr-iov: use device teardown to reattach device

2016-07-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: network/sr-iov: use device teardown to reattach device .. Patch Set 6: Code-Review+2 (1 comment)

Change in vdsm[ovirt-3.6]: openstacknet hook: include after_vm_start hook in rpm

2016-07-20 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: openstacknet hook: include after_vm_start hook in rpm .. openstacknet hook: include after_vm_start hook in rpm commit a655be4 excluded an important

Change in vdsm[ovirt-3.6]: openstacknet hook: include after_vm_start hook in rpm

2016-07-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: openstacknet hook: include after_vm_start hook in rpm .. Patch Set 1: Code-Review+2 Verified+1 rpm builds, no code change vs. 4.0. -- To view, visit

Change in vdsm[master]: virt: drop legacy device config support

2016-07-20 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: drop legacy device config support .. virt: drop legacy device config support Drop the legacy Vm methods to rebuild specific device configuration

Change in vdsm[master]: virt: drop legacy device config support

2016-07-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: virt: drop legacy device config support .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60326 To unsubscribe, visit

Change in vdsm[master]: contrib: jsonrpc: add example script to run a VM

2016-07-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: contrib: jsonrpc: add example script to run a VM .. Patch Set 2: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/61047/2/contrib/runvm File

Change in vdsm[master]: vm: graphics: drop legacy graphics config support

2016-07-20 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: graphics: drop legacy graphics config support .. vm: graphics: drop legacy graphics config support Drop the legacy Vm methods to rebuild specific

Change in vdsm[master]: vm: graphics: drop legacy graphics config support

2016-07-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: graphics: drop legacy graphics config support .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60325 To unsubscribe, visit

Change in vdsm[master]: fix flag in contrib script

2016-07-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: fix flag in contrib script .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/61081 To unsubscribe, visit

Change in vdsm[master]: fix flag in contrib script

2016-07-20 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: fix flag in contrib script .. fix flag in contrib script Change-Id: I38e2b213fd1eace584bdb0705303560edb8c4a4e Signed-off-by: Yaniv Bronhaim

Change in vdsm[master]: hostdev: s/parse/process

2016-07-20 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: hostdev: s/parse/process .. hostdev: s/parse/process Hostdev library module uses term parse throughout it's libvirt XML processing code. As previous

Change in vdsm[master]: hostdev: prepare addition of per device processing

2016-07-20 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: hostdev: prepare addition of per device processing .. hostdev: prepare addition of per device processing We presently have one large function

Change in vdsm[master]: vdscli: Replace the default '::' host with hostname

2016-07-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdscli: Replace the default '::' host with hostname .. Patch Set 1: Code-Review-1 please fix the test -- To view, visit https://gerrit.ovirt.org/60020 To

Change in vdsm[ovirt-3.6]: openstacknet hook: include after_vm_start hook in rpm

2016-07-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: openstacknet hook: include after_vm_start hook in rpm .. Patch Set 1: Continuous-Integration+1 Unrelated 08:11:35 FAIL: testEnablePromisc

Change in vdsm[ovirt-3.6]: openstacknet hook: include after_vm_start hook in rpm

2016-07-20 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: openstacknet hook: include after_vm_start hook in rpm .. openstacknet hook: include after_vm_start hook in rpm commit a655be4 excluded an important piece of

Change in vdsm[ovirt-4.0]: openstacknet hook: include after_vm_start hook in rpm

2016-07-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: openstacknet hook: include after_vm_start hook in rpm .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60897 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: openstacknet hook: include after_vm_start hook in rpm

2016-07-20 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: openstacknet hook: include after_vm_start hook in rpm .. openstacknet hook: include after_vm_start hook in rpm commit a655be4 excluded an important

Change in vdsm[master]: utils: build cert paths in single place

2016-07-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: utils: build cert paths in single place .. Patch Set 11: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/52354/11/vdsm/sos/vdsm.py.in File

Change in vdsm[master]: contrib: Simple jsonrpc client

2016-07-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: contrib: Simple jsonrpc client .. Patch Set 16: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/35181/16/contrib/jsonrpc File contrib/jsonrpc: Line

Change in vdsm[master]: Rename execCmd and startCmd to run_cmd and start_cmd

2016-07-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Rename execCmd and startCmd to run_cmd and start_cmd .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/60280/2/vdsm/hooking.py File vdsm/hooking.py:

Change in vdsm[master]: Using startCmd func for running async execution

2016-07-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Using startCmd func for running async execution .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/60237/3/lib/vdsm/network/ipwrapper.py File

Change in vdsm[master]: Remove deathSignal usages in sync execCmd calls

2016-07-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Remove deathSignal usages in sync execCmd calls .. Remove deathSignal usages in sync execCmd calls Once moving to systemd, when vdsm dies all

Change in vdsm[master]: tox: Exclude .ropeproject from pep8 check

2016-07-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: tox: Exclude .ropeproject from pep8 check .. tox: Exclude .ropeproject from pep8 check pep8 breaks on files in .ropeproject, created by Python rope

Change in vdsm[master]: tox: Exclude .ropeproject from pep8 check

2016-07-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tox: Exclude .ropeproject from pep8 check .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/59677 To unsubscribe, visit

Change in vdsm[master]: tox: fail make process if required tox version isn't installed.

2016-07-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: tox: fail make process if required tox version isn't installed. .. tox: fail make process if required tox version isn't installed. Over RHEL 7.2 yum

Change in vdsm[master]: tox: fail make process if required tox version isn't installed.

2016-07-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tox: fail make process if required tox version isn't installed. .. Patch Set 21: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/59306 To

Change in vdsm[master]: vm: network: drop legacy network config support

2016-07-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: network: drop legacy network config support .. vm: network: drop legacy network config support Drop the legacy Vm methods to rebuild specific

Change in vdsm[master]: vm: graphics: drop legacy graphics config support

2016-07-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: graphics: drop legacy graphics config support .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60325 To unsubscribe, visit

Change in vdsm[master]: vm: storage: drop legacy drive config support

2016-07-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: storage: drop legacy drive config support .. vm: storage: drop legacy drive config support Drop the legacy Vm methods to rebuild specific drive

Change in vdsm[master]: vm: always expect Vm devices to be sent

2016-07-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: always expect Vm devices to be sent .. vm: always expect Vm devices to be sent Ancient (< 3.6) Engines used to send the device configuration data

Change in vdsm[master]: vm: network: drop legacy network config support

2016-07-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: network: drop legacy network config support .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60324 To unsubscribe, visit

Change in vdsm[master]: vm: always expect Vm devices to be sent

2016-07-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: always expect Vm devices to be sent .. Patch Set 7: Code-Review-1 this -1 just piggy-backs on this patch; the little script I'm requesting could very well

Change in vdsm[master]: vm: always expect Vm devices to be sent

2016-07-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: always expect Vm devices to be sent .. Patch Set 7: would you be kind to add a doc or better - a tiny virt test script that creates the simplest possible

Change in vdsm[master]: vm: graphics: drop legacy configuration support

2016-07-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: graphics: drop legacy configuration support .. vm: graphics: drop legacy configuration support We no longer need compatibility with ancient

Change in vdsm[master]: vm: graphics: drop legacy configuration support

2016-07-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: graphics: drop legacy configuration support .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60321 To unsubscribe, visit

Change in vdsm[master]: drop painfully ancient vmConf examples

2016-07-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: drop painfully ancient vmConf examples .. drop painfully ancient vmConf examples These examples are sorely out of date. tests/functional/virtTests.py

Change in vdsm[master]: vm: graphics: report display info from device

2016-07-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: graphics: report display info from device .. vm: graphics: report display info from device We used to keep the first graphic device information in

Change in vdsm[master]: drop painfully ancient vmConf examples

2016-07-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: drop painfully ancient vmConf examples .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/60894 To unsubscribe, visit

Change in vdsm[master]: vm: split device init from domDependentInit

2016-07-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: split device init from domDependentInit .. Patch Set 16: Code-Review+1 ack from me, but let's see if Polednik agrees. -- To view, visit

Change in vdsm[master]: vm: split vcpu settings from domDependentInit

2016-07-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: split vcpu settings from domDependentInit .. Patch Set 15: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/59813 To unsubscribe, visit

Change in vdsm[master]: vm: split vcpu settings from domDependentInit

2016-07-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: split vcpu settings from domDependentInit .. vm: split vcpu settings from domDependentInit Move into helper to modularize the

Change in vdsm[master]: vm: reorder sampling initialization

2016-07-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: reorder sampling initialization .. Patch Set 15: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/59815 To unsubscribe, visit

Change in vdsm[master]: vm: reorder sampling initialization

2016-07-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: reorder sampling initialization .. vm: reorder sampling initialization The sampling subsystem initialization is actually independent with respect

Change in vdsm[master]: tests: containers: add testsuite

2016-07-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tests: containers: add testsuite .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/60678/8/tests/containers/conttestlib.py File

Change in vdsm[master]: tests: Set vars/ssl to true in graphics tests

2016-07-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Set vars/ssl to true in graphics tests .. tests: Set vars/ssl to true in graphics tests In 8a7479c, support for graphics defaultMode was added

Change in vdsm[master]: network/sr-iov: use device teardown to reattach device

2016-07-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: network/sr-iov: use device teardown to reattach device .. Patch Set 6: Code-Review+1 The code seems fine, but I'd appreciate if mburman can confirm that no

Change in vdsm[master]: network/sr-iov: fix ambiguous log message

2016-07-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: network/sr-iov: fix ambiguous log message .. network/sr-iov: fix ambiguous log message The log message for detached device used self.device, which, in

Change in vdsm[master]: network/sr-iov: use setup in hotplug routine

2016-07-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: network/sr-iov: use setup in hotplug routine .. network/sr-iov: use setup in hotplug routine Setup is new preferred way of setting up a device.

Change in vdsm[ovirt-4.0]: openstacknet hook: include after_vm_start hook in rpm

2016-07-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: openstacknet hook: include after_vm_start hook in rpm .. Patch Set 3: Continuous-Integration+1 unrelated CI error: 06:03:13 Error: nothing provides

Change in vdsm[master]: openstacknet hook: include after_vm_start hook in rpm

2016-07-18 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: openstacknet hook: include after_vm_start hook in rpm .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60896 To unsubscribe, visit

Change in vdsm[master]: openstacknet hook: include after_vm_start hook in rpm

2016-07-18 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: openstacknet hook: include after_vm_start hook in rpm .. openstacknet hook: include after_vm_start hook in rpm commit a655be4 excluded an important

Change in vdsm[ovirt-4.0]: openstacknet hook: include after_vm_start hook in rpm

2016-07-18 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: openstacknet hook: include after_vm_start hook in rpm .. openstacknet hook: include after_vm_start hook in rpm commit a655be4 excluded an important piece of

Change in vdsm[master]: openstacknet hook: include after_vm_start hook in rpm

2016-07-18 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: openstacknet hook: include after_vm_start hook in rpm .. openstacknet hook: include after_vm_start hook in rpm commit a655be4 excluded an important piece of

Change in vdsm[master]: drop painfully ancient vmConf examples

2016-07-18 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: drop painfully ancient vmConf examples .. drop painfully ancient vmConf examples These examples are sorely out of date. tests/functional/virtTests.py maybe be

Change in vdsm[master]: virt net: Change graphics type from network to address

2016-07-18 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt net: Change graphics type from network to address .. virt net: Change graphics type from network to address This patch changes the graphics

Change in vdsm[master]: jsonrpcvdscli: added getAllTasksInfo verb

2016-07-18 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: jsonrpcvdscli: added getAllTasksInfo verb .. jsonrpcvdscli: added getAllTasksInfo verb getAllTasksInfo verb is needed by sos report Change-Id:

Change in vdsm[master]: sos report: removed call to vdsClient getVGList

2016-07-18 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: sos report: removed call to vdsClient getVGList .. sos report: removed call to vdsClient getVGList getVGList has been deprecated in patch

Change in vdsm[master]: vdscli: added DeprecationWarning to module

2016-07-18 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdscli: added DeprecationWarning to module .. Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60318 To unsubscribe, visit

Change in vdsm[master]: vdscli: added DeprecationWarning to module

2016-07-18 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdscli: added DeprecationWarning to module .. vdscli: added DeprecationWarning to module vdscli is deprecated and will be replaced soon by jsonrpccli.

Change in vdsm[master]: Adding python-setuptools to required ci packages

2016-07-17 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Adding python-setuptools to required ci packages .. Adding python-setuptools to required ci packages Over f24 we started to see the following error

Change in vdsm[master]: Adding python-setuptools to required ci packages

2016-07-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Adding python-setuptools to required ci packages .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60848 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: Adding python-setuptools to required ci packages

2016-07-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Adding python-setuptools to required ci packages .. Patch Set 3: seems unrelated? 11:51:52 ERROR: test_path_ok (storage_check_test.TestDirectioChecker)

Change in vdsm[master]: vm: graphics: report display info from device

2016-07-13 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: graphics: report display info from device .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60320 To unsubscribe, visit

Change in vdsm[master]: vmxml: move metadata handling into helpers

2016-07-13 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vmxml: move metadata handling into helpers .. vmxml: move metadata handling into helpers to make room for future users of the `metadata' section, we

Change in vdsm[master]: vmxml: metadata could be local variable

2016-07-12 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vmxml: metadata could be local variable .. vmxml: metadata could be local variable There is no need for `metadata' to be an instance variable, so this

Change in vdsm[ovirt-4.0]: build: enable vdsm-gluster build

2016-07-11 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: build: enable vdsm-gluster build .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60329 To unsubscribe, visit

Change in vdsm[master]: net: call address.flush explicitly after dhclient.kill

2016-07-10 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: call address.flush explicitly after dhclient.kill .. net: call address.flush explicitly after dhclient.kill Change-Id:

Change in vdsm[master]: net: call address.flush explicitly after dhclient.kill

2016-07-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: call address.flush explicitly after dhclient.kill .. Patch Set 2: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/60155 To unsubscribe,

Change in vdsm[master]: ovs hook: fix dhclient imports

2016-07-10 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: ovs hook: fix dhclient imports .. ovs hook: fix dhclient imports Change-Id: Ie13c017538750902713831bbcb07a30c885abd7d Signed-off-by: Petr Horáček

Change in vdsm[master]: net: add address.flush family argument

2016-07-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: add address.flush family argument .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60153 To unsubscribe, visit

Change in vdsm[master]: net: add address.flush family argument

2016-07-10 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: add address.flush family argument .. net: add address.flush family argument Add family argument to address.flush to be able to flush just IP

Change in vdsm[master]: qos: fix invalid dictionary iteration

2016-07-09 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: qos: fix invalid dictionary iteration .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60333 To unsubscribe, visit

Change in vdsm[master]: qos: fix invalid dictionary iteration

2016-07-09 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: qos: fix invalid dictionary iteration .. qos: fix invalid dictionary iteration `for x, y in dictionary` is not valid dictionary iteration. This bug

Change in vdsm[master]: build: enable vdsm-gluster build

2016-07-07 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: build: enable vdsm-gluster build .. Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/58605 To unsubscribe, visit

Change in vdsm[master]: fcoe hook: enable service

2016-07-07 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: fcoe hook: enable service .. fcoe hook: enable service When fcoe is requested, we should start fcoe and lldpad immediately, but also after next boot.

Change in vdsm[master]: vmxml: move metadata handling into helpers

2016-07-06 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vmxml: move metadata handling into helpers .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/57380 To unsubscribe, visit

Change in vdsm[master]: ovs hook: fix dhclient imports

2016-07-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: ovs hook: fix dhclient imports .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60154 To unsubscribe, visit

Change in vdsm[master]: utils: build cert paths in single place

2016-07-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: utils: build cert paths in single place .. Patch Set 7: (2 comments) (very partial review) https://gerrit.ovirt.org/#/c/52354/7/lib/vdsm/constants.py.in File

Change in vdsm[master]: contrib: Simple jsonrpc client

2016-07-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: contrib: Simple jsonrpc client .. Patch Set 11: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/35181/11/contrib/jsonrpc File contrib/jsonrpc: Line

Change in vdsm[master]: v2v: Log detailed output of virt-v2v

2016-07-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: v2v: Log detailed output of virt-v2v .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/59834/4//COMMIT_MSG Commit Message: Line 13: It would be

Change in vdsm[master]: build: enable vdsm-gluster build

2016-07-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: build: enable vdsm-gluster build .. Patch Set 8: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/58605/8/vdsm.spec.in File vdsm.spec.in: Line 238:

Change in vdsm[master]: net address: ignore not existing iface on flush

2016-07-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net address: ignore not existing iface on flush .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/59957/3/lib/vdsm/network/ip/address.py File

Change in vdsm[master]: automation: Increase timeout for make check

2016-07-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: automation: Increase timeout for make check .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/60051/1/automation/check-patch.sh File

Change in vdsm[master]: automation: Increase timeout for make check

2016-07-04 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: automation: Increase timeout for make check .. automation: Increase timeout for make check CI slaves are sometimes very slow. Increase the timeout to

Change in vdsm[master]: automation: Increase timeout for make check

2016-07-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: automation: Increase timeout for make check .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60051 To unsubscribe, visit

Change in vdsm[master]: net test: Use fake netlink data for testGetDeviceByIP

2016-07-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net test: Use fake netlink data for testGetDeviceByIP .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/59881 To unsubscribe, visit

Change in vdsm[master]: net test: Use fake netlink data for testGetDeviceByIP

2016-07-04 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: net test: Use fake netlink data for testGetDeviceByIP .. net test: Use fake netlink data for testGetDeviceByIP Change-Id:

<    5   6   7   8   9   10   11   12   13   14   >