Deepak C Shetty has posted comments on this change.
Change subject: glusterSD: BZ 988299: Deduce gluster volume name from domain
metadata
..
Patch Set 1:
(1 comment)
File v
Deepak C Shetty has posted comments on this change.
Change subject: glusterSD: BZ 988299: Deduce gluster volume name from domain
metadata
..
Patch Set 1: Verified+1
Since 2 addnl issues were reported in BZ 988299 recently, I a
Deepak C Shetty has uploaded a new change for review.
Change subject: glusterSD: BZ 988299: Deduce gluster volume name from domain
metadata
..
glusterSD: BZ 988299: Deduce gluster volume name from domain metadata
Gluster volume
Deepak C Shetty has posted comments on this change.
Change subject: gluster: Get size information of a gluster volume
..
Patch Set 5:
(1 comment)
Another option could be do a readonly mount in a hidden dir and do 'df -h'
when
Deepak C Shetty has posted comments on this change.
Change subject: Add transient disk support
..
Patch Set 2: Verified+1
Verified the hotplug and unplug flows. Also verified that VM isMIgratable
returns false as long as trans
Deepak C Shetty has posted comments on this change.
Change subject: gluster: Get size information of a gluster volume
..
Patch Set 5:
A general Q:
IF gfapi.py is used only to query the statvfs info... the same could be
don
Deepak C Shetty has posted comments on this change.
Change subject: gluster: Get size information of a gluster volume
..
Patch Set 5: Code-Review-1
(9 comments)
File client/
Deepak C Shetty has posted comments on this change.
Change subject: spec: remove shared glusterfs requirements
..
Patch Set 1: Code-Review+1
vdsm-gluster indeed requires 'vdsm' main pkg.. so I am fine with this.
--
To view, v
Deepak C Shetty has posted comments on this change.
Change subject: vdsm.spec: BZ 988299: Fix GlusterFS RPM dep to support
GlusterFS SD
..
Patch Set 1:
(1 comment)
File vds
Deepak C Shetty has posted comments on this change.
Change subject: vdsm.spec: BZ 988299: Fix GlusterFS RPM dep to support
GlusterFS SD
..
Patch Set 1:
(1 comment)
File vds
Deepak C Shetty has posted comments on this change.
Change subject: spec: remove shared glusterfs requirements
..
Patch Set 1:
When we use a node as a gluster node (not as hypervisor/vdsm) i think it will
only install vdsm-glu
Deepak C Shetty has posted comments on this change.
Change subject: Add support for transient disk
..
Patch Set 1:
(2 comments)
Yeah, i was not clear on what exactly to do to disable migration. Pls enlighten
me.
Deepak C Shetty has posted comments on this change.
Change subject: Add support for transient disk
..
Patch Set 1: Verified+1
1) create VM
2) take live snap
3) hotplug the snap to the VM (it should create a transient disk and
Deepak C Shetty has uploaded a new change for review.
Change subject: Add support for transient disk
..
Add support for transient disk
Add support for transient disk
Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524
Signed-o
Deepak C Shetty has abandoned this change.
Change subject: vdsm.spec: BZ 988299: Fix GlusterFS RPM dep to support
GlusterFS SD
..
Abandoned
This didnt land in ovirt-3.3 branch as i expected.
Since this change is already sent t
Deepak C Shetty has posted comments on this change.
Change subject: vdsm.spec: BZ 988299: Fix GlusterFS RPM dep to support
GlusterFS SD
..
Patch Set 1: Verified+1
Verified on F19
FYI: This patch same as master branch patch @
Deepak C Shetty has uploaded a new change for review.
Change subject: vdsm.spec: BZ 988299: Fix GlusterFS RPM dep to support
GlusterFS SD
..
vdsm.spec: BZ 988299: Fix GlusterFS RPM dep to support GlusterFS SD
This patch fixes t
Deepak C Shetty has posted comments on this change.
Change subject: vdsm.spec: BZ 988299: Fix GlusterFS RPM dep to support
GlusterFS SD
..
Patch Set 1: Verified+1
Verified on F19
--
To view, visit http://gerrit.ovirt.org/179
Deepak C Shetty has uploaded a new change for review.
Change subject: vdsm.spec: BZ 988299: Fix GlusterFS RPM dep to support
GlusterFS SD
..
vdsm.spec: BZ 988299: Fix GlusterFS RPM dep to support GlusterFS SD
This patch fixes t
Deepak C Shetty has posted comments on this change.
Change subject: image: add support to upload/download images
..
Patch Set 9: (1 inline comment)
File vdsm/storage/image.py
.
File lib/vdsm/utils.py
Line 230: A sample of host-related statistics.
Line 231:
Line 232: Contains the sate of the host in the time of initialization.
Line 233: """
Line 234: MONITORED_PATHS = ['/tmp', '/var/log', '/var/log/core']
[dpk
Deepak C Shetty has abandoned this change.
Change subject: storage: WIP: Add support for Storage Array management using
libstoragemgmt
..
Patch Set 1: Abandoned
Need to look at Cinder integration instead of libSM
--
To view,
Deepak C Shetty has posted comments on this change.
Change subject: WIP: storage: Introduce Image.exportAsBlockDevice vdsm verb
..
Patch Set 10: Verified
Fixes 2 issues:
1) qcow2.py failing due to CWD being incorrect
2) qcow2.p
Deepak C Shetty has posted comments on this change.
Change subject: WIP: storage: Introduce Image.removeAsBlockDevice vdsm verb
..
Patch Set 8: Verified
Fixes 2 issues:
1) qcow2.py failing due to CWD being incorrect
2) qcow2.py
Deepak C Shetty has posted comments on this change.
Change subject: vdsm-tool: service management work with previous systemd release
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerr
Deepak C Shetty has posted comments on this change.
Change subject: vdsm-tool: service management work with previous systemd release
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerr
Deepak C Shetty has posted comments on this change.
Change subject: vdsm-tool: service management work with previous systemd release
..
Patch Set 1: Verified
Verified on systemd-44-8.fc17.x86_64
--
To view, visit http://gerri
Deepak C Shetty has posted comments on this change.
Change subject: vdsm-tool: service management work with previous systemd release
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
..
Deepak C Shetty has posted comments on this change.
Change subject: WIP: storage: Introduce Image.removeAsBlockDevice vdsm verb
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/14919
To unsubscribe, visit htt
Deepak C Shetty has posted comments on this change.
Change subject: WIP: storage: Introduce Image.exportAsBlockDevice vdsm verb
..
Patch Set 9: Verified
Fixed jenkins pep8 issues
--
To view, visit http://gerrit.ovirt.org/1440
Deepak C Shetty has posted comments on this change.
Change subject: WIP: storage: Introduce Image.exportAsBlockDevice vdsm verb
..
Patch Set 8: Verified
Verified.
--
To view, visit http://gerrit.ovirt.org/14403
To unsubscribe
Deepak C Shetty has posted comments on this change.
Change subject: WIP: storage: Introduce Image.removeAsBlockDevice vdsm verb
..
Patch Set 6: Verified
Verified
--
To view, visit http://gerrit.ovirt.org/14919
To unsubscribe,
Deepak C Shetty has posted comments on this change.
Change subject: WIP: storage: Introduce Image.exportAsBlockDevice vdsm verb
..
Patch Set 7:
Another FIXME that i quoted in the code.. but wanted to put it here as
well...in t
Deepak C Shetty has posted comments on this change.
Change subject: WIP: storage: Introduce Image.removeAsBlockDevice vdsm verb
..
Patch Set 5: Verified
Verified, one small caveat tho'
had to manually set +x perms to the remove
Deepak C Shetty has posted comments on this change.
Change subject: WIP: storage: Introduce Image.exportAsBlockDevice vdsm verb
..
Patch Set 7: Verified
Verified, one small caveat tho'
had to manually set +x perms to the create
Deepak C Shetty has posted comments on this change.
Change subject: volume: add the BLOCK_SIZE constant
..
Patch Set 2:
For file domains atleast, since its mounted, we can use statfs to get the
blocksize, instead of hardcoding
Deepak C Shetty has posted comments on this change.
Change subject: Make IRS methods bypass API.py
..
Patch Set 7:
I agree with agl here... a better commit msg that clearly states the reason for
this would be helpful and appre
Deepak C Shetty has posted comments on this change.
Change subject: WIP: storage: Introduce removeNBDImage vdsm verb
..
Patch Set 4: Verified
Fixing Jenkins issue
Looks like some pep8 violations are not catched by vdsm build, b
Deepak C Shetty has posted comments on this change.
Change subject: WIP: storage: Introduce exportImageAsNBD vdsm verb
..
Patch Set 6: Verified
Fixing Jenkins issue
Looks like some pep8 violations are not catched by vdsm build,
Deepak C Shetty has posted comments on this change.
Change subject: WIP: storage: Introduce exportImageAsNBD vdsm verb
..
Patch Set 5: Verified
Verified
Addressed ayal and federico's comemnts
--
To view, visit http://gerrit.ov
Deepak C Shetty has posted comments on this change.
Change subject: WIP: storage: Introduce removeNBDImage vdsm verb
..
Patch Set 3: Verified
Verified
Addressed ayal and federico's comemnts
--
To view, visit http://gerrit.ovir
Deepak C Shetty has posted comments on this change.
Change subject: WIP: storage: Introduce prepareBackupDisk vdsm verb
..
Patch Set 4: (1 inline comment)
Added some Qs on how to return the export Disk info from hsm.py
...
Deepak C Shetty has posted comments on this change.
Change subject: WIP: storage: Introduce prepareBackupDisk vdsm verb
..
Patch Set 4: (15 inline comments)
File vdsm/API.py
Deepak C Shetty has posted comments on this change.
Change subject: WIP: storage: Introduce teardownBackupDisk vdsm verb
..
Patch Set 2: Verified
Was able to gracefully terminate the qemu-nbd process that was originally
runnin
Deepak C Shetty has posted comments on this change.
Change subject: WIP: storage: Introduce teardownBackupDisk vdsm verb
..
Patch Set 1: Verified
Was able to gracefully terminate the qemu-nbd process that was originally
runnin
Deepak C Shetty has posted comments on this change.
Change subject: WIP: storage: Introduce prepareBackupDisk vdsm verb
..
Patch Set 4: Verified
Was able to create a qemu-nbd process, serving the given volUUID over a unix
sock
Deepak C Shetty has uploaded a new change for review.
Change subject: WIP: storage: Introduce teardownBackupDisk vdsm verb
..
WIP: storage: Introduce teardownBackupDisk vdsm verb
This patch introduces teardownBackupDisk vdsm ver
Deepak C Shetty has posted comments on this change.
Change subject: WIP: Introduce prepareForBackup vdsm verb
..
Patch Set 3:
@MarkWu,
Re: 1) We use qemu-nbd so that in future when the backup appliance is hosted on
a physical
Deepak C Shetty has posted comments on this change.
Change subject: storage: Fix the case when VDSM host is not a gluster peer
..
Patch Set 2:
gluster/cli.py - no changes since the last patch
storage/glusterVolume.py - implemen
Deepak C Shetty has posted comments on this change.
Change subject: storage: Fix the case when VDSM host is not a gluster peer
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/14666
To unsubscribe, visit http:
Deepak C Shetty has abandoned this change.
Change subject: storage: Fix the case when VDSM host is not a gluster peer
..
Patch Set 1: Abandoned
squash with 14666
--
To view, visit http://gerrit.ovirt.org/14667
To unsubscribe,
Deepak C Shetty has posted comments on this change.
Change subject: storage: Fix the case when VDSM host is not a gluster peer
..
Patch Set 1:
Will squash this with 14666 per fsimonce's suggestion
hence abandoning this change
Deepak C Shetty has posted comments on this change.
Change subject: storage: Fix the case when VDSM host is not a gluster peer
..
Patch Set 1: (1 inline comment)
File vdsm/st
Deepak C Shetty has posted comments on this change.
Change subject: WIP: Introduce prepareForBackup vdsm verb
..
Patch Set 1: (1 inline comment)
File vdsm/storage/hsm.py
Line
Deepak C Shetty has uploaded a new change for review.
Change subject: gluster: Add support for --remote-host to volumeInfo API
..
gluster: Add support for --remote-host to volumeInfo API
Add support for --remote-host gluster cli
Deepak C Shetty has uploaded a new change for review.
Change subject: storage: Fix the case when VDSM host is not a gluster peer
..
storage: Fix the case when VDSM host is not a gluster peer
Currently when using glusterSD, VDSM
Deepak C Shetty has posted comments on this change.
Change subject: WIP: Introduce prepareForBackup vdsm verb
..
Patch Set 1: (2 inline comments)
File vdsm/storage/hsm.py
Lin
Deepak C Shetty has posted comments on this change.
Change subject: WIP: Introduce prepareForBackup vdsm verb
..
Patch Set 1:
@Vinenz, thanks for your review.. will look into it.
Any other comments you have on the patch ?
--
T
Deepak C Shetty has uploaded a new change for review.
Change subject: WIP: Introduce prepareForBackup vdsm verb
..
WIP: Introduce prepareForBackup vdsm verb
This patch introduces prepareForBackup vdsm verb which will export
the
Deepak C Shetty has uploaded a new change for review.
Change subject: storage: WIP: Add support for Storage Array management using
libstoragemgmt
..
storage: WIP: Add support for Storage Array management using libstoragemgmt
NO
Deepak C Shetty has posted comments on this change.
Change subject: domain: unify the createVolume method
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13329
To unsubs
Deepak C Shetty has posted comments on this change.
Change subject: Add 3.3. to clusterLevels
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13236
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerr
Deepak C Shetty has uploaded a new change for review.
Change subject: Add 3.3. to clusterLevels
..
Add 3.3. to clusterLevels
Add version 3.3. to clusterLevels, returned by VDSM as part
of engine calling getCapabilities. This all
Deepak C Shetty has posted comments on this change.
Change subject: Fix MountError exception handling in MountConnection.connect()
..
Patch Set 1: Looks good to me, but someone else must approve
Good catch, MarkWu.
--
To view,
Deepak C Shetty has posted comments on this change.
Change subject: [WIP] Add new repository management code
..
Patch Set 17: (3 inline comments)
Few Qs and suggestions.
Fil
Deepak C Shetty has posted comments on this change.
Change subject: Override getLocalPathBase in GlusterFSConnection
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12127
To unsubscribe, visit http://gerrit.o
Deepak C Shetty has posted comments on this change.
Change subject: Introduce getLocalPathBase for MountConnection
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12126
To unsubscribe, visit http://gerrit.ovi
Deepak C Shetty has uploaded a new change for review.
Change subject: Introduce getLocalPathBase for MountConnection
..
Introduce getLocalPathBase for MountConnection
Introduce getLocalPathBase in MountConnection so that
class r
Deepak C Shetty has uploaded a new change for review.
Change subject: Override getLocalPathBase in GlusterFSConnection
..
Override getLocalPathBase in GlusterFSConnection
Override getLocalPathBase in GlusterFSConnection as a bet
Deepak C Shetty has posted comments on this change.
Change subject: [WIP] Add new repository management code
..
Patch Set 16: (1 inline comment)
1 more Q, as i understand more of this :)
...
Deepak C Shetty has posted comments on this change.
Change subject: [WIP] Add new repository management code
..
Patch Set 16: (4 inline comments)
few Qs.
File vdsm/storage/i
Deepak C Shetty has posted comments on this change.
Change subject: Improve dom xml gereration
..
Patch Set 7: Looks good to me, but someone else must approve
@MarkWu,
I saw the class Drive specific changes for network disk
Deepak C Shetty has posted comments on this change.
Change subject: tests/functional: Add GlusterSD functional test
..
Patch Set 8: Verified
no changes from prev patchset.
--
To view, visit http://gerrit.ovirt.org/10196
To uns
Deepak C Shetty has posted comments on this change.
Change subject: tests/functional: Use deleteVolume instead of deleteImage
..
Patch Set 6: Verified
No changes from prev. patchset...
--
To view, visit http://gerrit.ovirt.org
Deepak C Shetty has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN
..
Patch Set 15: Verified
@Dan,
I hope to have addressed all your comments here. Thanks Deepak
--
To view, visit http://gerrit
Deepak C Shetty has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN
..
Patch Set 14: (1 inline comment)
@Dan,
pls see my comment
File vdsm/sto
Deepak C Shetty has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN
..
Patch Set 14: (2 inline comments)
@Dan,
Added few comments to yours. Pls let me know your thoughts, post which I
will send
Deepak C Shetty has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN
..
Patch Set 14: (4 inline comments)
@dan,
pls see my comments and let me know if I have understood you correctly ?
..
Deepak C Shetty has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN
..
Patch Set 14: (4 inline comments)
@Dan,
Responded to your comments. Pls take a look.
..
Deepak C Shetty has posted comments on this change.
Change subject: tests/functional: Add GlusterSD functional test
..
Patch Set 7: Verified
Same as last patch, except for the minor change suggested by Zheng.
--
To view, visit
Deepak C Shetty has posted comments on this change.
Change subject: tests/functional: Add GlusterSD functional test
..
Patch Set 6: (1 inline comment)
File tests/functional/x
Deepak C Shetty has posted comments on this change.
Change subject: tests/functional: Add GlusterSD functional test
..
Patch Set 6:
@ZhengSheng,
I checked with the gluster folks privately. They are awaiting general
availaib
Deepak C Shetty has posted comments on this change.
Change subject: tests/functional: Add GlusterSD functional test
..
Patch Set 6:
Addign steps/procedure to create and start a gluster volume named 'testvol' for
running this f
Deepak C Shetty has posted comments on this change.
Change subject: tests/functional: Add GlusterSD functional test
..
Patch Set 6: Verified
Addresed fsimonce's review comments. Also rebased and reworked the patch to
work on t
Deepak C Shetty has posted comments on this change.
Change subject: tests/functional: Use deleteVolume instead of deleteImage
..
Patch Set 5: Verified
No changes wrt prev patchset. Rebased and reposted, due to some error thrown
Deepak C Shetty has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN
..
Patch Set 14: Verified
address 1 minor comment from fsimonce.
Verified.
--
To view, visit http://gerrit.ovirt.org/6856
To unsu
Deepak C Shetty has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN
..
Patch Set 13: (2 inline comments)
File vdsm/storage/glusterSD.py
Line 18:
Deepak C Shetty has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN
..
Patch Set 13: (1 inline comment)
File vdsm/storage/glusterSD.py
Line 18:
Deepak C Shetty has posted comments on this change.
Change subject: Improve dom xml gereration
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10054
To unsubscribe, visi
Deepak C Shetty has posted comments on this change.
Change subject: Improve dom xml gereration
..
Patch Set 5: (1 inline comment)
File vdsm/libvirtvm.py
Line 643:
Line 644:
Deepak C Shetty has posted comments on this change.
Change subject: tests/functional: Add GlusterSD functional test
..
Patch Set 5: Verified
Addresed fsimonce's review comments.
Also rebased and reworked the patch to work on to
Deepak C Shetty has posted comments on this change.
Change subject: tests/functional: Use deleteVolume instead of deleteImage
..
Patch Set 4: Verified
No changes wrt prev patchset. Rebased and reposted.
--
To view, visit http:
Deepak C Shetty has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN
..
Patch Set 13: Verified
Addressed fsimonce's review comments. Verified
--
To view, visit http://gerrit.ovirt.org/6856
To unsubs
Deepak C Shetty has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN
..
Patch Set 12: (1 inline comment)
File vdsm/storage/volume.py
Line 868:
Deepak C Shetty has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN
..
Patch Set 12: (7 inline comments)
@fsimonce, addressed your comments and posted some replies. Thanks for the
comprehensive rev
Deepak C Shetty has posted comments on this change.
Change subject: tests/functional: Add GlusterSD functional test
..
Patch Set 4: (2 inline comments)
File tests/functional/
Deepak C Shetty has posted comments on this change.
Change subject: tests/functional: Add GlusterSD functional test
..
Patch Set 3: (1 inline comment)
File tests/functional/x
Deepak C Shetty has posted comments on this change.
Change subject: tests/functional: Add GlusterSD functional test
..
Patch Set 4: Verified
Added support to check for gluster service and volume status, if not correct,
test wi
Deepak C Shetty has posted comments on this change.
Change subject: tests/functional: Use deleteVolume instead of deleteImage
..
Patch Set 3: Verified
No change wrt prev patchset. Had to rebase the topic branch, hence new
patc
Deepak C Shetty has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN
..
Patch Set 12: Verified
No changes wrt prev. patchset
had to rebase the topic, hence this new patchset.
--
To view, visit http:
1 - 100 of 213 matches
Mail list logo
