Milan Zamazal has uploaded a new change for review.
Change subject: virt: Typo fix in Vm._acquireCpuLockWithTimeout error message
..
virt: Typo fix in Vm._acquireCpuLockWithTimeout error message
Change-Id:
Hello Nir Soffer, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/65108
to review the following change.
Change subject: virt: Make boolean values from boolean migration options
..
Milan Zamazal has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 1: Verified+1
Verified that migrations still work and that when Engine asks to migrate
Milan Zamazal has posted comments on this change.
Change subject: vm: a Down domain is not ready for commands
..
Patch Set 1: Code-Review+1
(4 comments)
https://gerrit.ovirt.org/#/c/65130/1//COMMIT_MSG
Commit Message:
PS1,
Milan Zamazal has posted comments on this change.
Change subject: vm: ignore more errors in isDomainReadyForCommands
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/65131/1//COMMIT_MSG
Commit Message:
PS1, Line 13:
Milan Zamazal has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 2: Verified+1
No code change since the last verification, so Jenkins is enough.
--
To
Milan Zamazal has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 2:
TODO added.
--
To view, visit https://gerrit.ovirt.org/65007
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: logging: Use same log format in the tests
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64216
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: supervdsm: expose systemd utilities
..
Patch Set 29:
Hm, do we really want to permit starting/stopping any service with those APIs?
For instance, why should it
Milan Zamazal has posted comments on this change.
Change subject: logging: Improve log level alignment
..
Patch Set 2:
(1 comment)
I like the change, let's just replace the reference in the commit message.
Milan Zamazal has posted comments on this change.
Change subject: logging: Document the secret TRACE log level
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64218
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: logging: Unify SimpleLogAdapter format
..
Patch Set 1:
(1 comment)
Except for the commit comment I support this change.
Milan Zamazal has posted comments on this change.
Change subject: virt: utils: add is_kvm helper
..
Patch Set 33: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55647
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: logging: More standard logging format
..
Patch Set 3: Code-Review+1
Thanks for putting module:lineno back. It's fine for me as it is now (as well
as if
Milan Zamazal has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 8:
(7 comments)
Thank you all for the comments and suggestions, I hope things get clarified and
we
Milan Zamazal has posted comments on this change.
Change subject: cmdutils: enhance systemd_run
..
Patch Set 29: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56474
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
..
Patch Set 16:
(2 comments)
https://gerrit.ovirt.org/#/c/60640/16/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Milan Zamazal has posted comments on this change.
Change subject: logging: Improve log level alignment
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64217
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: logging: Unify SimpleLogAdapter format
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64227
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: tests: sampling: add FakeClock helper
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62416
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/62873/2/vdsm/virt/migration.py
File
Milan Zamazal has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/62873/2/vdsm/virt/migration.py
File
Milan Zamazal has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/62873/2/vdsm/virt/migration.py
File
Milan Zamazal has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/62873/2/vdsm/virt/migration.py
File
Milan Zamazal has posted comments on this change.
Change subject: Using %{?_smp_mflags} for make calls
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/62163/2/vdsm.spec.in
File vdsm.spec.in:
Line 743: %endif
Line
Milan Zamazal has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 5:
Another safety check: Let's not crash on post-copy switch when it is in the
schedule but not
Milan Zamazal has posted comments on this change.
Change subject: api: Move getAllVmStats hooks and logging from API to clientIF
..
Patch Set 2:
No problem, I don't think we are in an urgent need of this patch so we can wait
Milan Zamazal has posted comments on this change.
Change subject: vmdisk hook: add support for booting from image file
..
Patch Set 7:
(3 comments)
https://gerrit.ovirt.org/#/c/58748/6/vdsm_hooks/vmdisk/before_vm_start.py
Milan Zamazal has posted comments on this change.
Change subject: migration: coalesce join() into stop()
..
Patch Set 3: Code-Review+1
Good idea.
--
To view, visit https://gerrit.ovirt.org/62587
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 4:
(2 comments)
I additionally disabled compression with post-copy due to the QEMU bug, in
order to
Hello Francesco Romani, Michal Skrivanek,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/64499
to review the following change.
Change subject: virt: Don't crash in migration progress on compression bytes
Milan Zamazal has posted comments on this change.
Change subject: virt: Typo fix in Vm._acquireCpuLockWithTimeout error message
..
Patch Set 6: Verified+1
Trivial change, Jenkins is enough.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: API: modernize VM methods
..
Patch Set 19: Code-Review+1
(2 comments)
https://gerrit.ovirt.org/#/c/61475/18/vdsm/API.py
File vdsm/API.py:
Line 125:
Line 126:
Milan Zamazal has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
..
Patch Set 17: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60640
To unsubscribe, visit
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Make boolean values from boolean migration options
..
virt: Make boolean values from boolean migration options
`compressed' and `autoConverge' migration
Milan Zamazal has posted comments on this change.
Change subject: virt: Don't crash in migration progress on compression bytes
..
Patch Set 2: Verified+1
Bug number added.
Verified that with this change the crash (KeyError)
Milan Zamazal has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 1:
> This is "just" about polishing the code or you hit a bug caused by this?
I wanted to
Milan Zamazal has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 1: Verified+1
Verified that with this change and "minimal downtime" migration policy
Milan Zamazal has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 7:
(3 comments)
https://gerrit.ovirt.org/#/c/62873/6/vdsm/virt/migration.py
File
Milan Zamazal has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 6:
(4 comments)
https://gerrit.ovirt.org/#/c/62873/6/vdsm/virt/migration.py
File
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Don't crash in migration progress on compression bytes
..
virt: Don't crash in migration progress on compression bytes
If compression is not enabled for
Milan Zamazal has posted comments on this change.
Change subject: API: modernize VM methods
..
Patch Set 18: Code-Review-1
(6 comments)
Nice change, but we should be careful and double check. I'm afraid there are
some
Milan Zamazal has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64515
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: lib: shorten name of libvirt event thread
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65501
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Refuse to cancel post-copy migrations
..
Patch Set 10:
> does libvirt guarantee that post-copy migration can't be aborted? It is
> documented behaviour
Milan Zamazal has posted comments on this change.
Change subject: vm: introduce a `monitorable' attribute
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65590
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: migration: use system thread names
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/65503/3/vdsm/virt/migration.py
File vdsm/virt/migration.py:
PS3,
Milan Zamazal has posted comments on this change.
Change subject: vm: introduce a `monitorable' attribute
..
Patch Set 2: Code-Review+1
(Except for the style check.)
--
To view, visit https://gerrit.ovirt.org/65590
To
Milan Zamazal has posted comments on this change.
Change subject: vm: introduce a `monitorable' attribute
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65590
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: rename statsAge parameter
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65508
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt.vmdevices.core: Add Lease device
..
Patch Set 4:
Looks fine to me so far.
--
To view, visit https://gerrit.ovirt.org/65465
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/65562/1/lib/vdsm/numa.py
File
Milan Zamazal has posted comments on this change.
Change subject: virt: Try to detect non guest iniated shutdowns
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64991
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: a Down domain is not ready for commands
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65130
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: ignore more errors in isDomainReadyForCommands
..
Patch Set 2: Code-Review+1
(2 comments)
https://gerrit.ovirt.org/#/c/65131/2//COMMIT_MSG
Commit Message:
Milan Zamazal has uploaded a new change for review.
Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
..
numa: Don't crash on hotplugged CPUs when retrieving NUMA info
getVmNumaNodeRuntimeInfo maps
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Use a variable for self._vm in MonitorThread action
handling
..
virt: Use a variable for self._vm in MonitorThread action handling
This is a
Milan Zamazal has posted comments on this change.
Change subject: virt: Use a variable for self._vm in MonitorThread action
handling
..
Patch Set 9:
Rebase + resolved conflicts.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Fetch only minimum VM stats during post-copy migration
..
Patch Set 9:
Simplified thanks to the refactorization in the initial patch.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Stop guest agent before switching to post-copy
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/64145/8/vdsm/virt/migration.py
File
Milan Zamazal has posted comments on this change.
Change subject: virt: Destroy VM after post-copy migration failure
..
Patch Set 8:
Just rebase + resolved conflicts.
--
To view, visit https://gerrit.ovirt.org/64142
To
Milan Zamazal has posted comments on this change.
Change subject: virt: Distinguish between switching to and entering post-copy
migration
..
Patch Set 8:
The PostCopyPhase idea implemented (and 3 states are enough actually).
Milan Zamazal has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 12:
I moved the migration switching and the post-copy flag to Vm as was suggested
in and as a
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Refuse to cancel post-copy migrations
..
virt: Refuse to cancel post-copy migrations
A VM in post-copy migration is split between the source and the
Milan Zamazal has posted comments on this change.
Change subject: virt: Prevent monitoring of VMs in post-copy
..
Patch Set 10:
Just rebase + updates.
--
To view, visit https://gerrit.ovirt.org/64146
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Refuse to cancel post-copy migrations
..
Patch Set 10:
The post-copy flag is set at the proper place now. No changes wrt. locking
itself.
--
To view,
Milan Zamazal has posted comments on this change.
Change subject: virt: Report paused VM status in post-copy
..
Patch Set 10:
Just rebase + updates.
--
To view, visit https://gerrit.ovirt.org/64147
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/65562/2/lib/vdsm/numa.py
File
Milan Zamazal has posted comments on this change.
Change subject: virt: Start all VM related stuff after switching to post-copy
migration
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/63551/8/vdsm/virt/vm.py
File
Milan Zamazal has posted comments on this change.
Change subject: virt: Distinguish between switching to and entering post-copy
migration
..
Patch Set 7:
(2 comments)
Thank you for the suggestion, I'll do it this way.
Milan Zamazal has posted comments on this change.
Change subject: virt: Refuse to cancel post-copy migrations
..
Patch Set 10:
According to libvirt developers, we can indeed rely on libvirt and aborting the
migration job
Milan Zamazal has posted comments on this change.
Change subject: vm: rename statsAge parameter
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65813
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: reformat setUnresponsiveIfTimeout
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65812
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: introduce a `monitorable' attribute
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65814
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: ignore more errors in isDomainReadyForCommands
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65131
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: check stats timeout only for monitorable VMs
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/65727/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Milan Zamazal has abandoned this change.
Change subject: virt: Prevent running stuck VM operations
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/59735
To unsubscribe, visit https://gerrit.ovirt.org/settings
Milan Zamazal has uploaded a new change for review.
Change subject: logging: Remove connectivity log
..
logging: Remove connectivity log
There is no known use or user of this log. So the log just
unnecessarily produces another
Milan Zamazal has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 9:
Any other suggestion besides renaming export_xml for the upcoming rebase?
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: reformat setUnresponsiveIfTimeout
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65504
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: rename statsAge parameter
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65508
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: reformat setUnresponsiveIfTimeout
..
Patch Set 8: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/65504/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Milan Zamazal has posted comments on this change.
Change subject: vm: rename statsAge parameter
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65508
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: vm: introduce a `monitorable' attribute
..
Patch Set 9: Code-Review+1
(3 comments)
I suggest polishing the comment, otherwise it looks fine.
Milan Zamazal has posted comments on this change.
Change subject: clientIF: rename recovery thread
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65502
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 1: Code-Review+1 Verified+1
Verified that migration still works and the options values are
Milan Zamazal has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/55769/9/vdsm/virt/domain_descriptor.py
File
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Make DomainDescriptor use XML helpers
..
virt: Make DomainDescriptor use XML helpers
We are going to stop using xml.dom.minidom and to use xml.etree
Milan Zamazal has posted comments on this change.
Change subject: [WIP] use libvirt domain xml prepared in advance
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/65182/2/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Milan Zamazal has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 9:
(10 comments)
I tried to address all the suggestions for improvements, so hopefully we can
move
Milan Zamazal has posted comments on this change.
Change subject: virt: Try to detect non guest iniated shutdowns
..
Patch Set 7: Code-Review+1
Maybe _shutdownLock is no longer necessary?
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: py3: let bulk_sampling_test pass under py3
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65006
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Stop guest agent before switching to post-copy
..
Patch Set 8:
I additionally disabled stopping the already stopped guest agent after
post-copy migration
Milan Zamazal has posted comments on this change.
Change subject: virt: Prevent monitoring of VMs in post-copy
..
Patch Set 9:
Test breakage fixed.
--
To view, visit https://gerrit.ovirt.org/64146
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: py3: let bulk_sampling_test pass under py3
..
Patch Set 2: Verified+1
Conditionally verified: It successfully passes over all the changed code parts
and I can
Milan Zamazal has posted comments on this change.
Change subject: virt: Inform Engine about switching to post-copy
..
Patch Set 9:
I added reporting pauseCode in the minimum stats.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 11:
We are now more careful with POSTCOPY migration flag.
--
To view, visit
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Destroy VM after post-copy migration failure
..
virt: Destroy VM after post-copy migration failure
As explained in the source code comment, we don't have
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Start all VM related stuff after switching to post-copy
migration
..
virt: Start all VM related stuff after switching to post-copy migration
On the
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Fetch only minimum VM stats during post-copy migration
..
virt: Fetch only minimum VM stats during post-copy migration
When a migration switches to
701 - 800 of 805 matches
Mail list logo
