Looks great, I'll commit it. Thanks for your work.
-Ken
On Sat, Jun 14, 2008 at 11:26 PM, Craig A. Berry <[EMAIL PROTECTED]> wrote:
> At 2:03 AM -0500 5/30/08, Ken Williams wrote:
> >On Thu, May 29, 2008 at 10:13 PM, Craig A. Berry
> ><[EMAIL PROTECTED]> wrote:
On Thu, May 29, 2008 at 10:13 PM, Craig A. Berry
<[EMAIL PROTECTED]> wrote:
> After doing some testing with my own revision of the third version of
> this patch against blead, I belatedly realized that much of it has
> already been applied to the development stream of Module::Build,
> available via
Hi all,
I created a branch of the M::B repo to hold the changes that appeared
in 5.10 but never made it to SVN (or didn't make it in time for the
0.2808_01 release):
http://svn.perl.org/modules/Module-Build/branches/perl-5.10/
Almost all the changes are in t/*.t files. The only *.pm file that
Hi,
File::Spec in the core (and to a lesser extent, Cwd) is now
significantly different from the CPAN release. A unified diff
between the core code and version 3.25_01 (with standard context) is
about 500 lines long, mostly because 3.25_01 was never integrated
into the core, but also bec
On Nov 24, 2007, at 6:04 PM, Craig A. Berry wrote:
I'll let John check on whether his Cwd change look good, but I see two
VMS -related patches to PathTools in blead that are not in your svn
repository:
http://public.activestate.com/cgi-bin/perlbrowse/p/31431
http://public.activestate.com/cgi-
On Nov 19, 2007, at 8:54 AM, John E. Malmberg wrote:
The Cwd.pm in blead is different than CPAN right now for VMS,
Actually I just compared, and it looks like the 3.25_01 release of
PathTools never got integrated into blead. Is that a desirable thing
to do? From my perspective it would
On 11/6/07, Craig A. Berry <[EMAIL PROTECTED]> wrote:
>
> I think you and I agreed that the is_vmsish property should remain an
> indication of what OS we are on and not get tangled up with what make
> utility is in use (though a separate property might well track that).
Yes, although I bet John's
On Nov 3, 2007, at 2:14 AM, John E. Malmberg wrote:
John E. Malmberg wrote:
The patches previously submitted have not yet been applied.
I have just applied them to the M::B repo. Is your subsequent patch
still good to go?
-Ken
On Oct 28, 2007, at 1:21 PM, John E. Malmberg wrote:
Craig A. Berry wrote:
On 10/27/07, John E. Malmberg <[EMAIL PROTECTED]> wrote:
In Module/Build.pm :
It is vmsish if OS is VMS and the make program is one of MMK or MMS.
That seems wrong to me because it assumes we'd only need to do some
On Sep 30, 2007, at 10:07 AM, Craig A. Berry wrote:
At 9:13 AM -0500 9/30/07, John E. Malmberg wrote:
Change _detildefy into a method and then provide a VMS override to
it.
Thanks, applied as 31999. I omitted the file_qr hunk that had
already gone in as 31998, and I converted some commen
On Sep 29, 2007, at 11:41 AM, Craig A. Berry wrote:
Obviously I consider the blead changes correct since I made them :-).
Sorry not to keep you up-to-date; I think I had a fantasy that I
would get all the M::B on VMS issues worked out and submit one big
patch, but even with John's help that has
S version of splitdir('[.foo]') returns '', 'foo'.
-
-=cut
-
-sub man3page_name {
- my $self = shift;
-
- my $mpname = $self->SUPER::man3page_name( shift );
- my $sep = $self->manpage_separator;
- $mpname =~ s/^$sep//;
- return $mpname;
-}
=item expand_test_d
On Sep 28, 2007, at 9:23 PM, Ken Williams wrote:
Also, the t/install.t patch caused some new failures so I haven't
applied that yet.
Actually the failures were just because I didn't notice the whole
patch didn't apply cleanly. Once I went in and hand-applied the
On Sep 28, 2007, at 8:55 AM, John E. Malmberg wrote:
Additional changes:
In Base.pm, created a subroutine to return the regex either as case
insensitive or case sensitive based on the setting for
File::Spec::case_tolerant.
Note in the existing code, one place assumes that the
File::Spe
On Sep 7, 2007, at 9:01 AM, Craig A. Berry wrote:
I think what we need to do instead is just get rid of that call. I
can't think of any reason Module::Build needs to do macro expansion
since it's not using an external make utility the way MakeMaker does.
I already have a patch in progress that
On Sep 2, 2007, at 5:23 PM, John E. Malmberg wrote:
While there are still some CPANPLUS tests that are not working on
VMS, these patches improve things.
Note that the tests require that the symbol "PERL" be set up as a
foreign command for the non-debug perl image from blead.
In lib/Modul
Thanks, I've applied this one too.
-Ken
On Sep 14, 2006, at 12:30 PM, Craig Berry wrote:
On 9/10/06, Ken Williams <[EMAIL PROTECTED]> wrote:
Awesome, thanks Craig! I've committed your patch verbatim.
Thanks, here's another little one. It accounts for the fact tha
Awesome, thanks Craig! I've committed your patch verbatim.
-Ken
On Sep 9, 2006, at 4:58 PM, Craig Berry wrote:
The attached patch against 2805_01 gets the failure rate to 9/21 on
VMS, down from something in the high teens. Obviously there's still a
lot of work to do, but this gets a lot of
On Apr 27, 2006, at 12:38 AM, Craig A. Berry wrote:
Sorry for the slow reply, but yes, this passes all the File::Spec
tests when dropped into a fairly recent bleadperl.
Thanks, I'll roll a release together then.
-Ken
On Apr 22, 2006, at 9:29 PM, Ken Williams wrote:
Hi,
I got a report of some VMS problems in File::Spec, and I put
together this patch relative to 3.17:
http://rt.cpan.org/Ticket/Display.html?id=18846
The OP for that issue made a correction, the new section in t/Spec.t
should be
On Apr 22, 2006, at 11:59 PM, John E. Malmberg wrote:
Ken Williams wrote:
Hi,
I got a report of some VMS problems in File::Spec, and I put
together this patch relative to 3.17:
http://rt.cpan.org/Ticket/Display.html?id=18846
Could someone on VMS check it out? Thanks.
I will see if I
Hi,
I got a report of some VMS problems in File::Spec, and I put together
this patch relative to 3.17:
http://rt.cpan.org/Ticket/Display.html?id=18846
Could someone on VMS check it out? Thanks.
-Ken
patch
Description: Binary data
On Mar 25, 2006, at 10:04 AM, John E. Malmberg wrote:
Ken Williams wrote:
On Mar 24, 2006, at 9:29 PM, John E. Malmberg wrote:
Both lib/ExtUtils/CBuilder/t/01-basic.t and lib/ExtUtils/CBuilder/
t/ 02-link both pass with that.
Cool - then I assume this small rewrite of that method also
On Mar 24, 2006, at 9:29 PM, John E. Malmberg wrote:
Both lib/ExtUtils/CBuilder/t/01-basic.t and lib/ExtUtils/CBuilder/t/
02-link both pass with that.
Cool - then I assume this small rewrite of that method also makes
things pass?
-
sub arg_d
On Mar 24, 2006, at 6:56 PM, John E. Malmberg wrote:
Ken Williams wrote:
Hi Craig,
What's status look like now, with these changes?
[...] VMS does not support the list form of piped input, so some of
the tests that were passing are no longer passing.
How annoying. I was going o
Hi Craig,
I've applied a modified version of your patch, which I've attached.
It creates a new method, _backticks(), which will avoid shell-quoting
issues completely, when possible. I also deleted your change in
run_perl_command() because it didn't look quite right.
What's status look l
Thanks, Craig.
Rather than keeping an %args hash and a $config_defines string
separately, it would seem simpler to
On Mar 15, 2006, at 6:57 AM, Craig A. Berry wrote:
At 10:59 PM -0500 3/14/06, John E. Malmberg wrote:
is an update Craig's patch to handle the cases where there are no
defin
On Mar 13, 2006, at 5:12 PM, Craig Berry wrote:
On Monday, March 13, 2006, at 04:06PM, Ken Williams
<[EMAIL PROTECTED]> wrote:
BTW, is there a regression test that could have exposed this issue?
-Ken
It did show up in a number of the Module::Build failures, such as
xs.t. An
BTW, is there a regression test that could have exposed this issue?
-Ken
On Mar 12, 2006, at 7:37 PM, Ken Williams wrote:
Thanks Craig. Yup, CBuilder is separately maintained, the nexus
for development is often the Module::Build list.
I'll apply this patch and make a new release.
Thanks Craig. Yup, CBuilder is separately maintained, the nexus for
development is often the Module::Build list.
I'll apply this patch and make a new release.
-Ken
On Mar 12, 2006, at 6:01 PM, Craig A. Berry wrote:
The attached provides the special handling needed for C compiler
defines
On Feb 9, 2006, at 4:20 PM, Steven Lembark wrote:
Perhaps I'm misunderstanding something, but I can't see how an empty
volume name could ever indicate an absolute path.
Because on *NIX you can
join '/', @subdirz;
and get a leading '/'.
That's true, but the confusion here is my fault
On Feb 9, 2006, at 1:43 PM, Craig A. Berry wrote:
At 9:56 PM -0600 2/8/06, Ken Williams wrote:
Hi Steven,
On VMS is 'USER:[SLEMBARK.FINDBIN-LIBS-1_20]' an absolute path, i.e.
is the SLEMBARK directory understood to be at the root of the USER
volume?
Yes. You would not see
Hi Steven,
On VMS is 'USER:[SLEMBARK.FINDBIN-LIBS-1_20]' an absolute path, i.e. is
the SLEMBARK directory understood to be at the root of the USER volume?
If so, probably splitpath() is actually returning the wrong result.
On other platforms it returns an initial empty string to indicate an
On Feb 5, 2006, at 10:18 PM, Yitzchak Scott-Thoennes wrote:
Ken, do you have any problem with bundling Tie::CPHash in
Module::Build under t/bundled? The .pm file is just 5k.
Alternatively, it could be a build prerequisite, but I'm guessing
you'd rather not do that.
Sure, bundling in t/bundle
On Jan 26, 2006, at 11:45 AM, Craig A. Berry wrote:
The pathname is ok. The test can't find it because it really doesn't
exist because it got deleted by DistGen->clean(), which doesn't
recognize it as one of the directories in its cache of directory
names. The basic issues revolve around VMS f
On Jan 26, 2006, at 11:45 AM, Craig A. Berry wrote:
The pathname is ok. The test can't find it because it really doesn't
exist because it got deleted by DistGen->clean(), which doesn't
recognize it as one of the directories in its cache of directory
names. The basic issues revolve around VMS
On Dec 6, 2005, at 11:46 AM, John E. Malmberg wrote:
Ken Williams wrote:
Hi John,
Thanks for the patch, I've applied it. Could I trouble you to also
add a few tests to Spec.t to exercise these dead bugs?
Someone already did with a recent change to Spec.t, which made them
show
Hi John,
Thanks for the patch, I've applied it. Could I trouble you to also add
a few tests to Spec.t to exercise these dead bugs?
Thanks,
-Ken
On Dec 5, 2005, at 9:39 PM, John E. Malmberg wrote:
In abs2rel() fix handling of directory trees so that the test $file =
File::Spec::VMS->ab
On Sep 13, 2005, at 7:53 PM, John E. Malmberg wrote:
Ken Williams wrote:
On Sep 12, 2005, at 11:12 PM, John E. Malmberg wrote:
Ken Williams wrote:
Thanks, John. I've applied your patch (in a slightly modified
form) and released a new beta, 0.13_01. It would be great if you
(and
On Sep 12, 2005, at 11:12 PM, John E. Malmberg wrote:
Ken Williams wrote:
Thanks, John. I've applied your patch (in a slightly modified form)
and released a new beta, 0.13_01. It would be great if you (and/or a
couple other people on the vmsperl list) could try it out, and then I
s" were as capable as you. ;-)
On Sep 10, 2005, at 11:24 PM, John E. Malmberg wrote:
John E. Malmberg wrote:
Ken Williams wrote:
Hi John,
After my last email I reworked the patch so that all the
modifications are in Platform/VMS.pm. Could you confirm that it
still works for you and I ha
Hi John,
After my last email I reworked the patch so that all the modifications
are in Platform/VMS.pm. Could you confirm that it still works for you
and I haven't broken it?
Thanks,
-Ken
Index: lib/ExtUtils/CBuilder/Platform/VMS.pm
==
Hi John,
Thanks for the patch. A couple questions:
1) I see both /include and /Include specified in various places in the
source. Should your s/// be case-insensitive?
2) Would it be more appropriate to fold the include-dirs from ccflags
into the user-specified ones, rather than throwing t
I don't understand - where are those tests? They're not part of
PathTools' distribution. Also, how are you sure that these failures
are caused by PathTools and not some other code?
-Ken
On Mar 16, 2005, at 6:45 PM, Michael G Schwern wrote:
Its always good to CC the module author in on these s
On Mar 14, 2005, at 3:55 PM, [EMAIL PROTECTED] wrote:
Hmm - well I suppose I should mention a few tricky aspects
of using MCR on VMS.
[snip]
Thanks for letting me know. I'll make sure I'm careful with it. =)
I released a non-beta version of ExtUtils::CBuilder that should contain
all the patches n
On Mar 14, 2005, at 1:30 PM, [EMAIL PROTECTED] wrote:
OK that one is much close to what I thought you were aiming at :-)
It turns out there was an override typo in VMS.pm and t/02-link.t
was left as is.
Oops! That was me forgetting to apply the 02-link.t part of the patch.
This time around I have
On Mar 12, 2005, at 7:18 PM, Ken Williams wrote:
Excellent. I just have one question, then, about the following line:
my @lddlflags = $args{lddl} ? ($cf->{lddlflags}."=$out") :
("/exe=$out");
What is the original value of $cf->{lddlflags} such that it makes
sense to
On Mar 10, 2005, at 3:06 PM, [EMAIL PROTECTED] wrote:
Ken Williams <[EMAIL PROTECTED]> wrote on 03/06/2005 10:50:17 AM:
Care to try 0.09_01, which is now hitting CPAN? I've split out the
generation of command-line switches so it can easily be overridden for
VMS. So compile() mig
Any takers on this? Ping?
-Ken
On Mar 6, 2005, at 9:50 AM, Ken Williams wrote:
On Mar 4, 2005, at 6:39 PM, [EMAIL PROTECTED] wrote:
Yes the -foo switches have caused trouble.
[snip]
Er, sorry at this time I do not have a patch :-)
Care to try 0.09_01, which is now hitting CPAN? I've spli
On Mar 4, 2005, at 6:39 PM, [EMAIL PROTECTED] wrote:
Yes the -foo switches have caused trouble.
[snip]
Er, sorry at this time I do not have a patch :-)
Care to try 0.09_01, which is now hitting CPAN? I've split out the
generation of command-line switches so it can easily be overridden for
VMS.
Thanks. I've applied the patch.
-Ken
On Nov 18, 2004, at 7:05 PM, Craig A. Berry wrote:
There is a canonpath case where we reduce redundant directories down to
nothing but should instead reduce them to the magical six zeros root
directory. There have been two different definitions of "nothing" in
ke it correctly identify directories that exist in the
local filesystem or end with a '/'. This applies on top of the previous
patch.
Ken Williams wrote:
I'm releasing this as 0.89 right now. I hope to release the
consolidated File::Spec and Cwd distribution soon too.
Has the following m
Thanks, Craig.
I'm releasing this as 0.89 right now. I hope to release the
consolidated File::Spec and Cwd distribution soon too.
-Ken
On Aug 27, 2004, at 6:51 PM, Craig A. Berry wrote:
Richard Levitte recently reported on vmsperl a number of pathological
cases that break the current implement
On Saturday, March 29, 2003, at 09:38 PM, Michael G Schwern wrote:
The attached patch gets Module::Build working on VMS. Its dead simple
and
resolves three issues:
- You can't safely put switches after $Config{startperl}
- The comfortable VMS equivalent to ./Build is @Build which means
Build.
On Wednesday, November 20, 2002, at 06:56 PM, Craig A. Berry wrote:
At 5:27 PM +1100 11/20/02, Ken Williams wrote:
On Wednesday, November 20, 2002, at 04:06 PM, Michael G
Schwern wrote:
2.) my($key) forces list context but the result of a match can
only be
stored in a scalar lvalue
3.) The
On Wednesday, November 20, 2002, at 04:06 PM, Michael G Schwern wrote:
2.) my($key) forces list context but the result of a match can only be
stored in a scalar lvalue
3.) The result of a match is just a boolean, not the thing matched, so
$key would never have the unadorned macro name but that s
On Tuesday, April 23, 2002, at 03:55 PM, Craig A. Berry wrote:
> At 9:17 PM -0400 4/22/02, Michael G Schwern wrote:
>> Think this should do it.
> [added /m to regex]
>
> Nope. I think you need something more like the following. At
> least it works for me:
You didn't see the ^ at the beginnin
57 matches
Mail list logo
