Re: [webkit-dev] DOM tree vs. Render tree

On Jun 16, 2011, at 7:21 AM, song.7@nokia.com wrote: > Could some share what’s the design consideration about the DOM tree and > Render tree separation? CSS styling makes it easy for almost any DOM node to render as almost anything. To give one trivial example, a paragraph element can be tu

Re: [webkit-dev] Expected behavior of "scrolling" attribute for IFrame element

On Jun 13, 2011, at 11:05 AM, Ojan Vafai wrote: > On Mon, Jun 13, 2011 at 10:51 AM, Darin Adler wrote: >> Even though we need to prevent find or autoscrolling from scrolling, it >> seems we must not prevent explicit programmatic scrolling. I’ll add a >> comment

Re: [webkit-dev] Adding ENABLE_FLEXBOX to WebCore

On Jun 13, 2011, at 10:52 AM, Darin Fisher wrote: > On Mon, Jun 13, 2011 at 10:50 AM, Simon Fraser wrote: > >> Using terms like 'new' in code is rarely a good idea. In a year, the context >> has gone, and 'new' no longer means anything. > > Good point! Maybe we can use a term that is derived f

Re: [webkit-dev] Expected behavior of "scrolling" attribute for IFrame element

On Jun 13, 2011, at 10:49 AM, Simon Fraser wrote: > On Jun 13, 2011, at 8:30 AM, Darin Adler wrote: > >> As I understand it, generally speaking, if we have something like a find >> feature or autoscrolling code that scrolls outside the normal mechanism, it >> still s

Re: [webkit-dev] Expected behavior of "scrolling" attribute for IFrame element

HTML5 defines this scrolling attribute. It defines it in terms of a CSS overflow property on the frame below. The value scrolling="no" turns into overflow: hidden. Such overflow areas should not be scrolled. As I understand it, generally speaking, if we have something like a find feature or aut

Re: [webkit-dev] bugs.webkit.org UI housekeeping

On Jun 12, 2011, at 8:10 PM, Ojan Vafai wrote: > On Sun, Jun 12, 2011 at 1:30 PM, Adam Barth wrote: > >> Does anyone click the "Preview" button? If not, we should probably remove >> it. I often use the Preview button to look over my individual comments and decide whether review+ or review- i

Re: [webkit-dev] Do we have a style preference about const member functions?

On Jun 8, 2011, at 11:56 AM, Peter Kasting wrote: > What I thought Maciej was saying was that we should remove "const" on all the > existing accessors, in both categories, which sounded different than what you > were saying (which I read as "remove const on the accessors in the first > category

Re: [webkit-dev] Do we have a style preference about const member functions?

On Jun 8, 2011, at 11:48 AM, Peter Kasting wrote: > On Tue, Jun 7, 2011 at 11:18 PM, Maciej Stachowiak wrote: >> 1) We definitely have consensus to fix the broken non-logically-const >> accessors by making them non-const; consensus on also adding const accessors >> is less clear. > > There are

Re: [webkit-dev] Do we have a style preference about const member functions?

I think the “make some things non-const” part of this would be the first part to put up for review and land. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Do we have a style preference about const member functions?

On Jun 3, 2011, at 5:46 PM, Peter Kasting wrote: > From the perspective of Node itself, I'm not sure why this would be a "big > task". There shouldn't be any const accessors that return non-const pointers. > Simply removing the "const" qualifier on all the above accessors would make > things co

Re: [webkit-dev] Do we have a style preference about const member functions?

On Jun 3, 2011, at 9:28 AM, Maciej Stachowiak wrote: > On Jun 3, 2011, at 7:50 AM, Darin Adler wrote: > >> On Jun 2, 2011, at 1:32 AM, Ryosuke Niwa wrote: >> >>> All functions passed to enclosingNodeOfType in htmlediting.cpp are such >>> clients: >

Re: [webkit-dev] Do we have a style preference about const member functions?

On Jun 2, 2011, at 1:32 AM, Ryosuke Niwa wrote: > All functions passed to enclosingNodeOfType in htmlediting.cpp are such > clients: > > Node* enclosingNodeOfType(const Position& p, bool (*nodeIsOfType)(const > Node*), EditingBoundaryCrossingRule rule) > > It takes a boolean function that take

Re: [webkit-dev] Issue Analysis:48290 [HTML Canvas globalCompositeOperation]

On Jun 1, 2011, at 10:14 AM, Mustafizur Rahaman wrote: > Therefore, we submitted another patch where we are returning from the canvas > code itself if the compositing mode is "highlight". That’s not a good idea. We should keep looking into the real fix; that kind of hack is unneeded here. > Si

Re: [webkit-dev] Issue Analysis:48290 [HTML Canvas globalCompositeOperation]

On May 31, 2011, at 11:49 PM, Karthik wrote: > However, the following comment was mentioned in GraphicsType.h ("// Note: > These constants exactly match the NSCompositeOperator constants of // AppKit > on Mac OS X Tiger. If these ever change, we'll need to change the // Mac OS X > Tiger pla

Re: [webkit-dev] Do we have a style preference about const member functions?

On May 28, 2011, at 5:15 PM, Geoffrey Garen wrote: > This came up in https://bugs.webkit.org/show_bug.cgi?id=59604. > > My personal preference is against const member functions because they force > many error-prone code changes: introducing a const forces the transitive > closure of all potenti

Re: [webkit-dev] Early deletion of DocumentLoader instances

On May 26, 2011, at 9:52 AM, Adam Barth wrote: > The original reason why I was excited about changing to locating the > DocumentLoader via the Document was to avoid confusing where the Frame now > contains a different active DocumentLoader. Sure, that will be great eventually; I think a documen

Re: [webkit-dev] Early deletion of DocumentLoader instances

On May 24, 2011, at 6:56 AM, Raphael Kubo da Costa wrote: > Darin Adler writes: > >> Also, there is a Document::setDocumentLoader function, but nobody ever calls >> it. > > I could submit a patch to remove it, if that's desirable. Yes, we do want to remove it.

Re: [webkit-dev] Early deletion of DocumentLoader instances

On May 23, 2011, at 1:34 PM, Raphael Kubo da Costa wrote: > While working on the EFL port, I've noticed that sometimes a FrameLoader's > DocumentLoader ends up being deleted too early > (FrameLoader::setDocumentLoader causes the current DocumentLoader to be > deref'ed and freed), in the sense th

Re: [webkit-dev] Odd behavior with instrumentation of WebKit

On May 17, 2011, at 9:03 AM, Gregor Richards wrote: > In the uninstrumented branch (both JIT and interpreter), the lastIndexOf > property of Array.prototype (which we set) is marked as enumerable, so a > for...in loop outputs it. That sounds like a bug. You should file a bug report with the tes

Re: [webkit-dev] JSC bindings in the Qt bridge

On May 15, 2011, at 3:33 AM, Benjamin Poulain wrote: >> If during the conversion people find any short comings in the JSC API that's >> useful too, as it's likely that those problems would impact other users of >> the JSC API and we would welcome bugs being filed on those them (CC'ing me >> :)

Re: [webkit-dev] Why is gtest in the Source directory?

On May 12, 2011, at 11:33 AM, David Levin wrote: > Layout/ # Would be nice to have a better name since these test much > more than Layout > > DumpRenderTreeTests? > Integration? > AutomatedHtmlTests? Here are some characteristics of these tests that may help us name the directory: 1) Thi

Re: [webkit-dev] Dropping support for WML?

On Apr 8, 2011, at 2:09 AM, Ryosuke Niwa wrote: > Are there are other folks who are actively using WML? I realized that I pushed us off topic a little and wanted to remind everyone of the real point of this thread. Ryosuke specifically said he wants to get the data about who is using WML. So pl

Re: [webkit-dev] Dropping support for WML?

On Apr 8, 2011, at 2:09 AM, Ryosuke Niwa wrote: > We have been discussing the possibility of dropping WML support in WebKit on > IRC for a while now because > • None of core ports (Mac, Windows, GTK, Qt, & Chromium) use it by > default > • Maintenance cost is high I’ll just add one

[webkit-dev] Why I won’t be reviewing patches as much the next two weeks

I’ll be on vacation and mostly away from my email and computers for two weeks starting tomorrow. I wanted to mention this to the WebKit community so you understand why I’m not doing patch review for a while! -- Darin ___ webkit-dev mailing list we

Re: [webkit-dev] Canvas backing resolution

On Apr 5, 2011, at 9:52 PM, Charles Pritchard wrote: > Long-story-short, can we please expose some of the CSS pixel scaling, either > through window.devicePixelRatio I typed javascript:alert(devicePixelRatio) in Safari on my iPhone 4, and got the value 2. Isn’t this what you are asking for?

Re: [webkit-dev] Resource Cache in WebKit2

WebKit2 has only one web process at this time. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] embedding pixel result checksum in the png

Sounds like a great idea, as long as reading the checksum is still fast. I couldn’t tell when you mentioned run-webkit-tests in your steps what your specific plans are for old-run-webkit-tests and new-run-webkit-tests. -- Darin ___ webkit-dev mail

Re: [webkit-dev] Use of -webkit- prefix on CSS Values and Properties

On Mar 27, 2011, at 10:37 AM, Dan Bernstein wrote: > I think Eric is not asking about the unicode-bidi property, but rather about > the isolate value, which is not in CSS 2.1. I don’t know that there’s a > guideline, but there is precedent for prefixing values (for example, display: > box and d

Re: [webkit-dev] bugid in ChangeLog

On Mar 28, 2011, at 10:44 AM, Jeremy Orlow wrote: > If the issue is simply one of overhead, then we should allow committers to > omit change logs when they're not necessary as well. Sure I am open to discussion about that. I think that some check-ins, especially LayoutTest ones, don’t need chan

Re: [webkit-dev] bugid in ChangeLog

On Mar 28, 2011, at 9:59 AM, Antonio Gomes wrote: > Darin, could you explain your reasons? I think the burden for supplying a reason goes in the other direction, on people who want to require a bug for each check-in. Generally speaking, I want to keep paperwork and overhead to a minimum. We re

Re: [webkit-dev] bugid in ChangeLog

On Mar 27, 2011, at 1:31 AM, Jeremy Orlow wrote: > I'd even go a bit further and say that if something is worth a review (even > if it's over the shoulder), it's worth a bug + a bug number. This is where I do not agree. Review is a requirement, but I don’t think bugs.webkit.org should be.

Re: [webkit-dev] bugid in ChangeLog

On Mar 26, 2011, at 3:24 AM, Patrick Gansterer wrote: > Sometimes folks commit changes without bug numbers. If those changes breaks > things it's hard to find the correct context for the change. > Can we make the bug number a requirement for a commit when it has a > corresponding bug? > IMHO it

Re: [webkit-dev] JavaJSObject vs JSObject

On Mar 21, 2011, at 4:48 PM, Per Bothner wrote: > Some Googling found references to webkit_web_frame_get_global_context() and > WebFrame::globalContext() but I didn't find these - maybe they're > Cacoa-specific? webkit_web_frame_get_global_context is a GTK WebKit call. I think WebFrame::globalC

Re: [webkit-dev] JavaJSObject vs JSObject

On Mar 21, 2011, at 3:03 PM, Per Bothner wrote: > So I've implemented (a subclass of) netscape.javascript.JSObject to wrap > JavaScript objects as java Objects. I've got the essentials working, helped > by looking at code in jni_jsobject.mm and JNIUtilityPrivate.cpp. New code to do this should

Re: [webkit-dev] SearchBox API

On Mar 20, 2011, at 4:27 PM, Darin Adler wrote: > On Mar 20, 2011, at 4:23 PM, Adam Barth wrote: > >> When implemented by the embedder, the SearchBox API can't really make use of >> all the event-related machinery in WebCore. > > Lets see if we can export a clean

Re: [webkit-dev] SearchBox API

On Mar 20, 2011, at 4:23 PM, Adam Barth wrote: > When implemented by the embedder, the SearchBox API can't really make use of > all the event-related machinery in WebCore. Lets see if we can export a clean way to do that. It may be too late for SearchBox, but perhaps not for future similar thin

Re: [webkit-dev] SearchBox API

On Mar 19, 2011, at 10:10 AM, Adam Barth wrote: > Sorry to resurrect this old thread, but what are the DOM APIs in Safari that > are accessible only to search providers? Two functions on the window object, getSearchEngine and setSearchEngine. They take and return strings that are the names of s

Re: [webkit-dev] Odd behavior with instrumentation of WebKit

On Mar 15, 2011, at 8:16 AM, Gregor Richards wrote: > We maintain an instrumented branch of WebKit to do various dynamic > measurements of JavaScript. One of our changes which should have no semantic > effect on the behavior of JS is actually causing a visible change in the > behavior of (at le

Re: [webkit-dev] Background-image problems in iOS 4.3

This is not the right mailing list for discussion of how to use WebKit or work around bugs. This mailing list is for people involved in the development of WebKit to work together. For an iOS-specific issue I suggest iOS-specific resources. Or you could ask on webkit-help. See

Re: [webkit-dev] process for unreviewed commits

On Mar 3, 2011, at 11:58 PM, Ojan Vafai wrote: > The "Unreviewed" bit is news to me. I thought it was assumed that if there's > no "Reviewed By..." line then it was committed unreviewed and, in fact, that > was preferred to adding the "Unreviewed" line. Yes, this is how I understood it too.

Re: [webkit-dev] Is this a possible source of test flakiness?

I misread this and thought it was the unload attribute on the body element, not an iframe element. My answer was completely wrong for an iframe element! -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailm

Re: [webkit-dev] Is this a possible source of test flakiness?

On Feb 20, 2011, at 8:19 PM, Xianzhu Wang wrote: > My question is: Is this kind of usage (referencing a later-defined function > in onload event handler) correct in theory? Yes. The contents of the onload attribute don’t matter until the load event fires, which is after the script element has

Re: [webkit-dev] Web Inspector blog post draft

On Feb 15, 2011, at 8:05 AM, Alexander Pavlov wrote: > A few edits have been applied to the text (thanks to everyone who > contributed!) > > What is the official approval process for the Webkit blog posts? Should I > mark it as "Pending Review"? I don’t think we have any approval process. You

Re: [webkit-dev] Which MIME type is best for JavaScript in WebKit?

On Feb 12, 2011, at 3:36 PM, Eric Seidel wrote: > And I think I've fixed it by resetting my launch services. What does that mean, precisely? I’m familiar with Launch Services on Mac OS X, but not with a resetting procedure. -- Darin ___ webkit-de

[webkit-dev] Which MIME type is best for JavaScript in WebKit?

Three regression tests are failing on one of my Macs. For local .js files I am getting the MIME type text/javascript and the tests expect application/x-javascript. I don’t know why I am getting different results on my computer than on, say, buildbots running the same version of Mac OS X. And al

Re: [webkit-dev] Question regarding priorities of subresource content retrieval

This thread is wrong for webkit-dev. The discussion obliquely related to WebKit development and you are not yet contributors to the WebKit project yet. Could you please find somewhere else to discuss this? -- Darin ___ webkit-dev mailing list webk

Re: [webkit-dev] Proposal to Reorganize Position Classes

On Feb 1, 2011, at 6:51 PM, Ryosuke Niwa wrote: > • DOMPosition or SimplePosition - This class solely works on DOM, and > is agnostic of renderers and other parts of WebCore. It's meant to be used > in utility functions and classes or passed along between renderers and > WebCore/dom. It

Re: [webkit-dev] coding style and comments

On the WebKit project we like “why” comments, but not “what” comments. Comments that say what the next block of code does usually are not a good idea. Instead by using appropriate names and granularity we want the code itself to say what the comment would have. We also frown on “textbook” style

Re: [webkit-dev] How can I view an JSObject via Xcode's debugger?

On Jan 25, 2011, at 10:03 AM, Frederick C. Lee wrote: > I'm a JavaScript/WebKit <-->ObjC/Cocoa neophyte, snooping within an > ObjC/Cocoa program's webView looking for the actual HTML/JavaScript text for > study: This is the wrong mailing list for this kind of help request. As described here

Re: [webkit-dev] beforeload & link (esp rel prefetch)

On Jan 20, 2011, at 5:52 PM, Gavin Peters (蓋文彼德斯) wrote: > [2] I just installed Incognito mode in a local Safari, and sniffed it. I can > confirm requests to blocked domains go straight through; with cookies, > everything. The only place you won't see them is in the document, the DOM & > the Sa

Re: [webkit-dev] make-script-test-wrappers not being maintained

On Jan 18, 2011, at 11:28 PM, Maciej Stachowiak wrote: > Off-topic, but... we really should change the script to use the HTML5 doctype. As you may recall, the script uses a per-directory TEMPLATE.html file. Those can be changed to the HTML5 doctype one directory at a time as long as the person

Re: [webkit-dev] make-script-test-wrappers not being maintained

On Jan 18, 2011, at 4:49 PM, Ojan Vafai wrote: > On Tue, Jan 18, 2011 at 4:46 PM, Simon Fraser wrote: > It would be good if the generated HTML had a big in it. > > I agree this would be valuable. We should do it. > If you need a non-standard wrapper, don't put the JS file in the script-tests

Re: [webkit-dev] make-script-test-wrappers not being maintained

On Jan 18, 2011, at 4:36 PM, James Robinson wrote: > What are the advantages of using it vs generating script tests in other ways? The concept is that you write a script test and the wrapper is automatically generated. The advantage is that you don’t have to write the wrapper yourself. The long

Re: [webkit-dev] make-script-test-wrappers not being maintained

On Jan 18, 2011, at 4:43 PM, Ryosuke Niwa wrote: > What kind of diffs you're getting for the wrappers? All kinds. Most are some small difference between the template and the generated wrapper. An HTML5 DOCTYPE instead of the one in the wrapper. A different relative path that goes up one level f

[webkit-dev] make-script-test-wrappers not being maintained

It seems that a lot of people are making script tests with non-standard wrappers. And not adding exceptions to the make-script-test-wrappers script. I ran the script and it created 4 files, and modified 33 others. Any ideas on how to improve the situation? -- Darin

Re: [webkit-dev] [Mac] Pixel test passed but the text dump differs.

On Jan 10, 2011, at 11:05 AM, Jia Pu wrote: > I just noticed that there're a few spelling correction tests are failing on > TOT on mac. The pixel tests still pass, but the text dump are different. More > specifically, all the differences are on numeral value in the phrase > "#document toDOMRang

Re: [webkit-dev] EventListener Invocation Cost?

On Jan 9, 2011, at 11:56 AM, Alex Milowski wrote: > I'm not sure there is a lot that can be done about it. I’m sure we can speed it up if we have a reason to. Step one is to find out exactly where the time is spent. Then we figure out ways to streamline the code path. The experts on this may no

Re: [webkit-dev] RuntimeEnabledFeatures for JSC (was RE: Getting at Settings object from WorkerContext)

On Jan 6, 2011, at 12:41 PM, Joe Mason wrote: > I took a look at CodeGeneratorJS.pm to see how hard it would be to port this > over. I have no idea where to start… The structure of CodeGeneratorJS.pm and > CodeGeneratorV8.pm seem quite different. This also seems like a lot of work > to do just

Re: [webkit-dev] libxml2 "override encoding" support

On Jan 5, 2011, at 8:38 AM, Patrick Gansterer wrote: > Darin Adler: > >> On Jan 5, 2011, at 5:07 AM, Patrick Gansterer wrote: >> >>> Is there a reason why we can't pass the "raw" data to libxml2? >> >> Because libxml2 does its own en

Re: [webkit-dev] Best way to track feature evolution from release-to-release

On Jan 5, 2011, at 7:06 AM, Tom Bahnck wrote: > If my understanding is correct wrt to Apple's release process, when given the > chance, Apple tags the WebKit trunk under the name "Safari-###" in the /tags > directory. This contains all source from the WebKit trunk, including > tools/bugzilla/te

Re: [webkit-dev] libxml2 "override encoding" support

On Jan 5, 2011, at 5:07 AM, Patrick Gansterer wrote: > Is there a reason why we can't pass the "raw" data to libxml2? Because libxml2 does its own encoding detection which is not even close to what’s specified in HTML5, and supports far fewer encodings. If you make a test suite you will see. O

Re: [webkit-dev] Best way to track feature evolution from release-to-release

On Jan 4, 2011, at 1:47 PM, Tom Bahnck wrote: > We are looking for the best way to identify the supported syntactical > elements in each release, such as HTML/CSS tags/properties/values. Eric > Seidel's excellent lecture on the Google code channel points out that the > /WebCore/dom/*.idl /WebCo

Re: [webkit-dev] Handling of feature dependencies

On Jan 4, 2011, at 2:59 AM, Konstantin Tokarev wrote: > 03.01.2011, 23:58, "Darin Adler" : >> On Jan 3, 2011, at 12:53 PM, Konstantin Tokarev wrote: >> >>> I'd like to get WebKit running on device with very limited resources. >>> Basically, it w

Re: [webkit-dev] Handling of feature dependencies

On Jan 3, 2011, at 12:53 PM, Konstantin Tokarev wrote: > I'd like to get WebKit running on device with very limited resources. > Basically, it would be quite enough if resulting "browser" just properly > displayed HTML 4 + CSS 2.1, and it would be highly desired to reduce size of > binaries and

Re: [webkit-dev] Handling of feature dependencies

On Dec 30, 2010, at 2:37 AM, Konstantin Tokarev wrote: > What is the right way to handle dependencies between features set in time of > configuration? > > For example, I'd like to shrink some functionality ("feature B") in embedded > browser, and therefore add option --[no]-B flag to build-webk

[webkit-dev] Fixing Qt and Chromium builds

To fix Qt I need to add includes of ExceptionCode.h to two source files. To fox Chromium I have to figure out why my code change to not use defaultChecked seems to have been ineffective. I will be able to deal with these in an hour or so. If someone else can do so sooner that would be great. I

Re: [webkit-dev] More thoughts on cleaning up the root directory

On Dec 27, 2010, at 11:14 AM, Adam Barth wrote: > On Mon, Dec 27, 2010 at 10:37 AM, Mark Rowe wrote: >> Can someone also elaborate on why "Sources" was chosen as the top-level >> directory name rather than "Source"? "Source code" is a mass noun so it's >> unclear why the abbreviated form of "so

[webkit-dev] webkitpy test failures on GTK bots

Hi folks. The GTK bots have been red for a while now; not sure whether it’s been days or weeks. These are core builders, so should not be red for that long. Apparently the issue is that some Python tests can’t be run because there’s a Google python module of some sort that must be installed. Co

Re: [webkit-dev] Moving WTF out of JavaScriptCore

On Dec 24, 2010, at 9:51 AM, Eric Seidel wrote: > I guess all of those could move into Sources/Scripts if Sources becomes the > single directory which is submitted to Apple's build team. I see what you mean. Good point. I don’t think we really need to outlaw tools required for the building proc

Re: [webkit-dev] Moving WTF out of JavaScriptCore

On Dec 24, 2010, at 12:37 AM, Eric Seidel wrote: > There may end up being some fancy foot-work in your submission script to > include parts of Tools. No, we don’t submit anything in Tools as part of Apple build procedures. What did you have in mind? -- Darin __

Re: [webkit-dev] Plan to move TypedArray out of WebGL feature guard

On Dec 23, 2010, at 2:04 PM, Chris Marrin wrote: > How would we go about feeling comfortable about the security risk? The point isn’t the security risk, but rather the security risk with no benefit. It’s OK to make this class unconditional unless there is someone planning to ship WebKit that ha

Re: [webkit-dev] Plan to move TypedArray out of WebGL feature guard

On Dec 23, 2010, at 11:21 AM, Jian Li wrote: > We do not add an additional check expression when TypedArray is added to XHR. Is the TypedArray support in XHR a feature in its own right? Should it be off by default or is it ready to be on for all versions of WebKit? -- Darin ___

Re: [webkit-dev] Plan to move TypedArray out of WebGL feature guard

On Dec 23, 2010, at 11:17 AM, Chris Marrin wrote: > Is there any reason for it NOT to be unguarded? If this was used in any unconditional feature we wouldn’t need this discussion. Generally speaking we don’t want to put new DOM classes into WebKit that are there to support new features if the f

Re: [webkit-dev] Plan to move TypedArray out of WebGL feature guard

Yes, we want correct conditionals, and TypedArray should not be in the WebGL feature guard if it’s used in other features. Adding a feature new guard would not be good if it has to be set explicitly. It would be much better if the build just decided correctly based on the other feature guards.

Re: [webkit-dev] WebKitBuild tab completion

On Dec 22, 2010, at 4:33 PM, k...@inf.u-szeged.hu wrote: > I believe that the WebKitBuild/Build renaming would make our life much easier > (because of tab-completion) so please don't forget about that when the time > arrives for the Grand Renaming Day. Understood. You can fix the WebKitBuild t

Re: [webkit-dev] Ports that use the checked-in image decoders

On Dec 22, 2010, at 2:59 PM, Eric Seidel wrote: > both Apple's Windows port and Chromium's windows port use the checked-in > image decoders I believe that’s incorrect. The WebKit that comes with Safari on Windows uses image decoders from an Apple DLL, not the checked-in ones. The image decoder

Re: [webkit-dev] Renaming directories

On Dec 21, 2010, at 11:20 PM, Adam Barth wrote: > Looking through my working copy, there are a couple of things that aren't > obvious to me where they would go in this structure: WebKitBuild and > WebKitLibraries. Maybe these would become Build and Libraries as top-level > directories? WebKitB

Re: [webkit-dev] Renaming directories

Here’s my attempt to list the tests we currently have: - Automated regression tests (from LayoutTests directory). Many different types: Layout/pixel, text, script-tests, ref-tests coming soon, some requiring local server, some JavaScript only. Better organization needed. Need to replace old

Re: [webkit-dev] Renaming directories

Before we move LayoutTests, we might want to discuss further changes to structure. Mark Rowe and I talked about this briefly and he suggested a top level with just: Examples Sources Tests Tools Websites And perhaps one or two files. Maybe Makefile. For Apple internal purpo

Re: [webkit-dev] Renaming directories

On Dec 19, 2010, at 3:22 AM, Mark Rowe wrote: > My 2¢: Add a top-level Sites directory and then do the following: > WebKitSite => Sites/webkit.org > BugsSite => Sites/bugs.webkit.org > PlanetWebKit => Sites/planet.webkit.org Yes, that seems great. If it was me I would use Websites instead of Site

Re: [webkit-dev] Renaming directories

On Dec 18, 2010, at 2:23 AM, Adam Barth wrote: > While we're in the mood to rename directories, would these renamings make > sense: > > WebKitSite => WebSite > WebKitExamplePlugins => ExamplePlugins > LayoutTests => Tests I would use Website rather than We

Re: [webkit-dev] Question about StringImpl::create

On Dec 16, 2010, at 10:36 PM, Gavin Barraclough wrote: > The short answer is that String::format should be considered deprecated - its > behavior is platform-specific, and we'd like to move away from it. We should probably put a comment in WTFString.h that says something along these lines.

Re: [webkit-dev] Potential patch for building webkit on Visual Studio 2010

On Dec 15, 2010, at 10:00 AM, Jean-Luc Brouillet wrote: > if this broader discussion should also be done within the bug tracking system. Yes, this discussion belongs in a bug. I have some comments on it, and a particular specific suggestion for the short term fix. I am waiting for someone to ma

Re: [webkit-dev] Potential patch for building webkit on Visual Studio 2010

On Dec 14, 2010, at 5:24 PM, Jake wrote: > And secondly I changed all = 0 errors to = nullptr (approximately 450 > instances). We should look for another way to make things compile with Visual Studio 2010 that does not require this. -- Darin ___

Re: [webkit-dev] how to extend self-defined javascript in webkit using v8 on android

This mailing list is for discussion of development of WebKit, not development of software that uses WebKit. This webpage lists some other mailing lists and resources that may be appropriate for WebKit use questions. -- Darin

[webkit-dev] Looking for a V8 bindings volunteer to fix setLocation, open, and showModalDialog

Hi folks. I’m moved the logic of setLocation, open, and showModalDialog out of the JavaScript bindings and into the DOMWindow class. http://trac.webkit.org/changeset/73647 http://trac.webkit.org/changeset/73660 http://trac.webkit.org/changeset/73829 I was hoping to find a volunteer to change th

Re: [webkit-dev] Rebaselining render tree dumps

On Dec 10, 2010, at 2:05 PM, Ryosuke Niwa wrote: > If Ahem allows us to have the same pixel expected results for all platforms. > Why don't we switch the default font of DRT to Ahem? Ahem is a testing font where characters are all boxes. It’s quite useful for testing text layout that involves

Re: [webkit-dev] Looking for information on how to access certain functionality with python.

This is not a list for getting help using WebKit. It’s for discussion development of WebKit. This page mentions other lists that might be appropriate for a question like this. -- Darin ___ webkit-dev mailing list w

Re: [webkit-dev] Pixel tests and displaying text

On Dec 8, 2010, at 1:23 PM, Simon Fraser wrote: > On Dec 8, 2010, at 12:57 PM, Darin Adler wrote: > >> On Dec 8, 2010, at 12:13 PM, Peter Kasting wrote: >> >>> We could greatly decrease the number of these baselines by following a >>> simple rule: d

Re: [webkit-dev] Pixel tests and displaying text

On Dec 8, 2010, at 1:02 PM, Peter Kasting wrote: > the number of tests that fall into this bucket is hopefully small? Maybe we should talk about some specific tests. I can‘t think of many tests with no text that are self explanatory! -- Darin ___

Re: [webkit-dev] Pixel tests and displaying text

On Dec 8, 2010, at 12:13 PM, Peter Kasting wrote: > We could greatly decrease the number of these baselines by following a simple > rule: don't display text unless you need to. Seems like a good idea. I’m worried a bit, though, that if we can’t use any text in them at all, the tests are then no

[webkit-dev] Why do both DOMWindow and Document objects hold SecurityOrigin objects?

Why does both a DOMWindow and a Document hold a securityOrigin? Is there a way we can get rid of one or the other? Are the two equivalent, or is there a difference? Is there a time when it’s correct to do frame->domWindow()->securityOrigin() and incorrect to do frame->document()->securityOrigin

Re: [webkit-dev] style-queue

On Dec 7, 2010, at 11:09 AM, Eric Seidel wrote: > Sorry about the recent noise from the style queue. Its git repo got > corrupted. Adam and I are working on getting to the machine and resetting its > git repo. Is there a way to stop the noise in the meantime? I’ve received many more email mess

[webkit-dev] Better approach for JavaScript bindings, especially for the DOM window object

Hi folks. I recently noticed that far too much of the logic for the DOM window object is in the JavaScript bindings rather than in the DOM implementation of the window object itself. I also see efforts to make a “generic” binding that is currently used mostly for V8 only but seems intended for

Re: [webkit-dev] Bools are strictly worse than enums

On Dec 4, 2010, at 3:01 PM, Maciej Stachowiak wrote: > Passing a true or false literal (at least in cases where it's not the sole > argument) is a likely indicator of unclear style, as opposed to taking a > boolean argument. Agreed. > In fact, even putting a boolean literal in a named variable

Re: [webkit-dev] Bools are strictly worse than enums

On Dec 3, 2010, at 1:37 PM, David Hyatt wrote: > The only exception I would make to this rule is if all the call sites use > variables and never pass in raw true or false. In that case there's no loss > of readability, and whether you use an enum vs. a bool is irrelevant. That’s right. There ar

Re: [webkit-dev] Webkit-Javascript-Objc problem

This is the wrong mailing list for this question. This is a question for discussion of the development of WebKit, not discussion of programming with WebKit. This page lists some options and places you might ask this question. If you suspect this is a bug and wan

Re: [webkit-dev] Constant readonly

On Nov 22, 2010, at 2:41 AM, Mario Bensi wrote: > I tested if the constant in idl was readonly, like that : > > var node = document.getElementById('console'); > alert(node.ELEMENT_NODE); > node.ELEMENT_NODE = 666; > alert(node.ELEMENT_NODE); > > And it's strange, I can change ELEMENT_NODE value.

Re: [webkit-dev] Hunspell based spellchecker

On Nov 17, 2010, at 10:49 PM, Hajime Morita wrote: > In other word, we should make sure that TextChecker interface can have > subclasses both inside and outside WebCore. Yes, in this model the abstract base class inside WebCore will need a derived class inside Windows WebKit that then in turn c

Re: [webkit-dev] Hunspell based spellchecker

Safari on Windows provides a spelling checker outside of WebKit. If we change the way spelling checking is organized inside WebKit, we need to preserve that feature in the WebKit used by Safari on Windows. -- Darin ___ webkit-dev mailing list webk

<    1   2   3   4   5   6   7   8   9   10   >